Akshay Joshi
9110703aaa
Fix 'Could not find the object on the server.' error while refreshing the check constraint. Fixes #4966 .
2019-12-03 14:18:45 +05:30
Aditya Toshniwal
0a67b2ecb9
Added aria-label to provide an invisible label where a visible label cannot be used. Fixes #4772 .
2019-12-03 12:47:42 +05:30
Khushboo Vashi
d476343b99
Enhance the logic to change the label from 'Delete/Drop' to 'Remove' for the server and server group node. Fixes #4923
2019-12-03 11:52:02 +05:30
Akshay Joshi
d95e8db4ee
Fix an issue of retrieving properties for Compound Triggers. It's a regression of #4006 . Fixes #4952 .
2019-12-02 15:01:54 +05:30
Rahul Shirsat
d98e86d3df
Warn the user on changing the definition of Materialized View about the loss of data and its dependent objects. Fixes #4396
2019-12-02 11:25:51 +05:30
Akshay Joshi
4fa1bdba5a
1) Refactored code of columns node. Fixes #4938 .
...
2) Fix an issue where length and precision are not removed from table/column dialog. Fixes #4964 .
3) Fix an issue where the Interval data type is not displayed in the properties dialog of table/column. Fixes #4965 .
4) Fix an issue where the wrong type is displayed when changing the datatype from timestamp with time zone to timestamp without time zone. Fixes #4761 .
5) Change the label from 'Length and Precision' to 'Length/Precision and Scale' for columns.
6) The maximum length for datatype like interval, timestamp with time zone, time with time zone, etc.. is 6. Set the max length to 6 instead of 10.
2019-11-28 18:48:53 +05:30
Aditya Toshniwal
4ed2d74d9c
1) Fix network disconnect issue while establishing the connection via SSH Tunnel and it impossible to expand the Servers node. Fixes #4724 .
...
2) Fix server connection drops out issue in query tool. Fixes #4818
3) Fix VPN network disconnect issue where pgAdmin4 hangs on expanding the Servers node. Fixes #4926 .
4) Ensure that the Servers collection node should expand independently of server connections. Fixes #4933 .
Set the default connection timeout to 10 seconds instead of 0.
2019-11-26 09:04:41 +05:30
Rahul Shirsat
1a39dedc62
Add Reverse Engineered and Modified SQL tests for Materialized Views. Fixes #4696 .
2019-11-25 11:11:09 +05:30
Akshay Joshi
de878b3198
Refactored code of table and it's child nodes.
...
1) Remove duplicate logic.
2) Child node specific logic should be inside the child node and table node gets the required information from the respective child node.
Note:- Refactoring of columns node still in progress.
Fixes #4807
2019-11-15 14:45:55 +05:30
Akshay Joshi
7282e15ee2
Fixed API and RESQL test cases for Compound Trigger after the recent changes in EPAS 12.
...
EPAS 12 Changes:
Fix server crash when the compound trigger has both row and statement-level triggers having
WHEN clause containing NEW/OLD vars.
2019-11-11 17:22:50 +05:30
Aditya Toshniwal
8180403f97
1) Added support for custom theme creation and selection. Fixes #4348 .
...
2) Added Dark(Beta) UI Theme option. Fixes #3741 .
3) Fix an issue where a black arrow-kind image is displaying at the background of browser tree images. Fixes #4171
Changes include:
1) New theme option in preferences - Miscellaneous -> Themes. You can select the theme from the dropdown.
It also has a preview of the theme just below the dropdown. Note that, a page refresh is needed to apply changes.
On saving, a dialog appears to ask for refresh.
2) You can create your own theme and submit to hackers. README is updated to help you create a theme. Theme will be available only after the bundle.
3) Correction of SASS variables at few places and few other CSS corrections.
4) Added iconfont-webpack-plugin, which will convert all the SVG files(monochrome) used as icons for buttons to font icons.
This will allow us to change the color of the icon by using CSS color property.
5) All the .css files will bundle into a separate file now- pgadmin.style.css. This will help reduce the size of
theme CSS files as CSS in .css files will not change with the change of SASS variables.
2019-11-07 18:51:03 +05:30
Aditya Toshniwal
080ccdda5b
Remove arbitrary (and incorrect) requirement that composite types must have at least two members. Fixes #4451
2019-11-01 15:21:59 +00:00
Aditya Toshniwal
f8e0b54836
Ensure comments are shown in reverse engineered SQL for table partitions. Fixes #4191
2019-11-01 11:58:38 +00:00
Aditya Toshniwal
131a944e24
Support Enable Always and Enable Replica on triggers. Fixes #4006
2019-11-01 11:49:17 +00:00
Aditya Toshniwal
4125360dfb
Ensure the correct "running at" agent is shown when a pgAgent job is executing. Fixes #3913
2019-10-25 11:39:40 +01:00
Aditya Toshniwal
02642628b0
Added encrypted password in reverse engineered SQL for roles. Fixes #1974 .
2019-10-23 13:16:36 +05:30
Akshay Joshi
2790689d26
1) Fix issue where validate switch for the foreign key is enabled from table dialog even if the key is validated.
...
2) Fix issue where validate the foreign key from the table dialog, rename the foreign key constraint to none.
2019-10-14 18:19:32 +05:30
Akshay Joshi
c3e11bd390
Fix issue where VALID foreign keys show as NOT VALID in the SQL tab for tables.
...
Corrected the condition for valid foreign key.
Fixes #4791
2019-10-10 18:55:13 +05:30
Aditya Toshniwal
f16498a8a7
Optimize Webpack to improve overall performance.
...
Changes include:
1) Remove underscore-string and sprintf-js packages as we were using only %s. Instead, added a function to do the same. Also changed gettext to behave like sprintf directly.
2) backgrid.sizeable.columns was not used anywhere, removed. @babel/polyfill is deprecated, replaced it with core-js.
3) Moved few css to make sure they get minified and bundled.
4) Added Flask-Compress to send static files as compressed gzip. This will reduce network traffic and improve initial load time for pgAdmin.
5) Split few JS files to make code reusable.
6) Lazy load few modules like leaflet, wkx is required only if geometry viewer is opened. snapsvg loaded only when explain plan is executed. This will improve sqleditor initial opening time.
Reviewed By: Khushboo Vashi
Fixes #4701
2019-10-10 12:05:28 +05:30
Akshay Joshi
55c6fa0d93
Fix an error where 'false' string is displayed when we add a new parameter in the Parameters tab,
...
also clear the old value when the user changes the parameter name.
Corrected the implementation of BooleanCellFormatter.
Fixes #4753
2019-10-07 16:00:28 +05:30
Akshay Joshi
7489c372e5
The search path should not be quoted while setting as a parameter, if it is
...
quoted then that string considers to be a single schema.
Quoting not added for the 'search_path' parameter.
Fixes #4760 , #4780
2019-10-07 12:28:00 +05:30
Akshay Joshi
bf2c001c87
Export job fails when deselecting all the columns.
...
Select2 parameter 'first_empty' should be set to false for the controls of type array.
If it is true then on deselecting/clearing all the values, an empty entry is still there.
Fixes #4751
2019-10-04 13:00:39 +05:30
Akshay Joshi
c54017eac5
Add Reverse Engineered and Modified SQL tests for Synonyms. Fixes #4472
2019-09-24 18:33:07 +05:30
Akshay Joshi
faa6236580
Add Reverse Engineered and Modified SQL tests for Unique Constraints. Fixes #4628
2019-09-20 12:12:01 +05:30
Akshay Joshi
426d9d5872
Fix SQL issue of length and precision when changing the data type of Column. Fixes #4698
2019-09-16 18:57:57 +05:30
Khushboo Vashi
aa668856f7
1) Add Reverse Engineered and Modified SQL tests for Primary Keys. Fixes #4624 .
...
2) Ensure Primary Key should be created with Index. Fixes #4742 .
2019-09-16 12:05:29 +05:30
Murtuza Zabuawala
d923dcf98b
Added MSQL test cases for Roles.
2019-09-16 11:41:48 +05:30
Akshay Joshi
f5a6df4ddb
Fix issue where EXEC script doesn't write the complete script for Procedures. Fixes #4727
2019-09-13 16:58:25 +05:30
Akshay Joshi
da553eec9b
Ensure port and username should not be mandatory when a service is provided. Fixes #4642
2019-09-13 11:54:16 +05:30
Akshay Joshi
7944e75695
Ensure sequence with negative value should be created. Fixes #4726
2019-09-12 14:18:30 +05:30
Akshay Joshi
6a931588aa
1) Add Reverse Engineered and Modified SQL tests for Foreign Keys. Fixes #4616
...
2) Fix issue where Validated switch option is inverted for the Foreign Key. Fixes #4412
2019-09-11 15:59:13 +05:30
Nagesh Dhope
db06dd0275
Add msql tests for FTS Dictionaries
2019-09-06 16:00:33 +01:00
Nagesh Dhope
9f26e7ed20
Added MSQL test cases for Extension.
2019-09-06 16:28:41 +05:30
Akshay Joshi
8e4e8b3e5a
1) Add Reverse Engineered and Modified SQL tests for Indexes. Fixes #4621
...
2) Fix modified SQL for Index when reset the value of Fill factor and Clustered?. Fixes #4702
3) Fix reversed engineered SQL for btree Index when provided sort order and NULLs. Fixes #4703
2019-09-06 14:10:46 +05:30
Akshay Joshi
9eff2e9926
Modified RE-SQL/MSQL test cases of foreign tables for EPAS 9.4 and 9.5
2019-09-05 12:01:03 +05:30
Akshay Joshi
5e54f20578
Add Reverse Engineered and Modified SQL tests for Foreign Tables. Fixes #4618 .
2019-09-04 18:33:07 +05:30
Ganesh Jaybhay
85baa22ca1
Added Modified SQL test cases for FTS Configurations.
2019-09-03 17:42:44 +05:30
navnath gadakh
4690700a24
Added Modified SQL test cases for Packages.
2019-09-03 17:33:57 +05:30
Akshay Joshi
4745ad56e9
1) Add Reverse Engineered and Modified SQL tests for Foreign Servers. Fixes #4617
...
2) Add Reverse Engineered and Modified SQL tests for User Mappings. Fixes #4627
2019-09-03 16:27:41 +05:30
Shubham Agarwal
a0f6e5272a
Add MSQL test cases for FTS Parser.
2019-09-03 10:28:11 +05:30
Murtuza Zabuawala
eeeb350ed2
Add Modified SQL tests for Resource Group. Fixes #4690
2019-09-03 10:18:09 +05:30
Akshay Joshi
5ff3f40116
Add Reverse Engineered and Modified SQL tests for FTS Templates. Fixes #4619
2019-09-02 15:24:41 +05:30
Akshay Joshi
662266a367
Added MSQL test cases for Cast and Language.
2019-09-02 14:11:59 +05:30
Neel Patel
0ca65d7cfe
Added MSQL test cases for Domain.
2019-09-02 11:52:19 +05:30
Akshay Joshi
e0c53e7d1d
Add Reverse Engineered SQL tests for Schemas. Fixes #4575
2019-08-29 18:32:08 +05:30
Aditya Toshniwal
d6da1cf25c
Added MSQL test cases for Sequences and cover missing ACL RE-SQL test cases.
2019-08-29 14:15:34 +05:30
Usman Muzaffar
ac298b03c0
1) Add Reverse Engineered SQL tests for Views. Fixes #4576
...
2) Ensure View should be created with special characters. Fixes #4486
2019-08-28 12:48:59 +05:30
Akshay Joshi
28b741a13a
Fixed timezone issue in RE-SQL test cases for Roles.
2019-08-27 19:54:30 +05:30
Murtuza Zabuawala
1ddc9cc889
Modified RE-SQL test to cover Password, Account Expire, Connection Limit and Variables for Roles.
2019-08-26 18:25:48 +05:30
Aditya Toshniwal
53ab4d7e8d
Fix an error that could be seen when click on any system column of a table. Fixes #4577
2019-08-26 14:36:07 +05:30
Akshay Joshi
232fe286ee
Fix SQL tab issue for Views. It's a regression of compound triggers. Fixes #4650
2019-08-23 10:22:20 +05:30
Neel Patel
dc64ce331a
Fix length and precision enable/disable issue when changing the data type for Domain node. Fixes #4644 .
2019-08-21 16:27:23 +05:30
Akshay Joshi
094e5577e8
Add Reverse Engineered SQL tests for Rules. Fixes #4600
2019-08-21 16:06:05 +05:30
Akshay Joshi
41e2a674e3
Fix Truncate option deselect issue for compound triggers. Fixes #4643
2019-08-20 17:09:26 +05:30
Akshay Joshi
f3e4721a90
Added missing file for function selectivity feature. Fixes #4333
2019-08-20 10:02:43 +05:30
Akshay Joshi
0d6f07a035
1) Ensure compound triggers should be displayed under Views. Fixes #4638 .
...
2) Ensure Truncate option should be available for Compound Triggers. Fixes #4641 .
2019-08-20 09:39:31 +05:30
Akshay Joshi
24f9f65b1b
Ensure compound triggers for event should be updated properly. Fixes #4635
2019-08-17 15:58:50 +05:30
Murtuza Zabuawala
3f541200d9
Add Reverse Engineered SQL tests for Columns. Fixes #4546
2019-08-16 17:36:13 +05:30
Akshay Joshi
4403f326e9
Fix PEP8 issue
2019-08-12 14:41:22 +05:30
Akshay Joshi
35bbee3023
Fix generation of reverse engineered SQL for Rules. Fixes #4586
2019-08-12 14:27:02 +05:30
Aditya Toshniwal
1281f5cd6c
Fix console error when changing kind(SQL/BATCH) for pgAgent job step. Fixes #4582
2019-08-08 18:43:38 +05:30
Akshay Joshi
350ffcce7c
1) Add support of Compound Triggers for EPAS 12+. Fixes #4144 .
...
2) Ensure enable trigger menu should be visible when trigger is disabled. Fixes #4578 .
2019-08-08 16:59:11 +05:30
Dave Page
8331f62e1c
Fix PEP-8 issue.
2019-08-08 10:09:28 +01:00
Khushboo Vashi
c29275011a
Ensure the comment on a Primary Key constraint can be edited under the Table node. Fixes #4581
2019-08-08 09:52:10 +01:00
Akshay Joshi
7f53e13aa7
Fix generation of reverse engineered SQL for partition table, partitions were shown as a child of indexes. Fixes #4414
2019-08-07 17:49:13 +05:30
Dave Page
3a5464b278
Display the row count in the popup message when counting table rows, not just in the properties list. Fixes #4574
2019-08-07 11:17:57 +01:00
Aditya Toshniwal
4067d65a30
Improve test messages
2019-08-07 10:17:34 +01:00
Aditya Toshniwal
9cdb3b40ab
Add Reverse Engineered SQL tests for Trigger Functions. Fixes #4554
...
Fix the reverse engineered SQL for trigger functions with the WINDOW option selected. Fixes #4565
2019-08-06 14:26:11 +01:00
Khushboo Vashi
f8afe2ef94
Add Reverse Engineered SQL tests for Exclusion Constraint. Fixes #4555
2019-08-05 16:25:55 +05:30
Akshay Joshi
537c27a58e
Use the full tab space for CodeMirror instances on dialogues where appropriate. Fixes #4540
2019-08-02 10:25:21 +01:00
Akshay Joshi
1ff007d1cb
Swap the Schema and Schemas icons and Catalog and Catalogs icons that had been used the wrong way around.
2019-08-01 11:39:49 +05:30
Akshay Joshi
2ef3080d0e
Add support for generated columns in Postgres 12+. Fixes #4334
...
Ensure columns can be created when they are IDENTITY fields with the CYCLE option enabled. Fixes #4496
Ensure purely numeric comments can be saved on new columns. Fixed #4497
2019-07-25 16:38:26 +01:00
Daniel Gustafsson
5b322d94e8
Fix generation of reverse engineered SQL for tables with Greenplum 5.x. Fixes #4179
2019-07-25 16:16:44 +01:00
Khushboo Vashi
adb5cd34bf
Add support for planner support functions in PostgreSQL 12+ functions. Fixes #4333
2019-07-25 16:09:37 +01:00
Nagesh Dhope
1813eca1ca
Add support for pre-condition SQL in RE-SQL testsuite,
...
and use it to ensure that the right extensions are installed for the
extension tests.
2019-07-22 09:44:17 +01:00
Khushboo Vashi
8168f623c4
Add Reverse Engineered SQL tests for Constraints. Fixes #4475
2019-07-17 13:25:08 +01:00
Akshay Joshi
ab87035658
pgAgent fixes:
...
"malformed array literal error when updating pgagent job". Fixes #4428
"Error when updating connection string in pgagent Jobs.". Fixes #4448
When user create a schedule using Create->Schedule dialog browser tree is not showing newly created node.
Properties tab showing same properties for all the created schedule.
Added validation in "pga_jobstep.js", throws error on browser when we modify step from the pgagent dialog and select the same node.
2019-07-15 15:54:57 +01:00
Aditya Toshniwal
d3ef1137d9
Add Reverse Engineered SQL tests for Sequences. Fixes #4469
2019-07-15 14:56:22 +01:00
Aditya Toshniwal
0b82a4ad92
Fix sequence reverse engineered SQL generation with quoted names on PG/EPAS 10+. Fixes #4470
2019-07-15 14:55:07 +01:00
Murtuza Zabuawala
f4453e33cc
Stabilise ordering of ACLs in Type RE-SQL tests to prevent random failures.
2019-07-15 14:48:22 +01:00
Shubham Agarwal
809e0682bd
Add Reverse Engineered SQL tests for FTS Parsers. Fixes #4471
2019-07-15 12:02:44 +01:00
Murtuza Zabuawala
1831c9e70a
Use ROLE consistently when generating RE-SQL for roles, not USER. Fixes #4446
2019-07-15 11:31:27 +01:00
Murtuza Zabuawala
1dcf46cc5f
Add Reverse Engineered SQL tests for Types. Fixes #4468
2019-07-15 10:25:04 +01:00
Neel Patel
88ab6db976
Add Reverse Engineered SQL tests for Domains. Fixes #4463
2019-07-12 14:39:49 +01:00
Khushboo Vashi
79e6f4c008
Add Reverse Engineered SQL tests for Collations. Fixes #4464
...
This also adds the ability to test the msql output in ALTER steps.
2019-07-12 14:37:00 +01:00
Navnath Gadakh
ce8a2bb266
Fix re-sql tests for packages on EPAS 9.4-9.6.
2019-07-12 11:32:29 +01:00
Akshay Joshi
29fd83dc6c
Fix dropping of pgAgent schedules through the Job properties. Fixes #3996
2019-07-12 10:37:41 +01:00
Akshay Joshi
ed01274f7b
Fix an error that could be seen when editing column privileges. Fixes #4389
2019-07-12 10:16:18 +01:00
Nagesh Dhope
379b92729a
Add Reverse Engineered SQL tests for FTS Dictionaries. Fixes #4460
2019-07-11 14:00:11 +01:00
Navnath Gadakh
28585110dd
Add Reverse Engineered SQL tests for Packages. Fixes #4456
2019-07-11 09:23:13 +01:00
Akshay Joshi
cdf655f7db
Add Reverse Engineered SQL tests for Languages. Fixes #4452
2019-07-11 09:20:01 +01:00
Nagesh Dhope
e6c067025c
Fixed resql test cases for Extensions specific to database servers.
2019-07-11 13:16:00 +05:30
Akshay Joshi
6c7e95a463
Added re_sql test cases for privileges in Foreign Data Wrappers
2019-07-10 17:57:11 +05:30
Ganesh Jaybhay
f7d6966d60
Add Reverse Engineered SQL tests for FTS Configurations. Fixes #4454
2019-07-09 17:02:55 +01:00
Nagesh Dhope
84b712a008
Add RE-SQL tests for Extensions. Fixes #4453
2019-07-09 13:23:26 +01:00
Akshay Joshi
f085460453
Remove some files which was committed by mistake.
2019-07-09 16:47:23 +05:30
Akshay Joshi
1a9d8f01aa
1) Ensure re_sql tests should not abort at the first failure, it should run all the test cases.
...
2) Added place holder for owner, so we won't need to create separate pg/ppas folder just because of change in the owner name.
2019-07-09 15:37:53 +05:30
Akshay Joshi
a17687e27c
Fix reverse engineered sql for Foreign Data Wrapper created on EPAS server in redwood mode. Fixes #4450
2019-07-09 12:21:13 +05:30
Dave Page
863f62f4d8
Use special characters in names for RE-SQL tests to exercise quoting.
2019-07-08 11:03:30 +01:00
Khushboo Vashi
7c38c1cb38
Fix small issue which is required to support the custom schema in re_sql test cases.
2019-07-08 12:33:31 +05:30
Akshay Joshi
11a3aa56be
Use different folders for pg vs. ppas RE-SQL tests. Fall back to the tests folder without a subdirectory if neither exist.
2019-07-05 14:40:51 +01:00
Aditya Toshniwal
ba32c98241
Add Reverse Engineered SQL tests for FDWs. Fixes #4441
2019-07-05 11:24:54 +01:00
Akshay Joshi
776884860e
Ensure parameter values are quoted when needed when editing roles. Fixes #4393
2019-07-04 15:00:29 +01:00
Akshay Joshi
bf1f9a4b07
Fix table icon issue when updating any existing field. Fixes #4437
2019-07-04 17:34:47 +05:30
Murtuza Zabuawala
588e3814d1
Add RE-SQL tests for Roles and Resource Groups. Fixes #4415
2019-07-03 14:38:29 +01:00
Dave Page
644624eabe
PEP-8 fixes.
2019-06-20 14:30:31 +01:00
Khushboo Vashi
c07e52b9de
Ensure that both columns and partitions can be edited at the same time in the table dialog. Fixes #4380
2019-06-20 13:37:36 +01:00
Dave Page
81752bb998
Remove additional "SETOF" included when generating CREATE scripts for trigger functions. Fixes #4362
2019-06-20 13:18:30 +01:00
Akshay Joshi
9e65c971a3
Add a framework for testing reversed engineered SQL and CRUD API endpoints. Fixes #4202
2019-06-18 14:28:25 +01:00
Aditya Toshniwal
402dfd07db
Change icons for table inheritance (icons by Chethana Kumar) Fixes #3174
...
Along with this, I have also fixed few other issues/icons found on the way:
1) Dependencies tab for inherited tables/foreign keys shows partial text (Fixes ##3994).
2) Dependencies tab for child partition table shows parent partition table as Function.
3) Dependencies tab for triggers shows trigger functions as plain functions.
4) Dependents tab for partitioned table shows the child partition tables as normal table instead for partitioned tables.
2019-06-17 10:36:30 +01:00
Akshay Joshi
04328b76ba
Fix syntax error for Default value of column. It is a regression of #4253
2019-06-13 18:04:43 +05:30
Akshay Joshi
d774a0ff67
Fix issue where property dialog of column should open properly for EPAS v12. Fixes #4343
2019-06-11 17:48:01 +05:30
Dave Page
6d52f2b911
Initial support for PostgreSQL 12. Fixes #4283 . Fixes #4288 . Fixes #4290 .
2019-06-10 14:24:45 +01:00
Aditya Toshniwal
7ff85903e4
Fix issue where reverse engineered SQL was failing for foreign tables, if it had = in the options. Fixes #4171
2019-06-10 12:15:12 +05:30
Aditya Toshniwal
8b9c50ee5c
Fix issue where new column should be created with Default value. Fixes #4235
2019-06-10 11:53:16 +05:30
Aditya Toshniwal
a588c2994d
1) Fix issue where SSH tunnel connection using password is failing, it's regression of Master Password. Fixes #4320
...
2) Fix some more issues related to SSH Tunnel(By: Akshay Joshi)
2019-06-05 12:07:24 +05:30
Akshay Joshi
6a7339bbe4
Fix syntax error while opening properties tab of functions and procedures inside packages.
2019-06-01 14:02:33 +05:30
Akshay Joshi
26c7d76d4f
Fix the issue of accessing the SQL for Views and Materialized Views. Regression of pluralisation of folder names. Fixes #4308
2019-05-31 11:02:37 +05:30
Aditya Toshniwal
dfa892d2a2
1. Added Master Password to increase the security of saved passwords. Fixes #4184
...
2. In server(web) mode, update all the saved server credentials when user password is changed. Fixes #3377
2019-05-28 12:00:18 +05:30
Akshay Joshi
90a45557b9
1. Fix syntax error when adding more than one column to the existing table. Fixes #4162
...
2. Fix syntax error when creating a table with a serial column. Fixes #4284
2019-05-27 13:09:11 +05:30
Sander Eikelenboom
ab5f35da8d
Fixed error on displaying table properties of a table partitioned by list having a default partition. Fixes #4262
2019-05-15 18:36:16 +05:30
Akshay Joshi
b7121bb2d2
1) Make folder name pluralise inside 'templates' folder and fix naming inconsistency.
...
2) Remove unwanted functions "module_js()" from the code.
3) Change naming convention for 'Roles' module.
2019-05-15 15:11:54 +05:30
Dave Page
4b421550d3
Stop using application/x-javascript as a mime type and use the RFC-compliant application/javascript instead. Fixes #4261
2019-05-15 09:44:57 +01:00
Dave Page
e53c2b1a5d
Ensure the treeview shows all sequences except those used to implement IDENTITY columns (which can be edited as part of the column). Show all if Show System Objects is enabled. Fixes #4154
2019-04-26 12:36:56 +01:00
Akshay Joshi
9b5a6e2bb7
Prevent duplicate columns being included in reverse engineered SQL for tables. Fixes #4163
2019-04-24 11:35:20 +01:00
Khushboo Vashi
ecded18333
Fix an issue where 'GRANT UPDATE' sql should be displayed for default sequence privileges. Fixes #4087
2019-04-22 12:24:47 +05:30
Khushboo Vashi
5452bff49e
Fixed 'Increment value cannot be empty' error for existing tables. Fixes #4160
2019-04-22 12:04:49 +05:30
Aditya Toshniwal
d96f453e7f
Fixed 'Location cannot be empty' error when open Tablespace properties. Fixes #4134
2019-04-18 12:31:35 +05:30
Aditya Toshniwal
024cfd2fab
1) Ensure that JSON strings as comments should be added properly for all the objects. Fixes #3582
...
2) Fixed alignment issue of columns in definition section of Index node. Fixes #4121
2019-04-12 15:07:07 +05:30
Khushboo Vashi
a9d964b5ca
1) Added support for Default Partition. Fixes #3938
...
2) Ensure that record should be add/edited for root partition table with primary keys. Fixes #4104
2019-04-11 13:25:24 +05:30
Akshay Joshi
9c3925e448
Ensure that parameters of procedures for EPAS server 10 and below should be set/reset properly. Fixes #4161
2019-04-10 13:22:52 +05:30
Murtuza Zabuawala
84ecffa4d9
Added recommended ESLinter checks. Fixes #4142
2019-04-05 13:07:43 +05:30
Dave Page
614c66940a
Add missing files.
2019-04-01 11:04:44 +01:00
Akshay Joshi
d286bada5c
Fix custom autovacuum configuration for Materialized Views. Fixes #4110
2019-04-01 09:47:17 +01:00
Akshay Joshi
61ff588c09
Fixed issue while fetching the view id for view/materialized view. Added schema name in where clause.
2019-03-30 13:20:31 +05:30
Aditya Toshniwal
55c6f5205d
Add some SQL updates to handle inherited column markers/comments that were missed in the previous commit.
2019-03-29 14:44:21 +00:00
Dave Page
4d45a3cb24
PEP-8 fixes.
2019-03-28 14:20:52 -04:00
Khushboo Vashi
97919d091a
Add support for IDENTITY columns. Fixes #4030
2019-03-28 13:13:43 -04:00
Aditya Toshniwal
8aaacdf96e
Include inherited column comments and defaults in reverse engineered table SQL. Fixes #2627
...
Include comment SQL for inherited columns in reverse engineered table SQL. Fixes #4037
Include inherited columns in SELECT scripts. Fixes #4058
2019-03-28 08:36:41 -04:00
Akshay Joshi
9c2ea3ca11
1) Ensure View/Materialized View node should be visible after updating any property. Fixes #4109
...
2) Updated the icon for Materialized View.
2019-03-26 14:12:47 +05:30
Akshay Joshi
a0010aac31
1) Ensure that sequence should be created with Privileges.
...
2) Updated the validation for blank values in Definition tab.
2019-03-25 14:29:43 +05:30
Akshay Joshi
212ca01506
Ensure sequences can be created with increment, start, minimum and maximum options set. Fixes #4100
2019-03-22 15:54:34 +00:00
Dave Page
ce073a2856
Fix SQL help for EPAS 10+, and refactor the URL generation code into a testable function. Fixes #4099
2019-03-22 14:09:24 +00:00
Akshay Joshi
48c5c39c5d
Ensure that parser should be set in FTS Configuration.
2019-03-20 20:21:58 +05:30
Akshay Joshi
5dd1472d6b
1) Fixed issue in Select2 Control, added undefined/null check.
...
2) Fixed the width of the delete cell.
2019-03-20 18:54:49 +05:30
Dave Page
906a4a845e
Update pycodestyle to 2.5.0. Allow newer versions so we can catch issues early.
2019-03-20 13:01:32 +00:00
Dave Page
7a271a34c6
Make the WHEN field a CodeMirror control on the Event Trigger dialogue. Fixes #4050
2019-03-15 10:35:47 +00:00
Dave Page
2e3475e06a
Fix the RE-SQL syntax for roles with a VALID UNTIL clause. Fixes #4081
2019-03-15 10:03:11 +00:00
Dave Page
69ec460b60
Fix naming inconsistency for the column and FTS parser modules. Fixes #1269
2019-03-14 16:52:42 +00:00
Khushboo Vashi
e4417229aa
Update all Python and JS dependencies. Fixes #4019
2019-03-14 15:11:16 +00:00
Dave Page
a9dad423f6
Fix the online help button on the resource group dialogue. Fixes #4052
2019-03-13 16:21:10 +00:00
Dave Page
cdc9ed678f
Enable the online help button on the index dialogue. Fixes #4053
2019-03-13 16:18:51 +00:00
Dave Page
ab9a3a57ad
Make the Query Tool history persistent across sessions. Fixes #4017
2019-03-13 13:37:34 +00:00
Khushboo Vashi
eb1db50f85
Avoid 'bogus varno' message from Postgres when viewing the SQL for a table with triggers. Fixes #3995
2019-03-12 10:13:31 +00:00
Dave Page
d7bf6ec69f
String review and subsequent cleanup
...
Ashesh Vashi
Abhilasha Narendra
Karen Blatchley
Susan Douglas
Dave Page
2019-03-05 14:08:16 +00:00
Dave Page
e5598038fa
Ensure size stats are prettified on the statistics tab when the UI language != English. Fixes #3096
2019-02-20 16:39:38 +00:00
Akshay Joshi
0aa93ac3ba
Fix alignment of Connection type toggle switch of pgagent. Fixes #3974
2019-02-13 13:03:44 +05:30
Dave Page
1fc66406f5
Don't embed docs and external sites in iframes, to allow the external sites to set X-FRAME-OPTIONS = DENY for security. Fxies #3985
2019-02-12 16:07:38 +00:00
Akshay Joshi
8f4d1f14f2
1) Fix alignment of import/export toggle switch. Fixes #3963
...
2) Remove unnecessary options for toggle switch which are already the default options.
2019-02-06 16:49:36 +05:30
Khushboo Vashi
4a75053514
Clean up the unwanted extended versions of Backform Switch controls.
...
The Bootstrap Switch Control was extended only for alignment in most
places. IIntroduce a configurable option to set the necessary class
on the main div and also remove the extra extended controls.
2019-02-05 16:22:35 +00:00
Aditya Toshniwal
d2ee5c4e82
1) Fixed jasmine test cases.
...
2) Bootstarp4 toggle size should be mini for triggers
2019-02-04 17:43:19 +05:30
Khushboo Vashi
dae8186c2a
Replace Bootstrap switch with Bootstrap4 toggle to improve the performance. Fixes #3051
2019-02-04 11:31:48 +05:30
Akshay Joshi
2afa3d8267
Remove icon for 'Refresh View' context menu of Materialized View and Added label for Definition control for consistency.
2019-01-31 13:20:44 +05:30
Khushboo Vashi
3b35aaa1d7
Fixed unable to drop multiple Rules and Foreign Tables from properties tab. Fixes #3899
2019-01-31 13:03:37 +05:30
Akshay Joshi
0bb4f005e5
Correct schema should be displayed in Materialized View dialog. Fixes #3916
2019-01-31 11:29:18 +05:30
Khushboo Vashi
406ada10f5
Fixed EXEC script for procedures. Fixes #3850
2019-01-23 14:44:24 +05:30
Akshay Joshi
11ab1918ea
Fixed domain sql regression test for EPAS
2019-01-22 18:22:16 +05:30
Khushboo Vashi
c6bae69b6f
Proper SQL should be generated when create domain of type interval with precision. Fixes #3853
2019-01-22 17:53:36 +05:30
Harshal Dhumal
ea87d6da8f
Fixed keyboard navigation for Select2 and Privilege cell in Backgrid Fixes #3908
2019-01-22 16:35:57 +05:30
Akshay Joshi
c7cbe0ff4a
Data should be updated properly for FTS Configurations, FTS Dictionaries, FTS Parsers and FTS Templates. Fixes #3897
2019-01-21 14:36:39 +05:30
Akshay Joshi
69f6895224
Proper SQL should be generated when create function with return type as custom type argument. Fixes #3774
2019-01-18 15:11:35 +05:30
Aditya Toshniwal
f779378e8a
Add right border on selected tree item.
2019-01-17 13:27:07 +05:30
Akshay Joshi
c1aba3e055
1) Proper SQL should be generated when creating/changing column with custom type argument. Fixes #3838
...
2) Proper SQL should be generated when create procedure with custom type arguments. Fixes #3846
2019-01-17 13:13:15 +05:30
Aditya Toshniwal
6bbcaf6b27
Fixed SQL for when clause while creating Trigger. Fixes #3837
2019-01-16 14:46:34 +05:30
Aditya Toshniwal
d7b0508305
Fixed SQL for foreign table options. Fixes #3453
2019-01-16 12:34:16 +05:30
Aditya Toshniwal
7ac4e2a9d9
Fixed following issues:
...
- Process watcher made fixed width with header changes, time details rounded to 2 decimals
- Query history will show "No query history" if no query fired. Query editor default size increased.
- Fixed a bug where New folder create button not working when in List mode and No files/folder present.
- Other minor improvements.
2019-01-16 11:55:08 +05:30
Aditya Toshniwal
2a359d9d77
Proper error should be thrown when server group is created with existing name. Fixes #3693
2019-01-15 18:38:01 +05:30
Akshay Joshi
252e05ef29
Fix SQL generated for tables with inherited columns. Fixes #3505
2019-01-11 21:50:02 +05:30
Akshay Joshi
01b87d4834
Don't show system catalogs in the schemas property list unless show system objects is enabled. Fixes #3842
2019-01-10 11:41:09 +05:30
Akshay Joshi
4e27bf989f
Display event trigger functions correctly on EPAS. Fixes #3549
2019-01-04 13:06:45 +00:00
Murtuza Zabuawala
e23d307c56
Update copyright notices for 2019
2019-01-02 15:54:12 +05:30
Aditya Toshniwal
86ecf9c84e
Fixed following:
...
- Base font size changed from 0.815rem to 0.875rem, for navbar from 0.875rem to 0.925rem.
- Dialog sizes made consistent throughout the application. Now there are 3 size options for width and height each - sm, md, lg. Combination of any of these to be used hereafter
- Alignment fix for controls of Node properties dialogs which includes showing text and label in one line without dialog size change, checkbox alignment, switch control alignment at places and other minor improvements in other dialogs
- Error message design change in dialogs validation
- SQL Editor data grid editor popup design changes which were missed
- Design change for dashboard server activity grid
- Login page language dropdown color fix
- Properties accordion collapse design fix
- Help, Info icon fixed across all dialogs which were not working if clicked exactly on the text
- Added missing icon with buttons at few places
- Shadow behind the dialogs is increased to make it look clearly separated and depth.
- Control Alignment fix in maintenance dialog
- Min height of alertify dialogs set for better UX
- File dialog design fix when no files found
- Grant wizard fixes - Scroll bar visibility on first page, use full space for SQL generated on the last page
- Browser toolbar buttons changed to sync with SQL editor toolbar buttons
- Rounded corners for docker floating dialog (no properties)
- Renaming file in file dialog should show original file name
- SQL data grid text edit popup buttons behaviour was swapped. This is fixed.
- Import/Export dialog changes as per new design.
2019-01-02 15:07:59 +05:30
Ashesh Vashi
5799ac14ba
Improvement in the look and feel of the whole application
...
Changed the SCSS/CSS for the below third party libraries to adopt the
new look 'n' feel:
- wcDocker
- Alertify dialogs, and notifications
- AciTree
- Bootstrap Navbar
- Bootstrap Tabs
- Bootstrap Drop-Down menu
- Backgrid
- Select2
Adopated the new the look 'n' feel for the dialogs, wizard, properties,
tab panels, tabs, fieldset, subnode control, spinner control, HTML
table, and other form controls.
- Font is changed to Roboto
- Using SCSS variables to define the look 'n' feel
- Designer background images for the Login, and Forget password pages in
'web' mode
- Improved the look 'n' feel for the key selection in the preferences
dialog
- Table classes consistency changes across the application
- File Open and Save dialog list view changes
Author(s): Aditya Toshniwal & Khushboo Vashi
2018-12-21 17:14:55 +05:30
Aditya Toshniwal
ffae65bdbe
Ensure table definitions include WHERE clauses on EXCLUDE constraints. Fixes #3726
2018-12-20 10:19:54 +00:00
Akshay Joshi
7515e08578
Fix an issue when user define Cast from smallint->text is created. Fixes #3753
2018-12-19 18:02:04 +05:30
Akshay Joshi
c973c3387e
Include the WHERE clause on EXCLUDE constraints in RE-SQL. Fixes #3726
2018-12-18 13:37:04 +00:00
Khushboo Vashi
dfbb2212c0
Prevent attempts to bulk-drop schema objects. Fixes #3797
2018-12-13 11:03:30 +00:00
Akshay Joshi
3cfc3366d7
Fixed the height and width of the Table dialog.
2018-11-21 18:41:03 +05:30
Akshay Joshi
8b5abdfa8f
Fix changes to the NOT NULL and default value options in the Table Dialogue. Fixes #3742
2018-11-20 16:29:20 +00:00
Akshay Joshi
9b0889842d
Fix dropping of multiple functions/procedures at once. Fixes #3746
2018-11-14 08:40:21 -05:00
Dave Page
628f0d254e
Fix resource group multi-drop test.
2018-11-01 08:54:33 +00:00
Dave Page
7dde5d52d0
Fix regression test.
2018-10-31 12:18:13 +00:00
Khushboo Vashi
e59eaedfd0
Fix buildfarm failures.
2018-10-31 11:35:13 +00:00
Khushboo Vashi
f17979141c
Add support for dropping multiple objects at once from the collection Properties panel. Fixes #1513
2018-10-31 10:30:37 +00:00
Akshay Joshi
696fbfb8b9
Fix CREATE Script functionality for EDB-Wrapped functions. Fixes #3676
2018-10-29 11:54:11 +00:00
Akshay Joshi
50738db2b8
Fix syntax error when creating new pgAgent schedules with a start
...
date/time and exception. Fixes #3638
- Fixed syntax error.
- Update/Delete exceptions are not working, SQL is wrong.
- Wrong exception time is shown, it should shown in UTC as datatype of
the column is timestamp with out timezone.
- Added test cases for Schedule and Steps of pgAgent Job.
2018-10-17 12:28:31 +01:00
Aditya Toshniwal
d6c4911135
Fixed calender control issues with Bootstrap 4
2018-10-12 15:02:38 +05:30
Aditya Toshniwal
0565f8dd78
Update to use Bootstrap 3 instead of Bootstrap 4. Fixes #3562
2018-10-10 12:43:26 +01:00
Khushboo Vashi
528ea88dec
Save the treeview state periodically, and restore it automatically when reconnecting. Fixes #1253
2018-10-08 10:03:19 +01:00
Akshay Joshi
6c2c18106f
Swap the Schema and Schemas icons and Catalog and Catalogs icons that had been used the wrong way around.
2018-09-24 14:11:23 -04:00
Aditya Toshniwal
38ddea038a
Fix support for the CLOB datatype in EPAS. Fixes #3596
2018-09-13 13:45:06 +01:00
Aditya Toshniwal
82c9cca683
Move all CSS into SCSS files for consistency and ease of colour maintenance etc. Fixes #2927
2018-09-04 11:24:51 +01:00
Akshay Joshi
dd3c7c94e6
Ensure external table node should be visible only for GPDB. Fixes #3548
2018-08-27 19:11:25 +05:30
Joao De Almeida Pereira
46d4bf027d
Ensure sql for Role should be visible in SQL panel for GPDB. Fixes #3578
2018-08-17 14:50:16 +05:30
Akshay Joshi
c8c5f83dfe
Add support to save and clear SSH Tunnel password. Fixes #3511
2018-08-06 15:56:46 +05:30
Akshay Joshi
a17aa212f0
COST statement should not be automatically duplicated after creating trigger function. Fixes #3526
2018-08-06 11:54:25 +05:30
Akshay Joshi
e9e8b0b433
1. Change the string from 'Reset server password" to "Clear Saved Password" and move this sub menu from File to Object menu.
...
2. Move the "Change Password..." menu from 'File' to 'Object' menu.
RM #3074
2018-08-03 16:41:01 +05:30
Khushboo Vashi
0cb25bde63
Add support for primary key, foreign key, unique key, indexes and triggers on partitioned tables for PG/EPAS 11. Fixes #3412
2018-07-27 17:31:21 +05:30
Akshay Joshi
0138dee989
Add support for reset saved password. Fixes #3074
2018-07-27 14:36:42 +05:30
Akshay Joshi
213cb440d0
Add support for SCRAM password changes (requires psycopg2 >= 2.8). Fixes #2214
2018-07-23 15:03:44 +01:00
Khushboo Vashi
2d1e835d32
Fix panel errors seen when click on partitions.
2018-07-23 14:33:40 +01:00
Aditya Toshniwal
c353135a3a
Add support for INCLUDE columns on indexes and index constraints with PG 11+. Fixes #3462
2018-07-19 13:13:37 +01:00
Akshay Joshi
ce768c7f8a
Support SSH tunneling with keys that don't have a passphrase. Fixes #3468
2018-07-18 14:15:05 +01:00
Khushboo Vashi
8869fd6eb3
Fix a number of debugger execution issues. Fixes #3191
...
1. EPAS packages' function/procedure does not honour INOUT arguments, it converts INOUT to OUT.
2. Packages' functions and procedures are not getting listed in their respected nodes in some scenarios like procedure having INOUT argument and function with void return type
3. The Reverse engineering SQL is not correct for Packages' functions/procedures
4. In case of INOUT argument, debugger asks for mendatory input which should not.
5. Re-executing a procedure whilst direct debugging doesn't work.
2018-07-17 12:51:24 +01:00
Akshay Joshi
39b41d7b24
Various procedure/function related fixes for EPAS/PG 11. Fixes #3446
...
- Fix the RM #3446 "plpgsql keyword should displayed in SQL pane for EPAS-11".
- Procedures for EPAS 11 always created as 'edbspl', even though language is sql or plpgsql.
- Not able to create Function/Procedure/Trigger function if the language is "C" for all supported database server.
- Function creation for EPAS 9.6 and above when set "Window?" flag to "Yes".
- Disable Volatility, Strict, Parallel, Estimated cost and Leak prof while creating procedures in EPAS 11 when language is not 'edbspl'.
- Rename "default" folder to "11_plus" inside "pg" directory for procedures, as procedures are supported from PG11 onwards.
- Creating/Deleting parameter in Procedure for PG 11.
- Drop procedures with arguments for PG/EPAS 11.
pg_proc table has added default value 'v' for Volatility, 100 for Cost and 'u' for Parallel for any language. All the three are not supported for Procedures in PG/EPAS 11 (excluding 'edbspl' language for EPAS). Fixed the issue where it is visible in properties panel if we create procedure using language 'plpgsql' or 'sql'.
2018-07-17 12:43:46 +01:00
Aditya Toshniwal
41a8333145
Replace deprecated success, error callbacks in $.ajax call with new functions .done and .fail.
2018-07-09 13:54:00 +01:00
Akshay Joshi
57c054fb0e
Fix various Drop menu options that were broken during the treeview refactoring.
...
Fixes #3442 . Fixes #3443 . Fixes #3444
2018-06-25 15:52:12 +01:00
Akshay Joshi
4a71c6d7af
Various EPAS/PG11 function & procedure fixes. Fixes #3421 . Fixes #3422
2018-06-25 14:58:02 +01:00
Akshay Joshi
560e5f225a
Allow dropping of Procedures in PG 11. Fixes #3423
2018-06-21 16:36:10 -04:00
Akshay Joshi
480fe6b9fc
Fixed issue of detection of EPAS server 11 and above. Version string is changed in EPAS 11
2018-06-21 18:30:37 +05:30
Joao Pedro De Almeida Pereira
155f82676d
Fix the RE-SQL generation for GreenPlum external tables. Fixes #3431
2018-06-19 20:01:45 -04:00
Akshay Joshi
7a06acb678
Allow the connection timeout to be configured on a per-server basis. Fixes #3388
2018-06-19 19:58:46 -04:00
Dave Page
9821e28da5
Fix file permissions per Devrim
2018-06-19 16:09:49 -04:00
Dave Page
717637c5b9
Fix indent.
2018-06-18 13:47:39 -04:00
Akshay Joshi
a45c33cf76
Ensure that template0 and template1 are available as tempates when creating databasesa. Fixes #3361
...
[regardless of the Show System Objects? option]
2018-06-18 13:41:14 -04:00
Akshay Joshi
766b389001
Include the schema name on RE-SQL for packages. Fixes #3356
2018-06-15 10:40:14 +01:00
Akshay Joshi
df7b4d55c6
Remove an extra space in Procedure templates.
2018-06-15 09:16:00 +01:00
Dave Page
087db8a75e
Fix stored procedure test cases so they don't fail on EPAS 9.4
2018-06-13 17:01:19 +01:00
Khushboo Vashi
d1ecba56b8
Function and procedure support for PG11. Fixes #3362
2018-06-13 15:03:17 +01:00
Joao De Almeida Pereira
e5048b4d0b
Disable ACLs for the database objects for the Greenplum due to
...
performance issue.
Reviewed By: Ashesh
Fixes #3415
2018-06-12 10:07:23 +05:30
Victoria Henry
226c872a84
Avoid an exception on GreenPlum when retrieving RE-SQL on a table. Fixes #3409
2018-06-11 16:56:39 +01:00
Joao De Almeida Pereira
7dd6372eeb
Extract the tests and refactor some of the methods.
...
Extract some of the ACI Tree functionalities, and decouple it from the
main source. Also - create some abstractions from the repeated code
around the enable/disable the schema children object create/edit/delete
functionalities, and also created the dialog wrappers for backup and
restore dialogs.
Reviewed by: Khushboo and Ashesh
Refactored by: Ashesh
2018-06-05 16:42:59 +05:30
Murtuza Zabuawala
f877de6a1f
Fix an issue where a change to any field in server dialog causes the 'tunnel_identity_file' model value to get included unnecessarily in the update request. Fixes #3389
2018-05-31 10:10:43 -04:00
Akshay Joshi
08990cb1de
Handle errors properly if they occur when renaming a database. Fixes #3353
2018-05-28 17:35:33 -04:00
Aditya Toshniwal
9f13865777
Update jQuery to 3.3.1. Fixes #3271
...
Patch by Aditya, with test enhancements from Anthony and Joao at Pivotal.
2018-05-25 16:26:37 +01:00
Aditya Toshniwal
a4ed9d6976
Allow connections to servers with port numbers < 1024 which may be seen in container environments. Fixes #3307
2018-05-18 11:12:38 +01:00
Akshay Joshi
719938a14c
Fixed issue where 'Identity file' control of SSH Tunnel tab is enabled when database is connected and 'Use SSH tunneling' flag is set to No.
2018-05-17 17:18:00 +05:30
Anthony Emengo
ab27b9d118
Fix template handling in tests for Windows.
2018-05-14 15:47:38 +01:00
Dave Page
8937375885
Standardise the error handling for parsing of JSON response messages from the server. Fixes #3238
2018-05-04 16:56:15 +01:00
Akshay Joshi
b7fb01ab04
Add support for SSH tunneled connections. Fixes #1447
2018-05-04 11:27:27 +01:00
Joao De Almeida Pereira
966279c1b3
Fixed issue where icon for Partitioned tables was the same as Non Partitioned tables for GreenPlum database. Fixes #3308
2018-04-26 17:05:56 +05:30
Joao De Almeida Pereira
2ace6a60f3
Fixed display SQL of table with index for GreenPlum database. Fixes #3306
2018-04-25 12:36:41 +05:30
Ashesh Vashi
b653b742ed
Close button added to the alertify message box, which pops up in case of backend error. Fixes #3290
2018-04-24 18:57:31 +05:30
Aditya Toshniwal
d5fdd32971
Fix an error generating SQL for trigger functions. Fixes #3179
2018-04-12 14:10:35 +01:00
Murtuza Zabuawala
8ec51412c3
Add a (configurable) limit to the number of pgAgent job history rows displayed on the statistics tab. Fixes #3072
2018-04-06 10:00:25 +01:00
Murtuza Zabuawala
be055ce57d
Update Python and JS modules. Fixes #3154
2018-04-04 10:47:01 +01:00
Akshay Joshi
61eb94a23c
Fix index node display on PG 10. Fixes #3180
2018-03-29 15:09:29 +02:00
Murtuza Zabuawala
34f1ebc88e
Ensure the host parameter is correctly pickup up from the service file. Fixes #3200
2018-03-19 12:38:44 +00:00
Joao Pedro De Almeida Pereira
876ce1799a
Skip tests where appropriate on GPDB. Fixes #3190
...
Victoria & Joao @ Pivotal.
2018-03-13 15:32:35 -04:00
Victoria Henry
6b03cb78af
Refactor server dialogue validation for better unit testing.
...
Victoria & Joao @ Pivotal.
2018-03-13 14:47:32 -04:00
Dave Page
156b308fd3
Fix template paths for Windows. Fixes #3139
...
Joint work from Joao and Murtuza.
2018-03-13 12:45:14 -04:00
Murtuza Zabuawala
03b772bf64
Add support for connecting using pg_service.conf files. Fixes #3140
2018-03-12 16:45:56 -04:00
Murtuza Zabuawala
985a004766
Fix SQL generated when dropping NOT NULL from a "char" column. Fixes #2989
2018-03-09 15:23:49 +00:00
Joao Pedro De Almeida Pereira
3a6994f719
Final PEP-8 fixes
2018-03-08 09:33:43 +00:00
Joao Pedro De Almeida Pereira
d1ab47c10c
Disable function statistics on Greenplum. Fixes #3176
2018-03-07 11:52:02 +00:00
Murtuza Zabuawala
06ff05762e
PEP8 fixes. Fixes #3175
2018-03-07 11:47:01 +00:00
Joao Pedro De Almeida Pereira
427314cfdf
Support for external tables in GPDB. Fixes #3168
2018-03-02 16:49:25 +00:00
Khushboo Vashi
905cdafe90
PEP8 changes for the FDW modules.
2018-03-02 14:46:13 +00:00
Murtuza Zabuawala
8964e511bf
PEP8 fixes for the Casts, Event triggers, Extensions and Languages modules. Fixes #3161
2018-03-02 11:59:11 +00:00
Harshal Dhumal
7cdb489a47
Fix handling of tie/datetime array types when adding columns to a table. Fixes #3079
2018-03-02 11:51:53 +00:00
Murtuza Zabuawala
78e2ff4f56
Ensure the pgAgent job start/end time grid fields synchronise with the subnode control and validate correctly. Fixes #3073
2018-03-02 11:11:26 +00:00
Murtuza Zabuawala
cca6504d54
PEP8 fixes. Fixes #3156
2018-02-27 15:38:50 +00:00
Harshal Dhumal
055f7abc9e
PEP8 fixes for the server and server group modules.
2018-02-27 11:22:14 +00:00
Joao Pedro De Almeida Pereira
3be22383b8
Fix function reserve SQL for GPDB. Fixes #3150
2018-02-27 11:05:15 +00:00
Murtuza Zabuawala
6753cd7334
PEP8 fixes for the pgAgent and Tables nodes (and subnodes). Fixes #3148
2018-02-26 19:24:17 +00:00
Joao Pedro De Almeida Pereira
5ebd9ee8d3
Fix table statistics for Greenplum. Fixes #3059
2018-02-26 09:38:00 +00:00
Murtuza Zabuawala
54dd6aae83
Add a test for sequence validation.
2018-02-23 12:02:57 +00:00
Murtuza Zabuawala
55875f0cfa
PEP8 cleanups for the sequences module.
2018-02-21 17:37:34 +00:00
Murtuza Zabuawala
51cc04b5b0
Fix tablespace tests for Python 3.x. Fixes #3138
2018-02-21 17:34:18 +00:00
Murtuza Zabuawala
f8771d5585
Fix validation of sequence parameters. Fixes #3014
2018-02-21 17:32:04 +00:00
Khushboo Vashi
b49d625c2d
Don't depend on standards_conforming_strings being enabled. Fixes #3077
2018-02-21 17:18:00 +00:00
Joao Pedro De Almeida Pereira
ba70634e5f
Hide tablespace node on GPDB. Fixes #3107
2018-02-20 17:40:56 +00:00
Khushboo Vashi
9a498c2877
Ensure column names on indexes on views are properly quoted in RE-SQL. Fixes #3066
2018-02-20 16:47:33 +00:00
Khushboo Vashi
c85e14dc25
Add missing reverse-engineered SQL header and drop statement for sequences. Fixes #3081
2018-02-19 11:41:19 +00:00
Joao Pedro De Almeida Pereira
15862e903a
Fix creation of tables and columns in GPDB. Fixes #3099
2018-02-19 10:40:10 +00:00
Joao Pedro De Almeida Pereira
e16a952753
Support EXPLAIN on Greenplum. Fixes #3097
...
- Extract SQLEditor.execute and SQLEditor._poll into their own files and add test around them
- Extract SQLEditor backend functions that start executing query to their own files and add tests around it
- Move the Explain SQL from the front-end and now pass the Explain plan parameters as a JSON object in the start query call.
- Extract the compile_template_name into a function that can be used by the different places that try to select the version of the template and the server type
2018-02-09 11:54:42 +00:00
Navnath Gadakh
db92907fe9
Fix quoting of function names in RE-SQL. Fixes #3060
2018-02-09 10:15:41 +00:00
Dave Page
4d69764869
Don't quote variable values used by SET. It's usually going to be wrong. Fixes #3027
2018-02-02 14:58:29 +01:00
Harshal Dhumal
2042f89ce0
Don't include sizes on primitive datatypes that shouldn't have them when modifying columns. Fixes #3052
2018-02-01 16:27:36 +01:00
Harshal Dhumal
e0da9c5a0c
Significantly improve connection loss detection and handling in the query tool. Fixes #2815
2018-02-01 14:29:18 +01:00
Joao Pedro De Almeida Pereira
de1c767e88
Update the regression tests to fix issues with Python 3.5 and PG 9.2. Fixes #3057
2018-01-26 16:45:09 +00:00
Joao Pedro De Almeida Pereira
7c985695b7
Correct display of RE-SQL for partitioned tables in Greenplum. Fixes #3050
2018-01-25 12:37:17 +00:00
Joao Pedro De Almeida Pereira
65337daeba
Display functions in Greenplum. Fixes #3044
2018-01-23 11:10:46 +00:00
Joao Pedro De Almeida Pereira
678699c408
Display partitions in Greenplum. Fixes #3036
2018-01-23 10:41:36 +00:00
Joao Pedro De Almeida Pereira
284adbbb90
Correctly display SQL of multiple objects on the SQL tab in GPDB.
2018-01-22 11:04:49 +00:00
Khushboo Vashi
ca80cfa04a
Ensure clickable images/buttons have appropriate tooltips for screen readers. Fixes #2904
2018-01-22 10:37:56 +00:00
Joao Pedro De Almeida Pereira
56e922f5ab
Support Properties on Greenplum databases. Fixes #3015
2018-01-15 14:44:40 +05:30
Murtuza Zabuawala
8520871bc6
Monitor connection and transaction status in the query tool. Fixes #2475
2018-01-12 14:34:39 +00:00
Joao Pedro De Almeida Pereira
ed3e374df6
Support server and database statistics on Greenplum. Fixes #3004
2018-01-12 10:02:46 +00:00
Ashesh Vashi
c32eb6bd37
Fixed the warnings/errors reported by eslint for all the static
...
javascripts.
2018-01-12 13:00:14 +05:30
Dave Page
89821c0d19
Update copyright notices for 2018.
2018-01-05 10:42:50 +00:00
Khushboo Vashi
711fbd5144
Allow use of transition tables in PG 10 triggers. Fixes #2933
2018-01-03 16:25:03 +00:00
Murtuza Zabuawala
0810c681c3
Ensure the switch animation is consistent on the table dialogue and avoid displaying an error incorrectly. Fixes #2624
2018-01-03 15:32:44 +00:00
Khushboo Vashi
49dfd6fe31
Ensure invalid options can't be selected on triggers on views. Fixes #2945
2018-01-03 14:32:00 +00:00
Khushboo Vashi
e64bc2a821
Show complete SQL for FTS dictionaries. Fixes #2949
2018-01-03 13:16:11 +00:00
Khushboo Vashi
107795db10
Ensure column collation isn't lost when changing field size. Fixes #2779
2017-12-13 15:44:10 +00:00
Murtuza Zabuawala
c5d1fc8189
Ensure the datatype cache is updated when a domain is added. Fixes #2778
2017-12-13 15:17:17 +00:00
Dave Page
b2e844c0ad
Fix label inconsistency spotted by Susan.
2017-12-13 14:59:15 +00:00
Murtuza Zabuawala
4246a3b22f
Ensure password changes are successful if authenticating using a pgpass file. Fixes #2720
2017-12-13 13:28:07 +00:00
Khushboo Vashi
0c5a5ba9c2
Add support for editing data in tables with OIDs but no primary keys. Fixes #2849 .
...
This patch also updates the editor to retrieve all row values on save, thus immediately showing default values and allowing subsequent editing without a refresh.
2017-12-13 10:28:31 +00:00
Murtuza Zabuawala
f5718b9d56
Misc fixes for the pgAgent module:
...
1) User was allowed to enter start date ahead of end date while scheduling a job. Fixes #2921
2) Datetime picker was not displaying in the grid (sub-node collection control). Fixes #1749
3) Fixed UI issue where validation error was not displaying properly for Datetime control.
2017-12-06 12:25:45 +09:00
Murtuza Zabuawala
2995d6e9c5
Fix the width of Role dialogue so tabs don't wrap.
2017-11-30 10:58:27 +00:00
Navnath Gadakh
035c134fed
Cleanup properly after running the Foreign Table test cases.
2017-11-28 09:44:28 +00:00
Navnath Gadakh
80c4a3fb1a
Use sufficiently long random strings in test objects to avoid conflicts.
2017-11-27 12:01:50 +00:00
Murtuza Zabuawala
d614c88ada
Ensure we don't show the full path on the server when using virtual filesystem roots in server mode for SSL certs. Fixes #2866
2017-11-27 11:25:50 +00:00
Murtuza Zabuawala
b284572afe
Allow connections to be coloured in the treeview and query tool. Fixes #1383 . Fixes #2802
2017-11-21 16:28:01 +00:00
Murtuza Zabuawala
dd8e2fe8a6
Quote the owner name when creating types. Fixes #2787
2017-11-21 11:32:27 +00:00
Murtuza Zabuawala
5fd3a7dd3d
Display relevant error messages when access is denied creating a schema. Fixes #2094
2017-11-20 13:31:03 +00:00
Harshal Dhumal
051788d040
Fix a referenced before assignment bug in connection management. Fixes #2868
2017-11-16 12:40:00 +00:00
Khushboo Vashi
88cd68c2b9
Add an option to manually count rows in tables to render the properties. Fixes #2846
2017-11-07 20:27:10 -05:00
Alexander Lakhin
187ab22d90
Further missing translation fixes. Stats now:
...
1481 of 1831 messages (80%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po
1694 of 1831 messages (92%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po
1748 of 1831 messages (95%) translated in pgadmin/translations/pl/LC_MESSAGES/messages.po
1750 of 1831 messages (95%) translated in pgadmin/translations/ru/LC_MESSAGES/messages.po
1436 of 1831 messages (78%) translated in pgadmin/translations/zh/LC_MESSAGES/messages.po
2017-11-06 19:49:20 -05:00
Chethana Kumar
2be418706d
Updated colours of tree view icons, which is to be more comfortable in identifying.
2017-11-06 13:03:03 +05:30
Alexander Lakhin
f15f46592a
Tag some translations that were not, well, tagged. Current stats:
...
1481 of 1777 messages (83%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po
1694 of 1777 messages (95%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po
1472 of 1777 messages (82%) translated in pgadmin/translations/pl/LC_MESSAGES/messages.po
1750 of 1777 messages (98%) translated in pgadmin/translations/ru/LC_MESSAGES/messages.po
1436 of 1777 messages (80%) translated in pgadmin/translations/zh/LC_MESSAGES/messages.po
2017-11-05 08:32:26 -05:00
Dave Page
b2186db562
Revert "Fix a number of cases where strings were not properly marked for translation."
...
This reverts commit 1f23838a4c
due to unintended side
effects it caused - specifically, expanding Databases on the treeview displayed
Servers again
2017-11-03 16:45:20 +00:00
Alexander Lakhin
1f23838a4c
Fix a number of cases where strings were not properly marked for translation.
2017-11-03 13:10:42 +00:00
Khushboo Vashi
f73ce2dfc3
Ensure estimated rows are included correctly in CREATE script for functions. Fixes #2651
2017-11-02 09:47:31 +00:00
Murtuza Zabuawala
897bf4857a
Fix counted rows display in table properties. Fixes #2836
2017-11-02 09:35:44 +00:00
Alexander Lakhin
23d431fb54
Remove more exclamation marks from error messages.
2017-11-01 15:18:07 +00:00
Alexander Lakhin
9be1364d1a
Various string improvements and fixes.
2017-11-01 12:58:19 +00:00
Dave Page
890fece73a
Fix check constraint regression tests.
2017-10-16 16:01:07 +01:00
Murtuza Zabuawala
784f3f59d8
Fix name of 'check-constraints' to follow the usual singular convention.
2017-10-16 15:40:15 +01:00
Harshal Dhumal
04beec1309
Fix various issues that could cause an exception on startup. Fixes #2713
2017-10-10 09:50:47 +01:00
Murtuza Zabuawala
2f5a2b2392
Only allow specification of a pgpass file if libpq >= 10. Fixes #2768
2017-10-10 09:31:27 +01:00
Akshay Joshi
5a132a547f
Ensure using an alternate role to connect to a database doesn't cause an error when checking recovery state. Fixes #2742
2017-09-28 15:09:49 +01:00
Murtuza Zabuawala
f855ed88ce
Allow selection of SSL certificates and pgpass files in connection properties. Fixes #2649 . Fixes #2650
2017-09-28 10:02:33 +01:00
Chethana Kumar
62c9376546
Improve icon alignment.
2017-09-22 14:29:34 +01:00
Akshay Joshi
bdc08d94c4
Fix View Data option and column config for Foreign Tables. Fixes #2691
2017-09-18 14:32:17 +01:00
Murtuza Zabuawala
8bededa859
Fix disable trigger menu option. Fixes #2707
2017-09-18 12:37:59 +01:00
Murtuza Zabuawala
e64c52a446
Fix tablespace move prompt message. Fixes #2708
2017-09-18 12:36:04 +01:00
Murtuza Zabuawala
9cfb2f3cbe
Fix filtering of system schemas so pg_* is hidden but pg* is not. Fixes #2709
2017-09-15 13:50:06 +01:00
Chethana Kumar
ff79dfc186
Update cast icons with improved design.
2017-09-13 10:43:39 +01:00
Chethana Kumar
3779c36d0f
Update server and database icons with a clearer design.
2017-09-13 09:59:07 +01:00
Murtuza Zabuawala
80ce889c3d
Fix an issue in User mapping module where users were not listed. Fixes #2693
2017-09-13 09:53:25 +01:00
Murtuza Zabuawala
5891bda06a
Fix an issue where base types are not displaying in the create/edit domain dialog, also corrected the condition to show hidden system types. Fixes #2692
2017-09-13 09:52:16 +01:00
Chethana Kumar
f79b7f26b1
Using the svg icons for domain constraint, and server browser nodes.
2017-09-11 18:24:04 +05:30
Ashesh Vashi
ac2512799e
Rename the SecurityGroupUnderSchema to SecurityGroupSchema, and
...
redefined in the database (instead of schema) javascript module, as it
is also used by the foreign-server node too.
Reported by: Neel Patel
2017-09-11 13:13:40 +05:30
Ashesh Vashi
8c8c0e78ca
Miscellaneous fixes for icon sizing issue, missing tree nodes to be
...
webpacked, etc.
- Fixed the background-size for the svg icons to 20x20 px such that it
does not adjust it's size when a context menu height is different due
to length of the node label, also - it allows us to fix the issue of
icons sizes in the Grant Wizard.
- Added two missing browser tree nodes in the webpack configuration
i.e. Foreign Server, and User Mapping
- Removed a redundant javascript file foreign-server.js
- Fixed the missing context menu icons for Foreign Table, and Tablespace
nodes.
Thanks EDB development team to find the regression added after the icon
changes in quick time.
2017-09-11 12:55:42 +05:30
Ashesh Vashi
4018562bc7
Changes in the stylesheets to support the svg icons for the browser
...
tree nodes.
2017-09-11 11:22:55 +05:30
Chethana Kumar
23a00f9614
Replacing existing browser tree node png icons with the svg icons. Made
...
it compatible with the pgAdmin 4 color combination.
TODO::
Icons for the following nodes are in PNG format.
- Domain Constraint (Only the invalid icon)
- pgAgent Job Steps
- Green Plum database server
- Server (Only server.png, which is used in the create/edit dialog)
2017-09-11 11:17:31 +05:30
Murtuza Zabuawala
8d248dab4c
Fix quoting of index column names on tables. Fixes #2619
2017-09-07 16:36:35 +01:00
Dave Cramer
eae6f0427c
Fix display of types in GPDB.
2017-08-31 09:57:27 +01:00
Murtuza Zabuawala
52840d68a8
Fix RE-SQL for triggers with a single arg. Fixes #2668
2017-08-31 09:39:09 +01:00
Teng Zhang
821442ed8f
GPDB compatibility fixes:
...
When connected to a Greenplum database server
- Hide items that not work with GPDB, such as Triggers, FDW, FTS_*, etc
- Tables/Views/Catalogs/Language node can expand correctly
- Views/Languages/Catalogs can show properties dialog with correct information
- Show a greenplum icon at the server node
Teng Zhang & Hao Wang
2017-08-30 11:18:14 +01:00
Harshal Dhumal
b1ad89fb4a
Using the proper python syntax to fetch the default binary path for
...
different servers types.
2017-08-26 09:59:57 +05:30
Ashesh Vashi
6b727c43b9
Define the utility path lable, and help message for the Greenplum
...
database server, shown in the preferences dialog.
Also, fixed the issue, when server type is not defined in the
DEFAULT_BINARY_PATHS, in the configuration.
2017-08-25 21:35:57 +05:30
Teng Zhang
46c5df4e7b
Greenplum specific DDL and Dashboard display changes.
...
Initial patch by Sarah McAlear<smcalear@pivotal.io>.
2017-08-25 17:53:03 +05:30
Murtuza Zabuawala
d3babd78aa
Fixes #2560 - View is not fully qualified in Trigger definition.
2017-08-25 17:45:20 +05:30
Navnath Gadakh
bd04cfaaa8
Properly cleanup after running the FTS test cases.
2017-08-25 09:32:46 +01:00
Akshay Joshi
fe6e4686a2
Unable to add/update variables for columns of a table. Fixes #2659
2017-08-23 17:11:30 +05:30
Surinder Kumar
ee20a10e94
Syntax error while saving changes for start/end time, weekdays, monthdays, month, hours, minutes while updating the pgAgent Job. Fixes #2657 .
2017-08-23 14:05:54 +05:30