pgadmin-org
/
pgadmin4
mirror of https://github.com/pgadmin-org/pgadmin4.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix quoting of index column names on tables. Fixes #2619

pull/6/head
Murtuza Zabuawala 2017-09-07 16:36:35 +01:00 committed by Dave Page
parent d5f60e1a47
commit 8d248dab4c
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/__init__.py
View File

@ -480,7 +480,7 @@ class IndexesView(PGChildNodeView):
status=200
)
def _column_details(self, idx, data):
def _column_details(self, idx, data, mode='properties'):
"""
This functional will fetch list of column details for index
@ -504,8 +504,10 @@ class IndexesView(PGChildNodeView):
cols = []
for row in rset['rows']:
# We need all data as collection for ColumnsModel
# we will not strip down colname when using in SQL to display
cols_data = {
'colname': row['attdef'].strip('"'),
'colname': row['attdef'] if mode == 'create' else
row['attdef'].strip('"'),
'collspcname': row['collnspname'],
'op_class': row['opcname'],
}
@ -901,7 +903,7 @@ class IndexesView(PGChildNodeView):
data['table'] = self.table
# Add column details for current index
data = self._column_details(idx, data)
data = self._column_details(idx, data, 'create')
SQL, name = self.get_sql(did, scid, tid, None, data)
if not isinstance(SQL, (str, unicode)):

3
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py
View File

@ -923,8 +923,9 @@ class BaseTableView(PGChildNodeView):
cols = []
for col_row in rset['rows']:
# We need all data as collection for ColumnsModel
# Only for displaying SQL, we can omit strip on colname
cols_data = {
'colname': col_row['attdef'].strip('"'),
'colname': col_row['attdef'],
'collspcname': col_row['collnspname'],
'op_class': col_row['opcname'],
}