e793413d76
Fixed issue by adding extra check for 'relkind' column
2017-07-07 12:33:58 +05:30
c2fb0394bf
Added support of Declarative Partitioning (Range, List) for PostgreSQL 10.
...
This allows the user to create partitioned table and it's partitions.
- Edit partitions, Create/Listing of constraints, rules, triggers under partitions. (Implemented by Harshal)
- Updating browser tree node when create/attach/detach partitions from table dialog.(Implemented by Ashesh)
2017-07-07 11:55:55 +05:30
ca7fe9a520
Ensure the save password option is enabled when creating a server. Fixes #2540
2017-07-06 13:33:46 +01:00
66b101fe4c
Resolve a number of issues with domains and domain constraints. Fixes #2529
2017-07-04 11:52:58 +01:00
0aa763b706
Remove unnecessary whitespace from stored procedure SQL. Fixes #2146
2017-07-03 16:32:19 +01:00
5c7dcaba81
Allow debugging of functions in packages. Fixes #1948
2017-07-03 16:30:12 +01:00
2a30a86e7d
Update alertify alerts to use the styling defined in the styleguide.
2017-06-30 10:21:05 +01:00
15cb9fc35b
Add support for the hostaddr connection parameter. This helps us play nicely with Kerberos/SSPI and friends. Fixes #2191
2017-06-26 15:48:59 -04:00
27bc5c803f
Ensure saved passwords are effective immediately, not just following a restart when first saved. Fixes #1920
2017-06-26 07:55:34 -04:00
d4e77deda4
Ensure revoked public privileges are displayed in the RE-SQL for functions. Fixes #2507
2017-06-26 07:50:39 -04:00
7a4945ff9e
Fix removal of sizes from column definitions. Fixes #2155
2017-06-23 09:42:46 +01:00
137bae1b04
Ensure default values are honoured when adding/editing columns. Fixes #1860
2017-06-22 12:11:02 +01:00
d26337a1ba
Moved the javascripts of the following browser node modules to the
...
'static' directory from 'templates' in the respective module directory:
- Server Group
- Server
- Database
- Schema
- Cast
- Event trigger
- Extension
- Foreign data wrapper
- Language
- Catalog Object
- Collation
- Domain Constraint
- Domain
- Foreign server
- FTS Configuration
- FTS Dictionary
- FTS Parser
- FTS Template
- Function
- Procedure
- Trigger Function
- Package
- Sequence
- Catalog
- Schema
- Synonym
- Table
- Type
- Materialized View
- View
- pgAgent Modules
+ Job (pga_job)
+ Schedule (pga_schedule)
+ Steps (pga_jobstep)
Added new dynanic modules for listing the supported server types, and
current user information.
NOTE: We've not yet moved the javascripts for the children of the table
module.
2017-06-22 15:58:32 +05:30
b9f6fb9545
Update MatView and pgAgent modules to work with recent integer/numeric changes. Fixes #2504
2017-06-21 17:03:43 +01:00
b9736cbd74
Handle missing/dropped synonyms gracefully. Fixes #2503
2017-06-21 16:59:43 +01:00
9829d74a04
Correct the v10 template path.
2017-06-20 12:04:13 +01:00
16a15bf934
Fix the fix for RM2324.
2017-06-13 09:18:44 +01:00
af43ccfc07
Teach dialogues about Escape to cancel, Enter to Save/OK, and F1 for help. Fixes #1535
2017-06-12 16:43:29 +01:00
ec5bc23dfd
Allow editing of the WITH ADMIN option of role membership. Fixes #2086
2017-06-12 13:58:51 +01:00
c435d48885
Properly handle trigger functions with parameters. Fixes #2043
2017-06-12 13:19:49 +01:00
49cd578816
Fix error on the stats tab with PG10. Also, rename the 10.0_plus template directory to 10_plus to match the new versioning. Fixes #2450
2017-06-12 12:53:09 +01:00
8bd8ae001b
Fix the PostGIS Datatypes in SQL tab, Create / Update dialogues for Table, Column, Foreign Table and Type node. Fixes #2324
...
Note that this doesn't add full support for PostGIS types to the table/column dialogues, which still can't handle the typmod usage. It does bring support to parity with pgAdmin 3 though.
2017-06-12 12:49:17 +01:00
fd3ddbeafb
Implementation of the client side 'url_for(...)' function.
...
Created a url_for function module to be used by different javascript
modules to use the same functionality of flask at client side.
A python module can expose the list of endpoints, used by its
javascripts, by overriding the 'get_exposed_url_endpoints(self)'
function.
In this patch, we have modified all the browser modules to use this
function. It will allow us to move the majority of the javascript
modules of browser nodes from templates directory to the static
directory.
TODO::
- Move these javascripts modules to the static directory.
- Use this function in all the applicable javascript modules.
e.g. tools, miscellaneous modules
2017-06-12 12:01:25 +05:30
aa400cbc12
Fix integer/numeric validation on various dialogues. Fixes #2421
2017-06-08 14:59:26 +01:00
01bfa88309
Improvements to the Query Results grid:
...
- Improve the UI
- Allow copy/paste from sets of rows, columns or arbitrary blocks of cells
Patch by Matt, Shruti, Joao and Sarah @ Pivotal
Fixes #2476
2017-06-08 13:31:36 +01:00
b149fe371e
Fix various issues with pgAgent job steps and schedules:
...
1) Error on clicking SQL panel when Schedule OR Step node is selected in browser. Fixes #1888
2) Error while dropping Schedule OR Step node. Fixes #1889
3) Newly created Schedule/Step node was not displaying in browser. Fixes #1890
2017-06-08 12:30:00 +01:00
63c093248d
Allow users to remove default values from columns properly. Fixes #2461
2017-06-07 14:33:28 +01:00
495a3cedb0
List packages in PPAS 9.2-9.4 when creating synonyms. Fixes #1813
2017-06-07 13:44:36 +01:00
b134ae2cb4
Fix the RE-SQL for for views to properly qualify trigger function names. Fixes #2381
2017-06-07 13:40:11 +01:00
ae80976689
Using the client-side translation using the client-side 'gettext'
...
implementation.
This is the first step towards 'Avoid creating the javascript modules
using Jinja templates'.
2017-06-07 15:53:05 +05:30
9803468a77
Properly display security labels on EPAS 9.2+. Fixes #1575
2017-06-06 11:46:49 +01:00
cd3484d936
Make $ quoting consistent. Fixes #1525
2017-06-06 11:40:25 +01:00
bf06d82870
Fix validation for external and range types. Fixes #1795
2017-06-06 11:24:10 +01:00
e6aa3e1494
Fix default values and SQL formatting for event triggers. Fixes #1229
2017-06-06 11:19:40 +01:00
4c2004d479
Correct the validation logic when modifying indexes/exclusion constraints. Fixes #2113
2017-06-06 11:15:51 +01:00
4b74a5ff35
Enable dialogue help buttons on Language and Foreign Table dialogues. Fixes #2116
2017-06-06 09:52:44 +01:00
0bc9997a95
Properly refresh the parent node when renaming children. Fixes #2355
2017-06-06 09:50:05 +01:00
9e98ded06c
Display and allow toggling of trigger enable/disable status from the trigger dialogue. Fixes #2386
2017-06-05 17:11:21 +01:00
3f150f3f4e
Handle procedure flags (IMMUTABLE STRICT SECURITY DEFINER PARALLEL RESTRICTED) properly in RE-SQL on EPAS. Fixes #2280
2017-06-05 17:04:55 +01:00
2c9af4784e
Allow creation of ENUM types with no members. Fixes #2426
2017-05-26 12:21:23 -04:00
45d423c0ce
Ensure the last placeholder is included when generating UPDATE scripts for tables. Fixes #2436
2017-05-26 10:59:09 -04:00
a45bb905f5
Pass the database ID to the query tool when using the Script options. Fixes #2435
2017-05-26 10:57:31 -04:00
2f097cd016
Fix typo in freshly added check.
2017-05-25 17:10:41 -04:00
e9da157cc7
Add numerous missing checks to ensure objects really exist when we think they do. Fixes #2427
2017-05-25 16:28:04 -04:00
04ce72a6ae
Fix RE-SQL for rules which got the table name wrong in the header and DROP statement. Fixes #2422
2017-05-19 12:21:29 +01:00
eb18320950
Improve error handling in cases where the user tries to rename or create a server group that would duplicate an existing group. Fixes #2414
2017-05-17 15:57:38 +01:00
17de7db70b
Fix server stats display for EPAS 9.2, where inet needs casting to text for concatenation. Fixes #1831
2017-05-17 15:53:13 +01:00
a3226b1eb5
Reverse engineer SQL for table-returning functions correctly. Fixes #1851
2017-05-17 15:49:56 +01:00
655d5888a6
Various FTS dictionary cleanups. Fixes #1126
2017-05-17 14:13:05 +01:00
2ad14b379e
Validate table presence in SQL and Properties route handles. Fixes #2395
2017-05-15 10:15:09 +01:00
3bf17d9df4
1) Splits the SQL query used to retrieve the Dependents, Dependencies, and Roles SQL file into multiple versioned files.
...
2) Add Unit Tests for each file.
3) Add ORDER BY into Copy Selection Feature test to ensure the results are retrieved always in the same order
4) Renamed the Scenario of the xss_checks_pgadmin_debugger_test and skip it for versions less than 9.1
5) Deleted unused __init__.py files.
2017-05-15 10:40:46 +05:30
4f9628ed43
Improve handling of nulls and default values in the data editor. Fixes #2257
2017-05-12 10:53:57 +01:00
94cbd70370
Don't change the trigger icon back to "enabled" when the trigger is updated when it's disabled. Fixes #2271
2017-05-10 09:48:21 +01:00
9452e0699e
Allow creation of tables with pure numeric names. Fixes #2284
2017-05-10 09:40:32 +01:00
94b7fc483a
Fix sorting of sizes on the statistics views by sorting raw values and prettifying on the client side. Includes Jasmine tests for the prettyfying function. Fixes #2315
2017-05-08 11:29:13 +01:00
95f763463f
Fix an issue in NodeAjaxControl caching with cache-node field and add cache-node field in Trigger & Event trigger node so that whenever the user creates new Trigger Function we get new data from server in NodeAjaxControl. . Fixes #2242
2017-05-04 16:02:28 +01:00
6790bfd0c0
Fixed handling of default parameters ordering in functions. Fixes #2350
2017-04-25 18:40:44 +05:30
1ce1f216ca
Fixed handling of nested privileges. Fixes #2335
2017-04-25 12:39:46 +05:30
a449be784e
Initial support for PG 10.0, per #2214 (missed some files)
2017-04-24 13:56:01 +01:00
59834fba31
Initial support for PG 10.0, per #2214
2017-04-24 13:55:29 +01:00
8d6add13c0
Order foreign table columns correctly. Fixes #2318
2017-04-18 14:37:30 +01:00
a3007b7335
Ensure database driver names and description strings can be translated. Fixes #2190
2017-04-18 13:33:27 +01:00
0d566a6f3a
Changed switch label from True/False to Show/Hide for 'Package Functions' and 'Package Procedures' node in Preferences dialog.
2017-04-14 14:57:38 +05:30
9bbc05051c
Remove some unused events.
2017-04-12 15:46:31 +01:00
62716c4193
Include passed test results in the JSON output from the regression tests.
2017-04-12 13:11:53 +01:00
024b97479d
Recover properly if a database is renamed externally. Fixes #2077
2017-04-10 11:09:01 +01:00
14f3a57d82
Ensure menus are updated after disconnecting a server. Fixes #2281
2017-04-10 09:35:21 +01:00
3880bc7eb8
Fix validation on the table dialogue so the Save button isn't enabled if the name is removed and autovac custom settings are enabled. Fixes #2105
2017-04-06 09:56:52 +01:00
b8566a0127
Un-split some strings for translateability. And so begins the battle between gettext and pep8...
2017-04-05 15:05:11 +01:00
ddfa934357
Unified usage of "definition incomplete".
2017-04-05 13:55:00 +01:00
37120bf199
(De)Capitalized strings to fit the common/usual format, corrected spelling, removed unnecessary characters.
2017-04-05 13:50:49 +01:00
65f21a8cd7
Replace all occurrences of "can not" with "cannot".
2017-04-05 13:38:14 +01:00
4d55e8abe8
Resolved a typo in the previous commit.
2017-04-03 19:00:06 +05:30
02a3919b06
As per Murtuza, we will have the '__module__', when running as a WSGI
...
application, but - it will not have the '__file__' attribute.
2017-04-03 18:55:24 +05:30
b756407c3c
When running pgAdmin as a WSGI application, we will not be able to find
...
the '__main__' module under 'sys.modules'.
2017-04-03 18:44:53 +05:30
74655e60a0
Replace the '$DIR' only when found in the binary directory string.
2017-04-03 18:32:50 +05:30
bb0bd8acc5
Properly handle truncated table names (> NAMEDATALEN). Fixes #2277
2017-04-01 02:57:48 -04:00
6a861f7a91
Add the config option ALLOW_SAVE_PASSWORD to allow admins to disable saving of passwords. Fixes #2232
2017-03-31 20:14:37 -04:00
633d2ad28c
Fix the bin path preferences.
2017-03-27 12:25:59 -04:00
c391696054
Remove some unnecessary line breaks causing problems with translations.
2017-03-26 20:26:58 -04:00
6152d73f13
Fix some code inspection complaints
2017-03-25 22:04:52 -04:00
0eda6033df
Allow users to select UI language at login or from Preferences rather than unpredictable behaviour from browsers. Fixes #2190
2017-03-24 14:20:10 +00:00
6cb9ece6fd
Decode error messages before trying to use them.
2017-03-24 14:11:31 +00:00
d205550b53
Fix Python 3 compatibility.
2017-03-23 13:43:24 +00:00
10920404e1
Re-organised the regression directory now we have multiple test suites: move test_utils.py into python_test_utils/
2017-03-23 11:59:31 +00:00
77007996ed
Support generation of DDL for tables in Greenplum DB. Fixes #2261
2017-03-23 11:40:06 +00:00
0ba0b25290
Move foreign key templates into a default directory.
2017-03-23 11:13:06 +00:00
145983d544
Add miissing braces to reverse engineered SQL header block for Functions. Fixes #2246
2017-03-17 12:48:58 +00:00
4464be6f43
Fix a typo and remove an unnecessary copy of the column properties template.
2017-03-17 10:02:52 +00:00
b2a74ad26d
Fix a bunch of file headers.
2017-03-16 14:27:55 +00:00
18d465e7bc
Fix some messages and update the Polish translation from Begina Felicysym
2017-03-09 09:23:19 +00:00
fb44ffffa0
Fix a couple of translation issues, and remove the test French translation files.
2017-03-08 10:13:15 +00:00
c34f5fd2d4
Use "could not" consistently, instead of "couldn't" which was used in some places.
2017-03-07 10:29:54 +00:00
278c64c361
Add missing "Run Now" option for pgAdmin jobs. Fixes #1796
2017-03-06 10:24:43 +00:00
ffa8d94e76
Better handling the non-ascii characters for different database objects.
...
Using 'psycopg2.extensions.UNICODE' (for Python < 3) in the psycopg2
driver for proper conversation of unicode characters. Also - adjusted
the string typecaster to take care of different character types (char,
character, text, name, character varying, and their array types).
Reviewed by: Dave Page, Murtuza Zabuawala & Akshay Joshi
2017-03-02 15:09:28 +05:30
59c6be534d
Typo fixes.
2017-03-01 12:49:15 +00:00
ddb8bad201
Fix Sequence ACL SQL for PG 9.3/9.2.
2017-03-01 12:46:58 +00:00
e2e000a371
Remove a debug message.
2017-02-28 14:44:58 +00:00
1f935d699e
Testsuite fixes for 9.3 and 9.2 support.
2017-02-28 14:22:10 +00:00
a0a31e55ae
Move 3rd party client code into vendor/ directories for ease of maintenance.
2017-02-24 17:01:21 +00:00
b961b2d929
Fix function arguments when generating create SQL. Fixes #2198
2017-02-24 12:42:25 +00:00
0ba9b7db43
Add PARALLEL SAFE|UNSAFE|RESTRICTED support. Fixes #2089
2017-02-24 12:21:05 +00:00
1c09b57a1a
Fix casting issue with dependents queries.
2017-02-24 10:48:46 +00:00
685b1ea12f
Fix renaming of check constraints when the table name is changed at the same time. Fixes #2201
2017-02-24 10:44:43 +00:00
5e33fe4e95
Properly handle event trigger functions in different schemas. Fixes #2200
2017-02-24 10:40:11 +00:00
03a161cc0a
Don't try to decode connection error strings that are null.
2017-02-16 16:42:19 +00:00
03f292ce51
Tidy up the regression test output a little.
2017-02-16 11:40:54 +00:00
9ad1316990
Various encoding fixes. Fixes #2160
2017-02-16 11:00:40 +00:00
833629d438
Fix exclusion constraint reverse engineered SQL. Fixes #2115
2017-02-16 10:54:21 +00:00
cbaad81f00
Correct node labels in Preferences for EDB functions and procedures. Fixes #2126
2017-02-16 10:47:28 +00:00
ae10da4371
Another Python 3.x compatibility fix.
2017-02-13 10:27:16 +00:00
14f181d2ba
Fix Python 3 compatibility.
2017-02-13 10:07:38 +00:00
ec9e8b79a3
Basic support for viewing tables in Greenplum. Patch from George & Tira @ Pivotal.
2017-02-13 10:02:20 +00:00
6887920295
Ensure FTS parsers and templates are removed prior to creating them when testing.
2017-02-09 12:05:55 +00:00
c34fdaf37d
Fix the issue with Jinja conditions in Foreign Data Wrappers, Foreign Servers, User Mapping.
...
I also did some re-formatting & re-factoring to code to remove all the duplicate code.
2017-02-09 12:05:09 +00:00
c96da34c28
Fix handling of "char" columns. Fixes #2152
2017-02-06 10:59:03 +00:00
3ea8a7b211
Fix column addition regression test.
2017-02-06 09:46:34 +00:00
bf8c3c4180
Handle sized time/timestamp columns correctly. Fixes #2076
2017-02-03 14:51:58 +01:00
f2ac6fc6a7
1) Wrong tablespace displayed in table properties. Fixes #2069
...
2) Message (Connection to the server has been lost.) displayed with Materialized view and view under sql tab. Fixes #2139
2017-02-03 16:13:07 +05:30
2d442da9ff
Properly handle setting comments and other options on databases with allowconn = False. Fixes #2024
2017-02-01 10:23:45 +00:00
6d05302ca1
Rename the 9.1_plus templates to "default" to more appropriately support Greenplum which is based on 8.3.
2017-02-01 09:57:49 +00:00
c6b67fc66a
Bypass recovery checks with older servers. This is required for Greenplum which is based on PG 8.3 at present.
2017-01-30 17:02:55 +00:00
e8f0cf6d94
Resolve various trigger issues. Fixes #2015
...
- Allow changing of row/statement flag
- When user update any of the parameter - trigger gets disappear from browser tree. To make it visible user has to do refresh.
- Edit Mode - 'Row level' trigger was not allowed to edit for "inline edb-spl" trigger function, even though "Row Trigger" is enabled.
- SQL was not generated properly when user change 'Row Trigger', Fires and events.
- Edit Mode - Fires and Events should be allowed to edit for "inline edb-spl" function mentioned with Code in description.
- Edit Mode - For trigger, if user edit parameters like Fires, Events, Code, Row trigger etc. then new OID is getting generated so we should fetch and return new OID in response rather then old trigger OID.
2017-01-30 13:05:15 +00:00
19be3529f8
Create a template loader for SQL templates.
...
This will automatically find the correct version of a template for the server version, and allows us to remove templates that were previously duplicated for different server versions.
Patch by George & Tira at Pivotal. Review by me and Murtuza from EDB.
Discussion: https://www.postgresql.org/message-id/flat/CAHowoHaU9_pkCt%2B1g8dpY3hsXXZmsJZiJH-3-_Hd%2BC1MxiGhtA%40mail.gmail.com#CAHowoHaU9_pkCt+1g8dpY3hsXXZmsJZiJH-3-_Hd+C1MxiGhtA@mail.gmail.com
2017-01-30 11:25:03 +00:00
e01cf748ea
Enable/disable NULLs and ASC/DESC options for index columns and exclusion constraints appropriately. Fixes #2061 . Fixes #1840 .
2017-01-25 13:21:39 +00:00
29a6f2e124
Fix Reset Statistics operation for which the popup messages weren't displaying correctly. Fixes #2091
2017-01-24 10:19:33 +00:00
801c7688a3
A little message cleanup.
2017-01-24 10:18:30 +00:00
ac4178233b
Revert "Handle comments on databases with datallowconn=False correctly. Fixes #2024"
...
This reverts commit e431eb9d8e
2017-01-20 13:21:05 +00:00
6557433061
Fix display of enum GUCs on users/databases etc. Fixes #2067
2017-01-17 10:45:01 +00:00
28621999f2
Improve display of columns of exclusion contraints and foreign keys in the properties lists. Fixes #2065
2017-01-17 10:25:26 +00:00
e431eb9d8e
Handle comments on databases with datallowconn=False correctly. Fixes #2024
2017-01-16 15:42:25 +00:00
024b664c21
Improve the display of role membership on both the properties panel and role dialogue. Fixes #1730
2017-01-16 14:48:25 +00:00
a85861ca57
Remove some comments that don't fit with our normal presentation of generated SQL.
2017-01-16 14:46:44 +00:00
4c19f93b3b
Use the correct OID for retrieving properties of freshly created exclusion constraints. Fixes #1896
2017-01-09 15:05:22 +05:30
b14f8239d2
Fix a SQL error when reverse-engineering ROLE SQL on EPAS servers. Fixes #1830
2017-01-09 08:14:34 +05:30
01b2288d57
Ensure columns with types that are not in pg_catalog are handled properly in the table dialog.
2017-01-09 08:05:51 +05:30
1325b30e0b
Various improvements to the regression tests, notably avoiding use of signals unavailable on Windows.
2017-01-08 18:48:04 +05:30
bdf9761472
Improve consistency of dialogue controls offered. Fixes #1364
2017-01-08 16:05:34 +05:30
2787c5c207
Reset the column list properly if the access method is changed on an index to ensure error handling works correctly. Fixes #2009
2017-01-08 15:27:58 +05:30
879a6bef53
Fix keyboard control of switches in the column grid. Fixes #1394
2017-01-08 15:27:58 +05:30
e3c8cb2706
Prevent attempts to create server groups with no name. Fixes #2012
2017-01-08 15:27:58 +05:30
07e1c61eea
Allow setting of effective_io_concurrency on tablespaces in 9.6+. Fixes #2000
2017-01-08 15:27:58 +05:30
fe9bdc62a1
Fix copyright notices.
2017-01-04 13:35:38 +00:00
f221194bcc
Update copyright notices for 2017.
2017-01-04 13:33:32 +00:00
1d571902da
Fix regression when generating SQL for new databases, caused by an invalid check of datallowconn introduced in the fix for #1801 .
2016-12-16 13:12:12 +00:00
1431dfcb01
Show index columns in the correct order in RE-SQL. Fixes #1842
2016-12-16 11:59:37 +00:00
81841cdb3c
Treat databases with datallowconn=false appropriately. Fixes #1801
2016-12-09 11:59:13 +00:00
6ff2fe64b8
Fix various mis-spellings of VACUUM. Fixes #2005
2016-12-08 10:35:53 +00:00
54e6336a58
Deal with Function arguments correctly in the properties dialogue. Fixes #1979
2016-11-25 10:55:10 +00:00
66b9e22d01
Handle the template property on databases appropriately. Fixes #1800
2016-11-25 10:11:40 +00:00
Akshay Joshi
Murtuza Zabuawala
Khushboo Vashi
Joao Pedro De Almeida Pereira
Atul Sharma
Ashesh Vashi
Dave Page
Surinder Kumar
Harshal Dhumal
Sarah McAlear
Navnath Gadakh
RAJASEKAR G
Jonas Thelemann
Aravindraja Thinakaran
Atira Odhner
Neel Patel
George Gelashvili
George Gelashvili
Anthony DeBarros