f79b7f26b1
Using the svg icons for domain constraint, and server browser nodes.
2017-09-11 18:24:04 +05:30
ac2512799e
Rename the SecurityGroupUnderSchema to SecurityGroupSchema, and
...
redefined in the database (instead of schema) javascript module, as it
is also used by the foreign-server node too.
Reported by: Neel Patel
2017-09-11 13:13:40 +05:30
8c8c0e78ca
Miscellaneous fixes for icon sizing issue, missing tree nodes to be
...
webpacked, etc.
- Fixed the background-size for the svg icons to 20x20 px such that it
does not adjust it's size when a context menu height is different due
to length of the node label, also - it allows us to fix the issue of
icons sizes in the Grant Wizard.
- Added two missing browser tree nodes in the webpack configuration
i.e. Foreign Server, and User Mapping
- Removed a redundant javascript file foreign-server.js
- Fixed the missing context menu icons for Foreign Table, and Tablespace
nodes.
Thanks EDB development team to find the regression added after the icon
changes in quick time.
2017-09-11 12:55:42 +05:30
4018562bc7
Changes in the stylesheets to support the svg icons for the browser
...
tree nodes.
2017-09-11 11:22:55 +05:30
23a00f9614
Replacing existing browser tree node png icons with the svg icons. Made
...
it compatible with the pgAdmin 4 color combination.
TODO::
Icons for the following nodes are in PNG format.
- Domain Constraint (Only the invalid icon)
- pgAgent Job Steps
- Green Plum database server
- Server (Only server.png, which is used in the create/edit dialog)
2017-09-11 11:17:31 +05:30
8d248dab4c
Fix quoting of index column names on tables. Fixes #2619
2017-09-07 16:36:35 +01:00
eae6f0427c
Fix display of types in GPDB.
2017-08-31 09:57:27 +01:00
52840d68a8
Fix RE-SQL for triggers with a single arg. Fixes #2668
2017-08-31 09:39:09 +01:00
821442ed8f
GPDB compatibility fixes:
...
When connected to a Greenplum database server
- Hide items that not work with GPDB, such as Triggers, FDW, FTS_*, etc
- Tables/Views/Catalogs/Language node can expand correctly
- Views/Languages/Catalogs can show properties dialog with correct information
- Show a greenplum icon at the server node
Teng Zhang & Hao Wang
2017-08-30 11:18:14 +01:00
b1ad89fb4a
Using the proper python syntax to fetch the default binary path for
...
different servers types.
2017-08-26 09:59:57 +05:30
6b727c43b9
Define the utility path lable, and help message for the Greenplum
...
database server, shown in the preferences dialog.
Also, fixed the issue, when server type is not defined in the
DEFAULT_BINARY_PATHS, in the configuration.
2017-08-25 21:35:57 +05:30
46c5df4e7b
Greenplum specific DDL and Dashboard display changes.
...
Initial patch by Sarah McAlear<smcalear@pivotal.io>.
2017-08-25 17:53:03 +05:30
d3babd78aa
Fixes #2560 - View is not fully qualified in Trigger definition.
2017-08-25 17:45:20 +05:30
bd04cfaaa8
Properly cleanup after running the FTS test cases.
2017-08-25 09:32:46 +01:00
fe6e4686a2
Unable to add/update variables for columns of a table. Fixes #2659
2017-08-23 17:11:30 +05:30
ee20a10e94
Syntax error while saving changes for start/end time, weekdays, monthdays, month, hours, minutes while updating the pgAgent Job. Fixes #2657 .
2017-08-23 14:05:54 +05:30
2e2ca26020
Ensure role names are escaped in the membership control. Fixes #2606
2017-08-21 14:00:33 +01:00
d757d8698d
Fix connection string validation for pgAgent jobs. Fixes #2655
2017-08-21 13:20:07 +01:00
6d7b54eb62
Update datetime picker. Fixes #2654
2017-08-21 13:17:35 +01:00
e6223c9a49
Fixes #2567 - Use the proper database connection to fetch the default
...
prileges in the properties tab of the database.
Reviewed by: Murtuza Zabuawala
2017-08-18 09:15:57 +05:30
e9b80dae9c
User can not add New Server through Quick links. Fixes #2634
2017-08-17 18:14:06 +05:30
bff48e0b2d
Fixed the path reference of load-node.gif which was referencing to vendor directory. Fixes #2646
2017-08-17 15:27:09 +05:30
2df4625ce0
1) Connection Type cell was not honouring to 'Kind' option in Subnode control.
...
2) Kind option was not saved properly
3) User was not be able to update Kind option in edit mode.
Fixes #2633
2017-08-17 15:00:08 +05:30
2c6c4a16ce
Use dict based data instead of 2d-array in Type module as we are adding keys on the fly.
...
Reviewed By: Harshal Dhumal
2017-08-17 13:07:39 +05:30
c4ca781ce2
Fixed some UX issue with the Import/Export tool.
...
- Couldn't click on the filename control once gets an error.
- Encoding is not in alphabetical order.
2017-08-09 16:52:43 +05:30
845025db8f
Some cosmetic changes.
...
- Loading 'pgadmin' as 'sources/pgadmin', as found under the 'sources'
reference directory to be consistent with other files.
- Removed the 'pgadmin' reference from the base.html template.
- Renamed 'pgadmin.slickgrid.editors.js', and
'pgadmin.slickgrid.formatters.js' as 'editors.js', and 'formatters.js'
respectively, as they're already in the 'pgadmin/static/js/slickgrid'
directory.
- Removed the duplicate entry of 'translations' from the webpack.shim.js
2017-08-09 16:52:12 +05:30
e418cb8387
Changed the mapping of cell from 'numeric' to 'integer' for integer control as numeric cell has been removed from the code. Fixes #2631
2017-08-07 14:02:59 +05:30
801a05891e
Set the database name to blank('') when job type is set to batch, while creating pgAgent job. Fixes #2620
2017-08-04 19:31:17 +05:30
bebfc62721
Fixed collation tests on Windows, replace use of default 'POSIX' collation with 'C' collation for testing. Fixes #2501
2017-08-03 16:46:20 +05:30
6717aff8f5
Domain create dialog do not open and Font size issue in Security label control. Fixes #2616
2017-08-01 16:37:17 +05:30
e506fa1dbe
Improved alertify notification logic. Remove AlertifyWrapper class and extend notification methods in alertify itself.
2017-07-31 18:59:44 +05:30
a7f58e2b92
1) Added partition module in webpack config.
...
2) Fixed missing logic of partition from primary_key.js and unique_constraint.js as this two files are newly created for webpack.
3) Changed the node name from 'check_constraint' to 'check_constraints'. Also changed the same in test case url.
2017-07-31 18:25:04 +05:30
6d5417709c
Moved the javascripts of different modules from 'templates' to 'static' directory.
...
Moving the javascripts for the following modules:
- About
- Browser nodes
- Dashboard
- FileManager
- Vendor/snap.svg
- Preferences
- Settings
- Backup
- Datagrid
- Debugger
- Sqleditor
- Grant Wizard
- Import & Export
- Maintenance
- Restore and
- User Management
2017-07-27 17:25:08 +05:30
d1e7254fbd
Handle control visibility properly in javascript strict mode.
2017-07-26 12:55:46 +01:00
70418144cf
Add a field to the Server Dialogue allowing users to specify a subset of databases they'd like to see in the treeview. Fixes #1918
2017-07-21 12:44:57 +01:00
acaa79cf6b
Fix disconnection of new databases. Fixes #2594
2017-07-21 11:11:03 +01:00
4d4da67247
Fix regressions introduced by PG10's partitioning code. Fixes #2043 . Fixes #2324 .
2017-07-20 12:49:40 +01:00
dfa877262d
Webpacking cleanups
2017-07-19 15:03:21 +01:00
bab3da24e6
Support SSL in the regression tests. Fixes #2170
2017-07-18 15:23:11 +01:00
6396b8ce18
Add missing new files from the previous commit. Ooops.
2017-07-18 15:14:59 +01:00
4a91bcde30
Webpack all the things! Fixes #2135
...
This significantly speeds up loading of the application; in an average of 3 tests, v1.6
loaded in 11.5s in the runtime on a Mac, whilst the webpacked version of the code
loaded in 5.53s.
2017-07-18 15:13:17 +01:00
3942461c50
Correct for malformed query generated when using custom type. Fixes #2544
2017-07-17 11:14:34 +01:00
07aa74eaf5
Show tablespace on partitions. Fixes #2551
2017-07-17 09:50:18 +01:00
4eefc52748
[PostgreSQL 10] Fixed the Pause/Resume Replay of WAL files for PostgreSQL 10. Fixes #2566
2017-07-14 18:39:19 +05:30
822e62c238
Fix privileges control on IE 10/11. Fixes #1166
2017-07-14 12:45:09 +01:00
f06c3578f6
Fix drop/drop cascade for partitioned tables. Fixes #2550
2017-07-10 16:02:32 +01:00
ed3cb7df41
Handle partitioned tables created "OF TYPE". Fixes #2545
2017-07-10 14:16:30 +01:00
d151bdb4cd
Fix handling of CREATE TABLE OF <type>. Fixes #2534
2017-07-07 16:34:33 +01:00
815c4b4c45
Improve spacing around delete icons in backform tables.
2017-07-07 16:06:51 +01:00
acd3568f06
Fix the formatting of the ROWS option for functions etc. Fixes #2537
2017-07-07 15:57:43 +01:00
e793413d76
Fixed issue by adding extra check for 'relkind' column
2017-07-07 12:33:58 +05:30
c2fb0394bf
Added support of Declarative Partitioning (Range, List) for PostgreSQL 10.
...
This allows the user to create partitioned table and it's partitions.
- Edit partitions, Create/Listing of constraints, rules, triggers under partitions. (Implemented by Harshal)
- Updating browser tree node when create/attach/detach partitions from table dialog.(Implemented by Ashesh)
2017-07-07 11:55:55 +05:30
ca7fe9a520
Ensure the save password option is enabled when creating a server. Fixes #2540
2017-07-06 13:33:46 +01:00
66b101fe4c
Resolve a number of issues with domains and domain constraints. Fixes #2529
2017-07-04 11:52:58 +01:00
0aa763b706
Remove unnecessary whitespace from stored procedure SQL. Fixes #2146
2017-07-03 16:32:19 +01:00
5c7dcaba81
Allow debugging of functions in packages. Fixes #1948
2017-07-03 16:30:12 +01:00
2a30a86e7d
Update alertify alerts to use the styling defined in the styleguide.
2017-06-30 10:21:05 +01:00
15cb9fc35b
Add support for the hostaddr connection parameter. This helps us play nicely with Kerberos/SSPI and friends. Fixes #2191
2017-06-26 15:48:59 -04:00
27bc5c803f
Ensure saved passwords are effective immediately, not just following a restart when first saved. Fixes #1920
2017-06-26 07:55:34 -04:00
d4e77deda4
Ensure revoked public privileges are displayed in the RE-SQL for functions. Fixes #2507
2017-06-26 07:50:39 -04:00
7a4945ff9e
Fix removal of sizes from column definitions. Fixes #2155
2017-06-23 09:42:46 +01:00
137bae1b04
Ensure default values are honoured when adding/editing columns. Fixes #1860
2017-06-22 12:11:02 +01:00
d26337a1ba
Moved the javascripts of the following browser node modules to the
...
'static' directory from 'templates' in the respective module directory:
- Server Group
- Server
- Database
- Schema
- Cast
- Event trigger
- Extension
- Foreign data wrapper
- Language
- Catalog Object
- Collation
- Domain Constraint
- Domain
- Foreign server
- FTS Configuration
- FTS Dictionary
- FTS Parser
- FTS Template
- Function
- Procedure
- Trigger Function
- Package
- Sequence
- Catalog
- Schema
- Synonym
- Table
- Type
- Materialized View
- View
- pgAgent Modules
+ Job (pga_job)
+ Schedule (pga_schedule)
+ Steps (pga_jobstep)
Added new dynanic modules for listing the supported server types, and
current user information.
NOTE: We've not yet moved the javascripts for the children of the table
module.
2017-06-22 15:58:32 +05:30
b9f6fb9545
Update MatView and pgAgent modules to work with recent integer/numeric changes. Fixes #2504
2017-06-21 17:03:43 +01:00
b9736cbd74
Handle missing/dropped synonyms gracefully. Fixes #2503
2017-06-21 16:59:43 +01:00
9829d74a04
Correct the v10 template path.
2017-06-20 12:04:13 +01:00
16a15bf934
Fix the fix for RM2324.
2017-06-13 09:18:44 +01:00
af43ccfc07
Teach dialogues about Escape to cancel, Enter to Save/OK, and F1 for help. Fixes #1535
2017-06-12 16:43:29 +01:00
ec5bc23dfd
Allow editing of the WITH ADMIN option of role membership. Fixes #2086
2017-06-12 13:58:51 +01:00
c435d48885
Properly handle trigger functions with parameters. Fixes #2043
2017-06-12 13:19:49 +01:00
49cd578816
Fix error on the stats tab with PG10. Also, rename the 10.0_plus template directory to 10_plus to match the new versioning. Fixes #2450
2017-06-12 12:53:09 +01:00
8bd8ae001b
Fix the PostGIS Datatypes in SQL tab, Create / Update dialogues for Table, Column, Foreign Table and Type node. Fixes #2324
...
Note that this doesn't add full support for PostGIS types to the table/column dialogues, which still can't handle the typmod usage. It does bring support to parity with pgAdmin 3 though.
2017-06-12 12:49:17 +01:00
fd3ddbeafb
Implementation of the client side 'url_for(...)' function.
...
Created a url_for function module to be used by different javascript
modules to use the same functionality of flask at client side.
A python module can expose the list of endpoints, used by its
javascripts, by overriding the 'get_exposed_url_endpoints(self)'
function.
In this patch, we have modified all the browser modules to use this
function. It will allow us to move the majority of the javascript
modules of browser nodes from templates directory to the static
directory.
TODO::
- Move these javascripts modules to the static directory.
- Use this function in all the applicable javascript modules.
e.g. tools, miscellaneous modules
2017-06-12 12:01:25 +05:30
aa400cbc12
Fix integer/numeric validation on various dialogues. Fixes #2421
2017-06-08 14:59:26 +01:00
01bfa88309
Improvements to the Query Results grid:
...
- Improve the UI
- Allow copy/paste from sets of rows, columns or arbitrary blocks of cells
Patch by Matt, Shruti, Joao and Sarah @ Pivotal
Fixes #2476
2017-06-08 13:31:36 +01:00
b149fe371e
Fix various issues with pgAgent job steps and schedules:
...
1) Error on clicking SQL panel when Schedule OR Step node is selected in browser. Fixes #1888
2) Error while dropping Schedule OR Step node. Fixes #1889
3) Newly created Schedule/Step node was not displaying in browser. Fixes #1890
2017-06-08 12:30:00 +01:00
63c093248d
Allow users to remove default values from columns properly. Fixes #2461
2017-06-07 14:33:28 +01:00
495a3cedb0
List packages in PPAS 9.2-9.4 when creating synonyms. Fixes #1813
2017-06-07 13:44:36 +01:00
b134ae2cb4
Fix the RE-SQL for for views to properly qualify trigger function names. Fixes #2381
2017-06-07 13:40:11 +01:00
ae80976689
Using the client-side translation using the client-side 'gettext'
...
implementation.
This is the first step towards 'Avoid creating the javascript modules
using Jinja templates'.
2017-06-07 15:53:05 +05:30
9803468a77
Properly display security labels on EPAS 9.2+. Fixes #1575
2017-06-06 11:46:49 +01:00
cd3484d936
Make $ quoting consistent. Fixes #1525
2017-06-06 11:40:25 +01:00
bf06d82870
Fix validation for external and range types. Fixes #1795
2017-06-06 11:24:10 +01:00
e6aa3e1494
Fix default values and SQL formatting for event triggers. Fixes #1229
2017-06-06 11:19:40 +01:00
4c2004d479
Correct the validation logic when modifying indexes/exclusion constraints. Fixes #2113
2017-06-06 11:15:51 +01:00
4b74a5ff35
Enable dialogue help buttons on Language and Foreign Table dialogues. Fixes #2116
2017-06-06 09:52:44 +01:00
0bc9997a95
Properly refresh the parent node when renaming children. Fixes #2355
2017-06-06 09:50:05 +01:00
9e98ded06c
Display and allow toggling of trigger enable/disable status from the trigger dialogue. Fixes #2386
2017-06-05 17:11:21 +01:00
3f150f3f4e
Handle procedure flags (IMMUTABLE STRICT SECURITY DEFINER PARALLEL RESTRICTED) properly in RE-SQL on EPAS. Fixes #2280
2017-06-05 17:04:55 +01:00
2c9af4784e
Allow creation of ENUM types with no members. Fixes #2426
2017-05-26 12:21:23 -04:00
45d423c0ce
Ensure the last placeholder is included when generating UPDATE scripts for tables. Fixes #2436
2017-05-26 10:59:09 -04:00
a45bb905f5
Pass the database ID to the query tool when using the Script options. Fixes #2435
2017-05-26 10:57:31 -04:00
2f097cd016
Fix typo in freshly added check.
2017-05-25 17:10:41 -04:00
e9da157cc7
Add numerous missing checks to ensure objects really exist when we think they do. Fixes #2427
2017-05-25 16:28:04 -04:00
04ce72a6ae
Fix RE-SQL for rules which got the table name wrong in the header and DROP statement. Fixes #2422
2017-05-19 12:21:29 +01:00
eb18320950
Improve error handling in cases where the user tries to rename or create a server group that would duplicate an existing group. Fixes #2414
2017-05-17 15:57:38 +01:00
17de7db70b
Fix server stats display for EPAS 9.2, where inet needs casting to text for concatenation. Fixes #1831
2017-05-17 15:53:13 +01:00
a3226b1eb5
Reverse engineer SQL for table-returning functions correctly. Fixes #1851
2017-05-17 15:49:56 +01:00
655d5888a6
Various FTS dictionary cleanups. Fixes #1126
2017-05-17 14:13:05 +01:00
2ad14b379e
Validate table presence in SQL and Properties route handles. Fixes #2395
2017-05-15 10:15:09 +01:00
Chethana Kumar
Ashesh Vashi
Murtuza Zabuawala
Dave Cramer
Teng Zhang
Harshal Dhumal
Navnath Gadakh
Akshay Joshi
Surinder Kumar
Atul Sharma
Khushboo Vashi
Joao Pedro De Almeida Pereira
Dave Page
Sarah McAlear