b961b2d929
Fix function arguments when generating create SQL. Fixes #2198
2017-02-24 12:42:25 +00:00
0ba9b7db43
Add PARALLEL SAFE|UNSAFE|RESTRICTED support. Fixes #2089
2017-02-24 12:21:05 +00:00
1c09b57a1a
Fix casting issue with dependents queries.
2017-02-24 10:48:46 +00:00
685b1ea12f
Fix renaming of check constraints when the table name is changed at the same time. Fixes #2201
2017-02-24 10:44:43 +00:00
5e33fe4e95
Properly handle event trigger functions in different schemas. Fixes #2200
2017-02-24 10:40:11 +00:00
03a161cc0a
Don't try to decode connection error strings that are null.
2017-02-16 16:42:19 +00:00
03f292ce51
Tidy up the regression test output a little.
2017-02-16 11:40:54 +00:00
9ad1316990
Various encoding fixes. Fixes #2160
2017-02-16 11:00:40 +00:00
833629d438
Fix exclusion constraint reverse engineered SQL. Fixes #2115
2017-02-16 10:54:21 +00:00
cbaad81f00
Correct node labels in Preferences for EDB functions and procedures. Fixes #2126
2017-02-16 10:47:28 +00:00
ae10da4371
Another Python 3.x compatibility fix.
2017-02-13 10:27:16 +00:00
14f181d2ba
Fix Python 3 compatibility.
2017-02-13 10:07:38 +00:00
ec9e8b79a3
Basic support for viewing tables in Greenplum. Patch from George & Tira @ Pivotal.
2017-02-13 10:02:20 +00:00
6887920295
Ensure FTS parsers and templates are removed prior to creating them when testing.
2017-02-09 12:05:55 +00:00
c34fdaf37d
Fix the issue with Jinja conditions in Foreign Data Wrappers, Foreign Servers, User Mapping.
...
I also did some re-formatting & re-factoring to code to remove all the duplicate code.
2017-02-09 12:05:09 +00:00
c96da34c28
Fix handling of "char" columns. Fixes #2152
2017-02-06 10:59:03 +00:00
3ea8a7b211
Fix column addition regression test.
2017-02-06 09:46:34 +00:00
bf8c3c4180
Handle sized time/timestamp columns correctly. Fixes #2076
2017-02-03 14:51:58 +01:00
f2ac6fc6a7
1) Wrong tablespace displayed in table properties. Fixes #2069
...
2) Message (Connection to the server has been lost.) displayed with Materialized view and view under sql tab. Fixes #2139
2017-02-03 16:13:07 +05:30
2d442da9ff
Properly handle setting comments and other options on databases with allowconn = False. Fixes #2024
2017-02-01 10:23:45 +00:00
6d05302ca1
Rename the 9.1_plus templates to "default" to more appropriately support Greenplum which is based on 8.3.
2017-02-01 09:57:49 +00:00
c6b67fc66a
Bypass recovery checks with older servers. This is required for Greenplum which is based on PG 8.3 at present.
2017-01-30 17:02:55 +00:00
e8f0cf6d94
Resolve various trigger issues. Fixes #2015
...
- Allow changing of row/statement flag
- When user update any of the parameter - trigger gets disappear from browser tree. To make it visible user has to do refresh.
- Edit Mode - 'Row level' trigger was not allowed to edit for "inline edb-spl" trigger function, even though "Row Trigger" is enabled.
- SQL was not generated properly when user change 'Row Trigger', Fires and events.
- Edit Mode - Fires and Events should be allowed to edit for "inline edb-spl" function mentioned with Code in description.
- Edit Mode - For trigger, if user edit parameters like Fires, Events, Code, Row trigger etc. then new OID is getting generated so we should fetch and return new OID in response rather then old trigger OID.
2017-01-30 13:05:15 +00:00
19be3529f8
Create a template loader for SQL templates.
...
This will automatically find the correct version of a template for the server version, and allows us to remove templates that were previously duplicated for different server versions.
Patch by George & Tira at Pivotal. Review by me and Murtuza from EDB.
Discussion: https://www.postgresql.org/message-id/flat/CAHowoHaU9_pkCt%2B1g8dpY3hsXXZmsJZiJH-3-_Hd%2BC1MxiGhtA%40mail.gmail.com#CAHowoHaU9_pkCt+1g8dpY3hsXXZmsJZiJH-3-_Hd+C1MxiGhtA@mail.gmail.com
2017-01-30 11:25:03 +00:00
e01cf748ea
Enable/disable NULLs and ASC/DESC options for index columns and exclusion constraints appropriately. Fixes #2061 . Fixes #1840 .
2017-01-25 13:21:39 +00:00
29a6f2e124
Fix Reset Statistics operation for which the popup messages weren't displaying correctly. Fixes #2091
2017-01-24 10:19:33 +00:00
801c7688a3
A little message cleanup.
2017-01-24 10:18:30 +00:00
ac4178233b
Revert "Handle comments on databases with datallowconn=False correctly. Fixes #2024"
...
This reverts commit e431eb9d8e
2017-01-20 13:21:05 +00:00
6557433061
Fix display of enum GUCs on users/databases etc. Fixes #2067
2017-01-17 10:45:01 +00:00
28621999f2
Improve display of columns of exclusion contraints and foreign keys in the properties lists. Fixes #2065
2017-01-17 10:25:26 +00:00
e431eb9d8e
Handle comments on databases with datallowconn=False correctly. Fixes #2024
2017-01-16 15:42:25 +00:00
024b664c21
Improve the display of role membership on both the properties panel and role dialogue. Fixes #1730
2017-01-16 14:48:25 +00:00
a85861ca57
Remove some comments that don't fit with our normal presentation of generated SQL.
2017-01-16 14:46:44 +00:00
4c19f93b3b
Use the correct OID for retrieving properties of freshly created exclusion constraints. Fixes #1896
2017-01-09 15:05:22 +05:30
b14f8239d2
Fix a SQL error when reverse-engineering ROLE SQL on EPAS servers. Fixes #1830
2017-01-09 08:14:34 +05:30
01b2288d57
Ensure columns with types that are not in pg_catalog are handled properly in the table dialog.
2017-01-09 08:05:51 +05:30
1325b30e0b
Various improvements to the regression tests, notably avoiding use of signals unavailable on Windows.
2017-01-08 18:48:04 +05:30
bdf9761472
Improve consistency of dialogue controls offered. Fixes #1364
2017-01-08 16:05:34 +05:30
2787c5c207
Reset the column list properly if the access method is changed on an index to ensure error handling works correctly. Fixes #2009
2017-01-08 15:27:58 +05:30
879a6bef53
Fix keyboard control of switches in the column grid. Fixes #1394
2017-01-08 15:27:58 +05:30
e3c8cb2706
Prevent attempts to create server groups with no name. Fixes #2012
2017-01-08 15:27:58 +05:30
07e1c61eea
Allow setting of effective_io_concurrency on tablespaces in 9.6+. Fixes #2000
2017-01-08 15:27:58 +05:30
fe9bdc62a1
Fix copyright notices.
2017-01-04 13:35:38 +00:00
f221194bcc
Update copyright notices for 2017.
2017-01-04 13:33:32 +00:00
1d571902da
Fix regression when generating SQL for new databases, caused by an invalid check of datallowconn introduced in the fix for #1801 .
2016-12-16 13:12:12 +00:00
1431dfcb01
Show index columns in the correct order in RE-SQL. Fixes #1842
2016-12-16 11:59:37 +00:00
81841cdb3c
Treat databases with datallowconn=false appropriately. Fixes #1801
2016-12-09 11:59:13 +00:00
6ff2fe64b8
Fix various mis-spellings of VACUUM. Fixes #2005
2016-12-08 10:35:53 +00:00
54e6336a58
Deal with Function arguments correctly in the properties dialogue. Fixes #1979
2016-11-25 10:55:10 +00:00
66b9e22d01
Handle the template property on databases appropriately. Fixes #1800
2016-11-25 10:11:40 +00:00
1a18e07329
Allow a placeholder ($DIR) to be used in utility paths to make it easier to use relative paths.
2016-11-23 13:35:27 +00:00
08396ce861
Allow default binary paths to be set in the config for each database driver.
2016-11-23 12:44:13 +00:00
6e5126d571
Add newly created triggers to the treeview. Fixes #1747
2016-11-18 13:58:35 +00:00
6567669798
Ensure the check_option is only set when editing views when appropriate. Fixes #1924
2016-11-18 13:44:43 +00:00
00d2ab0338
Cast OIDs to oid not int, otherwise we lose half the range which results in objects not being accessible. Fixes #1951
2016-11-11 14:36:41 +00:00
f405cdf383
Ensure trigger function names are schema qualified in trigger RE-SQL. Fixes #1949
2016-11-11 13:46:06 +00:00
7b574b284d
Fix TypeError.
2016-11-10 12:48:38 +00:00
36c909b1f9
Generate mSQL for new schemas correctly. Fixes #1937
2016-11-09 15:13:17 +00:00
c345adaa52
Properly format arguments passed by triggers to functions. Fixes #1912
2016-11-09 15:00:35 +00:00
c2d9c0bb7c
Improve display of role options. Fixes #1729
2016-11-01 11:44:32 +02:00
a3622a380a
Fix display of exclusion contraint dependencies. Partially fixes #1892 - requires icon display fix.
2016-11-01 11:35:09 +02:00
ca57323ad1
Properly schema qualify domains when reverse engineering SQL. Fixes #1865
2016-10-28 16:45:06 +01:00
67e5dfa5a7
Fix refreshing of Unique constraints. Fixes #1893
2016-10-28 16:40:27 +01:00
8c48be3b0c
Properly quote role names when specifying function ownership. Fixes #1899
2016-10-28 16:18:31 +01:00
c1c2fb9df9
Ensure sequence start value is shown in SQL and properties list. Fixes #1155
2016-10-24 09:27:16 +01:00
2952faab5e
Fix exclusion constraint support on 9.6. Fixes #1875
2016-10-21 16:14:19 +01:00
23a0fc2f22
Fix refreshing of FTS Dictionaries. Fixes #1837
2016-10-21 16:07:45 +01:00
ef0d26c294
Ensure steps and schedules can be created in empty jobs. Fixes #1878
2016-10-21 16:00:23 +01:00
8e9108e0f3
Allow package bodies to be dropped. Fixes #1867
2016-10-21 15:24:11 +01:00
aef508ff91
Properly quote type names in RE-SQL for tables. Fixes #1863
2016-10-21 14:43:57 +01:00
da3a37ab19
Handle non-ascii responses from the server when connecting. Fixes #1822
2016-10-21 14:32:25 +01:00
406dab069d
Show security labels in the reverse engineered SQL for domains. Fixes #1574
2016-10-21 12:49:50 +01:00
d29ccea299
Don't allow setting of security labels on edbspl stored procedures (by correctly checking the node type). Fixes #1576
2016-10-21 12:37:47 +01:00
1908e86d22
Resolve a PG 9.6 compatibility issue in the regression test for Languages.
2016-10-21 12:24:26 +01:00
48ee8490f0
Add new indexes to the correct parent on the treeview. Fixes #1880
2016-10-21 12:12:37 +01:00
06039320b9
Don't specify ASC/DESC options for index types that don't support them. Fixes #1840
2016-10-21 12:08:41 +01:00
6874a1a247
Properly generate exclusion constraint SQL. Fixes #1861
2016-10-21 12:04:30 +01:00
76fb831554
Fixed issue where some parameter like 'Volatility, LeakProof , Variables etc..' not visible in SQL definition for functions and trigger functions.
2016-10-20 19:07:51 +05:30
6c5d81b6f5
Fixes #1843 Function definition does not match value returned from pg_get_functiondef()
2016-10-20 18:30:43 +05:30
c4f1b8eb11
Add tests for Languages
2016-10-18 14:36:25 +01:00
e31ba5873b
Add regression tests for resource groups on EPAS.
2016-10-18 12:01:01 +01:00
8d2dff1482
Always create databases from template0 when running regression tests, to ensure consistency and avoid concurrency issues.
2016-10-18 11:57:31 +01:00
11e486f96d
Fix unsafe schema lookups for types. Fixes #1728
2016-10-18 11:32:43 +01:00
dd6a69d845
Handle reverse engineering of synonyms with / in the name. Fixes #1622
2016-10-14 16:01:55 -07:00
2d39b5fb41
Identify the collation correctly when reverse engineering table SQL. Fixes #1847
2016-10-14 15:57:55 -07:00
c7520cf86d
Allow refreshing of synonym nodes. Fixes #1845
2016-10-14 15:50:20 -07:00
17bd379cb6
Properly quote names when renaming FTS dictionaries and templates. Fixes #1857
2016-10-14 12:23:10 -07:00
0df968f679
Resolve issue with properties refreshing. Fixes #1728
...
1) If we create/update a node with non-default schema, It should return selected schema id in return response. but default schema id is returned every time due to which it throws error in properties panel.
Fixed in Domains, Collation, Types, Views & Table node.
2) Incorrect parent id of object node is returned from nodes method due to which wrong parent id is passed while updating object and
thus node didn't get refreshed.
Fixed in FTS Configuration, FTS Parser nodes.
2016-10-14 12:19:00 -07:00
404d4efd2e
Add test cases for tables, types, views and their children.
2016-10-14 11:20:51 -07:00
22dadacb0f
Add terst cases for packages, and update Synonym cases for recent API changes.
2016-10-14 10:59:36 -07:00
540c389d92
Add regression tests for Foreignb Tables.
2016-10-13 06:57:16 -07:00
8b91babdc2
Add regression tests for FTS nodes.
2016-10-13 06:54:23 -07:00
713c692ddd
Fix View privilege management. Fixes #1531
...
1. Fixed update privileges for views and materialized views.
2. Apart from this fixed wrong sql for privilege update.
3. Fixed: Error message was not got cleared even after removing entry with error on privilege tab.
2016-10-10 09:42:22 +01:00
148808a17b
Fix label
2016-10-07 14:15:18 +01:00
ae612f5403
Major update to the test suite:
...
1. Code changes (due to drop objects functionality).
2. Quoting for database names in drop databases.
3. Code changes for import errors for pickle_path and advanced_config variables.
2016-10-07 13:59:43 +01:00
50658808d9
Ensure variable is defined before use.
2016-10-07 13:59:10 +01:00
50859f8369
Correctly identify server type upon first connection. Fixes #1785
2016-10-07 12:57:36 +01:00
c931d715ac
Fix refresh of Synonyms. Fixes #1611
2016-10-07 12:08:19 +01:00
8b2832bbc7
pgAgent docs. Fixes #1824
2016-10-04 14:48:57 +01:00
e52aeecd20
Fixes# 1808 - Invalid date-time format was used in the Start/End time
...
for Job Schedule.
Thanks Susan for the report.
2016-10-04 10:18:37 +05:30
d4af70aeb9
Label corrections.
2016-10-03 14:20:04 +01:00
a91f19a21d
Fix typo. Fixes #1596
2016-09-30 10:36:39 +01:00
49ee8abb72
Fix typo
2016-09-30 09:45:14 +01:00
f9dacc5237
Fix label cpaitalisation
2016-09-26 15:04:47 +01:00
0ae719dae0
Do not try to set in_recovery, is_replay_paused properties in the server
...
object, when data is not available.
2016-09-26 19:16:06 +05:30
a4aae4c245
Update role and tablespace tests to cleanup properly following a failure.
2016-09-26 14:02:59 +01:00
e591c6b5c0
pgAgent misc fixes:
...
1. When an existing schedule updated, or a new schedule is added from a pgAgent job dialog, it was not able to generate the proper update SQL Query.
2. The SubNodeCollectionControl was not removing the grid, when it is being getting removed.
2016-09-26 13:43:13 +01:00
237bfd4882
pgAgent - add modules for jobs, steps and schedules. Fixes #1341
2016-09-26 12:04:10 +01:00
912eebb583
Fix view creation. Fixes #1736
2016-09-26 11:00:18 +01:00
f51d8c72ef
Fix validation message
2016-09-26 10:57:16 +01:00
6999249dcd
Ensure the default schema is set when creating objects. Fixes #1735
2016-09-26 10:15:23 +01:00
1c623c56e7
Fixes#1737 - Setting the schedma-id as the pid (parent-id) for the
...
sequences node instead of the server-id.
Due to this - during updating the sequence node, it was not able to find
out the correct parent node, and it was updating the existing node, but
- later it (considering the old node) was removed by the replace logic.
2016-09-24 14:25:16 +05:30
8797b3f3bf
Change rolvaliduntil format to "YYYY-MM-DD HH:mm:ss Z" for consistency with the rest of the app.
2016-09-23 10:10:31 +01:00
163ae4d53d
Misc fixes and additions for pgAgent support:
...
- Added DatetimepickerControl, MomentCell (using moment.js)
- Used the 'DatetimepickerControl' in Role (Also - resolved an issue, when unset the datetime for 'Valid Until'.)
- Added a 'Select All/Unselect All' adaptor for Select2 used by pgAgent nodes.
- Fixed an issue with SubNodeCollectionControl, which was not starting the modification session of the child model, when created default value for collection is not null/undefined. And, hence - validation on the child model was not working.
- Fixed a memory leak with SqlFieldControl, and SqlTabControl, which was not releasing the CodeMirror properly.
2016-09-22 15:27:59 +01:00
a113b43a1f
Add Packages as a synonym target type. Fixes #1611
2016-09-22 14:56:00 +01:00
f48f806657
Fix stats on PG 9.6. Fixes #1719
2016-09-22 14:17:47 +01:00
1cb5a7c7ca
Update regression tests to resolve issues where database/connections were getting mixed up.
2016-09-22 12:58:38 +01:00
f117685d77
Drop all connections from the connection manager when a server is dropped to avoid issues if sqlite reuses an ID. Fixes #1720
2016-09-22 12:57:52 +01:00
c84fd83595
Enhanced summary output for the test suite.
2016-09-19 16:49:06 +01:00
2440f89a71
Fix an issue where the edit icon vanished and the default tab wasn't shown when advanced-editing a column in the table dialogue. Fixes #1704
2016-09-19 15:37:04 +01:00
cc0cb83277
Resolve a syntax error when updating packages with no body. Fixes #1588
2016-09-19 15:33:19 +01:00
82d63804c1
Resolve a refresh issue when updating packages. Fixes #1625
2016-09-19 09:41:13 +01:00
fc5ce22de9
Allow creation of objects in schemas with special chars in the name. Fixes #1598
...
This was caused through generation of SQL based on HTML-escaped labels, not the raw versions.
2016-09-16 17:02:57 +01:00
c5f04d03c6
Fix an issue where several default privileges cause error on database. Fixes #1670
2016-09-16 16:06:29 +01:00
92bc312d2d
Fix updating of matview definitions. Fixes #1595
2016-09-16 15:41:07 +01:00
ce20dbc25a
Add classid filter to queries on pg_depend. Fixes #1705
...
There are a number of cases where queries in both pgadmin4 and pgadmin3 are done against pg_depend but falis to constrain the query on classid.
In particular, if for example a constraint and a sequence exists with the same oid (which is perfectly valid, as they are in different tables), a column will suddenly refer sequences that are completely incorrect. When we look up sequences, we have to make sure we only match dependencies against pg_class.
2016-09-16 11:24:54 +01:00
165b93a968
Fix a syntax error when creating a trigger function on PPAS 9.5+. Fixes #1600
2016-09-16 11:12:41 +01:00
1ce5b38f4a
Fix an issue when changing the length of a column in the table dialogue. Fixes #1669
2016-09-16 11:09:13 +01:00
c48e8d415b
The Switch Dependency Cell, implemented in schema module, has a special
...
case. Its purpose is now to handle certain scinarios specific to table
children modules.
Renamed it to 'TableChildSwitchCell' from 'SwitchDepCell' to avoid any
conflict in future.
2016-09-15 13:36:56 +05:30
d3d8836f61
Introduce a test config database for the regression tests, and track/remove objects that are created during testing.
2016-09-14 16:26:12 +01:00
2ee631d6fc
Remove blank lines in the formatting of SELECT scripts for functions. Fixes #1690
2016-09-14 11:08:10 +01:00
f2469d113c
Fix function signature generation for reverse engineered SQL. Fixes #1674
...
1) In SQL pane, the signature in comments had arguments with name and type, Now it will show arguments with type only.
2) There is no indent+newline between arguments (there isn't even a space). - Fixed
3) The default value for the last argument is omitted. - Fixed
Last argument is omitted because the value for the last argument we got from table is empty.
Now we form function signature in the get_definition.sql using 'pg_catalog.pg_get_function_arguments' method.
Above changes will reflect in Functions, Procedures & Trigger function Nodes.
2016-09-14 10:59:11 +01:00
046f6dd442
Fix creation of DO INSTEAD rules. Fixes #1681
2016-09-14 10:39:16 +01:00
071b609a44
Fix error when refreshing table node. Fixes #1686
2016-09-14 10:30:02 +01:00
f2ed6fa4dd
Fix function signature generation. Fixes #1683
2016-09-12 15:20:46 +01:00
28b7a033bc
Prevent creation of packages and rules in catalogs. Fixes #1682
2016-09-12 11:37:25 +01:00
35d3c396de
Fix SQL generation for functions that return SETOF ... Fixes #1631
2016-09-07 14:53:22 +01:00
bd139bc83e
Improve binary path settings hint.
2016-09-07 09:54:54 +01:00
8ac65070bc
Improve the logic for Bad handling of missing connection database server RM #1387
2016-09-06 15:35:20 +05:30
f3f7413701
Use ISO formatted dates when setting rolvaluntil. Fixes #1153
2016-09-02 15:24:34 +01:00
689ef8d8d1
Fixes issues specific to SYNONYMS
...
- On droping a synonyms - the query should be modified in SQL pane.
- A proper message should be given on trying to drop an already dropped
synonyms.
- Handle the synonyms with special characters.
Fixes #1607 , #1608 , #1609
2016-08-29 20:25:18 +05:30
b6f307256b
Sorting the data during tree data loading using the natural sort
...
algorithm.
This patch takes care of:
* Consistent behaviour during create, update operation on any node.
- It should return the node data during creating a new object, or
updating the existing one.
* Now that - we have consistent behaviour during these operations, we
can consistently move, update the tree item based the node data from
the server.
* Implemented the methods for each node to get the information about
that particular node only.
* Using the above changes to implement the 'refresh' operation on tree
node properly.
I must thank Surinder, and Harshal for helping me implement the 'node'
method, and also changed the behaviour of create & update methods to
return the node data for most of the nodes.
Fixes #1244
2016-08-29 20:06:58 +05:30
f12d981a9d
Handling the bad/lost connection of a database server.
...
Made backend changes for:
* Taking care of the connection status in the psycopg2 driver. And, when
the connection is lost, it throws a exception with 503 http status
message, and connection lost information in it.
* Allowing the flask application to propagate the exceptions even in the
release mode.
* Utilising the existing password (while reconnection, if not
disconnected explicitly).
* Introduced a new ajax response message 'service_unavailable' (http
status code: 503), which suggests temporary service unavailable.
Client (front-end) changes:
* To handle the connection lost of a database server for different
operations by generating proper events, and handle them properly.
Removed the connection status check code from different nodes, so that
- it generates the proper exception, when accessing the non-alive
connection.
Fixes #1387
2016-08-29 12:01:35 +05:30
1b05464a04
Getting 'AttributeError' in pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py. Fixes #1464
2016-08-26 14:25:33 +05:30
5a78dd7ad3
Implemented Synonym node for EPAS
2016-08-26 13:01:57 +05:30
7b72448ec9
Internal sever error displayed if create New user mapping with public user. Fixes #1468
2016-08-26 11:23:15 +05:30
05473a7a35
domain node: id and pid is not being generated. Fixes #1586
2016-08-25 14:07:04 +05:30
e016869ad5
Trigger issues through right click. Fixes #1209
2016-08-24 12:10:54 +05:30
a535eddfcd
Add schema and database child node regression tests.
2016-08-23 11:50:41 +01:00
6775adc4c7
Cleanup old code in server_groups.js. Fixes #1247
2016-08-23 09:32:10 +05:30
58a79e4fc6
Fix parsing issue in packages.
2016-08-22 16:49:32 +01:00
cf1be2a320
Add support for Packages on EPAS.
2016-08-22 12:30:16 +01:00
fe54a124da
Don't offer to create resource groups on disconnected servers. Fixes #1569
2016-08-22 12:21:33 +01:00
4c2020cdc7
Allow the use of the tab key to select options in combo boxes. Fixes #1251
2016-08-22 12:18:38 +01:00
5690dfda16
Allow template databases to be used when creating new databases. Fixes #1570
2016-08-19 16:35:42 +01:00
7dffb020f1
Support CREATE LANGUAGE. Fixes #1252
2016-08-19 10:26:02 +01:00
8e0a61f556
Fixed typo in security labels macro Fixes #1457
2016-08-18 18:03:30 +05:30
1056e9553f
Show default database privileges in properties mode. Fixes #1538
2016-08-17 14:22:56 +01:00
9ec05d6bb1
Fix an issue where system level catalog are also displayed in PPAS server under relation of create new table like option. Fixes #1530
2016-08-16 16:29:50 +01:00
c336e8a743
Fix an issue in foreign tables node where it was displaying catalog tables in inherits options causing internal server error. Fixes RM#1520
2016-08-16 15:44:44 +01:00
99b4a0fe5b
Add unit tests for schemas, collations and trigger functions.
2016-08-16 12:54:02 +01:00
67f481ab11
Prevent creation of FTS objects in catalogs. Fixes #1122
2016-08-16 12:49:19 +01:00
81e2bc1e80
Test suite enhancements:
...
1. The user will specify the tablespace path in test_config.json.in
2. If tablespace path not found, skip the test cases for that server(Only tablespace test cases)
3. Add the skipped test summary in the test result. (Now it's showing on console + in log file, but need to update in a final enhanced test summary report. Which is research point we will work on that after finishing all nodes API test cases)
4. Removed the test_ prefix from the values in the config files.
5. Add tablespace and roles tests
2016-08-09 16:05:40 +01:00
2b13d55016
Add missing updates from the previous commit.
2016-08-09 12:17:02 +01:00
8918b8894d
Fixed privileges parsing issue while editing privileges of existing object. Fixes #1417
2016-08-08 16:31:57 +01:00
5900848842
Sequence related validation/fixes. Fixes #1119
...
1) Add proper validation checks for fields.
2) Fixed wrong sql generation due to incorrect conditions in template.
2016-08-08 12:47:20 +01:00
7cf4ac2474
Fix RE-SQL for Trigger Functions which was missing an 'AS'. Fixes #1524
2016-08-08 12:17:54 +01:00
b00e94e904
Fix drop trigger function, function and procedures. Fixes #1467
2016-08-04 15:24:03 +01:00
dfceb63986
Add save password option in sever create mode. Fixes #1450
...
Do a little string/layout cleanup whilst passing.
2016-08-03 15:55:45 +01:00
68497b00f6
Fix dropping of Domains. Fixes #1470
2016-08-03 15:44:24 +01:00
de568b3021
Fix renaming of constraints from the table dialogue. Fixes #1500
...
1] datamodel.js: For collection type added check before adding model into "changed" list instead of adding it blindly.
2] Type casting from str to int of column properties like attlen, attpricision.
3] Added missing data formating when adding new column to existing table (from table edit mode).
4] Added more validation for Foreign key constraint.
5] Column.js: Column grid (in table edit mode) show proper disabled color for disabled cell when grid renders.
6] All constraints and index js added idattribute to distinguish which s/constraint or s/index is updated on server side.
7] Column update.sql: Fixed sql when altering column data type. The issue was when we alter data type from which has length and precision to data type which don't have these properties and vice versa.
For e.g. alter data type numeric(10,12) to real (and vice versa)
8] Renaming constraint (RM1500).
9] simplejson KeyError handing for Python 2.7.
2016-08-03 15:39:14 +01:00
ec3b9bb15b
Allow to create the foreign table with inherits options. Fixes #1260
2016-08-02 09:38:56 +05:30
01252a13cf
Further misc quoting/encoding related fixes.
2016-08-01 15:23:06 +01:00
16304aafd2
s/buttton/button/g, per Anthony DeBarros. Fixes #1518
2016-08-01 15:16:14 +01:00
5c3c543d2e
Test suite improvements:
...
- Test framework support API testing with multiple server for this we need to modify test_config.json(for user it’s test_config.json.in) and test_advanced_config.json(for user it’s test_advanced_config.json.in). Server details of PG and PPAS are included in both .in files.
- Removed the logic of logging in the test client on each test scenario(As per Khushboo's comment in previous email). We need this logic in test cases under ‘browser/tests/’ as for test scenarios like change password and invalid login test cases as test client should be logged out first. So, as per this the code is slightly modified in ‘browser/tests/’.
2016-07-27 15:33:36 +01:00
b6e8d195dc
Security label providers are an optional parameter. Fixes #1478 .
2016-07-27 15:01:16 +01:00
06e881570a
Fix numerous encoding issues. Fixes #1307 . Fixes #1479
2016-07-26 15:05:14 +01:00
166d42953c
Give a more useful error message if attempting to drop an object that doesn't exist. Fixes #1154
2016-07-26 14:40:02 +01:00
e803464ee0
Replace 'Add' buttons with '+'
2016-07-26 12:54:59 +01:00
790b28fb61
Flask-Babel 0.11+ compatibility. Fixes #1496
2016-07-25 17:23:10 +01:00
875360d1c8
When we use deps functionality, backform controls re-render then. But before we re-render them we must remove old grid (if any) otherwise is causes js error "Unable to call exitEditMode of undefined". Fixes #1497
2016-07-25 14:31:17 +01:00
dbd3c7f4c5
Allow creation of FDWs if the extension is in a non-default schema. Fixes #1320
...
Root cause:-
When user change schema of already created fdw extension then while creating the new fdw we should append the <schema_name>.<fdw_handler_name>.
Previously we added only <fdw_handler_name> so while executing the query it will not be able to find fdw handler name without schema name.
e.g. If user changed the fdw handler 'postgres_fdw_handler' under schema 'test' then we should display the handler name under fdw as "test. postgres_fdw_handler".
Solution:-
With this patch, we have added <schema_name>.<fdw_handler_name> so while creating or updating the fdw, proper sql will be generated.
2016-07-25 12:48:11 +01:00
91559c622b
Fixes for function, procedure and trigger reverse SQL. Fixes #1293 . Fixes #1294
...
1. RM#1293 - SQL pane is not displaying GRANT queries in functions node
2. RM#1294 - Comments are not visible in sql pane for trigger functions and functions
Explanation:
Previously we we using 'get_defintion.sql' template to generate SQL for SQL pane for functions, procedure & trigger functions node.
but GRANT statements and COMMENTS changes were missing. In order to fix that, now we have used both 'create.sql' and 'get_definition.sql' templates to generate full SQL query for SQL pane.
2016-07-22 16:38:21 +01:00
60659975ed
Stop using deprecated imports.
2016-07-22 16:25:23 +01:00
f783aeac63
Change button label to initcap.
2016-07-21 17:18:15 +01:00
3d7b40e111
Fix support for security labels. Fixes #1457
2016-07-21 16:35:35 +01:00
f17c2e3b84
Enhancements to the regression test suite.
...
Navnath Gadakh and Priyanka Shendge
2016-07-18 14:50:21 +01:00
c7d25c33f2
Make the Parameter grid use a workflow consistent with other grids. Fixes #1241
...
1. Altered variable control to make its UI consistent with privileges and Security labels.
2. Changed datamodel.js to handle duplicate rows at datamodel level and not UI/Control level. (See variable control for example)
2016-07-18 11:50:42 +01:00
e94b14e7d7
Fix the issue in MATERIALIZED VIEW node where user was not able to add/update security label. Fixes #1458
2016-07-15 12:13:57 +01:00
efb254c966
Ensure newly created database can be dropped.
2016-07-15 10:14:11 +01:00
573abbe6ef
Allow users to select a data type with the keyboard only when creating a column in the subnode grid. Sanitise the list of fields shown.
2016-07-15 10:12:23 +01:00
fdcb9d2a57
Fix an issue in procedure node where users were not able to create a new procedure when they provide arguments. Fixes #1416
2016-07-13 14:57:08 +01:00
f79ca32e45
Allow selection of 'PUBLIC' as a role in privileges. Fixes #1416
2016-07-13 14:51:25 +01:00
ae692d2416
Display comments on languages. Fixes #1412
2016-07-13 14:45:34 +01:00
f58c4df85d
Fix incomplete reverse engineered SQL for databases. Fixes #1420
2016-07-13 12:42:01 +01:00
4077de2187
Fix Select2 issues. Fixes #1418 . Fixes #1434
...
1. Select2 control fixed for multi-select mode.
2. Index constrains (primary and unique key) fixed column listing issue.
3. Table node "inherited from" (Select2 control) was not showing table name with public schema
2016-07-05 12:58:48 +01:00
d4c3b1bcff
Fix trigger function help link. Fixes #1410
2016-07-02 17:24:21 +01:00
685b2f4ab7
Correct label
2016-06-30 14:05:10 +01:00
8246fc56e8
Offer the various serial pseudo-types as column type options. Fixes #1393
2016-06-29 19:50:43 +01:00
4bb849c58c
Allow toggling of the Primary Key option in the un-expanded column grid when defining a table. Fixes #1235
2016-06-24 14:05:59 +01:00
e4ef927da3
Fix tablespace statistics. Fixes #1196
2016-06-23 13:06:05 +01:00
8b0e65dc57
Allow default ACLs to be specified when creating schemas. Fixes #1108 .
2016-06-23 13:03:18 +01:00
5928f70a1d
Fix default ACL queries which were using invalid values for defaclobjtype.
2016-06-23 13:02:30 +01:00
4983eb2f1c
Fix SQL formatting. Fixes #1234
2016-06-23 12:14:23 +01:00
e5ee592470
Don't offer an option to drop the current maintenance database. Fixes #1382
2016-06-23 11:37:32 +01:00
b78b3904cd
Use PUBLIC (in caps) whenever used as a keyword. Fixes #1138
2016-06-23 09:15:09 +05:30
7d0fe669ca
Code tidy.
2016-06-21 14:21:06 +01:00
3026b470e9
Optimise Python imports.
2016-06-21 14:12:14 +01:00
03d348f7c2
Fix SELECT Script option for functions. Fixes #1191
2016-06-21 13:29:55 +01:00
3210975568
Fix creation of exclusion constraints. Fixes #1301
2016-06-21 12:01:39 +01:00
40b075389f
Add missing foreign table column options.
...
Fixes #1351
2016-06-20 13:45:37 +01:00
1a84c35628
Fix an issue where the save button was not getting enable when user revoke ADMIN option from Role privileges.
...
Issue: validation callback was missing in the control model.
Fixes #1302
2016-06-20 13:20:51 +01:00
01801e4acb
Fix date validation while creating new role.
...
Fixes #1370
2016-06-20 10:11:42 +01:00
ac37d60c03
Fix the issue in Materialized view where user was not able to create Materialized view with PPAS 9.5 due to incorrect template path.
...
Fixes #1379
2016-06-20 10:03:38 +01:00
3350eaceab
Use the same layout mechanism used as in the panel using elementary
...
layout support in different dialogs. Fixes #1358 .
2016-06-20 12:46:33 +05:30
3bcc5a4bd3
Further string improvements.
2016-06-17 14:51:01 +01:00
69d8f01d01
String improvements.
2016-06-17 14:35:16 +01:00
014eb2a5c2
Don't allow creation of edbspl trigger functions (they should be created as part of the trigger). Fixes #1212 .
2016-06-17 13:46:42 +01:00
d4e5d9c4f4
Add "Move objects..” functionality in tablespace node. Fixes #1286
2016-06-15 13:21:01 +01:00
fc40197d39
Fix handling of errors when using "Connect Now?" for new servers. Fixes #1313 .
...
Also fixes #1363 - display the server group properly in server properties.
2016-06-15 12:36:56 +01:00
71ec9ef914
Add stats on Sequences/Functions/Trigger functions collection nodes. Fixes #1299
2016-06-15 11:53:58 +01:00
6b95d6ac75
Added connect now option in server create dialog. Fixes #1313
2016-06-14 17:23:25 +01:00
62c1369938
Add "Move objects..” functionality to tablespace node. Fixes #1286
...
Additionally I have removed pre_9.1 sql's & align SQL line indentation as well.
2016-06-14 14:53:48 +01:00
fe1c86cbbe
Fix SSL mode selection. Fixes #1144
2016-06-14 12:26:07 +01:00
1f9d0ffc54
Fix comment removal for various nodes. Fixes #1331
2016-06-13 16:22:50 +01:00
c331b514a9
Auto-close the date picker when selecting a role expiry date. Fixes #1327
2016-06-10 17:13:06 +01:00
fcd33162a9
Fix role valid until date handling. Fixes #1107
2016-06-10 16:12:51 +01:00
d5a91c969c
Ensure the properties dialogues create objects in a single transaction/statement. Fixes #1107
2016-06-10 16:07:24 +01:00
802840fd7f
Fix various cosmetic issues with preference dialog
...
1. Foreign keys listed twice
The label for Exclusion constraint was set to 'Foreign keys'. fixed it.
2. Trigger function, Unique constraint, Primary key should be in title case
3. if user click outside of Preferences window it disappear (it should not disappear)
set preference alertify dialog option closableByDimmer to false.
4. Columns node settings listed twice
Override the register_preferences method in Columns CatalogObjectColumnsModule class
because there are two types of columns node, catalogs columns and tables columns.
so the settings for table columns should also work for catalog columns. Thats why we are not showing preference option for catalogs column node.
Ashesh fixed this issue.
2016-06-08 13:29:49 +01:00
d7f5e95b2b
Fix unwanted space indentation issue in Database node.
2016-06-08 12:56:56 +01:00
4ace8bb5b6
Statistics support remaining object types that support them.
2016-06-07 13:16:12 +01:00
20a22731e0
Fix incorrect condition checking for privileges.
2016-06-07 12:37:02 +01:00
7f1e57c2a6
Remove the header controls of subnode control properly, when removing it
...
from the VariableControl, and the customized TokenControl in the
fts_configuration javascript module during clean up process.
2016-06-06 18:53:19 +05:30
9ed2530b1f
Fixes #1110 - Proper validation for the security labels.
2016-06-06 18:07:13 +05:30
6dbfb7db7e
Fixes #1273 - Resolved an issue setting privileges on the SHELL type.
2016-06-03 15:58:10 +05:30
c14ff8e15e
Fixes #1300 - Honour show system object in the table dialog, and do not
...
show catalog schema tables.
2016-06-03 15:45:13 +05:30
6036c431b0
Fixes #1283 , #1287 - Do not show null description in the create mode,
...
corrected the index expression on table node.
Reported by Thom Brown.
2016-06-03 15:41:24 +05:30
8b54b59f2b
Fixes #1285 - Update the comments (description) over the tablespace
...
properly.
2016-06-03 15:36:47 +05:30
9436542074
Fixes #1223 - Do not allow to drop user from non-super user.
...
Also - fixed some javascript variable scope issue in the 'delete_obj'
function of nodes.
2016-06-03 15:32:33 +05:30
ab9f63d960
Fixes# 1210 - Send the columns SQL with proper mime type.
2016-06-03 15:24:39 +05:30
40ab0b7c88
Fixes #1298 - ACL for the SEQUENCE node were not parsed properly.
2016-06-03 15:23:14 +05:30
8313bc9b8a
Do proper validation of the server node.
2016-06-03 06:29:23 +05:30
e47671edaa
Table dialog and backup tool docs
2016-06-02 14:05:46 +01:00
1f25e90fa4
Fixes #1276 - Resolved an issue - 'TypeError: c is undefined on removing
...
member type from Type=composite'.
2016-06-02 15:31:07 +05:30
e18b135f6f
Rename the 'Auto Vacuum' tab to 'Parameter' as it represents 'Storage
...
Parameters'.
2016-06-02 15:28:32 +05:30
2610eaefbe
Fixes# 1290 - Use qtLiteral with parameterized values.
...
When not using qtLiteral, it was result into an error - "unknown
error displayed when modify comments which may special characters on
Materialized view".
2016-06-02 15:08:24 +05:30
60208b7ae5
Fixes an issue rendering the dashboard, when data object is missing.
...
Also, fixed an issue checking the existence of the data object before
accessing it in schema javascript module.
2016-06-02 14:58:14 +05:30
486da5e12c
Fixed issue only coming in the runtime.
...
* Do not need to translate an empty string. (that results into the
translation header inclusion in the javacript module).
* String.prototype.StartsWith is not an well received function, it has
not been available in the QWebkit for linux.
2016-06-02 13:15:26 +05:30
4482bbb1ba
Fixed a typo in Type node javascript module.
2016-05-31 23:29:50 +05:30
b4d195aafe
Fixes #1278 - Load the foreign server node javascript module when
...
databases (not when servers) are being loaded.
2016-05-31 23:26:55 +05:30
Harshal Dhumal
Khushboo Vashi
George Gelashvili
Dave Page
Murtuza Zabuawala
Surinder Kumar
Atira Odhner
George Gelashvili
Navnath Gadakh
Neel Patel
Anthony DeBarros
Akshay Joshi
Dan Vianello
Priyanka Shendge
Susan Douglas
Ashesh Vashi
Magnus Hagander
Sanket Mehta
Khushboo Vashi