Commit Graph

3263 Commits (cd94167fc8ba4d53257acef7f055f0aa44f37358)

Author SHA1 Message Date
nickmancari 229a721a84 fixed lint error 2023-02-02 05:45:43 -06:00
nickmancari d91847d6cf corrected the flag output 2023-02-01 21:08:53 -06:00
nickmancari 1db52e77b4 added flag 2023-02-01 15:34:37 -06:00
Sudharsan Rangarajan 7ce7244596 Incorrect field name being passed to info print statement for Mount Type 2023-01-28 09:53:22 +05:30
Steven Powell 0fbb9a6a31 update comments and store socket_vmnet paths in machine config 2023-01-25 10:45:20 -08:00
Steven Powell 46e9cc24ee check brew install paths for socket_vmnet 2023-01-24 11:51:17 -08:00
Steven Powell 5dbb92fbee update message 2023-01-19 15:08:03 -08:00
Steven Powell eb884228a4 warn users if using VirtualBox on macOS 13+ 2023-01-19 15:08:01 -08:00
Predrag Rogic 15bb620ca1
Merge branch 'master' into fix-TestNetworkPlugins-Linux_Docker 2023-01-18 02:43:47 +00:00
Medya Ghazizadeh 1b124462b1
Merge pull request #15611 from afbjorklund/numcpu-docker
Allow running docker driver with force on 1 CPU
2023-01-17 10:30:31 -08:00
Akihiro Suda ba11072162
main: propagate the current Docker CLI context to $DOCKER_HOST
So that google/go-containerregistry can pick it up

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2023-01-12 08:13:03 +09:00
Predrag Rogic 24226c5f5a
Merge branch 'master' into fix-TestNetworkPlugins-Linux_Docker 2023-01-10 22:44:50 +00:00
Anders F Björklund 83d4219fee Allow running docker driver with force on 1 CPU 2023-01-08 18:19:11 +01:00
Steven Powell 6e2511d9f1 add example of static IP in docs 2023-01-04 13:22:57 -08:00
Predrag Rogic 149e9a01b6
Merge branch 'master' into fix-TestNetworkPlugins-Linux_Docker 2023-01-04 21:10:29 +00:00
Steven Powell e6d95b8230 implement --static-ip flag 2023-01-04 10:27:00 -08:00
Shubh Bapna 5f18b0d310 wrapped error when validate subnet fails to parse address 2023-01-04 01:27:08 -05:00
Shubh Bapna 474a56b50c added comments and improved error message for validateSubnet 2022-12-23 08:44:57 -05:00
Shubh Bapna 7466acb3e8 moved bare metal validation to a separate function 2022-12-22 16:11:39 -05:00
Shubh Bapna 37098ababa added subnet validator and its test cases 2022-12-17 14:40:37 -05:00
Predrag Rogic 4e0994c43e
Merge remote-tracking branch 'upstream/master' into fix-TestNetworkPlugins-Linux_Docker 2022-12-17 17:57:34 +00:00
Predrag Rogic 72c8acc370
fix Docker_Linux and multinode 2022-12-13 03:35:16 +00:00
Steven Powell ff95fc7dc9 change cpus config field to string to support max value 2022-12-07 10:53:16 -08:00
Steven Powell 63934002d8 update golang.org and godoc.org links 2022-11-30 10:49:57 -08:00
Chris Kannon 2a86770a92
Merge branch 'master' into master 2022-11-17 09:58:49 -05:00
ckannon c4c05a78eb Remove startup error message on older version of ISO, sent to log instead 2022-11-17 09:51:23 -05:00
Steven Powell a5de48aef9
Merge pull request #15308 from Juneezee/test/t.Setenv
test: use `T.Setenv` to set env vars in tests
2022-11-16 14:32:54 -05:00
Steven Powell a800f27580 move license command to other section in help 2022-11-16 11:21:00 -05:00
Medya Ghazizadeh ccb569fabf
Merge pull request #15336 from prezha/fix-kubelet-localStorageCapacityIsolation-option
fix kubelet localStorageCapacityIsolation option
2022-11-14 09:54:22 -08:00
Predrag Rogic 28beac4edb
fix kubelet localStorageCapacityIsolation option for different k8s versions 2022-11-09 22:56:29 +00:00
ckannon 3198d106dc Renamed validateKicBaseVersion, fixed PR comments. 2022-11-09 09:40:10 -05:00
Eng Zer Jun 9d85be1a99
test: use `T.Setenv` to set env vars in tests
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.Setenv
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-11-08 10:30:29 +08:00
Steven Powell e2679ccd7a add additional memory overhead for VirtualBox 2022-11-07 16:06:55 -05:00
Chris Kannon bd11be75b8
Merge branch 'master' into master 2022-11-04 14:07:20 -04:00
Steven Powell 8bd593b433
Merge pull request #15266 from spowelljr/detectSocket
Auto select network on QEMU
2022-11-04 09:38:09 -07:00
Steven Powell ea8fd6c619
Merge pull request #15281 from spowelljr/fixAddonEnableMessages
Prevent enabling `efk` addon due to containing Log4j CVE
2022-11-04 09:36:59 -07:00
Steven Powell 43c4e59a60 disable efk addon 2022-11-03 16:38:59 -07:00
Rahil Patel d7baa13960
fix spelling and grammar in Go files 2022-11-03 18:31:44 -04:00
Chris Kannon 00486c3fd6
Merge branch 'master' into master 2022-11-02 15:09:58 -04:00
Chris Kannon 320c41f80e Added version.json to kicbase image and version validation to start.go.
Added CHANGELOG to kicbase and ISO.
Updated gh to latest version 2.18.1.
2022-11-02 14:17:41 -04:00
Steven Powell 3568d657ab auto select network on QEMU 2022-11-01 14:18:43 -07:00
Steven Powell 074e681975
Merge pull request #15160 from agarwalnit/master
Added cloud-spanner emulator add-on.
2022-10-28 13:58:41 -07:00
Steven Powell 253c006721
Merge pull request #15126 from spowelljr/dockerDesktopLinux
use port forwarding on Linux with Docker Desktop
2022-10-25 11:04:03 -07:00
Nitin Agarwal 909ac67151 Added cloud-spanner emulator add-on. 2022-10-20 23:16:53 +00:00
Steven Powell 289e3bcbf2 change command to license 2022-10-20 10:51:27 -07:00
Steven Powell 643fed94f1 added link to Docker Engine instructions 2022-10-18 10:00:23 -07:00
Steven Powell 8905963ff9 add credits command 2022-10-17 15:22:33 -07:00
Steven Powell 33ad232606 add warning to users using Docker Desktop on Linux 2022-10-12 15:23:01 -07:00
Steven Powell 6bcef35331 exit if mounting with user network 2022-10-11 14:29:33 -07:00
Steven Powell f981dd1527
Merge pull request #15081 from klaases/warn1
Warn if addon has no associated Github username
2022-10-10 10:12:31 -07:00
Steven Powell 399a60eb86
Merge pull request #15085 from spowelljr/fixPortValidation
Allow passing only exposed port to --ports
2022-10-07 14:39:43 -07:00
Steven Powell 26ff0aa2d2 allow only passing exposed port to --ports 2022-10-07 10:56:58 -07:00
klaases f6d3bf0515 remove check for unknown maintainer 2022-10-06 16:25:50 -07:00
klaases 43d0753d78 warn if addon has no associated github username 2022-10-06 16:11:53 -07:00
Steven Powell 6d00b3e89a mark as unpaused on start & renaming/comments 2022-10-06 14:27:34 -07:00
Steven Powell f1b909e44d add darwin conditionals 2022-10-03 15:17:29 -07:00
Steven Powell 5c27bc4d11 update messaging if using user network 2022-10-03 15:17:29 -07:00
Steven Powell 5fc653ba83 update experimental message and logic 2022-10-03 15:14:39 -07:00
Steven Powell ad1951ab80 rename socket to socket_vmnet 2022-10-03 15:14:39 -07:00
Steven Powell 8c12c40853 implement socket_vmnet 2022-10-03 15:14:36 -07:00
Steven Powell ab9130bf2d
Merge pull request #14951 from spowelljr/fixLinuxAddressBinding
Use SSH tunnel if user specifies bindAddress
2022-10-03 11:31:31 -07:00
Steven Powell 9fdb6d9bd6 convert another to os.Stdout.Write 2022-09-30 17:06:43 -07:00
Steven Powell 78a64e2534 add update check on status and profile list 2022-09-30 16:53:34 -07:00
Steven Powell b25b13f3f1 close channels in defer 2022-09-29 13:35:10 -07:00
Steven Powell 1ba9792419 fix update check logic 2022-09-21 16:06:21 -07:00
klaases 847b7731c6 improve warning wording 2022-09-20 16:42:38 -07:00
klaases 19f0b18357 issue warning for qemu with socket_vmnet flagset 2022-09-20 16:42:38 -07:00
klaases 787685e073 allow network flag with qemu 2022-09-20 16:42:38 -07:00
klaases 87175c7395 revert changes 2022-09-20 16:42:21 -07:00
klaases 5b7e19e172 fix socketVMnetPath 2022-09-20 16:41:13 -07:00
klaases 18fda4be13 add socket vmnet and client path flags 2022-09-20 16:41:13 -07:00
klaases ef31fc272c disable bail on qemu service 2022-09-20 16:41:13 -07:00
Steven Powell 012146bdbc use SSH tunnel if user specifies bindAddress 2022-09-14 11:57:28 -07:00
Steven Powell 6002db244e fix error message 2022-09-12 11:30:58 -07:00
Steven Powell 2482b4e4de fix unit tests on macOS arm64 2022-08-08 10:20:13 -07:00
Steven Powell 744187868d fix linting 2022-08-08 09:29:19 -07:00
Steven Powell 87d7e3b423
Merge pull request #14695 from spowelljr/limitAuditSize
Limit number of audit entries
2022-08-02 10:15:53 -07:00
Steven Powell 66ff960b61 limit number of audit entries 2022-08-01 14:16:28 -07:00
anoop142 13680ff987 fix linting 2022-08-01 23:00:25 +05:30
anoop142 5b2080f782 Fix url index out of range error in service
* if there is no node port, service panics accessing url
* since the length of array is 3 when there is no node port, accessing u[3] results in
	index out of range
2022-07-28 12:56:05 +05:30
Steven Powell 0d274d5603
Merge pull request #14499 from inifares23lab/master
add VerifiedMaintainer field to Addons and display a warning if empty
2022-07-25 17:00:41 -07:00
inifares23lab 7dfe7e65e4 when enable addons differentiate message for maintainer and verified maintainer 2022-07-20 21:00:35 +02:00
Steven Powell a2a814fa8b
Merge pull request #14589 from spowelljr/toolTip
Update docker-env description and add tooltip
2022-07-15 13:38:46 -07:00
Steven Powell 8fd532dd3a
Merge pull request #14522 from kinvolk/fix_headlamp_tip
Fix Post installation tip for headlamp addon
2022-07-15 13:18:18 -07:00
Santhosh Nagaraj S d9263acf8d Fix Post installation tip for headlamp
Signed-off-by: Santhosh Nagaraj S <santhosh@kinvolk.io>
2022-07-15 15:18:56 +05:30
Steven Powell af662f6b3a update wording 2022-07-14 14:22:11 -07:00
Steven Powell d49a6c8ccf update docker-env description and add tooltip 2022-07-14 10:52:46 -07:00
Steven Powell d89f43518e fix incorrect user and profile in audit logging 2022-07-12 11:40:58 -07:00
inifares23lab 21e00cf796 formatting with 'gofmt -w -s .' 2022-07-06 23:21:51 +02:00
peizhouyu 75a2631baf update start help info
Indicate --network-plugin flag is deprecated in flag description
2022-07-04 11:17:21 +08:00
inifares23lab dfb4860cec display warning for addons with unverified Maintainer 2022-07-03 14:42:40 +02:00
zhouguowei f60aa26c8b prbot need a strike 2022-06-27 09:50:27 +08:00
吴梓铭 360cc86ce5
fix: panic when environment variables are empty
On mac OS, environment variables like: OLDPWD are usually empty. May trigger panics like:
```bash
😄  minikube v1.26.0 on Darwin 11.6.5
panic: runtime error: index out of range [1] with length 1

goroutine 1 [running]:
k8s.io/minikube/cmd/minikube/cmd.displayEnviron({0xc000a69a40?, 0x1c, 0xb?})
	/private/tmp/minikube-20220623-65769-c2xa25/cmd/minikube/cmd/start.go:445 +0x252
k8s.io/minikube/cmd/minikube/cmd.runStart(0x7316040?, {0x5d07e13?, 0x0?, 0x0?})
	/private/tmp/minikube-20220623-65769-c2xa25/cmd/minikube/cmd/start.go:157 +0x245
github.com/spf13/cobra.(*Command).execute(0x7316040, {0x73736d8, 0x0, 0x0})
	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/cobra@v1.5.0/command.go:876 +0x67b
github.com/spf13/cobra.(*Command).ExecuteC(0x7313fc0)
	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/cobra@v1.5.0/command.go:990 +0x3b4
github.com/spf13/cobra.(*Command).Execute(...)
	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/cobra@v1.5.0/command.go:918
k8s.io/minikube/cmd/minikube/cmd.Execute()
	/private/tmp/minikube-20220623-65769-c2xa25/cmd/minikube/cmd/root.go:170 +0xca5
main.main()
	/private/tmp/minikube-20220623-65769-c2xa25/cmd/minikube/main.go:88 +0x255
```
2022-06-24 22:09:40 +08:00
Sharif Elgamal 90fabe158e fix grammar for common minikube start output 2022-06-22 12:13:31 -07:00
Steven Powell 6405bb3185
Merge pull request #14323 from lakshkeswani/master
Don't allow --control-plane=true for node add #14300
2022-06-21 11:02:03 -07:00
Steven Powell e5754a2a7a
Merge pull request #14315 from kinvolk/headlamp_addon
Addon: add headlamp
2022-06-21 10:37:06 -07:00
Nikhil Sharma 9fe8946e66 Made changes so that we get logs when a command starts no matter that it is finished or not 2022-06-16 12:58:06 -07:00
lakshkeswani cc1fba4411 Don't allow --control-plane=true for node add 2022-06-16 11:31:45 +00:00
Santhosh Nagaraj S 26afc8f85c Addon: add headlamp
Signed-off-by: Santhosh Nagaraj S <santhosh@kinvolk.io>
2022-06-16 10:34:18 +05:30
Sharif Elgamal 98c0e9f6c8
Merge pull request #14265 from sharifelgamal/arm64-containerd
Reduce package duplication for ISO building
2022-06-13 16:22:33 -07:00
Sharif Elgamal 6da1a20932
Merge pull request #14301 from sharifelgamal/gcp-auth-timeout
don't special case gcp-auth for enabling addons
2022-06-13 10:47:04 -07:00
Sharif Elgamal 1801630196 Merge branch 'master' of github.com:kubernetes/minikube into arm64-containerd 2022-06-10 17:02:58 -07:00
Kian-Meng Ang bc03821826 Fix typos 2022-06-10 15:26:35 -07:00
Sharif Elgamal 24e2708d91 Merge branch 'master' of github.com:kubernetes/minikube into gcp-auth-timeout 2022-06-10 13:40:07 -07:00
Sharif Elgamal b475b2526d Merge branch 'master' of github.com:kubernetes/minikube into arm64-containerd 2022-06-09 09:44:43 -07:00
Jack Zhang 7c4389c68b update image prefix 2022-06-08 14:31:44 -07:00
Sharif Elgamal 94dd7296d7 Merge branch 'master' of github.com:sharifelgamal/minikube into gcp-auth-timeout 2022-06-08 10:37:18 -07:00
Sharif Elgamal 1f763354ca
Merge pull request #12995 from eliaskoromilas/fpga-operator
InAccel FPGA Operator addon
2022-06-07 15:32:44 -07:00
Sharif Elgamal 8d60734670 small fixes 2022-06-07 12:52:39 -07:00
Sharif Elgamal b465bac75d
Merge pull request #14283 from sharifelgamal/custom-firmware
allow users to supply custom QEMU firmware path
2022-06-06 15:36:23 -07:00
Sharif Elgamal 7b890545b4
Update cmd/minikube/cmd/start_flags.go
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2022-06-06 12:54:56 -07:00
Sharif Elgamal 9cc18c0aa6 allow users to supply custom QEMU firmware path 2022-06-06 12:43:59 -07:00
Nils Fahldieck dfa371652b Update docs usage output 2022-06-04 16:58:50 +02:00
Nils Fahldieck ce08c0bcee Conditionally append docs to tData 2022-06-04 16:58:50 +02:00
Nils Fahldieck fa3ec1433f Add test for disabled/enabled docs 2022-06-04 16:58:50 +02:00
Nils Fahldieck 8be1b154ae Print doc only with enabled option 2022-06-04 16:58:50 +02:00
Nils Fahldieck 967b439993 Use "3rd party (maintainer)" across all strings 2022-06-04 16:56:41 +02:00
Nils Fahldieck 216b63060f Add doc URL to the addon list table 2022-06-04 16:56:41 +02:00
Steven Powell 5fb961c517
Merge pull request #14245 from te-simonren/pr-add-bind-address-for-tunnel
add bind address option for cmd tunnel
2022-06-03 10:00:32 -07:00
Sharif Elgamal b7b5395138 turn off crio for qemu for now 2022-06-02 13:07:18 -07:00
Harsh Vardhan a23d47b569 add active field in config.Profiles
Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>
2022-06-01 15:28:50 +05:30
Harsh Vardhan 066f731654 enhance: add json key for profile list cmd
Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>
2022-06-01 15:28:50 +05:30
Harsh Vardhan 2dc84b1dcd enhance: add active column for profile list cmd
Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>
2022-06-01 15:28:50 +05:30
simonren-tes 2813810bbd
generate doc & opt option string 2022-06-01 10:07:05 +08:00
Sharif Elgamal 1e7c257136 Merge branch 'master' of github.com:sharifelgamal/minikube into arm64-containerd 2022-05-31 14:44:53 -07:00
Sharif Elgamal 4ab16708f4 reconcile translations after extracting escape characters fix 2022-05-31 13:17:46 -07:00
Sharif Elgamal cd01efdf37 upgrade conmon to v2.0.24 2022-05-31 10:43:55 -07:00
simonren-tes 31843939d8
add bind address option for cmd tunnel 2022-05-27 13:50:23 +08:00
Elias Koromilas 6364518066 Add inaccel/fpga-operator addon
Signed-off-by: Elias Koromilas <elias.koromilas@gmail.com>
2022-05-26 10:52:08 +03:00
Predrag Rogic cf3d33aef6
include prereleases 2022-05-20 17:32:30 +01:00
Predrag Rogic 899b43c323
move to 'config defaults' 2022-05-20 17:32:30 +01:00
Predrag Rogic 219abcc1f1
fix json and yaml outputy 2022-05-20 17:32:30 +01:00
Predrag Rogic 88acdd018d
use GetTagName from release 2022-05-20 17:32:30 +01:00
Predrag Rogic eff4a18375
list all currently supported Kubernetes versions 2022-05-20 17:32:13 +01:00
Steven Powell 09365b4b04
Merge pull request #14175 from minikube-bot/auto_bump_golint_version
bump golint version
2022-05-16 13:21:06 -07:00
Steven Powell 53fdfb286c implement lint fixes 2022-05-16 12:48:41 -07:00
Sharif Elgamal 7292031c08
Merge pull request #13912 from kadern0/issue-12643
feat: added configure option to registry-alieases addon
2022-05-16 11:33:40 -07:00
Sharif Elgamal 17a8bc4e7b exit cleanly for unimplmented beta features 2022-05-12 09:44:38 -07:00
Sharif Elgamal 00d31d04ba Merge branch 'master' of github.com:kubernetes/minikube into anders-qemu2 2022-05-11 09:06:36 -07:00
ckannon 9360f907e3 Accept space before port in DashboardProxy Regex 2022-05-10 09:18:39 -04:00
Sharif Elgamal 5b39a46773 Merge branch 'master' of github.com:kubernetes/minikube into anders-qemu2 2022-05-03 14:01:09 -07:00
Steven Powell 58eed153fa
Merge pull request #13991 from EdwinWalela/edwin-dev
Add --audit flag to minikube logs command
2022-04-22 16:46:10 -07:00
Steven Powell fd718348cd remove setting event log path on delete 2022-04-22 11:34:14 -07:00
Medya Ghazizadeh e77e17b9ae
Merge pull request #13979 from spowelljr/deleteJSON
Add JSON output to `minikube delete`
2022-04-21 14:06:47 -07:00
Steven Powell caf8e6402e fix having flag before command cause problems 2022-04-20 15:12:20 -07:00
edwinwalela 46849037b2 add --audit flag to minikube logs command 2022-04-20 20:23:07 +03:00
Steven Powell df9b2c8541 add JSON output to delete 2022-04-18 16:52:31 -07:00
Medya Ghazizadeh 2c776978d9
Merge pull request #13856 from t-inu/issue12809
Improve description for minikube cache command
2022-04-18 15:54:40 -07:00
Toshiaki Inukai 18d20407c6 Improve description for minikube cache command 2022-04-14 10:31:54 +00:00
Medya Ghazizadeh 2b5a15fe19
Merge pull request #13957 from klaases/force1
Advise user of --force option when using root
2022-04-13 11:42:47 -07:00
Sharif Elgamal a9cf4750b0
Merge pull request #13812 from tyabu12/fix/port-validation
Fix port validation error on specifying tcp/udp or range of ports.
2022-04-13 09:01:56 -07:00
klaases d5a3fc48fd Adjust message for clarity 2022-04-12 15:26:26 -07:00
klaases 6787bcf6b2 Advise user of --force option when using root 2022-04-12 15:25:17 -07:00
Pablo Caderno 522c1a3274 feat: added configure option to registry-alieases addon
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2022-04-13 08:01:06 +10:00
Sharif Elgamal ad5c964e6b
Merge pull request #13829 from AkihiroSuda/rootless-podman-take2
Support rootless Podman driver, take 2 (Usage: `minikube config set rootless true`)
2022-04-12 11:19:30 -07:00
Anders F Björklund d21342c69f Make sure to look for KIC before using oci port 2022-04-05 20:02:08 +02:00
Akihiro Suda 92ab555928
Support rootless Podman driver, take 2
Usage:
```
minikube config set rootless true
minikube start --driver=podman --container-runtime=(cri-o|containerd)`
```

Tested on Podman 4.0.2, Ubuntu 21.10.

Needs cgroup v2 (as in Rootless Docker): https://rootlesscontaine.rs/getting-started/common/cgroup2/
See also `site/content/en/docs/drivers/includes/podman_usage.inc`

Fix issue 8719
Fix issue 12460
Replace PR 12901

Changes from PR 12901: `rootless` is now a config property.
In the previous PR, `--rootless` was implemented as a flag for `minikube start`

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2022-04-05 18:49:40 +09:00
Anders F Björklund 6a7f14ea01 Use the right port for docker in qemu driver 2022-04-04 20:18:51 +02:00
Steven Powell 2e4ea3c259 replace MkdirTemp with t.TempDir in tests 2022-04-01 19:18:20 -07:00
Steven Powell 1aa1f04e9b remove old build tags 2022-03-30 16:43:29 -07:00
Sharif Elgamal 31d1fdae3b
Merge pull request #13730 from presztak/subnet_flag
Add 'subnet' flag for docker/podman driver
2022-03-30 16:02:54 -07:00
Steven Powell 37e026b149 stop testing olm and warn users about the addon 2022-03-30 10:53:11 -07:00
Steven Powell 9549bef504 don't write logs that contain environment variables 2022-03-29 11:09:11 -07:00
Steven Powell 6e73112be6 change soft to silent 2022-03-28 16:47:33 -07:00
Steven Powell 93bb522986 soft fail when user trying to generate log file if cluster not running 2022-03-28 16:44:16 -07:00
Medya Ghazizadeh aa007da3fe
Merge pull request #13805 from klaases/autop1
Improve autopause error handling
2022-03-25 11:51:16 -07:00
Tomohito YABU afb3956fdb Add comment to TestValidatePorts. 2022-03-24 09:34:04 +09:00
Tomohito YABU 1832ed6ff5 Update validatePorts function comment for goDoc. 2022-03-23 13:21:33 +09:00
klaases 5a3877cfc5 Prefer out.Styled to out.Step, revert copyright 2022-03-21 11:49:26 -07:00
Tomohito YABU 513a757ca7 Fix port validation error on specifying tcp/udp or range of ports. 2022-03-19 10:51:43 +09:00
Predrag Rogic deb5a574b6
bump golangci-lint to v1.45.0 2022-03-18 19:57:22 +00:00
klaases f549634f59 Improve autopause error handling 2022-03-16 14:36:51 -07:00
Steven Powell 76d97af2a0 add disable-metrics flag 2022-03-16 11:00:20 -07:00
ckannon 701b4be842 Fix flow to support docker driver properly for mac, for issue #13746 2022-03-09 14:30:49 -05:00
Piotr Resztak cbdd447543 add 'subnet' flag 2022-02-27 16:56:05 +01:00
Steven Powell 70a98e34ab
Merge pull request #13053 from tmcalves/validations_on_image_repository
Fixes validation on image repository URL when it contains port but no scheme
2022-02-18 13:42:04 -08:00
Piotr Resztak a0b30b6d56 fix SIGSEGV in kubectl when k8s not running 2022-02-18 16:24:58 +01:00
Tiago Alves a9d3fe2906 Fixes validation on image repository URL when it contains port but not schema
Refactor the way validations are done to use regular expression
Explicitly use "auto" as the imageRepo instead of an empty string when URL received is invalid
2022-02-16 21:54:48 +00:00
Medya Ghazizadeh d6120f131e
Merge pull request #13367 from ckannon/master
Adds 'minikube service --all' feature to allow forwarding all services in a namespace
2022-02-09 12:24:54 -08:00
ckannon c8d846d6c1 minikube #13075 adds --all feature for service 2022-02-09 10:12:01 -05:00
Todd MacIntyre 0d677cb71b fix documentation typo for minikube image load command 2022-02-08 15:13:24 -08:00
Medya Ghazizadeh 8f41ad572a
Merge pull request #13547 from spowelljr/updateNotifyStructure
Update notify package to support `releases-v2.json`
2022-02-07 16:35:07 -08:00
Sharif Elgamal 5e54044127
Merge pull request #13354 from nishipy/issue-11627
Add exit message for too new Kubernetes version
2022-02-03 15:19:38 -08:00
Sharif Elgamal 423b816311
Merge pull request #13251 from afbjorklund/default-runtime
Make the default container runtime dynamic
2022-02-02 18:02:05 -08:00
Steven Powell d01c77d816 update notify package to support releases-v2.json 2022-02-02 16:39:57 -08:00
Medya Ghazizadeh 969b5cddf1
Merge pull request #13520 from minikube-bot/auto_bump_golint_version
bump golint version to v1.44.0
2022-02-02 15:57:24 -08:00
Medya Ghazizadeh 30b187f04d
Merge pull request #13514 from presztak/service_docker_hard_coded
Fix hard coded docker driver in minikube service command
2022-02-01 13:24:45 -08:00
Medya Gh c24818d9b7 lint 2022-02-01 13:21:53 -08:00
Sharif Elgamal 634b8030f9 Merge branch 'master' of github.com:kubernetes/minikube into anders-default-runtime 2022-02-01 12:59:09 -08:00
Sharif Elgamal 034f55696d
Merge pull request #13326 from gAmUssA/addons/kong
[Addon] Kong Ingress Controller
2022-01-31 17:15:54 -08:00
nishipy 9da7049f8a Currently, no warn or exit are there even if user specifies
any version newer than newestKubernetesVersion.
This fixes the flow as follows:
if not --force:
- Warn but do NOT exit for newer minor version and patch version
- Warn and Exit for newer major version

if --force: Warn but try anyways
2022-01-30 07:27:23 -05:00
Piotr Resztak dd431d36c2 remove hard coded docker driver 2022-01-30 00:08:23 +01:00
Steven Powell c5b1c56f57
Merge pull request #12835 from presztak/remove_kicbase_image_info
Print a message about preserving kicbase image when `minkube delete --purge --all` used
2022-01-27 21:23:27 -08:00
nishipy dc1b226562
Update cmd/minikube/cmd/start.go
Co-authored-by: Sharif Elgamal <selgamal@google.com>
2022-01-26 15:32:09 +09:00
Steven Powell fa5f67cc95
Merge pull request #13340 from spowelljr/addDisableOptimization
Add `--disable-optimizations` flag
2022-01-24 18:51:42 -08:00
Steven Powell 398906ebd7 generate-docs 2022-01-24 17:09:11 -08:00
Steven Powell 3eaf0f627c
Update cmd/minikube/cmd/start_flags.go
Co-authored-by: Medya Ghazizadeh <medyagh@users.noreply.github.com>
2022-01-24 17:07:57 -08:00
Steven Powell 3a4b676199 list optimizations in flag 2022-01-24 17:00:26 -08:00
Piotr Resztak 0f9564be88 remove hardcoded docker driver 2022-01-23 22:24:17 +01:00
nishipy 7aafb2ddce Add exit message for too new Kubernetes version 2022-01-15 11:18:34 -05:00