kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #13514 from presztak/service_docker_hard_coded 

Fix hard coded docker driver in minikube service command
pull/13538/head
Medya Ghazizadeh 2022-02-01 13:24:45 -08:00 committed by GitHub
parent 2cbe070b94 dd431d36c2
commit 30b187f04d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/minikube/cmd/service.go
View File

@ -93,7 +93,7 @@ You may select another namespace by using 'minikube service {{.service}} -n <nam
}
if driver.NeedsPortForward(co.Config.Driver) {
startKicServiceTunnel(svc, cname)
startKicServiceTunnel(svc, cname, co.Config.Driver)
return
}
@ -111,7 +111,7 @@ func init() {
serviceCmd.PersistentFlags().StringVar(&serviceURLFormat, "format", defaultServiceFormatTemplate, "Format to output service URL in. This format will be applied to each url individually and they will be printed one at a time.")
}
func startKicServiceTunnel(svc, configName string) {
func startKicServiceTunnel(svc, configName, driverName string) {
ctrlC := make(chan os.Signal, 1)
signal.Notify(ctrlC, os.Interrupt)
@ -120,7 +120,7 @@ func startKicServiceTunnel(svc, configName string) {
exit.Error(reason.InternalKubernetesClient, "error creating clientset", err)
}
port, err := oci.ForwardedPort(oci.Docker, configName, 22)
port, err := oci.ForwardedPort(driverName, configName, 22)
if err != nil {
exit.Error(reason.DrvPortForward, "error getting ssh port", err)
}