18ff76add7
Merge pull request #15074 from ComradeProgrammer/fix_15007
...
fix: handle DOS-style path for Dockerfile in minikube build
2023-06-12 10:39:07 -07:00
c301dacf93
Remove extra references to docker machine
...
Should only use libmachine and the drivers
2023-06-11 14:35:40 +02:00
0a551357b4
Remove the obsolete vmwarefusion driver
...
It just referred to the "vmware" driver
2023-06-11 14:16:17 +02:00
1cc6c0a29c
Update cmd/minikube/cmd/service.go
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-06-10 21:43:08 +08:00
0bb29fe744
Update cmd/minikube/cmd/image.go
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-06-10 21:30:26 +08:00
76950ebdf0
fix: handle DOS-style path for Dockerfile in minikube build
2023-06-08 08:31:50 +08:00
12c4bf5f1d
Add ability to create extra disks on qemu2 vms
...
Add the ability to create and attach extra disks to qemu2 vms.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2023-06-06 16:28:19 -06:00
55868b1736
fix: quit minikube service when there is no available pods
2023-06-05 16:16:02 -07:00
7489d959a8
Merge pull request #16609 from spowelljr/changeAddonOwners
...
Update addon owners
2023-06-05 12:38:15 -07:00
37d82ecef4
Merge pull request #16610 from spowelljr/automateUpdatingKubernetesVersionsList
...
CI: Automate updating Kubernetes versions list
2023-06-05 12:37:40 -07:00
0168d63fc8
Merge pull request #16569 from JudahNour/addKubernetesVersions
...
--kubernetes-version: assume latest patch version if not specified by user
2023-06-01 10:50:20 -07:00
1079f9b631
CI: Automate updating Kubernetes versions list
2023-05-31 15:16:09 -07:00
5a1b0a14d6
update addon owners
2023-05-31 14:12:34 -07:00
852d9197a1
Refactored code and modified/added tests
2023-05-31 16:55:54 +00:00
c81a3172a4
Refactored code, updated error messages, and generated docs
2023-05-31 15:22:50 +00:00
c2c3f2996d
Add testing for isTwoDigitSemver and changed messages to user.
...
Corrected bug with version prefixes
2023-05-30 20:11:51 +00:00
e01610a0f3
Modified to alert user and exit when there is no associated patch
...
for the major.minor given
2023-05-25 21:51:35 +00:00
cbd577878e
--kubernetes-version: making case insensitive and refactoring handling
2023-05-24 20:26:58 +00:00
3afc728238
modified so alerts user that the patch version is assumed
2023-05-24 16:44:14 +00:00
b0892d0b8e
use ValidKubernetesVersions list for config defaults
2023-05-23 16:31:19 -07:00
a81e4f76ac
accept kubernetes version without patch version
2023-05-23 19:27:26 +00:00
dda802b332
none driver: fix image build
2023-04-26 18:57:16 -07:00
8931619b01
Applied suggestions
2023-04-25 15:11:41 +03:00
455bcb19ef
refactors removePid logic
2023-04-22 13:32:45 +03:00
aab0cb6d2a
Adds mechanism to remove pid from pidfile if mount is sigtermd
2023-04-22 00:50:00 +03:00
3d3e6a14e7
added stuff to reflect suggestions
2023-04-22 00:49:30 +03:00
b196ee46af
Apply suggestions from code review
2023-04-22 00:49:30 +03:00
0170981567
Saves us from passing func as parameter
...
:)
2023-04-22 00:49:30 +03:00
b09cd43e1d
Corrects style issue
2023-04-22 00:49:30 +03:00
8f50ee999a
Corrects mendacious comment
2023-04-22 00:49:30 +03:00
595c8eeeda
Adapts TestTryKillOne log for failing
2023-04-22 00:49:30 +03:00
82abc0dbee
Adapts unit test to new dependency
2023-04-22 00:49:30 +03:00
c55a4caacc
Adds the ownership check as a dependency
...
Otherway I see no obvious way to pass this check
during (say) unit testing
2023-04-22 00:49:30 +03:00
d72f2fb285
Changes pid owner conditional
...
What happened in the failed integration tests was that the starting
process was not "minikube", it was "minikube-linux-" and
"minikube-darwin-" instead.
2023-04-22 00:49:30 +03:00
ddec3100b9
Ensures sigkilling only minikube started processes
...
Adds a helper function to check that the executable name
is minikube.
2023-04-22 00:49:30 +03:00
b5e59b5db4
Renames sigkill function
2023-04-22 00:49:30 +03:00
1d5b316fda
Makes comment more clear
2023-04-22 00:49:30 +03:00
b368c64bb6
Update cmd/minikube/cmd/delete.go
2023-04-22 00:49:30 +03:00
db14047b65
Changes helper killProcess function name
2023-04-22 00:49:30 +03:00
43ff38b27d
Changes variable name in test
2023-04-22 00:49:30 +03:00
ee22b47795
Apply suggestions from code review
2023-04-22 00:49:30 +03:00
51e46b6d8d
Refactors GetPids
...
Moves GetPids inside cmd/delete.go as a helper function
Adds description
2023-04-22 00:49:30 +03:00
ead0b401ae
Changes name to unittest tool
2023-04-22 00:48:58 +03:00
badc971403
Adds source for cross platform killable process to test
...
As a way to clean the minikube repo dir.
2023-04-22 00:48:58 +03:00
b1bd26ab06
Adds unit test for new helper function tryKillOne
...
also adds that pleasedontkillme pkg, for the trykillone to be
tested against, so that we can run unit tests cross-platform:
no sure exec.Command("sleep", ....) is avail on windows...
2023-04-22 00:48:58 +03:00
3f47e72752
Modularizes killProcess()
...
adds helper functions for killing one process, given one pid
adds helper function to read pids out of a given pidfile
2023-04-22 00:48:34 +03:00
07d20708a5
Corrects error handling in killProcess
...
If we encountered just one err, we're returning it
If we're returning multiple errors, we're outing 'em
and return a multiple-errors error
2023-04-22 00:47:06 +03:00
9d4f296c1f
Adjusts mount processes cleaning logic
...
The delete mechanism called by the --kill flag logic
inside the minikube mount command, relies on a .mount-process file
inside the .minikube dotfolder in home directory.
For this to work, the mount should've been instantiated
by some mechanism that also creates the file; like
k8s.io/minikube/pkg/minikube/node.configureMounts()
To just add the local.WriteFile() logic from configureMounts()
is not enough for the usecase in #15778 :
user's consequent "minikube mount" calls would break the cleaning
logic, since the file's content gets overwritten at each new call.
So on subsequent minikube mounts, a call to "minikube mount
--kill=true" would remove just the last pid, leaving the other
mounts unaltered, and no trace of them in any place...(leak?)
For the same mechanism to work here,
we should rely on some local.AppendFile() function, to add
separated pids consequently.
This way only "minikube mount" would use this new append logic,
leaving unaltered the other functions.
We now have a new behaviour for the .mount-process file,
in order to address this, we should modify the delete logic from
cmd/minikube/cmd/delete.go -- killProcess(),
so that we can both kill a single pid, as well as multiple
space-separated pids in the same way.
...
Ah yes..
we're slightly modifying the "minikube mount" RunE anon function,
in order to write the pid into the .mount-process file;
as well as modifying cluster.Mount()'s signature to accept the pid.
That should be more than safe, since cluster.Mount() is used only here
2023-04-22 00:47:06 +03:00
c30c183dac
remove deprecated functions
2023-04-12 15:03:13 -07:00
9d9403c50f
Merge pull request #16206 from spowelljr/checkForScannerErrors
...
cleanup: Check for scanner errors
2023-04-11 10:54:38 -07:00
4a8688218d
Add PowerShell code completion
...
Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com>
2023-04-07 22:58:47 +02:00
15b0ad0e13
update message
2023-04-04 11:15:24 -07:00
2f17549d79
add exit message if user tries to use virtualbox driver
2023-04-04 09:29:36 -07:00
ae7b5dc362
Require crictl to be installed for none driver
...
Before Kubernetes 1.24, it was possible to use the Docker runtime
without installing the "crictl" debugging tool (from cri-tools).
2023-04-02 22:05:57 +02:00
5dd0f26cd7
cleanup: Check for scanner errors
2023-03-31 11:15:34 -07:00
51474d4327
Merge pull request #16174 from spowelljr/noneDriverVersion
...
none driver: don't check for kicbase/ISO version
2023-03-27 16:31:02 -07:00
b296ae8c47
Merge pull request #16139 from kadern0/issue-15432
...
Fix: check if addon is enabled before doing validation
2023-03-27 14:42:07 -07:00
f86772b487
none driver: don't check for kicabse/ISO version
2023-03-27 13:52:42 -07:00
af02a8522a
Fix: check if addon is enabled before doing validation
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2023-03-25 18:46:22 +11:00
10145a2381
Merge pull request #15834 from OmSaran/tunnel
...
Ensure only one instance of tunnel process runs
2023-03-24 10:03:15 -07:00
5c261e80e9
Fix: check if addon is enabled before doing validation
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2023-03-24 09:15:30 +11:00
56c99ef91b
Fix: check if addon is enabled before doing validation
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2023-03-23 18:28:23 +11:00
7f1383fb89
Revert: "Add shell completion for minikube kubectl subcommand"
2023-03-22 13:33:46 -07:00
b0547a1caf
Remove unnecessary file creation for lock
2023-03-22 00:53:03 -05:00
50e9147e4e
fix lint errors
2023-03-20 12:43:07 -07:00
50b0730e5d
Merge pull request #15984 from spowelljr/fixAddons
...
Fix image related bugs when enabling addons
2023-03-10 11:11:41 -08:00
949ab16609
use decoder
2023-03-09 13:34:09 -08:00
270a985651
test: Fix having to change test byte size on new addon
2023-03-09 11:35:09 -08:00
1c0bc567dd
fixup error messaging
2023-03-07 11:40:30 -08:00
0db6f80b09
Fix format specifiers
2023-03-07 11:11:40 -08:00
0930723c09
Handle unexpected error for lock acquisition
2023-03-07 11:11:40 -08:00
09e6aff951
Simplify error handling for file lock in tunnel command
2023-03-07 11:11:40 -08:00
d8a920fd39
Rename function, update comment and update error message
2023-03-07 11:11:40 -08:00
e8625a3ba0
Add test to ensure no two tunnels can run simultaneously.
...
Add new error reason to disallow simultaneously running two tunnel processes
When tunnel fails to acquire lock due to contention, exit gracefully
2023-03-07 11:11:40 -08:00
cb71c5c5f0
Move tunnel locking to a func and add cleanup of lock
2023-03-07 11:11:40 -08:00
0319f4c1c0
Ensure only one instance of tunnel process runs
2023-03-07 11:11:40 -08:00
93a8607044
fix image related bugs when enabling addons
2023-03-06 14:19:18 -08:00
f2683edfb9
Merge pull request #15911 from spowelljr/fixMinikubeServiceList
...
minikube service list: fix table format & hide URLs
2023-02-22 19:57:04 -08:00
ca3bcae87a
remove unnecessary duplicated calls to NeedsPortForward
2023-02-22 13:59:48 -08:00
3c538f400a
minikube service list: fix table format & hide URLs
2023-02-22 13:50:47 -08:00
707562b735
Merge pull request #15866 from swastik959/json
...
added detail json for addons
2023-02-22 13:12:19 -08:00
6cc5ddc4ae
Merge pull request #15831 from OmSaran/main
...
Add ability to get json for "minikube service list"
2023-02-22 09:31:19 -08:00
c721b056fc
Make table and json output consistent
2023-02-21 20:06:31 -06:00
14b32a040b
added linting and fixed ubit test
2023-02-18 10:30:32 +05:30
fbce562099
add a new flag called --skip-aduit
2023-02-16 12:56:03 -08:00
1ca885c1b3
Optimized
2023-02-16 22:31:59 +05:30
1d5c6ef2a2
corrected
2023-02-16 21:53:45 +05:30
cd787da24e
added detail json for addons
2023-02-16 07:41:50 +05:30
e33b5af7b7
Add integration test and fix behvaior on wrong output format for service list
2023-02-15 15:44:48 -06:00
a26f197f0b
change another one to warn
2023-02-15 11:18:09 -08:00
f3266711de
change errorf to warnf for aduit error
2023-02-15 11:01:34 -08:00
313cabe8f7
Fix bash completion for kubectl symlinked to minikube by not adding `--cluster` flag for the `kubectl __complete` subcommand
...
Signed-off-by: Ben Krieger <ben.krieger@intel.com>
2023-02-15 10:36:36 -05:00
1bd9b39d51
Add shell completion for minikube kubectl subcommand
...
Signed-off-by: Ben Krieger <ben.krieger@intel.com>
2023-02-14 14:43:51 -05:00
ba699acc9b
Merge pull request #15731 from p2c2e/mount_msg
...
Print proper value of mount type using info print statement
2023-02-13 15:42:35 -08:00
f0e2e388dd
Add ability to get json for "minikube service list"
2023-02-11 15:33:11 -06:00
fc644b8453
Merge pull request #15793 from spowelljr/tabbedVView
...
QEMU: Rename `user` network to `builtin` and update documentation
2023-02-10 10:33:29 -08:00
0046eba5c3
rename IsBuiltin to IsBuiltinQEMU
2023-02-09 12:07:17 -08:00
c417258f9c
change user network to builtin
2023-02-09 09:48:43 -08:00
c311d9e620
better verb choice for error output
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-02-03 15:33:55 -06:00
383a4c181c
better flag description
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-02-03 15:32:53 -06:00
Steven Powell
Anders F Björklund
Товарищ программист
Товарищ программист
Blaine Gardner
Medya Ghazizadeh
Steven Powell
Judah Nouriyelian
x7upLime
Oldřich Jedlička
Pablo Caderno
Om Saran
swastik959
Medya Gh
Ben Krieger
Nick Mancari