kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Require crictl to be installed for none driver 

Before Kubernetes 1.24, it was possible to use the Docker runtime
without installing the "crictl" debugging tool (from cri-tools).
pull/16215/head
Anders F Björklund 2023-04-02 22:05:57 +02:00
parent 69a13aba7c
commit ae7b5dc362
3 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/minikube/cmd/start.go
View File

@ -1844,6 +1844,12 @@ func validateBareMetal(drvName string) {
exit.Message(reason.GuestMissingConntrack, "Sorry, Kubernetes {{.k8sVersion}} requires conntrack to be installed in root's path", out.V{"k8sVersion": version.String()})
}
}
// crictl is required starting with Kubernetes 1.24, for all runtimes since the removal of dockershim
if version.GTE(semver.MustParse("1.24.0-alpha.0")) {
if _, err := exec.LookPath("crictl"); err != nil {
exit.Message(reason.GuestMissingConntrack, "Sorry, Kubernetes {{.k8sVersion}} requires crictl to be installed in root's path", out.V{"k8sVersion": version.String()})
}
}
}
func exitIfNotForced(r reason.Kind, message string, v ...out.V) {

2
pkg/minikube/reason/reason.go
View File

@ -376,6 +376,8 @@ var (
GuestDrvMismatch = Kind{ID: "GUEST_DRIVER_MISMATCH", ExitCode: ExGuestConflict, Style: style.Conflict}
// minikube could not find conntrack on the host, which is required from Kubernetes 1.18 onwards
GuestMissingConntrack = Kind{ID: "GUEST_MISSING_CONNTRACK", ExitCode: ExGuestUnsupported}
// minikube could not find crictl on the host, which is required from Kubernetes 1.24 onwards
GuestMissingCrictl = Kind{ID: "GUEST_MISSING_CRICTL", ExitCode: ExGuestUnsupported}
// minikube failed to get the host IP to use from within the VM
IfHostIP = Kind{ID: "IF_HOST_IP", ExitCode: ExLocalNetworkError}

1
translations/strings.txt
View File

@ -572,6 +572,7 @@
"Skipped switching kubectl context for {{.profile_name}} because --keep-context was set.": "",
"Some dashboard features require the metrics-server addon. To enable all features please run:\n\n\tminikube{{.profileArg}} addons enable metrics-server\t\n\n": "",
"Sorry, Kubernetes {{.k8sVersion}} requires conntrack to be installed in root's path": "",
"Sorry, Kubernetes {{.k8sVersion}} requires crictl to be installed in root's path": "",
"Sorry, completion support is not yet implemented for {{.name}}": "",
"Sorry, please set the --output flag to one of the following valid options: [text,json]": "",
"Sorry, the IP provided with the --listen-address flag is invalid: {{.listenAddr}}.": "",