Judah Nouriyelian
e01610a0f3
Modified to alert user and exit when there is no associated patch
...
for the major.minor given
2023-05-25 21:51:35 +00:00
Judah Nouriyelian
cbd577878e
--kubernetes-version: making case insensitive and refactoring handling
2023-05-24 20:26:58 +00:00
Judah Nouriyelian
3afc728238
modified so alerts user that the patch version is assumed
2023-05-24 16:44:14 +00:00
Steven Powell
b0892d0b8e
use ValidKubernetesVersions list for config defaults
2023-05-23 16:31:19 -07:00
Judah Nouriyelian
a81e4f76ac
accept kubernetes version without patch version
2023-05-23 19:27:26 +00:00
Steven Powell
dda802b332
none driver: fix image build
2023-04-26 18:57:16 -07:00
x7upLime
8931619b01
Applied suggestions
2023-04-25 15:11:41 +03:00
x7upLime
455bcb19ef
refactors removePid logic
2023-04-22 13:32:45 +03:00
x7upLime
aab0cb6d2a
Adds mechanism to remove pid from pidfile if mount is sigtermd
2023-04-22 00:50:00 +03:00
x7upLime
3d3e6a14e7
added stuff to reflect suggestions
2023-04-22 00:49:30 +03:00
x7upLime
b196ee46af
Apply suggestions from code review
2023-04-22 00:49:30 +03:00
x7upLime
0170981567
Saves us from passing func as parameter
...
:)
2023-04-22 00:49:30 +03:00
x7upLime
b09cd43e1d
Corrects style issue
2023-04-22 00:49:30 +03:00
x7upLime
8f50ee999a
Corrects mendacious comment
2023-04-22 00:49:30 +03:00
x7upLime
595c8eeeda
Adapts TestTryKillOne log for failing
2023-04-22 00:49:30 +03:00
x7upLime
82abc0dbee
Adapts unit test to new dependency
2023-04-22 00:49:30 +03:00
x7upLime
c55a4caacc
Adds the ownership check as a dependency
...
Otherway I see no obvious way to pass this check
during (say) unit testing
2023-04-22 00:49:30 +03:00
x7upLime
d72f2fb285
Changes pid owner conditional
...
What happened in the failed integration tests was that the starting
process was not "minikube", it was "minikube-linux-" and
"minikube-darwin-" instead.
2023-04-22 00:49:30 +03:00
x7upLime
ddec3100b9
Ensures sigkilling only minikube started processes
...
Adds a helper function to check that the executable name
is minikube.
2023-04-22 00:49:30 +03:00
x7upLime
b5e59b5db4
Renames sigkill function
2023-04-22 00:49:30 +03:00
x7upLime
1d5b316fda
Makes comment more clear
2023-04-22 00:49:30 +03:00
x7upLime
b368c64bb6
Update cmd/minikube/cmd/delete.go
2023-04-22 00:49:30 +03:00
x7upLime
db14047b65
Changes helper killProcess function name
2023-04-22 00:49:30 +03:00
x7upLime
43ff38b27d
Changes variable name in test
2023-04-22 00:49:30 +03:00
x7upLime
ee22b47795
Apply suggestions from code review
2023-04-22 00:49:30 +03:00
x7upLime
51e46b6d8d
Refactors GetPids
...
Moves GetPids inside cmd/delete.go as a helper function
Adds description
2023-04-22 00:49:30 +03:00
x7upLime
ead0b401ae
Changes name to unittest tool
2023-04-22 00:48:58 +03:00
x7upLime
badc971403
Adds source for cross platform killable process to test
...
As a way to clean the minikube repo dir.
2023-04-22 00:48:58 +03:00
x7upLime
b1bd26ab06
Adds unit test for new helper function tryKillOne
...
also adds that pleasedontkillme pkg, for the trykillone to be
tested against, so that we can run unit tests cross-platform:
no sure exec.Command("sleep", ....) is avail on windows...
2023-04-22 00:48:58 +03:00
x7upLime
3f47e72752
Modularizes killProcess()
...
adds helper functions for killing one process, given one pid
adds helper function to read pids out of a given pidfile
2023-04-22 00:48:34 +03:00
x7upLime
07d20708a5
Corrects error handling in killProcess
...
If we encountered just one err, we're returning it
If we're returning multiple errors, we're outing 'em
and return a multiple-errors error
2023-04-22 00:47:06 +03:00
x7upLime
9d4f296c1f
Adjusts mount processes cleaning logic
...
The delete mechanism called by the --kill flag logic
inside the minikube mount command, relies on a .mount-process file
inside the .minikube dotfolder in home directory.
For this to work, the mount should've been instantiated
by some mechanism that also creates the file; like
k8s.io/minikube/pkg/minikube/node.configureMounts()
To just add the local.WriteFile() logic from configureMounts()
is not enough for the usecase in #15778 :
user's consequent "minikube mount" calls would break the cleaning
logic, since the file's content gets overwritten at each new call.
So on subsequent minikube mounts, a call to "minikube mount
--kill=true" would remove just the last pid, leaving the other
mounts unaltered, and no trace of them in any place...(leak?)
For the same mechanism to work here,
we should rely on some local.AppendFile() function, to add
separated pids consequently.
This way only "minikube mount" would use this new append logic,
leaving unaltered the other functions.
We now have a new behaviour for the .mount-process file,
in order to address this, we should modify the delete logic from
cmd/minikube/cmd/delete.go -- killProcess(),
so that we can both kill a single pid, as well as multiple
space-separated pids in the same way.
...
Ah yes..
we're slightly modifying the "minikube mount" RunE anon function,
in order to write the pid into the .mount-process file;
as well as modifying cluster.Mount()'s signature to accept the pid.
That should be more than safe, since cluster.Mount() is used only here
2023-04-22 00:47:06 +03:00
Steven Powell
c30c183dac
remove deprecated functions
2023-04-12 15:03:13 -07:00
Medya Ghazizadeh
9d9403c50f
Merge pull request #16206 from spowelljr/checkForScannerErrors
...
cleanup: Check for scanner errors
2023-04-11 10:54:38 -07:00
Oldřich Jedlička
4a8688218d
Add PowerShell code completion
...
Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com>
2023-04-07 22:58:47 +02:00
Steven Powell
15b0ad0e13
update message
2023-04-04 11:15:24 -07:00
Steven Powell
2f17549d79
add exit message if user tries to use virtualbox driver
2023-04-04 09:29:36 -07:00
Anders F Björklund
ae7b5dc362
Require crictl to be installed for none driver
...
Before Kubernetes 1.24, it was possible to use the Docker runtime
without installing the "crictl" debugging tool (from cri-tools).
2023-04-02 22:05:57 +02:00
Steven Powell
5dd0f26cd7
cleanup: Check for scanner errors
2023-03-31 11:15:34 -07:00
Medya Ghazizadeh
51474d4327
Merge pull request #16174 from spowelljr/noneDriverVersion
...
none driver: don't check for kicbase/ISO version
2023-03-27 16:31:02 -07:00
Steven Powell
b296ae8c47
Merge pull request #16139 from kadern0/issue-15432
...
Fix: check if addon is enabled before doing validation
2023-03-27 14:42:07 -07:00
Steven Powell
f86772b487
none driver: don't check for kicabse/ISO version
2023-03-27 13:52:42 -07:00
Pablo Caderno
af02a8522a
Fix: check if addon is enabled before doing validation
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2023-03-25 18:46:22 +11:00
Steven Powell
10145a2381
Merge pull request #15834 from OmSaran/tunnel
...
Ensure only one instance of tunnel process runs
2023-03-24 10:03:15 -07:00
Pablo Caderno
5c261e80e9
Fix: check if addon is enabled before doing validation
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2023-03-24 09:15:30 +11:00
Pablo Caderno
56c99ef91b
Fix: check if addon is enabled before doing validation
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2023-03-23 18:28:23 +11:00
Steven Powell
7f1383fb89
Revert: "Add shell completion for minikube kubectl subcommand"
2023-03-22 13:33:46 -07:00
Om Saran
b0547a1caf
Remove unnecessary file creation for lock
2023-03-22 00:53:03 -05:00
Steven Powell
50e9147e4e
fix lint errors
2023-03-20 12:43:07 -07:00
Steven Powell
50b0730e5d
Merge pull request #15984 from spowelljr/fixAddons
...
Fix image related bugs when enabling addons
2023-03-10 11:11:41 -08:00
Steven Powell
949ab16609
use decoder
2023-03-09 13:34:09 -08:00
Steven Powell
270a985651
test: Fix having to change test byte size on new addon
2023-03-09 11:35:09 -08:00
Steven Powell
1c0bc567dd
fixup error messaging
2023-03-07 11:40:30 -08:00
Om Saran
0db6f80b09
Fix format specifiers
2023-03-07 11:11:40 -08:00
Om Saran
0930723c09
Handle unexpected error for lock acquisition
2023-03-07 11:11:40 -08:00
Om Saran
09e6aff951
Simplify error handling for file lock in tunnel command
2023-03-07 11:11:40 -08:00
Om Saran
d8a920fd39
Rename function, update comment and update error message
2023-03-07 11:11:40 -08:00
Om Saran
e8625a3ba0
Add test to ensure no two tunnels can run simultaneously.
...
Add new error reason to disallow simultaneously running two tunnel processes
When tunnel fails to acquire lock due to contention, exit gracefully
2023-03-07 11:11:40 -08:00
Om Saran
cb71c5c5f0
Move tunnel locking to a func and add cleanup of lock
2023-03-07 11:11:40 -08:00
Om Saran
0319f4c1c0
Ensure only one instance of tunnel process runs
2023-03-07 11:11:40 -08:00
Steven Powell
93a8607044
fix image related bugs when enabling addons
2023-03-06 14:19:18 -08:00
Medya Ghazizadeh
f2683edfb9
Merge pull request #15911 from spowelljr/fixMinikubeServiceList
...
minikube service list: fix table format & hide URLs
2023-02-22 19:57:04 -08:00
Steven Powell
ca3bcae87a
remove unnecessary duplicated calls to NeedsPortForward
2023-02-22 13:59:48 -08:00
Steven Powell
3c538f400a
minikube service list: fix table format & hide URLs
2023-02-22 13:50:47 -08:00
Medya Ghazizadeh
707562b735
Merge pull request #15866 from swastik959/json
...
added detail json for addons
2023-02-22 13:12:19 -08:00
Steven Powell
6cc5ddc4ae
Merge pull request #15831 from OmSaran/main
...
Add ability to get json for "minikube service list"
2023-02-22 09:31:19 -08:00
Om Saran
c721b056fc
Make table and json output consistent
2023-02-21 20:06:31 -06:00
swastik959
14b32a040b
added linting and fixed ubit test
2023-02-18 10:30:32 +05:30
Medya Gh
fbce562099
add a new flag called --skip-aduit
2023-02-16 12:56:03 -08:00
swastik959
1ca885c1b3
Optimized
2023-02-16 22:31:59 +05:30
swastik959
1d5c6ef2a2
corrected
2023-02-16 21:53:45 +05:30
Swastik_Gour
cd787da24e
added detail json for addons
2023-02-16 07:41:50 +05:30
Om Saran
e33b5af7b7
Add integration test and fix behvaior on wrong output format for service list
2023-02-15 15:44:48 -06:00
Medya Gh
a26f197f0b
change another one to warn
2023-02-15 11:18:09 -08:00
Medya Gh
f3266711de
change errorf to warnf for aduit error
2023-02-15 11:01:34 -08:00
Ben Krieger
313cabe8f7
Fix bash completion for kubectl symlinked to minikube by not adding `--cluster` flag for the `kubectl __complete` subcommand
...
Signed-off-by: Ben Krieger <ben.krieger@intel.com>
2023-02-15 10:36:36 -05:00
Ben Krieger
1bd9b39d51
Add shell completion for minikube kubectl subcommand
...
Signed-off-by: Ben Krieger <ben.krieger@intel.com>
2023-02-14 14:43:51 -05:00
Medya Ghazizadeh
ba699acc9b
Merge pull request #15731 from p2c2e/mount_msg
...
Print proper value of mount type using info print statement
2023-02-13 15:42:35 -08:00
Om Saran
f0e2e388dd
Add ability to get json for "minikube service list"
2023-02-11 15:33:11 -06:00
Medya Ghazizadeh
fc644b8453
Merge pull request #15793 from spowelljr/tabbedVView
...
QEMU: Rename `user` network to `builtin` and update documentation
2023-02-10 10:33:29 -08:00
Steven Powell
0046eba5c3
rename IsBuiltin to IsBuiltinQEMU
2023-02-09 12:07:17 -08:00
Steven Powell
c417258f9c
change user network to builtin
2023-02-09 09:48:43 -08:00
Nick Mancari
c311d9e620
better verb choice for error output
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-02-03 15:33:55 -06:00
Nick Mancari
383a4c181c
better flag description
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-02-03 15:32:53 -06:00
nickmancari
229a721a84
fixed lint error
2023-02-02 05:45:43 -06:00
nickmancari
d91847d6cf
corrected the flag output
2023-02-01 21:08:53 -06:00
nickmancari
1db52e77b4
added flag
2023-02-01 15:34:37 -06:00
Sudharsan Rangarajan
7ce7244596
Incorrect field name being passed to info print statement for Mount Type
2023-01-28 09:53:22 +05:30
Steven Powell
0fbb9a6a31
update comments and store socket_vmnet paths in machine config
2023-01-25 10:45:20 -08:00
Steven Powell
46e9cc24ee
check brew install paths for socket_vmnet
2023-01-24 11:51:17 -08:00
Steven Powell
5dbb92fbee
update message
2023-01-19 15:08:03 -08:00
Steven Powell
eb884228a4
warn users if using VirtualBox on macOS 13+
2023-01-19 15:08:01 -08:00
Predrag Rogic
15bb620ca1
Merge branch 'master' into fix-TestNetworkPlugins-Linux_Docker
2023-01-18 02:43:47 +00:00
Medya Ghazizadeh
1b124462b1
Merge pull request #15611 from afbjorklund/numcpu-docker
...
Allow running docker driver with force on 1 CPU
2023-01-17 10:30:31 -08:00
Akihiro Suda
ba11072162
main: propagate the current Docker CLI context to $DOCKER_HOST
...
So that google/go-containerregistry can pick it up
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2023-01-12 08:13:03 +09:00
Predrag Rogic
24226c5f5a
Merge branch 'master' into fix-TestNetworkPlugins-Linux_Docker
2023-01-10 22:44:50 +00:00
Anders F Björklund
83d4219fee
Allow running docker driver with force on 1 CPU
2023-01-08 18:19:11 +01:00
Steven Powell
6e2511d9f1
add example of static IP in docs
2023-01-04 13:22:57 -08:00
Predrag Rogic
149e9a01b6
Merge branch 'master' into fix-TestNetworkPlugins-Linux_Docker
2023-01-04 21:10:29 +00:00
Steven Powell
e6d95b8230
implement --static-ip flag
2023-01-04 10:27:00 -08:00
Shubh Bapna
5f18b0d310
wrapped error when validate subnet fails to parse address
2023-01-04 01:27:08 -05:00
Shubh Bapna
474a56b50c
added comments and improved error message for validateSubnet
2022-12-23 08:44:57 -05:00
Shubh Bapna
7466acb3e8
moved bare metal validation to a separate function
2022-12-22 16:11:39 -05:00
Shubh Bapna
37098ababa
added subnet validator and its test cases
2022-12-17 14:40:37 -05:00
Predrag Rogic
4e0994c43e
Merge remote-tracking branch 'upstream/master' into fix-TestNetworkPlugins-Linux_Docker
2022-12-17 17:57:34 +00:00
Predrag Rogic
72c8acc370
fix Docker_Linux and multinode
2022-12-13 03:35:16 +00:00
Steven Powell
ff95fc7dc9
change cpus config field to string to support max value
2022-12-07 10:53:16 -08:00
Steven Powell
63934002d8
update golang.org and godoc.org links
2022-11-30 10:49:57 -08:00
Chris Kannon
2a86770a92
Merge branch 'master' into master
2022-11-17 09:58:49 -05:00
ckannon
c4c05a78eb
Remove startup error message on older version of ISO, sent to log instead
2022-11-17 09:51:23 -05:00
Steven Powell
a5de48aef9
Merge pull request #15308 from Juneezee/test/t.Setenv
...
test: use `T.Setenv` to set env vars in tests
2022-11-16 14:32:54 -05:00
Steven Powell
a800f27580
move license command to other section in help
2022-11-16 11:21:00 -05:00
Medya Ghazizadeh
ccb569fabf
Merge pull request #15336 from prezha/fix-kubelet-localStorageCapacityIsolation-option
...
fix kubelet localStorageCapacityIsolation option
2022-11-14 09:54:22 -08:00
Predrag Rogic
28beac4edb
fix kubelet localStorageCapacityIsolation option for different k8s versions
2022-11-09 22:56:29 +00:00
ckannon
3198d106dc
Renamed validateKicBaseVersion, fixed PR comments.
2022-11-09 09:40:10 -05:00
Eng Zer Jun
9d85be1a99
test: use `T.Setenv` to set env vars in tests
...
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.Setenv
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-11-08 10:30:29 +08:00
Steven Powell
e2679ccd7a
add additional memory overhead for VirtualBox
2022-11-07 16:06:55 -05:00
Chris Kannon
bd11be75b8
Merge branch 'master' into master
2022-11-04 14:07:20 -04:00
Steven Powell
8bd593b433
Merge pull request #15266 from spowelljr/detectSocket
...
Auto select network on QEMU
2022-11-04 09:38:09 -07:00
Steven Powell
ea8fd6c619
Merge pull request #15281 from spowelljr/fixAddonEnableMessages
...
Prevent enabling `efk` addon due to containing Log4j CVE
2022-11-04 09:36:59 -07:00
Steven Powell
43c4e59a60
disable efk addon
2022-11-03 16:38:59 -07:00
Rahil Patel
d7baa13960
fix spelling and grammar in Go files
2022-11-03 18:31:44 -04:00
Chris Kannon
00486c3fd6
Merge branch 'master' into master
2022-11-02 15:09:58 -04:00
Chris Kannon
320c41f80e
Added version.json to kicbase image and version validation to start.go.
...
Added CHANGELOG to kicbase and ISO.
Updated gh to latest version 2.18.1.
2022-11-02 14:17:41 -04:00
Steven Powell
3568d657ab
auto select network on QEMU
2022-11-01 14:18:43 -07:00
Steven Powell
074e681975
Merge pull request #15160 from agarwalnit/master
...
Added cloud-spanner emulator add-on.
2022-10-28 13:58:41 -07:00
Steven Powell
253c006721
Merge pull request #15126 from spowelljr/dockerDesktopLinux
...
use port forwarding on Linux with Docker Desktop
2022-10-25 11:04:03 -07:00
Nitin Agarwal
909ac67151
Added cloud-spanner emulator add-on.
2022-10-20 23:16:53 +00:00
Steven Powell
289e3bcbf2
change command to license
2022-10-20 10:51:27 -07:00
Steven Powell
643fed94f1
added link to Docker Engine instructions
2022-10-18 10:00:23 -07:00
Steven Powell
8905963ff9
add credits command
2022-10-17 15:22:33 -07:00
Steven Powell
33ad232606
add warning to users using Docker Desktop on Linux
2022-10-12 15:23:01 -07:00
Steven Powell
6bcef35331
exit if mounting with user network
2022-10-11 14:29:33 -07:00
Steven Powell
f981dd1527
Merge pull request #15081 from klaases/warn1
...
Warn if addon has no associated Github username
2022-10-10 10:12:31 -07:00
Steven Powell
399a60eb86
Merge pull request #15085 from spowelljr/fixPortValidation
...
Allow passing only exposed port to --ports
2022-10-07 14:39:43 -07:00
Steven Powell
26ff0aa2d2
allow only passing exposed port to --ports
2022-10-07 10:56:58 -07:00
klaases
f6d3bf0515
remove check for unknown maintainer
2022-10-06 16:25:50 -07:00
klaases
43d0753d78
warn if addon has no associated github username
2022-10-06 16:11:53 -07:00
Steven Powell
6d00b3e89a
mark as unpaused on start & renaming/comments
2022-10-06 14:27:34 -07:00
Steven Powell
f1b909e44d
add darwin conditionals
2022-10-03 15:17:29 -07:00
Steven Powell
5c27bc4d11
update messaging if using user network
2022-10-03 15:17:29 -07:00
Steven Powell
5fc653ba83
update experimental message and logic
2022-10-03 15:14:39 -07:00
Steven Powell
ad1951ab80
rename socket to socket_vmnet
2022-10-03 15:14:39 -07:00
Steven Powell
8c12c40853
implement socket_vmnet
2022-10-03 15:14:36 -07:00
Steven Powell
ab9130bf2d
Merge pull request #14951 from spowelljr/fixLinuxAddressBinding
...
Use SSH tunnel if user specifies bindAddress
2022-10-03 11:31:31 -07:00
Steven Powell
9fdb6d9bd6
convert another to os.Stdout.Write
2022-09-30 17:06:43 -07:00
Steven Powell
78a64e2534
add update check on status and profile list
2022-09-30 16:53:34 -07:00
Steven Powell
b25b13f3f1
close channels in defer
2022-09-29 13:35:10 -07:00
Steven Powell
1ba9792419
fix update check logic
2022-09-21 16:06:21 -07:00
klaases
847b7731c6
improve warning wording
2022-09-20 16:42:38 -07:00
klaases
19f0b18357
issue warning for qemu with socket_vmnet flagset
2022-09-20 16:42:38 -07:00
klaases
787685e073
allow network flag with qemu
2022-09-20 16:42:38 -07:00
klaases
87175c7395
revert changes
2022-09-20 16:42:21 -07:00
klaases
5b7e19e172
fix socketVMnetPath
2022-09-20 16:41:13 -07:00
klaases
18fda4be13
add socket vmnet and client path flags
2022-09-20 16:41:13 -07:00
klaases
ef31fc272c
disable bail on qemu service
2022-09-20 16:41:13 -07:00
Steven Powell
012146bdbc
use SSH tunnel if user specifies bindAddress
2022-09-14 11:57:28 -07:00
Steven Powell
6002db244e
fix error message
2022-09-12 11:30:58 -07:00
Steven Powell
2482b4e4de
fix unit tests on macOS arm64
2022-08-08 10:20:13 -07:00
Steven Powell
744187868d
fix linting
2022-08-08 09:29:19 -07:00
Steven Powell
87d7e3b423
Merge pull request #14695 from spowelljr/limitAuditSize
...
Limit number of audit entries
2022-08-02 10:15:53 -07:00
Steven Powell
66ff960b61
limit number of audit entries
2022-08-01 14:16:28 -07:00
anoop142
13680ff987
fix linting
2022-08-01 23:00:25 +05:30
anoop142
5b2080f782
Fix url index out of range error in service
...
* if there is no node port, service panics accessing url
* since the length of array is 3 when there is no node port, accessing u[3] results in
index out of range
2022-07-28 12:56:05 +05:30
Steven Powell
0d274d5603
Merge pull request #14499 from inifares23lab/master
...
add VerifiedMaintainer field to Addons and display a warning if empty
2022-07-25 17:00:41 -07:00
inifares23lab
7dfe7e65e4
when enable addons differentiate message for maintainer and verified maintainer
2022-07-20 21:00:35 +02:00
Steven Powell
a2a814fa8b
Merge pull request #14589 from spowelljr/toolTip
...
Update docker-env description and add tooltip
2022-07-15 13:38:46 -07:00
Steven Powell
8fd532dd3a
Merge pull request #14522 from kinvolk/fix_headlamp_tip
...
Fix Post installation tip for headlamp addon
2022-07-15 13:18:18 -07:00
Santhosh Nagaraj S
d9263acf8d
Fix Post installation tip for headlamp
...
Signed-off-by: Santhosh Nagaraj S <santhosh@kinvolk.io>
2022-07-15 15:18:56 +05:30
Steven Powell
af662f6b3a
update wording
2022-07-14 14:22:11 -07:00
Steven Powell
d49a6c8ccf
update docker-env description and add tooltip
2022-07-14 10:52:46 -07:00
Steven Powell
d89f43518e
fix incorrect user and profile in audit logging
2022-07-12 11:40:58 -07:00
inifares23lab
21e00cf796
formatting with 'gofmt -w -s .'
2022-07-06 23:21:51 +02:00
peizhouyu
75a2631baf
update start help info
...
Indicate --network-plugin flag is deprecated in flag description
2022-07-04 11:17:21 +08:00
inifares23lab
dfb4860cec
display warning for addons with unverified Maintainer
2022-07-03 14:42:40 +02:00
zhouguowei
f60aa26c8b
prbot need a strike
2022-06-27 09:50:27 +08:00
吴梓铭
360cc86ce5
fix: panic when environment variables are empty
...
On mac OS, environment variables like: OLDPWD are usually empty. May trigger panics like:
```bash
😄 minikube v1.26.0 on Darwin 11.6.5
panic: runtime error: index out of range [1] with length 1
goroutine 1 [running]:
k8s.io/minikube/cmd/minikube/cmd.displayEnviron({0xc000a69a40?, 0x1c, 0xb?})
/private/tmp/minikube-20220623-65769-c2xa25/cmd/minikube/cmd/start.go:445 +0x252
k8s.io/minikube/cmd/minikube/cmd.runStart(0x7316040?, {0x5d07e13?, 0x0?, 0x0?})
/private/tmp/minikube-20220623-65769-c2xa25/cmd/minikube/cmd/start.go:157 +0x245
github.com/spf13/cobra.(*Command).execute(0x7316040, {0x73736d8, 0x0, 0x0})
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/cobra@v1.5.0/command.go:876 +0x67b
github.com/spf13/cobra.(*Command).ExecuteC(0x7313fc0)
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/cobra@v1.5.0/command.go:990 +0x3b4
github.com/spf13/cobra.(*Command).Execute(...)
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/cobra@v1.5.0/command.go:918
k8s.io/minikube/cmd/minikube/cmd.Execute()
/private/tmp/minikube-20220623-65769-c2xa25/cmd/minikube/cmd/root.go:170 +0xca5
main.main()
/private/tmp/minikube-20220623-65769-c2xa25/cmd/minikube/main.go:88 +0x255
```
2022-06-24 22:09:40 +08:00
Sharif Elgamal
90fabe158e
fix grammar for common minikube start output
2022-06-22 12:13:31 -07:00
Steven Powell
6405bb3185
Merge pull request #14323 from lakshkeswani/master
...
Don't allow --control-plane=true for node add #14300
2022-06-21 11:02:03 -07:00
Steven Powell
e5754a2a7a
Merge pull request #14315 from kinvolk/headlamp_addon
...
Addon: add headlamp
2022-06-21 10:37:06 -07:00
Nikhil Sharma
9fe8946e66
Made changes so that we get logs when a command starts no matter that it is finished or not
2022-06-16 12:58:06 -07:00
lakshkeswani
cc1fba4411
Don't allow --control-plane=true for node add
2022-06-16 11:31:45 +00:00
Santhosh Nagaraj S
26afc8f85c
Addon: add headlamp
...
Signed-off-by: Santhosh Nagaraj S <santhosh@kinvolk.io>
2022-06-16 10:34:18 +05:30
Sharif Elgamal
98c0e9f6c8
Merge pull request #14265 from sharifelgamal/arm64-containerd
...
Reduce package duplication for ISO building
2022-06-13 16:22:33 -07:00
Sharif Elgamal
6da1a20932
Merge pull request #14301 from sharifelgamal/gcp-auth-timeout
...
don't special case gcp-auth for enabling addons
2022-06-13 10:47:04 -07:00
Sharif Elgamal
1801630196
Merge branch 'master' of github.com:kubernetes/minikube into arm64-containerd
2022-06-10 17:02:58 -07:00
Kian-Meng Ang
bc03821826
Fix typos
2022-06-10 15:26:35 -07:00
Sharif Elgamal
24e2708d91
Merge branch 'master' of github.com:kubernetes/minikube into gcp-auth-timeout
2022-06-10 13:40:07 -07:00
Sharif Elgamal
b475b2526d
Merge branch 'master' of github.com:kubernetes/minikube into arm64-containerd
2022-06-09 09:44:43 -07:00
Jack Zhang
7c4389c68b
update image prefix
2022-06-08 14:31:44 -07:00
Sharif Elgamal
94dd7296d7
Merge branch 'master' of github.com:sharifelgamal/minikube into gcp-auth-timeout
2022-06-08 10:37:18 -07:00
Sharif Elgamal
1f763354ca
Merge pull request #12995 from eliaskoromilas/fpga-operator
...
InAccel FPGA Operator addon
2022-06-07 15:32:44 -07:00
Sharif Elgamal
8d60734670
small fixes
2022-06-07 12:52:39 -07:00
Sharif Elgamal
b465bac75d
Merge pull request #14283 from sharifelgamal/custom-firmware
...
allow users to supply custom QEMU firmware path
2022-06-06 15:36:23 -07:00
Sharif Elgamal
7b890545b4
Update cmd/minikube/cmd/start_flags.go
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2022-06-06 12:54:56 -07:00
Sharif Elgamal
9cc18c0aa6
allow users to supply custom QEMU firmware path
2022-06-06 12:43:59 -07:00
Nils Fahldieck
dfa371652b
Update docs usage output
2022-06-04 16:58:50 +02:00
Nils Fahldieck
ce08c0bcee
Conditionally append docs to tData
2022-06-04 16:58:50 +02:00
Nils Fahldieck
fa3ec1433f
Add test for disabled/enabled docs
2022-06-04 16:58:50 +02:00
Nils Fahldieck
8be1b154ae
Print doc only with enabled option
2022-06-04 16:58:50 +02:00