root
d1e8d47f80
fix typos
2020-07-30 12:47:08 +00:00
Ajitesh13
c4957e4383
virtualbox: improve solution message -> ensure it is in the path #8453
2020-07-30 16:53:18 +05:30
niedhui
22edb6f063
make baseImage respect imageRepo
...
Signed-off-by: niedhui <niedhui@gmail.com>
2020-07-30 16:59:56 +08:00
Ling Samuel
bb57ae0c15
Ignore localhost proxy started with scheme. Fix start_test.
...
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2020-07-30 16:17:04 +08:00
Thomas Stromberg
c6e6013d40
Update unit tests
2020-07-29 14:08:48 -07:00
Thomas Stromberg
59d0d7335a
Add HTTP-like status codes, remove unused fields
2020-07-29 13:57:06 -07:00
Dean Coakley
9c23485dfb
Remove list of alternative drivers
2020-07-29 09:40:43 +01:00
Dean Coakley
4b2974472d
Improve error message text
2020-07-28 22:40:55 +01:00
Dean Coakley
b27440d4ae
Add warning for ingress addon with driver of none
2020-07-28 22:40:15 +01:00
Thomas Stromberg
aa3d2a2a8a
Improve handling of pause/unpause/stop/delete steps
2020-07-28 13:26:09 -07:00
Thomas Stromberg
ac1f901160
Allow non-start steps
2020-07-28 13:07:37 -07:00
Sharif Elgamal
2cc7445f1c
guard against joining the cluster twice
2020-07-28 12:16:33 -07:00
Thomas Stromberg
448ec75c8c
Add support for storing/retrieving transient status
2020-07-27 21:34:52 -07:00
Priya Wadhwa
1c1ac4273c
set proxy-refresh-interval=70000 for etcd to improve CPU overhead
2020-07-27 14:35:59 -04:00
Priya Wadhwa
9680237277
WIP
2020-07-27 14:24:40 -04:00
Sharif Elgamal
d546ea1b5c
Merge pull request #8817 from sharifelgamal/restart-kubelet
...
restart kubelet if config changes
2020-07-24 15:48:53 -07:00
Medya Gh
47ed4bc23c
update lint version
2020-07-24 14:45:15 -07:00
Medya Ghazizadeh
1395c8017c
Merge pull request #8784 from Dean-Coakley/disable-podman2
...
Warn user for podman2 version
2020-07-24 14:40:18 -07:00
Medya Ghazizadeh
8f404164d0
Merge pull request #8745 from littleroad/error_detect
...
Add error handling for os.RemoveAll
2020-07-24 14:38:10 -07:00
Dean Coakley
dc566bec0b
Remove warning prefix
2020-07-24 21:49:13 +01:00
Dean Coakley
57649f8ee8
Quote version numbers
2020-07-24 21:42:20 +01:00
Dean Coakley
fa04c83b83
Use UI for logging
2020-07-24 21:25:19 +01:00
Thomas Stromberg
9c0618f102
Merge to master
2020-07-24 11:22:59 -07:00
Medya Ghazizadeh
76b98ace96
Merge pull request #8827 from tstromberg/kic-longer
...
Increase maximum container startup wait from 13 seconds to 25 seconds
2020-07-24 11:10:39 -07:00
Sharif Elgamal
b9c218261d
adding debugging
2020-07-24 10:45:14 -07:00
Thomas Stromberg
f8f689b5cc
Merge branch 'master' into kic-show-errs
2020-07-24 09:06:56 -07:00
Thomas Stromberg
bd713ffd45
Increase maximum container startup wait from 13 seconds to 25 seconds
2020-07-24 09:02:32 -07:00
Thomas Stromberg
dee9c0b427
Show 'docker logs' excerpt if container dies
2020-07-24 08:58:09 -07:00
Thomas Stromberg
e172a7ee1c
Avoid panic: runtime error: invalid memory address or nil pointer dereference
2020-07-24 08:48:20 -07:00
Dean Coakley
db4bf9ec2a
Log warning instead of exit with error
2020-07-24 11:30:23 +01:00
Sharif Elgamal
be160406ec
remove space
2020-07-23 14:45:42 -07:00
Sharif Elgamal
82c4d49eb8
restart kubelet if config changes
2020-07-23 14:43:23 -07:00
Medya Ghazizadeh
993504e054
Merge pull request #8800 from priyawadhwa/improve-json
...
Improve json integration test
2020-07-23 10:23:36 -07:00
Medya Ghazizadeh
f230ca0c55
Merge pull request #8804 from medyagh/hot_upgrade_fix
...
Stop kube-system containers before applying configuration updates
2020-07-23 10:03:54 -07:00
Medya Ghazizadeh
b7b26ea2d5
Merge pull request #8737 from dddddai/master
...
Use RWMutex instead of Mutex
2020-07-23 09:57:25 -07:00
vinu2003
907cd34b78
fixed unit test based on update to v1.18.0
2020-07-24 02:22:26 +10:00
Medya Gh
44b6703e68
update comment
2020-07-23 09:17:30 -07:00
Medya Gh
d5cc6afc9b
update comment
2020-07-23 09:17:06 -07:00
Asare Worae
a31e359b01
fixed unwanted spinning up of mount deamon when using KIC drivers, and added same host mounted volumes logic for the Podman driver
2020-07-23 11:47:16 +02:00
Priya Wadhwa
2cba801d50
fix order
2020-07-22 20:47:41 -04:00
Priya Wadhwa
a03f25e976
add step to register
2020-07-22 18:50:42 -04:00
Priya Wadhwa
22226ffc8f
fixed merge conflict
2020-07-22 18:46:57 -04:00
priyawadhwa
25566c90f0
Merge pull request #8796 from priyawadhwa/error
...
Add support for Error type to JSON output
2020-07-22 18:43:46 -04:00
Priya Wadhwa
df0bc948bc
Add logging to none driver
2020-07-22 18:42:38 -04:00
Medya Gh
9fa1dfdaec
stop conainers before hot upgrade
2020-07-22 15:14:57 -07:00
Priya Wadhwa
3f18ecb052
add log
2020-07-22 15:01:22 -04:00
Priya Wadhwa
efe1ce278a
Add docs
2020-07-22 14:20:41 -04:00
Medya Ghazizadeh
f2100e365d
Merge pull request #8697 from medyagh/improv_sa_apply
...
improve applying default service account
2020-07-22 11:00:07 -07:00
Sharif Elgamal
ad083ba7ac
Merge pull request #8778 from sharifelgamal/hyerpv
...
allow for prefixed interface names for hyperv
2020-07-21 16:07:42 -07:00
Sharif Elgamal
58d4b0c32f
add less restrictive interface name matching
2020-07-21 15:32:38 -07:00
Priya Wadhwa
6a33c03df2
fix unit test
2020-07-21 18:23:22 -04:00
Priya Wadhwa
8bc875d520
Rebased on master; fixed json_output integration test
2020-07-21 18:20:02 -04:00
priyawadhwa
6df5d19d70
Merge pull request #8793 from priyawadhwa/warning
...
Implement Warning type for JSON output
2020-07-21 18:17:54 -04:00
Medya Ghazizadeh
85f1c4f2dd
Merge pull request #8792 from concaf/concaf/fix/fix-already-started
...
(Addons) Create a new command in every retry
2020-07-21 14:43:14 -07:00
Sharif Elgamal
1b6eee675b
Automated GCP Credentials Addon Prototype ( #8682 )
...
* metadata addon works
* Add code for metadata server image and makefile rules
* remove log message
* update to work with v1.13.11
* update readme
* fix metadata addon stuff for newer codebase
* buncha changes
* just so many changes
* ch-ch-ch-ch-changes
* addon works
* update readme
* boilerplate
* revert unrelated change
* move server code to another repo
* switch addon name to gcp-auth
* metadata -> gcp-auth
* missed one
* automate finding of credentials
* remove unnecessary comment
* address comments
* Update README.md
* Update README.md
* use mustload everywhere
* swap selector condition
* upgrade kube-webhook-certgen to 1.3
* move paths to constants
* add notice to user on addon enable
* adding addon documentation
* move addons documentation inside handbook
* remove old addons docs location
Co-authored-by: Priya Wadhwa <priyawadhwa@google.com>
2020-07-21 14:25:58 -07:00
Medya Ghazizadeh
24fa6280dc
Merge pull request #8588 from afbjorklund/preload-crio-2
...
Use preloaded tarball for cri-o container runtime
2020-07-21 13:59:03 -07:00
Priya Wadhwa
6ca72229bb
add json unit tests
2020-07-21 15:56:26 -04:00
Priya Wadhwa
b4b9013057
Add unit test for problem.DisplayJSON()
2020-07-21 15:51:47 -04:00
Priya Wadhwa
482b9befd6
implement errors in JSON
2020-07-21 15:43:19 -04:00
Medya Ghazizadeh
f04a6a061f
Merge pull request #8586 from afbjorklund/container-id
...
Support more error messages for container inspect
2020-07-21 12:22:31 -07:00
Priya Wadhwa
c60e754624
Implement warning type for JSON output
2020-07-21 14:40:31 -04:00
Shubham
f42f79e56d
(Addons) Create a new command in every retry
...
Whenever a `kubectl apply` fails while enabling an addon, it is
retried with exponential backoff. The command (type `*exec.Cmd`)
that this retry function runs in created outside the function -
which means that it is reused on every retry. This is a problem
because `exec.Cmd` (https://godoc.org/github.com/pkg/exec#Cmd )
states that "... Cmd cannot be reused after calling its Run or
Start methods."
This retry is a common case due to, say, a CRD and its resource
being present in the same YAML file of the addon which causes
a race condition where the resource is created before its CRD is
created in the cluster - this race is fixed by subsequent retries.
I've noticed this in the dashboard and the ambassador addon.
Due to the above mentioned bug, minikube throws errors like
`exec: already started` in every retry and the retry is never
successful, manifests are never deployed and addon creation errors
out.
Related to #8138 #8119 #8372
2020-07-21 21:20:24 +05:30
Dean Coakley
328dbc1f97
Improve fix message
2020-07-21 12:29:53 +01:00
Dean Coakley
66f03b89c3
Update formatting Podman->Podman v2
2020-07-21 12:24:03 +01:00
Anders F Björklund
59bf848e54
Use preloaded tarball for cri-o container runtime
...
Pretty much the same as containerd, minus Restart
2020-07-21 09:05:12 +02:00
Ambor
e00cf6c1e1
fix error usage for the WaitGroup in the pkg addons
2020-07-21 11:57:06 +08:00
dddddai
196789f965
Use RWMutex instead of Mutex
2020-07-21 10:39:45 +08:00
Dean Coakley
0d78fe56af
lint
2020-07-21 03:00:13 +01:00
Dean Coakley
622e33b7ab
Fix typo
2020-07-21 02:55:37 +01:00
Dean Coakley
62683c9b42
Exit with error on podman2 drivers
2020-07-21 02:39:46 +01:00
priyawadhwa
aaebd88251
Merge pull request #8610 from johscheuer/update-storage-provisioner
...
Update external-provisioner for storage provisioner for Kubernetes 1.18
2020-07-20 19:11:38 -04:00
Medya Ghazizadeh
79088e6ed2
Merge pull request #8581 from afbjorklund/preload-crio
...
Generate cri-o container runtime preload tarball
2020-07-20 15:55:31 -07:00
Medya Ghazizadeh
2086bcb2b1
Merge pull request #8718 from medyagh/check_docker_deskop
...
docker/podman: warn if allocated memory is below limit
2020-07-20 15:26:41 -07:00
Sharif Elgamal
f92015df9b
allow for prefix interace names for hyperv
2020-07-20 13:07:13 -07:00
Medya Gh
13357d91a4
avoid nil pointer
2020-07-20 12:56:03 -07:00
Anders F Björklund
22585c3a17
Use the preload container run for podman as well
...
Now that there is no more race between the containers for
preparing the volume, we can use it for podman as well...
Previously we risked ending up with not copying the contents
of /var from the container image, which made it not work.
2020-07-20 21:54:28 +02:00
Anders F Björklund
2a9e9b2425
Make sure to prepare the kic volume after creation
...
The volume is created as empty, so make sure that we run a
container to do the initial copy of /var from the image.
This is to avoid race conditions later on, where the preload
starts to use the created volume for packing up the tarball.
2020-07-20 21:50:13 +02:00
Jose Donizetti
c2175abcba
Add static ip to kic/docker
2020-07-18 18:19:53 -03:00
Jose Donizetti
cd17c872d3
Fix documentation typo
2020-07-18 15:02:09 -03:00
Thomas Stromberg
9546b1ebc6
Merge branch 'master' into kic-image-upgrade
2020-07-17 09:56:42 -07:00
Thomas Strömberg
b7e7ef3a65
Merge pull request #8751 from tstromberg/docker-err-suggestion
...
Add 'Start Docker' guidance for /pipe/docker_engine errors
2020-07-17 09:55:04 -07:00
Thomas Stromberg
f89094dcf8
Adjust comment
2020-07-17 09:46:53 -07:00
Thomas Stromberg
2b614ae856
Add 'Start Docker' guidance for /pipe/docker_engine errors
2020-07-17 09:45:16 -07:00
Thomas Stromberg
3b1dc975d0
legacy client certs: simplify logic
2020-07-17 07:23:48 -07:00
Lu Fengqi
c219b60b05
Add error handling for os.RemoveAll
...
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
2020-07-17 15:44:04 +08:00
Thomas Stromberg
b72eee4e36
Turn Errorf into Infof
2020-07-16 23:07:37 -07:00
Thomas Stromberg
94e866affc
Merge to master
2020-07-16 19:53:43 -07:00
Thomas Stromberg
798196d0ad
Remove stray log line
2020-07-16 19:37:28 -07:00
Thomas Stromberg
be2c27efe0
Find and copy legacy certificate/key paths
2020-07-16 19:37:15 -07:00
Thomas Strömberg
bb2fb3ad97
Merge pull request #8573 from tstromberg/cilium
...
Add support for Cilium CNI (--cni=cilium)
2020-07-16 19:34:44 -07:00
Thomas Stromberg
ccd3682116
Refactor upgrade tests
2020-07-16 17:34:46 -07:00
Marcin Niemira
8f47e32d7c
use pathlib
2020-07-16 18:46:21 +10:00
Thomas Stromberg
fcc15fa353
Merge to master
2020-07-15 21:04:33 -07:00
Thomas Stromberg
14b4a54ba2
Merge to master
2020-07-15 21:03:49 -07:00
Medya Gh
13d37ff7aa
adress review comments
2020-07-15 14:34:01 -07:00
Medya Gh
b0e58a3688
rename to FullName
2020-07-15 14:27:06 -07:00
Medya Gh
3aac9a3fff
remove duplicate return statement
2020-07-15 14:24:42 -07:00
Medya Gh
8ecb483cb7
use cached error
2020-07-15 14:23:25 -07:00
Medya Gh
7bbb0b6250
spell
2020-07-15 14:09:35 -07:00
Medya Gh
de6c10526b
move cacheDaemoninfo to oci package
2020-07-15 14:07:50 -07:00
Sharif Elgamal
af99a13e8f
Merge branch 'master' of github.com:kubernetes/minikube into master
2020-07-15 11:32:48 -07:00
Sharif Elgamal
1467e8f7c4
Merge pull request #8576 from afbjorklund/image-client
...
cache: Only use docker client for docker runtime
2020-07-15 11:12:52 -07:00
Medya Gh
dbfd16f21e
add helper fucns for drivers
2020-07-14 15:02:54 -07:00
priyawadhwa
c2e63844db
Merge pull request #8709 from priyawadhwa/json-output-download
...
Implement Download and DownloadProgress types for JSON output
2020-07-14 15:56:56 -04:00
Priya Wadhwa
cb03f56b1b
remove todo
2020-07-14 13:39:33 -04:00
priyawadhwa
f15b0d6e35
Merge pull request #8468 from prasadkatti/mv_kubelet_params_to_cfg_file
...
Move kubelet params to config file
2020-07-14 09:56:26 -04:00
Sharif Elgamal
9f2f604b93
several fixes
2020-07-13 18:54:40 -07:00
Sharif Elgamal
bd721de0cf
Merge branch 'master' of github.com:kubernetes/minikube into master
2020-07-13 15:00:38 -07:00
Priya Wadhwa
e4ce27abda
Add unit tests for register package
2020-07-13 12:08:06 -04:00
Priya Wadhwa
e771b72a82
fix lint
2020-07-13 10:05:06 -04:00
Priya Wadhwa
9784ce3051
Rebased on master
2020-07-13 09:57:42 -04:00
Priya Wadhwa
d26cd72d36
Implement Info type so that integration tests pass
2020-07-10 19:18:25 -04:00
Priya Wadhwa
3a290606db
Merge branch 'master' of https://github.com/kubernetes/minikube into json-output
2020-07-10 19:12:50 -04:00
Sharif Elgamal
aa4f7b3b21
update control plane properly on multinode restart
2020-07-10 15:40:21 -07:00
Medya Gh
17f44f69e3
impove applyying default service account
2020-07-10 15:01:06 -07:00
priyawadhwa
442bc138ce
Merge pull request #8676 from priyawadhwa/info
...
Add Infof function to out package
2020-07-10 17:08:30 -04:00
Medya Ghazizadeh
45677496fa
Merge pull request #8585 from prasadkatti/extra_option_8130
...
Do not auto-set extra config that user wishes to override
2020-07-10 13:54:19 -07:00
Medya Ghazizadeh
3c9e96ea6b
Merge pull request #8684 from tstromberg/none-cni
...
none CNI: error if portmap plug-in is required but unavailable
2020-07-10 13:50:54 -07:00
Medya Gh
6d9922b430
address review comments
2020-07-10 13:19:22 -07:00
Medya Gh
4bce402a3b
remove debug seconds
2020-07-10 13:18:25 -07:00
Medya Gh
11674e830f
spell
2020-07-10 13:13:45 -07:00
Medya Gh
c240fa97bc
add timeout for node label too
2020-07-10 13:06:43 -07:00
Medya Gh
f805be635a
add timeout for node label too
2020-07-10 13:04:11 -07:00
Medya Gh
f36da5f044
add timeout for node label too
2020-07-10 13:03:50 -07:00
Medya Gh
770f7aeeb4
adjust itmeout
2020-07-10 13:02:06 -07:00
Medya Gh
7088653d33
max 13 min for kubeadm
2020-07-10 13:01:08 -07:00
Medya Gh
6c702e1d29
add timeout for kubeadm init
2020-07-10 12:49:29 -07:00
Medya Ghazizadeh
87e540305c
Merge pull request #8648 from jlucktay/update/profile-name-validation
...
disallow setting profile names with underscore
2020-07-10 10:43:32 -07:00
Priya Wadhwa
3d105ef98f
Download and DownloadProgress implemented
2020-07-10 12:31:08 -04:00
Priya Wadhwa
d29a9dca67
Add Download and DownloadProgress types implementations
2020-07-10 11:58:23 -04:00
Prasad Katti
7bc10bb308
Set cgroupDriver and clientCAFile (for 1.16+) via kubelet config
2020-07-09 15:21:26 -07:00
Prasad Katti
c483714cbc
Move kubelet params to config file
2020-07-09 15:21:25 -07:00
Prasad Katti
332c3bd14f
Add unit tests for Exists in extra_options.go
2020-07-09 15:17:00 -07:00
Thomas Strömberg
ca9040b42b
Merge pull request #8664 from tstromberg/none-timeout
...
none: Fix 'minikube delete' issues when the apiserver is down
2020-07-09 14:16:14 -07:00
Sharif Elgamal
d0d3973a13
restrict apparmor security opt to docker
2020-07-09 12:58:01 -07:00
Thomas Stromberg
0b3e2ae79b
none CNI: error if portmap plug-in is required but unavailable. Make testable
2020-07-08 14:30:48 -07:00
Thomas Stromberg
f8068d06f7
Merge branch 'master' into none-timeout
2020-07-08 13:48:34 -07:00
Priya Wadhwa
b9cd0caa7c
only out.T should be used to convert steps to JSON
2020-07-08 16:30:48 -04:00
Priya Wadhwa
6d95edda7b
remove empty test
2020-07-08 16:28:51 -04:00
priyawadhwa
b6f0829d7d
Merge pull request #8505 from zhijianli88/cleanup-tempfiles
...
Cleanup tempfiles
2020-07-08 14:53:51 -04:00
priyawadhwa
7367c72a3e
Merge pull request #8490 from zhijianli88/cleanup
...
A few cleanup
2020-07-08 14:52:28 -04:00
Priya Wadhwa
3e6ef0b37a
fix unit test
2020-07-08 11:10:47 -04:00
Priya Wadhwa
290f48f98e
Add Infof function to out package
2020-07-08 11:00:32 -04:00
Medya Ghazizadeh
1bcb375f93
Merge pull request #8147 from nezorflame/fix-error-msg
...
add new --extra-config option "scheduler"
2020-07-07 15:55:08 -07:00
Medya Ghazizadeh
d8106f7d06
Merge pull request #8454 from colvin/addon-podsecuritypolicies
...
Include a podsecuritypolicies addon
2020-07-07 15:52:03 -07:00
Thomas Stromberg
7df4075297
Don't propagate stopped as an error, so that 'delete' works on stopped none clusters
2020-07-07 15:23:26 -07:00
Thomas Stromberg
53ce804cff
retry.Local should respect the maxTime argument
2020-07-07 15:10:30 -07:00
Thomas Stromberg
f82d5c6bb2
Reduce apiserver health timeout from 8s to 5s
2020-07-07 15:10:05 -07:00
Priya Wadhwa
1980e066dd
fix lint and generate-docs
2020-07-07 15:57:07 -04:00
Priya Wadhwa
6367f71867
Make sure each step is unique
2020-07-07 15:39:47 -04:00
Priya Wadhwa
bd94872a10
add additional steps
2020-07-07 14:25:27 -04:00
Priya Wadhwa
ddecfd77e7
Include Ln as a Step
2020-07-07 13:24:53 -04:00
Priya Wadhwa
1ac2f6ddc0
cleanup
2020-07-07 13:19:33 -04:00
Priya Wadhwa
dd60fa85cc
Remove emojis from json output
2020-07-06 15:28:51 -04:00
Priya Wadhwa
f68716e2da
Set up logic for steps
2020-07-06 15:12:13 -04:00
Priya Wadhwa
10ba39cd3c
Add --output=json flag and hook it up to out package
2020-07-06 12:32:34 -04:00
Priya Wadhwa
515616d1aa
Add register of steps for 'minikube start'
2020-07-06 12:24:10 -04:00
Priya Wadhwa
b72b1239ba
Add function to print data in cloud events format
2020-07-06 12:23:59 -04:00
James Lucktaylor
85a641177e
Resequence test cases for better readability.
2020-07-06 13:07:14 +01:00
James Lucktaylor
2cf72f7ca8
Update profile name validation pattern. #8493
...
- prevents some incompatible characters from making their way into
profile names and causing DNS/hostnames issues
2020-07-05 12:16:31 +01:00
James Lucktaylor
2660b92109
Update test coverage around ProfileNameValid func.
...
- preparing to update the ProfileNameValid func
- adding some more test cases to check against new profile name limits
2020-07-05 12:06:14 +01:00
Medya Ghazizadeh
a4b647f19b
Merge pull request #8629 from medyagh/sol_msg_docker_ssh_port
...
add solution message when container create is stuck
2020-07-01 13:41:21 -07:00
Medya Ghazizadeh
084df67df1
Merge pull request #8628 from sharifelgamal/del-on-failure
...
ensure deleting failed hosts if --delete-on-failure is specified
2020-07-01 13:40:43 -07:00
Medya Gh
fd2912340a
improve wording
2020-07-01 13:33:51 -07:00
Medya Gh
881ed1df1c
add link
2020-07-01 13:28:52 -07:00
Medya Gh
4a321a6b1e
add solution message when docker container create is stuck
2020-07-01 13:26:56 -07:00
Sharif Elgamal
84eea2f487
recreate hosts on failed provisioning if delete-on-failure is specified
2020-07-01 12:57:59 -07:00
Medya Gh
7564651d50
make docker driver highly prefered
2020-07-01 10:09:18 -07:00
Anders F Björklund
4968ff5e75
Run gofmt on pkg/minikube/shell/shell.go
2020-06-30 19:19:44 +02:00
Anders F Björklund
b0b3a1ac8c
Change indentation from gofmt to goimports
2020-06-30 19:12:11 +02:00
Johannes M. Scheuermann
73fccf04f8
Update external-provisioner for storage provisioner
2020-06-30 18:31:06 +02:00
Asare Worae
7bcae732bf
resolved merge conflicts
2020-06-30 10:00:52 +02:00
Medya Ghazizadeh
9e35037ed9
Merge pull request #8593 from sunny-b/gracefully-fail-misspelled-runtime
...
Gracefully exit if container runtime is misspelled
2020-06-29 22:07:57 -07:00
Medya Ghazizadeh
2b5254cf91
Merge pull request #8598 from afbjorklund/modprobe-br_netfilter
...
Don't verify nf_conntrack for br_netfilter
2020-06-29 21:13:13 -07:00
Sunny Beatteay
28238150f5
ensure that 'crio' is used for k8s config
2020-06-29 19:52:30 -04:00
Medya Gh
3bc3ce95de
refactor maybeExitWithAdvice
2020-06-29 14:38:37 -07:00
Anders F Björklund
a9273beec7
Don't verify nf_conntrack for br_netfilter
...
We need to make sure that the br_netfilter kernel module
has been loaded, when using non-Docker container runtimes.
But the code was verifying the nf_conntrack kernel module
instead, so it could still cause the "not loaded" error.
[ERROR FileContent--proc-sys-net-bridge-bridge-nf-call-iptables]
2020-06-29 22:30:13 +02:00
Medya Gh
08df5e2de3
add solution message if kbueadm is not executble on linux
2020-06-29 12:50:32 -07:00
Sunny Beatteay
9bcc587def
update crio to cri-o in docs and help text
2020-06-29 14:11:20 -04:00
Sunny Beatteay
5da2fdd922
enable graceful exit if container runtime is misspelled
2020-06-28 18:57:03 -04:00
Ilya Danilkin
e1f443e121
bsutil: add 'etcd' to the KubeadmExtraConfigOpts
2020-06-28 23:29:25 +03:00
Ilya Danilkin
83bb1e32d2
reoder extra-config consts
2020-06-28 22:51:29 +03:00
Ilya Danilkin
b470860a5a
fix condition check for extraOpts validation
2020-06-28 22:35:40 +03:00
Ilya Danilkin
ccffa40cfe
bsutil: extra-opts validation
2020-06-28 22:35:40 +03:00
Ilya Danilkin
d1ab5312d5
bsutil: list valid keys as slice instead of a map
2020-06-28 22:33:36 +03:00
Ilya Danilkin
79eaa8778a
bsutil: fix error msg for `--extra-config` parsing
2020-06-28 22:33:36 +03:00
Anders F Björklund
eaeb5f6060
Use preloaded tarball for cri-o container runtime
...
Pretty much the same as containerd, minus Restart
(cherry picked from commit d9fb2e05420c8f3526d1b1079ee129842ea5522c)
2020-06-28 16:46:54 +02:00
Anders F Björklund
f23bbea995
Support more error messages for container inspect
...
The messages are different between "inspect" and "container inspect",
and also changed a bit in format between Podman v1 and Podman v2.
Support all of them, for compatibility with different versions of
Docker and Podman. Was causing restarts and failures, with KIC.
2020-06-28 14:19:09 +02:00
Anders F Björklund
51b4d2eb24
Normalize name of the container runtime param
2020-06-28 13:45:22 +02:00
Anders F Björklund
b87a837f2e
Use the actual storage driver name for cri-o
2020-06-28 09:49:50 +02:00
Prasad Katti
42af47b909
Do not auto-set extra config that user wishes to override
2020-06-27 16:26:07 -07:00
Thomas Strömberg
cdc456a19b
Merge pull request #8570 from tstromberg/cni-split2
...
CNI: Update CRIO netconfig with matching subnet
2020-06-26 17:13:49 -07:00
Medya Gh
e829341b9d
improve logging
2020-06-26 15:12:15 -07:00
Medya Gh
64553e281b
revert debugging
2020-06-26 15:11:03 -07:00
Medya Gh
742dcd6b00
add addon status verification for 3 addons
2020-06-26 15:08:38 -07:00
Medya Gh
66421a6492
wait for ingress pod be running
2020-06-26 14:22:17 -07:00
Medya Gh
52f4e130b5
lint
2020-06-26 13:20:31 -07:00
Medya Gh
5fbf197b18
remove unrelated changes
2020-06-26 13:20:31 -07:00
Medya Gh
96781c61a2
remove unrelated changes
2020-06-26 13:20:30 -07:00
Medya Gh
058a732909
ingress addon validate deployment after enable
2020-06-26 13:20:30 -07:00
Medya Gh
c47854b8fd
add validate ingress
2020-06-26 13:20:30 -07:00
Medya Gh
a0c33f82c1
ingress addon wait for it
2020-06-26 13:20:30 -07:00
Anders F Björklund
a1991e596d
Only use docker client for docker runtime
...
Previously _always_ asking the docker daemon
Including for other runtimes, such as podman
2020-06-26 22:12:43 +02:00
Medya Ghazizadeh
e8cebe0330
Merge pull request #8575 from afbjorklund/podman-dev
...
Support prerelease versions of podman binary
2020-06-26 12:49:50 -07:00
Anders F Björklund
9d98e858a3
Support prerelease versions of podman binary
...
It was trying to parse the newline character
2020-06-26 21:37:44 +02:00
Priya Wadhwa
7c2cac612d
Fix bug in FailFastError and add unit test
...
Since FailFastError was just another `error`, all errors were technically `FailFastErrors`.
This code makes `FailFastError` a struct which implements the error interface, so that now errors can be distinctly identified as `FailFastError`'
Also added a unit test to prove that this works now.
2020-06-26 11:58:34 -07:00
Thomas Stromberg
ffcb14a6b2
Add support for Cilium CNI (--cni=cilium)
2020-06-26 11:55:30 -07:00
priyawadhwa
7d79241ea5
Merge pull request #8565 from priyawadhwa/update-alternatives
...
Check for iptables file before determining container is running
2020-06-26 11:29:52 -07:00
Thomas Stromberg
f901e638f2
Add support for Calico CNI (--cni=calico)
2020-06-26 11:21:15 -07:00
Thomas Stromberg
f192df8ec5
Update podman/crio CNI netconf files to match CNI subnet
2020-06-26 11:01:13 -07:00
Medya Ghazizadeh
7fb09bb63b
Merge pull request #8562 from tstromberg/patient-status
...
apiserverHealthz: wait up to 8s before declaring failure
2020-06-26 10:10:48 -07:00
Thomas Strömberg
ee18d3b03a
Merge pull request #8545 from tstromberg/cni-split2
...
Add --cni flag (replaces --enable-default-cni), fix --network-plugin handling
2020-06-26 09:53:53 -07:00
Priya Wadhwa
e32e2135ed
review comments
2020-06-25 19:39:59 -07:00
Priya Wadhwa
903686172d
Check for iptables file before determining container is running
2020-06-25 17:58:22 -07:00
Medya Ghazizadeh
0b53e9054a
Merge pull request #8541 from medyagh/modprob_overlay
...
docker driver on linux: Give warning if overlay module is not enabled
2020-06-25 15:39:39 -07:00
Thomas Stromberg
fb8e4950a1
Improve comment
2020-06-25 15:23:39 -07:00
Thomas Stromberg
a43d18ef9a
Update Bridge docstring
2020-06-25 15:21:25 -07:00
Thomas Stromberg
8c5f6a2132
apiserverHealthz: wait up to 8s before declaring failure
2020-06-25 15:14:51 -07:00
Thomas Stromberg
2f3094d32c
simplify string output
2020-06-25 14:43:29 -07:00
Thomas Stromberg
d16e7d4924
Use new kapi.KubectlBinary API
2020-06-25 14:43:19 -07:00
Thomas Stromberg
2a39d993ea
Address lint comments, remove confusing multi-runner API
2020-06-25 14:36:39 -07:00
Thomas Stromberg
521d334b6a
Apply CNI on restarts, remove .rej file
2020-06-25 14:23:18 -07:00
Thomas Stromberg
3968631b05
Merge to master
2020-06-25 10:54:42 -07:00
Thomas Strömberg
72e13c1eb8
Merge pull request #8543 from tstromberg/syspods-logging
...
Improve error and logging emitted by WaitForAppsRunning
2020-06-25 10:53:36 -07:00
priyawadhwa
a115db6da8
Merge pull request #8552 from priyawadhwa/coredns
...
Reduce coredns replicas from 2 to 1
2020-06-25 10:51:18 -07:00
Priya Wadhwa
1769750b7d
fix log level
2020-06-25 10:11:29 -07:00
Thomas Stromberg
3fb1cded91
Add retry.Local + retry logging
2020-06-25 09:43:45 -07:00
Priya Wadhwa
1b8eaaf76c
Move kubectl binary function to kapi package to prevent future cyclic import dependencies
2020-06-25 09:40:14 -07:00
priyawadhwa
d368674457
Merge pull request #8551 from priyawadhwa/etcd-extra-args
...
Allow passing in extra args to etcd via command line
2020-06-25 09:37:41 -07:00
Asare Worae
134ec1b144
changed `--docker-volume` flag logic to work from `--mount-string` and `--mount` flags
2020-06-25 09:16:04 +02:00
Priya Wadhwa
6d3a0c4eca
Reduce coredns replicas from 2 to 1
...
This is an easy way to improve overhead, and users can always scale this back up if they need to.
2020-06-24 17:42:12 -07:00
Priya Wadhwa
1b0de27d3d
fix spelling
2020-06-24 16:43:32 -07:00
Priya Wadhwa
9d9d512cd8
fix function so we don't get an index out of bounds error
2020-06-24 16:34:58 -07:00
Priya Wadhwa
57574e3b6d
fix space bug in unit test
2020-06-24 16:19:33 -07:00
Priya Wadhwa
b32487adb1
Only include etcd extra args if they exist
2020-06-24 15:54:19 -07:00
Priya Wadhwa
c1e2751ea6
Allow passing in extra args to etcd
2020-06-24 15:41:13 -07:00
priyawadhwa
84365fe57b
Merge pull request #8294 from maciaszczykm/dashboard-v2.0.1
...
Bump Dashboard to v2.0.1
2020-06-24 11:35:28 -07:00
Medya Ghazizadeh
977411bf75
Merge pull request #8544 from tstromberg/WaitForNode
...
Skip node pressure check if other checks failed, add retry
2020-06-24 10:26:25 -07:00
Thomas Stromberg
a0817b6221
Remove debug statement
2020-06-24 07:53:18 -07:00
Thomas Stromberg
af1798728b
virtualbox: double health check timeout, add better errors
2020-06-24 07:51:50 -07:00
Thomas Stromberg
9e95435e00
Add --cni flag, fix --network-plugin=kubenet
2020-06-23 20:10:25 -07:00
Thomas Stromberg
c38995d22d
Skip node pressure check if other checks failed, add retry
2020-06-23 19:58:27 -07:00
Thomas Stromberg
54e70c9826
Improve error and logging emitted by WaitForAppsRunning
2020-06-23 19:36:28 -07:00
Medya Ghazizadeh
4f6a9f6518
Merge pull request #8518 from afbjorklund/docker-containerd
...
Make sure to use internal containerd for docker
2020-06-23 16:49:14 -07:00
Marcin Niemira
11a45dd525
add file missing in previous commit
2020-06-24 07:33:19 +10:00
Marcin Niemira
baa443a83c
use default arg instead of env variable for passing minikube home
2020-06-24 07:29:54 +10:00
Medya Gh
0121b44175
add NeedsImprovement warnning for overlay kernel
2020-06-23 13:17:59 -07:00
Medya Gh
1101f543d0
add check for mod prob
2020-06-23 12:15:57 -07:00
Anders F Björklund
4027ba4979
Add test case restarting docker after containerd
...
If we stopped containerd, we restart dockerd.
2020-06-23 20:26:34 +02:00
Anders F Björklund
e25ab786ff
Only restart dockerd if containerd was running
...
If starting minikube a second time, do nothing.
2020-06-23 20:17:01 +02:00
Thomas Strömberg
f52a682a7e
Merge pull request #8531 from jtzwu/master
...
Do not output usage hint when shell=none.
2020-06-23 10:57:42 -07:00
Thomas Stromberg
852da00c03
Remove trailing spaces after leader-elect: false
2020-06-23 07:55:30 -07:00
Marcin Niemira
04d971ad86
add partial test to mustload
2020-06-23 20:07:55 +10:00
Jeff Wu
e1a7b225b3
Format code
2020-06-22 22:00:31 -07:00
Jeff Wu
33d4ecbcc1
Fix shell test to reflect the fact that shell=none no longer has a usage msg.
2020-06-22 21:36:08 -07:00
Jeff Wu
f19ca53f34
Do not output usage hint when shell=none. Since there is no shell,
...
there is no clear way to expect how a usage hint will be interpretted.
2020-06-22 21:22:43 -07:00
Anders F Björklund
63270ad3d6
Restore newline that was removed by mistake
2020-06-20 13:17:29 +02:00
Anders F Björklund
5021c2f2fa
Handle the empty SHELL special case ourselves
2020-06-20 13:13:09 +02:00
Anders F Björklund
8fc6dac9c5
Don't return error when SHELL has not been set
2020-06-20 13:00:22 +02:00
Anders F Björklund
22e1a41899
Adjust unit test results when docker not bound
...
When docker.service is *not* bound to containerd.service,
that means that it will be restarted to not try to use it.
2020-06-20 10:26:11 +02:00
Anders F Björklund
f2ea21ab23
Make sure to use internal containerd for docker
...
When not using the containerd.service, we should make
sure that dockerd does not use the stopped containerd.
2020-06-20 10:01:52 +02:00
colvin
3d2ae5423c
Rename podsecuritypolicies addon to pod-security-policy
2020-06-18 17:00:08 -04:00
Marcin Maciaszczyk
d02b4b0df4
Bump preload version
2020-06-18 10:37:40 +02:00
Medya Gh
e91e11eeba
address review comments
2020-06-17 18:32:11 -07:00
Medya Gh
29e01d5dcb
fix comment
2020-06-17 15:17:45 -07:00
Medya Gh
dacd980fe7
add err type for start too
2020-06-17 15:15:23 -07:00
Medya Gh
ca2d0f97ec
move advice to its own file
2020-06-17 15:07:17 -07:00
Medya Gh
543b0b5bfa
add post mortem logs when container not running
2020-06-17 13:27:17 -07:00
Medya Gh
736f5219e0
add error type for check running
2020-06-17 12:13:12 -07:00
Medya Ghazizadeh
18e89bbca2
Merge pull request #8499 from medyagh/sol_msg_cpucount
...
docker/podman: add advice for cpu count error
2020-06-17 11:52:01 -07:00
Li Zhijian
e6b905608d
kubeconfig_test: cleanup temp kubeconfig file
...
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-17 18:37:05 +08:00
Medya Gh
56b5524c8e
address review comments
2020-06-16 14:57:19 -07:00
Medya Ghazizadeh
16c3e95260
Merge pull request #8475 from 11janci/jjanik-fix-hostip-vbox
...
Fix host network interface for VBox
2020-06-16 13:40:34 -07:00
Medya Gh
4caf260279
add cpu count limit error type for kic drivers
2020-06-16 13:21:56 -07:00
Medya Gh
6e08caa4cf
add timed out log
2020-06-16 11:59:17 -07:00
Medya Gh
e07446a498
address review comments
2020-06-16 11:56:18 -07:00
Medya Gh
0aa313581f
address review comments
2020-06-16 11:27:02 -07:00
Li Zhijian
e7121b7290
unify TempDir for testing
...
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-16 09:53:58 +08:00
Li Zhijian
24c9ce079d
cleanup TempDir properly
...
a TempDir is like /tmp/minipath255070191/.minikube
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-16 09:34:25 +08:00
Medya Gh
a64038dfd0
better wording
2020-06-15 14:59:52 -07:00
Medya Gh
0e96154fc2
add better solution message when docker needs factory reset
2020-06-15 14:59:17 -07:00
Medya Gh
bb6c84f7ad
provide better solution message
2020-06-15 14:52:31 -07:00
Medya Ghazizadeh
804e772efd
Merge pull request #8455 from govargo/add-heapster-alias
...
Add heapster alias to metrics-server addon
2020-06-14 16:46:55 -07:00
jjanik
bf59d39587
fix host IP for virtualbox
2020-06-14 15:28:08 +02:00
Priya Wadhwa
6ef48499b4
Code review comments
2020-06-12 11:00:46 -07:00
Kenta Iso
ab58dca23d
replace to metrics-server in case of `minikube start --addons heapster`
2020-06-13 01:07:16 +09:00
Kenta Iso
803461ddcf
if the specified addon doesn't exist, skip enabling
2020-06-13 00:46:12 +09:00
Kenta Iso
9d71fc635b
remove unneccesary config
2020-06-13 00:46:12 +09:00
Kenta Iso
d76b58c3ae
Add heapster alias to metrics-server addon
2020-06-13 00:46:12 +09:00
Priya Wadhwa
b750ab4964
fix lint
2020-06-11 13:00:46 -07:00
Priya Wadhwa
330224f36a
Warn user to restart daemon if context deadline is exceeded
2020-06-11 12:50:11 -07:00
Priya Wadhwa
0ec839186d
Change glog.Errorf to glog.Infof so that we don't get an ugly log to stdout
2020-06-11 11:14:04 -07:00
Thomas Strömberg
db116c2689
Merge pull request #8428 from tstromberg/minikube-blacklist
...
Replace whitelist/blacklist with allow/deny
2020-06-11 07:18:02 -07:00
colvin
b32cb5e6ba
Create a podsecuritypolicies addon
...
Create a new addon, `podsecuritypolicies` that applies the
PodSecurityPolicy and related RBAC configuration from the
https://minikube.sigs.k8s.io/docs/tutorials/using_psp/ tutorial.
Apparently, recent work on the addons system has invalidated the
procedure shown in that tutorial, as the configuration is no longer
automatically applied. The last known working version is `1.6.2`.
This allows clusters started with
`--extra-configs=apiserver.enable-admission-plugins=PodSecurityPolicy`
to succeed, so long as they also include `--addons=podsecuritypolicies`.
2020-06-11 09:51:13 -04:00
Medya Ghazizadeh
ae555bf393
Merge pull request #8342 from prasadkatti/kubelet_flag_to_config
...
Set `failSwapOn` and `clusterDomain` via kubelet config file
2020-06-10 16:53:38 -07:00
Thomas Stromberg
bd1bdb3696
Use 'Allowed' instead of 'Allow'
2020-06-10 14:56:22 -07:00
Priya Wadhwa
6fcc987cc4
Add v1alpha3
2020-06-10 11:21:26 -07:00
Priya Wadhwa
69387a3937
Add in extra args for v1beta1
2020-06-10 10:58:37 -07:00
Marcin Maciaszczyk
424e158856
Fix unit tests
2020-06-10 10:41:19 +02:00
Thomas Stromberg
09672520ea
Merge branch 'master' into minikube-blacklist
2020-06-09 16:49:39 -07:00