Thomas Stromberg
3b42f5607a
Remove TestCreateSSHShell - it's been flaky for years
2020-08-21 13:59:24 -07:00
Thomas Stromberg
d2667324f6
Update DefaultKubernetesVersion to v1.19.0-rc.4
2020-08-21 13:39:28 -07:00
Thomas Strömberg
135d7bd7e4
Merge pull request #9045 from tstromberg/1.19.0-rc.4-updated
...
Update NewestKubernetesVersion to v1.19.0-rc.4
2020-08-21 13:38:51 -07:00
Thomas Strömberg
f492215009
Merge pull request #9046 from tstromberg/cni-true
...
Allow flannel CNI to work with kicbase by fixing IP conflict
2020-08-21 13:38:39 -07:00
Priya Wadhwa
88aece40d2
change name
2020-08-21 15:05:37 -04:00
Thomas Stromberg
c254778f39
Update CoreDNS and etcd images for Kubernetes v1.19
2020-08-21 10:45:23 -07:00
Thomas Stromberg
0cfd9e7cf4
Merge branch 'master' into 1.19.0-rc.4-updated
2020-08-21 10:44:31 -07:00
Priya Wadhwa
acd6589c5d
Remove debugging
2020-08-21 09:56:03 -04:00
Priya Wadhwa
44b93f4776
Change MemoryCapacity to StorageCapacity to be more accurate
2020-08-21 09:49:48 -04:00
Thomas Stromberg
c052d1ad18
Allow flannel CNI to work with kicbase by relocating conflicting file
2020-08-20 17:54:42 -07:00
Priya Wadhwa
4fcffca3db
write events to file, but not in parallel
2020-08-20 20:48:18 -04:00
Thomas Strömberg
e2e4ef168d
Merge pull request #8850 from priyawadhwa/proxy
...
set proxy-refresh-interval=70000 for etcd to improve CPU overhead
2020-08-20 14:05:11 -07:00
Thomas Stromberg
444dde078f
Update NewestVersion to v1.19.0-rc.4
2020-08-20 13:38:45 -07:00
Priya Wadhwa
7eda3a7711
Create new exit code for InsufficientStorage
2020-08-20 15:27:06 -04:00
Medya Gh
0afe83e015
reduce machine lock time for docker driver
2020-08-20 11:45:12 -07:00
Medya Ghazizadeh
b27dbc0dd4
Merge pull request #9037 from medyagh/swarm_
...
add swarm and storage driver to DaemonInfo
2020-08-20 09:55:55 -07:00
Li Zhijian
113e640c0d
create a temp MinikubeHome for a few cluster tests
...
these tests will write something to the MinikubeHome. Previously, these
tests will use the environment value of MinikubeHome directly which might
dirty the previous MiniKubeHome
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-20 11:49:12 +08:00
Li Zhijian
95e7203900
add a temp MinikubeHome for TestStart
...
this test will write a config.json into MinikubeHome, create a temp dir for it
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-20 11:49:07 +08:00
Medya Gh
56691f839c
add swarm and storage driver to DaemonInfo
2020-08-19 15:38:56 -07:00
Priya Wadhwa
e1deec7019
improve output
2020-08-19 17:57:56 -04:00
Priya Wadhwa
e1ed864708
Merge branch 'master' of https://github.com/kubernetes/minikube into var-status-code
2020-08-19 17:44:51 -04:00
Priya Wadhwa
a32896192d
add todo
2020-08-19 16:31:23 -04:00
Priya Wadhwa
4e638a1a0d
include tip about pruning via minikube ssh
2020-08-19 15:28:06 -04:00
Priya Wadhwa
704a2a7a83
Merge branch 'master' of https://github.com/kubernetes/minikube into var-warning
2020-08-19 15:17:44 -04:00
Priya Wadhwa
4d1c1c0dc3
Add integration test for insufficient storage
...
Make sure that if /var has full storage, the output of `minikube status` is correct regardless of whether events.json is present or not
2020-08-19 14:16:00 -04:00
Priya Wadhwa
3dba974535
Make sure 'minikube status' displays InsufficientStorage for cluster and nodes
...
if there is insufficient storage. Output now looks like:
```
{
"Name": "minikube",
"StatusCode": 507,
"StatusName": "InsufficientStorage",
"StatusDetail": "/var is almost out of disk space",
"Step": "Starting Node",
"StepDetail": "Updating the running docker \"minikube\" container ...",
"BinaryVersion": "v1.12.3",
"Components": {
"kubeconfig": {
"Name": "kubeconfig",
"StatusCode": 500,
"StatusName": ""
}
},
"Nodes": [
{
"Name": "minikube",
"StatusCode": 507,
"StatusName": "InsufficientStorage",
"Components": {
"apiserver": {
"Name": "apiserver",
"StatusCode": 405,
"StatusName": "Stopped"
},
"kubelet": {
"Name": "kubelet",
"StatusCode": 405,
"StatusName": "Stopped"
}
}
}
]
}
```
2020-08-19 13:25:48 -04:00
Thomas Strömberg
dd11ed8da0
Merge pull request #8989 from superbrothers/fix-nil-pointer-dereference
...
minikube update-context: Fix nil pointer dereference
2020-08-19 10:06:14 -07:00
Priya Wadhwa
064f021cf1
improve regex so this only works for docker
2020-08-19 10:29:21 -04:00
Priya Wadhwa
5033d24aae
Include review comments
2020-08-19 10:25:58 -04:00
Li Zhijian
50459e0566
add testing cleanup hook for createTestProfile
...
T.cleanup() is introduced since go-1.14
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-19 18:10:07 +08:00
Li Zhijian
640e9b64f8
cleanup tempdir properly for localpath_test
...
'path' could be changed during the test
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-19 16:56:14 +08:00
Priya Wadhwa
edc3c95081
Add a problem with advice to prune if no space on device error is seen
2020-08-18 19:30:57 -04:00
Priya Wadhwa
0f4d0b6584
Include post start validations that warn the users if /var is full
2020-08-18 19:05:08 -04:00
Medya Gh
e0d0ae1e19
correct comit sha
2020-08-17 16:56:25 -07:00
Medya Gh
20dd3e8ade
update kicbase to snapshot
2020-08-17 14:28:02 -07:00
Kazuki Suda
79d5641c53
Revert support for adding context if no clusters in the kubeconfig
2020-08-16 09:36:09 +09:00
Kazuki Suda
c41a5f19b7
minikube upate-cotext: Fix nil pointer dereference
2020-08-13 12:34:00 +09:00
Kazuki Suda
a3fe0f5c49
Fix "Using reference to loop iterator variable" in t.Parallel()
2020-08-13 11:33:55 +09:00
Priya Wadhwa
52953bac93
Merge branch 'master' of github.com:kubernetes/minikube into kic-add-static-ip
2020-08-12 14:03:43 -07:00
Priya Wadhwa
a949f9ca7b
improvement
2020-08-12 12:58:21 -07:00
Priya Wadhwa
bdb59c2598
lint
2020-08-12 12:56:07 -07:00
Priya Wadhwa
dfa05d714e
include gateway when creating custom network
2020-08-12 12:54:06 -07:00
Priya Wadhwa
af94e0a0c5
add logging
2020-08-12 10:57:48 -07:00
Priya Wadhwa
2400d1b850
remove network correctly
2020-08-12 10:08:46 -07:00
Priya Wadhwa
69d21df7c5
make sure we use custom network if it exists
2020-08-12 12:45:49 -04:00
Priya Wadhwa
3b5f973459
make sure we delete networks correctly
2020-08-12 12:36:57 -04:00
Priya Wadhwa
28cfb5899c
Merge branch 'master' of https://github.com/kubernetes/minikube into proxy
2020-08-12 10:43:53 -04:00
staticdev
4c5109b435
Fix go lint
2020-08-12 08:48:22 -03:00
staticdev
969bc9fd2c
Add timing enable ingress
2020-08-12 08:09:38 -03:00
Sharif Elgamal
200400e52c
Merge branch 'master' of github.com:kubernetes/minikube into add-kubectl
2020-08-11 15:58:26 -07:00
Medya Ghazizadeh
f6ebaa8871
Merge pull request #8820 from Dean-Coakley/fix-minikube-ip-errhandle
...
Fix handling of parseIP error
2020-08-11 15:52:22 -07:00
Medya Ghazizadeh
01454778ac
Merge pull request #8975 from medyagh/hypervdebug
...
log hyperv errs
2020-08-11 15:50:23 -07:00
Medya Ghazizadeh
51bbba9bdc
Merge pull request #8973 from medyagh/daemon_info_unittest
...
add unit test for daemon info
2020-08-11 15:50:02 -07:00
Medya Gh
f20d3bddf0
add boilerplate
2020-08-11 15:13:16 -07:00
Medya Gh
25dc0cd0f7
lint
2020-08-11 15:03:10 -07:00
Medya Gh
f8d932e697
use mock funcs
2020-08-11 14:55:30 -07:00
Medya Gh
0fe3a96ea4
log hyperv errs
2020-08-11 13:48:11 -07:00
Thomas Strömberg
1854dd818c
Merge pull request #8972 from tstromberg/record-output
...
Log output for post-mortem analysis
2020-08-11 13:41:14 -07:00
Medya Gh
4c0334d91f
add one more case
2020-08-11 13:10:17 -07:00
Medya Gh
a9eec3ca7b
add unit test for daemon info
2020-08-11 13:06:50 -07:00
Thomas Stromberg
606f8511ce
Log output for post-mortem analysis
2020-08-11 12:41:39 -07:00
Medya Gh
7463eda122
remvoe comment
2020-08-11 10:40:40 -07:00
Medya Gh
9409158d09
lint
2020-08-11 10:40:40 -07:00
Medya Gh
b0afc85327
dont fail on memory check if cpu and disk checks fail
2020-08-11 10:40:40 -07:00
Medya Gh
1d94fa911a
ensure nil error is returned
2020-08-11 10:40:40 -07:00
Medya Gh
51011688b2
wrap errs
2020-08-11 10:40:40 -07:00
Medya Gh
84d198d8b5
refresh cache if there was error
2020-08-11 10:40:40 -07:00
Medya Gh
5cb47d75af
return list of errors for cached host info
2020-08-11 10:40:40 -07:00
Medya Gh
bbc58fa194
refresh daemon info cache if there is error
2020-08-11 10:40:40 -07:00
Medya Ghazizadeh
8b6a0eb4fb
Merge pull request #8948 from kadern0/issue-8897
...
Added startHostTimeout flag
2020-08-11 10:36:21 -07:00
Pablo Caderno
9354d2c0e5
Removed extra flag add.
...
Set default value if not specified by the user.
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-11 19:05:12 +10:00
Dean Coakley
c3de6d6bb1
Fix handling of parseIP error
2020-08-11 00:59:45 +01:00
Priya Wadhwa
fb1bc3afbb
fix network name
2020-08-10 17:33:32 -04:00
Priya Wadhwa
21789d8c4e
compile
2020-08-10 17:18:42 -04:00
Priya Wadhwa
dfcfd6f2f0
cleanup
2020-08-10 17:15:26 -04:00
Priya Wadhwa
9dcb0c5478
fix merge conflict
2020-08-10 17:12:56 -04:00
Priya Wadhwa
5799b47ddb
Implement some checks and reorganize code
2020-08-10 17:04:41 -04:00
Medya Ghazizadeh
a13e5e5512
Merge pull request #8870 from Dean-Coakley/add-ingress-noneDriver-warn
...
Add warning for ingress addon enabled with driver of none
2020-08-10 13:17:54 -07:00
Medya Ghazizadeh
63b2cc15bd
Merge pull request #8533 from n0npax/mustloat-partial-test
...
add unit test for mustload pkg
2020-08-10 12:29:42 -07:00
Medya Ghazizadeh
9373842ea1
Merge pull request #8885 from lingsamuel/ignore-localhost-proxy-with-scheme
...
Ignore localhost proxy started with scheme.
2020-08-10 12:13:15 -07:00
Priya Wadhwa
4c0360a9e6
Merge branch 'master' of https://github.com/kubernetes/minikube into proxy
2020-08-10 11:27:17 -04:00
Pablo Caderno
37a1d3bc0b
Added startHostTimeout flag
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-10 16:23:13 +10:00
Sharif Elgamal
02930c0d51
fix tip output and do not output ending tip disabling
2020-08-06 13:45:46 -07:00
Sharif Elgamal
16ba55d05f
better error message
2020-08-06 12:36:54 -07:00
Sharif Elgamal
90dadd0ce6
better error messages for not finding creds
2020-08-06 11:47:09 -07:00
Anders F Björklund
9802423d9a
Add ImagesPreloaded to cruntime Manager interface
...
To make sure that it is actually called for all container runtimes,
including CRIO which was missing (only had Docker and Containerd)
2020-08-05 22:20:41 +02:00
Medya Gh
98c2157242
address review comments
2020-08-04 13:26:33 -07:00
Medya Gh
e87400db53
addres review comments
2020-08-04 13:26:33 -07:00
Medya Gh
b71a7dceca
use cached hostinfo instead
2020-08-04 13:26:33 -07:00
Medya Ghazizadeh
8698f9efbd
Merge pull request #8908 from linkvt/add-common-names-to-certificate-SANs
...
Add "minikube" and machineName to docker certificate SANs
2020-08-04 09:50:38 -07:00
Vincent Link
e95f279449
Add "minikube" and machineName to docker certificate SANs
...
See #6367
2020-08-03 20:42:12 +02:00
Priya Wadhwa
52bee6dced
Bump up preload version for new storage provisioner image
2020-08-03 13:50:22 -04:00
Priya Wadhwa
0538dddd9d
Upgrade storage provisioner to v2
2020-08-03 13:48:09 -04:00
Sharif Elgamal
7ef3a8c11a
respect native-ssh flag
2020-08-03 09:48:30 -07:00
Sharif Elgamal
5ba7281a0a
Merge pull request #8899 from sharifelgamal/new-kicbase
...
Upgrade kicbase to v0.0.11
2020-07-31 16:09:45 -07:00
Sharif Elgamal
bf85c88a56
Merge pull request #8896 from tstromberg/crio-fixes
...
Add stopping as a possible state in deleting, change errorf to warningf
2020-07-31 15:02:39 -07:00
Sharif Elgamal
d83b4a9654
Upgrade kicbase to v0.0.11
2020-07-31 10:46:11 -07:00
Sharif Elgamal
a231c8a151
Merge pull request #8887 from Ajitesh13/master
...
virtualbox: improve solution message -> ensure it is in the path #8453
2020-07-31 09:10:17 -07:00
Medya Ghazizadeh
31e6c4cc25
Merge pull request #8880 from niedhui/base-image-mirror
...
make base-image respect --image-repository
2020-07-30 21:32:58 -07:00
Thomas Stromberg
4384e67eb1
Add stopping as a possible state in deleting, change errorf to warningf
2020-07-30 16:11:26 -07:00
root
d1e8d47f80
fix typos
2020-07-30 12:47:08 +00:00
Ajitesh13
c4957e4383
virtualbox: improve solution message -> ensure it is in the path #8453
2020-07-30 16:53:18 +05:30
niedhui
22edb6f063
make baseImage respect imageRepo
...
Signed-off-by: niedhui <niedhui@gmail.com>
2020-07-30 16:59:56 +08:00
Ling Samuel
bb57ae0c15
Ignore localhost proxy started with scheme. Fix start_test.
...
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2020-07-30 16:17:04 +08:00
Thomas Stromberg
c6e6013d40
Update unit tests
2020-07-29 14:08:48 -07:00
Thomas Stromberg
59d0d7335a
Add HTTP-like status codes, remove unused fields
2020-07-29 13:57:06 -07:00
Dean Coakley
9c23485dfb
Remove list of alternative drivers
2020-07-29 09:40:43 +01:00
Dean Coakley
4b2974472d
Improve error message text
2020-07-28 22:40:55 +01:00
Dean Coakley
b27440d4ae
Add warning for ingress addon with driver of none
2020-07-28 22:40:15 +01:00
Thomas Stromberg
aa3d2a2a8a
Improve handling of pause/unpause/stop/delete steps
2020-07-28 13:26:09 -07:00
Thomas Stromberg
ac1f901160
Allow non-start steps
2020-07-28 13:07:37 -07:00
Sharif Elgamal
2cc7445f1c
guard against joining the cluster twice
2020-07-28 12:16:33 -07:00
Thomas Stromberg
448ec75c8c
Add support for storing/retrieving transient status
2020-07-27 21:34:52 -07:00
Priya Wadhwa
1c1ac4273c
set proxy-refresh-interval=70000 for etcd to improve CPU overhead
2020-07-27 14:35:59 -04:00
Priya Wadhwa
9680237277
WIP
2020-07-27 14:24:40 -04:00
Sharif Elgamal
d546ea1b5c
Merge pull request #8817 from sharifelgamal/restart-kubelet
...
restart kubelet if config changes
2020-07-24 15:48:53 -07:00
Medya Gh
47ed4bc23c
update lint version
2020-07-24 14:45:15 -07:00
Medya Ghazizadeh
1395c8017c
Merge pull request #8784 from Dean-Coakley/disable-podman2
...
Warn user for podman2 version
2020-07-24 14:40:18 -07:00
Medya Ghazizadeh
8f404164d0
Merge pull request #8745 from littleroad/error_detect
...
Add error handling for os.RemoveAll
2020-07-24 14:38:10 -07:00
Dean Coakley
dc566bec0b
Remove warning prefix
2020-07-24 21:49:13 +01:00
Dean Coakley
57649f8ee8
Quote version numbers
2020-07-24 21:42:20 +01:00
Dean Coakley
fa04c83b83
Use UI for logging
2020-07-24 21:25:19 +01:00
Thomas Stromberg
9c0618f102
Merge to master
2020-07-24 11:22:59 -07:00
Medya Ghazizadeh
76b98ace96
Merge pull request #8827 from tstromberg/kic-longer
...
Increase maximum container startup wait from 13 seconds to 25 seconds
2020-07-24 11:10:39 -07:00
Sharif Elgamal
b9c218261d
adding debugging
2020-07-24 10:45:14 -07:00
Thomas Stromberg
f8f689b5cc
Merge branch 'master' into kic-show-errs
2020-07-24 09:06:56 -07:00
Thomas Stromberg
bd713ffd45
Increase maximum container startup wait from 13 seconds to 25 seconds
2020-07-24 09:02:32 -07:00
Thomas Stromberg
dee9c0b427
Show 'docker logs' excerpt if container dies
2020-07-24 08:58:09 -07:00
Thomas Stromberg
e172a7ee1c
Avoid panic: runtime error: invalid memory address or nil pointer dereference
2020-07-24 08:48:20 -07:00
Dean Coakley
db4bf9ec2a
Log warning instead of exit with error
2020-07-24 11:30:23 +01:00
Sharif Elgamal
be160406ec
remove space
2020-07-23 14:45:42 -07:00
Sharif Elgamal
82c4d49eb8
restart kubelet if config changes
2020-07-23 14:43:23 -07:00
Medya Ghazizadeh
993504e054
Merge pull request #8800 from priyawadhwa/improve-json
...
Improve json integration test
2020-07-23 10:23:36 -07:00
Medya Ghazizadeh
f230ca0c55
Merge pull request #8804 from medyagh/hot_upgrade_fix
...
Stop kube-system containers before applying configuration updates
2020-07-23 10:03:54 -07:00
Medya Ghazizadeh
b7b26ea2d5
Merge pull request #8737 from dddddai/master
...
Use RWMutex instead of Mutex
2020-07-23 09:57:25 -07:00
vinu2003
907cd34b78
fixed unit test based on update to v1.18.0
2020-07-24 02:22:26 +10:00
Medya Gh
44b6703e68
update comment
2020-07-23 09:17:30 -07:00
Medya Gh
d5cc6afc9b
update comment
2020-07-23 09:17:06 -07:00
Asare Worae
a31e359b01
fixed unwanted spinning up of mount deamon when using KIC drivers, and added same host mounted volumes logic for the Podman driver
2020-07-23 11:47:16 +02:00
Priya Wadhwa
2cba801d50
fix order
2020-07-22 20:47:41 -04:00
Priya Wadhwa
a03f25e976
add step to register
2020-07-22 18:50:42 -04:00
Priya Wadhwa
22226ffc8f
fixed merge conflict
2020-07-22 18:46:57 -04:00
priyawadhwa
25566c90f0
Merge pull request #8796 from priyawadhwa/error
...
Add support for Error type to JSON output
2020-07-22 18:43:46 -04:00
Priya Wadhwa
df0bc948bc
Add logging to none driver
2020-07-22 18:42:38 -04:00
Medya Gh
9fa1dfdaec
stop conainers before hot upgrade
2020-07-22 15:14:57 -07:00
Priya Wadhwa
3f18ecb052
add log
2020-07-22 15:01:22 -04:00
Priya Wadhwa
efe1ce278a
Add docs
2020-07-22 14:20:41 -04:00
Medya Ghazizadeh
f2100e365d
Merge pull request #8697 from medyagh/improv_sa_apply
...
improve applying default service account
2020-07-22 11:00:07 -07:00
Sharif Elgamal
ad083ba7ac
Merge pull request #8778 from sharifelgamal/hyerpv
...
allow for prefixed interface names for hyperv
2020-07-21 16:07:42 -07:00
Sharif Elgamal
58d4b0c32f
add less restrictive interface name matching
2020-07-21 15:32:38 -07:00
Priya Wadhwa
6a33c03df2
fix unit test
2020-07-21 18:23:22 -04:00
Priya Wadhwa
8bc875d520
Rebased on master; fixed json_output integration test
2020-07-21 18:20:02 -04:00
priyawadhwa
6df5d19d70
Merge pull request #8793 from priyawadhwa/warning
...
Implement Warning type for JSON output
2020-07-21 18:17:54 -04:00
Medya Ghazizadeh
85f1c4f2dd
Merge pull request #8792 from concaf/concaf/fix/fix-already-started
...
(Addons) Create a new command in every retry
2020-07-21 14:43:14 -07:00
Sharif Elgamal
1b6eee675b
Automated GCP Credentials Addon Prototype ( #8682 )
...
* metadata addon works
* Add code for metadata server image and makefile rules
* remove log message
* update to work with v1.13.11
* update readme
* fix metadata addon stuff for newer codebase
* buncha changes
* just so many changes
* ch-ch-ch-ch-changes
* addon works
* update readme
* boilerplate
* revert unrelated change
* move server code to another repo
* switch addon name to gcp-auth
* metadata -> gcp-auth
* missed one
* automate finding of credentials
* remove unnecessary comment
* address comments
* Update README.md
* Update README.md
* use mustload everywhere
* swap selector condition
* upgrade kube-webhook-certgen to 1.3
* move paths to constants
* add notice to user on addon enable
* adding addon documentation
* move addons documentation inside handbook
* remove old addons docs location
Co-authored-by: Priya Wadhwa <priyawadhwa@google.com>
2020-07-21 14:25:58 -07:00
Medya Ghazizadeh
24fa6280dc
Merge pull request #8588 from afbjorklund/preload-crio-2
...
Use preloaded tarball for cri-o container runtime
2020-07-21 13:59:03 -07:00
Priya Wadhwa
6ca72229bb
add json unit tests
2020-07-21 15:56:26 -04:00
Priya Wadhwa
b4b9013057
Add unit test for problem.DisplayJSON()
2020-07-21 15:51:47 -04:00
Priya Wadhwa
482b9befd6
implement errors in JSON
2020-07-21 15:43:19 -04:00
Medya Ghazizadeh
f04a6a061f
Merge pull request #8586 from afbjorklund/container-id
...
Support more error messages for container inspect
2020-07-21 12:22:31 -07:00
Priya Wadhwa
c60e754624
Implement warning type for JSON output
2020-07-21 14:40:31 -04:00
Shubham
f42f79e56d
(Addons) Create a new command in every retry
...
Whenever a `kubectl apply` fails while enabling an addon, it is
retried with exponential backoff. The command (type `*exec.Cmd`)
that this retry function runs in created outside the function -
which means that it is reused on every retry. This is a problem
because `exec.Cmd` (https://godoc.org/github.com/pkg/exec#Cmd )
states that "... Cmd cannot be reused after calling its Run or
Start methods."
This retry is a common case due to, say, a CRD and its resource
being present in the same YAML file of the addon which causes
a race condition where the resource is created before its CRD is
created in the cluster - this race is fixed by subsequent retries.
I've noticed this in the dashboard and the ambassador addon.
Due to the above mentioned bug, minikube throws errors like
`exec: already started` in every retry and the retry is never
successful, manifests are never deployed and addon creation errors
out.
Related to #8138 #8119 #8372
2020-07-21 21:20:24 +05:30
Dean Coakley
328dbc1f97
Improve fix message
2020-07-21 12:29:53 +01:00
Dean Coakley
66f03b89c3
Update formatting Podman->Podman v2
2020-07-21 12:24:03 +01:00
Anders F Björklund
59bf848e54
Use preloaded tarball for cri-o container runtime
...
Pretty much the same as containerd, minus Restart
2020-07-21 09:05:12 +02:00
Ambor
e00cf6c1e1
fix error usage for the WaitGroup in the pkg addons
2020-07-21 11:57:06 +08:00
dddddai
196789f965
Use RWMutex instead of Mutex
2020-07-21 10:39:45 +08:00
Dean Coakley
0d78fe56af
lint
2020-07-21 03:00:13 +01:00
Dean Coakley
622e33b7ab
Fix typo
2020-07-21 02:55:37 +01:00
Dean Coakley
62683c9b42
Exit with error on podman2 drivers
2020-07-21 02:39:46 +01:00
priyawadhwa
aaebd88251
Merge pull request #8610 from johscheuer/update-storage-provisioner
...
Update external-provisioner for storage provisioner for Kubernetes 1.18
2020-07-20 19:11:38 -04:00
Medya Ghazizadeh
79088e6ed2
Merge pull request #8581 from afbjorklund/preload-crio
...
Generate cri-o container runtime preload tarball
2020-07-20 15:55:31 -07:00
Medya Ghazizadeh
2086bcb2b1
Merge pull request #8718 from medyagh/check_docker_deskop
...
docker/podman: warn if allocated memory is below limit
2020-07-20 15:26:41 -07:00
Sharif Elgamal
f92015df9b
allow for prefix interace names for hyperv
2020-07-20 13:07:13 -07:00
Medya Gh
13357d91a4
avoid nil pointer
2020-07-20 12:56:03 -07:00
Anders F Björklund
22585c3a17
Use the preload container run for podman as well
...
Now that there is no more race between the containers for
preparing the volume, we can use it for podman as well...
Previously we risked ending up with not copying the contents
of /var from the container image, which made it not work.
2020-07-20 21:54:28 +02:00
Anders F Björklund
2a9e9b2425
Make sure to prepare the kic volume after creation
...
The volume is created as empty, so make sure that we run a
container to do the initial copy of /var from the image.
This is to avoid race conditions later on, where the preload
starts to use the created volume for packing up the tarball.
2020-07-20 21:50:13 +02:00
Jose Donizetti
c2175abcba
Add static ip to kic/docker
2020-07-18 18:19:53 -03:00
Jose Donizetti
cd17c872d3
Fix documentation typo
2020-07-18 15:02:09 -03:00
Thomas Stromberg
9546b1ebc6
Merge branch 'master' into kic-image-upgrade
2020-07-17 09:56:42 -07:00
Thomas Strömberg
b7e7ef3a65
Merge pull request #8751 from tstromberg/docker-err-suggestion
...
Add 'Start Docker' guidance for /pipe/docker_engine errors
2020-07-17 09:55:04 -07:00
Thomas Stromberg
f89094dcf8
Adjust comment
2020-07-17 09:46:53 -07:00
Thomas Stromberg
2b614ae856
Add 'Start Docker' guidance for /pipe/docker_engine errors
2020-07-17 09:45:16 -07:00
Thomas Stromberg
3b1dc975d0
legacy client certs: simplify logic
2020-07-17 07:23:48 -07:00
Lu Fengqi
c219b60b05
Add error handling for os.RemoveAll
...
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
2020-07-17 15:44:04 +08:00
Thomas Stromberg
b72eee4e36
Turn Errorf into Infof
2020-07-16 23:07:37 -07:00
Thomas Stromberg
94e866affc
Merge to master
2020-07-16 19:53:43 -07:00
Thomas Stromberg
798196d0ad
Remove stray log line
2020-07-16 19:37:28 -07:00
Thomas Stromberg
be2c27efe0
Find and copy legacy certificate/key paths
2020-07-16 19:37:15 -07:00
Thomas Strömberg
bb2fb3ad97
Merge pull request #8573 from tstromberg/cilium
...
Add support for Cilium CNI (--cni=cilium)
2020-07-16 19:34:44 -07:00
Thomas Stromberg
ccd3682116
Refactor upgrade tests
2020-07-16 17:34:46 -07:00
Marcin Niemira
8f47e32d7c
use pathlib
2020-07-16 18:46:21 +10:00
Thomas Stromberg
fcc15fa353
Merge to master
2020-07-15 21:04:33 -07:00
Thomas Stromberg
14b4a54ba2
Merge to master
2020-07-15 21:03:49 -07:00
Medya Gh
13d37ff7aa
adress review comments
2020-07-15 14:34:01 -07:00
Medya Gh
b0e58a3688
rename to FullName
2020-07-15 14:27:06 -07:00
Medya Gh
3aac9a3fff
remove duplicate return statement
2020-07-15 14:24:42 -07:00
Medya Gh
8ecb483cb7
use cached error
2020-07-15 14:23:25 -07:00
Medya Gh
7bbb0b6250
spell
2020-07-15 14:09:35 -07:00
Medya Gh
de6c10526b
move cacheDaemoninfo to oci package
2020-07-15 14:07:50 -07:00