Commit Graph

4489 Commits (54f94000065d186b05fe6363d090fb1923b9b3e5)

Author SHA1 Message Date
Thomas Strömberg 51a3155cfd
Merge pull request #9126 from tstromberg/error-code-for-everyone
Add a machine readable reason to all error paths
2020-08-31 22:34:24 -07:00
Thomas Strömberg cf7484ed59
Merge pull request #9128 from tstromberg/pvc-directory
Add namespace to persistent volume path
2020-08-31 22:34:03 -07:00
Priya Wadhwa 4a0d3fc703 fix lint' 2020-08-31 18:35:37 -04:00
Priya Wadhwa c2680cc9e4 Merge branch 'master' of https://github.com/kubernetes/minikube into unit-test 2020-08-31 18:35:19 -04:00
Priya Wadhwa 640f7254bc Fix unit test 2020-08-31 18:28:42 -04:00
Priya Wadhwa 5da473e46f fix unit test 2020-08-31 18:27:49 -04:00
Priya Wadhwa 12c9d7f1a8 print stderr to stderr 2020-08-31 18:22:05 -04:00
Priya Wadhwa f31d7781b0 Merge branch 'master' of https://github.com/kubernetes/minikube into download-only 2020-08-31 18:17:47 -04:00
Priya Wadhwa 7750b3c445 mkcmp: download artifacts before timing starT 2020-08-31 18:17:15 -04:00
Priya Wadhwa 695117f3d7 use GCS client to download binaries 2020-08-31 16:30:47 -04:00
Priya Wadhwa e323a6f86e Set leader-elect=false in code instead of in config
This sets leader-elect=false as extra options for the scheduler and controller manager. This way, users can easily override those values. This will also allow users to specify additional flags via `--extra-config` without overwriting the leader-elect section in the config.
2020-08-31 16:03:42 -04:00
Thomas Strömberg df906e5895
Merge pull request #9127 from kubernetes/windows-emoji
Add MINIKUBE_IN_STYLE auto-detection for Windows terminal
2020-08-31 12:58:12 -07:00
Thomas Stromberg 750cf39f1e Code review comments 2020-08-31 12:57:48 -07:00
Thomas Stromberg 09cdf602b8 Update TestFunctional/parallel/DryRun and TestJSONOutputError to match new behavior 2020-08-31 11:21:23 -07:00
Thomas Stromberg 69214c08bb Update test data 2020-08-31 11:11:25 -07:00
Thomas Stromberg 464bd48ea1 Update dashboard to v2.0.3 2020-08-30 22:32:20 -07:00
Thomas Stromberg c152570f6c Add namespace to persistent volume path 2020-08-30 22:27:04 -07:00
Thomas Stromberg b91b5f9cc4 Merge remote-tracking branch 'upstream/master' into windows-emoji 2020-08-30 22:11:27 -07:00
Thomas Stromberg 764f4a0b27 Add MINIKUBE_IN_STYLE auto-detection for Windows terminal 2020-08-30 21:54:36 -07:00
Thomas Stromberg f3cce500b0 Improve error disambiguation, especially for non-running drivers 2020-08-30 20:49:16 -07:00
Thomas Stromberg 7f5a06b606 Unwrap unnecessary level of error annotation for improved messages 2020-08-30 20:48:55 -07:00
Thomas Stromberg cd91fb8470 Unwrap unnecessary level of error annotation for improved messages 2020-08-30 20:48:20 -07:00
Thomas Stromberg 2c5e8fdaee Add detailed JSON & status codes for all error paths 2020-08-30 17:25:11 -07:00
Thomas Stromberg 305d3580ba Merge branch 'master' into 1.19.0-rc.4-updated 2020-08-28 10:33:17 -07:00
Thomas Strömberg c25a2e645c
Merge pull request #9111 from priyawadhwa/fix-kubelet
Don't enable kubelet until after kubeadm generates config
2020-08-28 10:32:40 -07:00
Priya Wadhwa 52724f956b Run kubelet-start after kubeconfig as recommended in 1.19 changelog 2020-08-28 12:23:25 -04:00
Priya Wadhwa b9aa9c0f0f Don't enable kubelet until after kubeadm generates /var/lib/kubelet/config.yaml 2020-08-28 12:19:36 -04:00
Thomas Stromberg a63a1ddcda Update to v1.19.0 final release 2020-08-26 13:27:05 -07:00
Thomas Stromberg cffa2ad0c7 Merge branch 'master' into 1.19.0-rc.4-updated 2020-08-26 13:26:05 -07:00
Priya Wadhwa 8a2ebd505b also output final event when complete 2020-08-26 12:16:17 -04:00
Priya Wadhwa f99781ec1d print download progress every second; previously we were printing 6000x/sec which is unnecessary 2020-08-26 12:11:11 -04:00
AlexanderChen1989 6a2fd9678a fix multiple node calico-node not ready 2020-08-26 11:02:49 +08:00
Priya Wadhwa b053267a81 update kic version to incorporate /kubepods change 2020-08-25 15:59:04 -07:00
Medya Gh 2ead04aea0 bump kic base changes 2020-08-24 15:10:53 -07:00
Priya Wadhwa d634a85ff9 use daemon info so this works for docker and podman 2020-08-24 17:50:09 -04:00
Thomas Stromberg 2605872fad Merge branch 'master' into 1.19.0-rc.4-updated 2020-08-24 14:47:35 -07:00
Priya Wadhwa 535294e523 fixed merge conflict 2020-08-24 17:35:03 -04:00
Medya Ghazizadeh b28673f305
Merge pull request #8671 from vinu2003/bumpup-kubelib-version-18.5
upgrade: bump kube library version to latest 1.18.5
2020-08-24 11:03:35 -07:00
Priya Wadhwa a767b64b41 fix merge conflict 2020-08-21 21:40:32 -04:00
Thomas Stromberg f5c3a82600 Merge branch 'master' into 1.19.0-rc.4-updated 2020-08-21 16:22:42 -07:00
Medya Ghazizadeh 1ca96bf5bb
Merge pull request #9043 from medyagh/lock_debug
tune machine lock for docker driver
2020-08-21 16:14:25 -07:00
Medya Gh dd64445b1a spell 2020-08-21 15:35:28 -07:00
Medya Gh 0bd2dc3bf3 add coment 2020-08-21 15:34:08 -07:00
Medya Gh 26f3b9c5ea improve lock name 2020-08-21 15:33:20 -07:00
Medya Gh a913339e21 spell 2020-08-21 15:11:16 -07:00
Thomas Stromberg d5f9613be0 Merge branch 'master' into 1.19.0-rc.4-updated 2020-08-21 15:10:32 -07:00
Medya Gh 9ab2040be9 logs 2020-08-21 15:10:15 -07:00
Medya Gh ba04b8bef9 tune lock timeout 2020-08-21 15:09:21 -07:00
Medya Ghazizadeh 02c7d0480c
Merge pull request #9054 from medyagh/post_val_panic
avoid post validation panic
2020-08-21 15:00:51 -07:00
Medya Gh 0849b48b9c improve post validation 2020-08-21 14:29:19 -07:00
Thomas Stromberg 3b42f5607a Remove TestCreateSSHShell - it's been flaky for years 2020-08-21 13:59:24 -07:00
Thomas Stromberg d2667324f6 Update DefaultKubernetesVersion to v1.19.0-rc.4 2020-08-21 13:39:28 -07:00
Thomas Strömberg 135d7bd7e4
Merge pull request #9045 from tstromberg/1.19.0-rc.4-updated
Update NewestKubernetesVersion to v1.19.0-rc.4
2020-08-21 13:38:51 -07:00
Thomas Strömberg f492215009
Merge pull request #9046 from tstromberg/cni-true
Allow flannel CNI to work with kicbase by fixing IP conflict
2020-08-21 13:38:39 -07:00
Priya Wadhwa 88aece40d2 change name 2020-08-21 15:05:37 -04:00
Thomas Stromberg c254778f39 Update CoreDNS and etcd images for Kubernetes v1.19 2020-08-21 10:45:23 -07:00
Thomas Stromberg 0cfd9e7cf4 Merge branch 'master' into 1.19.0-rc.4-updated 2020-08-21 10:44:31 -07:00
Priya Wadhwa acd6589c5d Remove debugging 2020-08-21 09:56:03 -04:00
Priya Wadhwa 44b93f4776 Change MemoryCapacity to StorageCapacity to be more accurate 2020-08-21 09:49:48 -04:00
Thomas Stromberg c052d1ad18 Allow flannel CNI to work with kicbase by relocating conflicting file 2020-08-20 17:54:42 -07:00
Priya Wadhwa 4fcffca3db write events to file, but not in parallel 2020-08-20 20:48:18 -04:00
Thomas Strömberg e2e4ef168d
Merge pull request #8850 from priyawadhwa/proxy
set proxy-refresh-interval=70000 for etcd to improve CPU overhead
2020-08-20 14:05:11 -07:00
Thomas Stromberg 444dde078f Update NewestVersion to v1.19.0-rc.4 2020-08-20 13:38:45 -07:00
Priya Wadhwa 7eda3a7711 Create new exit code for InsufficientStorage 2020-08-20 15:27:06 -04:00
Medya Gh 0afe83e015 reduce machine lock time for docker driver 2020-08-20 11:45:12 -07:00
Medya Ghazizadeh b27dbc0dd4
Merge pull request #9037 from medyagh/swarm_
add swarm and storage driver to DaemonInfo
2020-08-20 09:55:55 -07:00
Li Zhijian 113e640c0d create a temp MinikubeHome for a few cluster tests
these tests will write something to the MinikubeHome. Previously, these
tests will use the environment value of MinikubeHome directly which might
dirty the previous MiniKubeHome

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-20 11:49:12 +08:00
Li Zhijian 95e7203900 add a temp MinikubeHome for TestStart
this test will write a config.json into MinikubeHome, create a temp dir for it

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-20 11:49:07 +08:00
Medya Gh 56691f839c add swarm and storage driver to DaemonInfo 2020-08-19 15:38:56 -07:00
Priya Wadhwa e1deec7019 improve output 2020-08-19 17:57:56 -04:00
Priya Wadhwa e1ed864708 Merge branch 'master' of https://github.com/kubernetes/minikube into var-status-code 2020-08-19 17:44:51 -04:00
Priya Wadhwa a32896192d add todo 2020-08-19 16:31:23 -04:00
Priya Wadhwa 4e638a1a0d include tip about pruning via minikube ssh 2020-08-19 15:28:06 -04:00
Priya Wadhwa 704a2a7a83 Merge branch 'master' of https://github.com/kubernetes/minikube into var-warning 2020-08-19 15:17:44 -04:00
Priya Wadhwa 4d1c1c0dc3 Add integration test for insufficient storage
Make sure that if /var has full storage, the output of `minikube status` is correct regardless of whether events.json is present or not
2020-08-19 14:16:00 -04:00
Priya Wadhwa 3dba974535 Make sure 'minikube status' displays InsufficientStorage for cluster and nodes
if there is insufficient storage. Output now looks like:

```
{
  "Name": "minikube",
  "StatusCode": 507,
  "StatusName": "InsufficientStorage",
  "StatusDetail": "/var is almost out of disk space",
  "Step": "Starting Node",
  "StepDetail": "Updating the running docker \"minikube\" container ...",
  "BinaryVersion": "v1.12.3",
  "Components": {
    "kubeconfig": {
      "Name": "kubeconfig",
      "StatusCode": 500,
      "StatusName": ""
    }
  },
  "Nodes": [
    {
      "Name": "minikube",
      "StatusCode": 507,
      "StatusName": "InsufficientStorage",
      "Components": {
        "apiserver": {
          "Name": "apiserver",
          "StatusCode": 405,
          "StatusName": "Stopped"
        },
        "kubelet": {
          "Name": "kubelet",
          "StatusCode": 405,
          "StatusName": "Stopped"
        }
      }
    }
  ]
}
```
2020-08-19 13:25:48 -04:00
Thomas Strömberg dd11ed8da0
Merge pull request #8989 from superbrothers/fix-nil-pointer-dereference
minikube update-context: Fix nil pointer dereference
2020-08-19 10:06:14 -07:00
Priya Wadhwa 064f021cf1 improve regex so this only works for docker 2020-08-19 10:29:21 -04:00
Priya Wadhwa 5033d24aae Include review comments 2020-08-19 10:25:58 -04:00
Li Zhijian 50459e0566 add testing cleanup hook for createTestProfile
T.cleanup() is introduced since go-1.14

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-19 18:10:07 +08:00
Li Zhijian 640e9b64f8 cleanup tempdir properly for localpath_test
'path' could be changed during the test

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-19 16:56:14 +08:00
Priya Wadhwa edc3c95081 Add a problem with advice to prune if no space on device error is seen 2020-08-18 19:30:57 -04:00
Priya Wadhwa 0f4d0b6584 Include post start validations that warn the users if /var is full 2020-08-18 19:05:08 -04:00
Medya Gh e0d0ae1e19 correct comit sha 2020-08-17 16:56:25 -07:00
Medya Gh 20dd3e8ade update kicbase to snapshot 2020-08-17 14:28:02 -07:00
Kazuki Suda 79d5641c53
Revert support for adding context if no clusters in the kubeconfig 2020-08-16 09:36:09 +09:00
Kazuki Suda c41a5f19b7
minikube upate-cotext: Fix nil pointer dereference 2020-08-13 12:34:00 +09:00
Kazuki Suda a3fe0f5c49
Fix "Using reference to loop iterator variable" in t.Parallel() 2020-08-13 11:33:55 +09:00
Priya Wadhwa 52953bac93 Merge branch 'master' of github.com:kubernetes/minikube into kic-add-static-ip 2020-08-12 14:03:43 -07:00
Priya Wadhwa a949f9ca7b improvement 2020-08-12 12:58:21 -07:00
Priya Wadhwa bdb59c2598 lint 2020-08-12 12:56:07 -07:00
Priya Wadhwa dfa05d714e include gateway when creating custom network 2020-08-12 12:54:06 -07:00
Priya Wadhwa af94e0a0c5 add logging 2020-08-12 10:57:48 -07:00
Priya Wadhwa 2400d1b850 remove network correctly 2020-08-12 10:08:46 -07:00
Priya Wadhwa 69d21df7c5 make sure we use custom network if it exists 2020-08-12 12:45:49 -04:00
Priya Wadhwa 3b5f973459 make sure we delete networks correctly 2020-08-12 12:36:57 -04:00
Priya Wadhwa 28cfb5899c Merge branch 'master' of https://github.com/kubernetes/minikube into proxy 2020-08-12 10:43:53 -04:00
staticdev 4c5109b435 Fix go lint 2020-08-12 08:48:22 -03:00
staticdev 969bc9fd2c Add timing enable ingress 2020-08-12 08:09:38 -03:00
Sharif Elgamal 200400e52c Merge branch 'master' of github.com:kubernetes/minikube into add-kubectl 2020-08-11 15:58:26 -07:00
Medya Ghazizadeh f6ebaa8871
Merge pull request #8820 from Dean-Coakley/fix-minikube-ip-errhandle
Fix handling of parseIP error
2020-08-11 15:52:22 -07:00
Medya Ghazizadeh 01454778ac
Merge pull request #8975 from medyagh/hypervdebug
log hyperv errs
2020-08-11 15:50:23 -07:00
Medya Ghazizadeh 51bbba9bdc
Merge pull request #8973 from medyagh/daemon_info_unittest
add unit test for daemon info
2020-08-11 15:50:02 -07:00
Medya Gh f20d3bddf0 add boilerplate 2020-08-11 15:13:16 -07:00
Medya Gh 25dc0cd0f7 lint 2020-08-11 15:03:10 -07:00
Medya Gh f8d932e697 use mock funcs 2020-08-11 14:55:30 -07:00
Medya Gh 0fe3a96ea4 log hyperv errs 2020-08-11 13:48:11 -07:00
Thomas Strömberg 1854dd818c
Merge pull request #8972 from tstromberg/record-output
Log output for post-mortem analysis
2020-08-11 13:41:14 -07:00
Medya Gh 4c0334d91f add one more case 2020-08-11 13:10:17 -07:00
Medya Gh a9eec3ca7b add unit test for daemon info 2020-08-11 13:06:50 -07:00
Thomas Stromberg 606f8511ce Log output for post-mortem analysis 2020-08-11 12:41:39 -07:00
Medya Gh 7463eda122 remvoe comment 2020-08-11 10:40:40 -07:00
Medya Gh 9409158d09 lint 2020-08-11 10:40:40 -07:00
Medya Gh b0afc85327 dont fail on memory check if cpu and disk checks fail 2020-08-11 10:40:40 -07:00
Medya Gh 1d94fa911a ensure nil error is returned 2020-08-11 10:40:40 -07:00
Medya Gh 51011688b2 wrap errs 2020-08-11 10:40:40 -07:00
Medya Gh 84d198d8b5 refresh cache if there was error 2020-08-11 10:40:40 -07:00
Medya Gh 5cb47d75af return list of errors for cached host info 2020-08-11 10:40:40 -07:00
Medya Gh bbc58fa194 refresh daemon info cache if there is error 2020-08-11 10:40:40 -07:00
Medya Ghazizadeh 8b6a0eb4fb
Merge pull request #8948 from kadern0/issue-8897
Added startHostTimeout flag
2020-08-11 10:36:21 -07:00
Pablo Caderno 9354d2c0e5 Removed extra flag add.
Set default value if not  specified by the user.

Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-11 19:05:12 +10:00
Dean Coakley c3de6d6bb1 Fix handling of parseIP error 2020-08-11 00:59:45 +01:00
Priya Wadhwa fb1bc3afbb fix network name 2020-08-10 17:33:32 -04:00
Priya Wadhwa 21789d8c4e compile 2020-08-10 17:18:42 -04:00
Priya Wadhwa dfcfd6f2f0 cleanup 2020-08-10 17:15:26 -04:00
Priya Wadhwa 9dcb0c5478 fix merge conflict 2020-08-10 17:12:56 -04:00
Priya Wadhwa 5799b47ddb Implement some checks and reorganize code 2020-08-10 17:04:41 -04:00
Medya Ghazizadeh a13e5e5512
Merge pull request #8870 from Dean-Coakley/add-ingress-noneDriver-warn
Add warning for ingress addon enabled with driver of none
2020-08-10 13:17:54 -07:00
Medya Ghazizadeh 63b2cc15bd
Merge pull request #8533 from n0npax/mustloat-partial-test
add unit test for mustload pkg
2020-08-10 12:29:42 -07:00
Medya Ghazizadeh 9373842ea1
Merge pull request #8885 from lingsamuel/ignore-localhost-proxy-with-scheme
Ignore localhost proxy started with scheme.
2020-08-10 12:13:15 -07:00
Priya Wadhwa 4c0360a9e6 Merge branch 'master' of https://github.com/kubernetes/minikube into proxy 2020-08-10 11:27:17 -04:00
Pablo Caderno 37a1d3bc0b Added startHostTimeout flag
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-10 16:23:13 +10:00
Sharif Elgamal 02930c0d51 fix tip output and do not output ending tip disabling 2020-08-06 13:45:46 -07:00
Sharif Elgamal 16ba55d05f better error message 2020-08-06 12:36:54 -07:00
Sharif Elgamal 90dadd0ce6 better error messages for not finding creds 2020-08-06 11:47:09 -07:00
Anders F Björklund 9802423d9a Add ImagesPreloaded to cruntime Manager interface
To make sure that it is actually called for all container runtimes,
including CRIO which was missing (only had Docker and Containerd)
2020-08-05 22:20:41 +02:00
Medya Gh 98c2157242 address review comments 2020-08-04 13:26:33 -07:00
Medya Gh e87400db53 addres review comments 2020-08-04 13:26:33 -07:00
Medya Gh b71a7dceca use cached hostinfo instead 2020-08-04 13:26:33 -07:00
Medya Ghazizadeh 8698f9efbd
Merge pull request #8908 from linkvt/add-common-names-to-certificate-SANs
Add "minikube" and machineName to docker certificate SANs
2020-08-04 09:50:38 -07:00
Vincent Link e95f279449 Add "minikube" and machineName to docker certificate SANs
See #6367
2020-08-03 20:42:12 +02:00
Priya Wadhwa 52bee6dced Bump up preload version for new storage provisioner image 2020-08-03 13:50:22 -04:00
Priya Wadhwa 0538dddd9d Upgrade storage provisioner to v2 2020-08-03 13:48:09 -04:00
Sharif Elgamal 7ef3a8c11a respect native-ssh flag 2020-08-03 09:48:30 -07:00
Sharif Elgamal 5ba7281a0a
Merge pull request #8899 from sharifelgamal/new-kicbase
Upgrade kicbase to v0.0.11
2020-07-31 16:09:45 -07:00
Sharif Elgamal bf85c88a56
Merge pull request #8896 from tstromberg/crio-fixes
Add stopping as a possible state in deleting, change errorf to warningf
2020-07-31 15:02:39 -07:00
Sharif Elgamal d83b4a9654 Upgrade kicbase to v0.0.11 2020-07-31 10:46:11 -07:00
Sharif Elgamal a231c8a151
Merge pull request #8887 from Ajitesh13/master
virtualbox: improve solution message -> ensure it is in the path #8453
2020-07-31 09:10:17 -07:00
Medya Ghazizadeh 31e6c4cc25
Merge pull request #8880 from niedhui/base-image-mirror
make base-image respect --image-repository
2020-07-30 21:32:58 -07:00
Thomas Stromberg 4384e67eb1 Add stopping as a possible state in deleting, change errorf to warningf 2020-07-30 16:11:26 -07:00