Commit Graph

4489 Commits (54f94000065d186b05fe6363d090fb1923b9b3e5)

Author SHA1 Message Date
Medya Ghazizadeh f6ebaa8871
Merge pull request #8820 from Dean-Coakley/fix-minikube-ip-errhandle
Fix handling of parseIP error
2020-08-11 15:52:22 -07:00
Medya Ghazizadeh 01454778ac
Merge pull request #8975 from medyagh/hypervdebug
log hyperv errs
2020-08-11 15:50:23 -07:00
Medya Ghazizadeh 51bbba9bdc
Merge pull request #8973 from medyagh/daemon_info_unittest
add unit test for daemon info
2020-08-11 15:50:02 -07:00
Medya Gh f20d3bddf0 add boilerplate 2020-08-11 15:13:16 -07:00
Medya Gh 25dc0cd0f7 lint 2020-08-11 15:03:10 -07:00
Medya Gh f8d932e697 use mock funcs 2020-08-11 14:55:30 -07:00
Medya Gh 0fe3a96ea4 log hyperv errs 2020-08-11 13:48:11 -07:00
Thomas Strömberg 1854dd818c
Merge pull request #8972 from tstromberg/record-output
Log output for post-mortem analysis
2020-08-11 13:41:14 -07:00
Medya Gh 4c0334d91f add one more case 2020-08-11 13:10:17 -07:00
Medya Gh a9eec3ca7b add unit test for daemon info 2020-08-11 13:06:50 -07:00
Thomas Stromberg 606f8511ce Log output for post-mortem analysis 2020-08-11 12:41:39 -07:00
Medya Gh 7463eda122 remvoe comment 2020-08-11 10:40:40 -07:00
Medya Gh 9409158d09 lint 2020-08-11 10:40:40 -07:00
Medya Gh b0afc85327 dont fail on memory check if cpu and disk checks fail 2020-08-11 10:40:40 -07:00
Medya Gh 1d94fa911a ensure nil error is returned 2020-08-11 10:40:40 -07:00
Medya Gh 51011688b2 wrap errs 2020-08-11 10:40:40 -07:00
Medya Gh 84d198d8b5 refresh cache if there was error 2020-08-11 10:40:40 -07:00
Medya Gh 5cb47d75af return list of errors for cached host info 2020-08-11 10:40:40 -07:00
Medya Gh bbc58fa194 refresh daemon info cache if there is error 2020-08-11 10:40:40 -07:00
Medya Ghazizadeh 8b6a0eb4fb
Merge pull request #8948 from kadern0/issue-8897
Added startHostTimeout flag
2020-08-11 10:36:21 -07:00
Pablo Caderno 9354d2c0e5 Removed extra flag add.
Set default value if not  specified by the user.

Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-11 19:05:12 +10:00
Dean Coakley c3de6d6bb1 Fix handling of parseIP error 2020-08-11 00:59:45 +01:00
Priya Wadhwa fb1bc3afbb fix network name 2020-08-10 17:33:32 -04:00
Priya Wadhwa 21789d8c4e compile 2020-08-10 17:18:42 -04:00
Priya Wadhwa dfcfd6f2f0 cleanup 2020-08-10 17:15:26 -04:00
Priya Wadhwa 9dcb0c5478 fix merge conflict 2020-08-10 17:12:56 -04:00
Priya Wadhwa 5799b47ddb Implement some checks and reorganize code 2020-08-10 17:04:41 -04:00
Medya Ghazizadeh a13e5e5512
Merge pull request #8870 from Dean-Coakley/add-ingress-noneDriver-warn
Add warning for ingress addon enabled with driver of none
2020-08-10 13:17:54 -07:00
Medya Ghazizadeh 63b2cc15bd
Merge pull request #8533 from n0npax/mustloat-partial-test
add unit test for mustload pkg
2020-08-10 12:29:42 -07:00
Medya Ghazizadeh 9373842ea1
Merge pull request #8885 from lingsamuel/ignore-localhost-proxy-with-scheme
Ignore localhost proxy started with scheme.
2020-08-10 12:13:15 -07:00
Priya Wadhwa 4c0360a9e6 Merge branch 'master' of https://github.com/kubernetes/minikube into proxy 2020-08-10 11:27:17 -04:00
Pablo Caderno 37a1d3bc0b Added startHostTimeout flag
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-10 16:23:13 +10:00
Sharif Elgamal 02930c0d51 fix tip output and do not output ending tip disabling 2020-08-06 13:45:46 -07:00
Sharif Elgamal 16ba55d05f better error message 2020-08-06 12:36:54 -07:00
Sharif Elgamal 90dadd0ce6 better error messages for not finding creds 2020-08-06 11:47:09 -07:00
Anders F Björklund 9802423d9a Add ImagesPreloaded to cruntime Manager interface
To make sure that it is actually called for all container runtimes,
including CRIO which was missing (only had Docker and Containerd)
2020-08-05 22:20:41 +02:00
Medya Gh 98c2157242 address review comments 2020-08-04 13:26:33 -07:00
Medya Gh e87400db53 addres review comments 2020-08-04 13:26:33 -07:00
Medya Gh b71a7dceca use cached hostinfo instead 2020-08-04 13:26:33 -07:00
Medya Ghazizadeh 8698f9efbd
Merge pull request #8908 from linkvt/add-common-names-to-certificate-SANs
Add "minikube" and machineName to docker certificate SANs
2020-08-04 09:50:38 -07:00
Vincent Link e95f279449 Add "minikube" and machineName to docker certificate SANs
See #6367
2020-08-03 20:42:12 +02:00
Priya Wadhwa 52bee6dced Bump up preload version for new storage provisioner image 2020-08-03 13:50:22 -04:00
Priya Wadhwa 0538dddd9d Upgrade storage provisioner to v2 2020-08-03 13:48:09 -04:00
Sharif Elgamal 7ef3a8c11a respect native-ssh flag 2020-08-03 09:48:30 -07:00
Sharif Elgamal 5ba7281a0a
Merge pull request #8899 from sharifelgamal/new-kicbase
Upgrade kicbase to v0.0.11
2020-07-31 16:09:45 -07:00
Sharif Elgamal bf85c88a56
Merge pull request #8896 from tstromberg/crio-fixes
Add stopping as a possible state in deleting, change errorf to warningf
2020-07-31 15:02:39 -07:00
Sharif Elgamal d83b4a9654 Upgrade kicbase to v0.0.11 2020-07-31 10:46:11 -07:00
Sharif Elgamal a231c8a151
Merge pull request #8887 from Ajitesh13/master
virtualbox: improve solution message -> ensure it is in the path #8453
2020-07-31 09:10:17 -07:00
Medya Ghazizadeh 31e6c4cc25
Merge pull request #8880 from niedhui/base-image-mirror
make base-image respect --image-repository
2020-07-30 21:32:58 -07:00
Thomas Stromberg 4384e67eb1 Add stopping as a possible state in deleting, change errorf to warningf 2020-07-30 16:11:26 -07:00
root d1e8d47f80 fix typos 2020-07-30 12:47:08 +00:00
Ajitesh13 c4957e4383 virtualbox: improve solution message -> ensure it is in the path #8453 2020-07-30 16:53:18 +05:30
niedhui 22edb6f063 make baseImage respect imageRepo
Signed-off-by: niedhui <niedhui@gmail.com>
2020-07-30 16:59:56 +08:00
Ling Samuel bb57ae0c15
Ignore localhost proxy started with scheme. Fix start_test.
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2020-07-30 16:17:04 +08:00
Thomas Stromberg c6e6013d40 Update unit tests 2020-07-29 14:08:48 -07:00
Thomas Stromberg 59d0d7335a Add HTTP-like status codes, remove unused fields 2020-07-29 13:57:06 -07:00
Dean Coakley 9c23485dfb Remove list of alternative drivers 2020-07-29 09:40:43 +01:00
Dean Coakley 4b2974472d Improve error message text 2020-07-28 22:40:55 +01:00
Dean Coakley b27440d4ae Add warning for ingress addon with driver of none 2020-07-28 22:40:15 +01:00
Thomas Stromberg aa3d2a2a8a Improve handling of pause/unpause/stop/delete steps 2020-07-28 13:26:09 -07:00
Thomas Stromberg ac1f901160 Allow non-start steps 2020-07-28 13:07:37 -07:00
Sharif Elgamal 2cc7445f1c guard against joining the cluster twice 2020-07-28 12:16:33 -07:00
Thomas Stromberg 448ec75c8c Add support for storing/retrieving transient status 2020-07-27 21:34:52 -07:00
Priya Wadhwa 1c1ac4273c set proxy-refresh-interval=70000 for etcd to improve CPU overhead 2020-07-27 14:35:59 -04:00
Priya Wadhwa 9680237277 WIP 2020-07-27 14:24:40 -04:00
Sharif Elgamal d546ea1b5c
Merge pull request #8817 from sharifelgamal/restart-kubelet
restart kubelet if config changes
2020-07-24 15:48:53 -07:00
Medya Gh 47ed4bc23c update lint version 2020-07-24 14:45:15 -07:00
Medya Ghazizadeh 1395c8017c
Merge pull request #8784 from Dean-Coakley/disable-podman2
Warn user for podman2 version
2020-07-24 14:40:18 -07:00
Medya Ghazizadeh 8f404164d0
Merge pull request #8745 from littleroad/error_detect
Add error handling for os.RemoveAll
2020-07-24 14:38:10 -07:00
Dean Coakley dc566bec0b Remove warning prefix 2020-07-24 21:49:13 +01:00
Dean Coakley 57649f8ee8 Quote version numbers 2020-07-24 21:42:20 +01:00
Dean Coakley fa04c83b83 Use UI for logging 2020-07-24 21:25:19 +01:00
Thomas Stromberg 9c0618f102 Merge to master 2020-07-24 11:22:59 -07:00
Medya Ghazizadeh 76b98ace96
Merge pull request #8827 from tstromberg/kic-longer
Increase maximum container startup wait from 13 seconds to 25 seconds
2020-07-24 11:10:39 -07:00
Sharif Elgamal b9c218261d adding debugging 2020-07-24 10:45:14 -07:00
Thomas Stromberg f8f689b5cc Merge branch 'master' into kic-show-errs 2020-07-24 09:06:56 -07:00
Thomas Stromberg bd713ffd45 Increase maximum container startup wait from 13 seconds to 25 seconds 2020-07-24 09:02:32 -07:00
Thomas Stromberg dee9c0b427 Show 'docker logs' excerpt if container dies 2020-07-24 08:58:09 -07:00
Thomas Stromberg e172a7ee1c Avoid panic: runtime error: invalid memory address or nil pointer dereference 2020-07-24 08:48:20 -07:00
Dean Coakley db4bf9ec2a Log warning instead of exit with error 2020-07-24 11:30:23 +01:00
Sharif Elgamal be160406ec remove space 2020-07-23 14:45:42 -07:00
Sharif Elgamal 82c4d49eb8 restart kubelet if config changes 2020-07-23 14:43:23 -07:00
Medya Ghazizadeh 993504e054
Merge pull request #8800 from priyawadhwa/improve-json
Improve json integration test
2020-07-23 10:23:36 -07:00
Medya Ghazizadeh f230ca0c55
Merge pull request #8804 from medyagh/hot_upgrade_fix
Stop kube-system containers before applying configuration updates
2020-07-23 10:03:54 -07:00
Medya Ghazizadeh b7b26ea2d5
Merge pull request #8737 from dddddai/master
Use RWMutex instead of Mutex
2020-07-23 09:57:25 -07:00
vinu2003 907cd34b78 fixed unit test based on update to v1.18.0 2020-07-24 02:22:26 +10:00
Medya Gh 44b6703e68 update comment 2020-07-23 09:17:30 -07:00
Medya Gh d5cc6afc9b update comment 2020-07-23 09:17:06 -07:00
Asare Worae a31e359b01 fixed unwanted spinning up of mount deamon when using KIC drivers, and added same host mounted volumes logic for the Podman driver 2020-07-23 11:47:16 +02:00
Priya Wadhwa 2cba801d50 fix order 2020-07-22 20:47:41 -04:00
Priya Wadhwa a03f25e976 add step to register 2020-07-22 18:50:42 -04:00
Priya Wadhwa 22226ffc8f fixed merge conflict 2020-07-22 18:46:57 -04:00
priyawadhwa 25566c90f0
Merge pull request #8796 from priyawadhwa/error
Add support for Error type to JSON output
2020-07-22 18:43:46 -04:00
Priya Wadhwa df0bc948bc Add logging to none driver 2020-07-22 18:42:38 -04:00
Medya Gh 9fa1dfdaec
stop conainers before hot upgrade 2020-07-22 15:14:57 -07:00
Priya Wadhwa 3f18ecb052 add log 2020-07-22 15:01:22 -04:00
Priya Wadhwa efe1ce278a Add docs 2020-07-22 14:20:41 -04:00
Medya Ghazizadeh f2100e365d
Merge pull request #8697 from medyagh/improv_sa_apply
improve applying default service account
2020-07-22 11:00:07 -07:00
Sharif Elgamal ad083ba7ac
Merge pull request #8778 from sharifelgamal/hyerpv
allow for prefixed interface names for hyperv
2020-07-21 16:07:42 -07:00
Sharif Elgamal 58d4b0c32f add less restrictive interface name matching 2020-07-21 15:32:38 -07:00
Priya Wadhwa 6a33c03df2 fix unit test 2020-07-21 18:23:22 -04:00
Priya Wadhwa 8bc875d520 Rebased on master; fixed json_output integration test 2020-07-21 18:20:02 -04:00
priyawadhwa 6df5d19d70
Merge pull request #8793 from priyawadhwa/warning
Implement Warning type for JSON output
2020-07-21 18:17:54 -04:00
Medya Ghazizadeh 85f1c4f2dd
Merge pull request #8792 from concaf/concaf/fix/fix-already-started
(Addons) Create a new command in every retry
2020-07-21 14:43:14 -07:00
Sharif Elgamal 1b6eee675b
Automated GCP Credentials Addon Prototype (#8682)
* metadata addon works

* Add code for metadata server image and makefile rules

* remove log message

* update to work with v1.13.11

* update readme

* fix metadata addon stuff for newer codebase

* buncha changes

* just so many changes

* ch-ch-ch-ch-changes

* addon works

* update readme

* boilerplate

* revert unrelated change

* move server code to another repo

* switch addon name to gcp-auth

* metadata -> gcp-auth

* missed one

* automate finding of credentials

* remove unnecessary comment

* address comments

* Update README.md

* Update README.md

* use mustload everywhere

* swap selector condition

* upgrade kube-webhook-certgen to 1.3

* move paths to constants

* add notice to user on addon enable

* adding addon documentation

* move addons documentation inside handbook

* remove old addons docs location

Co-authored-by: Priya Wadhwa <priyawadhwa@google.com>
2020-07-21 14:25:58 -07:00
Medya Ghazizadeh 24fa6280dc
Merge pull request #8588 from afbjorklund/preload-crio-2
Use preloaded tarball for cri-o container runtime
2020-07-21 13:59:03 -07:00
Priya Wadhwa 6ca72229bb add json unit tests 2020-07-21 15:56:26 -04:00
Priya Wadhwa b4b9013057 Add unit test for problem.DisplayJSON() 2020-07-21 15:51:47 -04:00
Priya Wadhwa 482b9befd6 implement errors in JSON 2020-07-21 15:43:19 -04:00
Medya Ghazizadeh f04a6a061f
Merge pull request #8586 from afbjorklund/container-id
Support more error messages for container inspect
2020-07-21 12:22:31 -07:00
Priya Wadhwa c60e754624 Implement warning type for JSON output 2020-07-21 14:40:31 -04:00
Shubham f42f79e56d (Addons) Create a new command in every retry
Whenever a `kubectl apply` fails while enabling an addon, it is
retried with exponential backoff. The command (type `*exec.Cmd`)
that this retry function runs in created outside the function -
which means that it is reused on every retry. This is a problem
because `exec.Cmd` (https://godoc.org/github.com/pkg/exec#Cmd)
states that "... Cmd cannot be reused after calling its Run or
Start methods."

This retry is a common case due to, say, a CRD and its resource
being present in the same YAML file of the addon which causes
a race condition where the resource is created before its CRD is
created in the cluster - this race is fixed by subsequent retries.
I've noticed this in the dashboard and the ambassador addon.

Due to the above mentioned bug, minikube throws errors like
`exec: already started` in every retry and the retry is never
successful, manifests are never deployed and addon creation errors
out.

Related to #8138 #8119 #8372
2020-07-21 21:20:24 +05:30
Dean Coakley 328dbc1f97 Improve fix message 2020-07-21 12:29:53 +01:00
Dean Coakley 66f03b89c3 Update formatting Podman->Podman v2 2020-07-21 12:24:03 +01:00
Anders F Björklund 59bf848e54 Use preloaded tarball for cri-o container runtime
Pretty much the same as containerd, minus Restart
2020-07-21 09:05:12 +02:00
Ambor e00cf6c1e1 fix error usage for the WaitGroup in the pkg addons 2020-07-21 11:57:06 +08:00
dddddai 196789f965 Use RWMutex instead of Mutex 2020-07-21 10:39:45 +08:00
Dean Coakley 0d78fe56af lint 2020-07-21 03:00:13 +01:00
Dean Coakley 622e33b7ab Fix typo 2020-07-21 02:55:37 +01:00
Dean Coakley 62683c9b42 Exit with error on podman2 drivers 2020-07-21 02:39:46 +01:00
priyawadhwa aaebd88251
Merge pull request #8610 from johscheuer/update-storage-provisioner
Update external-provisioner for storage provisioner for Kubernetes 1.18
2020-07-20 19:11:38 -04:00
Medya Ghazizadeh 79088e6ed2
Merge pull request #8581 from afbjorklund/preload-crio
Generate cri-o container runtime preload tarball
2020-07-20 15:55:31 -07:00
Medya Ghazizadeh 2086bcb2b1
Merge pull request #8718 from medyagh/check_docker_deskop
docker/podman: warn if allocated memory is below limit
2020-07-20 15:26:41 -07:00
Sharif Elgamal f92015df9b allow for prefix interace names for hyperv 2020-07-20 13:07:13 -07:00
Medya Gh 13357d91a4 avoid nil pointer 2020-07-20 12:56:03 -07:00
Anders F Björklund 22585c3a17 Use the preload container run for podman as well
Now that there is no more race between the containers for
preparing the volume, we can use it for podman as well...

Previously we risked ending up with not copying the contents
of /var from the container image, which made it not work.
2020-07-20 21:54:28 +02:00
Anders F Björklund 2a9e9b2425 Make sure to prepare the kic volume after creation
The volume is created as empty, so make sure that we run a
container to do the initial copy of /var from the image.

This is to avoid race conditions later on, where the preload
starts to use the created volume for packing up the tarball.
2020-07-20 21:50:13 +02:00
Jose Donizetti c2175abcba Add static ip to kic/docker 2020-07-18 18:19:53 -03:00
Jose Donizetti cd17c872d3 Fix documentation typo 2020-07-18 15:02:09 -03:00
Thomas Stromberg 9546b1ebc6 Merge branch 'master' into kic-image-upgrade 2020-07-17 09:56:42 -07:00
Thomas Strömberg b7e7ef3a65
Merge pull request #8751 from tstromberg/docker-err-suggestion
Add 'Start Docker' guidance for /pipe/docker_engine errors
2020-07-17 09:55:04 -07:00
Thomas Stromberg f89094dcf8 Adjust comment 2020-07-17 09:46:53 -07:00
Thomas Stromberg 2b614ae856 Add 'Start Docker' guidance for /pipe/docker_engine errors 2020-07-17 09:45:16 -07:00
Thomas Stromberg 3b1dc975d0 legacy client certs: simplify logic 2020-07-17 07:23:48 -07:00
Lu Fengqi c219b60b05 Add error handling for os.RemoveAll
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
2020-07-17 15:44:04 +08:00
Thomas Stromberg b72eee4e36 Turn Errorf into Infof 2020-07-16 23:07:37 -07:00
Thomas Stromberg 94e866affc Merge to master 2020-07-16 19:53:43 -07:00
Thomas Stromberg 798196d0ad Remove stray log line 2020-07-16 19:37:28 -07:00
Thomas Stromberg be2c27efe0 Find and copy legacy certificate/key paths 2020-07-16 19:37:15 -07:00
Thomas Strömberg bb2fb3ad97
Merge pull request #8573 from tstromberg/cilium
Add support for Cilium CNI (--cni=cilium)
2020-07-16 19:34:44 -07:00
Thomas Stromberg ccd3682116 Refactor upgrade tests 2020-07-16 17:34:46 -07:00
Marcin Niemira 8f47e32d7c
use pathlib 2020-07-16 18:46:21 +10:00
Thomas Stromberg fcc15fa353 Merge to master 2020-07-15 21:04:33 -07:00
Thomas Stromberg 14b4a54ba2 Merge to master 2020-07-15 21:03:49 -07:00
Medya Gh 13d37ff7aa adress review comments 2020-07-15 14:34:01 -07:00
Medya Gh b0e58a3688 rename to FullName 2020-07-15 14:27:06 -07:00
Medya Gh 3aac9a3fff remove duplicate return statement 2020-07-15 14:24:42 -07:00
Medya Gh 8ecb483cb7 use cached error 2020-07-15 14:23:25 -07:00
Medya Gh 7bbb0b6250 spell 2020-07-15 14:09:35 -07:00
Medya Gh de6c10526b move cacheDaemoninfo to oci package 2020-07-15 14:07:50 -07:00
Sharif Elgamal af99a13e8f Merge branch 'master' of github.com:kubernetes/minikube into master 2020-07-15 11:32:48 -07:00
Sharif Elgamal 1467e8f7c4
Merge pull request #8576 from afbjorklund/image-client
cache: Only use docker client for docker runtime
2020-07-15 11:12:52 -07:00
Medya Gh dbfd16f21e add helper fucns for drivers 2020-07-14 15:02:54 -07:00
priyawadhwa c2e63844db
Merge pull request #8709 from priyawadhwa/json-output-download
Implement Download and DownloadProgress types for JSON output
2020-07-14 15:56:56 -04:00
Priya Wadhwa cb03f56b1b remove todo 2020-07-14 13:39:33 -04:00
priyawadhwa f15b0d6e35
Merge pull request #8468 from prasadkatti/mv_kubelet_params_to_cfg_file
Move kubelet params to config file
2020-07-14 09:56:26 -04:00
Sharif Elgamal 9f2f604b93 several fixes 2020-07-13 18:54:40 -07:00
Sharif Elgamal bd721de0cf Merge branch 'master' of github.com:kubernetes/minikube into master 2020-07-13 15:00:38 -07:00
Priya Wadhwa e4ce27abda Add unit tests for register package 2020-07-13 12:08:06 -04:00
Priya Wadhwa e771b72a82 fix lint 2020-07-13 10:05:06 -04:00
Priya Wadhwa 9784ce3051 Rebased on master 2020-07-13 09:57:42 -04:00
Priya Wadhwa d26cd72d36 Implement Info type so that integration tests pass 2020-07-10 19:18:25 -04:00
Priya Wadhwa 3a290606db Merge branch 'master' of https://github.com/kubernetes/minikube into json-output 2020-07-10 19:12:50 -04:00
Sharif Elgamal aa4f7b3b21 update control plane properly on multinode restart 2020-07-10 15:40:21 -07:00
Medya Gh 17f44f69e3 impove applyying default service account 2020-07-10 15:01:06 -07:00
priyawadhwa 442bc138ce
Merge pull request #8676 from priyawadhwa/info
Add Infof function to out package
2020-07-10 17:08:30 -04:00
Medya Ghazizadeh 45677496fa
Merge pull request #8585 from prasadkatti/extra_option_8130
Do not auto-set extra config that user wishes to override
2020-07-10 13:54:19 -07:00
Medya Ghazizadeh 3c9e96ea6b
Merge pull request #8684 from tstromberg/none-cni
none CNI: error if portmap plug-in is required but unavailable
2020-07-10 13:50:54 -07:00
Medya Gh 6d9922b430 address review comments 2020-07-10 13:19:22 -07:00
Medya Gh 4bce402a3b remove debug seconds 2020-07-10 13:18:25 -07:00
Medya Gh 11674e830f spell 2020-07-10 13:13:45 -07:00
Medya Gh c240fa97bc add timeout for node label too 2020-07-10 13:06:43 -07:00
Medya Gh f805be635a add timeout for node label too 2020-07-10 13:04:11 -07:00
Medya Gh f36da5f044 add timeout for node label too 2020-07-10 13:03:50 -07:00
Medya Gh 770f7aeeb4 adjust itmeout 2020-07-10 13:02:06 -07:00
Medya Gh 7088653d33 max 13 min for kubeadm 2020-07-10 13:01:08 -07:00
Medya Gh 6c702e1d29 add timeout for kubeadm init 2020-07-10 12:49:29 -07:00
Medya Ghazizadeh 87e540305c
Merge pull request #8648 from jlucktay/update/profile-name-validation
disallow setting profile names with underscore
2020-07-10 10:43:32 -07:00
Priya Wadhwa 3d105ef98f Download and DownloadProgress implemented 2020-07-10 12:31:08 -04:00
Priya Wadhwa d29a9dca67 Add Download and DownloadProgress types implementations 2020-07-10 11:58:23 -04:00
Prasad Katti 7bc10bb308 Set cgroupDriver and clientCAFile (for 1.16+) via kubelet config 2020-07-09 15:21:26 -07:00
Prasad Katti c483714cbc Move kubelet params to config file 2020-07-09 15:21:25 -07:00
Prasad Katti 332c3bd14f Add unit tests for Exists in extra_options.go 2020-07-09 15:17:00 -07:00
Thomas Strömberg ca9040b42b
Merge pull request #8664 from tstromberg/none-timeout
none: Fix 'minikube delete' issues when the apiserver is down
2020-07-09 14:16:14 -07:00
Sharif Elgamal d0d3973a13 restrict apparmor security opt to docker 2020-07-09 12:58:01 -07:00
Thomas Stromberg 0b3e2ae79b none CNI: error if portmap plug-in is required but unavailable. Make testable 2020-07-08 14:30:48 -07:00
Thomas Stromberg f8068d06f7 Merge branch 'master' into none-timeout 2020-07-08 13:48:34 -07:00
Priya Wadhwa b9cd0caa7c only out.T should be used to convert steps to JSON 2020-07-08 16:30:48 -04:00
Priya Wadhwa 6d95edda7b remove empty test 2020-07-08 16:28:51 -04:00
priyawadhwa b6f0829d7d
Merge pull request #8505 from zhijianli88/cleanup-tempfiles
Cleanup tempfiles
2020-07-08 14:53:51 -04:00
priyawadhwa 7367c72a3e
Merge pull request #8490 from zhijianli88/cleanup
A few cleanup
2020-07-08 14:52:28 -04:00
Priya Wadhwa 3e6ef0b37a fix unit test 2020-07-08 11:10:47 -04:00
Priya Wadhwa 290f48f98e Add Infof function to out package 2020-07-08 11:00:32 -04:00
Medya Ghazizadeh 1bcb375f93
Merge pull request #8147 from nezorflame/fix-error-msg
add new --extra-config option "scheduler"
2020-07-07 15:55:08 -07:00
Medya Ghazizadeh d8106f7d06
Merge pull request #8454 from colvin/addon-podsecuritypolicies
Include a podsecuritypolicies addon
2020-07-07 15:52:03 -07:00
Thomas Stromberg 7df4075297 Don't propagate stopped as an error, so that 'delete' works on stopped none clusters 2020-07-07 15:23:26 -07:00
Thomas Stromberg 53ce804cff retry.Local should respect the maxTime argument 2020-07-07 15:10:30 -07:00
Thomas Stromberg f82d5c6bb2 Reduce apiserver health timeout from 8s to 5s 2020-07-07 15:10:05 -07:00
Priya Wadhwa 1980e066dd fix lint and generate-docs 2020-07-07 15:57:07 -04:00
Priya Wadhwa 6367f71867 Make sure each step is unique 2020-07-07 15:39:47 -04:00
Priya Wadhwa bd94872a10 add additional steps 2020-07-07 14:25:27 -04:00
Priya Wadhwa ddecfd77e7 Include Ln as a Step 2020-07-07 13:24:53 -04:00
Priya Wadhwa 1ac2f6ddc0 cleanup 2020-07-07 13:19:33 -04:00
Priya Wadhwa dd60fa85cc Remove emojis from json output 2020-07-06 15:28:51 -04:00
Priya Wadhwa f68716e2da Set up logic for steps 2020-07-06 15:12:13 -04:00
Priya Wadhwa 10ba39cd3c Add --output=json flag and hook it up to out package 2020-07-06 12:32:34 -04:00
Priya Wadhwa 515616d1aa Add register of steps for 'minikube start' 2020-07-06 12:24:10 -04:00
Priya Wadhwa b72b1239ba Add function to print data in cloud events format 2020-07-06 12:23:59 -04:00
James Lucktaylor 85a641177e
Resequence test cases for better readability. 2020-07-06 13:07:14 +01:00
James Lucktaylor 2cf72f7ca8
Update profile name validation pattern. #8493
- prevents some incompatible characters from making their way into
profile names and causing DNS/hostnames issues
2020-07-05 12:16:31 +01:00
James Lucktaylor 2660b92109
Update test coverage around ProfileNameValid func.
- preparing to update the ProfileNameValid func
- adding some more test cases to check against new profile name limits
2020-07-05 12:06:14 +01:00
Medya Ghazizadeh a4b647f19b
Merge pull request #8629 from medyagh/sol_msg_docker_ssh_port
add solution message when container create is stuck
2020-07-01 13:41:21 -07:00
Medya Ghazizadeh 084df67df1
Merge pull request #8628 from sharifelgamal/del-on-failure
ensure deleting failed hosts if --delete-on-failure is specified
2020-07-01 13:40:43 -07:00
Medya Gh fd2912340a improve wording 2020-07-01 13:33:51 -07:00
Medya Gh 881ed1df1c add link 2020-07-01 13:28:52 -07:00
Medya Gh 4a321a6b1e add solution message when docker container create is stuck 2020-07-01 13:26:56 -07:00
Sharif Elgamal 84eea2f487 recreate hosts on failed provisioning if delete-on-failure is specified 2020-07-01 12:57:59 -07:00
Medya Gh 7564651d50 make docker driver highly prefered 2020-07-01 10:09:18 -07:00
Anders F Björklund 4968ff5e75 Run gofmt on pkg/minikube/shell/shell.go 2020-06-30 19:19:44 +02:00
Anders F Björklund b0b3a1ac8c Change indentation from gofmt to goimports 2020-06-30 19:12:11 +02:00
Johannes M. Scheuermann 73fccf04f8 Update external-provisioner for storage provisioner 2020-06-30 18:31:06 +02:00
Asare Worae 7bcae732bf resolved merge conflicts 2020-06-30 10:00:52 +02:00
Medya Ghazizadeh 9e35037ed9
Merge pull request #8593 from sunny-b/gracefully-fail-misspelled-runtime
Gracefully exit if container runtime is misspelled
2020-06-29 22:07:57 -07:00
Medya Ghazizadeh 2b5254cf91
Merge pull request #8598 from afbjorklund/modprobe-br_netfilter
Don't verify nf_conntrack for br_netfilter
2020-06-29 21:13:13 -07:00
Sunny Beatteay 28238150f5 ensure that 'crio' is used for k8s config 2020-06-29 19:52:30 -04:00
Medya Gh 3bc3ce95de refactor maybeExitWithAdvice 2020-06-29 14:38:37 -07:00
Anders F Björklund a9273beec7 Don't verify nf_conntrack for br_netfilter
We need to make sure that the br_netfilter kernel module
has been loaded, when using non-Docker container runtimes.

But the code was verifying the nf_conntrack kernel module
instead, so it could still cause the "not loaded" error.

[ERROR FileContent--proc-sys-net-bridge-bridge-nf-call-iptables]
2020-06-29 22:30:13 +02:00
Medya Gh 08df5e2de3 add solution message if kbueadm is not executble on linux 2020-06-29 12:50:32 -07:00
Sunny Beatteay 9bcc587def update crio to cri-o in docs and help text 2020-06-29 14:11:20 -04:00
Sunny Beatteay 5da2fdd922 enable graceful exit if container runtime is misspelled 2020-06-28 18:57:03 -04:00
Ilya Danilkin e1f443e121
bsutil: add 'etcd' to the KubeadmExtraConfigOpts 2020-06-28 23:29:25 +03:00
Ilya Danilkin 83bb1e32d2
reoder extra-config consts 2020-06-28 22:51:29 +03:00
Ilya Danilkin b470860a5a
fix condition check for extraOpts validation 2020-06-28 22:35:40 +03:00
Ilya Danilkin ccffa40cfe
bsutil: extra-opts validation 2020-06-28 22:35:40 +03:00
Ilya Danilkin d1ab5312d5
bsutil: list valid keys as slice instead of a map 2020-06-28 22:33:36 +03:00
Ilya Danilkin 79eaa8778a
bsutil: fix error msg for `--extra-config` parsing 2020-06-28 22:33:36 +03:00
Anders F Björklund eaeb5f6060 Use preloaded tarball for cri-o container runtime
Pretty much the same as containerd, minus Restart

(cherry picked from commit d9fb2e05420c8f3526d1b1079ee129842ea5522c)
2020-06-28 16:46:54 +02:00
Anders F Björklund f23bbea995 Support more error messages for container inspect
The messages are different between "inspect" and "container inspect",
and also changed a bit in format between Podman v1 and Podman v2.

Support all of them, for compatibility with different versions of
Docker and Podman. Was causing restarts and failures, with KIC.
2020-06-28 14:19:09 +02:00
Anders F Björklund 51b4d2eb24 Normalize name of the container runtime param 2020-06-28 13:45:22 +02:00
Anders F Björklund b87a837f2e Use the actual storage driver name for cri-o 2020-06-28 09:49:50 +02:00
Prasad Katti 42af47b909 Do not auto-set extra config that user wishes to override 2020-06-27 16:26:07 -07:00
Thomas Strömberg cdc456a19b
Merge pull request #8570 from tstromberg/cni-split2
CNI: Update CRIO netconfig with matching subnet
2020-06-26 17:13:49 -07:00
Medya Gh e829341b9d improve logging 2020-06-26 15:12:15 -07:00
Medya Gh 64553e281b revert debugging 2020-06-26 15:11:03 -07:00
Medya Gh 742dcd6b00 add addon status verification for 3 addons 2020-06-26 15:08:38 -07:00
Medya Gh 66421a6492 wait for ingress pod be running 2020-06-26 14:22:17 -07:00
Medya Gh 52f4e130b5 lint 2020-06-26 13:20:31 -07:00
Medya Gh 5fbf197b18 remove unrelated changes 2020-06-26 13:20:31 -07:00
Medya Gh 96781c61a2 remove unrelated changes 2020-06-26 13:20:30 -07:00
Medya Gh 058a732909 ingress addon validate deployment after enable 2020-06-26 13:20:30 -07:00