kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

add post mortem logs when container not running

pull/8501/head
Medya Gh 2020-06-17 13:27:17 -07:00
parent 736f5219e0
commit 543b0b5bfa
2 changed files with 40 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/drivers/kic/oci/errors.go
View File

@ -27,5 +27,5 @@ var ErrWindowsContainers = FailFastError(errors.New("docker container type is wi
// ErrCPUCountLimit is thrown when docker daemon doesn't have enough CPUs for the requested container
var ErrCPUCountLimit = FailFastError(errors.New("not enough CPUs is available for container"))
// ErrNotRunningAfterCreate is thrown when container is created without error but it exists and it's status is not running
var ErrNotRunningAfterCreate = errors.New("container status is not running after creation")
// ErrExitedAfterCreate is thrown when container is created without error but it exists and it's status is not running.
var ErrExitedAfterCreate = errors.New("container status is not running after creation")

39
pkg/drivers/kic/oci/oci.go
View File

@ -218,7 +218,8 @@ func CreateContainerNode(p CreateParams) error {
// retry up to up 13 seconds to make sure the created container status is running.
if err := retry.Expo(checkRunning, 13*time.Millisecond, time.Second*13); err != nil {
return errors.Wrapf(ErrNotRunningAfterCreate, "container name %q", p.Name)
printPostPortem(p.OCIBinary, p.Name)
return errors.Wrapf(ErrExitedAfterCreate, "container name %q", p.Name)
}
return nil
@ -571,3 +572,39 @@ func ShutDown(ociBin string, name string) error {
glog.Infof("Successfully shutdown container %s", name)
return nil
}
//containerLogs will print out the logs for a container
func containerLogs(ociBin string, name string) (*RunResult, error) {
if ociBin == Docker {
return runCmd(exec.Command(ociBin, "logs", "--timestamps", "--details", name))
}
// podman doesn't have --details
return runCmd(exec.Command(ociBin, "logs", "--timestamps", name))
}
//printPostPortem will print revelant docker/podman infos after a container fails
func printPostPortem(ociBin string, name string) {
rr, err := containerLogs(ociBin, name)
glog.Warningf("The created container %s failed to be running", name)
if err != nil {
glog.Warningf("failed to get container logs for the :%v", name, err)
} else {
glog.Warningf("%s logs for container %q: %s", name, name, rr.Output())
}
if ociBin == Docker {
di, err := dockerSystemInfo()
if err != nil {
glog.Warningf("couldn't get postmortem info, failed to to run docker info: %v", err)
} else {
glog.Warningf("postmortem docker info: %+v", di)
}
} else {
pi, err := podmanSystemInfo()
if err != nil {
glog.Warningf("couldn't get postmortem info, failed to to run podman info: %v", err)
} else {
glog.Warningf("postmortem podman info: %+v", pi)
}
}
}