The echoserver-arm:1.8 image is not an arm64 image:
% kubectl create deployment echoserver --image registry.k8s.io/echoserver-arm:1.8
deployment.apps/echoserver created
% kubectl logs deploy/echoserver
exec /usr/sbin/nginx: exec format error
% minikube ssh -- sudo nerdctl -n k8s.io image ls registry.k8s.io/echoserver-arm:1.8
REPOSITORY TAG IMAGE ID CREATED PLATFORM SIZE BLOB SIZE
registry.k8s.io/echoserver-arm 1.8 b33d4cdf6ed0 About a minute ago linux/amd64 90.1 MiB 43.2 MiB
Replace with kickbase/echo-server we used in other tests.
With this change ServerCmdConnect pass. The other test using the broken
arm image was not failing, maybe it was not checking the deployment
status properly.
Functional tests time reduced from 230 seconds to 200 seconds:
--- FAIL: TestFunctional (200.87s)
* add matrixfying
* ensure matrix jobs run after build binaries job
* use echo instead of helper
* setup-go needs go version
* make binaries executables
* chmod +x for test binaries
* install conntrack and socat for baremetal
* cancel preivous commits jobs in favor of latest job
* limit to 7 digits of sha for gopogh file
* echo gopogh url
* add run id to gopogh filename
* fix indent
* rename to build-test-binaries
* list skipped files too
* kubectl test better
* use short run id
* imrove error tet
* download kubectl to a tmp folder and remove leftover
* produce job summary
* fix names
* better results summary
* publish gopogh url in summary
* format better
* wordings
* add a new job unit test
* comment
* unit test script mkdir for coverage folder for widnows
* try to fix unit test for windows
* dont fix windows tests in this PR
* add lint job
* fix name
* separate boilerplate and add go modtidy
* install libvirt for lint
* name
* go mod tidy
* dont repeat name functional twice
* rename step
* fix comment
* fix run id
* delete debug
* adjust timeouts and treat 0 pass as failure icon
* rename job
* fix name
* Refactored table rendering codes to support updated tablewriter v1.0.7
This commit makes all necessary code changes to maintain compatibility
with the new tablewriter version. The update includes several required modifications across multiple files.
Files modified:
- cmd/minikube/cmd/config/images.go
- cmd/minikube/cmd/config/addons_list.go
- cmd/minikube/cmd/config/profile_list.go
- hack/benchmark/time-to-k8s/chart.go
- hack/benchmark/time-to-k8s/cpu.go
- pkg/minikube/audit/row.go
- pkg/minikube/machine/cache_images.go
- pkg/minikube/perf/result_manager.go
- pkg/minikube/service/service.go
Now #20878 can be merged.
Addresses #20879
* The tablewriter package v1.0.7 renamed SetHeaders to SetHeader
* updated go mod and table.SetColumnAlignment([]int{0, 0, 0, 0})
* Changed syntax and added vendor to gitignore
* simplified version of tablewriter
* removed vendor
* fix addon_list
* fix images tablewrtier
* bump tablewriter for profile list
* go mod tidy
* bump tablewriter for chart
* bump tablewriter for cpu chart
* bump tablewriter for row
* bump tablewriter cache images
* bump tablewriter
* bump tablewriter
* revert file
* bump tablewritter
* fix unit test
* fix lint issues
* fix the integration test pipe char
* convert all tables to new pipe instead of asci pipe
* convert all tables to new pipe instead of asci pipe
* go mod tidy
* go work sync
---------
Co-authored-by: Medya Ghazizadeh <medya@google.com>
* Fix KVM driver tests timeouts
Rewrite KVM driver waiting logic for domain start, getting ip address
and shutting domain down. Add more config/state outputs to aid future
debugging.
Bump go/libvirt to v1.11002.0 and set the minimum memory required for
running all tests to 3GB to avoid some really weird system behaviour.
* revert reduction of timelimit for TestCert tests run
* set memory and debug output in TestNoKubernetes tests
* extend kvm waitForStaticIP timeout
* add console log to debug output
* Updating ISO to v1.36.0-1748823857-20852
---------
Co-authored-by: minikube-bot <minikube-bot@google.com>
Nir Soffer
Medya Ghazizadeh
Victor Ubahakwe
Predrag Rogic
錦南路之花
锦南路之花
Medya Gh
Steven Powell
Martin Jirku
Товарищ программист
Marcell Martini
Om Saran
Kian-Meng Ang
Sean Wei