add success message if log file path provided

pull/18007/head
Steven Powell 2024-01-19 16:26:24 -08:00
parent be57d72bcf
commit fc27285b44
2 changed files with 5 additions and 3 deletions

View File

@ -31,7 +31,9 @@ import (
"k8s.io/minikube/pkg/minikube/logs"
"k8s.io/minikube/pkg/minikube/machine"
"k8s.io/minikube/pkg/minikube/mustload"
"k8s.io/minikube/pkg/minikube/out"
"k8s.io/minikube/pkg/minikube/reason"
"k8s.io/minikube/pkg/minikube/style"
)
const (
@ -120,6 +122,9 @@ var logsCmd = &cobra.Command{
return
}
logs.Output(cr, bs, *co.Config, co.CP.Runner, numberOfLines, logOutput)
if fileOutput != "" {
out.Styled(style.Success, "Logs file created ({{.logPath}}), remember to include it when reporting issues!", out.V{"logPath": fileOutput})
}
},
}

View File

@ -1247,9 +1247,6 @@ func validateLogsFileCmd(ctx context.Context, t *testing.T, profile string) {
if err != nil {
t.Errorf("%s failed: %v", rr.Command(), err)
}
if rr.Stdout.String() != "" {
t.Errorf("expected empty minikube logs output, but got: \n***%s***\n", rr.Output())
}
logs, err := os.ReadFile(logFileName)
if err != nil {