From fc27285b44a3684906f383c28cb886ae15cd7524 Mon Sep 17 00:00:00 2001
From: Steven Powell <spowellgrr@gmail.com>
Date: Fri, 19 Jan 2024 16:26:24 -0800
Subject: [PATCH] add success message if log file path provided

---
 cmd/minikube/cmd/logs.go            | 5 +++++
 test/integration/functional_test.go | 3 ---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/cmd/minikube/cmd/logs.go b/cmd/minikube/cmd/logs.go
index 66ada7549b..91122cf0e7 100644
--- a/cmd/minikube/cmd/logs.go
+++ b/cmd/minikube/cmd/logs.go
@@ -31,7 +31,9 @@ import (
 	"k8s.io/minikube/pkg/minikube/logs"
 	"k8s.io/minikube/pkg/minikube/machine"
 	"k8s.io/minikube/pkg/minikube/mustload"
+	"k8s.io/minikube/pkg/minikube/out"
 	"k8s.io/minikube/pkg/minikube/reason"
+	"k8s.io/minikube/pkg/minikube/style"
 )
 
 const (
@@ -120,6 +122,9 @@ var logsCmd = &cobra.Command{
 			return
 		}
 		logs.Output(cr, bs, *co.Config, co.CP.Runner, numberOfLines, logOutput)
+		if fileOutput != "" {
+			out.Styled(style.Success, "Logs file created ({{.logPath}}), remember to include it when reporting issues!", out.V{"logPath": fileOutput})
+		}
 	},
 }
 
diff --git a/test/integration/functional_test.go b/test/integration/functional_test.go
index c11a228c1a..b3e97c2892 100644
--- a/test/integration/functional_test.go
+++ b/test/integration/functional_test.go
@@ -1247,9 +1247,6 @@ func validateLogsFileCmd(ctx context.Context, t *testing.T, profile string) {
 	if err != nil {
 		t.Errorf("%s failed: %v", rr.Command(), err)
 	}
-	if rr.Stdout.String() != "" {
-		t.Errorf("expected empty minikube logs output, but got: \n***%s***\n", rr.Output())
-	}
 
 	logs, err := os.ReadFile(logFileName)
 	if err != nil {