Apply suggestions from code review

Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
pull/20338/head
錦南路之花 2024-10-30 16:02:21 +01:00 committed by Medya Ghazizadeh
parent 3c42f1ce99
commit abdbc5b3a3
3 changed files with 8 additions and 5 deletions

View File

@ -87,9 +87,10 @@ func (r *persistentRegistry) Register(tunnel *ID) (rerr error) {
alreadyExists := false
for i, t := range tunnels {
// it is allowed for multiple minikube clusters to have multiple tunnels simultaneously
// it is possible that an old tunnel from an old profile has duplicated route information
// so we need to check both machine name and route information
// It is allowed for multiple minikube clusters to have multiple
// tunnels simultaneously. It is possible that an old tunnel
// from an old profile has duplicated route information so we
// need to check both machine name and route information.
if tunnel.MachineName == t.MachineName && t.Route.Equal(tunnel.Route) {
isRunning, err := checkIfRunning(t.Pid)
if err != nil {

View File

@ -115,7 +115,8 @@ asserts that there are no unexpected errors displayed in minikube command output
are functionality tests which can safely share a profile in parallel
## TestFunctionalNewestKubernetes
are functionality run functional tests using NewestKubernetesVersion
are functionality run functional tests using
NewestKubernetesVersion
#### validateNodeLabels
checks if minikube cluster is created with correct kubernetes's node label

View File

@ -77,7 +77,8 @@ func TestFunctional(t *testing.T) {
testFunctional(t, "")
}
// TestFunctionalNewestKubernetes are functionality run functional tests using NewestKubernetesVersion
// TestFunctionalNewestKubernetes are functionality run functional tests using
// NewestKubernetesVersion
func TestFunctionalNewestKubernetes(t *testing.T) {
if strings.Contains(*startArgs, "--kubernetes-version") || constants.NewestKubernetesVersion == constants.DefaultKubernetesVersion {
t.Skip()