kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

test: Usse kickbase/echo-server for service tests 

The echoserver-arm:1.8 image is not an arm64 image:

    % kubectl create deployment echoserver --image registry.k8s.io/echoserver-arm:1.8
    deployment.apps/echoserver created

    % kubectl logs deploy/echoserver
    exec /usr/sbin/nginx: exec format error

    % minikube ssh -- sudo nerdctl -n k8s.io image ls registry.k8s.io/echoserver-arm:1.8
    REPOSITORY                        TAG    IMAGE ID        CREATED               PLATFORM       SIZE        BLOB SIZE
    registry.k8s.io/echoserver-arm    1.8    b33d4cdf6ed0    About a minute ago    linux/amd64    90.1 MiB    43.2 MiB

Replace with kickbase/echo-server we used in other tests.

With this change ServerCmdConnect pass. The other test using the broken
arm image was not failing, maybe it was not checking the deployment
status properly.

Functional tests time reduced from 230 seconds to 200 seconds:

    --- FAIL: TestFunctional (200.87s)
pull/21406/head
Nir Soffer 2025-08-22 21:31:21 +03:00 committed by Medya Ghazizadeh
parent cb07147efe
commit 65ef5bd2c4
1 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
test/integration/functional_test.go
View File

@ -1442,18 +1442,13 @@ func validateServiceCmd(ctx context.Context, t *testing.T, profile string) {
validateServiceCmdURL(ctx, t, profile)
}
// validateServiceCmdDeployApp Create a new `registry.k8s.io/echoserver` deployment
// validateServiceCmdDeployApp Create a new `kickbase/echo_server` deployment
func validateServiceCmdDeployApp(ctx context.Context, t *testing.T, profile string) {
t.Run("DeployApp", func(t *testing.T) {
var rr *RunResult
var err error
// registry.k8s.io/echoserver is not multi-arch
if arm64Platform() {
rr, err = Run(t, exec.CommandContext(ctx, "kubectl", "--context", profile, "create", "deployment", "hello-node", "--image=registry.k8s.io/echoserver-arm:1.8"))
} else {
rr, err = Run(t, exec.CommandContext(ctx, "kubectl", "--context", profile, "create", "deployment", "hello-node", "--image=registry.k8s.io/echoserver:1.8"))
}
rr, err = Run(t, exec.CommandContext(ctx, "kubectl", "--context", profile, "create", "deployment", "hello-node", "--image", echoServerImage))
if err != nil {
t.Fatalf("failed to create hello-node deployment with this command %q: %v.", rr.Command(), err)
}
@ -1636,14 +1631,9 @@ func validateServiceCmdConnect(ctx context.Context, t *testing.T, profile string
var rr *RunResult
var err error
// docs: Create a new `registry.k8s.io/echoserver` deployment
// registry.k8s.io/echoserver is not multi-arch
if arm64Platform() {
rr, err = Run(t, exec.CommandContext(ctx, "kubectl", "--context", profile, "create", "deployment", "hello-node-connect", "--image=registry.k8s.io/echoserver-arm:1.8"))
} else {
rr, err = Run(t, exec.CommandContext(ctx, "kubectl", "--context", profile, "create", "deployment", "hello-node-connect", "--image=registry.k8s.io/echoserver:1.8"))
}
// docs: Create a new `kickbase/echo-server` deployment
rr, err = Run(t, exec.CommandContext(ctx, "kubectl", "--context", profile, "create", "deployment", "hello-node-connect", "--image", echoServerImage))
if err != nil {
t.Fatalf("failed to create hello-node deployment with this command %q: %v.", rr.Command(), err)
}