Steven Powell
4cd3abfcde
add disable-optimizations flag
2022-01-12 13:50:38 -08:00
Piotr Resztak
4a2c97f28a
ability to set a mirror for downloading kubectl, kubelet, & kubeadm
2022-01-12 17:43:33 +01:00
Piotr Resztak
1d857e11de
add binary-mirror flag to start cmd
2022-01-12 17:43:33 +01:00
Viktor Gamov
67f748fc9e
fixing broken addons_list_test
2022-01-11 18:29:09 -05:00
Sharif Elgamal
ee43bf8492
grammar
2022-01-06 13:19:32 -08:00
Sharif Elgamal
2ddfd60c72
Make warning for running amd64 binary on M1 more visible
2022-01-06 13:15:01 -08:00
Anders F Björklund
c4800a6115
Make the default container runtime dynamic
...
Since the dockershim removal, there is no longer a constant
default container runtime provided by upstream. Only CRI.
2022-01-04 15:03:57 +01:00
Steven Powell
b6e2ee2128
Merge pull request #12996 from presztak/listimages_formats
...
Add format flag to the `image ls` command
2021-12-23 12:31:59 -08:00
Anders F Björklund
df2de68c13
Show the version of the cri-dockerd component
2021-12-22 22:25:50 +01:00
Piotr Resztak
84a0e2023c
add format flag for 'image ls' command
2021-12-22 00:57:41 +01:00
Sharif Elgamal
a0d4d429e4
Merge pull request #13174 from sharifelgamal/addon-cleanup
...
cleanup addons documentation and image sources
2021-12-15 14:43:37 -08:00
Sharif Elgamal
5de765023a
Merge pull request #13124 from sharifelgamal/kicbase-arch
...
fix kicbase dockerfile to allow ppc64le and armv7 archs
2021-12-15 14:08:07 -08:00
Sharif Elgamal
aff01abcd1
Update cmd/minikube/cmd/config/addons_list_test.go
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2021-12-15 13:36:21 -08:00
Sharif Elgamal
cf73e08262
make the test better
2021-12-14 17:11:00 -08:00
Sharif Elgamal
066ee66ba8
fix unit test
2021-12-14 16:28:55 -08:00
Medya Ghazizadeh
b924ca6155
Merge pull request #13147 from Ashwin901/master
...
Improve UI Advice for failing to start for non-installed drivers
2021-12-14 13:52:30 -08:00
Sharif Elgamal
c3688b6230
address comments
2021-12-14 12:36:48 -08:00
Steven Powell
54c615bd36
remove --mode flag from mount
2021-12-13 15:32:20 -08:00
Sharif Elgamal
2d12be02c4
detect arm better
2021-12-13 14:35:16 -08:00
Sharif Elgamal
50ed250fce
don't use crio on armv7 either
2021-12-13 13:31:04 -08:00
Ashwin901
daa270ec0c
display installed and non-installed drivers in separate lists
2021-12-12 12:28:13 +05:30
Steven Powell
5ddb53f57b
add all mount flags to start command
2021-12-10 11:43:50 -08:00
Steven Powell
9d16d24909
Revert "Refactored to remove config.ExtraOptions"
2021-12-08 13:07:33 -08:00
Steven Powell
ed380db035
Merge pull request #13125 from spowelljr/refactorExtraOptions
...
Refactored to remove config.ExtraOptions
2021-12-08 09:48:53 -08:00
Steven Powell
3cd016b06f
added comment and append error to message
2021-12-07 16:56:35 -08:00
Sharif Elgamal
da7020aa9c
format error message EVEN BETTER
2021-12-07 16:27:50 -08:00
Sharif Elgamal
b9e9df130a
return better error
2021-12-07 16:10:04 -08:00
Steven Powell
355f431c2d
refactored to remove config.ExtraOptions
2021-12-07 16:09:39 -08:00
Sharif Elgamal
6b7168cf4b
fix kicbase dockerfile to allow ppc64le and armv7 archs
2021-12-07 16:05:32 -08:00
Medya Ghazizadeh
f915d68855
Merge pull request #13110 from medyagh/k8sgomod
...
gomod: remove depending on k8s.io/kubernetes as a lib
2021-12-07 16:04:23 -08:00
Medya Ghazizadeh
c3ea9c298c
Merge pull request #12692 from arrikto/fix-apiserver-ips
...
Support changing apiserver-ips when restarting minikube
2021-12-07 15:33:24 -08:00
Medya Gh
e900c5bb76
replacea all references to kuberentes/cmd to third_party
2021-12-07 14:20:07 -08:00
Sharif Elgamal
30afddc6c1
Merge pull request #13072 from klaases/kstop1
...
Stop K8s if running, when '--no-kubernetes' flag used
2021-12-06 12:49:20 -08:00
Medya Ghazizadeh
f1d63dfcff
Merge pull request #12990 from spowelljr/btrfsErrorMessage
...
Add advice if user using btrfs storage driver
2021-12-03 16:06:06 -08:00
klaases
47a280bdc7
Fix check for stopping k8s.
2021-12-03 14:15:00 -08:00
Sergio Galvan
de3799696d
add support for uppercase
...
Signed-off-by: Sergio Galvan <sergalma@gmail.com>
2021-12-03 22:35:09 +01:00
Sergio Galvan
9348d6a4f0
support newest for --kubernetes-version
2021-12-03 21:48:11 +01:00
klaases
f3186d07d8
Detect whether k8s needs to be stopped.
2021-12-03 12:35:34 -08:00
klaases
e468a42e15
Merge branch 'master' into kstop1
2021-12-02 14:43:33 -08:00
klaases
3074132aeb
Stop K8s if running, when --no-kubernetes.
2021-12-02 14:35:38 -08:00
Steven Powell
c8fbd6e242
typo
2021-12-02 09:39:42 -08:00
Steven Powell
3f8e3dc3ed
use oci cache to get storage driver
2021-12-01 16:15:01 -08:00
Steven Powell
592e2b01ca
auto set LocalStorageCapacityIsolation for BTRFS
2021-11-30 14:34:57 -08:00
Piotr Resztak
7b3860388c
Print a message about preserving kicbase image
...
Print additional info about preserving kicbase image and generates
image deletion command for user when running `minikube delete`.
Message is printed only when `--purge` option is used.
2021-11-25 23:36:59 +01:00
Steven Powell
ee75b3c368
add support for port validation with ip
2021-11-23 10:09:14 -08:00
Medya Ghazizadeh
3686ba58f0
Merge pull request #11598 from daehyeok/copy_from
...
Support copy file from node to local host or between nodes.
2021-11-22 13:42:35 -08:00
Medya Ghazizadeh
119a0f07d7
Merge pull request #12942 from klaases/go5
...
Exit if --kubernetes-version and --no-kubernetes are specified.
2021-11-22 10:01:21 -08:00
klaases
22bbf5f9bb
Add config unset message.
2021-11-19 13:54:57 -08:00
Medya Ghazizadeh
2ab68fb50f
Merge pull request #12977 from medyagh/allflag_cache
...
fix flag name in cache add
2021-11-18 08:19:29 -08:00
Medya Ghazizadeh
355fe0e2bc
Merge pull request #12976 from spowelljr/outputTunnelHasStarted
...
Output tunnel has started message so users aren't confused if tunnel is running
2021-11-17 16:05:18 -08:00
Medya Ghazizadeh
43482ee901
Merge pull request #12952 from spowelljr/privOnlyWSL
...
Only check privileged ports for WSL
2021-11-17 16:03:52 -08:00
Steven Powell
3dfe2a0af9
updated message
2021-11-17 15:43:19 -08:00
Steven Powell
0059bc953f
Merge pull request #12958 from klaases/go6
...
ensure --memory flag is within syslimit
2021-11-17 18:37:39 -05:00
Medya Gh
64ce5460cf
fix flag name in cache add
2021-11-17 15:31:55 -08:00
Steven Powell
c470b8db18
output tunnel has started message so users aren't confused if tunnel is running
2021-11-17 15:22:39 -08:00
Medya Ghazizadeh
48424c5393
Merge pull request #11909 from vishjain/user/vishal/memory-leak/master
...
Cleanup on ticker allocations.
2021-11-17 13:23:54 -06:00
Steven Powell
3c125f10e9
Merge pull request #12972 from mpuckett159/bug/fix-docker-env-typo
...
Fix typo in help text for minikube docker-env command
2021-11-17 13:51:52 -05:00
Marcus Puckett
d831158c0c
Fix typo in help text for minikube docker-env
...
In the help text for the `minikube docker-env` command the suggestions for setting the docker command for Windows (cmd and powershell) don't work as output because if you don't pass the `--shell` flag, it adds a line at the beginning that will cause the cmd example to fail, and doesn't specify that you need to set the flag `--shell powershell` for it to work properly. I've updated the help text to provide a command that will work as expected for both shells.
2021-11-16 22:48:55 -08:00
klaases
227efdd03a
Exit if both no-kubernetes and kubernetes-version flags are used together.
2021-11-16 15:53:32 -08:00
klaases
38358b9b63
Return NoKubernetesVersion if noKubernetes is true.
2021-11-16 14:24:02 -08:00
klaases
f3f5ae3474
Only check kubernetesVersion flag if noKubernetes is false.
2021-11-16 14:17:29 -08:00
Steven Powell
2a99b2f946
fix out of bound exceptions
2021-11-16 11:40:02 -05:00
klaases
e22b8c0709
ensure --memory flag is within syslimit
2021-11-15 13:35:12 -08:00
Pablo Caderno
5594331882
fix: do not let users run --no-kubernetes on the none driver
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2021-11-16 07:06:37 +11:00
Steven Powell
518fd1d6fa
update unit test
2021-11-15 12:16:57 -05:00
Steven Powell
81aedea0bd
only check privileged ports for WSL
2021-11-15 11:49:59 -05:00
Medya Ghazizadeh
8bd28a6599
Merge pull request #12933 from klaases/go2
...
update suggestion messaging for --no-kubernetes
2021-11-12 12:21:14 -08:00
Medya Ghazizadeh
80b4e238cf
Merge pull request #12900 from AkihiroSuda/rootless-crio
...
Support CRI-O runtime with Rootless Docker driver (`--driver=docker --container-runtime=cri-o`)
2021-11-11 16:05:36 -08:00
klaases
532b383f46
Add "minikube image" message.
2021-11-11 14:53:31 -08:00
klaases
4238bc1319
update message by runtime
2021-11-11 14:49:18 -08:00
Medya Ghazizadeh
75e2466cf9
Merge pull request #12923 from sharifelgamal/sched-ctd
...
fix scheduled stop test for containerd on docker driver
2021-11-11 12:45:12 -08:00
Sharif Elgamal
d226d04eab
fix schedule stop test for containerd on docker driver
2021-11-10 09:09:50 -08:00
Akihiro Suda
d7e728487c
Support CRI-O runtime with Rootless Docker driver
...
Follow-up to PR 12359 (containerd runtime with Rootless Docker driver).
Usage (needs cgroup v2):
```
dockerd-rootless-setuptool.sh install
docker context use rootless
minikube start --driver=docker --container-runtime=cri-o
```
See site/content/en/docs/drivers/includes/docker_usage.inc
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2021-11-09 16:09:52 +09:00
Sharif Elgamal
df14157e9f
fix formatting
2021-11-08 17:22:51 -08:00
Sharif Elgamal
93e267c5ae
Allow custom cert for ingress to be overwritten
2021-11-08 17:16:00 -08:00
Sharif Elgamal
12f3d7aff1
Merge pull request #12861 from sharifelgamal/node-add-step
...
register node add initial step
2021-11-04 14:54:17 -07:00
Medya Ghazizadeh
94c74a2f52
Merge pull request #12848 from medyagh/no_kubernetes
...
Add --no-kubernetes flag to start minikube without kubernetes
2021-11-04 14:46:48 -07:00
Sharif Elgamal
2e65c15d2b
register node add initial step
2021-11-04 13:12:57 -07:00
Medya Gh
92cf41d686
do not set global viper config
2021-11-04 12:22:29 -07:00
Medya Gh
a108c71ea9
remove comment
2021-11-04 11:16:27 -07:00
Medya Ghazizadeh
630e02d96b
Update cmd/minikube/cmd/start.go
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2021-11-04 11:10:18 -07:00
Sharif Elgamal
65ed4ad45f
Merge pull request #12839 from spowelljr/addonListNotRunning
...
`minikube addons list` tests
2021-11-03 21:50:47 -07:00
Daehyeok Mun
a88aec8b46
Support copy file from node to local host or between nodes.
2021-11-03 14:49:32 -07:00
Medya Gh
5bcdba0a09
add more constants
2021-11-03 14:16:04 -07:00
Medya Gh
cd9d263b9f
address review comments
2021-11-03 14:13:26 -07:00
Medya Gh
bfdc3cfdea
address review comments
2021-11-03 14:13:04 -07:00
Medya Gh
3d0f486d84
add integration test for --no-kubernetes
2021-11-03 14:08:01 -07:00
Steven Powell
f0f1819123
output empty addons objects on JSON
2021-11-03 10:12:41 -07:00
Medya Gh
79f1b8c55c
add --no-kubernetes flag to start minikube without kubernetes
2021-11-02 15:41:40 -07:00
Sharif Elgamal
3342d3aa34
Merge pull request #12811 from nbusseneau/pr/fix-virtualbox-ip
...
virtualbox: change default `host-only-cidr`
2021-11-02 13:38:16 -07:00
Medya Ghazizadeh
9dde4cb9c1
Merge pull request #12841 from Keyhoh/issue/refix-11348
...
fix zsh completion
2021-11-02 11:41:23 -07:00
Nicolas Busseneau
02a43c52e2
virtualbox: change default `host-only-cidr`
...
We change the default `--host-only-cidr` to `192.168.59.1/24` in order
to be compatible with the new default host-only networking restrictions
implemented in VirtualBox 6.1.28.
This fixes access denied errors on `minikube start` when using
VirtualBox >= 6.1.28:
```
VBoxManage: error: Code E_ACCESSDENIED (0x80070005) - Access denied (extended info not available)
VBoxManage: error: Context: "EnableStaticIPConfig(Bstr(pszIp).raw(), Bstr(pszNetmask).raw())" at line 242 of file VBoxManageHostonly.cpp
```
More details:
VirtualBox 6.1.28 introduced new restrictions on host-only networking:
https://www.virtualbox.org/wiki/Changelog-6.1#v28
Manual: https://www.virtualbox.org/manual/ch06.html#network_hostonly
> On Linux, Mac OS X and Solaris Oracle VM VirtualBox will only allow IP
> addresses in 192.68.56.0/21 range to be assigned to host-only
> adapters. For IPv6 only link-local addresses are allowed. If other
> ranges are desired, they can be enabled by creating
> /etc/vbox/networks.conf and specifying allowed ranges there. For
> example, to allow 10.0.0.0/8 and 192.168.0.0/16 IPv4 ranges as well as
> 2001::/64 range put the following lines into /etc/vbox/networks.conf:
>
> * 10.0.0.0/8 192.168.0.0/16
> * 2001::/64
>
> Lines starting with the hash # are ignored. Next example allows any
> addresses, effectively disabling range control:
>
> * 0.0.0.0/0 ::/0
These new restrictions manifest in the form of the following issue on
`minikube start` due to the default `--host-only-cidr` used by the
VirtualBox driver being `192.168.99.1/24`:
```console
😄 minikube v1.23.2 on Ubuntu 18.04
✨ Using the virtualbox driver based on user configuration
👍 Starting control plane node minikube in cluster minikube
🔥 Creating virtualbox VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...
🔥 Deleting "minikube" in virtualbox ...
🤦 StartHost failed, but will try again: creating host: create: creating: Error setting up host only network on machine start: /usr/bin/VBoxManage hostonlyif ipconfig vboxnet0 --ip 192.168.99.1 --netmask 255.255.255.0 failed:
VBoxManage: error: Code E_ACCESSDENIED (0x80070005) - Access denied (extended info not available)
VBoxManage: error: Context: "EnableStaticIPConfig(Bstr(pszIp).raw(), Bstr(pszNetmask).raw())" at line 242 of file VBoxManageHostonly.cpp
🔥 Creating virtualbox VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...
😿 Failed to start virtualbox VM. Running "minikube delete" may fix it: creating host: create: creating: Error setting up host only network on machine start: /usr/bin/VBoxManage hostonlyif ipconfig vboxnet1 --ip 192.168.99.1 --netmask 255.255.255.0 failed:
VBoxManage: error: Code E_ACCESSDENIED (0x80070005) - Access denied (extended info not available)
VBoxManage: error: Context: "EnableStaticIPConfig(Bstr(pszIp).raw(), Bstr(pszNetmask).raw())" at line 242 of file VBoxManageHostonly.cpp
❌ Exiting due to GUEST_PROVISION: Failed to start host: creating host: create: creating: Error setting up host only network on machine start: /usr/bin/VBoxManage hostonlyif ipconfig vboxnet1 --ip 192.168.99.1 --netmask 255.255.255.0 failed:
VBoxManage: error: Code E_ACCESSDENIED (0x80070005) - Access denied (extended info not available)
VBoxManage: error: Context: "EnableStaticIPConfig(Bstr(pszIp).raw(), Bstr(pszNetmask).raw())" at line 242 of file VBoxManageHostonly.cpp
╭───────────────────────────────────────────────────────────────────────────────────────────╮
│ │
│ 😿 If the above advice does not help, please let us know: │
│ 👉 https://github.com/kubernetes/minikube/issues/new/choose │
│ │
│ Please run `minikube logs --file=logs.txt` and attach logs.txt to the GitHub issue. │
│ │
╰───────────────────────────────────────────────────────────────────────────────────────────╯
```
While the above is the primary error, other errors will be reported if
the adapter already exists (this happens when the adapter was created
before updating to VirtualBox 6.1.28, on a version of VirtualBox without
the new restrictions). Some examples:
```
❌ Exiting due to IF_VBOX_NOT_VISIBLE: Failed to start host: creating host: create: creating: Error setting up host only network on machine start: The host-only adapter we just created is not visible. This is a well known VirtualBox bug. You might want to uninstall it and reinstall at least version 5.0.12 that is is supposed to fix this issue
```
```
❌ minikube is unable to connect to the VM: dial tcp 192.168.99.112:22: i/o timeout
This is likely due to one of two reasons:
- VPN or firewall interference
- virtualbox network configuration issue
Suggested workarounds:
- Disable your local VPN or firewall software
- Configure your local VPN or firewall to allow access to 192.168.99.112
- Restart or reinstall virtualbox
- Use an alternative --vm-driver
- Use --force to override this connectivity check
❌ Exiting due to GUEST_PROVISION: Failed to validate network: dial tcp 192.168.99.112:22: i/o timeout
```
When switching to a valid CIDR, `minikube start` works as usual:
```console
😄 minikube v1.23.2 on Ubuntu 18.04
✨ Using the virtualbox driver based on user configuration
👍 Starting control plane node minikube in cluster minikube
🔥 Creating virtualbox VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...
🐳 Preparing Kubernetes v1.22.2 on Docker 20.10.8 ...
▪ Generating certificates and keys ...
▪ Booting up control plane ...
▪ Configuring RBAC rules ...
▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🔎 Verifying Kubernetes components...
🌟 Enabled addons: storage-provisioner, default-storageclass
🏄 Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
```
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
2021-11-02 15:30:46 +01:00
Keyhoh
ca928b43ed
fix: revert wrong fix and re-fix zsh completion
2021-11-02 22:57:43 +09:00
Steven Powell
4c4adff43a
add tests
2021-11-01 17:39:46 -07:00
Steven Powell
389ea688ff
`minikube addons list` shows addons if cluster does not running
2021-11-01 12:44:44 -07:00
Medya Ghazizadeh
6f72fc9a25
Merge pull request #12578 from AliyunContainerService/aliyun-mirror
...
Initial support for adding Aliyun mirror for preload images and K8s release binaries
2021-10-26 13:22:30 -07:00
Medya Gh
c8cb7a3c2d
delete older minikube version preload files on start tup
2021-10-21 14:54:14 -07:00
Steven Powell
d7decc2a8d
persist mount settings after stop
2021-10-18 15:40:48 -07:00
Steven Powell
c073e65c6d
Merge pull request #12716 from spowelljr/fixHyperVStop
...
Kill mount process before stopping nodes
2021-10-18 14:33:09 -07:00
Piotr Resztak
21d08dd0ed
remove duplicated update of MinikubeISO
2021-10-16 13:34:06 +02:00
Steven Powell
99661e64a3
Merge pull request #12711 from spowelljr/fixMount
...
Fix mounting on non-default profile
2021-10-15 12:57:24 -07:00
Steven Powell
645b739d88
kill mount before stopping nodes
2021-10-15 10:52:39 -07:00
Steven Powell
0fcf1eddec
remove unnecessary join
2021-10-15 09:14:18 -07:00
Steven Powell
9a89855997
add backwards compatible mount-process delete
2021-10-14 16:01:59 -07:00
Steven Powell
2a489bf7e1
fix mounting on non-default profile & make mounting processes cluster independent
2021-10-14 14:44:51 -07:00
Carlos Santana
2f0e883e60
make options command discoverable in minikube help
2021-10-14 13:15:06 -04:00
Dimitris Aragiorgis
4535640b63
Support changing apiserver-ips when restarting minikube
...
After commit bee6815
, we could not change the apiserver-ips after
initial `minikube start`. Revert to previous behavior where both
apiserver-ips and apiserver-names were taken always into account
and certs were updated accordingly.
Fixes #9818
2021-10-11 05:28:30 -04:00
KallyDev
70022d9b2e
Move from deprecated ioutil to os and io packages
2021-10-08 08:57:19 +08:00
Steven Powell
7f827f93b3
Merge pull request #11752 from RA489/fix_ui
...
Minikube stop - correct the number of stopped nodes
2021-10-06 12:59:18 -04:00
RA489
ce2602c157
Minikube stop - correct the number of stopped nodes
2021-10-06 09:35:34 +05:30
Steven Powell
4c6f03c376
Merge pull request #12246 from spowelljr/fixMinikubeLogsWindows
...
Don't error if we can't retrieve logs from a pod during `minikube logs`
2021-10-01 09:58:32 -07:00
Steven Powell
a502d3e2e1
Merge pull request #12420 from Keyhoh/issue/11348
...
fix issue #11348 zsh completion broken
2021-09-28 18:41:58 -07:00
Keyhoh
1976f71548
fix: zsh completion broken
2021-09-29 06:21:33 +09:00
Steven Powell
25b73c79f9
add back warning output
2021-09-28 10:20:10 -07:00
Medya Ghazizadeh
2fd09e11a8
Merge pull request #12149 from afbjorklund/build-cp
...
Build images on the primary control plane
2021-09-27 19:11:04 -07:00
Steven Powell
f85e7db048
Merge pull request #12233 from kadern0/issue-10495
...
Added port validation
2021-09-27 15:56:03 -07:00
Pablo Caderno
4e1bcc06ce
Fixed error exit. Added docs
2021-09-28 08:43:19 +10:00
Li Yi
eb66c6797e
Initial support for adding Aliyun mirror for preload images and Kubernetes binaries
...
Signed-off-by: Li Yi <denverdino@gmail.com>
2021-09-26 15:36:36 +08:00
Sharif Elgamal
4307e834df
address review comments
2021-09-24 11:47:10 -07:00
Steven Powell
e7723c79dd
return 0 exit code if failed to get container logs
2021-09-23 13:22:31 -07:00
Sharif Elgamal
77051a35df
make sure to set expiration if not in existing config
2021-09-22 11:22:08 -07:00
Sharif Elgamal
1212848649
make cert expiration configurable and add test
2021-09-21 16:17:52 -07:00
Steven Powell
f21263390c
add warning for ambassador addon
2021-09-14 14:01:07 -07:00
Medya Ghazizadeh
9f96701d8f
Merge pull request #12458 from minikube-bot/auto_bump_golint_version
...
bump golint version
2021-09-13 16:30:45 -07:00
Steven Powell
145f9fc9ab
run `go fmt`
2021-09-13 11:58:43 -07:00
Sharif Elgamal
96923883e7
fixes for ingress
2021-09-09 13:47:01 -07:00
Steven Powell
3e25ee3dfe
Merge pull request #12381 from jayesh-srivastava/master
...
Updated version.go with crun version
2021-09-09 10:51:33 -07:00
Steven Powell
9d940e234f
ask user for config values even if already set
2021-09-08 12:19:48 -07:00
Sharif Elgamal
738eb5177c
Merge pull request #12231 from sharifelgamal/gcp-cs
...
gcp-auth: improve flow for GCE/Cloud Shell
2021-09-01 13:20:06 -07:00
Medya Ghazizadeh
3469c77ffa
Merge pull request #12351 from raghavendra-talur/rtalur-add-disks-kvm2
...
Add `--extra-disks` capability to kvm2 driver
2021-08-30 16:50:58 -07:00
Pablo Caderno
69a5a9383c
Refactored code into functions. Added tests
2021-08-31 09:16:37 +10:00
Jayesh Srivastava
eb78bb7602
Update version.go
2021-08-30 23:23:30 +05:30
Akihiro Suda
323225483e
Support Rootless Docker
...
Requirements:
- Install rootless Docker 20.10 or later, see https://rootlesscontaine.rs/getting-started/docker/
- Enable cgroup v2 delegation, see https://rootlesscontaine.rs/getting-started/common/cgroup2/
Usage: `minikube start --driver=docker --container-runtime=containerd`.
The `--container-runtime` flag needs to be set to "containerd".
CRI-O can be also supported later.
Closes issue 10836 ("add support for rootless Docker").
Support for rootless Podman (issue 8719) is not covered in this commit.
---
Code reading guide:
- `deploy/kicbase/Dockerfile`: updated to install fuse-overlayfs and containerd-fuse-overlayfs, which is used
instead of `overlayfs` snapshotter
- `deploy/kicbase/entrypoint`: updated to verify cgroup v2 delegation.
Mostly from 8a83ee46b2/images/base/files/usr/local/bin/entrypoint
- `cmd/minikube/cmd/start_flags.go`: updated to set `KubeletInUserNamespace` feature gate when rootless
- `pkg/drivers/kic/oci`: updated to use port forwarding, because rootless container IPs are not reachable from the host
- `pkg/minikube/cruntime`: updated to generate `/etc/containerd/config.toml` with rootless support.
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2021-08-27 17:21:53 +09:00
Sharif Elgamal
55c40f8220
Merge branch 'master' of github.com:kubernetes/minikube into gcp-cs
2021-08-26 13:32:10 -07:00
Medya Ghazizadeh
527a3d920f
Merge pull request #12265 from prezha/fix-image-save-cmd
...
fix image save cmd
2021-08-25 10:45:08 -07:00
Raghavendra Talur
dceb676527
Add extra disks capability to kvm2 driver
...
Having additional disks on the nodes is a requirement for developers
working on the storage components in Kubernetes. This commit adds the
extra-disks feature to the kvm2 driver.
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
2021-08-25 00:15:02 -04:00
Medya Ghazizadeh
01155b1537
Merge pull request #12319 from andriyDev/UseWSLIP
...
Select WSL VM IP when performing mounting
2021-08-24 10:40:32 -07:00
Predrag Rogic
6efbd1ce13
merge
2021-08-24 04:20:52 +01:00
Sharif Elgamal
42d3f3b92f
Merge branch 'master' of github.com:kubernetes/minikube into gcp-cs
2021-08-23 15:40:30 -07:00
Sharif Elgamal
8470a955db
error handling\!
2021-08-23 14:06:23 -07:00
Sharif Elgamal
32577cc801
Merge branch 'master' of github.com:kubernetes/minikube into cs-start-stop
2021-08-23 14:02:24 -07:00
Sharif Elgamal
4bc5cb77d1
Merge branch 'master' of github.com:sharifelgamal/minikube into gcp-cs
2021-08-23 11:11:16 -07:00
Anders F Björklund
817f8b4b70
Add also stand-alone image push matching pull
...
Normally this is done as part of image build
2021-08-22 20:11:19 +02:00
Anders F Björklund
380b846715
Add stand-alone image pull and image tag commands
...
Needed for testing, but maybe elsewhere as well
2021-08-22 19:52:07 +02:00
Sharif Elgamal
fe6cbc4e42
add extra options to minikube start directly
2021-08-20 15:34:53 -07:00
Sharif Elgamal
69d5d34eeb
Merge pull request #12089 from zhan9san/feature/ingress-mac
...
Support Ingress on MacOS, driver docker
2021-08-20 15:16:13 -07:00
Andriy Dzikh
405235908d
Fix lint.
2021-08-20 15:06:24 -07:00
Andriy Dzikh
47afdc87df
Add logging message incase someone tries to debug.
2021-08-20 11:42:17 -07:00
Andriy Dzikh
2f094d117d
Use WSL VM IP for mounting in WSL.
2021-08-20 11:41:44 -07:00
Jack Zhang
def3f067a8
Support Ingress on MacOS, driver docker
2021-08-17 10:27:21 +08:00
Anders F Björklund
9e588e6ba1
Add stand-alone image pull and image tag commands
...
Needed for testing, but maybe elsewhere as well
2021-08-15 20:22:24 +02:00
Pablo Caderno
1f83aa3ac2
Added port validation
2021-08-14 15:48:56 +10:00
Anders F Björklund
68197de861
Add command to save images from the cluster
...
This is the opposite command of "minikube image load",
and can be used after doing a "minikube image build".
The default is to save images in the cache, but it is
also possible to save to files or to standard output.
2021-08-13 23:28:25 +01:00
Anders F Björklund
5bd3f9a79c
Add tests for the new docker-env output formats
2021-08-13 23:32:03 +02:00
Anders F Björklund
4f8adb6f6d
Add output parameter to the docker-env none shell
...
Allows structured output as json and yaml, in addition to the
previous text output format. Note that keys might not be sorted.
2021-08-13 23:31:05 +02:00
Sharif Elgamal
235d7e8280
Merge branch 'master' of github.com:kubernetes/minikube into gcp-cs
2021-08-13 14:15:31 -07:00
Sharif Elgamal
371becaf73
tMerge branch 'master' of github.com:kubernetes/minikube into gcp-cs
2021-08-13 14:08:23 -07:00
Medya Ghazizadeh
0bd906077f
Revert "new `image save` command"
2021-08-13 14:06:42 -07:00
Sharif Elgamal
06ed3378b9
create special error to skip addons without erroring out
2021-08-13 13:42:02 -07:00
Medya Ghazizadeh
41ba49d597
Merge pull request #12162 from afbjorklund/image-save-cmd
...
Image save command
2021-08-13 13:02:58 -07:00
Medya Gh
6aa7abc24a
fix lint issues on master
2021-08-12 17:38:24 -07:00
Anders F Björklund
b75bf27942
Add command to save images from the cluster
...
This is the opposite command of "minikube image load",
and can be used after doing a "minikube image build".
The default is to save images in the cache, but it is
also possible to save to files or to standard output.
2021-08-10 09:49:23 +02:00
Anders F Björklund
2ab5c86a88
Build images on the primary control plane
...
Allow selecting another node using --node
Or continue build on all nodes with --all
2021-08-06 19:04:51 +02:00
Anders F Björklund
6e571d830f
Show data with keys sorted instead of random
2021-08-01 10:23:46 +02:00
Anders F Björklund
4f6ee47f28
Remove extra output lines after the version
...
Some commands, like crio and runc, dump extra line noise
after the --version even though they have a long version.
2021-08-01 10:23:42 +02:00
Anders F Björklund
46c3797169
Show cli versions instead of daemon versions
...
Since the server daemon might not be running
This affects docker and containerd runtimes
2021-08-01 10:22:05 +02:00
Blaine Gardner
8f05ee00e1
Add ability to create extra disks on hyperkit vms
...
Add the ability to create and attach extra disks to hyperkit vms.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-07-28 09:57:20 -06:00
Medya Ghazizadeh
3375c39c76
Merge pull request #11981 from de-sh/vb-warn
...
Add message to discourage the use of the virtualbox driver
2021-07-26 17:30:38 -07:00
Vishal Jain
7cda4bb986
Fix lint error.
2021-07-25 15:27:05 -07:00
Vishal Jain
5caf53c004
Cleanup ticker allocations.
2021-07-25 15:14:21 -07:00
Andriy Dzikh
36cc7e0a70
Have cluster.Mount return an error which is checked in advice.go.
2021-07-22 10:38:57 -07:00
Andriy Dzikh
49cd3840d3
Create advice for mount command timing out.
2021-07-14 15:38:04 -07:00
Andriy Dzikh
354fedb073
Add command-line argument port for mount cmd.
2021-07-14 15:00:03 -07:00
Devdutt Shenoi
0e665930e8
Add message to discourage the use of virtualbox driver
2021-07-14 15:00:22 +05:30
dmpe
0c721cbacd
remove whitespace
2021-07-12 20:23:07 +02:00
dmpe
a60b337237
fix an issue with hasPorts variable - further simplification
2021-07-12 20:15:21 +02:00
dmpe
6ccc6e7659
Merge branch 'master' into mytests
2021-07-12 19:57:21 +02:00
Steven Powell
961bbbe0aa
Merge pull request #11553 from zigarn/dashboard-set-port
...
Allow to set the dashboard proxyfied port
2021-07-12 16:53:32 +00:00
Medya Ghazizadeh
cabf73ed59
Merge pull request #11800 from mahalrs/simplify-error-codes-11786
...
Simplify, and remove all un-used minikube error codes
2021-07-06 19:48:12 -04:00
dmpe
12f2d69259
Merge remote-tracking branch 'upstream' into mytests
2021-07-06 12:13:06 +02:00
Alexandre Garnier
e63b223be9
Add dashboard port validation
2021-07-03 15:59:59 +02:00
Alexandre Garnier
f76b0795d8
Allow to set the dashboard proxyfied port
2021-07-03 15:59:59 +02:00
Steven Powell
f684ae4c5e
Merge pull request #11875 from mahalrs/flag-typo
...
Fix typo in pause command
2021-07-02 17:14:42 +00:00
Rajwinder Mahal
cd1db56f87
Fix typo in unpause command
2021-07-01 22:19:37 -07:00
Rajwinder Mahal
75422a844c
Fix typo in pause command
2021-07-01 16:23:07 -07:00
Sharif Elgamal
494a24abcc
Merge pull request #11834 from andriyDev/AutoPause
...
Add support for other container runtimes for auto-pause
2021-07-01 16:01:27 -07:00
Rajwinder Mahal
659e8c2785
Replace InternalEnable and InternalDisable with InternalAddonEnable and InternalAddonDisable
2021-07-01 14:52:24 -07:00
Sharif Elgamal
85e27c5820
Merge pull request #11773 from sharmarajdaksh/add-error-code-explanations
...
Adds explanations for all minikube error codes
2021-07-01 14:33:15 -07:00
Andriy Dzikh
574cdb9587
Add --container-runtime flag to auto-pause.
2021-07-01 13:11:12 -07:00
Medya Gh
61e06d77bd
fix boilerplate
2021-07-01 15:21:32 -04:00
Medya Gh
f35d99a2bb
add --components flag for verion command
2021-07-01 15:21:30 -04:00
Sharif Elgamal
99ba231b50
Merge pull request #11819 from spowelljr/fixKubectlDirectCall
...
windows: support renaming binary to `kubectl.exe` and running as kubectl
2021-07-01 11:03:04 -07:00
Dakshraj Sharma
d8adc48463
Adds explanations for minikube error codes
2021-07-01 23:22:23 +05:30
Steven Powell
fdca7d6844
support renaming binary to kubectl.exe and running as kubectl
2021-06-30 20:41:11 +00:00
Medya Gh
89c7853601
bump go mod libs manually
2021-06-29 15:24:59 -04:00
Steven Powell
e8b3db9485
Merge pull request #11692 from spowelljr/addNoLimit
...
Add ability to pass 'max' value to memory and cpus flags
2021-06-28 17:09:32 +00:00
Medya Ghazizadeh
512ae30449
Merge pull request #11753 from andriyDev/AddonMaintainers
...
Add maintainer column to addons list
2021-06-25 18:42:51 -04:00
Steven Powell
cae8f40eaf
fixed validation for cpus
2021-06-25 10:49:29 -07:00
Steven Powell
68cd71aea7
fix --cpus=max for non-KIC drivers
2021-06-25 10:49:28 -07:00
Steven Powell
6799b19972
use constant for flag description
2021-06-25 10:49:28 -07:00
Steven Powell
a2ae86cb7c
renamed flag value from nolimit to max
2021-06-25 10:49:28 -07:00
Steven Powell
c2e2546f9b
fixed linting issues
2021-06-25 10:49:28 -07:00
Steven Powell
4871d68d8c
add ability to pass nolimit value to memory and cpus flags
2021-06-25 10:49:28 -07:00
Andriy Dzikh
b5df84a707
Add maintainer column to addons list.
2021-06-24 10:11:38 -07:00
Ilya Zuyev
b2d46e51a1
Update message about running amd64 binary on M1
2021-06-21 18:38:47 -07:00
Ilya Zuyev
b10a7a1b9e
Merge branch 'master' into ilyaz/m1_amd64
2021-06-21 18:35:00 -07:00
Sharif Elgamal
cf4078ad1a
Merge pull request #11576 from JacekDuszenko/fix-embed-certs-from-config
...
Fix embed-certs global config
2021-06-21 11:33:11 -07:00
Medya Ghazizadeh
b9c363001d
Merge pull request #11668 from daehyeok/remove_config_options
...
Remove unused config options
2021-06-21 12:42:23 -04:00
Medya Ghazizadeh
c7c06e84f4
Merge pull request #11678 from RA489/regis_mirror
...
change registery_mirror to registery-mirror
2021-06-21 11:55:19 -04:00
Sharif Elgamal
811ff18161
Merge pull request #11677 from sharifelgamal/auto-gen-docs
...
Automatically run `make generate-docs` after every PR merge
2021-06-18 14:30:08 -07:00
Daehyeok Mun
cd1adcf35d
Remove unused config options
2021-06-18 11:54:47 -04:00
Medya Ghazizadeh
54d825068c
Merge pull request #11423 from vishjain/user/vishal/delete-profiles/main
...
Added Mock of Minikube Delete Profiles Test portion.
2021-06-17 13:02:18 -04:00
RA489
48709efc4d
change registery_mirror to registery-mirror
2021-06-17 15:15:04 +05:30
Sharif Elgamal
f7cb9286f6
only test for missing docs string
2021-06-16 10:06:11 -07:00
Sharif Elgamal
7b5381b697
add generate-docs script
2021-06-16 09:23:54 -07:00
Ilya Zuyev
32cd4cb12b
Allow running amd64 bianry on M1
2021-06-15 15:30:12 -07:00
Dongjoon Hyun
4eb3c6332d
Fix a download link to use arm64 instead of amd64
2021-06-14 15:11:49 -07:00
JacekDuszenko
b7a6dd0b5e
implement embed certs global config as EmbedCerts
2021-06-05 23:59:45 +01:00
dmpe
8badb789e8
smaller documentation fix
2021-06-05 20:59:52 +02:00
dmpe
445684d44d
fix(start): minikube start with --image-repository: add new test for URLs with ports, fixing fix validation logic
2021-06-05 20:50:00 +02:00
Vishal Jain
03b793c7d0
Fix names.
2021-06-05 11:18:07 -07:00
Vishal Jain
ebe03d7687
Added Mock to DeleteProfile Test.
2021-06-02 19:45:41 -07:00
Vishal Jain
36a6f87600
Added Mock of Minikube Delete Profiles Test portion.
2021-06-02 19:45:41 -07:00
Sharif Elgamal
d76259e86f
Merge pull request #11528 from andriyDev/FixDownloadOnlyTest2
...
Change PreloadExists to report no preload for BareMetal drivers
2021-06-02 12:59:15 -07:00
Sharif Elgamal
343015001a
Merge pull request #11504 from ilya-zuyev/ilyaz/fix_delete_paused
...
Fix delete command for paused kic driver with containerd/crio runtime
2021-06-01 13:14:05 -07:00
Sharif Elgamal
31417806b7
Merge pull request #11486 from sharifelgamal/gcp-auth-restart
...
gcp-auth addon: do not reapply gcp-auth yamls on minikube restart
2021-05-27 15:05:34 -07:00
Andriy Dzikh
a8136ec322
Move InstallOrUpdate to its own package.
2021-05-27 15:01:58 -07:00
Ilya Zuyev
eff0bc7161
trigger build to update github status
2021-05-26 22:02:41 -07:00
Ilya Zuyev
1b562da2b0
apply to crio as well
2021-05-26 17:09:13 -07:00
Ilya Zuyev
2244e26fe4
Merge branch 'master' into ilyaz/fix_delete_paused
2021-05-26 16:58:40 -07:00
Ilya Zuyev
2628f8bb04
fix quoting
2021-05-26 15:27:31 -07:00
Ilya Zuyev
2a7f0dca85
simplify the code
2021-05-26 13:41:10 -07:00
Ilya Zuyev
773500bc74
do not unapuse for docker/crio
2021-05-26 12:49:08 -07:00
Medya Ghazizadeh
b1ce37b7b5
Merge pull request #11469 from utkarsh-pro/utkarsh-pro/fix/11171
...
Support setting addons from environmental variables
2021-05-26 10:19:22 -07:00
Sharif Elgamal
6db4a51cbb
swap to --refresh
2021-05-26 09:26:10 -07:00
Ilya Zuyev
4567aaa72f
trigger bulid
2021-05-25 18:03:35 -07:00
Medya Ghazizadeh
08a7f20dea
Merge pull request #11481 from medyagh/guest_pro_docker
...
Unique exit code for when container exists prematurely
2021-05-25 12:40:04 -07:00
Ilya Zuyev
017bd42e17
update logs
2021-05-24 22:52:47 -07:00
Ilya Zuyev
4265887fa9
unpause before delete
2021-05-24 18:54:57 -07:00
Medya Ghazizadeh
b3541115b2
Merge pull request #11478 from sharifelgamal/error-codes
...
Add list of error codes to documentation
2021-05-24 15:25:58 -07:00
Medya Gh
6d8c001a00
spell
2021-05-21 13:57:37 -07:00
Medya Gh
9c9934879c
break guest provision when container exists prematurely
2021-05-21 13:34:34 -07:00
Medya Ghazizadeh
3f2170bb51
Merge pull request #11472 from andriyDev/ErrorCodes
...
Use DRV_NOT_HEALTHY when at least one driver is installed but unhealthy
2021-05-21 11:33:23 -07:00
Sharif Elgamal
e89aca810a
Add list of error codes to documentation
2021-05-21 11:07:59 -07:00
Andriy Dzikh
d59570c1f0
Add DRV_DOCKER_NOT_RUNNING error for cases where specifically docker fails.
2021-05-21 09:43:04 -07:00
Medya Ghazizadeh
d0d62a90e5
Merge pull request #11334 from daehyeok/close_asset
...
Add `Close() error` function into assets.CopyableFile
2021-05-21 09:23:41 -07:00
Utkarsh Srivastava
aa99526399
change variable name from addonList to addonListFlag
...
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-21 13:39:05 +05:30
Daehyeok Mun
d6691e796c
Add `Close() error` function into assets.CopyableFile
...
Add `Close` function and implemetions to explicitly close os.File which opend by
NewFileAsset.
2021-05-20 21:05:09 -07:00
Medya Ghazizadeh
b5499b4c2a
Merge pull request #11394 from ilya-zuyev/ilyaz/gh_11335_test_net_plugins_false_start
...
Skip network tests with disabled CNI for containerd/crio runtimes
2021-05-20 16:20:04 -07:00
Steven Powell
a60a6e215b
Merge pull request #11387 from vigothehacker/issue-11382
...
Use the first non flag argument for the log file name instead of the first argument
2021-05-20 15:51:33 -07:00
Ilya Zuyev
5600ee6755
Reorganize functional tests
2021-05-20 14:43:51 -07:00
Andriy Dzikh
b2d771cd89
Use unhealthy error code if no driver is picked and any driver is installed but unhealthy.
2021-05-20 14:03:53 -07:00
Utkarsh Srivastava
69b30c06df
change variable name from addonListName to addonList
...
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-20 22:25:38 +05:30
Utkarsh Srivastava
5a3843b074
replace addonList variable with viper provided data
...
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-20 21:39:07 +05:30
Ilya Zuyev
d185d765a1
update tests
2021-05-19 15:13:21 -07:00
Medya Ghazizadeh
72e8341536
Merge pull request #11431 from briandealwis/resume
...
Add "resume" as an alias for "unpause"
2021-05-19 15:04:35 -07:00
Ilya Zuyev
03600d9afc
Add integration test
2021-05-19 13:25:42 -07:00
Ilya Zuyev
039b727cb9
check if cni is not disabled for containerd/crio
2021-05-18 22:48:14 -07:00
Medya Ghazizadeh
e05cad71c4
Merge pull request #11355 from afbjorklund/driver-order
...
Sort rejected drivers by their preference order
2021-05-17 20:31:34 -07:00
Medya Ghazizadeh
cd73e832dd
Merge pull request #11371 from afbjorklund/driver-alternate
...
Fix error picking non-default alternate drivers
2021-05-17 18:54:43 -07:00
Medya Gh
f6a89cea06
goimport
2021-05-17 18:39:09 -07:00
Brian de Alwis
49fb17d9fc
Add "resume" as an alias for "unpause"
2021-05-17 18:34:11 -07:00
Anders F Björklund
6d0763648e
Keep original preference, for identical priority
...
Unhealthy drivers have their priority lowered
2021-05-16 09:31:37 +02:00
Anders F Björklund
dedfdfbfcf
Sort rejected drivers by their preference order
...
Don't show drivers not being selected by default
2021-05-15 09:41:12 +02:00
ilya-zuyev
2a2ffeb380
Merge pull request #11304 from daehyeok/copy_node
...
Implement target node option for cp command
2021-05-14 15:59:11 -07:00
Evan Baker
eca8a2d540
fix typo in flag documentation: sytemd -> systemd
...
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
2021-05-14 17:00:03 -05:00
Medya Ghazizadeh
33e26502dd
Merge pull request #11366 from spowelljr/fixImageLoad
...
`image load`: overwrite same image unless `--overwrite=false`
2021-05-13 21:18:29 -07:00
Daehyeok Mun
7c2e963392
Implement target node option for cp command
2021-05-13 10:47:09 -07:00
VigoTheHacker
a086536f38
Merge branch 'kubernetes:master' into issue-11382
2021-05-13 15:15:12 +05:30
Peixuan Ding
7b98243ea3
Add missing apiserver-names config update
2021-05-13 02:02:34 -04:00
Peixuan Ding
d156e5cbed
Fix TestKubernetesUpgrade
...
Signed-off-by: Peixuan Ding <pding@freewheel.com>
2021-05-12 21:35:22 -04:00
VigoTheHacker
5246729910
use global variables in logFileName
2021-05-13 06:44:57 +05:30
Steven Powell
9d3ee7e2e1
use overwrite flag for local images
2021-05-12 14:26:34 -07:00
Steven Powell
e59ced9029
updated flag description and renamed force arg to overwrite and made it non-optional
2021-05-12 14:26:34 -07:00
Steven Powell
826f1852ab
replace over-write with overwrite
2021-05-12 14:26:34 -07:00
Steven Powell
83366b7929
added over-write flag for image load
2021-05-12 14:26:32 -07:00
Steven Powell
32a91d6eb2
image load loads image even if name:tag already exists
2021-05-12 14:24:49 -07:00
VigoTheHacker
eca1d9e4f2
change the funnction param value from a global variable to a locally set variable
2021-05-12 23:58:35 +05:30
Anders F Björklund
6ea3ffee1f
Show suggestion for rejected unhealthy drivers
...
Normally how to add root permissions for the user, to be able to
run the "docker" or "podman" driver (through group or through sudo)
2021-05-12 07:15:26 +02:00
VigoTheHacker
5f3b63fb30
read the first non flag argument for the lag file name
2021-05-12 08:50:16 +05:30
Medya Ghazizadeh
c214b040e6
Merge pull request #11381 from sharifelgamal/test-doc
...
Make sure all tests have comments
2021-05-11 18:05:36 -07:00
Sharif Elgamal
8b67bf15e5
fix error message
2021-05-11 15:26:23 -07:00
Sharif Elgamal
971c74f381
fix spelling
2021-05-11 15:23:07 -07:00
Sharif Elgamal
972dae8133
Make sure all tests have comments
2021-05-11 15:17:43 -07:00
Medya Ghazizadeh
c136fe3cfd
Merge pull request #11060 from afbjorklund/retro-arch
...
Allow building minikube for outdated architectures
2021-05-11 12:22:03 -07:00
ilya-zuyev
1f2d50f297
Merge pull request #11247 from hex0punk/goroutine-leak-fix
...
Goroutine leak fix
2021-05-11 12:02:54 -07:00
Anders F Björklund
97b152f9a8
Fix error picking non-default alternate drivers
...
We should not select drivers like "ssh" or "none",
unless explicitly requested by the user. Wrong var...
2021-05-11 18:00:39 +02:00
Anders F Björklund
fb728a8893
Switch place of minikube image ls and list
...
Just to make it more similar to the docker image commands.
Both ls/list and rm/remove are equivalent commands, though.
2021-05-09 09:37:02 +02:00
Medya Ghazizadeh
8f167f4213
Merge pull request #10899 from daehyeok/overwrite_flag
...
Refactoring generate/update config file code.
2021-05-07 16:30:15 -07:00
Medya Ghazizadeh
a2d62511d2
Merge pull request #11191 from zhijianli88/shell-completion
...
completion: add specific shell completion
2021-05-07 16:16:54 -07:00
Daehyeok Mun
50637dd149
clean up `updateExistingConfigFromFlags` function.
...
Add missing flags to overwrite.
Reuse validate/set function from `generateNewClusterConfig`
2021-05-06 14:07:43 -07:00
Daehyeok Mun
afc9ed5222
Clean up `generateNewConfigFromFlags` function
...
split validate/set code with helper function to reuse later.
2021-05-06 14:07:43 -07:00
Medya Ghazizadeh
65692f3181
Merge pull request #11294 from andriyDev/UsernameMixin
...
Add the current user's name to log file hashes to prevent collision.
2021-05-06 10:22:46 -07:00
Andriy Dzikh
5776597eb3
Move deferred close to before error exit.
2021-05-05 16:18:15 -07:00
Andriy Dzikh
98f4d4706b
Add --file flag to 'minikube logs' to automatically put logs into a file.
2021-05-05 16:18:15 -07:00
Andriy Dzikh
65c0f0ff35
Add the current user's name to log file hashes to prevent collision.
2021-05-05 12:38:47 -07:00
Sharif Elgamal
e27e9a1e1b
return pointer to k8sissue
2021-05-03 12:25:17 -07:00
Sharif Elgamal
9dbe957234
Merge branch 'master' of github.com:kubernetes/minikube into warn-k8s
2021-05-03 12:22:34 -07:00
hex0punk
2474931ab3
prevents a goroutine from being leaked in call to readByteWithTimeout
2021-04-29 22:48:05 -07:00
hex0punk
f0226e50a9
Revert "prevents a goroutine from being leaked in call to readByteWithTimeout"
...
This reverts commit 8810120de6
.
2021-04-29 22:45:39 -07:00
hex0punk
8810120de6
prevents a goroutine from being leaked in call to readByteWithTimeout
2021-04-29 22:42:33 -07:00
Predrag Rogic
394def7a74
identify appropriate cni then configure cruntime accordingly
2021-04-29 23:36:46 +01:00
ilya-zuyev
9947c61a83
Merge pull request #11185 from prezha/workout-cni-and-cruntimes
...
improve how cni and cruntimes work together
2021-04-29 15:01:18 -07:00
Medya Ghazizadeh
ac2b98d744
Merge pull request #11169 from spowelljr/addBetaNotifications
...
Add opt-in notifications for beta releases
2021-04-29 14:03:59 -07:00
Li Zhijian
5943260780
completion: add specific shell completion
...
Previously, `minikube completion` is unable to auto-complete the
specific shell as other go-lang applications. For example, when user
type below command:
```
minikube$ minikube completion <tab> <tab>
```
In minikube, there is no candidate shells coming up, which is different
from kubectl:
```
$ kubectl completion <tab> <tab>
bash zsh
```
After this patch, as following, the candidata shell appears:
```
minikube$ minikube completion <tab> <tab>
bash fish zsh
```
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2021-04-29 18:30:27 +08:00
Sharif Elgamal
8657b72645
address comments
2021-04-28 17:29:28 -07:00
Sharif Elgamal
fb5f275baa
abstract kubernetes issues away
2021-04-28 16:01:59 -07:00
Steven Powell
c9ccfece9b
removed get prefix from funcs
2021-04-28 15:34:48 -07:00
Sharif Elgamal
7afe98b855
add 1.21.0
2021-04-28 08:59:15 -07:00
Sharif Elgamal
661e62aacd
warn about performance for certain versions of kubernetes
2021-04-27 13:54:06 -07:00
csiepka
ae450f6c7b
Correct typo in start_flags.go
...
Steps to reproduce the issue:
minikube start --memory=2G
Current Output (truncated):
smile minikube v1.14.1 on Linuxmint 19.3
sparkles Using the docker driver based on existing profile
exclamation You cannot change the memory size for an exiting minikube cluster. Please first delete the cluster.
Correction:
"exiting" to "existing" in output:
Expected output:
exclamation You cannot change the memory size for an existing minikube cluster. Please first delete the cluster.
2021-04-26 11:59:17 -07:00
Medya Ghazizadeh
cbe11ca8ff
Merge pull request #11003 from tklauser/x-term
...
Use golang.org/x/term
2021-04-25 22:56:14 -07:00
Medya Ghazizadeh
d6e011bf77
Merge pull request #10918 from afbjorklund/kicbase-cache
...
Add code for downloading kicbase image to cache
2021-04-25 22:25:06 -07:00
Predrag Rogic
e3b45667a6
improve how cni and cruntimes work together
2021-04-25 17:40:34 +01:00
Medya Ghazizadeh
41bbb4f6c5
Merge pull request #11164 from afbjorklund/build-rebase
...
Add re-implementation of the build command
2021-04-24 21:03:30 -07:00
Anders F Björklund
974268092f
Merge branch 'master' into kicbase-cache
2021-04-24 08:36:45 +02:00
Anders F Björklund
d50845903f
url.Parse treats DOS volumes as URL schemes
...
So need to be on the lookout for "C:\\path"
2021-04-23 23:04:30 +02:00
Steven Powell
29745438da
add opt-in notifications for beta releases
2021-04-22 14:35:19 -07:00
Andriy Dzikh
810f7ab108
Change 'minikube version --short' to only print the version without a prompt.
2021-04-21 19:01:55 -07:00
Anders F Björklund
943561b24d
Clean up the order of the image commands
2021-04-21 20:26:28 +02:00
Anders F Björklund
f7e07770c0
Clean up duplicated function etc after merge
2021-04-21 20:26:28 +02:00
Anders F Björklund
9516122d70
Add example parameters to the usage help text
2021-04-21 20:26:28 +02:00
Anders F Björklund
c961190ed8
Allow passing environ and options to build
2021-04-21 20:26:28 +02:00
Anders F Björklund
db203cd0e2
Allow building tarball from stdin stream
2021-04-21 20:26:28 +02:00
Anders F Björklund
9f9958f7ea
Allow building image from an url as well
2021-04-21 20:26:28 +02:00
Anders F Björklund
40cbe652ea
Improve comments and remove docker daemon
2021-04-21 20:26:28 +02:00
Anders F Björklund
02b4267fd0
Add option for pushing image to registry
2021-04-21 20:26:28 +02:00
Anders F Björklund
c94a6d7968
Make sure to pass any file param to build
2021-04-21 20:26:28 +02:00
Anders F Björklund
6cfbf2cc3d
Move minikube build cmd to minikube image build
...
Use the long name also for examples and usage
2021-04-21 20:26:28 +02:00
Anders F Björklund
9ef5d255d2
Add support for build directory and Dockerfile
...
Will create a temporary tarball, if given a dir
Some code from github.com/fsouza/go-dockerclient
(but not exported as a library, for some reason)
Upgrade docker client and cherry-pick windows
From v18.09.0 to v19.03.15, plus c3a0a37446
Update go-dockerclient and remove internal deps
2021-04-21 20:26:06 +02:00
Anders F Björklund
a2744827c3
Add some basic support for setting the image tag
2021-04-21 19:56:58 +02:00
Anders F Björklund
af5828dff9
Add initial re-implementation of the build command
...
Currently only handles tarballs, not directories
2021-04-21 19:56:55 +02:00
Tobias Klauser
112792fba0
Use golang.org/x/term
...
The golang.org/x/crypto/ssh/terminal package is deprecated and merely a
wrapper around golang.org/x/term. Thus, use the latter directly.
2021-04-21 12:50:48 +02:00
Anders F Björklund
ef036e9297
Mock the docker call when calling it from tests
2021-04-20 22:13:26 +02:00
Medya Ghazizadeh
f5035b5c28
Merge pull request #11122 from lilongfeng0902/minikube-lilf
...
Better to use "0777" than "0o777",instead of only in Go
2021-04-20 10:07:21 -07:00
李龙峰
84e7ea6d14
0777 better than 0o777
2021-04-20 15:04:44 +08:00
Anders F Björklund
a618655bb3
Make golint clean again by adding comments
2021-04-20 08:23:26 +02:00
李龙峰
0c093da67f
revert because of IDE bug
2021-04-20 08:56:17 +08:00
Medya Gh
1207de734b
bump golang lint ci to latest
2021-04-19 15:16:31 -07:00
Medya Ghazizadeh
d4c1c2a79f
Merge pull request #11127 from afbjorklund/image-pull
...
new command "image pull: allow to load remote images directly without cache
2021-04-19 14:57:48 -07:00
Anders F Björklund
d8050ee03c
Add documentation to the public image functions
2021-04-19 21:55:43 +02:00
Medya Ghazizadeh
19ea60f843
Merge pull request #11120 from sharifelgamal/gen-test-docs
...
site: Automatically generate integration test documentation
2021-04-19 12:40:40 -07:00
Anders F Björklund
9c1a4f4fc0
Allow to load remote images directly without cache
2021-04-19 20:24:06 +02:00
Anders F Björklund
fbef53209a
Add helper for runtime OS as well as for Arch
2021-04-18 12:51:30 +02:00
李龙峰
9cbfb9b841
filemode is not correct,0o777 to 0777
2021-04-17 10:08:28 +08:00
Sharif Elgamal
245f44da66
write to a file and move code around for clarity
2021-04-16 15:33:50 -07:00
Sharif Elgamal
1319b6e398
refactor checkRepository to make mocking easier
2021-04-14 12:51:16 -07:00
Sharif Elgamal
f95c0eb709
avoid network calls for mirror unit tests
2021-04-12 15:24:46 -07:00
Anders F Björklund
0d22fe24ae
Make lint happy by not using else statement
2021-04-10 16:00:00 +02:00
Anders F Björklund
bc62a9f1bd
Check for supported kubectl architecture too
2021-04-10 15:40:55 +02:00
Anders F Björklund
623b1a8639
Check for supported runtime architecture too
2021-04-10 15:30:17 +02:00
Anders F Björklund
1e3e8c9587
Only show the guest system, not the host system
2021-04-10 14:40:24 +02:00
Ilya Zuyev
193e4d5497
fix error message
2021-04-09 16:35:44 -07:00
Ilya Zuyev
6aa7e11923
fix imports
2021-04-08 11:50:03 -07:00
Ilya Zuyev
8d8f95305b
Merge branch 'master' into ilyaz/do_not_run_amd64_on_m1
2021-04-08 11:44:52 -07:00
Ilya Zuyev
b2aa1e56aa
make linter happy
2021-04-08 11:14:03 -07:00
Ilya Zuyev
9a3157950f
add download link
2021-04-08 10:25:12 -07:00
Medya Ghazizadeh
78288f87f3
Merge pull request #10976 from wangchenglong01/wangchl01
...
define a variable instead of duplicating "kube-system"
2021-04-07 18:05:27 -07:00
Ilya Zuyev
d1431f67a6
exit if run amd64 binary on M1 cpu
2021-04-07 15:44:03 -07:00
Medya Ghazizadeh
40d0f5ef06
Merge pull request #11014 from afbjorklund/config-memory
...
Respect memory being set in the minikube config
2021-04-07 15:27:14 -07:00
Medya Ghazizadeh
848a28db5f
Merge pull request #11007 from afbjorklund/list-images
...
Add ListImages function and image list command
2021-04-07 15:26:22 -07:00
Anders F Björklund
cc553bfb00
Fix broken unit tests encoding wrong result
2021-04-07 20:28:05 +02:00
Anders F Björklund
a757877392
Add new config generation to reduce complexity
2021-04-07 20:24:08 +02:00
Anders F Björklund
f672afe1d4
Fix wrong error message on memory validation
2021-04-07 20:02:46 +02:00
Anders F Björklund
25a98a2ebf
Respect memory being set in the minikube config
2021-04-07 19:58:09 +02:00
Anders F Björklund
35d8d4aa52
Add ListImages function and image list command
2021-04-06 22:57:34 +02:00
Medya Ghazizadeh
18dacff70f
Merge pull request #10958 from azhao155/yzhao/feature/AddAutoPauseInitiliazedStatus
...
auto-pause: initialize the pause state from the current state
2021-04-05 13:46:23 -07:00
Predrag Rogic
387ad774bb
multinode: fix kindnet and dns issues
2021-04-05 16:18:37 +01:00
Cookie Wang
006adc0530
define a variable instead of duplicating "kube-system"
2021-04-02 14:32:37 +08:00
Medya Ghazizadeh
2df898a50a
Merge pull request #10968 from MadhavJivrajani/master
...
Avoid logging 'kubeconfig endpoint' error when cluster is 'starting'
2021-04-01 09:57:30 -07:00
Kent Iso
14cde713bd
Fix unit test failing boilerplate, TestGenerateDocs
2021-04-01 21:22:05 +09:00
Madhav Jivrajani
7f1a33b6d0
avoid logging 'kubeconfig endpoint' error when cluster is 'starting'
...
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2021-04-01 10:24:34 +05:30
Anders F Björklund
ff23ccf318
Add constant for the ISO cache directory
2021-03-30 20:19:33 +02:00
Yanshu Zhao
93dad50a94
fix lint
2021-03-30 16:27:50 +00:00
Yanshu Zhao
837ff51c4a
Add initialization logic for auto-pause
2021-03-30 08:26:11 +00:00
Medya Ghazizadeh
0de446dc9e
Merge pull request #10792 from prezha/kvm-network
...
kvm2 driver: add dedicated network & static ip
2021-03-29 17:17:50 -07:00
Yanshu Zhao
fc7195cbe5
Replace glog with klog
2021-03-29 21:58:40 +00:00
Medya Gh
5f942518f5
lint master
2021-03-29 13:42:20 -07:00
Medya Ghazizadeh
660cc42e88
Merge pull request #10823 from azhao155/yzhao/feature/auto-hook
...
Add auto-pause webhook to inject env into pods for redirecting in-cluster kubectl request to reverse proxy of api server.
2021-03-29 09:53:14 -07:00
Medya Ghazizadeh
29f0aec44a
Merge pull request #10920 from anencore94/cp_window
...
Fix to minikube cp functional test work on windows os
2021-03-29 09:33:18 -07:00
Tharun
f022babe1e
refractored image command removeImages function
...
Signed-off-by: Tharun <rajendrantharun@live.com>
2021-03-29 10:56:13 +05:30
Predrag Rogic
06d4313f3f
kvm2 driver: add static ip
2021-03-27 23:33:24 +00:00
Predrag Rogic
fcc6283859
kvm2 driver: add dedicated network
2021-03-26 23:34:04 +00:00
Tharun
e37f8bc1a2
add unload as an alias and fixed parent command usage
...
Signed-off-by: Tharun <rajendrantharun@live.com>
2021-03-27 02:30:15 +05:30
anencore94
4f9aac3aa5
Fix to minikube cp functional test work on windows os
...
- use filpath lib to represent local path depends on host os
- write within-minikube-path as function to represent what
the path means
2021-03-26 15:26:03 +09:00
Tharun
82d7fcc65f
address log and docs feedback
...
Signed-off-by: Tharun <rajendrantharun@live.com>
2021-03-25 19:32:13 +05:30
Tharun
b9b657ca85
add minikube rm image command
...
Signed-off-by: Tharun <rajendrantharun@live.com>
2021-03-25 17:24:47 +05:30
Medya Ghazizadeh
77c6de357d
Merge pull request #10807 from afbjorklund/load-new
...
Image load: Allow loading local images from tar or cache
2021-03-24 17:50:03 -07:00
Tharun
628a4a8319
not mention timeToStop in status instead of showing NonExistent
...
Signed-off-by: Tharun <rajendrantharun@live.com>
2021-03-24 11:37:57 +05:30
Medya Ghazizadeh
f567893cdb
Merge pull request #10872 from tharun208/feat/docker_env_status
...
add docker-env and podman-env to minikube status
2021-03-23 20:44:11 -07:00
Medya Ghazizadeh
3e869e0b7c
Merge pull request #10198 from anencore94/minikube-scp
...
Add minikube cp command as new feature
2021-03-23 12:43:02 -07:00
Tharun
d72eea61c9
add test for docker-env status check and fix feedbacks
...
Signed-off-by: Tharun <rajendrantharun@live.com>
2021-03-23 23:25:38 +05:30
Tharun
2779ec021b
add docker-env and podman-env to minikube status
...
Signed-off-by: Tharun <rajendrantharun@live.com>
2021-03-23 22:24:04 +05:30
Yanshu Zhao
14ec53f29f
Fix typo
2021-03-23 15:39:04 +00:00
Anders F Björklund
e35057ae7d
Use accessor methods instead of just variables
2021-03-23 12:34:57 +01:00
Medya Ghazizadeh
f39a3c1504
Merge pull request #10425 from bharathkkb/fix-multiple-log-files
...
Generate one log file per minikube command
2021-03-23 00:54:10 -07:00
Yanshu Zhao
9ea99ae129
Add skip into label object of web hook, clean up code
2021-03-23 07:03:42 +00:00
Anders F Björklund
e064eb13fd
Merge branch 'master' into load-new
2021-03-23 07:02:50 +01:00
Medya Ghazizadeh
18c1cc2ee0
Merge pull request #10878 from daehyeok/rootless_docker
...
Add solution message if Docker is rootless
2021-03-22 18:57:52 -07:00
Medya Ghazizadeh
7a47f16eec
Merge pull request #10844 from afbjorklund/kubectl-ssh
...
Allow running kubectl over the ssh connection
2021-03-22 18:45:45 -07:00
Anders F Björklund
1ab1eada29
Cleanup the weird-looking comment indentation
2021-03-22 20:54:47 +01:00
Anders F Björklund
fd4a62f77f
Make it possible to choose daemon or remote
2021-03-22 20:49:15 +01:00
Anders F Björklund
e1eaeba691
Fix whitespace to make goimports happy
2021-03-22 20:43:16 +01:00
Daehyeok Mun
9b23841ee3
Add solution message if Docker is rootless
2021-03-20 13:20:30 -07:00
Anders F Björklund
e7f568a9d2
Make --help work when running minikube as kubectl
...
Avoid the "magic" cobra.Command parsing of --help,
and pass all flags as-is to the kubectl command.
Use "minikube kubectl" if you want to set flags,
and "kubectl" if you just want to run Kubernetes.
2021-03-18 07:19:46 +01:00
Anders F Björklund
c552a1e754
Make the example with --help not broken again
2021-03-17 20:22:39 +01:00
Anders F Björklund
2df5215960
Add more help text about using the ssh option
2021-03-17 20:17:56 +01:00
Yanshu Zhao
107331275c
Add template for reverse proxy ip
2021-03-17 18:52:55 +00:00
Yanshu Zhao
839aacf580
polish the code
2021-03-17 08:18:36 +00:00
Yanshu Zhao
923a6247a2
fix lint
2021-03-17 02:43:48 +00:00
Anders F Björklund
eea380fc0e
Add example parameters to the usage help text
2021-03-16 19:36:59 +01:00
Anders F Björklund
3e4a0202cb
Allow loading image from standard input stream
2021-03-16 19:35:58 +01:00
Anders F Björklund
78bc248a89
Allow running kubectl over the ssh connection
...
The default is to run kubernetes client locally
2021-03-16 07:45:17 +01:00
Anders F Björklund
eec6f05ce0
Don't use the generic path name for a variable
...
It conflicts with the system "path" in module
2021-03-16 07:29:14 +01:00
Steven Powell
a369264139
removed isClusterRunning check
2021-03-15 16:41:22 -07:00
Steven Powell
3e38a1954a
renamed OutputMinikubeLogs to OutputOffline
2021-03-15 16:33:39 -07:00
Steven Powell
eb8f7e65b9
Show last start and audit logs on `minikube logs` if minikube not running
2021-03-15 15:43:11 -07:00
Yanshu Zhao
4072ea7a93
Add header file
2021-03-15 06:37:06 +00:00
Yanshu Zhao
91f9bd6ef9
Add webhook to inject env to redirect inner cluster requests to haproxy
...
in auto-pause
2021-03-15 05:56:44 +00:00
Anders F Björklund
ea1d023c8a
Allow loading more than one image at a time
...
They need to all be cached or all be local, though.
If one appears to be local, then assume that all are.
2021-03-13 14:43:18 +01:00
Anders F Björklund
0d99d18803
Allow loading local images as well as from cache
...
Previously only allowed loading from daemon or remote
via the cache, and not directly from local tarball.
2021-03-13 14:43:15 +01:00
Medya Ghazizadeh
ff0e25ada8
Merge pull request #10793 from afbjorklund/kubectl-cluster
...
minikube kubectl: The --cluster flags should be prepended
2021-03-12 14:18:21 -08:00
Medya Gh
67172b636c
break down usage for no profile found
2021-03-12 12:29:23 -08:00
Anders F Björklund
e8a35de28e
The --cluster flags should be prepended
...
Not appended, because it will break exec
2021-03-12 08:39:41 +01:00
jjkiely
e2d08bbd06
Updated more information section of validateChangedMemoryFlags function with correct, working link
2021-03-11 16:19:15 +00:00
Medya Ghazizadeh
5147ef3554
Merge pull request #10730 from sharifelgamal/auth-gce
...
auto-detect gce and do not enable gcp auth addon
2021-03-10 15:26:34 -08:00
Medya Ghazizadeh
b3b4807ed8
Merge pull request #10760 from yxxhero/master
...
add validateImageRepository func for validates --image-repository args
2021-03-10 13:30:44 -08:00
Medya Ghazizadeh
df7cb644af
Merge pull request #10763 from afbjorklund/silent-shell
...
Silent output when talking to a shell
2021-03-10 13:26:41 -08:00
yxxhero
f65333730c
add unittest for validateImageRepository and optimize validateImageRepository
2021-03-10 13:28:43 +08:00
Medya Ghazizadeh
05bc047dd1
Merge pull request #10732 from afbjorklund/kubectl-mustload
...
The cluster doesn't have to be healthy for kubectl
2021-03-09 16:46:03 -08:00
Medya Ghazizadeh
5beacff48f
Merge pull request #10734 from afbjorklund/kubectl-crash
...
Need to exit if unable to cache kubectl
2021-03-09 16:45:26 -08:00
Sharif Elgamal
a3544ae90a
create detect package
2021-03-09 15:11:54 -08:00
Sharif Elgamal
15c44bf7ac
reorganize addons to make force flag more generic
2021-03-09 13:32:09 -08:00
Anders F Björklund
5e566d3039
Silent output when talking to a shell
...
If the output is not a terminal, then assume that we are running
docker-env or podman-env under "eval" or similar shell construct.
So don't output all the interactive information, but only return
the actual exit code for some further troubleshooting (perhaps).
2021-03-09 17:59:26 +01:00
yxxhero
416f92a8b5
add validateImageRepository func for validates --image-repository args
2021-03-09 13:47:36 +08:00
Sharif Elgamal
e6cb33fa6d
oh dear global variable
2021-03-08 12:15:05 -08:00
Sharif Elgamal
d12afd6ae5
Merge branch 'master' of github.com:kubernetes/minikube into auth-gce
2021-03-08 12:07:28 -08:00
Sharif Elgamal
5a5abedb3e
support force in addons enable command
2021-03-08 08:47:39 -08:00
anencore94
109b1e0fe2
make cp commmand allow target path as absolutepath
...
- only absolute path is allowed
Signed-off-by: anencore94 <anencore94@kaist.ac.kr>
2021-03-08 10:51:15 +09:00
anencore94
76f3c72e82
[Feature] Add minikube cp command
...
- add new feature represents cp local file into minikube
- add functional test for cp command
Signed-off-by: anencore94 <anencore94@kaist.ac.kr>
2021-03-08 10:51:15 +09:00
Medya Ghazizadeh
3760bf765e
Merge pull request #10735 from Loyen/correct-message-spelling
...
Correct spelling in --insecure-registry validation error message
2021-03-06 14:30:55 -08:00
Patrik Freij
a39238ece2
Correct spelling of "Expected formats"
2021-03-06 13:30:02 +01:00
Anders F Björklund
d5a69dc10e
Need to exit if unable to cache kubectl
2021-03-06 13:00:27 +01:00
Anders F Björklund
eb89c8a56f
Use the default k8s version if there is no profile
...
The "mustload" module will abort without a profile
2021-03-06 12:42:00 +01:00
Anders F Björklund
651c81df14
The cluster doesn't have to be healthy for kubectl
...
We only want to match the kubectl version with it
2021-03-06 09:48:04 +01:00
Medya Ghazizadeh
0f4405798a
Merge pull request #10712 from prezha/kvm-check-libvirt-perms
...
kvm: provide solution if user doesn't belong to libvirt group
2021-03-05 22:19:32 -08:00
Medya Ghazizadeh
d2cb052fca
Merge pull request #10653 from Loyen/add-listen-address-flag
...
Add flag "--listen-address" for docker and podman driver
2021-03-05 12:56:22 -08:00
Predrag Rogic
c3cd3bc500
kvm: check if user belongs to libvirt group
2021-03-04 01:33:01 +00:00
Steven Powell
cf23cb12cc
changed one more Styled back to Step
2021-03-02 17:23:43 -07:00
Steven Powell
a2989a119e
reverted actions from Styled to Step
2021-03-02 17:23:43 -07:00
Steven Powell
e9d16eb42d
replaced non-step logging with Styled
2021-03-02 17:23:43 -07:00
Patrik Freij
29a7145e9d
Add podman support for --listen-address
2021-03-02 20:59:27 +01:00
phantooom
529881e01c
fix: fix kvm2 numa simulate ut&lint
2021-03-02 22:40:42 +08:00
phantooom
badc5d4532
add more check for kvm2 support simulate numa node
2021-03-02 22:27:26 +08:00
phantooom
e11f23a4c9
kvm2 driver support simulate numa node
2021-03-02 22:27:26 +08:00
Patrik Freij
21636a5466
Move docker only flag to its own area
...
Confusing to keep it under "docker & podman" when it's only for docker.
2021-03-01 21:52:42 +01:00
Patrik Freij
ca81de183f
Add --listen-address validation
2021-03-01 21:08:59 +01:00
bharathkkb
015b721f17
feat: add default log_file name
...
add max log size, add tests, update website docs
fix func comments
address comments
fix docs
fail fast
add tests to TestErrorSpam, switch to using log
2021-02-28 17:12:22 -06:00
Patrik Freij
98633b7e55
Remove unnecessary fmt.Sprintf usage
2021-02-28 23:30:26 +01:00
Patrik Freij
cb116e4c1c
Add --listen-address for docker driver
2021-02-28 23:14:08 +01:00
Priya Wadhwa
fd506460b3
Add README for mkcmp
2021-02-26 13:00:19 -08:00
Medya Ghazizadeh
abb403645e
Merge pull request #10617 from ariesliuwei/logche
...
migrate some logs to structured logging
2021-02-25 11:32:10 -08:00
Medya Ghazizadeh
80219cfa70
Merge pull request #10616 from ariesliuwei/logmod
...
Migrate kubectl logs to structured logging
2021-02-25 11:31:30 -08:00
Medya Ghazizadeh
33146eac8e
Merge pull request #10615 from ariesliuwei/ari-logfix
...
Migrate kubectl logs to structured logging
2021-02-25 11:30:50 -08:00
liuwei10
5788d43116
Migrate some logs to structured logging
2021-02-25 18:59:21 +08:00
liuwei10
6ea237047b
Migrate kubectl logs to structured logging
2021-02-25 18:47:40 +08:00
liuwei10
f939910a94
Migrate kubectl logs to structured logging
2021-02-25 17:41:38 +08:00
Medya Ghazizadeh
828769b816
Merge pull request #10606 from spowelljr/fixOutOfRange
...
Check for args length to prevent out of bounds panic
2021-02-24 16:33:09 -08:00
Steven Powell
c50bdaabfe
Check for args length to prevent out of bounds panic
2021-02-24 16:45:24 -07:00
Medya Gh
4a6f00ba4b
add todo with issue numbers
2021-02-24 13:15:36 -08:00
Medya Gh
73772286eb
address review comments
2021-02-24 13:07:25 -08:00
Medya Gh
1bd0b6daae
add final touch
2021-02-24 12:30:06 -08:00
Medya Gh
a162f26f4a
spell
2021-02-24 12:30:06 -08:00
Medya Gh
8739e20fef
update addon name
2021-02-24 12:30:06 -08:00
Medya Gh
21d9f50e9c
adding channels
2021-02-24 12:30:06 -08:00
Medya Gh
191e116d04
autopause prototype
2021-02-24 12:30:06 -08:00
Medya Gh
44a256bc53
add auto-pause binary
2021-02-24 12:30:06 -08:00
Medya Ghazizadeh
460342a5f2
Merge pull request #10575 from hetong07/issue_10519
...
Improve the error message of setting cgroup memory limit.
2021-02-24 11:53:54 -08:00
Steven Powell
34db47e956
Merge pull request #10465 from spowelljr/addLastStart
...
Add last start logs to minikube logs output
2021-02-24 10:52:26 -07:00
priyawadhwa
57d33de86a
Merge pull request #10554 from afbjorklund/drivers-default
...
Don't select Discouraged or Obsolete by default
2021-02-23 17:21:23 -08:00
priyawadhwa
2ef49ae05c
Merge pull request #10321 from BLasan/issue-8040
...
Move DeletePossibleKicLeftOver function to delete pkg
2021-02-23 17:15:50 -08:00
hetong07
56cf965a7b
Rename validateMemoryFlags() -> validateChangedMemoryFlags().
2021-02-23 16:16:22 -08:00
Steven Powell
f0902d4ba5
improved func comment
2021-02-23 16:54:00 -07:00
Steven Powell
7098409bdc
optimized file/dir creation logic
2021-02-23 16:51:40 -07:00
Steven Powell
48652fa952
moved import comment
2021-02-23 15:12:21 -07:00
Steven Powell
6794f2055d
removed duplicate flag check
2021-02-23 15:04:56 -07:00
Steven Powell
b42f8f6af2
Create logs directory if it does not exist
2021-02-23 15:03:04 -07:00
hetong07
abe7d71aee
Only validate cgroup memory setting when using container as driver.
2021-02-22 23:14:17 -08:00
hetong07
9a30756d38
Improve the error message of setting cgroup memory limit.
2021-02-22 20:18:22 -08:00
Anders F Björklund
4e4a59901c
Don't select Discouraged or Obsolete by default
...
These drivers require either an active choice (opt-in),
or a previous configuratio (for the warning message).
2021-02-21 18:18:43 +01:00
BLasan
03ae2d2aa3
Fix Rsrc Insufficient System memory issue
2021-02-21 22:46:23 +05:30
Medya Ghazizadeh
9d9aeccf23
Merge pull request #10535 from BLasan/issue-10143
...
Fix minikube kubectl context switching
2021-02-20 10:06:05 -08:00
BLasan
01d47d6141
Fix minikube kubectl context switching
2021-02-20 16:37:15 +05:30
Medya Ghazizadeh
77e9751229
Merge pull request #10493 from kadern0/issue-8790
...
Improved insecure registry validation function
2021-02-19 16:22:00 -08:00
Steven Powell
610a97067f
Fixed failing if lastStart.txt file does not exist
2021-02-19 13:54:10 -07:00
Steven Powell
f390d1ef0b
Output last start logs during minikube logs
2021-02-19 13:54:02 -07:00
Steven Powell
91e8c0980b
Save start logs to lastStart.txt in minikube dir
2021-02-19 13:51:44 -07:00
Pablo Caderno
6934c85451
Improved insecure registry validation function
2021-02-17 18:06:00 +11:00
Medya Ghazizadeh
27d86a421f
Merge pull request #10388 from BLasan/issue-10386
...
Add condition to check --cpus count with available cpu count
2021-02-12 12:48:33 -08:00
Medya Ghazizadeh
350f8a2494
Merge pull request #10452 from ilya-zuyev/ilyaz/disable_hyperv_on_m1
...
Disable all drivers except "docker" and "ssh" on darwin/arm64
2021-02-11 17:10:10 -08:00
BLasan
5c5c2169bc
Rename profile.go file as delete.go
2021-02-12 00:13:41 +05:30
BLasan
bb80fe355a
Rebase changes in PR #10332
2021-02-12 00:13:41 +05:30
BLasan
707e2e969b
Move DeletePossibleKicLeftOver function to profile pkg
2021-02-12 00:10:52 +05:30
Medya Ghazizadeh
3512e88020
Merge pull request #10435 from afbjorklund/podman-cleanup
...
Explicitly remove podman volume and network
2021-02-11 10:27:50 -08:00
Ilya Zuyev
a99d545a54
Fix "The driver {{.driver}} is not supported on {{.os}}/{{.arch}}" message
2021-02-10 17:06:20 -08:00
Ilya Zuyev
3caf9c0f05
Fix "The driver {{.driver}} is not supported on {{.os}}/{{.arch}}" message
2021-02-10 17:05:16 -08:00
Medya Ghazizadeh
a3609d3778
Merge pull request #10380 from daehyeok/profile_list_light
...
Add -l/--light option for profile list command.
2021-02-10 17:04:39 -08:00
Ilya Zuyev
af5b44df12
Fix "The driver {{.driver}} is not supported on {{.os}}/{{.arch}}" message
2021-02-10 17:03:53 -08:00
Medya Ghazizadeh
984b079821
Merge pull request #10412 from sharifelgamal/crio
...
remove crio restart hack
2021-02-10 16:55:44 -08:00
Ilya Zuyev
7536f4436c
Fix build constraints
2021-02-10 16:15:28 -08:00
Ilya Zuyev
d7beb72025
disable hyperkit driver on arm64
2021-02-10 13:47:46 -08:00
Anders F Björklund
b7de621033
Explicitly remove podman volume and network
...
The --filter and --label functionality was broken,
in earlier versions of podman (before version 3.0)
2021-02-10 20:57:20 +01:00
priyawadhwa
09de7ff62f
Merge pull request #10332 from priyawadhwa/delete-timeout
...
Add 5 minute timeout to deleting a profile
2021-02-10 10:40:32 -08:00
Daehyeok Mun
f457bde02d
Add -l/--light option for profile list command.
...
If option is true, Doens't try to get profiles from container and read
current status.
2021-02-09 16:06:09 -08:00
priyawadhwa
51ec098b05
Merge pull request #10366 from priyawadhwa/mk-image-load
...
Implement minikube image load command
2021-02-09 14:42:31 -08:00
Priya Wadhwa
e8945f2934
Add warning for cache add
2021-02-09 13:36:40 -08:00
Priya Wadhwa
6ed56d842e
Rename to delCtx
2021-02-09 10:51:51 -08:00
Sharif Elgamal
57ffa272c9
remove crio restart hack
2021-02-08 16:28:05 -08:00
Priya Wadhwa
53dad6a4ae
fix log
2021-02-08 15:26:04 -08:00
Priya Wadhwa
8f02a5851e
Time everything via context
2021-02-08 15:24:41 -08:00
Priya Wadhwa
51169d68ea
Add context to remaining necessary functions
2021-02-08 15:19:01 -08:00
Priya Wadhwa
a6372b35a3
Add 5 minute timeout to deleting leftover cvolumes and containers
2021-02-08 15:15:08 -08:00
Priya Wadhwa
9b147f788d
Merge branch 'master' of https://github.com/kubernetes/minikube into delete-timeout
2021-02-08 14:56:13 -08:00
BLasan
948178711b
Add advice message to increase cpus
2021-02-08 23:22:48 +05:30
Medya Ghazizadeh
1c8944f790
Merge pull request #10395 from govargo/fix-metallb-addon
...
Fix configuration of the metallb with empty load balancing IP range
2021-02-08 09:12:48 -08:00
Medya Ghazizadeh
262d102ceb
Merge pull request #10354 from hetong07/issue_10311
...
Provide advice when running windows binary (.exe) inside WSL
2021-02-08 09:05:54 -08:00
hetong07
bdac73d2fd
Put the environment check as a separate if-else clause, and make this check as early as possible.
2021-02-07 17:37:01 -08:00
Kent Iso
b1030dc28a
Fix configuration of the metallb with empty load balancing IP range
2021-02-07 23:43:05 +09:00
BLasan
cc2bf6aa15
Add condition to check --cpus count with available cpu count
2021-02-07 01:08:08 +05:30
Priya Wadhwa
9a9c160b3f
Move load test into functional test
2021-02-05 14:28:25 -08:00
Priya Wadhwa
22a65a0c12
Add --all flag to
2021-02-05 10:48:08 -08:00
Priya Wadhwa
0061d72be6
Merge branch 'master' of https://github.com/kubernetes/minikube into mk-image-load
2021-02-05 10:24:23 -08:00
Priya Wadhwa
1d63f085e4
Add command
2021-02-04 14:45:27 -08:00
hetong07
6d8804e10e
Use the 'ExProgramUnsupported' as the error code for MK_WRONG_BINARY_WSL error.
2021-02-03 18:29:13 -08:00
hetong07
547f506701
Rephrase the adivce, use the runtime.GOOS to check whether it is .exe binary and modify the error name to address comments in pull request.
2021-02-03 18:06:05 -08:00
hetong07
289bf2fe84
Merge branch 'master' into issue_10311
2021-02-03 17:41:15 -08:00
ilya-zuyev
a7489c1bba
Merge pull request #10309 from afbjorklund/ssh-address
...
Make sure that ssh driver gets an ip address
2021-02-03 11:17:07 -08:00
hetong07
ad08087b44
Allow user to use --force to run windows binary inside WSL.
2021-02-02 23:48:14 -08:00
Priya Wadhwa
0a0f39a112
Implement minikube image load command
2021-02-02 15:47:07 -08:00
Medya Ghazizadeh
d97418828d
Merge pull request #10119 from daehyeok/profile_name
...
Don't allow profile names that conflict with a multi-node name
2021-02-02 15:12:57 -08:00
Anders F Björklund
21206402a9
Check that the ssh-ip-address is a valid IP
2021-02-02 08:36:05 +01:00
Priya Wadhwa
4bda151a62
Fix delete var
2021-02-01 12:47:46 -08:00
Priya Wadhwa
d02eabb835
Add 2 minute timeout to deleting a profile
2021-02-01 12:44:43 -08:00
hetong07
276ad6c7c7
First step to address #10311 : disallow running minikube.exe insided WSL.
2021-01-31 12:34:05 -08:00
Anders F Björklund
f94cb815cf
Make sure that ssh driver gets an ip address
2021-01-29 17:12:23 +01:00
Daehyeok Mun
a00d632930
Check profile, node name to prevent duplication
...
Check profile and node name before add to prevent conflict with
machine name on multinode cluster.
2021-01-28 14:42:40 -08:00
Ling Samuel
101d39fc51
Addon custom registry:
...
* fix missing suffix when using global image repo
* support override global image repo
* change all imagePullPolicy to IfNotPresent
* fix empty global image repo suffix
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-27 10:33:08 +08:00
Ling Samuel
52f0e49a1e
Fix docker.io/ prefix
...
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-27 10:33:07 +08:00
Ling Samuel
de3c901c18
Implement all addons
...
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-27 10:33:07 +08:00
Ling Samuel
b949034e1a
Manage addon images in code, support custom addon images
...
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-27 10:33:00 +08:00