kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Replace InternalEnable and InternalDisable with InternalAddonEnable and InternalAddonDisable

pull/11800/head
Rajwinder Mahal 2021-06-28 18:27:28 -07:00
parent 65d5179a0f
commit 659e8c2785
No known key found for this signature in database
GPG Key ID: 86D607CAFD33BCD2
3 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/minikube/cmd/config/disable.go
View File

@ -40,7 +40,7 @@ var addonsDisableCmd = &cobra.Command{
}
err := addons.SetAndSave(ClusterFlagValue(), addon, "false")
if err != nil {
exit.Error(reason.InternalDisable, "disable failed", err)
exit.Error(reason.InternalAddonDisable, "disable failed", err)
}
out.Step(style.AddonDisable, `"The '{{.minikube_addon}}' addon is disabled`, out.V{"minikube_addon": addon})
},

2
cmd/minikube/cmd/config/enable.go
View File

@ -49,7 +49,7 @@ var addonsEnableCmd = &cobra.Command{
viper.Set(config.AddonRegistries, registries)
err := addons.SetAndSave(ClusterFlagValue(), addon, "true")
if err != nil {
exit.Error(reason.InternalEnable, "enable failed", err)
exit.Error(reason.InternalAddonEnable, "enable failed", err)
}
if addon == "dashboard" {
tipProfileArg := ""

8
pkg/minikube/reason/reason.go
View File

@ -74,7 +74,9 @@ var (
// minikube failed to create a new Docker Machine api client
NewAPIClient = Kind{ID: "MK_NEW_APICLIENT", ExitCode: ExProgramError}
// minikube could not enable an addon, e.g dashboard addon
// minikube could not disable an addon, e.g. dashboard addon
InternalAddonDisable = Kind{ID: "MK_ADDON_DISABLE", ExitCode: ExProgramError}
// minikube could not enable an addon, e.g. dashboard addon
InternalAddonEnable = Kind{ID: "MK_ADDON_ENABLE", ExitCode: ExProgramError}
// minikube failed to update internal configuration, such as the cached images config map
InternalAddConfig = Kind{ID: "MK_ADD_CONFIG", ExitCode: ExProgramError}
@ -96,12 +98,8 @@ var (
InternalConfigView = Kind{ID: "MK_CONFIG_VIEW", ExitCode: ExProgramError}
// minikybe failed to delete an internal configuration, such as a cached image
InternalDelConfig = Kind{ID: "MK_DEL_CONFIG", ExitCode: ExProgramError}
// minikube failed to disable a minikube addon
InternalDisable = Kind{ID: "MK_DISABLE", ExitCode: ExProgramError}
// minikube failed to generate script to activate minikube docker-env
InternalDockerScript = Kind{ID: "MK_DOCKER_SCRIPT", ExitCode: ExProgramError}
// minkube failed to enable a minikube addon
InternalEnable = Kind{ID: "MK_ENABLE", ExitCode: ExProgramError}
// an error occurred when viper attempted to bind flags to configuration
InternalBindFlags = Kind{ID: "MK_BIND_FLAGS", ExitCode: ExProgramError}
// an error occurred when setting cofniguration flags (currently not in use)