Commit Graph

13114 Commits (7b385600fd08165ab645b0cfe2fcd75bf47603f5)

Author SHA1 Message Date
kodiakhq[bot] 7b385600fd
Merge pull request #8305 from influxdata/savage/await-enqueue-rotation-returned-receiver-during-shutdown
fix(ingester): Graceful shutdown must wait for file rotation receiver
2023-07-24 09:22:52 +00:00
kodiakhq[bot] 0ed4e8509b
Merge branch 'main' into savage/await-enqueue-rotation-returned-receiver-during-shutdown 2023-07-24 09:17:55 +00:00
dependabot[bot] 79bb1347e6
chore(deps): Bump sysinfo from 0.29.5 to 0.29.6 (#8311)
Bumps [sysinfo](https://github.com/GuillaumeGomez/sysinfo) from 0.29.5 to 0.29.6.
- [Changelog](https://github.com/GuillaumeGomez/sysinfo/blob/master/CHANGELOG.md)
- [Commits](https://github.com/GuillaumeGomez/sysinfo/commits)

---
updated-dependencies:
- dependency-name: sysinfo
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-24 08:40:05 +00:00
Marco Neumann 748e66731c
feat: batch partition catalog requests in querier (take 2) (#8299)
* feat: batch partition catalog requests in querier

This is mostly wiring that builds on top of the other PRs linked to #8089.

I think we eventually could make the batching code nicer by adding
better wrappers / helpers, but lets do that if we have other batched
caches and this patterns proofs to be useful.

Closes #8089.

* test: extend `test_multi_get`

* test: regression test for #8286

* fix: prevent auto-flush CPU looping

* fix: panic when loading different tables at the same time

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-24 08:24:10 +00:00
dependabot[bot] b2179e2f8b
chore(deps): Bump clap from 4.3.17 to 4.3.19 (#8310)
Bumps [clap](https://github.com/clap-rs/clap) from 4.3.17 to 4.3.19.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/clap-rs/clap/compare/v4.3.17...v4.3.19)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-24 08:11:17 +00:00
dependabot[bot] 30ac7d86eb
chore(deps): Bump tower-http from 0.4.2 to 0.4.3 (#8298)
Bumps [tower-http](https://github.com/tower-rs/tower-http) from 0.4.2 to 0.4.3.
- [Release notes](https://github.com/tower-rs/tower-http/releases)
- [Commits](https://github.com/tower-rs/tower-http/compare/tower-http-0.4.2...tower-http-0.4.3)

---
updated-dependencies:
- dependency-name: tower-http
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-21 21:08:33 +00:00
Joe-Blount 58f79ddf47
Merge pull request #8308 from influxdata/jrb_70_stuck
fix: avoid compacting 1 L0 to 1 L0 file (stuck looping)
2023-07-21 14:41:56 -05:00
Joe-Blount 7622358518 fix: avoid compacting 1 L0 to 1 L0 file (stuck looping) 2023-07-21 13:55:04 -05:00
Martin Hilton b1c695d5a2
fix(influxql): fill count aggregates with 0 by default (#8284)
* chore: update expected output for `COUNT` aggregates with `FILL(null)`

See #8232

* fix(influxql): fill count aggregates with 0 by default

When gap-filling a COUNT aggregate any missing rows should be filled
with 0, unless otherwise directed by a FILL clause. To do this the
projection on the aggregate plan is modiefied to coalesce any COUNT
fields with 0 unless a FILL value has been specified in the query.

* chore: add more tests

* chore: add explanation of COUNT gap filling with multiple measurements

* fix: update test introduced with merge

---------

Co-authored-by: Stuart Carnie <stuart.carnie@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-21 16:31:10 +00:00
Martin Hilton 5731e012bf
fix(influxql): advanced syntax window functions with selector aggregates (#8303)
Ensure that advanced syntax window functions that contain a selector,
rather than an aggregate, function are considered valid and generate
a correct plan.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-21 14:48:15 +00:00
kodiakhq[bot] 2a658ec0ab
Merge pull request #8289 from influxdata/cn/cleanups
fix: Clean up some comments and unused imports that were allowed
2023-07-21 13:27:37 +00:00
kodiakhq[bot] 76ecfcc815
Merge branch 'main' into cn/cleanups 2023-07-21 13:22:50 +00:00
Carol (Nichols || Goulding) 3ac0e30ac9
fix: Remove namespace ID from a partition identifier type (#8288)
I'm going to make a change in the future that removes the access to the
namespace ID from this code, and it's not needed anyway as partitions
are uniquely identifiable by only table ID and partition key.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-21 13:22:33 +00:00
Fraser Savage a14afafcd9
Merge branch 'main' into savage/await-enqueue-rotation-returned-receiver-during-shutdown 2023-07-21 12:45:55 +01:00
Fraser Savage 6347d833e7
fix(ingester): Graceful shutdown must wait for file rotation receiver
This adds a second level of wait to the WAL draing & rotate before
allowing shutdown to proceed. Only once the returned receiver has
notified the called that the notification has been handled may it await
the empty waker set.
2023-07-21 12:31:04 +01:00
Andrew Lamb 3eb48ef210
chore: Update datafusion again (#8247)
* chore: Update datafusion to get new grouping

* chore: Update for new API

* chore: update tests

* fix: new API

* fix: state type

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-21 11:20:36 +00:00
Andrew Lamb ac9d1946e9
fix: add retry loop to avoid CI flake in build-catalog test (#8271)
* fix: add retry loop to avoid CI flake in build-catalog test

* fix: Update influxdb_iox/tests/end_to_end_cases/debug.rs

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-21 10:14:06 +00:00
dependabot[bot] 0d0f07b34e
chore(deps): Bump tempfile from 3.6.0 to 3.7.0 (#8297)
* chore(deps): Bump tempfile from 3.6.0 to 3.7.0

Bumps [tempfile](https://github.com/Stebalien/tempfile) from 3.6.0 to 3.7.0.
- [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Stebalien/tempfile/compare/v3.6.0...v3.7.0)

---
updated-dependencies:
- dependency-name: tempfile
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: Run cargo hakari tasks

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: CircleCI[bot] <circleci@influxdata.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-21 09:06:34 +00:00
dependabot[bot] 867937157c
chore(deps): Bump num-traits from 0.2.15 to 0.2.16 (#8296)
Bumps [num-traits](https://github.com/rust-num/num-traits) from 0.2.15 to 0.2.16.
- [Changelog](https://github.com/rust-num/num-traits/blob/master/RELEASES.md)
- [Commits](https://github.com/rust-num/num-traits/compare/num-traits-0.2.15...num-traits-0.2.16)

---
updated-dependencies:
- dependency-name: num-traits
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-21 09:00:43 +00:00
Joe-Blount 732ae81f0b
Merge pull request #8290 from influxdata/jrb_67_update_new_file_at_for_l2
fix: update new_file_at following all compactions
2023-07-20 14:13:04 -05:00
Joe-Blount 629f9d20db fix: update new_file_at following all compactions 2023-07-20 13:27:54 -05:00
Carol (Nichols || Goulding) 3dd29384ed
fix: Remove unneeded allow unused_imports and remove unused imports 2023-07-20 14:20:55 -04:00
Carol (Nichols || Goulding) fce4f3f346
test: Remove outdated test comments
This is not at all what this test is doing; probably copypasta
2023-07-20 14:13:15 -04:00
Chunchun Ye 8575f3c022
chore(docs): add `influxdb_iox debug build-catalog` to debug.md (#8273)
* chore(docs): add `influxdb_iox debug build-catalog` to debug.md

chore(docs): wording

chore(docs): rephrase

* chore: remove personal shell prompt and make cmds cleaner

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-20 15:42:19 +00:00
Joe-Blount 1bed99567c
chore: add DF metrics to compaction spans (#8270)
* chore: add DF metrics to compaction spans

* chore: update string for test verification

* chore: update comment

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-20 15:00:22 +00:00
Christopher M. Wolff 668a1c3d8e
fix: aggregate fns called on tags should return null (#8274)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-20 14:55:16 +00:00
kodiakhq[bot] 58181bab0a
Merge pull request #8285 from influxdata/savage/allow-kafka-columns-to-be-nullable
refactor(catalog): Allow kafka columns to be nullable
2023-07-20 14:25:23 +00:00
kodiakhq[bot] bdc884e6e8
Merge branch 'main' into savage/allow-kafka-columns-to-be-nullable 2023-07-20 14:20:42 +00:00
dependabot[bot] a49a0aaa21
chore(deps): Bump zstd from 0.12.3+zstd.1.5.2 to 0.12.4 (#8280)
Bumps [zstd](https://github.com/gyscos/zstd-rs) from 0.12.3+zstd.1.5.2 to 0.12.4.
- [Release notes](https://github.com/gyscos/zstd-rs/releases)
- [Commits](https://github.com/gyscos/zstd-rs/commits)

---
updated-dependencies:
- dependency-name: zstd
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-20 14:14:08 +00:00
Marco Neumann 0173c50ba1
fix: use correct error code when querier is shutting down (#8282)
When a long running query is in process and the querier is shutting
down, it might happen that the executor (= thread pool and tokio
executor responsible for the CPU-bound DataFusion execution) is shut
down while the query is running. From a "systems interaction" PoV I
think this is totally fine and I would like to avoid some weird
ref-counting. Or in other words: if the system is shutting down, shut it
down.

However the error was treated as "internal" which is not useful. The
client should rather be informed that its server was gone and that it is
OK (and desired) to retry. So as per
<https://grpc.github.io/grpc/core/md_doc_statuscodes.html> I think this
should signal "unavailable".

This change wires the error code in such a way that the gRPC service
layer can properly inspect it and then changes the error mapping.

Ref https://github.com/influxdata/idpe/issues/17917 .

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-20 12:08:22 +00:00
dependabot[bot] 9263b42c35
chore(deps): Bump clap from 4.3.16 to 4.3.17 (#8277)
Bumps [clap](https://github.com/clap-rs/clap) from 4.3.16 to 4.3.17.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/clap-rs/clap/compare/v4.3.16...v4.3.17)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-20 12:03:06 +00:00
Marco Neumann 6ae9143742
fix: `end_to_end_cases::cli::query_ingester` flakyness (#8281)
While I cannot reproduce the CI flakyness locally (probably because the
local system is fast enough), looking at the test convinced me that the
ingester should not persist.

Closes #8245.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-20 11:48:59 +00:00
Fraser Savage e894ea73f7
refactor(catalog): Allow kafka columns to be nullable 2023-07-20 11:18:02 +01:00
Marco Neumann d3432198b6
revert: batch partition catalog requests in querier (#8269) (#8283)
Panics in prod.

This reverts commit 0c347e8e64.
2023-07-20 09:42:40 +00:00
dependabot[bot] 0994f54af4
chore(deps): Bump sqlparser from 0.35.0 to 0.36.0 (#8279)
* chore(deps): Bump sqlparser from 0.35.0 to 0.36.0

Bumps [sqlparser](https://github.com/sqlparser-rs/sqlparser-rs) from 0.35.0 to 0.36.0.
- [Changelog](https://github.com/sqlparser-rs/sqlparser-rs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sqlparser-rs/sqlparser-rs/compare/v0.35.0...v0.36.0)

---
updated-dependencies:
- dependency-name: sqlparser
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: Run cargo hakari tasks

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: CircleCI[bot] <circleci@influxdata.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-20 09:30:14 +00:00
dependabot[bot] 0f2cbcaef5
chore(deps): Bump zstd-safe from 6.0.5+zstd.1.5.4 to 6.0.6 (#8275)
Bumps [zstd-safe](https://github.com/gyscos/zstd-rs) from 6.0.5+zstd.1.5.4 to 6.0.6.
- [Release notes](https://github.com/gyscos/zstd-rs/releases)
- [Commits](https://github.com/gyscos/zstd-rs/commits)

---
updated-dependencies:
- dependency-name: zstd-safe
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-20 09:05:54 +00:00
dependabot[bot] 4eff0fb359
chore(deps): Bump tower-http from 0.4.1 to 0.4.2 (#8278)
Bumps [tower-http](https://github.com/tower-rs/tower-http) from 0.4.1 to 0.4.2.
- [Release notes](https://github.com/tower-rs/tower-http/releases)
- [Commits](https://github.com/tower-rs/tower-http/compare/tower-http-0.4.1...tower-http-0.4.2)

---
updated-dependencies:
- dependency-name: tower-http
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-20 08:36:49 +00:00
Marco Neumann 0c347e8e64
feat: batch partition catalog requests in querier (#8269)
This is mostly wiring that builds on top of the other PRs linked to #8089.

I think we eventually could make the batching code nicer by adding
better wrappers / helpers, but lets do that if we have other batched
caches and this patterns proofs to be useful.

Closes #8089.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-20 08:31:49 +00:00
dependabot[bot] 59c532ee56
chore(deps): Bump serde from 1.0.171 to 1.0.173 (#8276)
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.171 to 1.0.173.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](https://github.com/serde-rs/serde/compare/v1.0.171...v1.0.173)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-20 08:05:38 +00:00
Martin Hilton 2f2fcb6f05
refactor(influxql): make DERIVATIVE a user-defined window function (#8265)
Now that user-defined window functions are available, change the
DERIVATIVE and NON_NEGATIVE_DERIVATIVE function implementations to
use user-defined windows functions. This should improve performance
by allowing the entire window to be processed in one go, rather
than processing one row at a time.

The implementation is also moved out of the planner module alongside
the other user-defined window functions.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-20 06:19:02 +00:00
Chunchun Ye b3fca844d5
chore: update doc to `remote store get-table` (#8261)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-19 20:23:41 +00:00
Joe-Blount 2519c9c6d2
Merge pull request #8262 from influxdata/jrb_65_move_progress_reporting
fix(compactor timeout): chunk up high plan counts in the compactor
2023-07-19 14:16:48 -05:00
Joe-Blount ccb950445c Merge remote-tracking branch 'origin/main' into jrb_65_move_progress_reporting 2023-07-19 14:05:48 -05:00
Joe-Blount 4c5c2473e6 chore: move scratchpad cleanup earlier 2023-07-19 10:16:28 -05:00
Marco Neumann 4e88571142
feat: add batch partition getters (#8268) 2023-07-19 15:05:41 +00:00
Marco Neumann 004b401a05
chore: upgrade to sqlx 0.7.1 (#8266)
There are a bunch of dependencies in `Cargo.lock` that are related to
mysql. These are NOT compiled at all, and are also not part of `cargo
tree`. The reason for the inclusion is a bug in cargo:

https://github.com/rust-lang/cargo/issues/10801

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-19 12:18:57 +00:00
dependabot[bot] d3b3805e5f
chore(deps): Bump clap from 4.3.15 to 4.3.16 (#8263)
Bumps [clap](https://github.com/clap-rs/clap) from 4.3.15 to 4.3.16.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/clap-rs/clap/compare/v4.3.15...v4.3.16)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-19 09:26:04 +00:00
Marco Neumann fbbaf155ec
feat: ability to batch cache loader requests (#8259)
Core functionality for #8089.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-19 09:20:40 +00:00
Joe-Blount 69e4f998dd fix: chunk up high plan counts in the compactor 2023-07-18 15:16:04 -05:00
Christopher M. Wolff b79009b128
refactor: refactor `Schemas` type in InfluxQL planner (#8237)
* refactor: refactor `Schemas` type in InfluxQL planner

* chore: update after merging main

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-07-18 17:14:39 +00:00