Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #8305 from influxdata/savage/await-enqueue-rotation-returned-receiver-during-shutdown 

fix(ingester): Graceful shutdown must wait for file rotation receiver
pull/24376/head
kodiakhq[bot] 2023-07-24 09:22:52 +00:00 committed by GitHub
parent 79bb1347e6 0ed4e8509b
commit 7b385600fd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ingester/src/init/graceful_shutdown.rs
View File

@ -118,9 +118,12 @@ pub(super) async fn graceful_shutdown_handler<F, T, P>(
// that the segment's file can be deleted because everything has been
// persisted.
let (closed_segment, sequence_number_set) = wal.rotate().expect("failed to rotate wal");
wal_reference_handle
let rx = wal_reference_handle
.enqueue_rotated_file(closed_segment.id(), sequence_number_set)
.await;
if let Err(e) = rx.await {
error!(%e, "encountered failure waiting on file rotation receiver during shutdown");
};
// Wait for the file rotation to be processed and the tracked set
// to drop to empty.