Commit Graph

4447 Commits (74c620e478f1a42c4b238940626db53b255f9ec2)

Author SHA1 Message Date
Nikhil Mohite d945c6f843 Fixed an issue where connections keep open to (closed) connections on the initial connection to the database server. Fixes #7035 2022-01-19 15:02:05 +05:30
Akshay Joshi dabe64a8df Fixed enable/disable menu issue introduced by SonarQube fix. 2022-01-19 12:16:57 +05:30
Aditya Toshniwal fbc3b1a318 Added support for grouping in input select boxes and allow setting default selected options. 2022-01-18 18:44:55 +05:30
Akshay Joshi 6adc1bfd42 Fixed context menu issue. 2022-01-18 18:43:34 +05:30
Nikhil Mohite e7e4d5cf0a Fixed feature test cases for maintenance dialog. 2022-01-18 14:51:02 +05:30
Akshay Joshi 9f836f5433 Fixed following code smells reported by SonarQube:
1) Immediately return this expression instead of assigning it to the temporary variable.
 2) Extract this nested ternary operation into an independent statement.
 3) Expected a `for-of` loop instead of a `for` loop with this simple iteration.
2022-01-18 14:49:54 +05:30
Akshay Joshi e3807ec3d6 Fixed following code smells reported by SonarQube:
1) Boolean checks should not be inverted.
 2) Review this redundant assignment.
 3) Extract this nested ternary operation into an independent statement.
 4) Unexpected empty function.
 5) Immediately return this expression instead of assigning it to the temporary variable.
2022-01-17 13:56:01 +05:30
Nikhil Mohite 4787de6968 CSS changes in the browser tree.
refs #7085
2022-01-13 12:52:55 +05:30
Akshay Joshi 3f7e921cce Fixed code smell 'Unexpected empty arrow function' reported by SonarQube. 2022-01-12 18:59:21 +05:30
Akshay Joshi 4e414f57e6 Fixed code smell 'Default parameters should be last' reported by SonarQube. 2022-01-12 18:40:18 +05:30
Akshay Joshi c98fb887cc Fixed code smell 'Unexpected empty arrow function' reported by SonarQube. 2022-01-12 17:32:20 +05:30
Nikhil Mohite d2457f2a1d Ensure that Partitioned tables should be visible correctly when creating multiple partition levels. Fixes #7085 2022-01-12 16:29:13 +05:30
Akshay Joshi e38c38cd58 Fixed following SonarQube code smells:
1) Remove this useless assignment to a variable.
2) Remove the unused local variable.
2022-01-12 14:53:19 +05:30
Nikhil Mohite 374c5e952f Fixed an issue where the Browser tree gets disappears when scrolling sequences. Fixes #7100 2022-01-11 18:03:11 +05:30
Libor M 38e5ded821 Update Czech translation. 2022-01-11 17:40:49 +05:30
Akshay Joshi 44a5a3f2fc Update version for release. 2022-01-10 16:20:11 +05:30
Akshay Joshi 7fe1d89891 Fixed import/export servers issue reported during testing. 2022-01-10 16:16:10 +05:30
Nikhil Mohite e43a87da09 Fixed SonarQube issue. 2022-01-10 12:10:20 +05:30
Akshay Joshi 55dc06de15 Fixed API test case for Import/Export Servers. 2022-01-09 14:47:32 +05:30
Identifier Anonymous f61d22d58d Update Japanese translation. 2022-01-09 12:54:51 +05:30
Domenico Sgarbossa fd92974902 Update Italian translation. 2022-01-09 12:53:42 +05:30
Akshay Joshi ec64910e0c Update message catalog. 2022-01-07 21:36:04 +05:30
Akshay Joshi 4ecd05e33b 1) Fixed import/export servers issue in server mode.
2) Fixed an issue where files are not showing as per the selected format in
   the file dialog when opened the first time.
2022-01-07 21:29:17 +05:30
Nikhil Mohite af6ff20020 Fixed SonarQube issues. 2022-01-07 19:58:19 +05:30
Nikhil Mohite ad862f4084 Port Maintenance dialog to React. Fixes #7019 2022-01-07 12:07:49 +05:30
Akshay Joshi 7cc76c7d2d Fixed import/export server issues reported while testing. 2022-01-06 20:01:25 +05:30
Rahul Shirsat 6528d086ba Fixed review comments:
1. Split the restore options/backup options into 2 tabs
2. Restore icon changes
3. feature tests issues
4. restore help link broken
5. Comment section not visible

refs #7018
2022-01-06 16:46:44 +05:30
Akshay Joshi f56b4030f1 Fixed a schema diff issue where generated script adds unwanted line endings for Functions/Procedures/Trigger Functions. Fixes #7102 2022-01-06 13:08:50 +05:30
Akshay Joshi 8b13f158ab Fixed review comments for Import/Export Servers.
refs #4803
2022-01-05 14:02:49 +05:30
Akshay Joshi 964eddf952 Corrected wrong import statement. 2022-01-04 15:27:06 +05:30
Akshay Joshi 2786f7ac5a Update copyright notices for 2022 2022-01-04 13:54:25 +05:30
Akshay Joshi 9dd957a2aa Added support to import/export server groups and servers from GUI. Fixes #4803 2022-01-04 12:27:17 +05:30
Pradip Parkale c1ad7d81f4 Fixed an issue where destroy method is not present for the browser tree after React porting. 2022-01-03 17:47:22 +05:30
Akshay Joshi a4ef5ea48b Fixed an issue where SubPlans may overlap other nodes & make them inaccessible in Graphical EXPLAIN View.
Patch sent by:  Robert Frunzke

Fixes #7093
2021-12-31 14:49:42 +05:30
Yogesh Mahajan 44ab4648a8 Fixed an issue in SQL generation for PostgreSQL-14 functions. Fixes #7081 2021-12-31 14:30:53 +05:30
Nikhil Mohite 19016c3733 Ensure that help should be visible properly for Procedures. Fixes #7075 2021-12-31 14:21:38 +05:30
Nikhil Mohite e18ce2c9e3 Updates CSS and structure in Wizard, also fixed css issues in GrantWizard. 2021-12-31 14:16:50 +05:30
Yogesh Mahajan 0ceb2e2767 Ensure that Truncate and Reset statistics should work. Fixes #7096 2021-12-30 12:19:33 +05:30
Nikhil Mohite 191e2b6242 Fixed an issue where an operation error message pop up showing the database object's name incorrectly. Fixes #7078 2021-12-28 13:49:04 +05:30
Rahul Shirsat 603d91be0e Port Restore dialog to React. Fixes #7018 2021-12-28 13:45:59 +05:30
Akshay Joshi 262dcdcf54 Added postion relative to show error message properly. 2021-12-24 17:37:59 +05:30
Akshay Joshi 74be3a9f52 Fixed linter error. 2021-12-24 16:52:32 +05:30
Aditya Toshniwal 5c65766ece Added a common table MUI style object which can be used on any table.
Added a few more styling improvements.
2021-12-24 16:15:38 +05:30
Nikhil Mohite bae8a2bd5d Fixed an issue where Explain Analyze shows negative exclusive time. Fixes #7003 2021-12-24 16:11:58 +05:30
Yogesh Mahajan 6d0ed91d31 Fixed an issue where the Owner is not displayed in the reverse engineering SQL for Procedures. Fixes #7077 2021-12-24 16:09:51 +05:30
Nikhil Mohite 45179ccb8c Change logic for grant wizard, wizard component, and updated CSS. 2021-12-22 18:26:21 +05:30
Akshay Joshi ebee7a5b72 Fixed linter errors. 2021-12-22 14:44:57 +05:30
Akshay Joshi ae73f13812 Added beforeNext and beforeBack method in Wizard. 2021-12-22 14:25:08 +05:30
Yogesh Mahajan e302a6199a Fixed QueryToolJourneyTest feature test. 2021-12-21 18:10:48 +05:30
Nikhil Mohite e5e9981836 Fixed an issue where Columns with default value not showing when adding a new row. Fixes #7034 2021-12-21 18:09:20 +05:30
Nikhil Mohite 461c0abce1 Fixed an issue where Tablespace is created though an error is shown on the dialog. Fixes #6745 2021-12-21 18:07:17 +05:30
Akshay Joshi 02b83146be 1) Added spacing for message and loading spinner.
2) Rename the GrantWizard Dialog.
3) Return the activeStep from disableNextStep function.
2021-12-21 18:00:07 +05:30
Pradip Parkale 9754b0fe14 Fixed an issue where Columns with default value not showing when adding a new row. Fixes #7034 2021-12-17 10:48:24 +05:30
Akshay Joshi 92a997b16a Rearrange tools menu on the basis of usability and form groups of similar sub-menus. 2021-12-16 18:29:44 +05:30
Akshay Joshi 8cfdfd898d Updated testtools version to work with Python 3.10 2021-12-16 17:36:13 +05:30
Fred Escallier 3a9a635419 Update French translation. 2021-12-15 14:51:19 +05:30
Aditya Toshniwal 6875d00e44 Fixed an issue where confirmation pop-up is hidden behind Reassign/Drop Owned Dialog. Fixes #7071 2021-12-14 16:42:06 +05:30
Akshay Joshi 83e646c7d4 Reverting patch for #7003, showing Nan in time fields. 2021-12-14 16:30:59 +05:30
Akshay Joshi d0d194b60d Update version for release. 2021-12-13 17:20:43 +05:30
Aditya Toshniwal 701e6f86f5 Ensure that statue message should not hide the last line of messages when running a long query. Fixes #7020 2021-12-13 13:10:56 +05:30
Akshay Joshi da5545ff57 Added support to disable the auto-discovery of the database servers. Fixes #7039 2021-12-13 13:07:37 +05:30
Libor M fea44c07c7 Update Czech translation. 2021-12-13 11:22:11 +05:30
Identifier Anonymous e539bc2ae7 Update Japanese translation. 2021-12-13 11:20:25 +05:30
Domenico Sgarbossa 9bdca4b409 Update Italian translation. 2021-12-13 11:17:37 +05:30
Pradip Parkale 40027dd502 Remove some unwanted code.
refs #6840
2021-12-13 11:13:34 +05:30
Akshay Joshi bd545fd5b2 1) Fixed schema diff owner related issue. Fixes #6877
2) Fixed schema diff related some issues. Fixes #6957
2021-12-11 22:10:28 +05:30
Akshay Joshi 3f939dfc11 Update message catalogs. 2021-12-10 19:49:27 +05:30
Nikhil Mohite 4dc7f24b5f Fixed linter error 2021-12-09 20:26:44 +05:30
Nikhil Mohite 9ec8d05a64 1) Ensure that the Owner should not be disabled while creating the procedure. Fixes #7064
2) Fixed an issue where Explain Analyze shows negative exclusive time. Fixes #7003
2021-12-09 16:59:43 +05:30
Akshay Joshi f24348b2b0 Fixed an issue where notifier not working when opening query tool in a new
window and then open it in the new tab.
2021-12-08 18:15:13 +05:30
Rahul Shirsat 91a288c2bb Correct the SQL definition for function/procedure with the Atomic keyword in PG14. Fixes #7029 2021-12-08 12:31:59 +05:30
Akshay Joshi fd53e4f5f9 Replace Alertify alert and confirm with React-based model dialog. Fixes #7053 2021-12-07 18:52:40 +05:30
Akshay Joshi e327066523 Fixed RESQL test cases for EPAS-14 2021-12-07 11:48:27 +05:30
Yogesh Mahajan 48dc4bacc4 Fixed Kerberos authentication issue which is broken due to 2FA.
refs #6543
2021-12-06 20:14:39 +05:30
Nikhil Mohite 950809ee55 Increase the width of the scrollbars. Fixes #6978 2021-12-06 20:11:30 +05:30
Pradip Parkale c7a49490a2 Fixed an issue where tooltip data are not displaying on downloaded graphical explain plan. Fixes #6840 2021-12-06 20:07:11 +05:30
Akshay Joshi f8cb62180e Fixed API test cases for StartRunningQueryTest. 2021-12-03 13:19:31 +05:30
Aditya Toshniwal dfdaf7f6d1 Implemented React based modal provider to create models on the fly.
Also, use this to replace Alertify alert and confirm dialog.
2021-12-03 12:50:24 +05:30
Akshay Joshi 9c0c046a38 Fixed unhashable type issue while opening the about dialog. Fixes #7048 2021-12-03 12:31:59 +05:30
Akshay Joshi 5ae1036a24 Corrected the down_version in migration file. 2021-12-02 18:35:08 +05:30
Ashesh Vashi 36c9eb3dfd Added support for Two-factor authentication for improving security. Fixes #6543 2021-12-02 16:47:18 +05:30
Pradip Parkale fe096116be Change the logic to rename the table in the SQLite database to fix the migration issue.
refs #7031
2021-12-02 16:25:59 +05:30
Ganesh Jaybhay e30cbe2579 Fixed some accessibility issues:
1) Focus is not visible while navigating through top navbar menu items(File, Object, Tools)
2) In preference dialog wherever access key is used for a shortcut declaration, unable to get out of the textbox.
3) Focus is not visible for the links on the dashboard

Fixes #7046
2021-12-02 16:24:55 +05:30
Akshay Joshi c6424e3897 Replaced alertifyjs notifiers with React-based notistack. Fixes #7004 2021-12-02 16:05:52 +05:30
Akshay Joshi 0f9b9b9dcf Added 'eslint-plugin-react-hooks' to identify the linter errors related to react hooks. 2021-12-01 17:43:20 +05:30
Pradip Parkale 6b613fdf36 Fixed an issue where SQLite database definition is wrong because the USER_ID FK
references the table user_old which is not available.

Fixes #7031
2021-12-01 17:24:41 +05:30
Aditya Toshniwal 9d804d2857 Update the dropzone version to 5.9.3 and Flask-SQLAlchemy to 2.5.*. Fixes #7044 2021-12-01 17:23:46 +05:30
Akshay Joshi 2c02e6fc23 Ensure that the user should be allowed to set the schema of an extension while creating it. Fixes #6963 2021-11-29 15:27:44 +05:30
Nikhil Mohite 61b440261f Ensure that sort order should be maintained when renaming a server group. Fixes #6955 2021-11-29 12:04:04 +05:30
Akshay Joshi fbd10ef4b6 Fixed an issue where reverse engineering SQL is wrong for Aggregate. Fixes #7024 2021-11-29 12:00:38 +05:30
Yogesh Mahajan abe5303448 Fixed an issue where the error is thrown while creating a new server using
Add New Server from the dashboard while tree item is not selected.

Fixes #7015
2021-11-28 13:32:30 +05:30
Nikhil Mohite bef692d431 Fixed an issue where On-demand rows throw an error when any row cell is edited
and saved it then scroll to get more rows.

Fixes #7005
2021-11-28 13:26:40 +05:30
Akshay Joshi 9a0d92469b Use .__ne__ instead of 'is not None' statement to fix the API test cases. 2021-11-24 18:54:25 +05:30
Akshay Joshi bce7e8346d Fixed API test case after upgrading Flask to v2. 2021-11-24 17:58:29 +05:30
Nikhil Mohite 3dcee71a92 Resolved issue if the binary path is not present/correct, then show error notification to add/correct the binary path.
refs #6984
2021-11-24 17:28:04 +05:30
Akshay Joshi d644b4f94e 1) Replace Flask-BabelEx with Flask-Babel. Fixes #6088
2) Upgrade Flask to version 2. Fixes #7010
2021-11-24 17:22:57 +05:30
Nikhil Mohite 3a30f27153 1. Updated notification message for the reset layout.
2. Added notification type in alertify which was missing.

refs #6988
2021-11-24 10:58:15 +05:30
Yogesh Mahajan 19984d6563 Fixed feature test failures due to React porting of backup dialog. 2021-11-23 17:36:10 +05:30
Yogesh Mahajan b921a55c46 Adds flexibility to wait for launching pgAdmin in feature test. 2021-11-22 18:05:30 +05:30
Nikhil Mohite 3afeb8ca46 Port Backup Global, Backup Server, and Backup object dialog in React. Fixes #6984 2021-11-22 11:20:44 +05:30
Akshay Joshi a701e8c766 Fixed an issue where the Change Password menu option is missing for internal
authentication source when more than one authentication source is defined.

Fixes #6989
2021-11-22 11:02:26 +05:30
Yogesh Mahajan 246bb01736 Fixed feature test cases. 2021-11-18 17:13:32 +05:30
Nikhil Mohite cc91e5da94 Fixed an issue where properties of the database should not be visible after removing the database.
Fixes #6964
2021-11-18 12:36:39 +05:30
Pradip Parkale a5b79564ff Fixed an issue where the user can't debug function with timestamp parameter. Fixes #6986 2021-11-18 12:25:21 +05:30
Nikhil Mohite 3d5d507f4b Fixed an issue where referenced table drop-down should be disabled in
foreign key -> columns after one row is added.

Fixes #6906
2021-11-18 12:22:14 +05:30
Fred Escallier e1020aefdd Update French translation. 2021-11-18 12:01:06 +05:30
Khushboo Vashi cc38bc132e Fixed scroll issue in the browser tree when navigating using the keyboard. 2021-11-15 18:26:16 +05:30
Akshay Joshi 053519aef6 Update version for release. 2021-11-15 16:38:10 +05:30
Nikhil Mohite 1408bad8ba Fixed an issue where reset layout message showing when the user opens the query tool.
refs #6988
2021-11-15 16:34:25 +05:30
Pradip Parkale 33cc2a7514 Fixed an issue where SQL for index shows the same column multiple times. Fixes #6981 2021-11-15 16:31:40 +05:30
Domenico Sgarbossa d6a754e850 Update Italian translation. 2021-11-15 12:56:58 +05:30
Libor M fc05ef49ce Update Czech translation. 2021-11-15 12:54:06 +05:30
Identifier Anonymous b36a290b54 Update Japanese translation. 2021-11-15 12:52:09 +05:30
Akshay Joshi 0ca7dbccf6 Ensure that the Binary path for PG14 should be visible in the preferences. Fixes #6972 2021-11-15 12:44:33 +05:30
Khushboo Vashi e67bad3461 Ensure that the user should be able to navigate browser tree objects using arrow keys from keyboard. Fixes #6896 2021-11-15 11:17:42 +05:30
Yogesh Mahajan e2e5a8208c 1) Fixed an issue where JSON editor preview colours have inappropriate contrast in dark mode. Fixes #6944
2) Fixed JSON Editor scrolling issue in code mode. Fixes #6945
2021-11-15 10:58:17 +05:30
Akshay Joshi 59707fc8af Update message catalogs. 2021-11-12 20:01:25 +05:30
Akshay Joshi 25ace94d10 Fixed API test cases for search object. 2021-11-12 19:58:29 +05:30
Akshay Joshi ca4d5d0ca4 Added operators and aggregates in search objects. Fixes #6974 2021-11-12 17:45:08 +05:30
Aditya Toshniwal 600690a789 Fixed JS audit issues. 2021-11-12 14:19:09 +05:30
Yogesh Mahajan 77931d2315 Uses selenium 4.0.0a6 which works with python 3.6 2021-11-12 11:56:44 +05:30
Nikhil Mohite 8bf178b0a3 Reset the layout if pgAdmin4 detects the layout is in an inconsistent state. Fixes #6988 2021-11-12 11:50:37 +05:30
Pradip Parkale d4bf7164f9 Ensure that inherit table icon should be visible properly in the tree view. Fixes #6845 2021-11-11 12:55:38 +05:30
Nikhil Mohite 7468ca36ae Fixed SQL syntax error if select "Custom auto-vacuum" option and not set Autovacuum option to Yes or No. Fixes #6925 2021-11-11 12:36:19 +05:30
Rahul Shirsat 572b5a126a Ensure that internal authentication when combined with other authentication providers, the order of internal source should not matter while picking up the provider. Fixes #6832 2021-11-11 12:29:30 +05:30
Khushboo Vashi d4697e8f1c Ensure that users should be able to modify the REMOTE_USER environment
variable as per their environment by introducing the new config parameter
WEBSERVER_REMOTE_USER.

Fixes #6953
2021-11-10 15:38:41 +05:30
Yogesh Mahajan 9479f0e632 Fixed feature test cases after react porting. 2021-11-10 11:50:20 +05:30
Khushboo Vashi aff84103d9 Fixed an issue where database nodes are not getting loaded behind a reverse
proxy with SSL. Fixes #6905
2021-11-10 11:47:40 +05:30
Pradip Parkale a61a9e5b8f Fixed an issue where older server group name displayed in the confirmation
pop-up when the user removes server group. Fixes #6939
2021-11-10 11:17:51 +05:30
Pradip Parkale eb8168285e Cover more scenarios for the pgAdmin freezing issue. Fixes #5427 2021-11-10 11:11:24 +05:30
Aditya Toshniwal 1ed4d0f95e Fixed an issue where textarea should be allowed to resize and have more than 255 chars. Fixes #6976 2021-11-07 10:51:54 +05:30
Aditya Toshniwal 31849ea95f Ensure that changing themes should work on Windows when system high contrast
mode is enabled. Fixes #6954
2021-11-07 10:46:49 +05:30
Akshay Joshi 719f8c8fd2 Fixed API test case for DataTypeReader 2021-10-29 17:37:02 +05:30
Pradip Parkale fa8b3edda5 Fixed an issue where user details are not shown when the non-admin user tries
to connect to the shared server. Fixes #6940
2021-10-29 16:26:11 +05:30
Nikhil Mohite f71e2e8040 Fixed an issue where pgAdmin is not opening properly. Fixes #6809 2021-10-29 16:17:36 +05:30
Akshay Joshi 39992a817d Added support of Aggregate and Operator node in view-only mode. Fixes #3834 2021-10-29 16:14:33 +05:30
Akshay Joshi 7b85253465 Corrected some menu lables. 2021-10-27 11:05:23 +05:30
Pradip Parkale 35b1e1d0d2 Fixed pgAdmin freezing issue by providing the error message for the operation
that can't perform due to lock on the particular table. Fixes #5427
2021-10-27 10:51:52 +05:30
Rahul Shirsat 711ea3bfa1 Fixed an issue where properties panel is not updated when any object is added from the browser tree. Fixes #6859 2021-10-27 10:31:49 +05:30
Rahul Shirsat 8eb6f8061d Ensure that dialog should be opened when clicking on Reassign/Drop owned menu. Fixes #6949 2021-10-25 11:47:28 +05:30
Akshay Joshi 2c4ed4d115 Reverted the last patch to pin mozjpeg as it didn't work. 2021-10-21 17:06:04 +05:30
Aditya Toshniwal fc233ed993 Pin mozjpeg to 7.1.0 as the latest version will require zlib to be re-compiled. 2021-10-21 16:18:06 +05:30
Aditya Toshniwal 1d8810775c Fixed JS audit issues wherever possible and ignores devDependencies from packages.json 2021-10-21 15:08:24 +05:30
Aditya Toshniwal d28e249673 Ignore flask-security-too irrelevant vulnerability. 2021-10-21 11:14:27 +05:30
Pradip Parkale c7cd57db91 Ensure that columns should be merged if the newly added column is present in the parent table. Fixes #6780 2021-10-21 10:59:52 +05:30
Akshay Joshi d2a7f7fffe Fixed API test cases for PG 14 2021-10-20 18:39:42 +05:30
Rahul Shirsat 27b6e07e21 Fixed object delete issue from the properties tab for the collection nodes. Fixes #6858 2021-10-19 17:21:46 +05:30
Aditya Toshniwal a2f5e6ad8f Fixed an issue where the wrong SQL is generated when deleting and renaming table columns together. Fixes #6935 2021-10-19 17:13:12 +05:30
Akshay Joshi ea0d3eb812 Fixed an issue where a blank string is stored instead of NULL in create mode in server dialog. Fixes #6915 2021-10-19 17:01:50 +05:30
Aditya Toshniwal 9de1489322 Ensure that only the table node should be allowed to drop on the ERD tool. Fixes #6929 2021-10-19 12:01:43 +05:30