milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
14,800 Commits
133 Branches
115 Tags
559 MiB
Commit Graph

5302 Commits (e196caf6041aad321100b23403150b495b81c645)

Author SHA1 Message Date
Jiquan Long 77b0f290a8
Fix prefix match on sealed segment (#17050) 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
 2022-05-17 20:15:55 +08:00
congqixia 5282397c1b
Fix VectorChunkManager cache enable parameter (#17058) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-05-17 17:37:55 +08:00
cai.zhang d6bb86dd46
Return buildID when creating index if the index alreay exists (#17045) 
Signed-off-by: Cai.Zhang <cai.zhang@zilliz.com>
 2022-05-17 15:21:57 +08:00
xige-16 c2f1d65fa1
Print err info when insert msg not aligned (#16305) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
 2022-05-17 13:01:57 +08:00
yah01 960d35e517
Add MockCluster, make unit tests reliable (#17032) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-05-17 12:57:56 +08:00
XuanYang-cn a1480aaf76
Clear shard leaders cache when releasing (#16942) 
See also: #16926

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
 2022-05-17 11:11:56 +08:00
Xiaofan 5355153805
Minio Error is not Handled gracefully (#17003) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-05-16 19:25:55 +08:00
Xiaofan 327bd6abbe
Support Txn interface in rockskv (#17027) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-05-16 19:17:55 +08:00
xige-16 935b729a0c
Fix multiple deletes not taking effect (#17033) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
 2022-05-16 18:39:56 +08:00
congqixia ffff291018
Fix Handoff log in shardCluster service (#17039) 
Fix #17035

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-05-16 18:29:56 +08:00
congqixia 94f0951f0d
Fix query lock logic in query shard (#17034) 
Previously query shard locks the querylock in collectionReplica before any search/query
The lock range is too large and easy to cause dead lock

This PR makes following changes:
- Rename collectionReplica to metaReplica which is more reasonable
- Make release collection operation cancels waiting search/query request
- Reduce the queryLock to collection level
- Add some unit tests for timeout & released case

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-05-16 18:23:55 +08:00
Bingyi Sun 59bc0a7000
Add some log. (#16978) 
Signed-off-by: sunby <bingyi.sun@zilliz.com>

Co-authored-by: sunby <bingyi.sun@zilliz.com>
 2022-05-16 17:15:55 +08:00
yah01 e38c6f6c44
Fix load the same segments multiple times for manual LoadBalance (#16921) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-05-16 15:41:56 +08:00
Xiaofan 338edcd3cc
Load binlog for different field in parallel (#17005) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-05-15 16:11:54 +08:00
SimFG ea2c395a38
Fix the comment info in task_test.go (#16982) 
Signed-off-by: SimFG <bang.fu@zilliz.com>
 2022-05-15 09:03:54 +08:00
jaime 328ab7ecf6
Fix kafka client hang after killing broker pod of parition leader (#16983) 
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
 2022-05-14 23:05:54 +08:00
congqixia 23f7ef931c
Remove not used QueryService (#16973) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-05-13 20:27:54 +08:00
congqixia ec66ac69ac
Simplify chunk manager in QueryShard (#16976) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-05-13 19:55:54 +08:00
yah01 a382133a8a
Add new node into the replica which has the most of offline nodes (#16907) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-05-13 18:31:54 +08:00
Xiaofan 52fc9a558c
Fix valid error message (#16953) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-05-13 18:19:53 +08:00
Jiquan Long ca3ecec5b5
Fix ut data race (#16939) 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
 2022-05-13 17:43:53 +08:00
groot 168935f4cf
Fix bulkload bug for string primary key (#16958) 
Signed-off-by: groot <yihua.mo@zilliz.com>
 2022-05-13 16:07:54 +08:00
Letian Jiang f0dee539bb
Improve query shard log (#16950) 
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
 2022-05-13 13:45:53 +08:00
XuanYang-cn 43b36b4e5f
Make proxy update cache with NotShardLeader status code (#16940) 
See also: #16926

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
 2022-05-13 11:35:53 +08:00
Jiquan Long c5149c7e85
Replace text codec of pb with binary codec (#16955) 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
 2022-05-13 09:53:53 +08:00
Ten Thousand Leaves 63385b7c12
Make data queryable and data indexed states as independent flags (#16837) 
/kind improvement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
 2022-05-12 19:23:53 +08:00
congqixia ae717bf991
Fix channelUnsubscribe data race and logic (#16946) 
- Add a RWMutex for container/list which is not goroutine-safe
- Fix the element in list is never removed

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-05-12 18:09:53 +08:00
xige-16 08ad77c71b
Delete all repeated primary keys (#16863) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
 2022-05-12 14:09:53 +08:00
Letian Jiang b3eb2b1d0d
Support deltaLog loading on growing segment (#16903) 
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
 2022-05-12 11:59:53 +08:00
congqixia a8b81e215b
Fix deadlock in release replica (#16925) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-05-11 21:57:53 +08:00
congqixia a0614a3ff8
Use NodeIds instead of NodeID in segment info (#16912) 
The NodeID field is deprecated in current design
Query Node segment detector shall read NodeIds instead of NodeID

Fix #16911

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-05-11 17:39:53 +08:00
xige-16 9e6d9fb7d8
Print collectionName when load failed (#16878) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
 2022-05-11 09:47:53 +08:00
Jiquan Long be688d894a
Forbid multiple indexes on same field (#16875) 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
 2022-05-10 21:07:53 +08:00
exia 4ee78eb5ad
proxy support tls (#16706) 
Signed-off-by: xiyichan <2863768433@qq.com>
 2022-05-10 20:05:53 +08:00
congqixia 5c98329f7c
Return error when no replica available (#16886) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-05-10 19:47:53 +08:00
Xiaofan 000c5ff3de
Fix msgstream unsubscription (#16883) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-05-10 19:43:52 +08:00
congqixia 34833680da
Add lock before query release collection from replica (#16880) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-05-10 18:09:53 +08:00
Ten Thousand Leaves 216c45fbd6
Add tests where segments load delta logs (#16825) 
issue: #16821

/kind improvements

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
 2022-05-10 17:59:52 +08:00
yah01 2d0f908dba
Fix updating segments' NodeIds correctly after LoadBalance (#16854) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-05-10 15:47:53 +08:00
Letian Jiang 72bbe40254
Make PayloadReader read column data in batch (#16826) 
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
 2022-05-10 11:37:52 +08:00
Ten Thousand Leaves 5afdf3d49f
Move locks back to meta table methods (#16848) 
/kind improvement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
 2022-05-09 20:47:52 +08:00
Bingyi Sun 76bfd41952
Refine DataNode logs. (#16849) 
Signed-off-by: sunby <bingyi.sun@zilliz.com>

Co-authored-by: sunby <bingyi.sun@zilliz.com>
 2022-05-09 16:25:52 +08:00
Xiaofan 62658dcda6
Fix pulsar unscubsribe fail because of consumer not found (#16839) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-05-09 12:07:52 +08:00
cai.zhang b0c9f25352
Sort out the log of IndexCoord (#16810) 
Signed-off-by: Cai.Zhang <cai.zhang@zilliz.com>
 2022-05-09 12:05:52 +08:00
xige-16 8fcf349609
Fix create index failed after drop index (#16836) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
 2022-05-09 11:35:53 +08:00
congqixia c7935d1a86
Add legacySegments for load balance segments rc track (#16831) 
- Add legacySegments in ShardCluster tracking old segment inUse
- Apply node id check for segment online/inUse check
- Add unit test simulating load balance case

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-05-07 18:25:52 +08:00
Jiquan Long ac389f3e93
Limit and translate pattern match operations (#16818) 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
 2022-05-07 16:31:52 +08:00
Ten Thousand Leaves 6b2d3c3ec1
Make each dataNode only accept one bulk load task simultaneously (#16820) 
issue: #16674

/kind improvement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
 2022-05-07 14:05:52 +08:00
Xiaofan 92b6293be4
Fix QueryNode log level (#16604) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-05-07 10:27:51 +08:00
Enwei Jiao 67ce206cf0
make SegmentMaxLifetime configurable (#16783) 
Signed-off-by: Enwei Jiao <jiaoew2011@gmail.com>
 2022-05-06 23:41:51 +08:00
Ten Thousand Leaves 31ddff2056
Some minor fixes and improvements (#16814) 
/kind improvement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
 2022-05-06 21:35:51 +08:00
bigsheeper 64d2793fe9
Fix wrong result topks when reduce search result (#16815) 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
 2022-05-06 21:17:51 +08:00
Ten Thousand Leaves a8e1c8fa9d
Make duplicate flush recalls success and other logic update (#16755) 
Latest logic:
1) Duplicate flush calls on same segments will not result in errors (same as the original design)
2) `FlushSegments` now still flushes stale segments even if non-stale segments failed to get flushed

issue: #16749

/kind enhancement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
 2022-05-06 17:49:51 +08:00
Jiquan Long 98ceb162aa
Support antlr as plan parser (#16696) 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>

Co-authored-by: xaxys <tpnnghd@163.com>

Co-authored-by: xaxys <tpnnghd@163.com>
 2022-05-06 17:43:51 +08:00
Letian Jiang b0053b7a45
Add isShardLeader field in search/query request (#16798) 
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
 2022-05-06 16:55:51 +08:00
xige-16 009b773b6e
Delete set default type param max_len for varchar field (#16794) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
 2022-05-06 15:59:51 +08:00
groot 8736372fd2
Fix bulkload bugs (#16760) 
Signed-off-by: groot <yihua.mo@zilliz.com>
 2022-05-06 11:21:50 +08:00
xige-16 7cc995d085
Prohibit creating diff indexes with same index_name on a collection (#16774) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
 2022-05-05 21:33:51 +08:00
Ten Thousand Leaves 1acd256481
Add DataQueryable and DataIndexed states for bulk load tasks (#16725) 
issue: #16607

/kind enhancement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
 2022-05-05 21:17:50 +08:00
yah01 c82e2453eb
Modify the replicas' shard info after load balance (#16785) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-05-05 21:15:50 +08:00
congqixia 8c004fa981
Fix replicaID is allow zero from watch channel task (#16788) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-05-05 18:11:51 +08:00
yah01 20936f78da
Fix LoadBalance failed to sync segments to shard leader when the leader is offline (#16770) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-05-05 16:25:50 +08:00
Xiaofan 333b439a6c
Support config grpc log level (#16618) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-05-05 10:35:50 +08:00
shaoyue fa97f86cda
Clean up not used id_cache related code (#16655) 
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
 2022-05-05 09:59:51 +08:00
Xiaofan 337ad53613
Support config small index nprobe and nlist (#16731) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-05-05 09:49:50 +08:00
cai.zhang 2be46a01c0
Reduce the number of retries and add error log (#16754) 
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
 2022-05-05 09:31:51 +08:00
jaime c25b337c36
Remove AddTenant from meta table (#16717) 
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
 2022-05-05 09:23:51 +08:00
Eng Zer Jun 5375161777
test: use `T.TempDir` to create temporary test directory (#16758) 
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.

Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
	defer func() {
		if err := os.RemoveAll(dir); err != nil {
			t.Fatal(err)
		}
	}
is also tedious, but `t.TempDir` handles this for us nicely.

Fixes: #16759
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
 2022-05-04 11:35:50 +08:00
Cai Yudong 21a1311f66
Merge utils/Utils.h into common/Utils.h (#16762) 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
 2022-05-03 12:05:50 +08:00
Cai Yudong 6a62ff18bf
Support easylogging config for segcore and knowhere (#16751) 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
 2022-05-03 08:39:49 +08:00
Cai Yudong d5db4ae463
Merge utils/Types.h with common/Types.h (#16445) 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
 2022-05-02 22:21:51 +08:00
bigsheeper 1a29337e6b
Print unflushed segmentIDs instead of whole SegmentInfo (#16301) 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
 2022-04-29 19:13:47 +08:00
bigsheeper f18b3c44ee
Print msgID instead of msg (#16268) 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
 2022-04-29 19:11:47 +08:00
cai.zhang 6440c0dd98
Add log for getting IndexNode's mertrics (#16747) 
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
 2022-04-29 19:07:47 +08:00
congqixia 9e09434a4b
Remove not used QueryService in querynode (#16735) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-04-29 18:15:48 +08:00
Jiquan Long 2fe8677cbf
Enable dimension check in Proxy when create index request received (#16718) 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
 2022-04-29 18:01:49 +08:00
jaime bb9ccbb7e2
Use a singleton kafka producer (#16739) 
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
 2022-04-29 17:29:47 +08:00
Letian Jiang 5b2b917987
Benchmark go/cgo parquet payload readers (#16736) 
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
 2022-04-29 15:59:47 +08:00
yah01 7dfab0aa13
Add unit test for case of failed to sync segments to shard leader (#16712) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-04-29 15:51:49 +08:00
zhenshan.cao 97757405de
Fix bug: wrong metrics name and forget to register metrics (#16714) 
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
 2022-04-29 15:35:47 +08:00
yah01 93416d5524
Fix LoadBalance loads the same segment multiple times (#16734) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-04-29 15:19:47 +08:00
shaoyue 2f49db9d3c
Implements remaining rest APIs (#16387) 
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
 2022-04-29 15:15:47 +08:00
yah01 415a0e5978
Fix miss segments/DmChannel when query by nodeID (#16719) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-04-29 14:11:47 +08:00
Letian Jiang a38c84e7e7
Lock meta-replica during search/query (#16703) 
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
 2022-04-29 13:37:47 +08:00
xige-16 515d0369de
Support string type in segcore (#16546) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
Co-authored-by: dragondriver <jiquan.long@zilliz.com>

Co-authored-by: dragondriver <jiquan.long@zilliz.com>
 2022-04-29 13:35:49 +08:00
jaime 68b1b82faf
Remove DataKV interface (#16692) 
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
 2022-04-28 21:03:47 +08:00
groot 21b5973253
Refine list import task api (#16690) 
Signed-off-by: groot <yihua.mo@zilliz.com>
 2022-04-28 17:21:47 +08:00
jaime 2205b878b1
Refine log in query_shard.go (#16693) 
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
 2022-04-28 17:13:48 +08:00
yah01 206b554d49
Sync the distribution of segments to shard leaders (#16685) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-04-28 16:01:48 +08:00
Xiaofan ed51ffd50f
Fix Compact Entity ttl param (#16665) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-04-28 11:51:47 +08:00
jaime c0a73dbe98
Using a temporary dir instead of a specified dir within embed etcd test (#16694) 
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
 2022-04-28 11:17:47 +08:00
yah01 7017756601
Validate the number of replicas for load collection/partitions request (#16697) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-04-28 10:54:00 +08:00
zhenshan.cao 0a953948af
Simplify monitoring metrics (#16687) 
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
 2022-04-27 23:03:47 +08:00
congqixia 3a6db2faeb
Fix handling segment change logic (#16695) 
Dispatch segmentChangeInfo to ShardCluster leader
Hold segment remove before search is done

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-04-27 22:23:46 +08:00
yah01 bb6cd4b484
Disable the unit test for the case of filter out unavailable leaders of GetShardLeaders (#16688) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-04-27 22:15:47 +08:00
Xiaofan be5d1f1243
Fix Datacoord ut when etcd is slow (#16689) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-04-27 21:49:47 +08:00
xiyichan 056fd9aa17
Correct wrong words (#16490) 
Signed-off-by: chenlifeng <chenlifeng0995@wezhuiyi.com>

Co-authored-by: chenlifeng <chenlifeng0995@wezhuiyi.com>
 2022-04-27 19:51:46 +08:00
Letian Jiang 2879796b42
Validate partitionIDs & segmentIDs in query request (#16684) 
* check partitions if they are released or unloaded
    * check segments if their collection/partition(s) are released or unloaded

Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
 2022-04-27 19:23:48 +08:00
XuanYang-cn 35b7267edb
Add ut for task_policies (#16663) 
See also: #16652

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
 2022-04-27 16:55:46 +08:00
yah01 68ef720d6b
Filter out the unavailable shard leaders (#16677) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-04-27 16:27:46 +08:00