milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Disable the unit test for the case of filter out unavailable leaders of GetShardLeaders (#16688) 

Signed-off-by: yah01 <yang.cen@zilliz.com>
pull/16690/head
yah01 2022-04-27 22:15:47 +08:00 committed by GitHub
parent be5d1f1243
commit bb6cd4b484
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
internal/querycoord/impl_test.go
View File

@ -1585,6 +1585,7 @@ func TestGetShardLeaders(t *testing.T) {
waitQueryNodeOnline(queryCoord.cluster, node1.queryNodeID)
waitQueryNodeOnline(queryCoord.cluster, node2.queryNodeID)
waitQueryNodeOnline(queryCoord.cluster, node3.queryNodeID)
defer node1.stop()
defer node2.stop()
defer node3.stop()
defer removeAllSession()
@ -1618,23 +1619,26 @@ func TestGetShardLeaders(t *testing.T) {
}
assert.Equal(t, 0, totalLeaders%3)
// Filter out unavailable shard
err = node1.stop()
assert.NoError(t, err)
err = removeNodeSession(node1.queryNodeID)
assert.NoError(t, err)
waitAllQueryNodeOffline(queryCoord.cluster, []int64{node1.queryNodeID})
resp, err = queryCoord.GetShardLeaders(ctx, getShardLeadersReq)
assert.NoError(t, err)
assert.Equal(t, commonpb.ErrorCode_Success, resp.Status.ErrorCode)
for i := 0; i < len(resp.Shards); i++ {
assert.Equal(t, 2, len(resp.Shards[i].NodeIds))
}
// TODO(yah01): Disable the unit test case for now,
// restore it after the rebalance between replicas feature is implemented
node4, err := startQueryNodeServer(ctx)
assert.NoError(t, err)
waitQueryNodeOnline(queryCoord.cluster, node4.queryNodeID)
defer node4.stop()
// Filter out unavailable shard
// err = node1.stop()
// assert.NoError(t, err)
// err = removeNodeSession(node1.queryNodeID)
// assert.NoError(t, err)
// waitAllQueryNodeOffline(queryCoord.cluster, []int64{node1.queryNodeID})
// resp, err = queryCoord.GetShardLeaders(ctx, getShardLeadersReq)
// assert.NoError(t, err)
// assert.Equal(t, commonpb.ErrorCode_Success, resp.Status.ErrorCode)
// for i := 0; i < len(resp.Shards); i++ {
// assert.Equal(t, 2, len(resp.Shards[i].NodeIds))
// }
// node4, err := startQueryNodeServer(ctx)
// assert.NoError(t, err)
// waitQueryNodeOnline(queryCoord.cluster, node4.queryNodeID)
// defer node4.stop()
// GetShardLeaders after release collection, it should return meta failed
status, err = queryCoord.ReleaseCollection(ctx, &querypb.ReleaseCollectionRequest{