Print collectionName when load failed (#16878)

Signed-off-by: xige-16 <xi.ge@zilliz.com>
pull/16910/head
xige-16 2022-05-11 09:47:53 +08:00 committed by GitHub
parent be688d894a
commit 9e6d9fb7d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 1 deletions

View File

@ -1311,7 +1311,12 @@ func (sct *showCollectionsTask) Execute(ctx context.Context) error {
}
if resp.Status.ErrorCode != commonpb.ErrorCode_Success {
return errors.New(resp.Status.Reason)
// update collectionID to collection name, and return new error info to sdk
newErrorReason := resp.Status.Reason
for _, collectionID := range collectionIDs {
newErrorReason = ReplaceID2Name(newErrorReason, collectionID, IDs2Names[collectionID])
}
return errors.New(newErrorReason)
}
sct.result = &milvuspb.ShowCollectionsResponse{

View File

@ -555,3 +555,7 @@ func ValidatePassword(password string) error {
}
return nil
}
func ReplaceID2Name(oldStr string, id int64, name string) string {
return strings.ReplaceAll(oldStr, strconv.FormatInt(id, 10), name)
}

View File

@ -610,3 +610,9 @@ func TestValidatePassword(t *testing.T) {
res = ValidatePassword("aaaaaaaaaabbbbbbbbbbccccccccccddddddddddeeeeeeeeeeffffffffffgggggggggghhhhhhhhhhiiiiiiiiiijjjjjjjjjjkkkkkkkkkkllllllllllmmmmmmmmmnnnnnnnnnnnooooooooooppppppppppqqqqqqqqqqrrrrrrrrrrsssssssssstttttttttttuuuuuuuuuuuvvvvvvvvvvwwwwwwwwwwwxxxxxxxxxxyyyyyyyyyzzzzzzzzzzz")
assert.Error(t, res)
}
func TestReplaceID2Name(t *testing.T) {
srcStr := "collection 432682805904801793 has not been loaded to memory or load failed"
dstStr := "collection default_collection has not been loaded to memory or load failed"
assert.Equal(t, dstStr, ReplaceID2Name(srcStr, int64(432682805904801793), "default_collection"))
}