Commit Graph

1830 Commits (a6a64692f821fa6b377a7254e916d3b7a4006f8a)

Author SHA1 Message Date
cai.zhang 63a83f027f
Reduce running unit test time for indexcoord (#7779)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-14 10:41:21 +08:00
cai.zhang 8a458b7a38
Add log for building index about num rows (#7811)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-14 10:27:06 +08:00
bigsheeper 691e4c5bc9
Use definitional type instead of raw type (#7797)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-09-14 10:25:26 +08:00
bigsheeper 27beb033de
Add task unittest for query node (#7820)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-09-14 10:24:48 +08:00
dragondriver bcf9b4e240
Coverage error case of searchTask.PreExecute (#7826)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-14 10:24:00 +08:00
bigsheeper 664d4ca923
Fix index loader test (#7805)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-09-14 10:21:08 +08:00
yukun 5c997710ab
Change Assert() to AssertInfo() to return error messages (#7843)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-09-14 10:06:40 +08:00
yukun f1366b9451
Rename rocksmq unittests (#7846)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-09-14 09:55:00 +08:00
Xiaofan 00a5c39c2f
Remove unnecessary variables in allocator (#7849)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-09-14 09:54:31 +08:00
nameczz 87460665e0
improve HasCollectionRequest and DropCollectionRequest comments (#7693)
Signed-off-by: Gitea <zizhao.chen@zilliz.com>
2021-09-14 09:53:21 +08:00
Xiangyu Wang 60c11c85ad
[skip ci]Rename unit tests (#7844)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-09-13 21:24:58 +08:00
dragondriver 8d239b6473
Add test cases for search task (#7796)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-13 17:12:19 +08:00
congqixia 85d73358cc
Remove ctx from LongTermChecker (#7792)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-13 16:50:57 +08:00
bigsheeper 73ab06c628
Decrease unittests execution time in query node (#7791)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-09-13 16:37:01 +08:00
groot c242b8bb25
Rename unittest for flowgraph (#7794)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-13 16:34:26 +08:00
groot 203010524d
Rename unittest for metricsinfo (#7795)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-13 16:33:27 +08:00
groot a953c912b2
Add unittest for timeticksync (#7793)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-13 16:32:44 +08:00
congqixia e2c15d5b01
[skip ci]Add comment for ClusterStore (#7785)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-13 15:59:55 +08:00
cai.zhang b1805d980c
Reduce running unit test time for indexnode (#7773)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-13 12:00:08 +08:00
cai.zhang 9b0aacd07a
Increase code coverage rate for proxy (#7727)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-13 11:58:11 +08:00
sunby 4c18910acd
Improve log print in rootcoord (#7354)
issue: #7306
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-09-13 11:56:42 +08:00
zhenshan.cao db7fdefcd0
Add unittest for proxy (#7764)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-13 10:56:03 +08:00
Xiaofan 619c4393f3
Refine logs in proxy search path(#7357) (#7753)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-09-12 17:54:01 +08:00
dragondriver 5a3fc37584
Add test cases for create collection (#7759)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-11 18:06:02 +08:00
bigsheeper ab7ded2202
Add loader and streaming unittests for query node (#7762)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-09-11 17:56:01 +08:00
bigsheeper 44bc0af063
Add node and queryCollection unittests for query node (#7719)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-09-11 17:26:01 +08:00
bigsheeper 3c01839d0d
Add impl and plan unittests for query node (#7712)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-09-11 17:22:01 +08:00
Cai Yudong 27dcf698d3
Support set segcore chunk_size via config file (#7635)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-11 14:40:01 +08:00
dragondriver a872a4357c
Add more test cases for proxy implementation (#7685)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-11 11:36:22 +08:00
yukun 92295b77a1
Add DestroyTopic and DestroyConsumerGroup for CloseRocksMQ (#7730)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-09-10 20:54:01 +08:00
xige-16 15a6f30ac4
Add ut for querycoord's impl (#7728)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-09-10 19:14:01 +08:00
bigsheeper 0e81c62031
Check collection and plan before calling cgo functions (#7733)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-09-10 18:12:01 +08:00
groot c8f860dcfb
Add unittest for proxy_client_manager (#7729)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-10 18:10:00 +08:00
yukun d60ea8bc21
Change prefix length to FixedChannelNameLen + 1 (#7717)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-09-10 17:42:10 +08:00
bigsheeper cb5cd1cf12
Add index unittests for query node (#7674)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-09-10 17:11:09 +08:00
groot 020f109dd8
Add unittest for rootcoord util (#7688)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-10 16:41:48 +08:00
sunby db01040b53
Fix query request lost bug (#7715)
Issue: #7633
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-09-10 16:34:44 +08:00
XuanYang-cn ce33855652
[skip-ci]Fix datanode comment typo (#7689)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-10 14:46:00 +08:00
Xiangyu Wang 494600c37c
Add unit tests for msg.go (#7691)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-09-10 14:24:02 +08:00
cai.zhang be9427e8b9
Increase covd coverage for paramtable (#7583)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-10 14:14:12 +08:00
Cai Yudong 4e23ed9a18
Revert apply physical channels from pool (d5f7e358 and 3b960969) (#7687)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-10 13:00:00 +08:00
congqixia d3be316bc2
Add Comment for datacoord cluster (#7676)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-10 11:26:00 +08:00
Xiangyu Wang 6b86a18a7e
Comments unused msg from msg.go (#7686)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-09-10 11:12:05 +08:00
groot 16a6afa9bd
Fix build version typo (#7639)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-10 11:10:00 +08:00
yukun 5a303e7672
Fix rocksmq load with prefix (#7678)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-09-10 10:22:01 +08:00
yukun 34228eb74b
Add topic lock for DestroyConsumerGroup (#7636)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-09-10 10:20:00 +08:00
nameczz a392f1005c
improve CreateCollectionRequest comment in milvus.proto (#7590)
Signed-off-by: Gitea <zizhao.chen@zilliz.com>
2021-09-10 10:06:00 +08:00
bigsheeper 8216478b3d
Add replica and insertNode unittests for query node (#7638)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-09-10 09:33:43 +08:00
Xiangyu Wang 42aafdc407
Remove unused msg from msg.go (#7612)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-09-09 19:56:00 +08:00
sunby 49b6c3101d
Remove datacoord useless code (#7673)
Issue: #7624
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-09-09 19:08:03 +08:00
Xiangyu Wang 624ea2f676
Add unit tests for msg.go (#7659)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-09-09 19:03:40 +08:00
dragondriver 596357dc85
Add more data definition test cases (#7623)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-09 19:02:08 +08:00
Cai Yudong d5f7e358aa
Let dml tolerant physical channels generated by old version (#7644)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-09 18:08:02 +08:00
zwd1208 02d5397c6f
[skip ci] Remove useless commets (#7662)
Signed-off-by: Weida Zhu <weida.zhu@zilliz.com>
2021-09-09 18:00:19 +08:00
zhenshan.cao 29e5138274
Fix unittest: timeout caused by excessive use of resources (#7653)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-09 17:39:30 +08:00
bigsheeper 1a5e5989c8
Add segment unittests for query node (#7632)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-09-09 17:36:02 +08:00
groot 314eed2172
Update storage unittest (#7637)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-09 17:12:55 +08:00
congqixia 8e814a2972
Make flowgraph Close only once (#7631)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-09 17:12:38 +08:00
groot a3666c843f
Add unittest for chunk manager (#7628)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-09 17:12:15 +08:00
cai.zhang f6621dc847
Increase code coverage for indexnode component (#7520)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>

Co-authored-by: edward.zeng <jie.zeng@zilliz.com>
2021-09-09 17:09:08 +08:00
sunby 06cee85a39
Add data node unit tests (#7622)
Issue: #6357
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-09-09 16:40:00 +08:00
XuanYang-cn 64aad49959
Add ut in datasync service to 88% (#7615)
See also: #6357

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-09 15:36:01 +08:00
congqixia 69794fd32d
Refactor insertBufferNode and add unit tests (#7621)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-09 15:00:00 +08:00
groot dbd2a02462
Add unittest for VectorChunkManager (#7610)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-09 14:34:00 +08:00
zhenshan.cao 89358ad91e
Deep copy rocksdb data to byte slice (#7605)
Add unittest

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-09 10:56:00 +08:00
congqixia c96b19a640
Add datacoord metricsinfo unit test (#7595)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-09 10:16:00 +08:00
XuanYang-cn 762060e670
Add ut for segmentReplica to 100% (#7589)
See also: #6357
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-09 10:14:00 +08:00
bigsheeper 5906551f41
Add task unittest for query node (#7599)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-09-09 10:10:00 +08:00
dragondriver 9b21b3b5fd
Initialize test framework of proxy (#7563)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-09 10:06:29 +08:00
godchen 3c2821e5e2
Add rmq consumer close (#7596)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-09-08 21:49:59 +08:00
bigsheeper d3a18a66b5
Add tSafeReplica and task scheduler unittests (#7587)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-09-08 20:50:00 +08:00
XuanYang-cn 074b610811
Add ut for dmstream_input_node to 100% (#7593)
See also: #6357

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-08 19:12:00 +08:00
groot 159d3702a0
Rename unittest for indexparamcheck (#7580)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-08 19:10:03 +08:00
bigsheeper 50c677f72b
Remove useless message and add service time node unittest (#7565)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-09-08 17:10:15 +08:00
Xiangyu Wang 2224099f22
Add unit tests for msg.go (#7577)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-09-08 16:54:00 +08:00
groot ae3a43cf37
Rename unittest for funcutil (#7581)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-08 16:53:30 +08:00
groot 618fef0a43
Add unittest for mqclient (#7578)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-08 16:52:35 +08:00
sunby 79516dacd2
Add log unit tests (#7561)
Issue: #7491
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-09-08 15:03:59 +08:00
zhenshan.cao b0524adbd8
Support specified shard number when create collection (#7482)
Add shards_num to CollectionInfo

Modify dmlChannelNum config

Compatible with old meta

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-08 15:00:00 +08:00
cai.zhang e1081b6783
Increase indexcoord component code coverage (#7558)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-08 14:23:59 +08:00
yukun a560aefc36
Fix search result is wrong when the term content in expression is not in order (#7557)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-09-08 11:49:59 +08:00
congqixia 664aeb09c6
Add ut and comments for datacoord meta (#7560)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-08 11:35:59 +08:00
groot 58700dedbc
Update unittest name of distance (#7537)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-08 11:28:25 +08:00
yukun fbc352263c
Improve rocksmq client code coverage (#7540)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-09-08 11:03:59 +08:00
XuanYang-cn 4785e452be
Fix Arrow unable to find Boost error (#7552)
Resolve: #7549

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-08 10:59:59 +08:00
sunby bbb6051cdc
Remove time-consuming test (#7551)
issue: #7491
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-09-08 10:59:52 +08:00
XuanYang-cn a5767e05c6
Add ut for flowgraph_delete_node to 100% (#7550)
See also: #6357
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-08 10:41:59 +08:00
congqixia 76f5264e79
Fix MqMsgStream Seek logic (#7536)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-07 16:35:59 +08:00
sunby 62f4cb5e1b
Remove stats watcher (#7501)
issue: #7500
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-09-07 16:11:07 +08:00
sunby 668d10d1da
Add log unit tests (#7524)
issue: #7491
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-09-07 16:07:58 +08:00
bigsheeper bcccd767ac
Add unittests for querynode (#7510)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-09-07 15:45:59 +08:00
XuanYang-cn 29756c6ce8
Add ut for flow_graph_dd_node to 100% (#7511)
This PR:
- Change mutex to sync.Map
- Add ut for flow_graph_dd_node.go to 100%

See also: #6357

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-07 15:41:59 +08:00
groot 89815a64d7
Update unittest name of paramtable (#7526)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-07 15:20:40 +08:00
xige-16 468bef4478
Fix dataset's memory leak in knowWhere when search (#7527)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-09-07 14:25:59 +08:00
congqixia 5b22697ec4
Add segment manager unit tests (#7525)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-07 13:59:58 +08:00
bigsheeper b7103357fd
Load failed if collection beyonds the memory limit (#7434)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-09-07 11:35:18 +08:00
Cai Yudong d15d3fa0ac
Improve rootcoord codecov (#7518)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-07 11:16:37 +08:00
groot 1401ed516d
Add unittest for flowgraph (#7512) 2021-09-07 09:39:47 +08:00
dragondriver 42b687bf48
Add unittest for task scheduler (#7508)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-06 20:49:04 +08:00
yukun 7025a6e925
Improve rocksmq code coverage (#7483)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-09-06 19:36:42 +08:00
cai.zhang e6e03fc93f
Add unittest for index component (#7475)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-06 17:54:41 +08:00
congqixia fb4e23bc79
Add datacoord server unit tests (#7499)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-06 17:02:41 +08:00
sunby 5e0d724738
Add log unit tests (#7492)
issue: #7491
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-09-06 16:50:42 +08:00
Xiangyu Wang 79a0a5482f
Add unit test for mq_factory (#7477)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-09-06 14:59:21 +08:00
zhenshan.cao 86afde4598
Fix unittest for rootcoord, should filter out timetick msg first (#7490)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-06 11:52:41 +08:00
groot af7b7537f0
Update unittest for calc_distance (#7488) 2021-09-06 11:35:02 +08:00
congqixia 1f590d6c26
Add datacoord services related unit tests (#7467)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-06 11:12:42 +08:00
groot ccfb350bd1
Unittest for funcutil (#7473)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-04 12:13:25 +08:00
Cai Yudong 5a16236768
Improve codecov for paramtable and typeutil (#7471)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-04 10:22:41 +08:00
dragondriver 960741ee16
Support more detailed metrics information (#7472)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-03 19:35:47 +08:00
dragondriver 1db573731b
Cache the system information metrics (#7436)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-03 17:15:26 +08:00
yukun 94272bba87
Support query by expression (#7386)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-09-03 17:12:55 +08:00
godchen db8067d61c
Add trace ut (#7445)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-09-03 15:41:25 +08:00
groot 229965a9bb
Unittest for indexparamcheck (#7464)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-03 14:22:17 +08:00
Xiangyu Wang acf4354b83
Add logs in rootcoord (#7457)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-09-03 14:10:10 +08:00
dragondriver 9b87da1ee8
Fix deadlock of channels time ticker (#7444)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-03 11:53:29 +08:00
godchen 8b1ae98fa9
Add id allocator ut (#7440)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-09-03 09:44:10 +08:00
Cai Yudong 7edd96989f
Improve codecov for paramtable and typeutil (#7451)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-02 22:18:10 +08:00
yukun d5d73833b2
Add some logs in rocksmq retention (#7403)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-09-02 20:04:10 +08:00
congqixia d3027c0d28
Fix possible deadlock (#7428)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-02 14:56:10 +08:00
Cai Yudong bd3056fcbe
Improve tso codecov (#7407)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-01 18:29:59 +08:00
dragondriver 3721cbfea1
Proxy metrics integrates with other coordinators (#7400)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-01 17:35:00 +08:00
yukun 71aa300499
Fix rocksmq retention panic when delete by message size (#7393)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-09-01 12:03:58 +08:00
dragondriver 89748ac639
Expose metrics of data cluster (#7177)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-01 10:13:15 +08:00
Cai Yudong 3b9609692b
Apply for msgstream from pool when creating collection (#7377)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-31 18:35:58 +08:00
godchen 08a31010e9
Change log (#7366)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-08-31 12:07:58 +08:00
dragondriver f0dbdd7f13
Expose metrics of root coordinator (#7228)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-08-31 11:45:59 +08:00
sunby 8f660ae4e6
Add log print in proxy (#7369)
issue: #7316
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-08-31 11:17:59 +08:00
Cai Yudong f4b53df727
Revert "Apply for msgstream from pool when creating collection (#7323)" (#7376)
This reverts commit e6de86a433.
2021-08-31 11:07:58 +08:00
dragondriver 5b354313df
Add unittest for timestamp allocator (#7367)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-08-31 10:33:58 +08:00
dragondriver 84bddd0a03
Add unittest cases for proxy (#7364)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-08-31 10:25:59 +08:00
Cai Yudong e6de86a433
Apply for msgstream from pool when creating collection (#7323)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-31 09:47:58 +08:00
congqixia 1c88c8b0a5
Clean fmt.Println in util/flowgraph (#7355)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-30 15:29:57 +08:00
congqixia 65f168eac1
Fix datanode corner cases (#7336)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-30 10:03:58 +08:00
xige-16 af574d17d5
Fix querycoord panic when stop nil conn of querynoClient (#7346)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-08-28 12:51:57 +08:00
zhenshan.cao cc99bae250
Add unittest for proxy (#7342)
Fix unittest data race

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-08-28 10:21:57 +08:00
cai.zhang 880aa540e6
Fix bug for expression boundary (#7339)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-08-28 10:13:57 +08:00
godchen c333af0dcf
Add query node segment filter (#7303)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-08-28 10:12:00 +08:00
godchen 2dc2cb1a28
Fix collection nil when add query collection (#7311)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-08-27 17:51:56 +08:00
bigsheeper 14391fe9a2
Release flowgraphs properly (#7266)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-08-27 17:03:56 +08:00
bigsheeper 1e60cccaf9
Set inMemoryPercentage to 0 when releasing partition (#7310)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-08-27 16:51:11 +08:00
congqixia 0281bd8d22
Change context to correct package (#7331)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-27 15:37:56 +08:00
zhenshan.cao 7c60e6aa00
Avoid port conflicts between embedded etcd and external etcd (#7320)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-08-27 10:13:57 +08:00
sunby 920b09cf7d
Print insert log once receive a request (#7318)
issue: #7316
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-08-27 10:08:47 +08:00
Xiangyu Wang c62f23e201
[skip ci]Remove neza2017 from reviewers (#7324)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-08-27 00:27:36 +08:00
xige-16 055d94ede1
Add ut for queryCoord (#7212)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-08-26 14:17:54 +08:00
groot 8701c477e2
Add delete api into proto (#7304)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-08-26 12:15:52 +08:00
congqixia 4d9f89df09
Add unit test for 7150 fix (#7276)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-25 14:41:52 +08:00
godchen b4c55f6b3c
Add delete node (#7261)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-08-25 11:41:52 +08:00
congqixia daae05641a
Construct bloom filter when inserting (#7268)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-25 10:29:52 +08:00
congqixia d83bc7fb54
Fix 0 ts when build index (#7272)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-24 21:15:52 +08:00
sunby 4d56d53c0b
Add a tool to move binlog path to SegmentInfo (#7243)
issue: #7214
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-08-24 15:51:51 +08:00
bigsheeper 653ec6cedb
Remove service time check in streaming search (#7253)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-08-24 15:07:52 +08:00
Cai Yudong 0ab70271a6
correct empty search result handle (#7244)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-24 11:13:52 +08:00
Xiaofan 58b2089692
Import Embedded Etcd Kv Part 1(#7112) (#7174)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-08-24 09:45:51 +08:00
wt 780a4d2c8e
Update script of run_go_codecov (#7248)
Signed-off-by: wangting0128 <ting.wang@zilliz.com>
2021-08-23 22:01:51 +08:00
congqixia f5451d12f3
Refactor datacoord allocator (#7226)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-23 17:59:51 +08:00
godchen db25550fd0
Add segment filter interface (#7231)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-08-23 17:49:50 +08:00
Cai Yudong 8405d90f5e
proxy add illegal check for search result (#7227)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-23 17:03:51 +08:00
godchen 33583525c5
Add connection manager (#6867)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-08-23 10:00:12 +08:00
godchen bf2c427609
Fix connection timeout (#7203)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-08-20 17:52:11 +08:00
congqixia be5c492e5a
Add datacoord unit tests (#7197)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-20 17:50:12 +08:00
congqixia 881d0af1fc
Add sync logic in TestWatchChannel (#7188)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-20 17:48:13 +08:00
XuanYang-cn 9e71daa759
Fix rocksdb not installed problem (#7200) 2021-08-20 17:46:48 +08:00
groot 1c6f5104f7
Improper error returned by calc_distance (#7175)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-08-20 16:19:42 +08:00
sunby 6e34f4c7f1
Add a seal policy which restrict the lifetime of a segment (#7172)
issue: #7164
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-08-20 15:42:12 +08:00
紫晴 7233b62dad
Enable 70% of delta condition judgment for codecov (#7160)
Signed-off-by: wangting0128 <ting.wang@zilliz.com>
2021-08-19 15:50:12 +08:00
congqixia ec9ccd8bd1
Fix DropCollection not processed by datanode (#7151)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-19 15:06:12 +08:00
cai.zhang 171088409b
Increase the timeout for grpc connection when create index (#7163)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-08-19 14:32:11 +08:00
xige-16 76066b5659
Fix IVF_FLAT index's wrong meta_data (#7167)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-08-19 14:26:11 +08:00
sunby 3cc210da26
Add flush interval (#6996)
Time tick message is sent about per 0.2 seconds. DataCoord will call
`FlushSegment` too frequently. We add a min interval for segment flush. A
segment will called `FlushSegment` only once between the interval.

issue: #6995
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-08-19 14:08:10 +08:00
sunby 4f7c3e7d3a
Save binlog path in SegmentInfo (#6590)
issue: #6589
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-08-19 13:00:12 +08:00
dragondriver 648d22ee40
Expose metrics of IndexCoord and IndexNodes (#7157)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-08-19 10:28:10 +08:00
godchen 8cc24e09c9
Make users get vectors without using local storage (#7134)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-08-18 16:30:11 +08:00
紫晴 09525f5723
Update file of codecov (#7144)
Signed-off-by: wangting0128 <ting.wang@zilliz.com>
2021-08-18 14:48:11 +08:00
Cai Yudong 305fa9c17e
Fix timestamp go back issue for timeticksync (#7123)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-18 14:36:10 +08:00
groot b4eb20f2c0
Fix calc_distance TANIMOTO bug (#7140)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-08-18 11:16:10 +08:00
dragondriver e45cb6c644
Expose system topology information by proxy (#7137)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-08-18 10:12:10 +08:00
Cai Yudong 21117241ec
Let system panic if kv operation fail (#7143)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-17 23:06:10 +08:00
cai.zhang 3d83e99a99
Adding indexnode should be processed asynchronously (#7141)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-08-17 20:26:11 +08:00
cai.zhang c2a4bd3e9c
Lock when writing meta instead of trying to connect to indexnode (#7136)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-08-17 17:54:10 +08:00
紫晴 1b4231b4e8
Add yaml file of codecov (#7124)
* Add yaml file of codecov

Signed-off-by: wangting0128 <ting.wang@zilliz.com>

* Update code of codecov

Signed-off-by: wangting0128 <ting.wang@zilliz.com>
2021-08-17 11:56:11 +08:00
dragondriver 7eb8a665b2
Expose metrics of QueryCoord and QueryNodes (#7113)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-08-17 10:06:11 +08:00
congqixia fb22d122e5
Add EarliestMessageID patch logic (#7119)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-16 19:08:09 +08:00
yukun 61bda45e35
Add ConfAdapter to check search (#6971)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-08-16 18:54:10 +08:00
yukun 847586eb95
Add rocksmq retention (#6617)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-08-16 18:46:10 +08:00
yukun 671b2737d2
Remove RetrieveRequest and RetrieveTask (#6848)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-08-16 17:06:10 +08:00
xige-16 b035ec5c7b
Enable search when querynode only load segment (#7104)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-08-16 12:24:09 +08:00
sunby 9551dc3b7e
Fix segment auto flush bug (#7085)
issue: #7084
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-08-16 11:00:09 +08:00
Cai Yudong e771bda92f
optimize retrieve output vector code structure (#7102)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-14 11:18:10 +08:00
cai.zhang 382fa6f274
IndexNode dose not need to wait for IndexCoord to start to comlete (#7074)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-08-13 18:12:08 +08:00
XuanYang-cn 86ca96a02e
Fix master branch unittest error (#7083)
Resolves: #7080

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-08-13 14:00:14 +08:00
XuanYang-cn 6c5be83ea1
Refactor NewEtcdKV API (#7075)
This PR mainly did the following 3 things:

- Refactor NewEtcdKV API
- Add unittests for `kv/etcd/`, raise the coverage
up to 94%
- Correct some APIs from version to revision

The old NewEtcdKV() API took `clientv3.Client` as
one of the input, making everyone who using this API
had to create a new `clientv3.Client`. So there're a lot
of repeated codes everywhere.

Meanwhile, someplace didn't even check whether the
`clientv3.New()` returned error or not, and the old API
also didn't check whether the clientv3.Client was Nil.
This caused issue#6955.

Ectd's version and revision have nothing alike, they
represent different concepts, but our APIs kind of
mixed them all up. So I correct those APIs' names.

Resolves: #6955

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-08-13 11:04:09 +08:00
congqixia e1b3273d1c
Add Datanode watch etcd channel (#6965)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-13 10:50:09 +08:00
sunby 5c383d1d02
Add a checker to listen for the timetick. (#7061)
issue: #7060
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-08-12 19:58:08 +08:00
Xiangyu Wang 5e78fd6a97
[skip ci]Update approvers (#7063)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-08-12 19:36:09 +08:00
Cai Yudong 6c75301c70
optimize search reduce logic (#7066)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-12 18:00:11 +08:00
dragondriver b3f10ae5cc
Fix 6990, enhance the log when parsing grpc recv/send parameters (#6993)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-08-12 16:16:09 +08:00
congqixia 3f21e3d062
Fix querynode tt producer leak (#7059)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-12 14:16:08 +08:00
bigsheeper b9d3897deb
Return error when any failed detected in loadSegment (#7005)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-08-12 14:14:08 +08:00
Cai Yudong 85ea051ddc
change growing segment default value to -1 (#7054)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-12 12:32:07 +08:00
sunby 31182e52a9
Fix expire allocation bug (#7053)
issue: #7052
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-08-12 10:48:08 +08:00
godchen 7fc7623b92
Add vector data memroy existence check (#7044)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-08-11 19:50:09 +08:00
XuanYang-cn 9d81a90402
Fix mem leak of flush cache in DataNode (#6862)
Resolves: #6858

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-08-11 14:24:09 +08:00
groot bdb8396e74
Fix CalcDistance wrong result when fetting vectors from collection (#6976)
* Fix CalcDistance wrong result when fetting vectors from collection

Signed-off-by: yhmo <yihua.mo@zilliz.com>

* Fix CalcDistance wrong result when fetting vectors from collection

Signed-off-by: yhmo <yihua.mo@zilliz.com>

* preset capacity

Signed-off-by: yhmo <yihua.mo@zilliz.com>

* typo

Signed-off-by: yhmo <yihua.mo@zilliz.com>

* error check

Signed-off-by: yhmo <yihua.mo@zilliz.com>

* code lint

Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-08-10 11:59:28 +08:00
godchen 7557616fea
Change client timeout (#6982)
* Change client timeout

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* change timeout

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* change timeout time

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix conflicts

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix ut

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* remove ut

Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-08-06 14:09:26 +08:00
congqixia 9eb35996b5
Fix pulsar consumer goroutine leakage (#7004)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-06 09:45:24 +08:00
sunby 454620dfaa
Add unit test in datacoord (#6985)
issue: #6984
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-08-04 16:59:25 +08:00
dragondriver ad77a6e0d4
Fix #6859, increase the MaxCallRecvMsgSize and MaxCallSendMsgSize of grpc client (#6861)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-08-04 13:03:24 +08:00
bigsheeper 07cc449fbf
Fix data race in flow graph (#6946)
* Fix data race in flow graph

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* add cancel func to flowgraph

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-08-03 22:43:25 +08:00
xige-16 c8a1f780c1
Use proto marshal instead of MarshalTextString in querycoord (#6958)
* use proto marshal instead of marshalToText

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* log error

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* don't retry after init meta/cluster/scheduler failed

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* fix return err

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* log inconsistent task info

Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-08-03 22:03:25 +08:00
bigsheeper 4123deef9e
Return error message in grpc.LoadSegment in query node (#6908)
* return load error

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* init streaming meta in loadSegment

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* fix excluded init

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* improve impl

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-08-03 22:01:27 +08:00
xige-16 09199170a4
sync call querycoord releaseXXXX (#6978)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-08-03 21:47:24 +08:00
Xiaofan aba234fa3f
Fix Msgstream exponential retry (#6807)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-08-03 10:39:24 +08:00
dragondriver d2767f920c
Fix index parameters check of RHNSWPQ (#6950)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-08-03 10:25:25 +08:00
XuanYang-cn 47df4a2e57
Fix DataNode BackGroudGC problem (#6551)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-08-03 09:59:24 +08:00
xige-16 87c5a49d9a
Refactor showCollection/showPartition to get load state in memory (#6935)
* refactor showCollection/showPartition to get load state in memory

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* update proto

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* update proto

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* update milvus.proto

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* add show result log to debug

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* fix wrong err message

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* update pymilvus-orm version

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* fix repeated load error

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* update proto

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* fix status nil error

Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-08-02 22:39:25 +08:00
congqixia 4d5eeb2890
Fix minio object leaking goroutine (#6944)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-02 15:25:24 +08:00
Cai Yudong fe50f97726
Use id to tell search result validation in proxy reduce stage (#6905)
* use id to tell search result validation

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* enable test_search_binary_hamming_flat_index

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* code optimize

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fix merge retrieve result issue

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-02 10:25:49 +08:00
bigsheeper e8ea8b51d5
improve query node log (#6897)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-07-31 10:47:22 +08:00
bigsheeper 7307332fab
Add nil check (#6832)
* add nil check

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* use grpc functions

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* use grpc functions

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* fix indexCoord crash

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-07-29 20:11:23 +08:00
bigsheeper eee0f1e077
Add mutex for segment of segCore in querynode (#6870)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-07-29 16:03:22 +08:00
cai.zhang d51fec6678
Enhance log when create index failed (#6871)
* Enhance log when create index failed

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix bug for repeatedly drop index

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>
2021-07-29 14:47:22 +08:00
godchen 61786f769c
Add file exist check (#6840)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-07-28 16:31:22 +08:00
sunby 23bffe399d
Enhance log print in data coordinator (#6681)
issue: #6680
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-07-28 11:43:22 +08:00
zhenshan.cao 8a1a841011
FixBug: Incorrect handling of time synchronization (#6814)
* FixBug: proxy send wrong sync timetick and DataCoord did not filter channel

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-07-27 14:34:48 +08:00
dragondriver 3cc8ee298e
Filter NaN when reducing search results (#6806)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-27 10:19:21 +08:00
xaxys e43b43e7d8
Refactor `RangeExpr` & `CompareExpr` (#6786)
* Changed `RangeExpr` proto to `UnaryRangeExpr` & `BinaryRangeExpr`
Several unit test unpassed.

Signed-off-by: xaxys <tpnnghd@163.com>

* Fix bugs to pass unit test. Fix format.

Signed-off-by: xaxys <tpnnghd@163.com>

* Remove debug information.

Signed-off-by: xaxys <tpnnghd@163.com>

* Fix format.
Remove debug information.
Unify variable name.
Add error information.
Remove `CompareExpr` test in `test_c_api.cpp`.

Signed-off-by: xaxys <tpnnghd@163.com>

* Fix code format.

Signed-off-by: xaxys <tpnnghd@163.com>

* Update `Plan.cpp`.

Signed-off-by: xaxys <tpnnghd@163.com>
2021-07-25 10:23:19 +08:00
zhenshan.cao 2962d31a5f
Fixbug: segment allocate but return value incorrect (#6788)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-07-24 20:49:20 +08:00
godchen db94d7771f
Read vector from disk (#6707)
* Read vector from disk

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* go fmt

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix git action error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix test error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix action error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix caculate error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* change var name

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* remove unused method

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* remove unused method

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix len error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* remove unused code

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* change bytes to float method

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* change float to bytes method

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix action error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-07-24 09:25:22 +08:00
sunby aa20d88f6f
Fix datacoord stop bug (#6642)
issue: #6641
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-07-24 09:25:14 +08:00
sunby fc74a0f578
Auto create new segments when allocating rows more than (#6665)
max number of rows per segment

If user insert too much rows in a request. Now we will return a failed
response. Maybe auto creating new segments to hold that much rows is a
better way.

issue: #6664
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-07-23 21:58:33 +08:00
sunby 63387c83ef
Remove collection check when saving binlog (#6658)
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-07-23 21:23:22 +08:00
dragondriver 2821c08560
Add unittests for metric_type: tanimoto (#6773)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-23 20:59:33 +08:00
dragondriver cf8e9d52b1
Reduce the log of proxy (#6766)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-23 20:33:34 +08:00
bigsheeper 21bc5810c0
remove redundant log of query node (#6768)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-07-23 20:09:33 +08:00
bigsheeper 2f44fc40a3
fix historical unittest (#6705)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-07-23 19:55:07 +08:00
FluorineDog aba21baf82
refactor expr executor to use single bitset (#6667)
Signed-off-by: fluorinedog <fluorinedog@gmail.com>
2021-07-23 15:30:12 +08:00
neza2017 5adb69161f
Set CollectionInfo.CreateTime to the timestamp when save the metadata into etcd, (#6763)
not the timestamp when RootCoord receive the CreateCollection Request

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-07-23 14:36:12 +08:00
cai.zhang e1b52b0583
Add unittest for IndexCoord and IndexNode (#6698)
* Add unittest for IndexCoord and IndexNode

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix verifiers

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>
2021-07-23 10:44:12 +08:00
cai.zhang 9aa56cd7b8
Add log for IndexCoord and IndexNode (#6597)
* Add log for IndexCoord and IndexNode

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Make verifier

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Delete unused script

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>
2021-07-22 11:40:11 +08:00
cai.zhang a3c662c7bf
Add watchWithVersion interface for etcdKV (#6663)
* Add watchWithVersion interface for etcdKV

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Add unittest

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Add LoadWithVersion interface

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>
2021-07-21 18:20:11 +08:00
dragondriver 67c1fdd2c0
Show/Describe collections/partitions with created timestamp (#6700)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-21 18:00:14 +08:00
Cai Yudong cbb4052fdb
Support search and query output fields using wildcard (#6671)
* update wildcard polocy for search and query

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* mark xfail cases

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* mark xfail cases

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* optimize debug log

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fix static-check

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-07-21 14:52:12 +08:00
dragondriver 26f890b5f5
Remove too frequent timetick log (#6682)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-21 11:26:11 +08:00
congqixia 9b1708f6e5
Fix proxy crashes when retrieve task is called (#6656)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-07-20 22:33:09 +08:00
Cai Yudong 744f2c7f51
optimize test_c_api.cpp (#6637)
* optimize test_c_api.cpp

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* clean redundant file

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* change DIM to const

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* optimize test_c_api.cpp

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* update reduce testcase

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-07-20 17:13:21 +08:00
FluorineDog 234954931f
remove deprecated (#6623)
* remove deprecated

Signed-off-by: fluorinedog <fluorinedog@gmail.com>

* fix timeout

Signed-off-by: fluorinedog <fluorinedog@gmail.com>
2021-07-20 15:18:08 +08:00
godchen b9f5949680
Add vector chunk manager (#6613)
* add file manager

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* add file manager

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* add vector file manager

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* rename

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* go fmt

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix ut error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix action error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix memory error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-07-20 15:06:09 +08:00
dragondriver 99249a0224
Fix bug: override the compare function of SearchResultPair (#6628)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-20 14:38:11 +08:00
sunby ab5a7cbf44
Remove timesync package (#6619)
issue: #6618
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-07-19 18:53:09 +08:00
sunby b98b30b96f
Fix datacoord_test.go failed (#6558)
Create a mock rootcoord when testing datacoord to hide the network layer
issue: #6557
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-07-19 10:41:15 +08:00
dragondriver 0e2329c7ad
Refactor snapshot of timestamp statistics (#6600)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-17 16:31:29 +08:00
Cai Yudong a7b27db63e
update fillRetrieveResults parameter (#6598)
* update fillRetrieveResults parameter

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* optimize fillVectorFieldData process

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-07-17 15:17:30 +08:00
dragondriver 2d9361e0ba
Fix bug: remove duplicated primary field id when retrieve entities (#6577)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-17 10:53:30 +08:00
Cai Yudong a992dcf6a8
Support query return vector output field (#6570)
* improve code readibility

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* add offset in RetrieveResults

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* add VectorFieldInfo into Segment struct

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* add new interface for query vector

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* update load vector field logic

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* update load vector field logic

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fill in field name in query result

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* add FieldId into FieldData

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* add fillVectorOutputFieldsIfNeeded

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* update data_codec_test.go

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* add DeserializeFieldData

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* realize query return vector output field

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fix static-check

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* disable query vector case

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-07-16 17:19:55 +08:00
紫晴 4c7b57ffc5
Upload codecov report in GitHub Actions (#6565)
* Upload codecov report in GitHub Actions

Signed-off-by: wangting0128 <ting.wang@zilliz.com>
2021-07-16 14:52:21 +08:00
xige-16 2a42244ff6
fix watchQueryChannelTask's info can't be deleted from etcd (#6568)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-07-16 10:21:55 +08:00
dragondriver 84b9791221
Fix snapshot of timestmap statistics (#6543)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-15 17:47:55 +08:00
sunby ee38d14f5d
Fix channel lost after data node crash (#6545)
If we start up 2 data nodes and one of them crashes. We expect that all
channels of crashed node will be allcoated to the alive node. But now we
discover that these channels are lost after data node crash. The reason
is we pass a NodeInfo with empty channel info. We fix it and improve log
print.

issue: #6501
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-07-15 16:38:31 +08:00
bigsheeper 7b9f0d398f
update flowgraph unittest (#6537)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-07-15 14:51:55 +08:00
groot 6b001fd76a
fix debug error in IDE (#6539)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-07-15 14:27:54 +08:00
XuanYang-cn dca6c6afde
Add unittest for BackGroundGC in DataNode (#6522)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-07-15 10:05:55 +08:00
dragondriver 5016e509be
Support wildcard match on search/query output fields (#6510)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-14 18:51:54 +08:00
neza2017 fac350cc58
fix tso (#6500)
Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-07-14 17:11:54 +08:00
dragondriver 7f99d9d714
Loose the limit of dimension when searching on a binary vector field (#6503)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-14 14:33:54 +08:00
cai.zhang f469a315d6
Refactor the logic of assign tasks in IndexCoord (#6328)
* Refactor the logic of assign tasks in IndexCoord

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix bugs

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix bug for unittest

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Add lock for map

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Improve code

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix unittest bug

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Reduce duriation for timetick

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Update orm version

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Reset sdk version

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix bug

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Reset orm version

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Reset test ip

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix bug

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix bug for unissued

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Rename some variables

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix bug

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Use break instead of continue in select::case

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>
2021-07-14 14:15:55 +08:00
Cai Yudong 1c29b42434
change output_fields to out_fields_id for RetrieveRequest (#6506)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-07-14 13:11:54 +08:00
bigsheeper e50d39dfe1
Query result get global sealed segments from ETCD (#6377)
* get global sealed segments from ETCD

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* fix race error

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-07-14 11:15:54 +08:00
cai.zhang f3a5b46288
Fix bug for repeatedly create bucket in minio (#6477)
* Fix bug for repeatedly create bucket in minio

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Simplify code

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Add log

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>
2021-07-14 09:55:46 +08:00
Cai Yudong 724f10b9a0
Unify the usage of query and search (#6467)
Unify the usage of query and search

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-07-13 22:20:33 +08:00
neza2017 b66157358c
add more log for create collection (#6478)
Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-07-13 22:19:55 +08:00
dragondriver d896e3119e
Fix 6419, check if num_rows is greater than zero in proxy (#6439)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-13 16:33:55 +08:00
dragondriver 25b8c37383
Fix 6421, split raw vectors to serveral smaller one (#6449)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-13 16:05:36 +08:00
congqixia bc15b74244
Handle datasorter edge cases (#6465)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-07-13 14:37:54 +08:00
xaxys e5f8a77a2d
Extend grammar of boolean expression (#6460)
* Extend grammar of boolean expression

Signed-off-by: xaxys <tpnnghd@163.com>
2021-07-13 14:37:03 +08:00
xige-16 2b720fd2f7
Fix load hang when restart querynode many time in short time (#6351)
* fix load hang when restart querynode many time in short time

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* add multi queryNode ut

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* add ut for restart querynode

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* set queryCoord contex to load collection

Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-07-13 14:16:00 +08:00
neza2017 d4239f0cd8
masterservice -> rootcoord (#6447)
Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-07-13 09:37:40 +08:00
sunby 83be910baa
Refactor segment manager (#6441)
issue: #6440
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-07-12 17:24:25 +08:00
sunby a8e5fd2024
Refactor cluster in dataservice (#6356)
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-07-12 11:03:52 +08:00
dragondriver bd317a5461
Check if field data is empty (#6404)
* Check if field data is empty

Signed-off-by: dragondriver <jiquan.long@zilliz.com>

* FixBug: fast fail when output_fields contain fields that are not in schema

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>

Co-authored-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-07-11 19:39:52 +08:00
neza2017 8b89744c6b
search with exp (#6409)
* process float vector and binary vector field
on the search result

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* add more debug info on etcd

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* add debug info when grpc failed

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-07-10 10:21:52 +08:00
FluorineDog 99ed122d11
Remove Dead Code, use signed type (#6398)
* make type signed

Signed-off-by: fluorinedog <fluorinedog@gmail.com>

* remove dead code

Signed-off-by: fluorinedog <fluorinedog@gmail.com>

* remove code

Signed-off-by: fluorinedog <fluorinedog@gmail.com>
2021-07-09 18:25:11 +08:00
FluorineDog 2ff072ea7b
Use larger dim for binary test to avoid false positive test failed (#6416)
Signed-off-by: fluorinedog <fluorinedog@gmail.com>
2021-07-09 18:12:40 +08:00
groot 19fc42c9eb
calc_distance typo (#6380)
* calc_distance typo

Signed-off-by: yhmo <yihua.mo@zilliz.com>

* calc_distance typo

Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-07-09 14:53:52 +08:00
godchen 346e9cba4a
Add minio FGet method (#6386)
* Add minio FGet method

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* go fmt

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* change el append

Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-07-09 11:44:40 +08:00
zhenshan.cao 6b4b71bf03
Fixbug: remove wrong check code (#6372)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-07-08 20:17:43 +08:00
zhenshan.cao b53699b846
Fixbug: distinguish the name of the subscription based on ProxyID (#6333)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-07-08 19:52:39 +08:00
XuanYang-cn f0a68704e2
Add unittests for getChannelName in DataNode (#6346)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-07-08 15:52:40 +08:00
FluorineDog d972a0361d
Weaken debug message (#6324)
Signed-off-by: fluorinedog <fluorinedog@gmail.com>
2021-07-08 15:50:57 +08:00
quicksilver 7d920e9c9c
Fix compile error on CentOS (#6359)
Signed-off-by: quicksilver <zhifeng.zhang@zilliz.com>
2021-07-08 15:43:45 +08:00
yukun 33162ca40f
Fix query error message (#6344)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-07-08 15:05:52 +08:00
Cai Yudong 3387b07dfd
Optimize code under storage (#6335)
* rename AddOneStringToPayload/GetOneStringFromPayload to AddStringToPayload/GetStringFromPayload

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* code optimize

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename print_binglog_test to print_binlog_test

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* update chap08_binlog.md

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fix unittest

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* use SetEventTimestamp() to replace SetStartTimestamp() and SetEndTimestamp()

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* code optimize

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename AddStringToPayload/GetStringFromPayload to AddOneStringToPayload/GetOneStringFromPayload

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-07-07 19:10:07 +08:00
sunby 017484e093
Refactor meta in data coord (#6300)
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-07-07 14:02:01 +08:00
shengjun.li a1ba9e9dcd
Fix comile on CentOS (#6334)
Signed-off-by: shengjun.li <shengjun.li@zilliz.com>
2021-07-07 12:34:02 +08:00
dragondriver 166548447b
Fix 6249, use more clear error message (#6316)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-06 14:40:04 +08:00
FluorineDog 97b1426666
fix benchmark, add support for primary key in schemaHelper (#6281)
* fix benchmark

Signed-off-by: fluorinedog <fluorinedog@gmail.com>

* fix tests

Signed-off-by: fluorinedog <fluorinedog@gmail.com>
2021-07-06 09:50:01 +08:00
sunby 836a45ec26
Remove sending newSegmentMsg to rootcoord (#6301)
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-07-06 09:24:05 +08:00
Cai Yudong 21a9bcd844
Create default partition when receive CreateCollectionMsg (#6305)
* create default partition when create collection

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fix unittest

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* adjust sleep time for unittest

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-07-06 09:16:03 +08:00
shengjun.li 1f42b4ec9d
fix the case that knng is not full (#6308)
Signed-off-by: shengjun.li <shengjun.li@zilliz.com>
2021-07-05 17:26:07 +08:00