milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[skip-ci]Fix datanode comment typo (#7689) 

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
pull/7714/head
XuanYang-cn 2021-09-10 14:46:00 +08:00 committed by GitHub
parent 18e96e6e62
commit ce33855652
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
internal/datanode/data_node.go
View File

@ -67,8 +67,8 @@ const illegalRequestErrStr = "Illegal request"
// services in datanode package.
//
// DataNode implements `types.Component`, `types.DataNode` interfaces.
// `rootCoord` is grpc client of root coordinator.
// `dataCoord` is grpc client of data service.
// `rootCoord` is a grpc client of root coordinator.
// `dataCoord` is a grpc client of data service.
// `NodeID` is unique to each datanode.
// `State` is current statement of this data node, indicating whether it's healthy.
//
@ -198,7 +198,7 @@ func (node *DataNode) StartWatchChannels(ctx context.Context) {
}
}
// handleChannelEvt handels event from kv watch event
// handleChannelEvt handles event from kv watch event
func (node *DataNode) handleChannelEvt(evt *clientv3.Event) {
switch evt.Type {
case clientv3.EventTypePut: // datacoord shall put channels needs to be watched here
@ -226,7 +226,7 @@ func (node *DataNode) handleChannelEvt(evt *clientv3.Event) {
if err != nil {
log.Warn("fail to change WatchState to complete", zap.String("key", string(evt.Kv.Key)), zap.Error(err))
node.ReleaseDataSyncService(string(evt.Kv.Key))
// maybe retry logic and exit logic
// TODO GOOSE: maybe retry logic and exit logic
}
case clientv3.EventTypeDelete:
// guaranteed there is no "/" in channel name