milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Lock when writing meta instead of trying to connect to indexnode (#7136) 

Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
pull/7141/head
cai.zhang 2021-08-17 17:54:10 +08:00 committed by GitHub
parent 1b4231b4e8
commit c2a4bd3e9c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
internal/indexcoord/node_manager.go
View File

@ -37,6 +37,11 @@ func NewNodeManager() *NodeManager {
}
func (nm *NodeManager) setClient(nodeID UniqueID, client types.IndexNode) {
nm.lock.Lock()
defer nm.lock.Unlock()
log.Debug("IndexCoord NodeManager setClient", zap.Int64("nodeID", nodeID))
defer log.Debug("IndexNode NodeManager setclient success", zap.Any("nodeID", nodeID))
item := &PQItem{
key: nodeID,
priority: 0,
@ -55,9 +60,6 @@ func (nm *NodeManager) RemoveNode(nodeID UniqueID) {
}
func (nm *NodeManager) AddNode(nodeID UniqueID, address string) error {
nm.lock.Lock()
defer nm.lock.Unlock()
log.Debug("IndexCoord addNode", zap.Any("nodeID", nodeID), zap.Any("node address", address))
if nm.pq.CheckExist(nodeID) {
log.Debug("IndexCoord", zap.Any("Node client already exist with ID:", nodeID))
@ -66,10 +68,12 @@ func (nm *NodeManager) AddNode(nodeID UniqueID, address string) error {
nodeClient, err := grpcindexnodeclient.NewClient(context.TODO(), address)
if err != nil {
log.Error("IndexCoord NodeManager", zap.Any("Add node err", err))
return err
}
err = nodeClient.Init()
if err != nil {
log.Error("IndexCoord NodeManager", zap.Any("Add node err", err))
return err
}
nm.setClient(nodeID, nodeClient)