Commit Graph

740 Commits (a577cac46b86e338382ac7191188342ea6db7440)

Author SHA1 Message Date
Xiangyu Wang cabc40cb09
Improve import statement (#13737)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-12-20 14:39:12 +08:00
Xiangyu Wang a7dfd53f53
Improve import statement (#13736)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-12-20 14:38:25 +08:00
Xiangyu Wang 08be6888d5
Improve import statement (#13733)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-12-20 14:33:47 +08:00
congqixia 2de5cf7762
[skip e2e] Improve log in flush manager (#13689)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-20 12:22:43 +08:00
congqixia d4afc812d1
Normalize DataNode term in errors.go (#13688)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-20 12:20:50 +08:00
congqixia 1dcd06cc78
Add log file info for all kind of segment binlogs (#13606)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-19 20:00:42 +08:00
JackLCL 20c956b675
[skip e2e]Fix error log output format in segment_replica.go (#13676)
Signed-off-by: JackLCL <chenglong.li@zilliz.com>
2021-12-19 12:32:42 +08:00
godchen 154f11e3a1
[skip e2e]Fix redundant conversion (#13648)
Signed-off-by: godchen0212 <qingxiang.chen@zilliz.com>
2021-12-17 22:28:50 +08:00
godchen e191b23249
[skip e2e]Fix error string (#13647)
Signed-off-by: godchen0212 <qingxiang.chen@zilliz.com>
2021-12-17 19:22:42 +08:00
godchen fefeaa2e1d
[skip e2e]Fix compaction executor typo (#13646)
Signed-off-by: godchen0212 <qingxiang.chen@zilliz.com>
2021-12-17 19:20:46 +08:00
cai.zhang 9f23fc7f2a
Register the service when the component state is healthy (#13248)
Signed-off-by: Cai.Zhang <cai.zhang@zilliz.com>
2021-12-15 11:47:10 +08:00
Bingyi Sun 0c39e0370c
Move segment statistics update to datanode tt loop (#13233)
Signed-off-by: sunby <bingyi.sun@zilliz.com>

Co-authored-by: sunby <bingyi.sun@zilliz.com>
2021-12-15 10:53:16 +08:00
JackLCL 30afcf2311
[skip ci]Fix error log output format in segment_replica.go (#13350)
Signed-off-by: JackLCL <chenglong.li@zilliz.com>
2021-12-14 16:51:09 +08:00
JackLCL 5f02a3738a
[skip ci]Fix error log output format in meta_service.go (#13349)
Signed-off-by: JackLCL <chenglong.li@zilliz.com>
2021-12-14 16:43:25 +08:00
Xiangyu Wang 405b3cd932
Use the same lint rules with golint in revive (#13324)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-12-14 15:31:07 +08:00
congqixia 8f87cc7ef1
Fix JoinIDPath logic problem (#13039)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-09 12:05:04 +08:00
XuanYang-cn dbf757e08b
Change genKey into JoinIDPath (#12959)
1. Simplify genKey(), make genKey a rpc call
2. Unify the usage of JoinIDPath

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-12-09 11:09:06 +08:00
XuanYang-cn a9a332dbcf
Fix empty segment compact and load (#12710)
1. Fix compaction save empty segment bug
2. Fix load empty segment bug
3. Add UT for dmlchannels to 100%

Resolves: #12450

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-12-09 11:03:08 +08:00
congqixia 1195f441b2
Update DataNode state before stop (#12946)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-08 14:19:04 +08:00
JackLCL 73b63b9a02
[skip ci]Fix error log output format in segment_replica.go (#12929)
Signed-off-by: JackLCL <chenglong.li@zilliz.com>
2021-12-08 13:55:04 +08:00
JackLCL a6ce7d7f53
[skip ci]Fix error log output format in meta_service.go (#12928)
Signed-off-by: JackLCL <chenglong.li@zilliz.com>
2021-12-08 13:51:09 +08:00
JackLCL e51ef53632
[skip ci]Fix error log output format in flush_manager.go (#12857)
Signed-off-by: JackLCL <chenglong.li@zilliz.com>
2021-12-07 14:38:15 +08:00
congqixia b20a238c38
Fix newDataSyncService panicking with normal segment has no dml pos (#12771)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-06 16:21:35 +08:00
congqixia 58c5b6093d
Fix close10000 ut has chances to fail (#12740)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-06 09:59:35 +08:00
Bingyi Sun 8bbaae04ff
Decrease compaction parallel (#12707)
Signed-off-by: sunby <bingyi.sun@zilliz.com>

Co-authored-by: sunby <bingyi.sun@zilliz.com>
2021-12-03 18:57:33 +08:00
congqixia ffd05eb140
Fix deadlock in mergedTimeTickSender (#12697)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-03 16:39:33 +08:00
edward.zeng 45cbec1f7b
[skip ci] Refine datanode binlog io comment (#12638)
Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
2021-12-02 19:11:32 +08:00
edward.zeng c2b73e1b55
[skip ci] Refine data node flow graph comment (#12637)
Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
2021-12-02 18:59:33 +08:00
congqixia 8f9e62fa18
Apply DropVirtualChannel and FlushManager drop mode (#12563)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-02 16:39:33 +08:00
godchen 5e3e3b3b41
Remove grpc returned error (#12537)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-12-01 22:17:46 +08:00
edward.zeng 271aaa7537
[skip ci] Refine data node param table comment (#12560)
Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
2021-12-01 19:31:36 +08:00
congqixia e813867652
Implement Drop mode for flush manager (#12469)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-01 10:11:39 +08:00
godchen f31ed089b5
Add timeout for reader next (#12308)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-26 22:45:24 +08:00
XuanYang-cn 48b45d82e5
Add ut for binlog_io to 100 coverage (#12283)
Make DN ut coverage upto 90%
Resolves: #8058

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-11-26 17:43:17 +08:00
dragondriver b6d0150dc5
Fix health check when disconnect to etcd (#12292)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-11-26 11:39:16 +08:00
bigsheeper e245ba87a9
Add excluded segments for dropped segemnts (#12247)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-11-25 14:25:15 +08:00
XuanYang-cn 8a8ebed23d
Fix DN GC bug (#12258)
Fixes: #12249

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-11-25 09:43:15 +08:00
congqixia 59d19384dc
Fix flush manager injection logic with multiple segments (#12260)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-24 18:41:16 +08:00
godchen e3f49858c5
Add subscription prefix (#12251)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-24 17:47:15 +08:00
dragondriver 6c4c0ef6b5
Add more deploy metrics (#12248)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-11-24 15:43:15 +08:00
XuanYang-cn e72c5b9351
Filter dropped segments in DN (#12242)
See also: #12131, #12230

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-11-24 14:11:15 +08:00
XuanYang-cn 6bf0c4326d
Fix compaction generates wrong insert binlogs (#12204)
This PR
- changes Get() to GetRow() in BinlogIterator
- removes Get() and Length() of FieldData
- adds ut in BinlogIterator for floatvector and binaryvector
- fix a log bug

Fixes: #12146

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-11-23 17:09:15 +08:00
congqixia 4121e31df1
Send SIGINT to runner goroutine after etcd disconnects (#12163)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-22 16:23:17 +08:00
godchen 51b353b52c
Add msgstream reader (#12130)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-19 15:57:12 +08:00
congqixia 7e91bcf115
Normalize datanode dminput node log (#12128)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-19 14:21:13 +08:00
dragondriver ee0f753f7a
Fix datarace between GetComponentStates and Register (#11935)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-11-19 13:57:12 +08:00
Bingyi Sun 038f42851e
Add more log for debug (#11893)
Signed-off-by: sunby <bingyi.sun@zilliz.com>

Co-authored-by: sunby <bingyi.sun@zilliz.com>
2021-11-18 10:37:41 +08:00
XuanYang-cn 7dbb4d10e5
Fix DeltaLogs empty yet appending a deltaInfo bug (#11984)
- Add more logs for startpositions

Fixes: #11970

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-11-17 17:57:11 +08:00
congqixia 5e550a8793
Add close for flushManager (#11874)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-17 10:39:15 +08:00
XuanYang-cn 9bd3664672
Fix compaction bug (#11816)
This PR fixes:
- timeout in compaction
- BinlogIterator using rawID as PKField bug

See also: #11757

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-11-17 10:07:13 +08:00
congqixia 5edbb82610
Add session revoke (#11908)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-16 22:31:14 +08:00
Xiangyu Wang 12f50cb22c
[skip ci]Update OWNERS files (#11898)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-11-16 15:41:11 +08:00
congqixia fa6314393a
Fix compactor loop closure captured (#11814)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-15 19:44:10 +08:00
congqixia 579416e3d3
Apply retry for flush manager execution (#11808)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-15 17:19:10 +08:00
XuanYang-cn f3852c1db0
Add more specific logs (#11724)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-11-15 15:25:09 +08:00
Bingyi Sun 5c8978e5d6
Fix drop segment bug (#11709)
issue: #11708
Signed-off-by: sunby <bingyi.sun@zilliz.com>

Co-authored-by: sunby <bingyi.sun@zilliz.com>
2021-11-12 17:31:11 +08:00
XuanYang-cn c4bb73dc74
Complete drop collection procedure in DN (#11552)
drop, cancel compaction, flush all buffers and release fg

See also: #11426

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-11-11 20:56:49 +08:00
godchen 5357e301f4
Fix retrieve search error (#11501)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-11 00:54:45 +08:00
godchen 14d2891a69
[skip ci]Fix download typo (#11577)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-10 20:11:35 +08:00
godchen 0fc1e12faf
[skip ci]Fix download typo (#11575)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-10 20:09:33 +08:00
godchen 038d0f1adf
[skip ci]Fix download typo (#11573)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-10 20:07:39 +08:00
congqixia 4c37e94a39
Add type assertion for compactTask (#11468)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-10 19:16:40 +08:00
Xiaofan 5f08b67156
Move node.yaml to component.yaml (#11363)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-11-10 14:27:37 +08:00
godchen 863f1bb34e
Fix multi delete data not effect (#11422)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-09 15:01:17 +08:00
Xiangyu Wang 0eb71f7ee5
Logging traceID in process of processing delete request (#11374)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-11-09 11:01:02 +08:00
godchen 639800241d
Make flow graph for delta channel (#11379)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-09 09:27:04 +08:00
XuanYang-cn 3cd0584a04
Add compaction in datanode (#11353)
See also: #9530

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-11-08 19:49:07 +08:00
congqixia 3ac7d7a9de
Add detailed comments for dataSyncService in DataNode (#11285)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-05 22:59:04 +08:00
sunby c26cd79532
Add compaction (#9906)
issue: #9904
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-11-05 22:25:00 +08:00
congqixia 0e5931a3da
Add mergedTimetickSender for datanode (#11297)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-05 14:59:32 +08:00
godchen 9186d5527e
Forward delete msg (#11210)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-05 11:59:02 +08:00
XuanYang-cn 8863c01ff7
Make DN fail faster when watching an invalid chan (#11102)
See also: #11098

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-11-04 15:56:28 +08:00
congqixia 0ef95c5df1
Add timeticker logger for insert buffer node (#11216)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-04 15:40:14 +08:00
godchen b63a9521c2
Make gen msg private (#10115)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-04 15:36:19 +08:00
godchen a0a3a889e7
Add common endian for global use (#11092)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-02 18:16:32 +08:00
XuanYang-cn 225b2c66a0
Fix datanode ut using register bug (#10885)
Resolves: #10881
See also: #8058

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-11-01 11:01:49 +08:00
XuanYang-cn 1e3fc5076f
Change etcdkv clientv3 into MetaKv interface (#10903)
This pr:
- changed etcdkv clientv3 into MetaKv interface
- replaced fmt.Sprintf with path.Join for kv key

See also: #8058

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-11-01 10:19:55 +08:00
Xiaofan 2df2d488e1
Fix Unit test fatal fail (#10933)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-10-30 10:24:38 +08:00
congqixia 756be81bce
Add injectFlush method for flushManager interface (#10659)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-28 19:16:31 +08:00
Xiaofan 6fddcb3925
Fix Session checker for proxy (#10737)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-10-27 21:58:33 +08:00
XuanYang-cn 42ce9b18d1
Add methods in segment replica (#10582)
see also: #8058

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-27 17:14:28 +08:00
congqixia 169af67eb1
Fix segments not removed from flushingCache (#10738)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-27 16:06:24 +08:00
cai.zhang aff5cd9598
Supprot to read the configuration of minio from environment variables (#10534)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-26 15:10:03 +08:00
godchen 095a2378ca
Add datanode ut (#10433)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-25 22:52:27 +08:00
congqixia ae2a301662
Add injection logic for FlushManager (#10580)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-25 20:17:34 +08:00
XuanYang-cn 21d98c2825
Add binlog io for compaction (#10536)
See also: #9530

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-25 20:13:51 +08:00
godchen d2e0943f21
Fix delete node flush error (#10549)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-25 18:49:20 +08:00
congqixia 2713988ff2
Merge auto manual flush with same segment id (#10550)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-25 18:03:42 +08:00
congqixia bd90a3831c
Allow flushed segments trigger flushe process (#10539)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-25 18:01:50 +08:00
XuanYang-cn cd06f50645
Remove schema in delete codec (#10517)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-24 09:59:10 +08:00
godchen 31393d8801
[skip ci]Fix datanode comment typo error (#10502)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-23 16:57:35 +08:00
godchen ffc0c07610
Change delete data primary key to int64 (#10438)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-22 15:37:12 +08:00
godchen d6bf0c928f
Get stats delta path from datacoord (#10362)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-22 14:31:13 +08:00
congqixia 7ce7cb7a5e
Add a timed flush trigger mechanism (#10197)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-20 15:02:36 +08:00
godchen 6279fb817a
Fix stats log load with prefix error (#10216)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-19 20:50:35 +08:00
godchen 8daeb0d519
Change bloom filter use pk (#10193)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-19 20:18:47 +08:00
sunby 4031b8746f
Fix panic when flushing segment (#10182)
issue: #10180
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-10-19 19:06:37 +08:00
congqixia ed4e516ce7
Save stats and delta logs from DataNode (#10159)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-19 14:34:35 +08:00
congqixia 5737e0075f
Apply flush manager logic in datanode (#10142)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-19 11:04:34 +08:00
congqixia 3711fcd82f
Add more info for Delta log compaction (#10083)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-18 18:24:45 +08:00
congqixia 0438ed2bfe
Use single signal chan to notify flush (#10075)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-18 12:34:34 +08:00
congqixia 90f88c6559
Add flush manager structure (#9986)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-18 10:38:35 +08:00
Xiaofan d845153de4
Add Buffer for consumer channel (#9578)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-10-15 20:31:16 +08:00
XuanYang-cn d0e6b52ce9
[skip ci]Update license for datanode (#9963)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-15 18:09:00 +08:00
XuanYang-cn dcd56a575d
[skip ci]Update license for flowgraph of dn (#9962)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-15 18:07:09 +08:00
XuanYang-cn 9c706c6dc3
[skip ci]Update license on datanode (#9960)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-15 18:03:25 +08:00
XuanYang-cn 880056e664
[skip ci]Update license for datesync (#9959)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-15 18:01:38 +08:00
godchen bf71965f58
Check watchlist error (#9953)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-15 17:02:37 +08:00
godchen 9e9ad7c7e6
Check pk filter merge error (#9952)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-15 16:58:42 +08:00
Xiaofan a0b98dacda
Skip reconsume tt msgstream when datacoord restart (#9684)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-10-15 11:46:33 +08:00
godchen 2e0f7dfe42
Check data sync service error (#9856)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-14 17:40:42 +08:00
congqixia ec6e8e4127
Hide liveChn into sessionutil and fix liveness init order (#9860)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-14 16:40:35 +08:00
sunby 044b06421a
Use etcd to watch channel on datanode (#7115)
issue: #6578
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-10-14 15:44:34 +08:00
yukun 92815f4542
Change timestamp to timestamps in internalproto.DeleteRequest (#9802)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-10-14 14:48:34 +08:00
godchen 77a9b521c6
Check data sync service test error (#9854)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-14 14:12:34 +08:00
dragondriver 72d3d470ba
Use the server id as identifier in system topology graph (#9825)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-10-14 11:12:38 +08:00
godchen a2dc0d8808
Init segment replica bloom filter (#9770)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-14 10:24:33 +08:00
congqixia c50233639f
Add allocIDBatch for datanode allocator (#9782)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-13 22:12:32 +08:00
XuanYang-cn c2c927bd55
Use reader in the right way (#9790)
Avoid to mantaining the position myself.

Make Read bytes more easy to read and maintain.

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-13 21:32:33 +08:00
congqixia c90a97f95a
Fix Watch Channel canceled due to revision compacted (#9788)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-13 17:02:33 +08:00
XuanYang-cn aac6323cff
Use config as parameter (#9707)
Make functions in flowgraph lesser parameters

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-13 11:16:32 +08:00
godchen 59ab0e441c
Add bloom filter for stats (#9630)
* Add bloom filter for stats

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* trigger GitHub actions

Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-13 10:22:33 +08:00
congqixia d8f490082c
Normalize dmInputNode seek log (#9714)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-12 23:44:35 +08:00
godchen 653ba91cc7
[skip ci ]Add join id path comment (#9718)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-12 19:23:39 +08:00
godchen f496bc70c0
[skip ci]Fix delete node comment lint (#9717)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-12 18:32:33 +08:00
godchen 13c1a1c746
Add joinIDPath for reuse (#9650)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-12 17:20:33 +08:00
congqixia 80ac456cf8
Normalize dmInputNode log (#9652)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-11 21:54:33 +08:00
godchen 3e26c19bad
[skip ci]Fix segment replica comment (#9654)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-11 21:12:44 +08:00
XuanYang-cn f0bedc7046
Add ut for data_node.go (#9489)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-11 18:50:30 +08:00
congqixia e05877f828
Change datanode cache implementation to sync.Map (#9607)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-11 17:32:30 +08:00
Cai Yudong 84e568ee32
Support Delete in datanode (#8505)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-11 16:31:44 +08:00
xige-16 e99ecc8cab
Add ProduceMark interface to return messageID (#9556)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-10-11 11:38:57 +08:00
godchen d0bc0cd697
Skip data sync service test (#9571)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-09 17:41:00 +08:00
godchen 5e7648fc7c
Check data node test error (#9532)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-09 15:45:15 +08:00
godchen 376be1b532
Add data sync service error check (#9498)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-09 15:38:57 +08:00
godchen 55ec988544
[skip ci]Fix data node comment lint (#9534)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-09 11:28:57 +08:00
zwd1208 9ceb1c73db
[skip ci]Change uppercase of MinIO (#9539)
Signed-off-by: Weida Zhu <weida.zhu@zilliz.com>
2021-10-09 11:22:58 +08:00
groot 735b02cf2b
Add unittest for distributed/datanode (#9503)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-10-09 10:10:59 +08:00
XuanYang-cn 30395cb1b1
Add more specific comment in datanode (#9488)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-09 00:09:47 +08:00
zhenshan.cao aacfa172ba
Fix unittest bug: delete variables that do not need to be initialized (#9520)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-10-08 22:02:58 +08:00
godchen ac35aa7e34
Add flowgraph dmstream input node error check (#9497)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-08 19:25:00 +08:00
XuanYang-cn e6346d7b60
[skip ci]Add license in cache_test.go (#9500)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-08 19:18:57 +08:00
XuanYang-cn a853ca6044
[skip ci]Add license in cache.go (#9499)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-08 19:17:03 +08:00
godchen 937dbf4279
Add flushed segments (#9476)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-08 19:09:12 +08:00
Cai Yudong b9f5a6bb1e
Rename some variables in unittest (#9484)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-08 17:47:25 +08:00
Cai Yudong ec9ec97cec
Fix typo (#9482)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-08 17:45:35 +08:00
Cai Yudong 78755263e2
Update ddnode test (#9477)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-08 17:43:46 +08:00
congqixia a1651104c3
[skip ci] Fix datanode Cache comment typo (#9483)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-08 17:22:54 +08:00
Cai Yudong 3dac2611b6
Remove redundant variable load (#9452)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-08 14:49:08 +08:00
Cai Yudong 12d640a023
Update filterSegmentByPK (#9450)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-08 12:04:56 +08:00
XuanYang-cn a1f9e46e44
[skip ci]Update comment in datanode package (#9428)
Signed-off-by: Yang Xuan <xuan.yang@zilliz.com>
2021-10-07 23:50:52 +08:00
XuanYang-cn 9526d22dc7
[skip ci]Add comment for normal2FlushedSegment (#9431)
Signed-off-by: Yang Xuan <xuan.yang@zilliz.com>
2021-10-07 23:46:37 +08:00
godchen 445f5426d1
Check data node error (#9303)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-07 22:16:56 +08:00
congqixia 908b7df41d
Add comment and implementation assertion for ddnode (#9333)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-07 19:54:56 +08:00
godchen cd4205e447
[skip ci]Fix allocator comment typo (#9363)
Signed-off-by: godchen0212 <qingxiang.chen@zilliz.com>
2021-10-06 23:32:27 +08:00
XuanYang-cn e7e37448d2
[skip ci]Add comment for flowgraph insertBufferNode (#9361)
Signed-off-by: Yang Xuan <xuan.yang@zilliz.com>
2021-10-06 23:30:21 +08:00
XuanYang-cn 5bb832e6cc
[skip ci]Add comment on flowgraph dmstream inputnode (#9359)
Signed-off-by: Yang Xuan <xuan.yang@zilliz.com>
2021-10-06 23:02:08 +08:00
XuanYang-cn 27143c6095
[skip ci]Add comment on flowgraph ddNode (#9358)
Signed-off-by: Yang Xuan <xuan.yang@zilliz.com>
2021-10-06 22:51:58 +08:00
XuanYang-cn 7b14b0e63d
[skip ci]Add comment on readBinary (#9355)
Signed-off-by: Yang Xuan <xuan.yang@zilliz.com>
2021-10-06 22:28:11 +08:00
XuanYang-cn 65a76b9bb5
[skip ci]Add comment in insertbuffernode (#9354)
Signed-off-by: Yang Xuan <xuan.yang@zilliz.com>
2021-10-06 22:20:05 +08:00
godchen 83228c35ad
Add flowgraph insert buffer node error check (#9310)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-06 21:06:23 +08:00
XuanYang-cn e7aa5eebd6
[skip ci]Update comment of cache in datanode (#9313)
Signed-off-by: Yang Xuan <xuan.yang@zilliz.com>
2021-10-06 07:08:24 +08:00
XuanYang-cn cb6d853b56
[skip ci]Add README.md in datanode (#9311)
Signed-off-by: Yang Xuan <xuan.yang@zilliz.com>
2021-10-05 23:12:03 +08:00
XuanYang-cn f49e35a7fb
[skip ci]Update datanode param table comment (#9308)
Signed-off-by: Yang Xuan <xuan.yang@zilliz.com>
2021-10-05 22:54:03 +08:00
godchen e6ee4f39bb
Add flow graph dmstream input node test error check (#9213)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-04 17:37:57 +08:00
godchen 3eee4e4259
Add segment replica test error check (#9212)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-04 17:36:06 +08:00
godchen 83f256c31b
Remove datanode mock test error (#9211)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-04 17:34:16 +08:00
congqixia becf6c8f7d
Add DataNode implementation Assertion (#9144)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-03 19:46:05 +08:00
congqixia 109186db9c
[skip ci] Add comment for datanode meta_service.go (#9036)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-01 22:25:24 +08:00
Xiaofan 2c2b800ff4
Change Log Name with NodeId (#8721)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-10-01 08:52:50 +08:00
congqixia 6bbf0a8f8f
Read datanode insertbuf from env (#8942)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-30 17:45:07 +08:00
congqixia 10a6f7f146
Defer buf removal from insertBuf after SaveBinlog succeeds (#8930)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-30 17:42:11 +08:00
zhenshan.cao d1d5f9e409
Replace proto.MarshalTextString with proto.Marshal (#8542)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-29 20:26:00 +08:00
congqixia db944cd09c
Refactor flowgraph and related invocation (#8770)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-29 20:19:59 +08:00
Cai Yudong d94361fdcc
Add parameter partitionID for API filterSegments (#8813)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-29 10:27:58 +08:00
XuanYang-cn 3be6672753
Add flush channel for delete_node (#8762)
Resolves: #8761

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-28 18:22:16 +08:00
congqixia d374ea71ba
Unify liveness check in datacoord and datanode (#8480)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-28 16:10:04 +08:00
XuanYang-cn b150f57927
No buffer also means flushed (#8686)
Resolves: #8684

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-28 11:18:03 +08:00
Xiaofan 585989935a
Revert the logger change (#8677)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-09-27 17:37:57 +08:00
godchen 51151b7b95
Fix delete node ut error (#8674)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-09-27 17:07:58 +08:00
godchen 77a773dff0
Change segment replica struct (#8608)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-09-27 14:38:00 +08:00
congqixia e7117f67ee
Add BroadcastMark for Msgstream returning MessageIDs (#8654)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-27 14:10:09 +08:00
zhenshan.cao b71bffe26f
Replace ChannelID with ShardName in DML Request (#8539)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-27 10:01:59 +08:00
Xiaofan d38adda8c2
Rename log file based on node id (#8517)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-09-26 21:18:11 +08:00
XuanYang-cn 1307782093
[skip-ci]Fix golint in param_table in datanode (#8602)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-26 20:57:59 +08:00
XuanYang-cn ebd894d8b7
Refactor buffer size calculation (#8565)
This PR changes the datanode insertBufSize config
from 32000 number of rows to 16MB

Resolves: #7741

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-26 20:55:59 +08:00
XuanYang-cn b376107ab3
[skip-ci]Fix golint in segmentRep (#8601)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-26 20:51:58 +08:00
XuanYang-cn b13170f83e
[skip-ci]Fix golint in flowgraphnode.go (#8600)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-26 20:49:59 +08:00
groot e4e762f2e8
Reduce go unittest time cost (#8503)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-26 12:50:24 +08:00
Cai Yudong b2e5627061
Rename insertMsg to flowGraphMsg in datanode flow graph (#8546)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-26 10:43:57 +08:00
Cai Yudong 28d305148a
Update ddnode insert (#8536)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-26 09:43:57 +08:00
XuanYang-cn 3aabc1d3ee
[skip-ci]Fix golint in type_def.go (#8464)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-24 21:43:56 +08:00
sunby 816bac82ec
Add root path in minio and replace etcd.rootPath in datanode (#8272)
issue: #7905
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-09-24 20:50:23 +08:00
XuanYang-cn e4f0d4bab6
[skip-ci]Fix golint in flow_graph_message.go (#8463)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-24 20:46:04 +08:00
XuanYang-cn 2539dd4593
[skip-ci]Fix golint in data_node.go (#8462)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-24 20:44:05 +08:00
XuanYang-cn faeb1bf50f
Add comment on exposed struct (#8348)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-23 20:15:54 +08:00
XuanYang-cn 2b82482679
Fix golint and ruleguard (#8347)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-23 19:14:01 +08:00
XuanYang-cn a830c28bd8
Fix golint in datanode (#8345)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-23 19:05:55 +08:00
congqixia 2aa9deda1c
Improve logic when watch dm channel fails (#8386)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-23 18:31:55 +08:00
SS 58a178fdf5
[skip ci] Fix grammar in comment (#8382)
Signed-off-by: sida shen <sida@sidas-MacBook-Pro.local>

Co-authored-by: sida shen <sida@sidas-MacBook-Pro.local>
2021-09-23 16:50:16 +08:00
XuanYang-cn d816a81ee3
Make FlushSegments async (#8159)
Resolves: #8122

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-23 16:03:54 +08:00
congqixia 6469d83072
Add datanode etcd alive check (#8363)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-23 14:29:54 +08:00
Xiaofan f5173b595f
Add a channel prefix for all channels (#8166)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-09-23 10:53:53 +08:00
godchen 050e27cbcf
[skip ci]Add delete node comment (#8323)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-09-22 20:02:09 +08:00
Xiangyu Wang c314b2b4a8
Remove unused label rules (#7929)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-09-18 18:19:51 +08:00
groot 334297b49d
[skip ci] Update OWNERS files (#8211)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-18 15:30:37 +08:00
congqixia bdfb8768d4
Enable gosec (#8202)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-18 14:45:50 +08:00
XuanYang-cn 46c72c57c2
Add BufferData in insertbufferNode (#8138)
Optimize bufferInsertMsg param to avoid a second transfer
of endposition

See also: #8058, #7741

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-18 14:25:50 +08:00
Cai Yudong d10c6abc9e
Apply for msgstream from pool when creating collection (#7738)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-18 09:13:50 +08:00
dragondriver daf001f683
Expose created time and updated time to datanode metrics (#8173)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-17 21:32:47 +08:00
XuanYang-cn 6c434b4801
Improve codes in insertbuffernode (#8054)
Add error handling in insertbuffernode

See also: #7624, #7684

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-17 16:27:56 +08:00
XuanYang-cn 82d4d19337
Remove not in use segmentCheckPoints (#8039)
Resolves: #8037

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-17 16:25:55 +08:00
XuanYang-cn 3db76e8e59
[skip-ci]Add comment in data sync service (#8002)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-15 21:25:49 +08:00
XuanYang-cn 376d39fa02
[skip-ci]Add comment for Cache and allocator (#7924)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-15 10:33:37 +08:00
dragondriver a872a4357c
Add more test cases for proxy implementation (#7685)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-11 11:36:22 +08:00
XuanYang-cn ce33855652
[skip-ci]Fix datanode comment typo (#7689)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-10 14:46:00 +08:00
Cai Yudong 4e23ed9a18
Revert apply physical channels from pool (d5f7e358 and 3b960969) (#7687)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-10 13:00:00 +08:00
sunby 06cee85a39
Add data node unit tests (#7622)
Issue: #6357
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-09-09 16:40:00 +08:00
XuanYang-cn 64aad49959
Add ut in datasync service to 88% (#7615)
See also: #6357

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-09 15:36:01 +08:00
congqixia 69794fd32d
Refactor insertBufferNode and add unit tests (#7621)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-09 15:00:00 +08:00
XuanYang-cn 762060e670
Add ut for segmentReplica to 100% (#7589)
See also: #6357
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-09 10:14:00 +08:00
XuanYang-cn 074b610811
Add ut for dmstream_input_node to 100% (#7593)
See also: #6357

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-08 19:12:00 +08:00
XuanYang-cn a5767e05c6
Add ut for flowgraph_delete_node to 100% (#7550)
See also: #6357
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-08 10:41:59 +08:00
XuanYang-cn 29756c6ce8
Add ut for flow_graph_dd_node to 100% (#7511)
This PR:
- Change mutex to sync.Map
- Add ut for flow_graph_dd_node.go to 100%

See also: #6357

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-07 15:41:59 +08:00
dragondriver 960741ee16
Support more detailed metrics information (#7472)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-03 19:35:47 +08:00
dragondriver 89748ac639
Expose metrics of data cluster (#7177)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-01 10:13:15 +08:00
Cai Yudong 3b9609692b
Apply for msgstream from pool when creating collection (#7377)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-31 18:35:58 +08:00
Cai Yudong f4b53df727
Revert "Apply for msgstream from pool when creating collection (#7323)" (#7376)
This reverts commit e6de86a433.
2021-08-31 11:07:58 +08:00
Cai Yudong e6de86a433
Apply for msgstream from pool when creating collection (#7323)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-31 09:47:58 +08:00
congqixia 65f168eac1
Fix datanode corner cases (#7336)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-30 10:03:58 +08:00
godchen c333af0dcf
Add query node segment filter (#7303)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-08-28 10:12:00 +08:00
godchen b4c55f6b3c
Add delete node (#7261)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-08-25 11:41:52 +08:00
congqixia daae05641a
Construct bloom filter when inserting (#7268)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-25 10:29:52 +08:00
Xiaofan 58b2089692
Import Embedded Etcd Kv Part 1(#7112) (#7174)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-08-24 09:45:51 +08:00
congqixia 881d0af1fc
Add sync logic in TestWatchChannel (#7188)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-20 17:48:13 +08:00
sunby 4f7c3e7d3a
Save binlog path in SegmentInfo (#6590)
issue: #6589
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-08-19 13:00:12 +08:00
XuanYang-cn 86ca96a02e
Fix master branch unittest error (#7083)
Resolves: #7080

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-08-13 14:00:14 +08:00
XuanYang-cn 6c5be83ea1
Refactor NewEtcdKV API (#7075)
This PR mainly did the following 3 things:

- Refactor NewEtcdKV API
- Add unittests for `kv/etcd/`, raise the coverage
up to 94%
- Correct some APIs from version to revision

The old NewEtcdKV() API took `clientv3.Client` as
one of the input, making everyone who using this API
had to create a new `clientv3.Client`. So there're a lot
of repeated codes everywhere.

Meanwhile, someplace didn't even check whether the
`clientv3.New()` returned error or not, and the old API
also didn't check whether the clientv3.Client was Nil.
This caused issue#6955.

Ectd's version and revision have nothing alike, they
represent different concepts, but our APIs kind of
mixed them all up. So I correct those APIs' names.

Resolves: #6955

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-08-13 11:04:09 +08:00
congqixia e1b3273d1c
Add Datanode watch etcd channel (#6965)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-13 10:50:09 +08:00
Xiangyu Wang 5e78fd6a97
[skip ci]Update approvers (#7063)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-08-12 19:36:09 +08:00
XuanYang-cn 9d81a90402
Fix mem leak of flush cache in DataNode (#6862)
Resolves: #6858

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-08-11 14:24:09 +08:00
XuanYang-cn 47df4a2e57
Fix DataNode BackGroudGC problem (#6551)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-08-03 09:59:24 +08:00
bigsheeper 7307332fab
Add nil check (#6832)
* add nil check

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* use grpc functions

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* use grpc functions

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* fix indexCoord crash

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-07-29 20:11:23 +08:00
godchen db94d7771f
Read vector from disk (#6707)
* Read vector from disk

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* go fmt

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix git action error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix test error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix action error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix caculate error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* change var name

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* remove unused method

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* remove unused method

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix len error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* remove unused code

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* change bytes to float method

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* change float to bytes method

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix action error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-07-24 09:25:22 +08:00
XuanYang-cn dca6c6afde
Add unittest for BackGroundGC in DataNode (#6522)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-07-15 10:05:55 +08:00
XuanYang-cn f0a68704e2
Add unittests for getChannelName in DataNode (#6346)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-07-08 15:52:40 +08:00
godchen 49a0528d53
Fix trace (#6218)
* Fix trace

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix go fmt

Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-06-30 16:18:13 +08:00
XuanYang-cn 357af89d55
Add unittest in segment_replica (#6197)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-30 10:26:12 +08:00
XuanYang-cn 769cbb292a
Update doc in datanode (#6194)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-29 17:34:13 +08:00
yukun 39614aa8eb
Add rocksmq_path in config and paramtable (#6099)
* Add rocksmq_path in config and paramtable

Signed-off-by: fishpenguin <kun.yu@zilliz.com>

* Add rocksdbPath in NewRmsFactory

Signed-off-by: fishpenguin <kun.yu@zilliz.com>

* Change rdb default path to /vat/lib/milvus/rdb_data

Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-06-25 19:44:11 +08:00
Cai Yudong a09a3a1905
rename service to coord (#6020)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-06-23 16:14:08 +08:00
XuanYang-cn b640627a38
Fix datanode restart bug (#5976) (#6004)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-23 12:26:10 +08:00
Cai Yudong 7dbf33b788
Update component names in config files (#5989)
* rename master/indexService in .yaml

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename proxyNode to proxy in config files

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* move master.yaml to root_coord.yaml, move proxy_node.yaml to proxy.yaml

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* move proto/query_service.proto to proto/query_coord.proto

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* move proxy_node_manager.go to proxy_manager.go

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* add query_coord.pb.go

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* update ci

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-06-22 19:08:03 +08:00
Cai Yudong d5f4ee6f44
Rename proto master/index_service/proxy_service (#5973)
* rename proto proxy_service to proxy

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename proto index_service to index_coord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename proto master to root_coord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-06-22 16:14:09 +08:00
sunby 7f2d7c1da3
Rename dataservice to datacoordinator (#5912)
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-06-21 18:22:13 +08:00
XuanYang-cn 688a587f4f
Add metrics in datanode (#5926)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-21 18:08:15 +08:00
sunby 0300b682f8
Remove deprecated interfaces in data coordinator (#5929)
* Remove derecated interfaces in data coordinator

Signed-off-by: sunby <bingyi.sun@zilliz.com>

* Remove RegisterNode in data coordinator

Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-06-21 17:40:05 +08:00
Cai Yudong 92e429d812
Rename IndexService to IndexCoord (#5932)
* rename package indexservice to indexcoord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename indexservice to indexcoord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fix queryservice static-check

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* move distributed/indexservice to distributed/indexcoord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* move internal/indexservice to internal/indexcoord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename indexservice to indexcoord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename MasterComponent to RootCoordComponent

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename master to rootcoord for queryservice

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename master to rootcoord for dataservice

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename master to rootcoord for datanode

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename master to rootcoord for proxynode

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename master to rootcoord for querynode

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename master to rootcoord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename IndexService to IndexCoord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename IndexService to IndexCoord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fix rebase issue

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-06-21 17:28:03 +08:00
XuanYang-cn 441300140d
Tidy replica (#5920)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-21 16:00:22 +08:00
sunby da1f9f9241
Rename dataservice to datacoordinator (#5904)
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-06-21 11:40:15 +08:00
sunby 3cc0ab1345
Remove panic in NewDataSyncService (#5888)
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-06-19 15:18:06 +08:00
XuanYang-cn ab7f642740
Add alias in paramtable (#5878)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-19 12:38:06 +08:00
sunby 33f5225968
Use physical channel to init msg stream (#5815)
* Use physical channel to init msg stream

Signed-off-by: sunby <bingyi.sun@zilliz.com>

* fix search collection error check (#1)

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

Co-authored-by: bigsheeper <954206947@qq.com>
2021-06-18 16:02:05 +08:00
XuanYang-cn 18eb27aa7a
Tidy replica in datanode (#5805)
- Remove not using functions
- Remove `initNode` logic in ParamTable
- Delete collection.go and collection_test.go

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-16 19:03:57 +08:00
XuanYang-cn 75f2b3c2ba
Add Unittest for allocator (#5781)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-15 19:11:55 +08:00
Cai Yudong 0f4bd50ce3 Support ETCD endpoints array (#5755) 2021-06-15 16:36:36 +08:00
XuanYang-cn 5bcb94294c Set start positions in datanode (#5757)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-15 16:36:36 +08:00
XuanYang-cn dea0a4e522 Idempotent of FlushSegment (#5746)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-15 16:36:36 +08:00
sunby 8a0335be44 Fix dd node filter bug (#5736)
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-06-15 16:24:49 +08:00
XuanYang-cn ab2fd34a2f fix double messages bug in datanode recovery (#5733)
* fix double messages bug in datanode recovery

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

* remove debug log

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-15 16:14:29 +08:00
XuanYang-cn 46699c4c2b fix datanode dropcollection error (#5690)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-15 16:06:13 +08:00
sunby 189ac881f3 Fix bugs (#5676)
* Remove redundant session startup

Signed-off-by: sunby <bingyi.sun@zilliz.com>

* Register datanode after start success

Signed-off-by: sunby <bingyi.sun@zilliz.com>

* fix meta snap shot

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* fix datanode message stream channel

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

* Fix bugs when drop empty collection

Signed-off-by: sunby <bingyi.sun@zilliz.com>

* Fix bug of getting pchan statistics from task scheduler

Signed-off-by: dragondriver <jiquan.long@zilliz.com>

* Fix i/dist/dataservice test code

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

* Fix epoch lifetime not applied

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

* fix datanode flowgraph dd node

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

* Fix handle datanode timetick bug

Signed-off-by: sunby <bingyi.sun@zilliz.com>

* Remove repack function of dml stream

Signed-off-by: dragondriver <jiquan.long@zilliz.com>

* fix proxynode

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* Apply extended seal policy

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

* add check for time tick

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* fix check

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* Fix the repack function of dml stream

Signed-off-by: dragondriver <jiquan.long@zilliz.com>

* Fix the bug when send statistics of pchan

Signed-off-by: dragondriver <jiquan.long@zilliz.com>

* Fix the repack function when craete dml stream

Signed-off-by: dragondriver <jiquan.long@zilliz.com>

* fix bugs

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* fix describe collection

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* Fix bug when send timestamp statistics

Signed-off-by: dragondriver <jiquan.long@zilliz.com>

* fix data node

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* Add length check before flush request

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

* add log for data node

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* Fix SaveBinlog bugs

Signed-off-by: sunby <bingyi.sun@zilliz.com>

* Add more log in datanode

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

* Put SegmentState.Flushing as the last one in enum to fit the client

Signed-off-by: sunby <bingyi.sun@zilliz.com>

* Fix params in GetInsertBinlogPaths

Signed-off-by: sunby <bingyi.sun@zilliz.com>

* Rename policy

Signed-off-by: sunby <bingyi.sun@zilliz.com>

* Remove unused ddl functions and fields

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

* Remove pchan when drop collection

Signed-off-by: dragondriver <jiquan.long@zilliz.com>

* Add balanced assignment policy

Signed-off-by: sunby <bingyi.sun@zilliz.com>

* fix master ut

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* Add lock in session manager

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

* add log for debug

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* Fix some logic bug and typo

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

* Fix recover bugs

Signed-off-by: sunby <bingyi.sun@zilliz.com>

* Get collection scheme of a specific timestamp

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

* Change CheckPoint to SegmentInfo in VchannelInfo

Signed-off-by: sunby <bingyi.sun@zilliz.com>

* Recover Unflushed segment numOfRows

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

* Fix dataservice unit tests

Signed-off-by: sunby <bingyi.sun@zilliz.com>

Co-authored-by: yefu.chen <yefu.chen@zilliz.com>
Co-authored-by: yangxuan <xuan.yang@zilliz.com>
Co-authored-by: dragondriver <jiquan.long@zilliz.com>
Co-authored-by: Congqi Xia <congqi.xia@zilliz.com>
2021-06-15 16:06:11 +08:00
XuanYang-cn e7fd3aa926 Flowgraph recovery (#5640)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-15 16:04:48 +08:00
XuanYang-cn ac19711d74 Destroy DataNode when drop collections (#5638)
* Destroy DataNode when drop collections

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

* golanci-lint

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

Co-authored-by: yefu.chen <yefu.chen@zilliz.com>
2021-06-15 16:04:48 +08:00
neza2017 74c73fa75f fix datanode (#5635)
Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-06-15 16:04:48 +08:00
neza2017 7064937dc3 fix insertBuffer node (#5632)
Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-06-15 16:04:48 +08:00
neza2017 0c362a8831 fix bug and add unit test for insert buffer (#5630)
Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-06-15 16:04:48 +08:00
neza2017 3c70675313 data node, save binlog to minIO, and let data service save these meta (#5618)
Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-06-15 16:04:48 +08:00
neza2017 0a82c6381f add auto flush for data node (#5609)
Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-06-15 16:04:48 +08:00
congqixia d0d845805b Change WatchDmChannelsRequest proto (#5577)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-06-15 16:04:48 +08:00
godchen 275881dbdb Remove address param (#5556)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-06-15 16:04:46 +08:00
XuanYang-cn e96d39bf6a refactor datanode flowgraph (#5538)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-15 15:59:04 +08:00
congqixia 31c4a4f5ed Simplify dd buffer & add lock (#5513)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-06-15 15:59:04 +08:00
congqixia 68bf983f21 Add Collection ID in ddNode and filter logic (#5496)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-06-15 15:59:04 +08:00
XuanYang-cn 6c02ae4eb1 Remove Old msgposition logic (#5487)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-15 15:59:04 +08:00
congqixia 8657251f41 DataNode stores segment msgpack positions (#5472)
* DataNode stores segment msgpack positions

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

* Fix typo caused deadlock

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

* Use MsgPack EndPositions for flush pos

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-06-15 15:59:04 +08:00
XuanYang-cn 7a8b34ee9f Remove not using code in DataNode (#5476)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-15 15:59:04 +08:00
XuanYang-cn 55eac3ee7f Complete Flush procedure in DataNode (#5454)
* Complete Flush proceduer in DataNode

Resolves: #5220

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

* fix unittest

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-15 15:59:04 +08:00
sunby cfdd98b70f Fix recovery branch after rebasing master (#5444)
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-06-15 15:59:04 +08:00
congqixia e3956ad13f Change SaveBinLogPaths field2Path to repeated (#8)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-06-15 15:59:04 +08:00
yangxuan ef563fda8f Updata flushe procedure
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-15 15:59:04 +08:00
sunby c53afee616 DataNode scales flowgraph
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-06-15 15:59:04 +08:00
zhenshan.cao 7dac20c35c
Add log for poxynode transform data and querynode segment insert (#5627)
* Add log for poxynode transform data and querynode segment insert

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>

* Decrease print times

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-06-05 16:21:36 +08:00
zhenshan.cao 03e3b4beb4
Add log to startup process (#5594)
* Add log to startup process

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>

* Fixbug: avoid ctx exceed deadline

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>

* Fmt code

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>

* Fix bug: wrong time unit

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>

* Fixbug: datanservice client reconnect use time ctx

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-06-04 16:29:35 +08:00
Xiangyu Wang f791ccb246 Update OWNERS file
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-06-03 20:01:24 +08:00
zhenshan.cao b0b8f58192
Fix bug: search timeout (#5557)
* Fix bug: search timeout

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>

* Add log and fix unittest bug

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-06-03 14:58:34 +08:00
Xiangyu Wang ca0993c274 Update OWNERS
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-05-30 18:58:47 +08:00
neza2017 f80dbab6ec
watch proxynode (#5424)
watch proxy node and,
send InvalidataCollectionMetaCache to each proxynode

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

Resolves: #5423
2021-05-26 12:14:30 +00:00
neza2017 c28c34e852
let master use session.ServerID as nodeID (#5385)
let master use session.ServerID as nodeID

also see #5386 

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-05-25 07:06:05 +00:00
neza2017 e326eaad1e
master client,reconnect if grpc failed (#5360)
master client,reconnect if grpc failed

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-05-24 01:44:49 +00:00
godchen 0eee7e5252
Change session (#5329)
Change session.

Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-05-21 11:28:52 +00:00
congqixia 46790d9c68
Fix issue 5333 uninitialized return value (#5338)
Fix uninitialized named value `meta` caused crash

Resolves #5333 

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-05-21 08:21:08 +00:00
Xiangyu Wang 23c4de0eb8
Flush statistics for all int64 fields (#5318)
Resolves: #5262

Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-05-20 10:38:45 +00:00
XuanYang-cn 1c779f3efd
Refactor ddl binlog flush (#5303)
DDL won't auto-flush now

See also: #5289 , #5220 

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-05-19 11:42:07 +00:00
godchen e224d1e725
Add SessionManager (#5288)
Add SessionManager.
Resolves: #5174 

Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-05-19 10:36:05 +00:00
XuanYang-cn fc630bc1c8
Correct auto-flush behaviour (#5282)
Before this PR, DataNode considered auto-flush a valid flush
complete. It's wrong. So I open this PR to correct this behaviour
in DataNode.

Now binlog paths from auto-flush will be buffered in replica,
waiting until the manul flush to save into etcd all together.

See also: #5220, #5268
A follow up job of #5271 

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-05-18 11:45:00 +00:00
XuanYang-cn c3ac1375d8
Add buffer function for auto flush (#5271)
Auto-flush of a segment is not considered flush-completed.
So we need to buffer binlog paths generated by auto-flush.

See also: #5268 #5220 

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-05-18 08:33:05 +00:00
godchen b74afd7a0e
Add service registration (#5189)
Add service registration.
Part of Issue #5174.

Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-05-14 02:05:18 +00:00
XuanYang-cn eb557b289b
Add docs in package datanode (#5117)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-05-08 07:24:12 +00:00
Cai Yudong 5f0006d0f9
Improve code coverage for distributed/datanode (#5133)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-05-08 06:07:04 +00:00
XuanYang-cn cebdfb34f7
Enable multiple datanode (#5068)
Now it's able to start multiple datanode, however, they will process the same insert data.
Further changes are needed to truly enable multiple datanode:

While registering, dataservice need to return different insert channels for different datanode.

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-04-28 18:43:48 +08:00
Xiangyu Wang 82ccd4cec0
Rename module (#4988)
* Rename module

Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-04-22 14:45:57 +08:00
Cai Yudong 51cae2c9ba
add datanode unittest to improve code coverage (#4982)
add datanode unittest to improve code coverage 

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-04-21 18:41:37 +08:00
XuanYang-cn 6deba1faa5 Add license in datanode package
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-04-19 15:16:33 +08:00
Cai Yudong a2041abab4 improve code coverage for datanode
improve code coverage for collection_replica_test.go
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-04-19 10:34:56 +08:00
sunby a7dac818ee Refactor datanode register
Dataservice should not be stalled during registering datanode.

Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-04-13 09:47:02 +08:00
godchen deba964590 Change name of kvBase
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-04-12 18:09:28 +08:00
Xiangyu Wang 87a1e0b662 Reorganize msgstream
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-04-02 13:48:25 +08:00
XuanYang-cn 91f5c48037 Fix datanode goroutine leak
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-03-30 09:47:27 +08:00
xige-16 a48d46cfaf Alter msgID’s type to bytes
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-03-27 09:46:54 +08:00
quicksilver 7ad9b36207 Update reviewdog/action-hadolint github action version to v1.16.1
Signed-off-by: quicksilver <zhifeng.zhang@zilliz.com>
2021-03-25 14:41:46 +08:00
sunby ca3187d173 Fix data race in datanode tests
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-03-24 16:35:38 +08:00
XuanYang-cn 51f669f1cb Flush segments concurrently & change etcd meta
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-03-23 18:50:13 +08:00
bigsheeper 1634d75980 Release flowgraph properly
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-03-22 12:49:50 -05:00
zhenshan.cao c2734fa55f Fix bug and enchance system
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-03-22 16:36:10 +08:00
XuanYang-cn 32660d547b Add endPositions in datanode
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-03-16 17:55:42 +08:00
godchen f3649f0419 Refactor interface and proto
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-03-12 14:22:09 +08:00
ThreadDao ca916a5c47 Add ci nightly
Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
2021-03-11 14:14:29 +08:00
xige-16 09ae985daa Fix wrong error code in master_service_test.go
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-03-10 22:06:22 +08:00
del-zhenwu b1763c3690 Disable xdist in test cases
Signed-off-by: del-zhenwu <zhenxiang.li@zilliz.com>
2021-03-10 15:27:26 +08:00
neza2017 7b2d67242d Fix describe segment if index not exist
Signed-off-by: neza2017 <yefu.chen@zilliz.com>
2021-03-10 14:45:35 +08:00
quicksilver 455cc59dbb Update publish-test-images.yaml
Signed-off-by: quicksilver <zhifeng.zhang@zilliz.com>
2021-03-09 13:55:35 +08:00
sunby 76480fcefe Change default log output to stdout
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-03-08 16:24:55 +08:00
sunby ab21115d54 Init rand.Seed
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-03-08 15:25:55 +08:00
neza2017 2835bcdc4e Update masterservice unittest
Signed-off-by: neza2017 <yefu.chen@zilliz.com>
2021-03-05 20:41:34 +08:00
Xiangyu Wang e5d595564a Add log for singlenode
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-03-05 18:16:50 +08:00
quicksilver 74154a11a4 Fix deploy error during regression stage
Signed-off-by: quicksilver <zhifeng.zhang@zilliz.com>
2021-03-05 16:52:45 +08:00
sunby ddddd65d10 Delete internal/errors package
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-03-05 10:15:27 +08:00
godchen 3ba0dc2f44 Change doc
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-03-04 10:35:28 +08:00
XuanYang-cn c0edffc63f Fix datanode update segment statistics bug
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-03-02 15:47:37 +08:00
godchen 7b9fdd7f29 Add opentracing
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-02-26 17:44:24 +08:00
cai.zhang f5977a1302 Change retry times and add retry logic
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-02-26 15:17:47 +08:00
XuanYang-cn 10374f15d7 Update log in datanode
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-02-26 10:13:36 +08:00
Cai Yudong 84110d2684 Add tests/benchmark and tests/python_test using new python SDK
Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
2021-02-25 17:35:36 +08:00
XuanYang-cn fd562f9f9c Update doc: add proxy graph
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-02-24 09:48:17 +08:00
zhenshan.cao bbfcbbdd68 Fix ci: paramstable and startup logic refactor
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-02-23 11:40:30 +08:00
xige-16 a6442cb600 Fix querynode memory leak
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-02-20 09:20:51 +08:00
groot dc3736281a Integrate message stream
Signed-off-by: groot <yihua.mo@zilliz.com>
2021-02-08 14:30:54 +08:00
bigsheeper 7342e0758c Fix index and flush errors, and fix master crash error
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-02-07 17:02:13 +08:00
groot b034740c6c Make paramstable initialize once by using do_once
Signed-off-by: groot <yihua.mo@zilliz.com>
2021-02-06 13:39:15 +08:00
sunby 0111cba8ae Fix startup bugs in some modules
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-02-06 10:28:53 +08:00
XuanYang-cn a64c4efde9 Refactor collectionReplica in datanode
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-02-04 20:31:23 +08:00
godchen c2ca2c276f Fix response check error
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-02-04 19:34:35 +08:00
dragondriver e0e8e1605e Implement the release-related task and load-related task in Proxy
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-02-04 17:47:19 +08:00
sunby 7270d18c98 Fix timesync startup bugs
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-02-04 17:31:02 +08:00
XuanYang-cn 560d2350ae Fix datanode watchDmChannel bug
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-02-04 16:09:34 +08:00
zhenshan.cao b89e5a3240 Add GetQuerySegmentInfo
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-02-04 14:37:12 +08:00
sunby 71b6c88c6e Defer lock's unlock in meta::DropSegment
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-02-04 11:52:10 +08:00
Xiangyu Wang 8d35e76ad1 Change Msgstream interface
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-02-04 13:55:47 +08:00
XuanYang-cn 1aafe86ffe Change MsgPosition Logic
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-02-04 11:19:48 +08:00
XuanYang-cn bc7ad02df4 Fix datanode init bug
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-02-04 10:25:01 +08:00
Xiangyu Wang fd9e42d3ed Update msgstream/unmarshal interface
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-02-03 17:30:10 +08:00
bigsheeper abffdbff62 Remove partition tag
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-02-03 16:44:38 +08:00
XuanYang-cn 73a8e7de84 Fix datanode insertchannel refresh bug
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-02-03 15:18:05 +08:00
zhenshan.cao 3afa7dd50d Fix GetSegmentStates
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-02-02 10:58:39 +08:00
neza2017 3f45cfd6e8 Fix data node
Signed-off-by: neza2017 <yefu.chen@zilliz.com>
2021-02-01 11:44:02 +08:00
Xiangyu Wang 99cef4b5c8 Add Distributed main entrypoint
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-01-29 17:08:31 +08:00
bigsheeper 73d2b6a101 Get index param from minio and filter by vector fields
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-01-29 15:22:24 +08:00
neza2017 bdf84f08ab Add watcher_test and fix some bugs
Signed-off-by: neza2017 <yefu.chen@zilliz.com>
2021-01-29 14:40:19 +08:00
sunby f088467dde Add watcher_test and fix some bugs
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-01-28 10:14:31 +08:00
XuanYang-cn b597a637f3 Add datanode metatable tests
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-01-29 12:03:10 +08:00
sunby bcd7368533 Fix get component states
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-01-28 15:20:24 +08:00
sunby 5ac463c9ca Add datanode client in data service
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-01-28 11:24:41 +08:00
XuanYang-cn 4acaa97039 Add unittests for datanode and queryservice
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-01-27 20:00:47 +08:00
sunby b4bcaaf847 Fix data service startup bug
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-01-27 11:40:10 +08:00
XuanYang-cn 05b013c52a Fix datanode bug
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-01-27 11:37:26 +08:00
xige-16 947976dbec Add test for query service’s load function
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-01-27 11:34:16 +08:00
neza2017 d1b23cb8c5 Add debug info
Signed-off-by: neza2017 <yefu.chen@zilliz.com>
2021-01-26 19:24:09 +08:00
XuanYang-cn b445587e11 Add datanode main
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-01-26 14:46:54 +08:00
XuanYang-cn 6c303c67b2 Rearrange update segment statistics of start position procedure
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-01-26 09:44:39 +08:00
bigsheeper 7554246ace Add segment seeking and use real client
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-01-25 18:33:10 +08:00
sunby 7c0c835b49 Init params and add segment start/end position
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-01-25 15:16:28 +08:00
XuanYang-cn 5015a1035d Add logic of get meta from MasterService for datanode
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-01-25 17:10:32 +08:00
XuanYang-cn 5d9d35b733 Add Supplementary statistics
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-01-25 13:36:40 +08:00
XuanYang-cn 9fe672ab86 Enchance datanode interface
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-01-24 21:20:11 +08:00
XuanYang-cn 50e2369000 Change name and tag to ID
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-01-22 19:36:09 +08:00
XuanYang-cn 377ee8687d Modify flush logic
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-01-22 09:36:40 +08:00
XuanYang-cn ec27788628 Add segment statistics updates logic for datanode
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-01-21 09:55:25 +08:00
Xiangyu Wang 7ee8623e1a Refactor msgstream
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-01-20 10:02:59 +08:00
XuanYang-cn 6a13386393 Add DataNode package
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-01-19 11:37:16 +08:00