milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove not in use segmentCheckPoints (#8039) 

Resolves: #8037

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
pull/8138/head
XuanYang-cn 2021-09-17 16:25:55 +08:00 committed by GitHub
parent 422b7dcf3e
commit 82d4d19337
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
internal/datanode/flow_graph_insert_buffer_node.go
View File

@ -65,9 +65,7 @@ type insertBufferNode struct {
timeTickStream msgstream.MsgStream
segmentStatisticsStream msgstream.MsgStream
dsSaveBinlog func(fu *segmentFlushUnit) error
segmentCheckPoints map[UniqueID]segmentCheckPoint
segmentCheckPointLock sync.Mutex
dsSaveBinlog func(fu *segmentFlushUnit) error
}
type segmentCheckPoint struct {
@ -891,11 +889,10 @@ func newInsertBufferNode(
timeTickStream: wTtMsgStream,
segmentStatisticsStream: segStatisticsMsgStream,
replica: replica,
flushMap: sync.Map{},
flushChan: flushCh,
idAllocator: idAllocator,
dsSaveBinlog: saveBinlog,
segmentCheckPoints: make(map[UniqueID]segmentCheckPoint),
replica: replica,
flushMap: sync.Map{},
flushChan: flushCh,
idAllocator: idAllocator,
dsSaveBinlog: saveBinlog,
}, nil
}

15
internal/datanode/flow_graph_insert_buffer_node_test.go
View File

@ -469,13 +469,6 @@ func TestFlowGraphInsertBufferNode_AutoFlush(t *testing.T) {
inMsg.startPositions = []*internalpb.MsgPosition{{Timestamp: 234}}
inMsg.endPositions = []*internalpb.MsgPosition{{Timestamp: 345}}
iBNode.Operate([]flowgraph.Msg{iMsg})
assert.Equal(t, len(iBNode.segmentCheckPoints), 3)
assert.Equal(t, iBNode.segmentCheckPoints[1].numRows, int64(50+16000+100+32000))
assert.Equal(t, iBNode.segmentCheckPoints[2].numRows, int64(100+32000))
assert.Equal(t, iBNode.segmentCheckPoints[3].numRows, int64(0))
assert.Equal(t, iBNode.segmentCheckPoints[1].pos.Timestamp, Timestamp(345))
assert.Equal(t, iBNode.segmentCheckPoints[2].pos.Timestamp, Timestamp(234))
assert.Equal(t, iBNode.segmentCheckPoints[3].pos.Timestamp, Timestamp(123))
assert.Equal(t, len(flushUnit), 2)
assert.Equal(t, flushUnit[1].segID, int64(1))
@ -511,11 +504,6 @@ func TestFlowGraphInsertBufferNode_AutoFlush(t *testing.T) {
assert.Equal(t, len(flushSeg), 1)
assert.Equal(t, flushSeg[0].FieldID, int64(1))
assert.NotNil(t, flushSeg[0].Binlogs)
assert.Equal(t, len(iBNode.segmentCheckPoints), 2)
assert.Equal(t, iBNode.segmentCheckPoints[2].numRows, int64(100+32000))
assert.Equal(t, iBNode.segmentCheckPoints[3].numRows, int64(0))
assert.Equal(t, iBNode.segmentCheckPoints[2].pos.Timestamp, Timestamp(234))
assert.Equal(t, iBNode.segmentCheckPoints[3].pos.Timestamp, Timestamp(123))
assert.Equal(t, len(flushUnit), 3)
assert.Equal(t, flushUnit[2].segID, int64(1))
@ -545,9 +533,6 @@ func TestFlowGraphInsertBufferNode_AutoFlush(t *testing.T) {
assert.Equal(t, len(flushSeg), 1)
assert.Equal(t, flushSeg[0].FieldID, int64(3))
assert.NotNil(t, flushSeg[0].Binlogs)
assert.Equal(t, len(iBNode.segmentCheckPoints), 1)
assert.Equal(t, iBNode.segmentCheckPoints[2].numRows, int64(100+32000))
assert.Equal(t, iBNode.segmentCheckPoints[2].pos.Timestamp, Timestamp(234))
assert.Equal(t, len(flushUnit), 4)
assert.Equal(t, flushUnit[3].segID, int64(3))
assert.Equal(t, len(flushUnit[3].checkPoint), 2)