Commit Graph

18521 Commits (381a45012a32824b9e57a8b5125c646fd6ca11a8)

Author SHA1 Message Date
sre-ci-robot 381a45012a Update all contributors
Signed-off-by: sre-ci-robot <sre-ci-robot@zilliz.com>
2023-11-29 12:25:57 +00:00
congqixia 3f9da2b8a0
fix: Check whether compaction plan exist before update (#28826)
Fix: #28825

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-29 18:54:27 +08:00
cqy123456 3b1b14dd78
fix: update binlog index memory uasge before loading segments (#28528)
issue: #27678 
when interimIndex = true, memory predict should be update with the
memory usage of binlog index build process.

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2023-11-29 16:42:27 +08:00
sre-ci-robot d10c5af7aa
[automated] Update Pytest image changes (#28751)
Update Pytest image changes
See changes:
8fe2fb3eb9
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-11-29 12:56:27 +08:00
yah01 c0f6eccb7a
fix: No LevelZero segment in target (#28803)
the incorrect filter causes all LevelZero segment filtered, so the
deleted entities may be still visible
related: #27349

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-29 11:48:27 +08:00
XuanYang-cn 321c5c32e3
fix: Separate schedule and check results loop (#28692)
This PR:

- Separates compaction scheduler and check results loop So that slow in
check-loop doesn't influence execution.

- Cleans compaction tasks when drop a vchannel so dropped-channel's
compaction tasks won't be checked over and over again.

  - Skips meta change when meta's already changed, avoid panic
  - Remove not inuse injectDone(bool) parameter

See also: #28628, #28209

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-11-29 10:50:29 +08:00
nico 845851ea1c
test: add test cases (#28541)
1. modify test cases about output a non-existed field. issue: #28465
2. add cases about creating collection using different language
3. add test case about inserting a string value to a pk(int64) field
4. add test case about search with expression using double quotes.
issue: #28365

Signed-off-by: nico <cheng.yuan@zilliz.com>
2023-11-29 10:48:26 +08:00
nico 92b48c5384
test: add range search iterator back (#28659)
Signed-off-by: nico <cheng.yuan@zilliz.com>
2023-11-29 10:30:28 +08:00
nico 4d53980456
test: modify test cases (#28800)
1. Drop a non-existing partition will not raise error now. #28722
2. Search will not raise error now when some row has less elements than
expression index. #28293

Signed-off-by: nico <cheng.yuan@zilliz.com>
2023-11-29 10:26:26 +08:00
Gao 5bd73d5503
enhance: add efficient distance computations in Go (#28657)
Related #28656
Add more efficient calc_distance at Go side.

---------

Signed-off-by: chasingegg <chao.gao@zilliz.com>
2023-11-28 18:20:26 +08:00
XuanYang-cn 606ec77b66
enhance: Unify levelzero segment config in DN (#28720)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-11-28 18:04:26 +08:00
congqixia 881a166b5a
fix: data race on rootcoord.proxyClientManager.proxyClient (#28787)
Fix #28786

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-28 15:52:26 +08:00
aoiasd 89d8ce2f73
enhance: refine access log to support format access log by yaml and print name info. (#28319)
relate: https://github.com/milvus-io/milvus/issues/28086

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-11-28 15:32:31 +08:00
cai.zhang 1b7a503f89
enhance: Revert import support csv format (#28760)
Revert import support csv format.
issue: #28778

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-28 14:32:27 +08:00
congqixia 5025c10e8b
enhance: Remove channel cp lag metrics when DropChannel (#28784)
See also #28765
Remove metric when Drop channel grpc execute succeed

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-28 14:24:25 +08:00
groot 9c9ab08f54
test: Avoid unstable case of bulkinsert (#28679)
test: There are too many test cases for bulkinsert+partition_key. Each
case creates 10 bulkinsert tasks to import a file with 100~200 rows. The
default num_partitions is 64 for partition_key. So, each task will
generate 64 tiny segments. There are 10 cases, each case 10 tasks, each
task 64 tiny segment, totally there are 6400 tiny segments generated.
And all these segment row count is less than 1024, no need to build
index, and take part in compaction. There will be lots of compaction
tasks generated. It costs too much time to process these compaction
tasks. Eventually, some cases are timeout after waiting 5 minutes for
their segments to be ready and cases fail.

Specifying the num_partitions to a small value can avoid this problem.

```
[2023-11-21T03:41:16.187Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_json_file[int_scalar-True-True] PASSED [ 54%]
[2023-11-21T03:41:42.796Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_json_file[int_scalar-False-True] PASSED [ 57%]
[2023-11-21T03:42:04.694Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_json_file[string_scalar-True-True] PASSED [ 60%]
[2023-11-21T03:42:31.205Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_json_file[string_scalar-False-True] PASSED [ 63%]
[2023-11-21T03:43:38.876Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_multi_numpy_files[10-150-13-True] XPASS [ 66%]
[2023-11-21T03:49:00.357Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_multi_numpy_files[10-150-13-False] XFAIL [ 69%]
[2023-11-21T03:53:51.811Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_csv_file[int_scalar-True] FAILED [ 72%]
[2023-11-21T03:58:58.283Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_csv_file[int_scalar-False] FAILED [ 75%]
[2023-11-21T04:02:04.696Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_csv_file[string_scalar-True] PASSED [ 78%]
[2023-11-21T04:02:26.608Z] testcases/test_bulk_insert.py::TestBulkInsert::test_partition_key_on_csv_file[string_scalar-False] PASSED [ 81%]
```

Signed-off-by: yhmo <yihua.mo@zilliz.com>
2023-11-28 10:34:31 +08:00
aoiasd ce2436127c
fix: log can not reduce level (#28750)
relate: https://github.com/milvus-io/milvus/issues/28749

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-11-28 10:02:27 +08:00
yihao.dai 4bd426dbe7
fix: Fix minio latency monitoring for get operation (#28510)
see also: https://github.com/milvus-io/milvus/issues/28509

Currently Minio latency monitoring for get operation only collects the
duration of getting object (which just returns an io.Reader and does not
really read from minio), this pr will correct this behavior.

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-11-28 10:00:27 +08:00
congqixia dd682658da
enhance: Add channel checkpoint ts lag metric (#28767)
See also #28765

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-28 07:00:28 +08:00
SimFG 9c46788d87
enhance: Support to trace restful request and request error (#28685)
issue: #28348

Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-11-27 20:14:26 +08:00
congqixia eaabe0293b
fix: Update segment compactTo when compactTo segment is compacted (#28755)
Related to #28736 #28748
See also #27675
Previous PR: #28646

This PR fixes `SegmentNotFound` issue when compaction happens multiple
times and the buffer of first generation segment is sync due to stale
policy

Now the `CompactSegments` API of metacache shall update the compactTo
field of segmentInfo if the compactTo segment is also compacted to keep
the bloodline clean

Also, add the `CompactedSegment` SyncPolicy to sync the compacted
segment asap to keep metacache clean

Now the `SyncPolicy` is an interface instead of a function type so that
when it selects some segments to sync, we colud log the reason and
target segment

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-27 19:48:26 +08:00
jaime b1e0a27f31
enhance: Add logs for each step during service initialization (#28624)
/kind improvement

Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-11-27 16:30:26 +08:00
jaime c5f455dc6b
fix: cmux graceful shutdown on proxy service (#28383)
issue #28305

Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-11-27 16:28:34 +08:00
wei liu 911a915798
feat: enable balance based on growing segment row count (#28623)
issue: #28622 

query node with delegator will has more rows than other query node due
to delgator loads all growing rows.
This PR enable the balance segment which based on the num of growing
rows in leader view.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-11-27 14:58:26 +08:00
cai.zhang c29b60e18e
enhance: Support Array DataType for bulk_insert (#28341)
issue: #28272 
Support array DataType for bulk_insert with json, binlog files.

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-27 13:50:27 +08:00
nico 8fe2fb3eb9
test: update pymilvus version (#28636)
issue: #17614

Signed-off-by: nico <cheng.yuan@zilliz.com>
2023-11-27 12:56:25 +08:00
MrPresent-Han fc30d291be
fix createCollection failed occasionally (#28592) (#28712)
fix: create collection seldom failure #28592

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-11-27 11:10:25 +08:00
Xiaofan f13ef1665a
fix : macos clean compilation fail, brew install some missed library (#28717)
fix macOS compilation fail, related #28715
1) install_deps.sh missed to install some dependencies 
2) llvm can not be found without a soft link

Signed-off-by: xiaofan luan <xiaofanluan@xiaofandeMacBook-Pro.local>
Co-authored-by: xiaofan luan <xiaofanluan@xiaofandeMacBook-Pro.local>
2023-11-27 10:06:26 +08:00
congqixia 8a9ab69369
fix: Skip statslog generation flushing empty L0 segment (#28733)
See also #27675

When L0 segment contains only delta data, merged statslog shall be
skiped when performing sync task

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-25 15:10:25 +08:00
congqixia d344336a13
fix: Change schema to atomic.Pointer to avoid data race (#28739)
Fix #28738

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-25 12:42:24 +08:00
Bingyi Sun 8514a39d1a
feat: Add checker activation (#28611)
issue: https://github.com/milvus-io/milvus/issues/28610

---------

Signed-off-by: sunby <sunbingyi1992@gmail.com>
2023-11-24 18:08:24 +08:00
SimFG 089e58dfbb
fix: Fix the unstable unit test `TestReplicateManager` (#28718)
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-11-24 17:50:30 +08:00
sre-ci-robot 86ccb8e146
[automated] Update Knowhere Commit (#28704)
Update Knowhere Commit
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-11-24 16:56:24 +08:00
aoiasd 8a4cfb7d6a
enhance: add l0 metric and fix datacoord no need drop l0 segment when flush (#28373)
relate: https://github.com/milvus-io/milvus/issues/27675

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-11-24 15:58:24 +08:00
congqixia 39be35804c
enhance: Add back clean compacted segment info logic (#28646)
See also #27675
Compacted segment info shall be removed after all buffer belongs to it
is sync-ed.
This PR add the cleanup function after triggerSyncTask logic:
- The buffer is stable and protected by mutex
- Cleanup fetches compacted & non-sync segment
- Remove segment info only there is no buffered maintained in manager

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-24 15:38:25 +08:00
yah01 3ea0129eb3
enhance: improve the error messages and logs (#28684)
- better name for log fields
- make the error and log consistent

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-24 15:08:24 +08:00
XuanYang-cn 24616e7838
fix: Remove ignored files in path (#28696)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-11-24 15:04:26 +08:00
smellthemoon 79c0edb1d8
enhance:Remove msgbase unnecessary assignments (#28511)
remove some unnecessary assignments, for the reason that
commonpbutil.NewMsgBase has default value.

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2023-11-24 15:02:39 +08:00
nico 824e278219
test: update test cases for new error code&msg (#28706)
issue: #23075

Signed-off-by: nico <cheng.yuan@zilliz.com>
2023-11-24 14:52:25 +08:00
cai.zhang 6f7a9264d5
enhance: Handle knowhere error for creare diskann index (#28690)
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-24 11:58:23 +08:00
wayblink 5aedbd0af4
fix: Repair integration test framework (#28308)
#28307

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-11-24 10:26:23 +08:00
Bingyi Sun 2843664a20
fix: channel name can not contains '-partition-' (#28689)
issue: https://github.com/milvus-io/milvus/issues/28675

Signed-off-by: sunby <sunbingyi1992@gmail.com>
2023-11-24 10:14:24 +08:00
sre-ci-robot 3199da3b77
[automated] Update Builder gpu image changes (#28702)
Update Builder gpu image changes
See changes:
90997a5ddb
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-11-24 10:00:24 +08:00
sammy.huang fa66c2829d
enhance: [skip e2e] add auto prefix for the PR from bot (#28705)
Signed-off-by: Sammy Huang <sammy.huang@zilliz.com>
2023-11-24 09:42:23 +08:00
wayblink 53646032d0
fix: rootcoord_collection_num metric is twice the real value (#28666)
#28665

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-11-23 20:42:23 +08:00
PowderLi 90997a5ddb
enhance: update the base image: milvusdb/milvus-env (#28505)
issue: #28683
to avoid downloading installation packages in CI workload install vcpkg
and install some packages in advance

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-11-23 19:58:25 +08:00
zhagnlu 0d9d098186
enhance: Add precheck when chunk manager init (#28330)
#28329

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2023-11-23 19:56:32 +08:00
wayblink da339535d5
enhance: Merge flowgraph goroutines into 1 (#28654)
/kind enhancement
#24826

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-11-23 19:52:25 +08:00
wei liu 4b8d3eaa41
enhance: Increase heartbeat timeout (#28648)
it's easy to trigger heartbeat timeout after 100ms when standalone cpu
usage reach 100%.
This PR increase the heartbeat timeout param to 2000ms

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-11-23 19:50:24 +08:00
congqixia 098c1c926d
fix: Add IndexList check for load segment request (#28601)
See also #28022 #28034
The load segment may reaches before watch dml channel, so the index meta
may be empty as well

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-23 19:42:30 +08:00