milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: data race on rootcoord.proxyClientManager.proxyClient (#28787) 

Fix #28786

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
pull/28800/head
congqixia 2023-11-28 15:52:26 +08:00 committed by GitHub
parent 89d8ce2f73
commit 881a166b5a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/rootcoord/root_coord.go
View File

@ -2803,6 +2803,7 @@ func (c *Core) CheckHealth(ctx context.Context, in *milvuspb.CheckHealthRequest)
group, ctx := errgroup.WithContext(ctx)
errReasons := make([]string, 0, len(c.proxyClientManager.proxyClient))
c.proxyClientManager.lock.RLock()
for nodeID, proxyClient := range c.proxyClientManager.proxyClient {
nodeID := nodeID
proxyClient := proxyClient
@ -2821,6 +2822,7 @@ func (c *Core) CheckHealth(ctx context.Context, in *milvuspb.CheckHealthRequest)
return nil
})
}
c.proxyClientManager.lock.RUnlock()
err := group.Wait()
if err != nil || len(errReasons) != 0 {