Commit Graph

415 Commits (2.5)

Author SHA1 Message Date
cai.zhang 53a49a9255
GetIndexState only get the state generated call CreateIndex (#17549)
Signed-off-by: Cai.Zhang <cai.zhang@zilliz.com>
2022-06-16 20:12:11 +08:00
xing.zhao e9dcda161f
Add aliases return value in describeCollection task (#17516)
Signed-off-by: xingzhao <xing.zhao@zilliz.com>

Co-authored-by: 赵星 <zhaoxing@zhaoxings-MacBook-Pro.local>
2022-06-13 19:22:10 +08:00
Letian Jiang dfaed5acdd
Add QueryServiceAvailable field in ShowCollections (#17456)
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
2022-06-09 18:20:07 +08:00
Jiquan Long 2ca81620ea
Reduce lock operations when get dml stream (#17468)
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2022-06-09 17:34:09 +08:00
xige-16 b5c11a216d
Alter varChar type params's name to max_length (#17409)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2022-06-07 15:58:06 +08:00
Jiquan Long adf3b14027
Refine channels management in Proxy. (#17334)
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2022-06-02 15:34:04 +08:00
congqixia c88514bc49
Remove not used QueryChannel in Proxy and Query Cluster (#16856)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-05-30 19:50:04 +08:00
bigsheeper 9eeec4a2d5
Add collection load cache and InvalidateCollMetaCache by collID (#16882)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2022-05-19 10:13:56 +08:00
XuanYang-cn a1480aaf76
Clear shard leaders cache when releasing (#16942)
See also: #16926

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-05-17 11:11:56 +08:00
Xiaofan 52fc9a558c
Fix valid error message (#16953)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-05-13 18:19:53 +08:00
xige-16 9e6d9fb7d8
Print collectionName when load failed (#16878)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2022-05-11 09:47:53 +08:00
xige-16 8fcf349609
Fix create index failed after drop index (#16836)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2022-05-09 11:35:53 +08:00
xige-16 009b773b6e
Delete set default type param max_len for varchar field (#16794)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2022-05-06 15:59:51 +08:00
Jiquan Long 2fe8677cbf
Enable dimension check in Proxy when create index request received (#16718)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2022-04-29 18:01:49 +08:00
xige-16 515d0369de
Support string type in segcore (#16546)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
Co-authored-by: dragondriver <jiquan.long@zilliz.com>

Co-authored-by: dragondriver <jiquan.long@zilliz.com>
2022-04-29 13:35:49 +08:00
zhenshan.cao 0a953948af
Simplify monitoring metrics (#16687)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2022-04-27 23:03:47 +08:00
zhenshan.cao a3f7bb5f2d
Remove the collectionID label from metrics (#16571)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2022-04-26 17:29:45 +08:00
Xiaofan 89b4a34892
Fix Data race in NodeID (#16603)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-04-24 22:03:44 +08:00
congqixia 69252f812d
Implement memory replica in Proxy, QueryNode and QueryCoord (#16470)
Related to #16298 #16291 #16154
Co-authored-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: yangxuan <xuan.yang@zilliz.com>
Co-authored-by: yah01 <yang.cen@zilliz.com>
Co-authored-by: Letian Jiang <letian.jiang@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-20 16:15:41 +08:00
xige-16 99984b88e1
Support delete varChar value (#16229)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2022-04-02 17:43:29 +08:00
XuanYang-cn e9090a62ab
Rearrange search/queryTask for readability (#16325)
`searchTask` has 683 lines of code, `queryTask` has 485 lines of code.
`task.go` contains 4k+ codes including `searchTask` and `queryTask`.

It was so much pain navigating codes of searchTask and queryTask though task.go,
task.go and task_test.go are literaly unreadable.

This PR moves
1. 650+ lines of code of `searchTask` from `task.go` to `task_search.go`.
2. 1.4k+ lines of test code of `searchTask` from `task_test.go` to
   `task_search_test.go`.
3. 450+ lines of code of `queryTask` from `task.go` to `task_query.go`.
4. 200+ lines of test code of `queryTask from `task_test.go to
   `task_query_test.go`.

This PR also rearrange methods positions of `searchTask` and
`queryTask`:
-  Putting the most important methods `PreExecute`, `Execute`, and
   `PosExecute` at the beginning of the file.
-  Moves interface methods `ID`, `SetID`, `Type`, `BeginTs`, etc.
   that nobody cares about to the bottom of the file.

See also: #16298

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-04-01 18:59:29 +08:00
XuanYang-cn a0bb758be5
Refine log in proxy searchTask (#16263)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-03-30 22:09:28 +08:00
zhenshan.cao 11cea5aad0
Refine proxy log (#16246)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2022-03-29 02:29:27 +08:00
congqixia 2c03287e79
Improve log level in proxy QueryTask (#16234)
Use warn instead of debug in error case

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-03-28 23:11:26 +08:00
Ten Thousand Leaves 40c703dacd
Support check index state in root coord, for bulk load feature. (#16198)
issue: #15604

/kind feature

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
2022-03-28 16:41:28 +08:00
xige-16 205c92e54b
Support insert string data (#15993)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2022-03-25 14:27:25 +08:00
Jiquan Long f8d9bc919d
Unify interface of vector index & scalar index. (#15959)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2022-03-21 14:23:24 +08:00
zhenshan.cao f3eeecf146
Reduce the number of metrics (#16030)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2022-03-15 21:51:21 +08:00
cai.zhang 2512dff261
Fix misuse of timerecord (#15868)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2022-03-04 15:45:56 +08:00
Jiquan Long f71651e294
Support column-based insert data in message stream (#15802)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2022-03-04 15:09:56 +08:00
Cai Yudong 57b97ccb9c
Let search fail as if one query_node return error result (#15855)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-03-04 10:43:56 +08:00
jaime 7a3a721380
Reconstruct mqstream module (#15784)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
2022-03-03 21:57:56 +08:00
congqixia 3f34bc1ab7
Ban DataType_String in CreateCollection (#15838)
Fix #15836
/kind enhancement

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-03-03 16:57:56 +08:00
朱亚光 27a7875a15
add array hashKeys empty check (#15796)
fix #15791 https://github.com/milvus-io/milvus/issues/15791
Signed-off-by: zhuyaguang <zhuyaguang1368@163.com>
2022-03-03 00:33:56 +08:00
cai.zhang d183748484
Add some prometheus metrics for proxy (#15582)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2022-03-02 16:23:55 +08:00
Filipe Caixeta dee1961b4d
Make SearchResults and QueryResults return collectionID (#15377)
* Make SearchResults and QueryResults return collectionID

Signed-off-by: Filipe Caixeta <filipecaixeta@gmail.com>

* add return collection name from QueryRequest and SearchRequest

Signed-off-by: Filipe Caixeta <filipecaixeta@gmail.com>

* remove comment

Signed-off-by: Filipe Caixeta <filipecaixeta@gmail.com>
2022-01-27 22:55:41 +08:00
Cai Yudong 6323907566
Use CommonConfig in GlobalParams for all components (#15106)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-01-10 19:03:35 +08:00
shaoyue 2e8dd74c7e
[skip e2e] Add comment for proxy task (#15089)
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2022-01-10 18:33:46 +08:00
Cai Yudong 7efb02a4c5
Use PulsarConfig in GlobalParams for all components (#15046)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-01-09 23:45:33 +08:00
guoxiangzhou 1807ba534d
[skip e2e] Modify log text according to the naming conventions (#14969)
Signed-off-by: guoxiangzhou <xiangzhou.guo@zilliz.com>
2022-01-07 18:41:23 +08:00
guoxiangzhou 8ec3c69447
[skip e2e] Modify log text according to the naming conventions (#14970)
Signed-off-by: guoxiangzhou <xiangzhou.guo@zilliz.com>
2022-01-07 18:39:22 +08:00
congqixia 6400263f3c
[skip e2e] Improve SearchTask log format (#14753)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-01-04 14:15:39 +08:00
Jiquan Long 77ef791b6e
[skip e2e] Add comment for minFloat32 (#14752)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2022-01-04 14:13:44 +08:00
Xiaofan 98e4ff33a8
Fix RocksDB Slow (#14614) 2021-12-30 20:08:15 +08:00
congqixia 7bb1d6267d
[skip e2e] Add comment for CreateAliasTask methods (#14539)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-29 22:40:27 +08:00
zhenshan.cao 32a5126705
Add the limitation of the traceable interval to timeTravel (#14498)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-12-29 21:29:45 +08:00
congqixia ffe44ae1ea
[skip e2e] Add comment for CreateAliasTask (#14463)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-28 22:22:46 +08:00
congqixia 307b07363b
[skip e2e] Add comment for IDs2Expr (#14352)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-28 09:48:15 +08:00
shaoyue 26ed17a905
[skip e2e] Add comment for AlterAliasTask (#14140)
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2021-12-24 13:33:45 +08:00
Xiaofan 24e2faf110
Fix has collection err (#14089)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-12-23 21:46:10 +08:00
Cai Yudong 891c202b73
Use GlobalParamTable for all components (#13885)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-12-23 18:39:11 +08:00
shaoyue e8ebd926e0
[skip e2e] Add comment for internal/proxy/task.go (#14031)
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2021-12-23 11:05:09 +08:00
edward.zeng 8eb4d9a2b4
[skip e2e] Add comment to proxy task (#14003)
Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
2021-12-22 20:29:29 +08:00
Jiquan Long bdb001b20d
Add log of query to record time spent in mq (#13526)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-12-22 10:11:02 +08:00
Jiquan Long 8a63dba149
Add consistency level field in collection meta (#13766)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-12-21 19:49:02 +08:00
xige-16 dc7fb594af
[skip e2e]Improve log for QueryNode spell (#13809)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-12-20 23:10:51 +08:00
shaoyue 22e0fc8701
[skip e2e] Add comment for DropAliasTask (#13626)
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2021-12-17 18:46:38 +08:00
zhenshan.cao bfdf6eb402
[skip e2e]Fix datarace in proxy (#13607)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-12-17 16:32:52 +08:00
Jiquan Long 00c9797d91
Add log of insert to record time spent in mq (#13527)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-12-16 22:27:42 +08:00
Jiquan Long cb51df5985
Add log of search to record time spent in mq (#13525)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-12-16 22:22:06 +08:00
Xiangyu Wang 405b3cd932
Use the same lint rules with golint in revive (#13324)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-12-14 15:31:07 +08:00
Cai Yudong b5d639a1ab
Use typeutil.ProxyRole instead of Params.RoleName in proxy (#13217)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-12-13 10:01:18 +08:00
bigsheeper 214f40b209
Add timeout ts for search and query (#12890)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-12-08 14:15:03 +08:00
dragondriver a2a1f9d08c
Disable multiple vector fields (#12691)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-12-06 10:03:34 +08:00
Cai Yudong 147fc41a67
Update proxy debug log (#12591)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-12-02 12:41:32 +08:00
dragondriver 1db1cf2104
Fix similarity correlation (#12511)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-12-01 15:26:02 +08:00
dragondriver 6d92b8499c
Revert #11901, Fix wrong jaccard distance (#12487)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-11-30 20:31:35 +08:00
Cai Yudong 74a4a4e15b
Fix golint warnings for proxy (#11895)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-29 12:25:17 +08:00
godchen 927f72d588
Add delete task channel stats interface (#12250)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-24 16:01:17 +08:00
shaoyue b231965e15
[skip ci] Add comments for exported funcs in internal/proxy/task.go (#11980)
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2021-11-17 16:13:17 +08:00
dragondriver 8c951217ee
Fix wrong distances caused by metric type (#11901)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-11-16 19:11:10 +08:00
yukun 27d711e5d2
Insert task hash by primarykeys (#11819)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-11-16 14:21:27 +08:00
XuanYang-cn 99894e451d
[skip ci]Update license for proxy task (#11611)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-11-10 23:55:48 +08:00
Cai Yudong e27283abbf
Update query reduce log (#11402)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-08 16:07:34 +08:00
Cai Yudong d32c77e99b
Update search reduce log (#11400)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-08 16:03:30 +08:00
godchen 88c9067873
Add hashvalue warning (#10668)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-05 14:20:55 +08:00
bigsheeper c99d1a56bf
Refactor proxy ticker to fix guarantee_time not work (#11248)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-11-05 09:14:02 +08:00
Cai Yudong 0fac38000c
Correct empty retrieve result handling (#11219)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-04 18:08:32 +08:00
godchen a0a3a889e7
Add common endian for global use (#11092)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-02 18:16:32 +08:00
Cai Yudong 70188990dc
Remove primary key duplicated query result on proxy (#10967)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-01 10:27:56 +08:00
Cai Yudong da0cb4a702
Use primary key only to check search result duplicate (#10949)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-01 10:06:03 +08:00
Cai Yudong 0049837dc4
Add utils API AppendFieldData (#10910)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-29 18:06:43 +08:00
Cai Yudong 5ad4cdda25
Clean search result duplicates removal debug log (#10769)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-27 20:02:26 +08:00
Cai Yudong 24f9411249
Optimize queryTask PostExecute (#10739)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-27 17:34:35 +08:00
Cai Yudong c51155a542
Optimize decodeSearchResults (#10728)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-27 14:10:27 +08:00
cai.zhang 3734ff49ac
Add default value for the parameter roundDeciaml (#9626)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-26 18:24:23 +08:00
zhenshan.cao bb08df28f3
Fix golint error in proxy (#10620)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-10-26 10:38:41 +08:00
zhenshan.cao 4b0fd28de7
Fix golint error in proxy (#10621)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-10-25 23:42:29 +08:00
godchen daaa9428ea
Fix delete msg hash error (#10599)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-25 22:20:20 +08:00
godchen d2e0943f21
Fix delete node flush error (#10549)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-25 18:49:20 +08:00
cai.zhang c3cce20413
Reset the msgstream threshold to PulsarMaxMessageSize (#10186)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-25 17:57:14 +08:00
Cai Yudong 880e375b00
[skip ci] Remove comments (#10541)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-25 15:25:12 +08:00
Cai Yudong f6802589eb
Optimize proxy reduce code readability (#10537)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-25 14:29:12 +08:00
zhenshan.cao 3af852eafb
Fix golint error in proxy (#10488)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-10-23 23:17:11 +08:00
zhenshan.cao 51d82fc71d
Fix golint error in proxy (#10487)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-10-23 18:25:37 +08:00
zhenshan.cao 169359448f
Fix golint error in proxy (#10486)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-10-23 18:23:44 +08:00
zhenshan.cao 43ef5d5eb9
Fix golint error in proxy (#10485)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-10-23 10:53:12 +08:00
Cai Yudong 824005115a
Remove duplicated search results in proxy (#10355)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-21 19:52:28 +08:00
Cai Yudong b099179ac0
Optimize proxy reduce search result data (#10327)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-21 10:46:36 +08:00
Cai Yudong b40513b211
Use timerecord to calculate time span (#10287)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-20 17:56:38 +08:00
godchen 24a6fc096b
Update query node bloom filter (#10109)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-18 20:08:42 +08:00
Cai Yudong dc0269cf4c
Optimize proxy getChannels (#9964)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-15 20:37:04 +08:00
yukun 92815f4542
Change timestamp to timestamps in internalproto.DeleteRequest (#9802)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-10-14 14:48:34 +08:00
dragondriver 8f5bf46705
Fix golint warning of plan_parser.go (#9827)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-10-13 20:30:32 +08:00
Cai Yudong 84e568ee32
Support Delete in datanode (#8505)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-11 16:31:44 +08:00
Cai Yudong bd3a8ed3cf
Support delete in proxy (#9588)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-11 07:48:55 +08:00
Xiangyu Wang 75716e0deb
Update partition name validation in DeleteTask (#9560)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-10-09 22:50:39 +08:00
dragondriver 302ca04d6c
Describe collection by collection ID (#9471)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-10-09 16:10:56 +08:00
elfisworking d4232f88a2
For search funtion adding a round_decimal paramter to precision control (#8574)
Signed-off-by: elfisworking <zymustb@126.com>
2021-10-08 17:39:55 +08:00
congqixia 827a18a7c1
Fix Assigner typo (#9075)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-02 18:43:56 +08:00
godchen 4bfa85eda3
Fix searchTask result nil (#8844)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-09-29 15:48:00 +08:00
zhenshan.cao a662c62880
Fix golint error of segment.go in proxy package (#8629)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-28 23:06:15 +08:00
dragondriver 6065bb50c4
Fix golint warning of funcutil (#8652)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-27 23:18:02 +08:00
zhenshan.cao b71bffe26f
Replace ChannelID with ShardName in DML Request (#8539)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-27 10:01:59 +08:00
Cai Yudong 3938d68034
Optimize proxy query execute (#8479)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-25 00:21:57 +08:00
Cai Yudong ee3eaa2966
Rename CreateQueryExprPlan to CreateExprPlan (#8438)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-24 10:27:54 +08:00
XuanYang-cn 4ee8275b88
Fix master compile error (#8333)
Resolves: #8336

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-22 20:31:54 +08:00
cai.zhang 729d409a32
Add trace log for search (#8302)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-22 19:36:00 +08:00
cai.zhang 79b7dcc75a
Add trace log for insert (#8301)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-22 19:33:54 +08:00
dragondriver b2e8ba7b33
Fix reduce algorithm in proxy search task (#8206)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-22 10:15:54 +08:00
congqixia bdfb8768d4
Enable gosec (#8202)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-18 14:45:50 +08:00
Yusup ccb57ba4b2
add collection alias (#7255)
Signed-off-by: Yusup <yusup@lsgrep.com>
2021-09-18 11:13:51 +08:00
yukun 46871fcaec
Remove unused code in queryTask (#8077)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-09-17 21:57:58 +08:00
congqixia 4fe22bcaaa
Fix query task panicking (#8060)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-16 20:03:50 +08:00
dragondriver 5f3b961502
Add test case for delete task (#7939)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-15 14:04:54 +08:00
Xiaofan d0667b58d7
Change Error Msg When dimension of vector field not exist (#7931)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-09-15 10:01:30 +08:00
dragondriver 2382be82a5
Add test case for the workflow of insert task (#7912)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-14 19:07:48 +08:00
dragondriver ec776a30dc
Add test case for the workflow of query task (#7886)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-14 16:19:08 +08:00
dragondriver f122e93383
Proxy ut cover case that search task process the fields data (#7874)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-14 14:09:05 +08:00
zhenshan.cao e5e4b24954
Fix bug: describe collection return wrong shard number (#7841)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-14 11:59:47 +08:00
dragondriver bcf9b4e240
Coverage error case of searchTask.PreExecute (#7826)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-14 10:24:00 +08:00
dragondriver 8d239b6473
Add test cases for search task (#7796)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-13 17:12:19 +08:00
Xiaofan 619c4393f3
Refine logs in proxy search path(#7357) (#7753)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-09-12 17:54:01 +08:00
dragondriver 5a3fc37584
Add test cases for create collection (#7759)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-11 18:06:02 +08:00
dragondriver a872a4357c
Add more test cases for proxy implementation (#7685)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-11 11:36:22 +08:00
dragondriver 596357dc85
Add more data definition test cases (#7623)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-09 19:02:08 +08:00
zhenshan.cao b0524adbd8
Support specified shard number when create collection (#7482)
Add shards_num to CollectionInfo

Modify dmlChannelNum config

Compatible with old meta

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-08 15:00:00 +08:00
dragondriver 42b687bf48
Add unittest for task scheduler (#7508)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-06 20:49:04 +08:00
yukun 94272bba87
Support query by expression (#7386)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-09-03 17:12:55 +08:00
groot 8701c477e2
Add delete api into proto (#7304)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-08-26 12:15:52 +08:00
Cai Yudong 0ab70271a6
correct empty search result handle (#7244)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-24 11:13:52 +08:00
Cai Yudong 8405d90f5e
proxy add illegal check for search result (#7227)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-23 17:03:51 +08:00
yukun 671b2737d2
Remove RetrieveRequest and RetrieveTask (#6848)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-08-16 17:06:10 +08:00
Cai Yudong e771bda92f
optimize retrieve output vector code structure (#7102)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-14 11:18:10 +08:00
xige-16 87c5a49d9a
Refactor showCollection/showPartition to get load state in memory (#6935)
* refactor showCollection/showPartition to get load state in memory

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* update proto

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* update proto

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* update milvus.proto

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* add show result log to debug

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* fix wrong err message

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* update pymilvus-orm version

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* fix repeated load error

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* update proto

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* fix status nil error

Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-08-02 22:39:25 +08:00
Cai Yudong fe50f97726
Use id to tell search result validation in proxy reduce stage (#6905)
* use id to tell search result validation

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* enable test_search_binary_hamming_flat_index

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* code optimize

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fix merge retrieve result issue

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-02 10:25:49 +08:00
cai.zhang d51fec6678
Enhance log when create index failed (#6871)
* Enhance log when create index failed

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix bug for repeatedly drop index

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>
2021-07-29 14:47:22 +08:00
zhenshan.cao 8a1a841011
FixBug: Incorrect handling of time synchronization (#6814)
* FixBug: proxy send wrong sync timetick and DataCoord did not filter channel

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-07-27 14:34:48 +08:00
dragondriver 3cc8ee298e
Filter NaN when reducing search results (#6806)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-27 10:19:21 +08:00
zhenshan.cao 2962d31a5f
Fixbug: segment allocate but return value incorrect (#6788)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-07-24 20:49:20 +08:00
dragondriver cf8e9d52b1
Reduce the log of proxy (#6766)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-23 20:33:34 +08:00
dragondriver 67c1fdd2c0
Show/Describe collections/partitions with created timestamp (#6700)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-21 18:00:14 +08:00
Cai Yudong cbb4052fdb
Support search and query output fields using wildcard (#6671)
* update wildcard polocy for search and query

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* mark xfail cases

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* mark xfail cases

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* optimize debug log

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fix static-check

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-07-21 14:52:12 +08:00
dragondriver 2d9361e0ba
Fix bug: remove duplicated primary field id when retrieve entities (#6577)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-17 10:53:30 +08:00
Cai Yudong a992dcf6a8
Support query return vector output field (#6570)
* improve code readibility

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* add offset in RetrieveResults

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* add VectorFieldInfo into Segment struct

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* add new interface for query vector

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* update load vector field logic

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* update load vector field logic

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fill in field name in query result

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* add FieldId into FieldData

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* add fillVectorOutputFieldsIfNeeded

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* update data_codec_test.go

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* add DeserializeFieldData

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* realize query return vector output field

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fix static-check

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* disable query vector case

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-07-16 17:19:55 +08:00
dragondriver 5016e509be
Support wildcard match on search/query output fields (#6510)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-14 18:51:54 +08:00
Cai Yudong 1c29b42434
change output_fields to out_fields_id for RetrieveRequest (#6506)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-07-14 13:11:54 +08:00
dragondriver d896e3119e
Fix 6419, check if num_rows is greater than zero in proxy (#6439)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-13 16:33:55 +08:00
dragondriver bd317a5461
Check if field data is empty (#6404)
* Check if field data is empty

Signed-off-by: dragondriver <jiquan.long@zilliz.com>

* FixBug: fast fail when output_fields contain fields that are not in schema

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>

Co-authored-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-07-11 19:39:52 +08:00
neza2017 8b89744c6b
search with exp (#6409)
* process float vector and binary vector field
on the search result

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* add more debug info on etcd

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* add debug info when grpc failed

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-07-10 10:21:52 +08:00
dragondriver 166548447b
Fix 6249, use more clear error message (#6316)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-06 14:40:04 +08:00
zhenshan.cao ff4c6c7ff4
Fix travel timestamp and guarantee timestamp (#6234)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-06-30 21:02:13 +08:00
yukun 95aa3c85b6
Add index_name check for drop_index (#6217)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-06-30 17:56:12 +08:00
yukun b87baa108a
Add topks in searchResult (#6168)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-06-28 15:28:11 +08:00
dragondriver d3c503f3aa
Calculate the real topk in proxy (#6132)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-06-28 14:30:14 +08:00
yukun ae66446f16
Fix issue-5992 (#6158)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-06-28 12:16:13 +08:00
yukun effcbc7cb3
Fix issue-6143 (#6145)
* Fix issue-6143

Signed-off-by: kun yu <kun.yu@zilliz.com>

* Return error when output_fields contains vector field

Signed-off-by: kun yu <kun.yu@zilliz.com>

* Fix when output_fields contain primarykey

Signed-off-by: kun yu <kun.yu@zilliz.com>

* Add primarykey

Signed-off-by: kun yu <kun.yu@zilliz.com>
2021-06-28 10:12:13 +08:00
xige-16 ca4cba152c
return loaded collection when ShowCollectionsType_InMemory (#6149)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-06-27 12:10:08 +08:00
yukun eb818d05ab
Remove vector fields from output fields (#6112)
* Remove vector fields from output fields

Signed-off-by: fishpenguin <kun.yu@zilliz.com>

* Add empty_collection error_code

Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-06-25 16:52:11 +08:00
yukun 9b549e0fa4
Add primaryKey to output fields (#6094)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-06-24 21:08:14 +08:00
sunby 46f86a0354
Return sealed segments when calling flush (#6011)
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-06-23 16:56:11 +08:00
dragondriver a493151f70
Fix #5951 (#6010)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-06-23 12:06:10 +08:00
yukun 792dba4ae3
Fix id field insert failed when auto_id is true (#5984)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-06-22 18:46:04 +08:00
zhenshan.cao 0f05622c09
Modify error msg when index is not created (#5978)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-06-22 18:04:07 +08:00
xige-16 2af1c27811
Rename queryservice to querycoordinator (#5931)
* Rename queryservice to querycoordinator

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* fix param table

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* code format

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* fix unittest

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* service to coordinator

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* code format

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* set querycoord in ci

Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-06-22 16:44:09 +08:00
dragondriver fd57554d32
Add index params check in proxy (#5958)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-06-22 15:28:04 +08:00
Cai Yudong 2926a78968
Rename proxynode to proxy (#5961)
* rename package name from proxynode to proxy

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* move distributed/proxynode to distributed/proxy

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* move internal/proxynode to internal/proxy

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename proxynode to proxy

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-06-22 14:40:07 +08:00
quicksilver 7fe061b846 Raneme init_devcontainer.sh to devcontainer.sh
Signed-off-by: quicksilver <zhifeng.zhang@zilliz.com>
2021-01-15 14:38:36 +08:00
neza2017 56ab2bda2d Update proto:add partition id
Signed-off-by: neza2017 <yefu.chen@zilliz.com>
2021-01-15 11:53:22 +08:00
zhenshan.cao 63b21321d6 Refactor indexservice and update doc
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-01-15 13:50:27 +08:00
cai.zhang 3d885742ee Reopen ruleguard and format code
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-01-13 13:36:27 +08:00
bigsheeper 2d2af1505a Improve mutex usage in query node
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-01-12 18:03:24 +08:00
GuoRentong f3d2afa4f4 Update doc:detailed interface definition
Signed-off-by: GuoRentong <rentong.guo@zilliz.com>
2021-01-11 18:35:54 +08:00
quicksilver a6690dbc99 Fix syntax error: Bad fd number
Signed-off-by: quicksilver <zhifeng.zhang@zilliz.com>
2021-01-11 15:25:19 +08:00
yukun 18cfd31d40 Fix Load and Remove with prefix
Signed-off-by: yukun <kun.yu@zilliz.com>
2021-01-11 15:17:06 +08:00
bigsheeper 4fad3b189c Fix search without insertion, improve nil hits behavior (#622)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-01-09 17:58:18 +08:00
xige-16 f4566731fc Fix search error in regression test
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-01-09 09:47:22 +08:00
sunby 5dfe9448ae Modify test_index
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-01-08 16:00:16 +08:00
GuoRentong 82ad488555 Update doc: rocksmq
Signed-off-by: GuoRentong <rentong.guo@zilliz.com>
2021-01-08 18:37:24 +08:00
dragondriver 018466a256 Avoid crash when index parameters are invalid
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-01-08 17:45:57 +08:00
XuanYang-cn 65089ea362 Fix flush sync test bug and remove unecessary lock in meta_table
Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>
2021-01-08 17:20:59 +08:00
GuoRentong c4599e26de Update doc: node api
Signed-off-by: GuoRentong <rentong.guo@zilliz.com>
2021-01-08 16:59:19 +08:00
bigsheeper e13822043d Fix search test when partition not exists, add binary vector search validation
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-01-08 16:41:27 +08:00
godchen fa73f17f94 Add opentracing doc
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-01-08 15:32:38 +08:00
dragondriver ced56c84f8 Add support to build binary vector index
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-01-07 14:56:17 +08:00
godchen 8f1f118b26 Add query opentracing
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-01-07 14:24:35 +08:00
bigsheeper a1e2ff3c26 Add gcNode to write node
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-01-06 16:44:12 +08:00
neza2017 4015d7245d Merge operation
Signed-off-by: neza2017 <yefu.chen@zilliz.com>
2021-01-06 14:45:50 +08:00
zhenshan.cao b06e01f523 Initmate querynode collection manager
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-01-06 11:31:36 +08:00
godchen 1c87faf8b3 Add insert request opentracing
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-01-06 11:17:35 +08:00