milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix golint error in proxy (#10488) 

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
pull/10517/head
zhenshan.cao 2021-10-23 23:17:11 +08:00 committed by GitHub
parent f08ed354df
commit 3af852eafb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/proxy/task.go
View File

@ -1193,11 +1193,11 @@ func (cct *createCollectionTask) PreExecute(ctx context.Context) error {
return errors.New("dimension is not defined in field type params, check type param `dim` for vector field")
}
if field.DataType == schemapb.DataType_FloatVector {
if err := ValidateDimension(dim, false); err != nil {
if err := validateDimension(dim, false); err != nil {
return err
}
} else {
if err := ValidateDimension(dim, true); err != nil {
if err := validateDimension(dim, true); err != nil {
return err
}
}

2
internal/proxy/validate_util.go
View File

@ -140,7 +140,7 @@ func validateFieldName(fieldName string) error {
return nil
}
func ValidateDimension(dim int64, isBinary bool) error {
func validateDimension(dim int64, isBinary bool) error {
if dim <= 0 || dim > Params.MaxDimension {
return fmt.Errorf("invalid dimension: %d. should be in range 1 ~ %d", dim, Params.MaxDimension)
}

14
internal/proxy/validate_util_test.go
View File

@ -96,15 +96,15 @@ func TestValidateFieldName(t *testing.T) {
}
func TestValidateDimension(t *testing.T) {
assert.Nil(t, ValidateDimension(1, false))
assert.Nil(t, ValidateDimension(Params.MaxDimension, false))
assert.Nil(t, ValidateDimension(8, true))
assert.Nil(t, ValidateDimension(Params.MaxDimension, true))
assert.Nil(t, validateDimension(1, false))
assert.Nil(t, validateDimension(Params.MaxDimension, false))
assert.Nil(t, validateDimension(8, true))
assert.Nil(t, validateDimension(Params.MaxDimension, true))
// invalid dim
assert.NotNil(t, ValidateDimension(-1, false))
assert.NotNil(t, ValidateDimension(Params.MaxDimension+1, false))
assert.NotNil(t, ValidateDimension(9, true))
assert.NotNil(t, validateDimension(-1, false))
assert.NotNil(t, validateDimension(Params.MaxDimension+1, false))
assert.NotNil(t, validateDimension(9, true))
}
func TestValidateVectorFieldMetricType(t *testing.T) {