11674e830f
spell
2020-07-10 13:13:45 -07:00
d0d3973a13
restrict apparmor security opt to docker
2020-07-09 12:58:01 -07:00
7367c72a3e
Merge pull request #8490 from zhijianli88/cleanup
...
A few cleanup
2020-07-08 14:52:28 -04:00
7c2cac612d
Fix bug in FailFastError and add unit test
...
Since FailFastError was just another `error`, all errors were technically `FailFastErrors`.
This code makes `FailFastError` a struct which implements the error interface, so that now errors can be distinctly identified as `FailFastError`'
Also added a unit test to prove that this works now.
2020-06-26 11:58:34 -07:00
7d79241ea5
Merge pull request #8565 from priyawadhwa/update-alternatives
...
Check for iptables file before determining container is running
2020-06-26 11:29:52 -07:00
e32e2135ed
review comments
2020-06-25 19:39:59 -07:00
903686172d
Check for iptables file before determining container is running
2020-06-25 17:58:22 -07:00
9e95435e00
Add --cni flag, fix --network-plugin=kubenet
2020-06-23 20:10:25 -07:00
e91e11eeba
address review comments
2020-06-17 18:32:11 -07:00
29e01d5dcb
fix comment
2020-06-17 15:17:45 -07:00
dacd980fe7
add err type for start too
2020-06-17 15:15:23 -07:00
ca2d0f97ec
move advice to its own file
2020-06-17 15:07:17 -07:00
543b0b5bfa
add post mortem logs when container not running
2020-06-17 13:27:17 -07:00
736f5219e0
add error type for check running
2020-06-17 12:13:12 -07:00
56b5524c8e
address review comments
2020-06-16 14:57:19 -07:00
4caf260279
add cpu count limit error type for kic drivers
2020-06-16 13:21:56 -07:00
24c9ce079d
cleanup TempDir properly
...
a TempDir is like /tmp/minipath255070191/.minikube
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-16 09:34:25 +08:00
6ef48499b4
Code review comments
2020-06-12 11:00:46 -07:00
b750ab4964
fix lint
2020-06-11 13:00:46 -07:00
330224f36a
Warn user to restart daemon if context deadline is exceeded
2020-06-11 12:50:11 -07:00
0ec839186d
Change glog.Errorf to glog.Infof so that we don't get an ugly log to stdout
2020-06-11 11:14:04 -07:00
15088526cd
clean up comments
2020-06-04 11:05:52 -07:00
7dfea631d4
Refactor downloading kic base image
2020-06-04 10:48:38 -07:00
488e2003f4
fix image digest
2020-05-29 12:19:59 -07:00
bc8c3faf86
add docker hub fall back image
2020-05-29 11:55:21 -07:00
14937e4677
Never use docker inspect, always provide the type
...
Should avoid errors like: map has no entry for key "State"
When inspecting a volume, rather than a container or image
2020-05-21 17:20:53 +02:00
afab7c87c6
Merge pull request #7959 from afbjorklund/podman-prompt
...
Use noninteractive sudo when running podman
2020-05-11 21:02:22 +00:00
d2ae2b35a0
Merge pull request #8057 from afbjorklund/podman-tar
...
Don't run the extraction tar container for podman
2020-05-11 19:22:48 +00:00
6b97ee8ee2
Merge pull request #8001 from afbjorklund/podman-start
...
podman: Wrap the start command with cgroup manager too
2020-05-11 17:59:39 +00:00
c578a7aa1e
Add a PointToHost function for podman as well
...
And add an active variable, similiar to docker
2020-05-10 23:07:12 +02:00
7e3da0f8b0
Merge pull request #8017 from elegos/podman-volumes-extract-tarball-to-volume
...
Podman: disable selinux labels when extracting the tarball (permissions error)
2020-05-09 21:35:43 +00:00
cac41495cf
Don't run the extraction tar container for podman
...
The preloaded images will be extracted anyway, using ssh.
But if creating them on the volume before the container is
booted, means that /var will not be fully copied over to it.
And without /var/lib/dpkg and others, kicbase will not boot.
So skip the parallel extraction for podman, do it afterwards.
Probably shouldn't mount all of /var, but just a sub-set...
2020-05-09 18:36:56 +02:00
46025eccf5
Use the runCmd wrapper for start to not miss error
2020-05-09 14:07:18 +02:00
ac01e92012
Add comment about why podman looks at runtime.GOOS
2020-05-09 14:05:57 +02:00
a7a5148ff6
Don't add cgroup manager param for podman-remote
...
Since it doesn't work for either "run" or "start"
Error: unknown flag: --cgroup-manager
2020-05-09 14:04:04 +02:00
85fae62d4a
Wrap the start command with cgroup manager too
...
When running with podman, to match the run cmd
2020-05-09 14:04:04 +02:00
934ad06a82
Use noninteractive sudo when running podman
...
To avoid asking for a password in the middle of minikube commands.
The setup process is supposed to involve adding podman to sudoers...
2020-05-09 13:23:46 +02:00
ba267702af
Merge branch 'master' of https://github.com/kubernetes/minikube into embed-certs
2020-05-08 12:38:02 -07:00
436cee2d84
Fix minikube/kubernetes capitalization, make short help consistent
2020-05-07 14:12:10 -07:00
163ab88408
Restart kubelet in a function that is called on soft start
2020-05-07 13:22:09 -07:00
a353d564dd
Add comments
2020-05-07 13:03:07 -07:00
c037a97392
Restart kubeadm on soft `minikube start`
...
This should resolve a race condition in which the expected node IP and the ip passed into kubelet are different.
This should fix the embed-certs integration test which has been flaky for a while.
2020-05-07 12:59:55 -07:00
9c43c47b06
Podman: disable selinux labels when extracting the tarball to prevent permission errors
2020-05-07 02:09:09 +02:00
7914d057d1
fall back to github if gcr.io is not available
2020-05-04 13:12:50 -07:00
6eeb929b3d
Merge pull request #7962 from afbjorklund/podman-gateway
...
Get the gateway by inspecting container network
2020-05-04 20:05:56 +00:00
1da92a1c84
Merge pull request #7961 from afbjorklund/podman-preload
...
Use the correct binary for unpacking the preload
2020-05-04 20:04:19 +00:00
e0685c8f5d
Merge pull request #7984 from medyagh/detect_windows_container
...
Detect windows container and exit with instructions
2020-05-04 20:01:17 +00:00
cc6506d2c9
Remove logging statement from containerGateway
2020-05-03 09:42:32 +02:00
bcecda8e20
add comment for error type
2020-05-02 18:48:52 -07:00
2102a20605
wrap errors
2020-05-02 18:38:23 -07:00
Medya Gh
Sharif Elgamal
priyawadhwa
Thomas Stromberg
Li Zhijian
Anders F Björklund
Medya Ghazizadeh
Giacomo Mr. Wolf Furlan