Commit Graph

513 Commits (f92015df9be60e83d3eb122471db30612c3bf04b)

Author SHA1 Message Date
Medya Gh 7619a5075a fix logging 2020-03-23 21:01:12 -07:00
Medya Gh 36f3f657af force stop if cant stop for none 2020-03-23 21:01:12 -07:00
Medya Gh 545348341a for none let it stop all containers 2020-03-23 21:01:12 -07:00
Medya Gh 47c8e9c87b dont return on error kic sto 2020-03-23 21:01:12 -07:00
Medya Gh 5f90a319bd stop k8s in kic and none 2020-03-23 21:01:12 -07:00
Medya Gh fae3e34319 add stop force stop 2020-03-23 20:59:21 -07:00
Medya Gh 298be78e5f remove duplicate code 2020-03-23 20:59:21 -07:00
Medya Gh beec3b1ce1 stop kubelet on docker stop 2020-03-23 20:59:21 -07:00
Priya Wadhwa abf35cfbc1 Upgrade podman and add libglib2.0-0 to kicbase image
The `TestOffline/group/crio` integration test was failing with the error:

```
crio load image: sudo podman load -i /var/lib/minikube/images/storage-provisioner_v1.8.1: exit status 125
```

I tried SSH'ing into minikube and running the command myself, and got the error:

```
Error: could not get runtime: please update to v2.0.1 or later: outdated conmon version
```

I then tried updating conmon, but got the error:

```
conmon: error while loading shared libraries: libglib-2.0.so.0: cannot open shared object file: No such file or directory
```

I then tried adding the libglib2.0-0 library to the kic base image and upgrading podman, which seems to have resolved the issue.
2020-03-23 17:41:06 -07:00
Priya Wadhwa bfe8aee3b5 Pass in container runtime to preload tarball name
This way we don't have to individually check if we support a container runtime
2020-03-23 12:29:49 -07:00
Priya Wadhwa 0e5974367f rebased on master' 2020-03-23 10:59:02 -07:00
vikkyomkar f54af5d684 function name HostPortBinding changed to ForwardedPort 2020-03-14 21:28:12 +05:30
Priya Wadhwa 89c6c72adb Skip preload if not running on amd64
Also make sure that preload is available before attempting to run preload.
2020-03-13 16:24:28 -07:00
Thomas Stromberg 895967235a Improve error message output 2020-03-13 16:18:14 -07:00
Thomas Stromberg 196a8d7b82 Delete: output underlying status failure, refactor wordy code 2020-03-13 15:51:03 -07:00
Medya Gh 70c9304724 code review comments 2020-03-13 10:37:29 -07:00
Medya Gh 99ba89c2dd ip 2020-03-12 16:01:49 -07:00
Medya Gh 084da0c46a fix maybe 2020-03-12 15:31:38 -07:00
Thomas Stromberg 43ce409e79 Extra debugging for preload generation process 2020-03-11 13:09:55 -07:00
Medya Gh b5681d52c5 lint 2020-03-10 18:45:56 -07:00
Medya Gh 9ff0dc0ebc pass api server port to kic create container 2020-03-10 18:33:59 -07:00
Thomas Stromberg 9ac1ad2a7e Merge master 2020-03-06 16:13:54 -08:00
Thomas Stromberg e027dfc4d2 More unused code cleanup 2020-03-06 15:57:12 -08:00
Thomas Stromberg 3fee641a13 Remove remaining PointToHostDockerDaemon calls 2020-03-06 15:15:05 -08:00
Medya Gh a58a9f0176 tweak 2020-03-06 15:13:56 -08:00
Medya Gh cb14468b44 english 2020-03-06 15:11:42 -08:00
Medya Gh cdb8f9c3f6 make sure container is running after create 2020-03-06 15:08:39 -08:00
Thomas Stromberg 6f46393123 Remove blank line 2020-03-06 12:15:58 -08:00
Thomas Stromberg 120dce7b56 Remove extraneous calls to oci.PointToHostDockerDaemon 2020-03-06 12:13:51 -08:00
Medya Gh 38ccb88e3f address code review 2020-03-06 10:25:48 -08:00
Medya Gh 1c37fc5505 lint 2020-03-05 22:45:38 -08:00
Medya Gh 0335fb1ad7 change names 2020-03-05 22:38:47 -08:00
Medya Gh 2a37317a72 improve comment 2020-03-05 22:34:10 -08:00
Medya Gh 1e8dd94a77 fix logic 2020-03-05 22:31:44 -08:00
Medya Gh e1f6820335 fix already in use 2020-03-05 16:42:56 -08:00
Thomas Stromberg 1f7ae5b35b Merge to master 2020-03-05 09:57:46 -08:00
Thomas Stromberg a1ebcbd031 Merge conflicts 2020-03-04 18:01:41 -08:00
Sharif Elgamal 0ff12cafac Merge branch 'master' of github.com:kubernetes/minikube into machinename 2020-03-04 16:37:54 -08:00
Sharif Elgamal a3e000d850 addressing comments 2020-03-04 14:09:15 -08:00
Medya Gh f40c5a7b30 move funcs arround 2020-03-04 12:50:01 -08:00
Medya Gh db5903d3ed lint 2020-03-04 10:40:32 -08:00
Medya Gh 54df61d677 point to host daemon more places 2020-03-04 10:37:10 -08:00
Medya Gh 6a62046e62 add warning and point to right docker 2020-03-04 10:22:20 -08:00
Sharif Elgamal 28e030c728
Merge branch 'master' of github.com:kubernetes/minikube into machinename 2020-03-03 12:16:47 -08:00
Sharif Elgamal 31a42ce672
address comments 2020-03-02 17:30:08 -08:00
Priya Wadhwa 05a46f6526 remove unnecessary PreloadedVolume 2020-03-02 16:17:35 -08:00
Sharif Elgamal 4cd3ef81a5
more changes 2020-03-02 15:21:37 -08:00
Priya Wadhwa 481010d8dc added overlay2 to preloaded images tarball name 2020-03-02 14:10:41 -08:00
Priya Wadhwa d6e94c1ee4 remove unused functions 2020-03-02 13:54:35 -08:00
Priya Wadhwa 474561d082 remove unused functions 2020-03-02 13:48:18 -08:00
Priya Wadhwa 697359b4f3 Fixed lint 2020-03-02 13:37:22 -08:00
Priya Wadhwa 6b0e942e7e Rebased on master 2020-03-02 13:33:27 -08:00
Medya Ghazizadeh 3cf2c9bbe3
Merge pull request #6807 from medyagh/delete_hang
warn about "stuck docker"  in minikube delete
2020-02-26 14:32:18 -08:00
Medya Gh 8d0c41392b continue instead of nest 2020-02-26 13:50:42 -08:00
Medya Gh 4709af55df resolve review comments 2020-02-26 12:44:25 -08:00
Medya Gh e8c85543f7 limit time waiting for delete 2020-02-26 10:57:46 -08:00
Medya Gh 6651e0b5a5 docker podman sysinfo 2020-02-26 09:15:25 -08:00
Medya Gh f3c171eaa3 show info for docker damemon 2020-02-25 17:34:03 -08:00
Medya Gh e60b034c84 Add Daemon Info func to oci 2020-02-25 17:16:49 -08:00
Priya Wadhwa aefbf2cd18 Rebased on master 2020-02-24 13:41:06 -08:00
Medya Gh 5f8740a15e update kic sha 2020-02-22 15:41:12 -08:00
Medya Gh 988a1b983a fix sha format 2020-02-22 14:23:43 -08:00
Medya Gh 73c4c4c323 bump kic version to 7 2020-02-22 14:07:43 -08:00
Medya Gh 95402af363 bump kic version 2020-02-22 13:51:42 -08:00
Medya Gh 9b91ef7590 Add CIO-o runtime to kic drivers and improve kic image 2020-02-22 13:46:17 -08:00
Anders F Björklund fa9f7f9794 Add comments to avoid warnings from go lint 2020-02-22 16:12:42 +01:00
Priya Wadhwa 97bf128703 only use preloaded volumes for docker runtime 2020-02-21 12:53:24 -08:00
Priya Wadhwa 328466f1e1 Check if preloaded volume is attached before skipping binary transfer 2020-02-21 12:41:33 -08:00
Priya Wadhwa cc1a6f11f0 Delete volume if it isn't extracted properly so future runs don't try to use it 2020-02-21 12:13:34 -08:00
Priya Wadhwa c99bf76ee4 Add checksum verification 2020-02-21 12:03:31 -08:00
sayboras 4201bbcfe3 Address one simple linter error 2020-02-21 14:55:22 +11:00
Priya Wadhwa 86df9ffb2c Rebased on master 2020-02-20 16:20:54 -08:00
Priya Wadhwa dcbf242192 Add SHA as constant 2020-02-20 15:56:00 -08:00
Priya Wadhwa 94737b4a14 Add lz4 to kic base image and upgrade to v0.0.6 2020-02-20 15:53:09 -08:00
Priya Wadhwa 55dd40efc5 Debugging 2020-02-20 15:05:07 -08:00
Priya Wadhwa 5ac8520ab8 skip transferring binaries and transferring imagse if using preloaded volume 2020-02-20 14:59:43 -08:00
Priya Wadhwa b0f685c072 Move all preloading code into preload package 2020-02-20 14:43:24 -08:00
Medya Ghazizadeh 7fddd05bf5
Merge pull request #6630 from medyagh/mount_kic
add mount feature to kic drivers
2020-02-20 14:11:15 -08:00
Priya Wadhwa 19fa296625 Compress with lz4 2020-02-20 14:07:03 -08:00
Priya Wadhwa 0e88697f16 Delete container once it has finished executing 2020-02-20 10:06:15 -08:00
Priya Wadhwa 055e4bb618 Add run to docker command 2020-02-20 09:57:19 -08:00
Priya Wadhwa 335637f4a3 Name tarball by k8s version name 2020-02-20 09:42:04 -08:00
Priya Wadhwa b8bc461157 Rebased on master 2020-02-20 09:18:12 -08:00
Medya Gh 30a38e5a9d wrap error 2020-02-20 00:07:36 -08:00
Medya Gh 4fe9ca5f05 break done delete and prune into two funcs better error handling 2020-02-20 00:07:36 -08:00
Medya Gh e1ffa5fb0f return error instead of logging 2020-02-20 00:07:36 -08:00
Medya Gh 354ff6256d improve comments 2020-02-20 00:07:36 -08:00
Medya Gh 6c94880149 dont list empty ones 2020-02-20 00:07:36 -08:00
Medya Gh d84aa9f447 lint 2020-02-20 00:07:36 -08:00
Medya Gh b1d139c24b code review comments 2020-02-20 00:07:35 -08:00
Medya Gh efd4aabde4 clean up containers first then delete volume 2020-02-20 00:07:35 -08:00
Medya Gh b235255196 fix volume clean up 2020-02-20 00:07:35 -08:00
Priya Wadhwa bb11bc666b Create volume of preloaded images and mount it in 2020-02-19 23:02:36 -08:00
Medya Gh 597798395f lint 2020-02-19 22:01:45 -08:00
Medya Gh 3a7041c3b2 add logging 2020-02-19 22:01:45 -08:00
Medya Gh d548eabdc6 added kic mount 2020-02-19 22:01:45 -08:00
Medya Gh 1ee08c7517 add funcs to get routable host ip from inside container 2020-02-19 22:01:45 -08:00
Priya Wadhwa d506aa18b4 Download preloaded images tarball with --download-only flag 2020-02-19 21:53:44 -08:00
Medya Gh 1da0a370ff code review comments 2020-02-17 10:55:53 -08:00
Medya Gh 3ce0164281 add logging for prune 2020-02-16 11:54:56 -08:00
Medya Gh a007c0790c Delete volumes created by kic 2020-02-14 01:39:16 -08:00
Medya Gh a4ee4186bd create docker volumes explictily with a label 2020-02-14 01:01:53 -08:00
Medya Ghazizadeh 4c6b435f68
revert docker volume host path (#6616) 2020-02-13 10:57:23 -07:00
Medya Ghazizadeh 398c7ef00b
Add podman driver (#6515) 2020-02-12 19:11:44 -07:00
tstromberg 97f926eeb1 Use vmpath constants where possible 2020-02-07 13:06:00 -08:00
Medya Gh 4b9d15a34c point to host docker 2020-02-04 16:09:43 -08:00
Medya Gh c86b20ade2 add option to exec runner to point to host docker daemon 2020-02-04 15:33:04 -08:00
Medya Gh 6c95a28c10 remove default crictl setting 2020-02-03 23:25:55 -08:00
Medya Gh e231e7ae96 rever dockefile changes 2020-02-03 22:32:08 -08:00
Medya Gh a2f2df9f81 add options to docker service for kic 2020-02-03 20:21:41 -08:00
Thomas Strömberg 901cb520b9
Merge pull request #6452 from tstromberg/none-paused
Fix none driver bugs with "pause"
2020-02-03 16:16:34 -08:00
Medya Ghazizadeh 3dd5495d2f
trim kic base image (#6478) 2020-02-03 16:31:52 -07:00
tstromberg 4124fbdb69 Consider a paused apiserver to be controlled by a running host 2020-02-03 14:20:57 -08:00
Thomas Stromberg 1176aa468f More status logging 2020-01-31 19:00:59 -08:00
Thomas Stromberg cee9448fa0 Make none.GetState more intelligent to fix stop issues 2020-01-31 18:54:27 -08:00
Thomas Stromberg 7f0e83508a Add more logging 2020-01-31 18:44:00 -08:00
Thomas Stromberg dd4ad10b83 Improve handling of paused none clusters. 2020-01-31 16:23:25 -08:00
Medya Gh 0e5059ddd0 log warning if docker is stuck 2020-01-30 21:36:56 -08:00
Medya Gh a6ec05e35a unexport noderolekey 2020-01-30 21:05:51 -08:00
Medya Gh 968fe86869 unexport more funcs 2020-01-30 21:01:27 -08:00
Medya Gh 006c781fbc remove unused kic code 2020-01-30 20:44:32 -08:00
Medya Gh 23e125649d rename createConfig 2020-01-30 18:13:11 -08:00
Medya Gh b20322a8c2 rename funcs 2020-01-30 18:12:04 -08:00
Medya Gh 5b055d7ff8 add comment 2020-01-30 16:57:53 -08:00
Medya Gh 58b637b05f delete all cleans up stale kic profiles 2020-01-30 16:42:14 -08:00
Medya Gh 8e0ffdf1cf resolve conflict 2020-01-30 16:20:55 -08:00
Medya Ghazizadeh 4bf3fc422a
Add docker run-time for kic driver (#6436)
* Add docker container run time for kic
2020-01-30 14:30:04 -08:00
Medya Gh b3404a70e6 patch node refactor for kic 2020-01-24 19:03:50 -08:00
Thomas Strömberg 82e096a7a1
Merge pull request #6390 from medyagh/kic_bindip
kic driver: add multiple profiles and ssh
2020-01-24 15:45:51 -08:00
Medya Gh ba3965b076 specify SSH username 2020-01-24 14:42:28 -08:00
Medya Gh 83dd9fc4ff Bump kic base image for ssh 2020-01-24 14:20:49 -08:00
Medya Gh c6c0046c57 let docker/podman choose hostbind port 2020-01-24 14:15:48 -08:00
tstromberg 35f1e58583 Merge conflict 2020-01-24 10:40:26 -08:00
Medya Gh 2bd169f508 add config fields for kic SSH and API ports 2020-01-23 23:51:41 -08:00
Medya Gh ca0f4c7e20 generate ssh keys for kic container 2020-01-23 19:20:44 -08:00
Medya Gh 09d9d05c6b generate ssh certs for kic during creation 2020-01-23 18:43:26 -08:00
Medya Gh 3d5c9ae870 implement SSHPortName for kic 2020-01-23 18:28:32 -08:00
Medya Gh 1e05b11703 Add ssh to kic image 2020-01-23 18:24:51 -08:00
Medya Gh 773510b9c1 Add ssh to kic container image 2020-01-23 17:45:50 -08:00
Medya Gh 5191659ff2 bind ip use const instead of string 2020-01-23 17:28:30 -08:00
tstromberg b81960e37c Fix none driver 2020-01-22 14:28:18 -08:00
tstromberg c83ee09417 Update Kubernetes libraries to v1.17.2 2020-01-22 14:10:53 -08:00
Thomas Stromberg 5f0420f72e Merge branch 'master' into pause 2020-01-22 09:48:26 -08:00
Thomas Stromberg 7e2e9eb15b Merge conflicts 2020-01-21 20:00:21 -08:00
Medya Gh 5a3c13815e network overlay only for kic 2020-01-21 15:14:51 -08:00
Medya Ghazizadeh 19c8ddee9f
Merge pull request #6151 from medyagh/kic_exp
Experimental verison of kic
2020-01-10 00:42:01 -08:00
Medya Gh 40a011c49a use api port for host binding port 2020-01-08 16:09:24 -08:00
Medya Gh cf9e6e512f fix ineffectual assignment 2020-01-08 15:21:57 -08:00
Medya Gh de0d603c7f convert base image to a const 2020-01-08 13:56:23 -08:00
Medya Gh ddf5ab027a add extra option fail swap for kic 2020-01-08 12:53:29 -08:00
Medya Ghazizadeh 6da07be75d
Merge pull request #6175 from q384566678/oci-remove-todo
pkg/drivers/kic/oci: delete TODO info
2020-01-08 10:40:32 -08:00
Zhou Hao 7e0b89cc9d code optimization
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-08 16:25:11 +08:00
Medya Gh f80572bb4c code review 2020-01-07 13:59:41 -08:00
Medya Gh 77394db9aa add Dockerfile for kic images 2020-01-07 13:54:00 -08:00
Medya Gh a64a2721d5 Add localhost to ca cert 2020-01-07 13:54:00 -08:00
Medya Gh e9b7451278 auto set podsubnet for kic improve none auto set 2020-01-07 13:54:00 -08:00
Medya Gh c7bc61af2c Add overlay network for kic 2020-01-07 13:54:00 -08:00
Medya Gh 6cf2554877 add flag for kic host binding port 2020-01-07 13:54:00 -08:00
Medya Gh ac97b51058 implement setup certs for kicbs 2020-01-07 13:52:47 -08:00
Medya Gh a358aff093 fix ocibinary 2020-01-07 13:52:47 -08:00
Zhou Hao c1859c44e3 kic/oci: parse all kind of states
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-02 14:16:54 +08:00
Medya Ghazizadeh e5f5abda89
Merge pull request #6179 from q384566678/fix-pause
pkg/drivers/kic: fix wrong command in Unpause
2019-12-30 18:42:28 -08:00
Zhou Hao 9c4e3fbd3c pkg/drivers/kic: fix wrong command in Unpause
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 15:54:48 +08:00
Zhou Hao ae61e56594 pkg/drivers/kic/oci: fix Status info
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 15:21:03 +08:00
Zhou Hao aa52255be0 pkg/drivers/kic/oci: delete TODO info
When the docker exit status is 125, it is not entirely certain that it is caused by duplicate names.There may also be other errors.
e.g:
➜  minikube git:(oci-remove-todo) ✗ docker run -itzz
unknown shorthand flag: 'z' in -zz
See 'docker run --help'.
➜  minikube git:(oci-remove-todo) ✗ echo $?
125

So delete this TODO info.

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 14:43:11 +08:00
Medya Gh f39ba0deb0 add unit test for feature gate supports 2019-12-20 01:17:33 -08:00
Medya Gh cce503033d rename CreateParam to CreateConfig 2019-12-19 11:12:49 -08:00
Medya Gh e1d5704170 get rid of default oci 2019-12-19 11:08:05 -08:00
Medya Gh 6cbdfe3961 remove more codefrom node 2019-12-19 10:47:07 -08:00
Medya Gh 310cef80de get rid of node cache 2019-12-19 10:37:15 -08:00
Medya Gh f001dd703a convert kic restart to case switch 2019-12-19 10:01:18 -08:00
Medya Gh 80b15e8e6c Add comment for config structs 2019-12-19 09:52:53 -08:00
Medya Gh 19560a631b Add kic specific machine creation message 2019-12-18 15:53:34 -08:00
Medya Gh 2243847f98 add kic command runner to machine 2019-12-18 13:57:32 -08:00
Medya Gh c627f58fbb add default image 2019-12-18 13:04:09 -08:00
Medya Gh 71b260292c remove more code 2019-12-17 21:53:36 -08:00
Medya Gh 12df013810 simplify overlaping structs 2019-12-17 21:36:37 -08:00
Medya Gh ca68beae6a remove not needed code 2019-12-17 19:33:54 -08:00
Medya Gh 7a433cc6a9 Add kic specifc fields to machine config 2019-12-17 17:47:37 -08:00
Medya Gh 379bf2ac0c fix boilerplate formats 2019-12-17 16:38:56 -08:00
Medya Gh 46df68ca4b move cri to oci package 2019-12-17 16:04:03 -08:00
Medya Gh d7273d36c9 Add kic driver 2019-12-17 15:18:31 -08:00
Thomas Stromberg 337db1707d First pass at multi-runtime pause/unpause 2019-11-22 15:11:51 -08:00
Medya Gh 773c525ae7 fix test and remove extra code 2019-10-29 16:36:10 -07:00
Medya Gh cd9e413852 resolve code review 2019-10-29 14:11:21 -07:00
Medya Ghazizadeh e2bbf7111e
Merge branch 'master' into NewCmdRunner 2019-10-27 00:18:00 -07:00
Medya Gh 792de2b0a1 resolve code review 2019-10-25 17:12:55 -07:00
Medya Gh 187dfe29f8 getting rid of some of bin bash -c 2019-10-24 14:13:51 -07:00
Medya Gh 05bbcf733a remove uneeded wrap output 2019-10-21 15:18:04 -07:00
Medya Gh 6faf9cdbe7 lint and code review 2019-10-21 13:01:06 -07:00
Medya Gh 6bd5d9b157 Merge remote-tracking branch 'upstream/master' into NewCmdRunner 2019-10-21 11:17:28 -07:00
Thomas Strömberg 523db2099c
Merge pull request #5640 from sharifelgamal/auto-download-off
add ability to override autoupdating drivers
2019-10-21 10:16:49 -07:00
tstromberg 35f7c9f38a Merge branch 'master' into drv-reorg 2019-10-21 09:50:08 -07:00
cueo 6533d9f2e8 Rename methods to match the convention 2019-10-20 19:11:31 +05:30
tstromberg 7cb0cfdf79 Pass lint checks 2019-10-18 13:53:57 -07:00
Thomas Stromberg 6d7d589a52 Consolidate driver-interaction code into pkg/minikube/driver 2019-10-18 13:00:07 -07:00
Sharif Elgamal a6d7989bfc add ability to override autoupdating drivers 2019-10-16 14:51:13 -07:00
Medya Gh fcf17fb42f bin bash all the way 2019-10-10 09:23:26 -07:00
Medya Gh 25e3d870e5 fixing with shelquote 2019-10-08 17:08:38 -07:00
Medya Gh 91618aa38b get rid of ExecCmd all the way 2019-10-08 15:13:54 -07:00