Commit Graph

213 Commits (dd11ed8da03f940ef610f4aa97eab47f034932a2)

Author SHA1 Message Date
Priya Wadhwa 52953bac93 Merge branch 'master' of github.com:kubernetes/minikube into kic-add-static-ip 2020-08-12 14:03:43 -07:00
Priya Wadhwa a949f9ca7b improvement 2020-08-12 12:58:21 -07:00
Priya Wadhwa bdb59c2598 lint 2020-08-12 12:56:07 -07:00
Priya Wadhwa dfa05d714e include gateway when creating custom network 2020-08-12 12:54:06 -07:00
Priya Wadhwa af94e0a0c5 add logging 2020-08-12 10:57:48 -07:00
Priya Wadhwa 2400d1b850 remove network correctly 2020-08-12 10:08:46 -07:00
Priya Wadhwa 69d21df7c5 make sure we use custom network if it exists 2020-08-12 12:45:49 -04:00
Priya Wadhwa 3b5f973459 make sure we delete networks correctly 2020-08-12 12:36:57 -04:00
Medya Ghazizadeh 51bbba9bdc
Merge pull request #8973 from medyagh/daemon_info_unittest
add unit test for daemon info
2020-08-11 15:50:02 -07:00
Medya Gh f20d3bddf0 add boilerplate 2020-08-11 15:13:16 -07:00
Medya Gh 25dc0cd0f7 lint 2020-08-11 15:03:10 -07:00
Medya Gh f8d932e697 use mock funcs 2020-08-11 14:55:30 -07:00
Medya Gh 4c0334d91f add one more case 2020-08-11 13:10:17 -07:00
Medya Gh a9eec3ca7b add unit test for daemon info 2020-08-11 13:06:50 -07:00
Medya Gh 7463eda122 remvoe comment 2020-08-11 10:40:40 -07:00
Medya Gh 1d94fa911a ensure nil error is returned 2020-08-11 10:40:40 -07:00
Medya Gh bbc58fa194 refresh daemon info cache if there is error 2020-08-11 10:40:40 -07:00
Priya Wadhwa 21789d8c4e compile 2020-08-10 17:18:42 -04:00
Priya Wadhwa dfcfd6f2f0 cleanup 2020-08-10 17:15:26 -04:00
Priya Wadhwa 9dcb0c5478 fix merge conflict 2020-08-10 17:12:56 -04:00
Priya Wadhwa 5799b47ddb Implement some checks and reorganize code 2020-08-10 17:04:41 -04:00
Thomas Stromberg 9c0618f102 Merge to master 2020-07-24 11:22:59 -07:00
Thomas Stromberg bd713ffd45 Increase maximum container startup wait from 13 seconds to 25 seconds 2020-07-24 09:02:32 -07:00
Thomas Stromberg dee9c0b427 Show 'docker logs' excerpt if container dies 2020-07-24 08:58:09 -07:00
Medya Ghazizadeh f04a6a061f
Merge pull request #8586 from afbjorklund/container-id
Support more error messages for container inspect
2020-07-21 12:22:31 -07:00
Medya Ghazizadeh 2086bcb2b1
Merge pull request #8718 from medyagh/check_docker_deskop
docker/podman: warn if allocated memory is below limit
2020-07-20 15:26:41 -07:00
Medya Gh 13357d91a4 avoid nil pointer 2020-07-20 12:56:03 -07:00
Anders F Björklund 22585c3a17 Use the preload container run for podman as well
Now that there is no more race between the containers for
preparing the volume, we can use it for podman as well...

Previously we risked ending up with not copying the contents
of /var from the container image, which made it not work.
2020-07-20 21:54:28 +02:00
Anders F Björklund 2a9e9b2425 Make sure to prepare the kic volume after creation
The volume is created as empty, so make sure that we run a
container to do the initial copy of /var from the image.

This is to avoid race conditions later on, where the preload
starts to use the created volume for packing up the tarball.
2020-07-20 21:50:13 +02:00
Jose Donizetti c2175abcba Add static ip to kic/docker 2020-07-18 18:19:53 -03:00
Medya Gh 3aac9a3fff remove duplicate return statement 2020-07-15 14:24:42 -07:00
Medya Gh 8ecb483cb7 use cached error 2020-07-15 14:23:25 -07:00
Medya Gh 7bbb0b6250 spell 2020-07-15 14:09:35 -07:00
Medya Gh de6c10526b move cacheDaemoninfo to oci package 2020-07-15 14:07:50 -07:00
Sharif Elgamal d0d3973a13 restrict apparmor security opt to docker 2020-07-09 12:58:01 -07:00
Anders F Björklund f23bbea995 Support more error messages for container inspect
The messages are different between "inspect" and "container inspect",
and also changed a bit in format between Podman v1 and Podman v2.

Support all of them, for compatibility with different versions of
Docker and Podman. Was causing restarts and failures, with KIC.
2020-06-28 14:19:09 +02:00
Priya Wadhwa 7c2cac612d Fix bug in FailFastError and add unit test
Since FailFastError was just another `error`, all errors were technically `FailFastErrors`.

This code makes `FailFastError` a struct which implements the error interface, so that now errors can be distinctly identified as `FailFastError`'

Also added a unit test to prove that this works now.
2020-06-26 11:58:34 -07:00
Priya Wadhwa e32e2135ed review comments 2020-06-25 19:39:59 -07:00
Priya Wadhwa 903686172d Check for iptables file before determining container is running 2020-06-25 17:58:22 -07:00
Medya Gh e91e11eeba address review comments 2020-06-17 18:32:11 -07:00
Medya Gh 29e01d5dcb fix comment 2020-06-17 15:17:45 -07:00
Medya Gh ca2d0f97ec move advice to its own file 2020-06-17 15:07:17 -07:00
Medya Gh 543b0b5bfa add post mortem logs when container not running 2020-06-17 13:27:17 -07:00
Medya Gh 736f5219e0 add error type for check running 2020-06-17 12:13:12 -07:00
Medya Gh 56b5524c8e address review comments 2020-06-16 14:57:19 -07:00
Medya Gh 4caf260279 add cpu count limit error type for kic drivers 2020-06-16 13:21:56 -07:00
Priya Wadhwa 6ef48499b4 Code review comments 2020-06-12 11:00:46 -07:00
Priya Wadhwa b750ab4964 fix lint 2020-06-11 13:00:46 -07:00
Priya Wadhwa 330224f36a Warn user to restart daemon if context deadline is exceeded 2020-06-11 12:50:11 -07:00
Priya Wadhwa 0ec839186d Change glog.Errorf to glog.Infof so that we don't get an ugly log to stdout 2020-06-11 11:14:04 -07:00