14937e4677
Never use docker inspect, always provide the type
...
Should avoid errors like: map has no entry for key "State"
When inspecting a volume, rather than a container or image
2020-05-21 17:20:53 +02:00
afab7c87c6
Merge pull request #7959 from afbjorklund/podman-prompt
...
Use noninteractive sudo when running podman
2020-05-11 21:02:22 +00:00
6b97ee8ee2
Merge pull request #8001 from afbjorklund/podman-start
...
podman: Wrap the start command with cgroup manager too
2020-05-11 17:59:39 +00:00
c578a7aa1e
Add a PointToHost function for podman as well
...
And add an active variable, similiar to docker
2020-05-10 23:07:12 +02:00
7e3da0f8b0
Merge pull request #8017 from elegos/podman-volumes-extract-tarball-to-volume
...
Podman: disable selinux labels when extracting the tarball (permissions error)
2020-05-09 21:35:43 +00:00
46025eccf5
Use the runCmd wrapper for start to not miss error
2020-05-09 14:07:18 +02:00
ac01e92012
Add comment about why podman looks at runtime.GOOS
2020-05-09 14:05:57 +02:00
a7a5148ff6
Don't add cgroup manager param for podman-remote
...
Since it doesn't work for either "run" or "start"
Error: unknown flag: --cgroup-manager
2020-05-09 14:04:04 +02:00
85fae62d4a
Wrap the start command with cgroup manager too
...
When running with podman, to match the run cmd
2020-05-09 14:04:04 +02:00
934ad06a82
Use noninteractive sudo when running podman
...
To avoid asking for a password in the middle of minikube commands.
The setup process is supposed to involve adding podman to sudoers...
2020-05-09 13:23:46 +02:00
436cee2d84
Fix minikube/kubernetes capitalization, make short help consistent
2020-05-07 14:12:10 -07:00
9c43c47b06
Podman: disable selinux labels when extracting the tarball to prevent permission errors
2020-05-07 02:09:09 +02:00
6eeb929b3d
Merge pull request #7962 from afbjorklund/podman-gateway
...
Get the gateway by inspecting container network
2020-05-04 20:05:56 +00:00
1da92a1c84
Merge pull request #7961 from afbjorklund/podman-preload
...
Use the correct binary for unpacking the preload
2020-05-04 20:04:19 +00:00
e0685c8f5d
Merge pull request #7984 from medyagh/detect_windows_container
...
Detect windows container and exit with instructions
2020-05-04 20:01:17 +00:00
cc6506d2c9
Remove logging statement from containerGateway
2020-05-03 09:42:32 +02:00
bcecda8e20
add comment for error type
2020-05-02 18:48:52 -07:00
2102a20605
wrap errors
2020-05-02 18:38:23 -07:00
4572d0634f
exit with usage if container type is windows
2020-05-02 18:29:33 -07:00
ee9004f93b
add os type to DaemonInfo
2020-05-02 17:02:19 -07:00
743f9f7efc
Don't show any podman hint about restarting sudo
2020-05-01 22:21:32 +02:00
e2d7d94dfc
Use the correct binary for unpacking the preload
...
Previously hardcoded to *always* use a Docker volume,
even if using a different container driver (podman).
2020-05-01 22:11:28 +02:00
3531efda7b
Get the gateway by inspecting container network
2020-05-01 15:05:21 +02:00
78a22f5056
Remove prefix parameter and add prefix command
...
Move the "sudo" prefix to a central location, instead of
having it all over the place. Assume only needed on Linux.
2020-04-28 13:52:52 +02:00
1744ffe773
Restore the configured state added for podman
...
Reverted 22aa1aff22
2020-04-27 22:27:53 +02:00
998ab840fb
Use simple version of podman info format parameter
...
So that it works with the older versions of podman
2020-04-26 22:54:45 +02:00
795128131f
Remove old Copy function added in merge conflict
2020-04-26 22:52:10 +02:00
28106fa2d7
Use constants instead of the KIC prefix strings
2020-04-26 15:22:57 +02:00
88c8a24d55
Pass the container implementation on to systemd
2020-04-25 22:43:40 +02:00
7185140c57
Remove extra quotes added in conflict resolution
...
Reverted f264ac171e
2020-04-25 22:09:52 +02:00
7647b1f998
Don't try to limit podman memory without cgroup
...
Podman requires both memcg and memcg_swap for it (--memory).
Docker will still limit memory, without swap limit support.
2020-04-25 22:01:51 +02:00
6644c5cc64
Merge branch 'master' into podman-sudo
2020-04-25 18:05:33 +02:00
63f9bfbb61
addres review comments
2020-04-24 14:07:54 -07:00
ef01ed481c
get rid of global CliRunner
2020-04-23 14:37:03 -07:00
17f420cc71
warn slow part of cli runner
2020-04-23 01:23:49 -07:00
d9f1b532d0
unexport warnIfSlow func
2020-04-23 00:33:59 -07:00
038aef6b48
unexport warnIfSlow func
2020-04-23 00:33:40 -07:00
8a0a210763
convert more funcs to use cli runner
2020-04-23 00:29:37 -07:00
c6e1445ccb
convert more to cli runner
2020-04-23 00:12:41 -07:00
29df4260ef
make all oci volume calls go through runner
2020-04-22 23:27:54 -07:00
915058ef8e
lint
2020-04-22 23:01:04 -07:00
72baa1dad2
convert execs to cliRunner
2020-04-22 22:49:48 -07:00
c6895c2058
add cli runner to info
2020-04-22 22:34:11 -07:00
fad745f607
adding runner for oci package
2020-04-22 22:16:18 -07:00
b639c6112d
fix delete and add integeration test
2020-04-20 20:38:31 -07:00
19be5619d6
Resource limits seem to work ok when not rootless
2020-04-19 09:45:16 +02:00
024cd6b108
Use the same kind of named /var mount for podman
...
The internal anonymous mounts do not seem to have the same
issues as the external path mounts, so we can do all of /var
2020-04-19 09:45:16 +02:00
8987b1067a
Also persist the kubelet and the cni state dirs
2020-04-19 09:45:16 +02:00
223424652c
Also create and mount the container runtime dirs
2020-04-19 09:45:16 +02:00
df3aec6b0a
Missed to wrap one podman inspect in sudo proper
2020-04-19 09:45:16 +02:00
f57faf8036
Only remount the /var/lib/minikube directory
2020-04-19 09:45:16 +02:00
22aa1aff22
Handle more state and status for the podman driver
2020-04-19 09:45:16 +02:00
f264ac171e
Remove extra single-quotes from format parameter
...
podman
Error: template parsing error: template: image:1: function "json" not defined
2020-04-19 09:42:17 +02:00
d7dc7bf7b2
The podman driver should not be run as root
...
Use sudo for the podman commands instead
Wrap the docker commands with env prefix
2020-04-19 09:42:17 +02:00
bf15f9a00c
fix build err
2020-04-16 16:20:04 -07:00
934f900f16
improve kic start and kill
2020-04-16 16:10:44 -07:00
34fafc783f
fine tune
2020-04-14 22:20:28 -07:00
7303ccf07d
lint
2020-04-14 21:31:12 -07:00
54aa958f01
use oci to delete
2020-04-14 20:51:18 -07:00
f22a36332e
add shut down to stop
2020-04-14 20:21:40 -07:00
b7f0bfc369
unconfine apparmor for kic
2020-04-13 16:44:17 -07:00
3a12fbd1f5
Fix spelling
2020-04-09 10:50:20 -07:00
70329bf51d
Code review comments
2020-04-08 13:44:04 -07:00
b509d69182
Extract preloaded tarball as soon as minikube volume is created
...
Extracting preload currently takes 6 seconds. This PR begins preload extraction as soon as the minikube volume is created, and runs it in parallell with creating the container node and setting up SSH.
This shaves 2-3 secnods off of `node.StartHost`
2020-04-07 14:19:20 -07:00
a0263c2513
adjust more
2020-04-03 20:59:03 -07:00
a62d611e0b
adjust kill time
2020-04-03 20:59:03 -07:00
8f51d7de58
adjust warn if slow for ps and volume
2020-04-03 20:59:03 -07:00
5307145802
Move errors and warnings to output to stderr
2020-04-02 09:58:13 -07:00
2f2dccd30c
Remove test values
2020-03-26 14:05:02 -07:00
46f31480df
Make slow command detection consistent across kic/oci
2020-03-26 14:03:22 -07:00
f00f5ff600
remove extra if
2020-03-24 10:21:32 -07:00
940baa09ea
fix comment
2020-03-24 07:31:22 -07:00
41b16b1568
fail if container is not running
2020-03-24 07:27:07 -07:00
83cc28e082
add logging for when container status is running
2020-03-24 07:11:22 -07:00
f54af5d684
function name HostPortBinding changed to ForwardedPort
2020-03-14 21:28:12 +05:30
43ce409e79
Extra debugging for preload generation process
2020-03-11 13:09:55 -07:00
9ac1ad2a7e
Merge master
2020-03-06 16:13:54 -08:00
e027dfc4d2
More unused code cleanup
2020-03-06 15:57:12 -08:00
3fee641a13
Remove remaining PointToHostDockerDaemon calls
2020-03-06 15:15:05 -08:00
a58a9f0176
tweak
2020-03-06 15:13:56 -08:00
cb14468b44
english
2020-03-06 15:11:42 -08:00
cdb8f9c3f6
make sure container is running after create
2020-03-06 15:08:39 -08:00
38ccb88e3f
address code review
2020-03-06 10:25:48 -08:00
0335fb1ad7
change names
2020-03-05 22:38:47 -08:00
1e8dd94a77
fix logic
2020-03-05 22:31:44 -08:00
e1f6820335
fix already in use
2020-03-05 16:42:56 -08:00
0ff12cafac
Merge branch 'master' of github.com:kubernetes/minikube into machinename
2020-03-04 16:37:54 -08:00
a3e000d850
addressing comments
2020-03-04 14:09:15 -08:00
f40c5a7b30
move funcs arround
2020-03-04 12:50:01 -08:00
6a62046e62
add warning and point to right docker
2020-03-04 10:22:20 -08:00
28e030c728
Merge branch 'master' of github.com:kubernetes/minikube into machinename
2020-03-03 12:16:47 -08:00
31a42ce672
address comments
2020-03-02 17:30:08 -08:00
05a46f6526
remove unnecessary PreloadedVolume
2020-03-02 16:17:35 -08:00
4cd3ef81a5
more changes
2020-03-02 15:21:37 -08:00
d6e94c1ee4
remove unused functions
2020-03-02 13:54:35 -08:00
474561d082
remove unused functions
2020-03-02 13:48:18 -08:00
697359b4f3
Fixed lint
2020-03-02 13:37:22 -08:00
6b0e942e7e
Rebased on master
2020-03-02 13:33:27 -08:00
3cf2c9bbe3
Merge pull request #6807 from medyagh/delete_hang
...
warn about "stuck docker" in minikube delete
2020-02-26 14:32:18 -08:00
8d0c41392b
continue instead of nest
2020-02-26 13:50:42 -08:00
Anders F Björklund
Medya Ghazizadeh
Thomas Stromberg
Giacomo Mr. Wolf Furlan
Medya Gh
Medya Gh
Priya Wadhwa
vikkyomkar
Sharif Elgamal