Thomas Stromberg
c5f65baf61
Remove uid from hash name, as it is not necessary now that we lock on filenames rather than descriptive names
2019-12-11 11:52:36 -08:00
Thomas Stromberg
129b6a870b
Update log messages
2019-12-11 09:54:44 -08:00
Thomas Stromberg
af4e690837
Use sha1 for a larger hash, truncated to 40 chars
2019-12-11 09:14:20 -08:00
Thomas Stromberg
cfe0f5a5b7
Use md5 to generate unique lock names
2019-12-11 08:13:12 -08:00
Thomas Stromberg
bb28d5c346
Make lock names more specific to avoid conflicts
2019-11-14 10:57:11 -08:00
Medya Gh
6bd5d9b157
Merge remote-tracking branch 'upstream/master' into NewCmdRunner
2019-10-21 11:17:28 -07:00
Thomas Strömberg
ce2b0a3b9a
Merge pull request #5471 from xichengliudui/redundantCode
...
remove the redundant code in util.go
2019-10-17 15:16:40 -07:00
Medya Gh
eaa01716ea
move unit tests from util to command_runner
2019-10-02 15:56:21 -07:00
Medya Gh
88183240ca
move teePrefix from util to ssh_runner
2019-10-02 15:09:42 -07:00
xichengliudui
7ebef128f3
Remove the redundant code in util.go
...
update pull request
2019-09-27 09:35:59 +08:00
Anders F Björklund
869c08a5bc
Address some minor comment issues raised by golint
2019-09-21 09:24:35 +02:00
serhatcetinkaya
20a439de02
replaced constants.GetMinipath() with localpath.MiniPath()
2019-09-19 23:28:20 +03:00
tstromberg
d2b675a7fb
Indent progress bar to fit under a status item
2019-09-17 17:47:45 -07:00
Thomas Stromberg
3b394df815
Add mutex around generateCerts to avoid TOCTOU race
2019-09-11 13:10:21 -07:00
josedonizetti
30e75c3c39
Download kvm2 driver
2019-09-11 11:34:29 -03:00
Sharif Elgamal
14f3aa9244
Merge pull request #5165 from sharifelgamal/cfg
...
Replace file lock with mutex
2019-08-26 15:25:47 -07:00
AllenZMC
b73c8505b4
cleanup: fix mis-spelling in retry.go
2019-08-26 20:26:35 +08:00
Sharif Elgamal
172d5933f1
Merge branch 'master' of github.com:kubernetes/minikube into cfg
2019-08-22 16:29:25 -07:00
Sharif Elgamal
4733ebd1c3
formatting
2019-08-22 13:19:56 -07:00
Sharif Elgamal
534b2e9ec4
add test for getMutexName
2019-08-22 12:45:04 -07:00
Sharif Elgamal
8b4365e51d
change confusing variable name
2019-08-21 18:55:35 -07:00
Sharif Elgamal
0cd49b8a32
more massaging around mutex name
2019-08-21 15:42:57 -07:00
Sharif Elgamal
020167617a
add comments for clarity
2019-08-21 15:21:10 -07:00
Sharif Elgamal
43e39618a2
Replace file lock with mutex
2019-08-21 15:17:32 -07:00
Thomas Stromberg
62a452edab
Merge master
2019-08-21 10:26:10 -07:00
Medya Gh
5811610697
refactor util/kuberentes and ExtraOptions
2019-08-17 19:05:54 -07:00
Guangming Wang
8fb12d3a61
cleanup: lock.go error message typo fix
...
Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
2019-08-17 23:29:21 +08:00
Thomas Stromberg
282dcc9503
Merge branch 'master' into persistent
2019-08-16 16:38:56 -07:00
Guangming Wang
39d055431d
cleanup: fix error message in crypto.go
...
Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
2019-08-16 23:23:21 +08:00
Medya Gh
9fad24aa37
defer release the lock
2019-08-14 11:05:03 -07:00
Thomas Stromberg
b983c47145
Merge branch 'master' into persistent
2019-08-14 08:12:25 -07:00
Medya Gh
fb24d04fef
remove unused code
2019-08-14 00:35:39 -07:00
Medya Gh
c8e6f61bc1
convert all util.Retry to retry.Expo
2019-08-14 00:24:51 -07:00
Medya Gh
f17f3408a8
convert all RetryAfter to retry.Expo
2019-08-13 23:48:30 -07:00
Medya Gh
998d305af3
Adding lock to most ioutil.WriteFile
2019-08-13 21:12:34 -07:00
Medya Gh
9d44601ede
Addeed file lock for kubeconfig
2019-08-13 20:56:28 -07:00
Medya Gh
d264d7d553
adding retry subpackage
2019-08-13 19:59:21 -07:00
Medya Ghazizadeh
7bb085ad24
Merge pull request #5003 from medyagh/kubeconfig
...
Refactor Kubeconfig
2019-08-13 14:57:49 -07:00
Thomas Strömberg
345ed1b85d
Merge pull request #5025 from blueelvis/4996-fix-download-progress-bars
...
Upgrade cheggaaa/pb from v1.0.27 to v3.0.1
2019-08-12 08:31:20 -07:00
Pranav Jituri
42f5b11fb3
Fixed as per review comments
2019-08-10 12:48:49 +05:30
Thomas Stromberg
7c865c27cf
Merge DefaultMinikubeDirectory with GuestPersistentDir
2019-08-09 15:19:23 -07:00
Thomas Stromberg
2f1a11d8d3
Move reusable files (images, binaries, certs) to /data
2019-08-09 15:04:07 -07:00
Medya Gh
9ab4892806
move test data
2019-08-09 12:19:58 -07:00
Medya Gh
df624349c3
created kubeconfig package
2019-08-09 12:18:33 -07:00
Sharif Elgamal
1f48364487
Fix prepareNone and add integration test for it ( #5023 )
...
* Fix prepareNone and add integration test for it
* add test file
* only compile none test on linux
* build tags are confusing
* build tags are quite confusing
* build tags are very confusing
2019-08-08 15:47:44 -07:00
Pranav Jituri
7fa4e054f3
Fixed the progress bars ^_^
2019-08-09 04:02:29 +05:30
tstromberg
08d97cf025
Use a temp dest to atomically download the iso
2019-08-06 16:01:06 -07:00
Medya Ghazizadeh
551b164017
Merge pull request #4941 from josedonizetti/add-kubeconfig-tests
...
wip: Improve coverage: add kubeconfig tests
2019-08-06 10:38:04 -07:00
Thomas Stromberg
38410704ed
Document 78
2019-08-05 16:32:54 -07:00
Thomas Stromberg
2540253bcb
Indent progress bar & set width to 78 columns
2019-08-05 15:40:14 -07:00
tstromberg
23491b68b6
Add boilerplate
2019-08-05 12:47:11 -07:00
tstromberg
22e55c70b8
Switch ISO download impl from go-download to go-getter
2019-08-05 11:46:38 -07:00
josedonizetti
e14c7d9b1f
Fix TestSetCurrentContext to use tmpfile
2019-08-02 21:28:16 -03:00
tstromberg
e717d46030
Decrease ReasonableStartTime from 10 minutes to 5 minutes
2019-08-02 14:42:57 -07:00
josedonizetti
760707a5fb
Fix lint
2019-08-01 15:08:27 -03:00
josedonizetti
358750e2e4
Add UnsetCurrentContext tests
2019-08-01 14:32:26 -03:00
josedonizetti
8cc1242601
Add TestSetCurrentContext
2019-08-01 13:20:01 -03:00
Medya Gh
9b3f72024a
list vms after clean up
2019-07-30 10:42:55 -07:00
Medya Gh
d1a41e0015
Added default profile
2019-07-30 10:40:11 -07:00
josedonizetti
3ec9b1ed2a
Bump k8s.io/kubernetes to 1.15.0
2019-07-24 19:51:40 -03:00
Sharif Elgamal
6552436311
Console output cleanup ( #4825 )
...
* Console output cleanup
* comment fix
* Fixing out.Out stutter
* Fix invalid template
* Change profile_list.go to new console functions
* more merge stuff
2019-07-19 17:00:51 -07:00
Thomas Stromberg
4076eb15d6
Remove unused imports
2019-07-19 16:40:34 -07:00
Thomas Stromberg
a9309c3237
Remove unused ParseSHAFromURL function
2019-07-19 16:36:26 -07:00
tstromberg
22ae10c267
Remove unused getTestArgs struct
2019-07-18 18:17:19 -07:00
tstromberg
14c67d46a5
Remove TestParseSHAFromURL (not well isolated, takes 30 seconds)
2019-07-18 18:12:28 -07:00
Sharif Elgamal
93263bc2bc
Templatizing more calls to console
2019-07-17 18:06:06 -07:00
Thomas Strömberg
82d4c7dd2c
Merge pull request #4688 from kairen/better-comment
...
Add space after // comments
2019-07-11 11:53:15 -07:00
Kyle Bai
c5f695e8a0
Better comment syntax
2019-07-05 11:17:10 +08:00
Kyle Bai
6505dfad62
Delete kubeconfig when a machine has been deleted
2019-07-04 14:47:41 +08:00
Pranav Jituri
6ba1725c08
Added Memory Size Checking
2019-06-26 00:22:41 +05:30
serhat çetinkaya
9d88171d18
Improve stop behavior to unset curren-tcontext only if needed
2019-06-25 10:55:28 -07:00
Medya Gh
b332f04ac0
better var name
2019-06-15 23:17:14 -07:00
Medya Gh
5176806eb2
set context on profile
2019-06-15 22:18:23 -07:00
Medya Gh
05177194a5
increasing time out for Pod operations
2019-06-14 16:03:23 -07:00
Medya Gh
657469310c
Use retryable http to avoid connection flakes
2019-06-13 22:58:14 -07:00
Sharif Elgamal
f424969553
Initialisms, man.
2019-05-30 10:40:45 -07:00
Sharif Elgamal
34ccd2ad41
Change console style string to enum
2019-05-29 18:45:55 -07:00
Thomas Strömberg
9d09ff069b
Merge pull request #4229 from medyagh/no_proxy_for_self
...
Allow minikube to function with misconfigured NO_PROXY value
2019-05-20 11:22:12 -07:00
Jan Janik
21b9e95647
Whitelist for kubeadm extra args
2019-05-17 17:11:03 +12:00
Medya Gh
3ff806a595
Added unittest and rebase
2019-05-16 14:44:01 -07:00
Medya Gh
e878f9badb
Merge remote-tracking branch 'upstream/master' into no_proxy_for_self
2019-05-15 14:19:14 -07:00
Medya Gh
b9149b1eb0
Better name
2019-05-15 11:44:31 -07:00
Medya Gh
6fe614efa7
Fix stutter between the package name and the function
2019-05-15 11:34:21 -07:00
Medya Gh
8120cdd505
No Proxy for Dashboard and moving logic to proxy package
2019-05-14 21:45:35 -07:00
tstromberg
313cf575fe
Merge branch 'master' into gomods
2019-05-14 21:06:00 -07:00
Medya Gh
6a433d01bf
Fixing K8S Client Config with TranportWrap
2019-05-14 20:16:44 -07:00
Thomas Stromberg
25579f5a58
Use consistent names for k8s API imports
2019-05-13 21:57:59 -07:00
tstromberg
9a9f9edf5f
First pass at lint-ageddon
2019-05-13 18:31:55 -07:00
Himanshu Pandey
c8af727416
Added tests to check current-context on start and stop of minikube
2019-04-30 15:32:40 -07:00
Himanshu Pandey
df0a0ad77c
Unset the current-context on minikube stop
2019-04-30 00:02:05 -07:00
Anders F Björklund
a73dfc5f9e
Merge branch 'master' into cyclo
2019-04-12 20:03:20 +02:00
Benn Linger
d102550644
Fixed status checking with non-default apiserver-port.
2019-04-04 21:43:43 -04:00
Jan Janik
e3cd27264d
Escape systemd special chars in —docker-env
2019-03-29 16:56:51 +13:00
Anders F Björklund
4667c28164
Merge branch 'master' into cyclo
2019-03-26 07:16:28 +01:00
Thomas Strömberg
460ef571e2
Merge branch 'master' into lint
2019-03-21 11:32:47 -07:00
Thomas Stromberg
605088ff72
Keep Initializers as the first element, fix v1.14 test which still included Initializers
2019-03-20 17:23:07 -07:00
Thomas Stromberg
88091b2323
Fix DefaultLegacyAdmissionControllers comment
2019-03-20 16:45:39 -07:00
Anders F Björklund
03bdce47ee
Decrease cyclomatic complexity for test
...
Mostly by using the "extract method" pattern.
Here was the report (from gocyclo), before:
17 tunnel TestTunnelManagerCleanup pkg/minikube/tunnel/tunnel_manager_test.go:174:1
44 tunnel TestTunnel pkg/minikube/tunnel/tunnel_test.go:35:1
34 kubeconfig configEquals pkg/util/kubeconfig/config_test.go:420:1
25 integration testMounting test/integration/mount_test.go:36:1
18 integration testTunnel test/integration/tunnel_test.go:37:1
2019-03-16 23:04:24 +01:00
Anders F Björklund
00c9846a19
Decrease cyclomatic complexity for code
...
Mostly by using the "extract method" pattern.
Here was the report (from gocyclo), before:
16 kubeadm (*KubeadmBootstrapper).UpdateCluster pkg/minikube/bootstrapper/kubeadm/kubeadm.go:374:1
16 cluster StartHost pkg/minikube/cluster/cluster.go:64:1
16 tunnel setupRoute pkg/minikube/tunnel/tunnel.go:135:1
16 provision configureAuth pkg/provision/buildroot.go:218:1
21 util setElement pkg/util/config.go:50:1
2019-03-16 22:18:14 +01:00
Anders F Björklund
5497b966be
Rename stutter and move classes between packages
...
Removing the kubeconfig module is probably not a big deal,
since it was already hiding under the "util" directory...
But the layout of the Bootstrapper is slightly irritating,
as long as it is contained in a different "kubeadm" module.
2019-03-16 16:57:56 +01:00