Remove TestParseSHAFromURL (not well isolated, takes 30 seconds)
							parent
							
								
									172fa046cf
								
							
						
					
					
						commit
						14c67d46a5
					
				| 
						 | 
				
			
			@ -19,9 +19,6 @@ package util
 | 
			
		|||
import (
 | 
			
		||||
	"bytes"
 | 
			
		||||
	"fmt"
 | 
			
		||||
	"io"
 | 
			
		||||
	"net/http"
 | 
			
		||||
	"net/http/httptest"
 | 
			
		||||
	"strings"
 | 
			
		||||
	"sync"
 | 
			
		||||
	"testing"
 | 
			
		||||
| 
						 | 
				
			
			@ -94,39 +91,6 @@ type getTestArgs struct {
 | 
			
		|||
	expectedError bool
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
var testSHAString = "test"
 | 
			
		||||
 | 
			
		||||
func TestParseSHAFromURL(t *testing.T) {
 | 
			
		||||
	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 | 
			
		||||
		if _, err := io.WriteString(w, testSHAString); err != nil {
 | 
			
		||||
			t.Fatalf("WriteString: %v", err)
 | 
			
		||||
		}
 | 
			
		||||
	}))
 | 
			
		||||
	serverBadResponse := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 | 
			
		||||
		w.WriteHeader(http.StatusInternalServerError)
 | 
			
		||||
		if _, err := w.Write([]byte("500 HTTP status code returned!")); err != nil {
 | 
			
		||||
			t.Fatalf("Write: %v", err)
 | 
			
		||||
		}
 | 
			
		||||
	}))
 | 
			
		||||
 | 
			
		||||
	argsList := [...]getTestArgs{
 | 
			
		||||
		{server.URL, testSHAString, false},
 | 
			
		||||
		{serverBadResponse.URL, "", true},
 | 
			
		||||
		{"abc", "", true},
 | 
			
		||||
	}
 | 
			
		||||
	for _, args := range argsList {
 | 
			
		||||
		url, err := ParseSHAFromURL(args.input)
 | 
			
		||||
		wasError := err != nil
 | 
			
		||||
		if wasError != args.expectedError {
 | 
			
		||||
			t.Errorf("ParseSHAFromURL Expected error was: %t, Actual Error was: %s",
 | 
			
		||||
				args.expectedError, err)
 | 
			
		||||
		}
 | 
			
		||||
		if url != args.expected {
 | 
			
		||||
			t.Errorf("ParseSHAFromURL: Expected %s, Actual: %s", args.expected, url)
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func TestMultiError(t *testing.T) {
 | 
			
		||||
	m := MultiError{}
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue