c721b056fc
Make table and json output consistent
2023-02-21 20:06:31 -06:00
14b32a040b
added linting and fixed ubit test
2023-02-18 10:30:32 +05:30
fbce562099
add a new flag called --skip-aduit
2023-02-16 12:56:03 -08:00
1ca885c1b3
Optimized
2023-02-16 22:31:59 +05:30
1d5c6ef2a2
corrected
2023-02-16 21:53:45 +05:30
cd787da24e
added detail json for addons
2023-02-16 07:41:50 +05:30
e33b5af7b7
Add integration test and fix behvaior on wrong output format for service list
2023-02-15 15:44:48 -06:00
a26f197f0b
change another one to warn
2023-02-15 11:18:09 -08:00
f3266711de
change errorf to warnf for aduit error
2023-02-15 11:01:34 -08:00
313cabe8f7
Fix bash completion for kubectl symlinked to minikube by not adding `--cluster` flag for the `kubectl __complete` subcommand
...
Signed-off-by: Ben Krieger <ben.krieger@intel.com>
2023-02-15 10:36:36 -05:00
1bd9b39d51
Add shell completion for minikube kubectl subcommand
...
Signed-off-by: Ben Krieger <ben.krieger@intel.com>
2023-02-14 14:43:51 -05:00
ba699acc9b
Merge pull request #15731 from p2c2e/mount_msg
...
Print proper value of mount type using info print statement
2023-02-13 15:42:35 -08:00
f0e2e388dd
Add ability to get json for "minikube service list"
2023-02-11 15:33:11 -06:00
fc644b8453
Merge pull request #15793 from spowelljr/tabbedVView
...
QEMU: Rename `user` network to `builtin` and update documentation
2023-02-10 10:33:29 -08:00
0046eba5c3
rename IsBuiltin to IsBuiltinQEMU
2023-02-09 12:07:17 -08:00
c417258f9c
change user network to builtin
2023-02-09 09:48:43 -08:00
c311d9e620
better verb choice for error output
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-02-03 15:33:55 -06:00
383a4c181c
better flag description
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-02-03 15:32:53 -06:00
229a721a84
fixed lint error
2023-02-02 05:45:43 -06:00
d91847d6cf
corrected the flag output
2023-02-01 21:08:53 -06:00
1db52e77b4
added flag
2023-02-01 15:34:37 -06:00
7ce7244596
Incorrect field name being passed to info print statement for Mount Type
2023-01-28 09:53:22 +05:30
0fbb9a6a31
update comments and store socket_vmnet paths in machine config
2023-01-25 10:45:20 -08:00
46e9cc24ee
check brew install paths for socket_vmnet
2023-01-24 11:51:17 -08:00
5dbb92fbee
update message
2023-01-19 15:08:03 -08:00
eb884228a4
warn users if using VirtualBox on macOS 13+
2023-01-19 15:08:01 -08:00
15bb620ca1
Merge branch 'master' into fix-TestNetworkPlugins-Linux_Docker
2023-01-18 02:43:47 +00:00
1b124462b1
Merge pull request #15611 from afbjorklund/numcpu-docker
...
Allow running docker driver with force on 1 CPU
2023-01-17 10:30:31 -08:00
ba11072162
main: propagate the current Docker CLI context to $DOCKER_HOST
...
So that google/go-containerregistry can pick it up
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2023-01-12 08:13:03 +09:00
24226c5f5a
Merge branch 'master' into fix-TestNetworkPlugins-Linux_Docker
2023-01-10 22:44:50 +00:00
83d4219fee
Allow running docker driver with force on 1 CPU
2023-01-08 18:19:11 +01:00
6e2511d9f1
add example of static IP in docs
2023-01-04 13:22:57 -08:00
149e9a01b6
Merge branch 'master' into fix-TestNetworkPlugins-Linux_Docker
2023-01-04 21:10:29 +00:00
e6d95b8230
implement --static-ip flag
2023-01-04 10:27:00 -08:00
5f18b0d310
wrapped error when validate subnet fails to parse address
2023-01-04 01:27:08 -05:00
474a56b50c
added comments and improved error message for validateSubnet
2022-12-23 08:44:57 -05:00
7466acb3e8
moved bare metal validation to a separate function
2022-12-22 16:11:39 -05:00
37098ababa
added subnet validator and its test cases
2022-12-17 14:40:37 -05:00
4e0994c43e
Merge remote-tracking branch 'upstream/master' into fix-TestNetworkPlugins-Linux_Docker
2022-12-17 17:57:34 +00:00
72c8acc370
fix Docker_Linux and multinode
2022-12-13 03:35:16 +00:00
ff95fc7dc9
change cpus config field to string to support max value
2022-12-07 10:53:16 -08:00
63934002d8
update golang.org and godoc.org links
2022-11-30 10:49:57 -08:00
2a86770a92
Merge branch 'master' into master
2022-11-17 09:58:49 -05:00
c4c05a78eb
Remove startup error message on older version of ISO, sent to log instead
2022-11-17 09:51:23 -05:00
a5de48aef9
Merge pull request #15308 from Juneezee/test/t.Setenv
...
test: use `T.Setenv` to set env vars in tests
2022-11-16 14:32:54 -05:00
a800f27580
move license command to other section in help
2022-11-16 11:21:00 -05:00
ccb569fabf
Merge pull request #15336 from prezha/fix-kubelet-localStorageCapacityIsolation-option
...
fix kubelet localStorageCapacityIsolation option
2022-11-14 09:54:22 -08:00
28beac4edb
fix kubelet localStorageCapacityIsolation option for different k8s versions
2022-11-09 22:56:29 +00:00
3198d106dc
Renamed validateKicBaseVersion, fixed PR comments.
2022-11-09 09:40:10 -05:00
9d85be1a99
test: use `T.Setenv` to set env vars in tests
...
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.Setenv
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-11-08 10:30:29 +08:00
e2679ccd7a
add additional memory overhead for VirtualBox
2022-11-07 16:06:55 -05:00
bd11be75b8
Merge branch 'master' into master
2022-11-04 14:07:20 -04:00
8bd593b433
Merge pull request #15266 from spowelljr/detectSocket
...
Auto select network on QEMU
2022-11-04 09:38:09 -07:00
ea8fd6c619
Merge pull request #15281 from spowelljr/fixAddonEnableMessages
...
Prevent enabling `efk` addon due to containing Log4j CVE
2022-11-04 09:36:59 -07:00
43c4e59a60
disable efk addon
2022-11-03 16:38:59 -07:00
d7baa13960
fix spelling and grammar in Go files
2022-11-03 18:31:44 -04:00
00486c3fd6
Merge branch 'master' into master
2022-11-02 15:09:58 -04:00
320c41f80e
Added version.json to kicbase image and version validation to start.go.
...
Added CHANGELOG to kicbase and ISO.
Updated gh to latest version 2.18.1.
2022-11-02 14:17:41 -04:00
3568d657ab
auto select network on QEMU
2022-11-01 14:18:43 -07:00
074e681975
Merge pull request #15160 from agarwalnit/master
...
Added cloud-spanner emulator add-on.
2022-10-28 13:58:41 -07:00
253c006721
Merge pull request #15126 from spowelljr/dockerDesktopLinux
...
use port forwarding on Linux with Docker Desktop
2022-10-25 11:04:03 -07:00
909ac67151
Added cloud-spanner emulator add-on.
2022-10-20 23:16:53 +00:00
289e3bcbf2
change command to license
2022-10-20 10:51:27 -07:00
643fed94f1
added link to Docker Engine instructions
2022-10-18 10:00:23 -07:00
8905963ff9
add credits command
2022-10-17 15:22:33 -07:00
33ad232606
add warning to users using Docker Desktop on Linux
2022-10-12 15:23:01 -07:00
6bcef35331
exit if mounting with user network
2022-10-11 14:29:33 -07:00
f981dd1527
Merge pull request #15081 from klaases/warn1
...
Warn if addon has no associated Github username
2022-10-10 10:12:31 -07:00
399a60eb86
Merge pull request #15085 from spowelljr/fixPortValidation
...
Allow passing only exposed port to --ports
2022-10-07 14:39:43 -07:00
26ff0aa2d2
allow only passing exposed port to --ports
2022-10-07 10:56:58 -07:00
f6d3bf0515
remove check for unknown maintainer
2022-10-06 16:25:50 -07:00
43d0753d78
warn if addon has no associated github username
2022-10-06 16:11:53 -07:00
6d00b3e89a
mark as unpaused on start & renaming/comments
2022-10-06 14:27:34 -07:00
f1b909e44d
add darwin conditionals
2022-10-03 15:17:29 -07:00
5c27bc4d11
update messaging if using user network
2022-10-03 15:17:29 -07:00
5fc653ba83
update experimental message and logic
2022-10-03 15:14:39 -07:00
ad1951ab80
rename socket to socket_vmnet
2022-10-03 15:14:39 -07:00
8c12c40853
implement socket_vmnet
2022-10-03 15:14:36 -07:00
ab9130bf2d
Merge pull request #14951 from spowelljr/fixLinuxAddressBinding
...
Use SSH tunnel if user specifies bindAddress
2022-10-03 11:31:31 -07:00
9fdb6d9bd6
convert another to os.Stdout.Write
2022-09-30 17:06:43 -07:00
78a64e2534
add update check on status and profile list
2022-09-30 16:53:34 -07:00
b25b13f3f1
close channels in defer
2022-09-29 13:35:10 -07:00
1ba9792419
fix update check logic
2022-09-21 16:06:21 -07:00
847b7731c6
improve warning wording
2022-09-20 16:42:38 -07:00
19f0b18357
issue warning for qemu with socket_vmnet flagset
2022-09-20 16:42:38 -07:00
787685e073
allow network flag with qemu
2022-09-20 16:42:38 -07:00
87175c7395
revert changes
2022-09-20 16:42:21 -07:00
5b7e19e172
fix socketVMnetPath
2022-09-20 16:41:13 -07:00
18fda4be13
add socket vmnet and client path flags
2022-09-20 16:41:13 -07:00
ef31fc272c
disable bail on qemu service
2022-09-20 16:41:13 -07:00
012146bdbc
use SSH tunnel if user specifies bindAddress
2022-09-14 11:57:28 -07:00
6002db244e
fix error message
2022-09-12 11:30:58 -07:00
2482b4e4de
fix unit tests on macOS arm64
2022-08-08 10:20:13 -07:00
744187868d
fix linting
2022-08-08 09:29:19 -07:00
87d7e3b423
Merge pull request #14695 from spowelljr/limitAuditSize
...
Limit number of audit entries
2022-08-02 10:15:53 -07:00
66ff960b61
limit number of audit entries
2022-08-01 14:16:28 -07:00
13680ff987
fix linting
2022-08-01 23:00:25 +05:30
5b2080f782
Fix url index out of range error in service
...
* if there is no node port, service panics accessing url
* since the length of array is 3 when there is no node port, accessing u[3] results in
index out of range
2022-07-28 12:56:05 +05:30
0d274d5603
Merge pull request #14499 from inifares23lab/master
...
add VerifiedMaintainer field to Addons and display a warning if empty
2022-07-25 17:00:41 -07:00
7dfe7e65e4
when enable addons differentiate message for maintainer and verified maintainer
2022-07-20 21:00:35 +02:00
a2a814fa8b
Merge pull request #14589 from spowelljr/toolTip
...
Update docker-env description and add tooltip
2022-07-15 13:38:46 -07:00
8fd532dd3a
Merge pull request #14522 from kinvolk/fix_headlamp_tip
...
Fix Post installation tip for headlamp addon
2022-07-15 13:18:18 -07:00
d9263acf8d
Fix Post installation tip for headlamp
...
Signed-off-by: Santhosh Nagaraj S <santhosh@kinvolk.io>
2022-07-15 15:18:56 +05:30
af662f6b3a
update wording
2022-07-14 14:22:11 -07:00
d49a6c8ccf
update docker-env description and add tooltip
2022-07-14 10:52:46 -07:00
d89f43518e
fix incorrect user and profile in audit logging
2022-07-12 11:40:58 -07:00
21e00cf796
formatting with 'gofmt -w -s .'
2022-07-06 23:21:51 +02:00
75a2631baf
update start help info
...
Indicate --network-plugin flag is deprecated in flag description
2022-07-04 11:17:21 +08:00
dfb4860cec
display warning for addons with unverified Maintainer
2022-07-03 14:42:40 +02:00
f60aa26c8b
prbot need a strike
2022-06-27 09:50:27 +08:00
360cc86ce5
fix: panic when environment variables are empty
...
On mac OS, environment variables like: OLDPWD are usually empty. May trigger panics like:
```bash
😄 minikube v1.26.0 on Darwin 11.6.5
panic: runtime error: index out of range [1] with length 1
goroutine 1 [running]:
k8s.io/minikube/cmd/minikube/cmd.displayEnviron({0xc000a69a40?, 0x1c, 0xb?})
/private/tmp/minikube-20220623-65769-c2xa25/cmd/minikube/cmd/start.go:445 +0x252
k8s.io/minikube/cmd/minikube/cmd.runStart(0x7316040?, {0x5d07e13?, 0x0?, 0x0?})
/private/tmp/minikube-20220623-65769-c2xa25/cmd/minikube/cmd/start.go:157 +0x245
github.com/spf13/cobra.(*Command).execute(0x7316040, {0x73736d8, 0x0, 0x0})
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/cobra@v1.5.0/command.go:876 +0x67b
github.com/spf13/cobra.(*Command).ExecuteC(0x7313fc0)
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/cobra@v1.5.0/command.go:990 +0x3b4
github.com/spf13/cobra.(*Command).Execute(...)
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/cobra@v1.5.0/command.go:918
k8s.io/minikube/cmd/minikube/cmd.Execute()
/private/tmp/minikube-20220623-65769-c2xa25/cmd/minikube/cmd/root.go:170 +0xca5
main.main()
/private/tmp/minikube-20220623-65769-c2xa25/cmd/minikube/main.go:88 +0x255
```
2022-06-24 22:09:40 +08:00
90fabe158e
fix grammar for common minikube start output
2022-06-22 12:13:31 -07:00
6405bb3185
Merge pull request #14323 from lakshkeswani/master
...
Don't allow --control-plane=true for node add #14300
2022-06-21 11:02:03 -07:00
e5754a2a7a
Merge pull request #14315 from kinvolk/headlamp_addon
...
Addon: add headlamp
2022-06-21 10:37:06 -07:00
9fe8946e66
Made changes so that we get logs when a command starts no matter that it is finished or not
2022-06-16 12:58:06 -07:00
cc1fba4411
Don't allow --control-plane=true for node add
2022-06-16 11:31:45 +00:00
26afc8f85c
Addon: add headlamp
...
Signed-off-by: Santhosh Nagaraj S <santhosh@kinvolk.io>
2022-06-16 10:34:18 +05:30
98c0e9f6c8
Merge pull request #14265 from sharifelgamal/arm64-containerd
...
Reduce package duplication for ISO building
2022-06-13 16:22:33 -07:00
6da1a20932
Merge pull request #14301 from sharifelgamal/gcp-auth-timeout
...
don't special case gcp-auth for enabling addons
2022-06-13 10:47:04 -07:00
1801630196
Merge branch 'master' of github.com:kubernetes/minikube into arm64-containerd
2022-06-10 17:02:58 -07:00
bc03821826
Fix typos
2022-06-10 15:26:35 -07:00
24e2708d91
Merge branch 'master' of github.com:kubernetes/minikube into gcp-auth-timeout
2022-06-10 13:40:07 -07:00
b475b2526d
Merge branch 'master' of github.com:kubernetes/minikube into arm64-containerd
2022-06-09 09:44:43 -07:00
7c4389c68b
update image prefix
2022-06-08 14:31:44 -07:00
94dd7296d7
Merge branch 'master' of github.com:sharifelgamal/minikube into gcp-auth-timeout
2022-06-08 10:37:18 -07:00
1f763354ca
Merge pull request #12995 from eliaskoromilas/fpga-operator
...
InAccel FPGA Operator addon
2022-06-07 15:32:44 -07:00
8d60734670
small fixes
2022-06-07 12:52:39 -07:00
b465bac75d
Merge pull request #14283 from sharifelgamal/custom-firmware
...
allow users to supply custom QEMU firmware path
2022-06-06 15:36:23 -07:00
7b890545b4
Update cmd/minikube/cmd/start_flags.go
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2022-06-06 12:54:56 -07:00
9cc18c0aa6
allow users to supply custom QEMU firmware path
2022-06-06 12:43:59 -07:00
dfa371652b
Update docs usage output
2022-06-04 16:58:50 +02:00
ce08c0bcee
Conditionally append docs to tData
2022-06-04 16:58:50 +02:00
fa3ec1433f
Add test for disabled/enabled docs
2022-06-04 16:58:50 +02:00
8be1b154ae
Print doc only with enabled option
2022-06-04 16:58:50 +02:00
967b439993
Use "3rd party (maintainer)" across all strings
2022-06-04 16:56:41 +02:00
216b63060f
Add doc URL to the addon list table
2022-06-04 16:56:41 +02:00
5fb961c517
Merge pull request #14245 from te-simonren/pr-add-bind-address-for-tunnel
...
add bind address option for cmd tunnel
2022-06-03 10:00:32 -07:00
b7b5395138
turn off crio for qemu for now
2022-06-02 13:07:18 -07:00
a23d47b569
add active field in config.Profiles
...
Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>
2022-06-01 15:28:50 +05:30
066f731654
enhance: add json key for profile list cmd
...
Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>
2022-06-01 15:28:50 +05:30
2dc84b1dcd
enhance: add active column for profile list cmd
...
Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>
2022-06-01 15:28:50 +05:30
2813810bbd
generate doc & opt option string
2022-06-01 10:07:05 +08:00
1e7c257136
Merge branch 'master' of github.com:sharifelgamal/minikube into arm64-containerd
2022-05-31 14:44:53 -07:00
4ab16708f4
reconcile translations after extracting escape characters fix
2022-05-31 13:17:46 -07:00
cd01efdf37
upgrade conmon to v2.0.24
2022-05-31 10:43:55 -07:00
31843939d8
add bind address option for cmd tunnel
2022-05-27 13:50:23 +08:00
6364518066
Add inaccel/fpga-operator addon
...
Signed-off-by: Elias Koromilas <elias.koromilas@gmail.com>
2022-05-26 10:52:08 +03:00
cf3d33aef6
include prereleases
2022-05-20 17:32:30 +01:00
899b43c323
move to 'config defaults'
2022-05-20 17:32:30 +01:00
219abcc1f1
fix json and yaml outputy
2022-05-20 17:32:30 +01:00
Om Saran
swastik959
Medya Gh
Ben Krieger
Medya Ghazizadeh
Steven Powell
Nick Mancari
nickmancari
Sudharsan Rangarajan
Predrag Rogic
Akihiro Suda
Anders F Björklund
Shubh Bapna
Chris Kannon
ckannon
Steven Powell
Eng Zer Jun
Rahil Patel
Nitin Agarwal
klaases
anoop142
inifares23lab
Santhosh Nagaraj S
peizhouyu
zhouguowei
吴梓铭
Sharif Elgamal
Nikhil Sharma
lakshkeswani
Sharif Elgamal
Kian-Meng Ang
Jack Zhang
Nils Fahldieck
Harsh Vardhan
simonren-tes
Elias Koromilas