Commit Graph

2888 Commits (80a3435e1f64288f5813b0446fbc3b19fa3b961c)

Author SHA1 Message Date
Sharif Elgamal 96923883e7 fixes for ingress 2021-09-09 13:47:01 -07:00
Steven Powell 3e25ee3dfe
Merge pull request #12381 from jayesh-srivastava/master
Updated version.go with crun version
2021-09-09 10:51:33 -07:00
Steven Powell 9d940e234f ask user for config values even if already set 2021-09-08 12:19:48 -07:00
Sharif Elgamal 738eb5177c
Merge pull request #12231 from sharifelgamal/gcp-cs
gcp-auth: improve flow for GCE/Cloud Shell
2021-09-01 13:20:06 -07:00
Medya Ghazizadeh 3469c77ffa
Merge pull request #12351 from raghavendra-talur/rtalur-add-disks-kvm2
Add `--extra-disks` capability to kvm2 driver
2021-08-30 16:50:58 -07:00
Pablo Caderno 69a5a9383c Refactored code into functions. Added tests 2021-08-31 09:16:37 +10:00
Jayesh Srivastava eb78bb7602
Update version.go 2021-08-30 23:23:30 +05:30
Akihiro Suda 323225483e
Support Rootless Docker
Requirements:
- Install rootless Docker 20.10 or later, see https://rootlesscontaine.rs/getting-started/docker/
- Enable cgroup v2 delegation, see https://rootlesscontaine.rs/getting-started/common/cgroup2/

Usage: `minikube start --driver=docker --container-runtime=containerd`.
The `--container-runtime` flag needs to be set to "containerd".
CRI-O can be also supported later.

Closes issue 10836 ("add support for rootless Docker").

Support for rootless Podman (issue 8719) is not covered in this commit.

---

Code reading guide:
- `deploy/kicbase/Dockerfile`: updated to install fuse-overlayfs and containerd-fuse-overlayfs, which is used
  instead of `overlayfs` snapshotter

- `deploy/kicbase/entrypoint`: updated to verify cgroup v2 delegation.
  Mostly from 8a83ee46b2/images/base/files/usr/local/bin/entrypoint

- `cmd/minikube/cmd/start_flags.go`: updated to set `KubeletInUserNamespace` feature gate when rootless

- `pkg/drivers/kic/oci`: updated to use port forwarding, because rootless container IPs are not reachable from the host

- `pkg/minikube/cruntime`: updated to generate `/etc/containerd/config.toml` with rootless support.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2021-08-27 17:21:53 +09:00
Sharif Elgamal 55c40f8220 Merge branch 'master' of github.com:kubernetes/minikube into gcp-cs 2021-08-26 13:32:10 -07:00
Medya Ghazizadeh 527a3d920f
Merge pull request #12265 from prezha/fix-image-save-cmd
fix image save cmd
2021-08-25 10:45:08 -07:00
Raghavendra Talur dceb676527 Add extra disks capability to kvm2 driver
Having additional disks on the nodes is a requirement for developers
working on the storage components in Kubernetes. This commit adds the
extra-disks feature to the kvm2 driver.

Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
2021-08-25 00:15:02 -04:00
Medya Ghazizadeh 01155b1537
Merge pull request #12319 from andriyDev/UseWSLIP
Select WSL VM IP when performing mounting
2021-08-24 10:40:32 -07:00
Predrag Rogic 6efbd1ce13
merge 2021-08-24 04:20:52 +01:00
Sharif Elgamal 42d3f3b92f Merge branch 'master' of github.com:kubernetes/minikube into gcp-cs 2021-08-23 15:40:30 -07:00
Sharif Elgamal 8470a955db error handling\! 2021-08-23 14:06:23 -07:00
Sharif Elgamal 32577cc801 Merge branch 'master' of github.com:kubernetes/minikube into cs-start-stop 2021-08-23 14:02:24 -07:00
Sharif Elgamal 4bc5cb77d1 Merge branch 'master' of github.com:sharifelgamal/minikube into gcp-cs 2021-08-23 11:11:16 -07:00
Anders F Björklund 817f8b4b70 Add also stand-alone image push matching pull
Normally this is done as part of image build
2021-08-22 20:11:19 +02:00
Anders F Björklund 380b846715 Add stand-alone image pull and image tag commands
Needed for testing, but maybe elsewhere as well
2021-08-22 19:52:07 +02:00
Sharif Elgamal fe6cbc4e42 add extra options to minikube start directly 2021-08-20 15:34:53 -07:00
Sharif Elgamal 69d5d34eeb
Merge pull request #12089 from zhan9san/feature/ingress-mac
Support Ingress on MacOS, driver docker
2021-08-20 15:16:13 -07:00
Andriy Dzikh 405235908d Fix lint. 2021-08-20 15:06:24 -07:00
Andriy Dzikh 47afdc87df Add logging message incase someone tries to debug. 2021-08-20 11:42:17 -07:00
Andriy Dzikh 2f094d117d Use WSL VM IP for mounting in WSL. 2021-08-20 11:41:44 -07:00
Jack Zhang def3f067a8 Support Ingress on MacOS, driver docker 2021-08-17 10:27:21 +08:00
Anders F Björklund 9e588e6ba1 Add stand-alone image pull and image tag commands
Needed for testing, but maybe elsewhere as well
2021-08-15 20:22:24 +02:00
Pablo Caderno 1f83aa3ac2 Added port validation 2021-08-14 15:48:56 +10:00
Anders F Björklund 68197de861
Add command to save images from the cluster
This is the opposite command of "minikube image load",
and can be used after doing a "minikube image build".

The default is to save images in the cache, but it is
also possible to save to files or to standard output.
2021-08-13 23:28:25 +01:00
Anders F Björklund 5bd3f9a79c Add tests for the new docker-env output formats 2021-08-13 23:32:03 +02:00
Anders F Björklund 4f8adb6f6d Add output parameter to the docker-env none shell
Allows structured output as json and yaml, in addition to the
previous text output format. Note that keys might not be sorted.
2021-08-13 23:31:05 +02:00
Sharif Elgamal 235d7e8280 Merge branch 'master' of github.com:kubernetes/minikube into gcp-cs 2021-08-13 14:15:31 -07:00
Sharif Elgamal 371becaf73 tMerge branch 'master' of github.com:kubernetes/minikube into gcp-cs 2021-08-13 14:08:23 -07:00
Medya Ghazizadeh 0bd906077f
Revert "new `image save` command" 2021-08-13 14:06:42 -07:00
Sharif Elgamal 06ed3378b9 create special error to skip addons without erroring out 2021-08-13 13:42:02 -07:00
Medya Ghazizadeh 41ba49d597
Merge pull request #12162 from afbjorklund/image-save-cmd
Image save command
2021-08-13 13:02:58 -07:00
Medya Gh 6aa7abc24a fix lint issues on master 2021-08-12 17:38:24 -07:00
Anders F Björklund b75bf27942 Add command to save images from the cluster
This is the opposite command of "minikube image load",
and can be used after doing a "minikube image build".

The default is to save images in the cache, but it is
also possible to save to files or to standard output.
2021-08-10 09:49:23 +02:00
Anders F Björklund 2ab5c86a88 Build images on the primary control plane
Allow selecting another node using --node

Or continue build on all nodes with --all
2021-08-06 19:04:51 +02:00
Anders F Björklund 6e571d830f Show data with keys sorted instead of random 2021-08-01 10:23:46 +02:00
Anders F Björklund 4f6ee47f28 Remove extra output lines after the version
Some commands, like crio and runc, dump extra line noise
after the --version even though they have a long version.
2021-08-01 10:23:42 +02:00
Anders F Björklund 46c3797169 Show cli versions instead of daemon versions
Since the server daemon might not be running

This affects docker and containerd runtimes
2021-08-01 10:22:05 +02:00
Blaine Gardner 8f05ee00e1
Add ability to create extra disks on hyperkit vms
Add the ability to create and attach extra disks to hyperkit vms.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-07-28 09:57:20 -06:00
Medya Ghazizadeh 3375c39c76
Merge pull request #11981 from de-sh/vb-warn
Add message to discourage the use of the virtualbox driver
2021-07-26 17:30:38 -07:00
Vishal Jain 7cda4bb986 Fix lint error. 2021-07-25 15:27:05 -07:00
Vishal Jain 5caf53c004 Cleanup ticker allocations. 2021-07-25 15:14:21 -07:00
Andriy Dzikh 36cc7e0a70 Have cluster.Mount return an error which is checked in advice.go. 2021-07-22 10:38:57 -07:00
Andriy Dzikh 49cd3840d3 Create advice for mount command timing out. 2021-07-14 15:38:04 -07:00
Andriy Dzikh 354fedb073 Add command-line argument port for mount cmd. 2021-07-14 15:00:03 -07:00
Devdutt Shenoi 0e665930e8 Add message to discourage the use of virtualbox driver 2021-07-14 15:00:22 +05:30
dmpe 0c721cbacd remove whitespace 2021-07-12 20:23:07 +02:00
dmpe a60b337237 fix an issue with hasPorts variable - further simplification 2021-07-12 20:15:21 +02:00
dmpe 6ccc6e7659 Merge branch 'master' into mytests 2021-07-12 19:57:21 +02:00
Steven Powell 961bbbe0aa
Merge pull request #11553 from zigarn/dashboard-set-port
Allow to set the dashboard proxyfied port
2021-07-12 16:53:32 +00:00
Medya Ghazizadeh cabf73ed59
Merge pull request #11800 from mahalrs/simplify-error-codes-11786
Simplify, and remove all un-used minikube error codes
2021-07-06 19:48:12 -04:00
dmpe 12f2d69259 Merge remote-tracking branch 'upstream' into mytests 2021-07-06 12:13:06 +02:00
Alexandre Garnier e63b223be9 Add dashboard port validation 2021-07-03 15:59:59 +02:00
Alexandre Garnier f76b0795d8 Allow to set the dashboard proxyfied port 2021-07-03 15:59:59 +02:00
Steven Powell f684ae4c5e
Merge pull request #11875 from mahalrs/flag-typo
Fix typo in pause command
2021-07-02 17:14:42 +00:00
Rajwinder Mahal cd1db56f87
Fix typo in unpause command 2021-07-01 22:19:37 -07:00
Rajwinder Mahal 75422a844c
Fix typo in pause command 2021-07-01 16:23:07 -07:00
Sharif Elgamal 494a24abcc
Merge pull request #11834 from andriyDev/AutoPause
Add support for other container runtimes for auto-pause
2021-07-01 16:01:27 -07:00
Rajwinder Mahal 659e8c2785
Replace InternalEnable and InternalDisable with InternalAddonEnable and InternalAddonDisable 2021-07-01 14:52:24 -07:00
Sharif Elgamal 85e27c5820
Merge pull request #11773 from sharmarajdaksh/add-error-code-explanations
Adds explanations for all minikube error codes
2021-07-01 14:33:15 -07:00
Andriy Dzikh 574cdb9587 Add --container-runtime flag to auto-pause. 2021-07-01 13:11:12 -07:00
Medya Gh 61e06d77bd fix boilerplate 2021-07-01 15:21:32 -04:00
Medya Gh f35d99a2bb add --components flag for verion command 2021-07-01 15:21:30 -04:00
Sharif Elgamal 99ba231b50
Merge pull request #11819 from spowelljr/fixKubectlDirectCall
windows: support renaming binary to `kubectl.exe` and  running as kubectl
2021-07-01 11:03:04 -07:00
Dakshraj Sharma d8adc48463 Adds explanations for minikube error codes 2021-07-01 23:22:23 +05:30
Steven Powell fdca7d6844 support renaming binary to kubectl.exe and running as kubectl 2021-06-30 20:41:11 +00:00
Medya Gh 89c7853601 bump go mod libs manually 2021-06-29 15:24:59 -04:00
Steven Powell e8b3db9485
Merge pull request #11692 from spowelljr/addNoLimit
Add ability to pass 'max' value to memory and cpus flags
2021-06-28 17:09:32 +00:00
Medya Ghazizadeh 512ae30449
Merge pull request #11753 from andriyDev/AddonMaintainers
Add maintainer column to addons list
2021-06-25 18:42:51 -04:00
Steven Powell cae8f40eaf fixed validation for cpus 2021-06-25 10:49:29 -07:00
Steven Powell 68cd71aea7 fix --cpus=max for non-KIC drivers 2021-06-25 10:49:28 -07:00
Steven Powell 6799b19972 use constant for flag description 2021-06-25 10:49:28 -07:00
Steven Powell a2ae86cb7c renamed flag value from nolimit to max 2021-06-25 10:49:28 -07:00
Steven Powell c2e2546f9b fixed linting issues 2021-06-25 10:49:28 -07:00
Steven Powell 4871d68d8c add ability to pass nolimit value to memory and cpus flags 2021-06-25 10:49:28 -07:00
Andriy Dzikh b5df84a707 Add maintainer column to addons list. 2021-06-24 10:11:38 -07:00
Ilya Zuyev b2d46e51a1 Update message about running amd64 binary on M1 2021-06-21 18:38:47 -07:00
Ilya Zuyev b10a7a1b9e Merge branch 'master' into ilyaz/m1_amd64 2021-06-21 18:35:00 -07:00
Sharif Elgamal cf4078ad1a
Merge pull request #11576 from JacekDuszenko/fix-embed-certs-from-config
Fix embed-certs global config
2021-06-21 11:33:11 -07:00
Medya Ghazizadeh b9c363001d
Merge pull request #11668 from daehyeok/remove_config_options
Remove unused config options
2021-06-21 12:42:23 -04:00
Medya Ghazizadeh c7c06e84f4
Merge pull request #11678 from RA489/regis_mirror
change registery_mirror to registery-mirror
2021-06-21 11:55:19 -04:00
Sharif Elgamal 811ff18161
Merge pull request #11677 from sharifelgamal/auto-gen-docs
Automatically run `make generate-docs` after every PR merge
2021-06-18 14:30:08 -07:00
Daehyeok Mun cd1adcf35d Remove unused config options 2021-06-18 11:54:47 -04:00
Medya Ghazizadeh 54d825068c
Merge pull request #11423 from vishjain/user/vishal/delete-profiles/main
Added Mock of Minikube Delete Profiles Test portion.
2021-06-17 13:02:18 -04:00
RA489 48709efc4d change registery_mirror to registery-mirror 2021-06-17 15:15:04 +05:30
Sharif Elgamal f7cb9286f6 only test for missing docs string 2021-06-16 10:06:11 -07:00
Sharif Elgamal 7b5381b697 add generate-docs script 2021-06-16 09:23:54 -07:00
Ilya Zuyev 32cd4cb12b Allow running amd64 bianry on M1 2021-06-15 15:30:12 -07:00
Dongjoon Hyun 4eb3c6332d
Fix a download link to use arm64 instead of amd64 2021-06-14 15:11:49 -07:00
JacekDuszenko b7a6dd0b5e implement embed certs global config as EmbedCerts 2021-06-05 23:59:45 +01:00
dmpe 8badb789e8 smaller documentation fix 2021-06-05 20:59:52 +02:00
dmpe 445684d44d fix(start): minikube start with --image-repository: add new test for URLs with ports, fixing fix validation logic 2021-06-05 20:50:00 +02:00
Vishal Jain 03b793c7d0 Fix names. 2021-06-05 11:18:07 -07:00
Vishal Jain ebe03d7687 Added Mock to DeleteProfile Test. 2021-06-02 19:45:41 -07:00
Vishal Jain 36a6f87600 Added Mock of Minikube Delete Profiles Test portion. 2021-06-02 19:45:41 -07:00
Sharif Elgamal d76259e86f
Merge pull request #11528 from andriyDev/FixDownloadOnlyTest2
Change PreloadExists to report no preload for BareMetal drivers
2021-06-02 12:59:15 -07:00
Sharif Elgamal 343015001a
Merge pull request #11504 from ilya-zuyev/ilyaz/fix_delete_paused
Fix delete command for paused kic driver with containerd/crio runtime
2021-06-01 13:14:05 -07:00
Sharif Elgamal 31417806b7
Merge pull request #11486 from sharifelgamal/gcp-auth-restart
gcp-auth addon: do not reapply gcp-auth yamls on minikube restart
2021-05-27 15:05:34 -07:00
Andriy Dzikh a8136ec322 Move InstallOrUpdate to its own package. 2021-05-27 15:01:58 -07:00
Ilya Zuyev eff0bc7161 trigger build to update github status 2021-05-26 22:02:41 -07:00
Ilya Zuyev 1b562da2b0 apply to crio as well 2021-05-26 17:09:13 -07:00
Ilya Zuyev 2244e26fe4 Merge branch 'master' into ilyaz/fix_delete_paused 2021-05-26 16:58:40 -07:00
Ilya Zuyev 2628f8bb04 fix quoting 2021-05-26 15:27:31 -07:00
Ilya Zuyev 2a7f0dca85 simplify the code 2021-05-26 13:41:10 -07:00
Ilya Zuyev 773500bc74 do not unapuse for docker/crio 2021-05-26 12:49:08 -07:00
Medya Ghazizadeh b1ce37b7b5
Merge pull request #11469 from utkarsh-pro/utkarsh-pro/fix/11171
Support setting addons from environmental variables
2021-05-26 10:19:22 -07:00
Sharif Elgamal 6db4a51cbb swap to --refresh 2021-05-26 09:26:10 -07:00
Ilya Zuyev 4567aaa72f trigger bulid 2021-05-25 18:03:35 -07:00
Medya Ghazizadeh 08a7f20dea
Merge pull request #11481 from medyagh/guest_pro_docker
Unique exit code for when container exists prematurely
2021-05-25 12:40:04 -07:00
Ilya Zuyev 017bd42e17 update logs 2021-05-24 22:52:47 -07:00
Ilya Zuyev 4265887fa9 unpause before delete 2021-05-24 18:54:57 -07:00
Medya Ghazizadeh b3541115b2
Merge pull request #11478 from sharifelgamal/error-codes
Add list of error codes to documentation
2021-05-24 15:25:58 -07:00
Medya Gh 6d8c001a00 spell 2021-05-21 13:57:37 -07:00
Medya Gh 9c9934879c break guest provision when container exists prematurely 2021-05-21 13:34:34 -07:00
Medya Ghazizadeh 3f2170bb51
Merge pull request #11472 from andriyDev/ErrorCodes
Use DRV_NOT_HEALTHY when at least one driver is installed but unhealthy
2021-05-21 11:33:23 -07:00
Sharif Elgamal e89aca810a Add list of error codes to documentation 2021-05-21 11:07:59 -07:00
Andriy Dzikh d59570c1f0 Add DRV_DOCKER_NOT_RUNNING error for cases where specifically docker fails. 2021-05-21 09:43:04 -07:00
Medya Ghazizadeh d0d62a90e5
Merge pull request #11334 from daehyeok/close_asset
Add `Close() error` function into assets.CopyableFile
2021-05-21 09:23:41 -07:00
Utkarsh Srivastava aa99526399
change variable name from addonList to addonListFlag
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-21 13:39:05 +05:30
Daehyeok Mun d6691e796c Add `Close() error` function into assets.CopyableFile
Add `Close` function and implemetions to explicitly close os.File which opend by
NewFileAsset.
2021-05-20 21:05:09 -07:00
Medya Ghazizadeh b5499b4c2a
Merge pull request #11394 from ilya-zuyev/ilyaz/gh_11335_test_net_plugins_false_start
Skip network tests with disabled CNI for containerd/crio runtimes
2021-05-20 16:20:04 -07:00
Steven Powell a60a6e215b
Merge pull request #11387 from vigothehacker/issue-11382
Use the first non flag argument for the log file name instead of the first argument
2021-05-20 15:51:33 -07:00
Ilya Zuyev 5600ee6755 Reorganize functional tests 2021-05-20 14:43:51 -07:00
Andriy Dzikh b2d771cd89 Use unhealthy error code if no driver is picked and any driver is installed but unhealthy. 2021-05-20 14:03:53 -07:00
Utkarsh Srivastava 69b30c06df
change variable name from addonListName to addonList
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-20 22:25:38 +05:30
Utkarsh Srivastava 5a3843b074
replace addonList variable with viper provided data
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-20 21:39:07 +05:30
Ilya Zuyev d185d765a1 update tests 2021-05-19 15:13:21 -07:00
Medya Ghazizadeh 72e8341536
Merge pull request #11431 from briandealwis/resume
Add "resume" as an alias for "unpause"
2021-05-19 15:04:35 -07:00
Ilya Zuyev 03600d9afc Add integration test 2021-05-19 13:25:42 -07:00
Ilya Zuyev 039b727cb9 check if cni is not disabled for containerd/crio 2021-05-18 22:48:14 -07:00
Medya Ghazizadeh e05cad71c4
Merge pull request #11355 from afbjorklund/driver-order
Sort rejected drivers by their preference order
2021-05-17 20:31:34 -07:00
Medya Ghazizadeh cd73e832dd
Merge pull request #11371 from afbjorklund/driver-alternate
Fix error picking non-default alternate drivers
2021-05-17 18:54:43 -07:00
Medya Gh f6a89cea06 goimport 2021-05-17 18:39:09 -07:00
Brian de Alwis 49fb17d9fc Add "resume" as an alias for "unpause" 2021-05-17 18:34:11 -07:00
Anders F Björklund 6d0763648e Keep original preference, for identical priority
Unhealthy drivers have their priority lowered
2021-05-16 09:31:37 +02:00
Anders F Björklund dedfdfbfcf Sort rejected drivers by their preference order
Don't show drivers not being selected by default
2021-05-15 09:41:12 +02:00
ilya-zuyev 2a2ffeb380
Merge pull request #11304 from daehyeok/copy_node
Implement target node option for cp command
2021-05-14 15:59:11 -07:00
Evan Baker eca8a2d540
fix typo in flag documentation: sytemd -> systemd
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
2021-05-14 17:00:03 -05:00
Medya Ghazizadeh 33e26502dd
Merge pull request #11366 from spowelljr/fixImageLoad
`image load`: overwrite same image unless `--overwrite=false`
2021-05-13 21:18:29 -07:00
Daehyeok Mun 7c2e963392 Implement target node option for cp command 2021-05-13 10:47:09 -07:00
VigoTheHacker a086536f38 Merge branch 'kubernetes:master' into issue-11382 2021-05-13 15:15:12 +05:30
Peixuan Ding 7b98243ea3 Add missing apiserver-names config update 2021-05-13 02:02:34 -04:00
Peixuan Ding d156e5cbed Fix TestKubernetesUpgrade
Signed-off-by: Peixuan Ding <pding@freewheel.com>
2021-05-12 21:35:22 -04:00
VigoTheHacker 5246729910 use global variables in logFileName 2021-05-13 06:44:57 +05:30
Steven Powell 9d3ee7e2e1 use overwrite flag for local images 2021-05-12 14:26:34 -07:00
Steven Powell e59ced9029 updated flag description and renamed force arg to overwrite and made it non-optional 2021-05-12 14:26:34 -07:00
Steven Powell 826f1852ab replace over-write with overwrite 2021-05-12 14:26:34 -07:00