Commit Graph

2888 Commits (80a3435e1f64288f5813b0446fbc3b19fa3b961c)

Author SHA1 Message Date
Steven Powell 5ddb53f57b add all mount flags to start command 2021-12-10 11:43:50 -08:00
Steven Powell 9d16d24909
Revert "Refactored to remove config.ExtraOptions" 2021-12-08 13:07:33 -08:00
Steven Powell ed380db035
Merge pull request #13125 from spowelljr/refactorExtraOptions
Refactored to remove config.ExtraOptions
2021-12-08 09:48:53 -08:00
Steven Powell 3cd016b06f added comment and append error to message 2021-12-07 16:56:35 -08:00
Steven Powell 355f431c2d refactored to remove config.ExtraOptions 2021-12-07 16:09:39 -08:00
Medya Ghazizadeh f915d68855
Merge pull request #13110 from medyagh/k8sgomod
gomod: remove depending on k8s.io/kubernetes as a lib
2021-12-07 16:04:23 -08:00
Medya Ghazizadeh c3ea9c298c
Merge pull request #12692 from arrikto/fix-apiserver-ips
Support changing apiserver-ips when restarting minikube
2021-12-07 15:33:24 -08:00
Medya Gh e900c5bb76 replacea all references to kuberentes/cmd to third_party 2021-12-07 14:20:07 -08:00
Sharif Elgamal 30afddc6c1
Merge pull request #13072 from klaases/kstop1
Stop K8s if running, when '--no-kubernetes' flag used
2021-12-06 12:49:20 -08:00
Medya Ghazizadeh f1d63dfcff
Merge pull request #12990 from spowelljr/btrfsErrorMessage
Add advice if user using btrfs storage driver
2021-12-03 16:06:06 -08:00
klaases 47a280bdc7 Fix check for stopping k8s. 2021-12-03 14:15:00 -08:00
Sergio Galvan de3799696d
add support for uppercase
Signed-off-by: Sergio Galvan <sergalma@gmail.com>
2021-12-03 22:35:09 +01:00
Sergio Galvan 9348d6a4f0
support newest for --kubernetes-version 2021-12-03 21:48:11 +01:00
klaases f3186d07d8 Detect whether k8s needs to be stopped. 2021-12-03 12:35:34 -08:00
klaases e468a42e15
Merge branch 'master' into kstop1 2021-12-02 14:43:33 -08:00
klaases 3074132aeb Stop K8s if running, when --no-kubernetes. 2021-12-02 14:35:38 -08:00
Steven Powell c8fbd6e242 typo 2021-12-02 09:39:42 -08:00
Steven Powell 3f8e3dc3ed use oci cache to get storage driver 2021-12-01 16:15:01 -08:00
Steven Powell 592e2b01ca auto set LocalStorageCapacityIsolation for BTRFS 2021-11-30 14:34:57 -08:00
Steven Powell ee75b3c368 add support for port validation with ip 2021-11-23 10:09:14 -08:00
Medya Ghazizadeh 3686ba58f0
Merge pull request #11598 from daehyeok/copy_from
Support copy file from node to local host or between nodes.
2021-11-22 13:42:35 -08:00
Medya Ghazizadeh 119a0f07d7
Merge pull request #12942 from klaases/go5
Exit if --kubernetes-version and --no-kubernetes are specified.
2021-11-22 10:01:21 -08:00
klaases 22bbf5f9bb Add config unset message. 2021-11-19 13:54:57 -08:00
Medya Ghazizadeh 2ab68fb50f
Merge pull request #12977 from medyagh/allflag_cache
fix flag name in cache add
2021-11-18 08:19:29 -08:00
Medya Ghazizadeh 355fe0e2bc
Merge pull request #12976 from spowelljr/outputTunnelHasStarted
Output tunnel has started message so users aren't confused if tunnel is running
2021-11-17 16:05:18 -08:00
Medya Ghazizadeh 43482ee901
Merge pull request #12952 from spowelljr/privOnlyWSL
Only check privileged ports for WSL
2021-11-17 16:03:52 -08:00
Steven Powell 3dfe2a0af9 updated message 2021-11-17 15:43:19 -08:00
Steven Powell 0059bc953f
Merge pull request #12958 from klaases/go6
ensure --memory flag is within syslimit
2021-11-17 18:37:39 -05:00
Medya Gh 64ce5460cf fix flag name in cache add 2021-11-17 15:31:55 -08:00
Steven Powell c470b8db18 output tunnel has started message so users aren't confused if tunnel is running 2021-11-17 15:22:39 -08:00
Medya Ghazizadeh 48424c5393
Merge pull request #11909 from vishjain/user/vishal/memory-leak/master
Cleanup on ticker allocations.
2021-11-17 13:23:54 -06:00
Steven Powell 3c125f10e9
Merge pull request #12972 from mpuckett159/bug/fix-docker-env-typo
Fix typo in help text for minikube docker-env command
2021-11-17 13:51:52 -05:00
Marcus Puckett d831158c0c Fix typo in help text for minikube docker-env
In the help text for the `minikube docker-env` command the suggestions for setting the docker command for Windows (cmd and powershell) don't work as output because if you don't pass the `--shell` flag, it adds a line at the beginning that will cause the cmd example to fail, and doesn't specify that you need to set the flag `--shell powershell` for it to work properly. I've updated the help text to provide a command that will work as expected for both shells.
2021-11-16 22:48:55 -08:00
klaases 227efdd03a Exit if both no-kubernetes and kubernetes-version flags are used together. 2021-11-16 15:53:32 -08:00
klaases 38358b9b63 Return NoKubernetesVersion if noKubernetes is true. 2021-11-16 14:24:02 -08:00
klaases f3f5ae3474 Only check kubernetesVersion flag if noKubernetes is false. 2021-11-16 14:17:29 -08:00
Steven Powell 2a99b2f946 fix out of bound exceptions 2021-11-16 11:40:02 -05:00
klaases e22b8c0709 ensure --memory flag is within syslimit 2021-11-15 13:35:12 -08:00
Pablo Caderno 5594331882 fix: do not let users run --no-kubernetes on the none driver
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2021-11-16 07:06:37 +11:00
Steven Powell 518fd1d6fa update unit test 2021-11-15 12:16:57 -05:00
Steven Powell 81aedea0bd only check privileged ports for WSL 2021-11-15 11:49:59 -05:00
Medya Ghazizadeh 8bd28a6599
Merge pull request #12933 from klaases/go2
update suggestion messaging for --no-kubernetes
2021-11-12 12:21:14 -08:00
Medya Ghazizadeh 80b4e238cf
Merge pull request #12900 from AkihiroSuda/rootless-crio
Support CRI-O runtime with Rootless Docker driver (`--driver=docker --container-runtime=cri-o`)
2021-11-11 16:05:36 -08:00
klaases 532b383f46 Add "minikube image" message. 2021-11-11 14:53:31 -08:00
klaases 4238bc1319 update message by runtime 2021-11-11 14:49:18 -08:00
Medya Ghazizadeh 75e2466cf9
Merge pull request #12923 from sharifelgamal/sched-ctd
fix scheduled stop test for containerd on docker driver
2021-11-11 12:45:12 -08:00
Sharif Elgamal d226d04eab fix schedule stop test for containerd on docker driver 2021-11-10 09:09:50 -08:00
Akihiro Suda d7e728487c
Support CRI-O runtime with Rootless Docker driver
Follow-up to PR 12359 (containerd runtime with Rootless Docker driver).

Usage (needs cgroup v2):
```
dockerd-rootless-setuptool.sh install
docker context use rootless
minikube start --driver=docker --container-runtime=cri-o
```

See site/content/en/docs/drivers/includes/docker_usage.inc

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2021-11-09 16:09:52 +09:00
Sharif Elgamal df14157e9f fix formatting 2021-11-08 17:22:51 -08:00
Sharif Elgamal 93e267c5ae Allow custom cert for ingress to be overwritten 2021-11-08 17:16:00 -08:00