ef31fc272c
disable bail on qemu service
2022-09-20 16:41:13 -07:00
012146bdbc
use SSH tunnel if user specifies bindAddress
2022-09-14 11:57:28 -07:00
6002db244e
fix error message
2022-09-12 11:30:58 -07:00
2482b4e4de
fix unit tests on macOS arm64
2022-08-08 10:20:13 -07:00
744187868d
fix linting
2022-08-08 09:29:19 -07:00
87d7e3b423
Merge pull request #14695 from spowelljr/limitAuditSize
...
Limit number of audit entries
2022-08-02 10:15:53 -07:00
66ff960b61
limit number of audit entries
2022-08-01 14:16:28 -07:00
13680ff987
fix linting
2022-08-01 23:00:25 +05:30
5b2080f782
Fix url index out of range error in service
...
* if there is no node port, service panics accessing url
* since the length of array is 3 when there is no node port, accessing u[3] results in
index out of range
2022-07-28 12:56:05 +05:30
0d274d5603
Merge pull request #14499 from inifares23lab/master
...
add VerifiedMaintainer field to Addons and display a warning if empty
2022-07-25 17:00:41 -07:00
7dfe7e65e4
when enable addons differentiate message for maintainer and verified maintainer
2022-07-20 21:00:35 +02:00
a2a814fa8b
Merge pull request #14589 from spowelljr/toolTip
...
Update docker-env description and add tooltip
2022-07-15 13:38:46 -07:00
8fd532dd3a
Merge pull request #14522 from kinvolk/fix_headlamp_tip
...
Fix Post installation tip for headlamp addon
2022-07-15 13:18:18 -07:00
d9263acf8d
Fix Post installation tip for headlamp
...
Signed-off-by: Santhosh Nagaraj S <santhosh@kinvolk.io>
2022-07-15 15:18:56 +05:30
af662f6b3a
update wording
2022-07-14 14:22:11 -07:00
d49a6c8ccf
update docker-env description and add tooltip
2022-07-14 10:52:46 -07:00
d89f43518e
fix incorrect user and profile in audit logging
2022-07-12 11:40:58 -07:00
21e00cf796
formatting with 'gofmt -w -s .'
2022-07-06 23:21:51 +02:00
75a2631baf
update start help info
...
Indicate --network-plugin flag is deprecated in flag description
2022-07-04 11:17:21 +08:00
dfb4860cec
display warning for addons with unverified Maintainer
2022-07-03 14:42:40 +02:00
f60aa26c8b
prbot need a strike
2022-06-27 09:50:27 +08:00
360cc86ce5
fix: panic when environment variables are empty
...
On mac OS, environment variables like: OLDPWD are usually empty. May trigger panics like:
```bash
😄 minikube v1.26.0 on Darwin 11.6.5
panic: runtime error: index out of range [1] with length 1
goroutine 1 [running]:
k8s.io/minikube/cmd/minikube/cmd.displayEnviron({0xc000a69a40?, 0x1c, 0xb?})
/private/tmp/minikube-20220623-65769-c2xa25/cmd/minikube/cmd/start.go:445 +0x252
k8s.io/minikube/cmd/minikube/cmd.runStart(0x7316040?, {0x5d07e13?, 0x0?, 0x0?})
/private/tmp/minikube-20220623-65769-c2xa25/cmd/minikube/cmd/start.go:157 +0x245
github.com/spf13/cobra.(*Command).execute(0x7316040, {0x73736d8, 0x0, 0x0})
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/cobra@v1.5.0/command.go:876 +0x67b
github.com/spf13/cobra.(*Command).ExecuteC(0x7313fc0)
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/cobra@v1.5.0/command.go:990 +0x3b4
github.com/spf13/cobra.(*Command).Execute(...)
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/spf13/cobra@v1.5.0/command.go:918
k8s.io/minikube/cmd/minikube/cmd.Execute()
/private/tmp/minikube-20220623-65769-c2xa25/cmd/minikube/cmd/root.go:170 +0xca5
main.main()
/private/tmp/minikube-20220623-65769-c2xa25/cmd/minikube/main.go:88 +0x255
```
2022-06-24 22:09:40 +08:00
90fabe158e
fix grammar for common minikube start output
2022-06-22 12:13:31 -07:00
6405bb3185
Merge pull request #14323 from lakshkeswani/master
...
Don't allow --control-plane=true for node add #14300
2022-06-21 11:02:03 -07:00
e5754a2a7a
Merge pull request #14315 from kinvolk/headlamp_addon
...
Addon: add headlamp
2022-06-21 10:37:06 -07:00
9fe8946e66
Made changes so that we get logs when a command starts no matter that it is finished or not
2022-06-16 12:58:06 -07:00
cc1fba4411
Don't allow --control-plane=true for node add
2022-06-16 11:31:45 +00:00
26afc8f85c
Addon: add headlamp
...
Signed-off-by: Santhosh Nagaraj S <santhosh@kinvolk.io>
2022-06-16 10:34:18 +05:30
98c0e9f6c8
Merge pull request #14265 from sharifelgamal/arm64-containerd
...
Reduce package duplication for ISO building
2022-06-13 16:22:33 -07:00
6da1a20932
Merge pull request #14301 from sharifelgamal/gcp-auth-timeout
...
don't special case gcp-auth for enabling addons
2022-06-13 10:47:04 -07:00
1801630196
Merge branch 'master' of github.com:kubernetes/minikube into arm64-containerd
2022-06-10 17:02:58 -07:00
bc03821826
Fix typos
2022-06-10 15:26:35 -07:00
24e2708d91
Merge branch 'master' of github.com:kubernetes/minikube into gcp-auth-timeout
2022-06-10 13:40:07 -07:00
b475b2526d
Merge branch 'master' of github.com:kubernetes/minikube into arm64-containerd
2022-06-09 09:44:43 -07:00
7c4389c68b
update image prefix
2022-06-08 14:31:44 -07:00
94dd7296d7
Merge branch 'master' of github.com:sharifelgamal/minikube into gcp-auth-timeout
2022-06-08 10:37:18 -07:00
1f763354ca
Merge pull request #12995 from eliaskoromilas/fpga-operator
...
InAccel FPGA Operator addon
2022-06-07 15:32:44 -07:00
8d60734670
small fixes
2022-06-07 12:52:39 -07:00
b465bac75d
Merge pull request #14283 from sharifelgamal/custom-firmware
...
allow users to supply custom QEMU firmware path
2022-06-06 15:36:23 -07:00
7b890545b4
Update cmd/minikube/cmd/start_flags.go
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2022-06-06 12:54:56 -07:00
9cc18c0aa6
allow users to supply custom QEMU firmware path
2022-06-06 12:43:59 -07:00
dfa371652b
Update docs usage output
2022-06-04 16:58:50 +02:00
ce08c0bcee
Conditionally append docs to tData
2022-06-04 16:58:50 +02:00
fa3ec1433f
Add test for disabled/enabled docs
2022-06-04 16:58:50 +02:00
8be1b154ae
Print doc only with enabled option
2022-06-04 16:58:50 +02:00
967b439993
Use "3rd party (maintainer)" across all strings
2022-06-04 16:56:41 +02:00
216b63060f
Add doc URL to the addon list table
2022-06-04 16:56:41 +02:00
5fb961c517
Merge pull request #14245 from te-simonren/pr-add-bind-address-for-tunnel
...
add bind address option for cmd tunnel
2022-06-03 10:00:32 -07:00
b7b5395138
turn off crio for qemu for now
2022-06-02 13:07:18 -07:00
a23d47b569
add active field in config.Profiles
...
Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>
2022-06-01 15:28:50 +05:30
066f731654
enhance: add json key for profile list cmd
...
Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>
2022-06-01 15:28:50 +05:30
2dc84b1dcd
enhance: add active column for profile list cmd
...
Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>
2022-06-01 15:28:50 +05:30
2813810bbd
generate doc & opt option string
2022-06-01 10:07:05 +08:00
1e7c257136
Merge branch 'master' of github.com:sharifelgamal/minikube into arm64-containerd
2022-05-31 14:44:53 -07:00
4ab16708f4
reconcile translations after extracting escape characters fix
2022-05-31 13:17:46 -07:00
cd01efdf37
upgrade conmon to v2.0.24
2022-05-31 10:43:55 -07:00
31843939d8
add bind address option for cmd tunnel
2022-05-27 13:50:23 +08:00
6364518066
Add inaccel/fpga-operator addon
...
Signed-off-by: Elias Koromilas <elias.koromilas@gmail.com>
2022-05-26 10:52:08 +03:00
cf3d33aef6
include prereleases
2022-05-20 17:32:30 +01:00
899b43c323
move to 'config defaults'
2022-05-20 17:32:30 +01:00
219abcc1f1
fix json and yaml outputy
2022-05-20 17:32:30 +01:00
88acdd018d
use GetTagName from release
2022-05-20 17:32:30 +01:00
eff4a18375
list all currently supported Kubernetes versions
2022-05-20 17:32:13 +01:00
09365b4b04
Merge pull request #14175 from minikube-bot/auto_bump_golint_version
...
bump golint version
2022-05-16 13:21:06 -07:00
53fdfb286c
implement lint fixes
2022-05-16 12:48:41 -07:00
7292031c08
Merge pull request #13912 from kadern0/issue-12643
...
feat: added configure option to registry-alieases addon
2022-05-16 11:33:40 -07:00
17a8bc4e7b
exit cleanly for unimplmented beta features
2022-05-12 09:44:38 -07:00
00d31d04ba
Merge branch 'master' of github.com:kubernetes/minikube into anders-qemu2
2022-05-11 09:06:36 -07:00
9360f907e3
Accept space before port in DashboardProxy Regex
2022-05-10 09:18:39 -04:00
5b39a46773
Merge branch 'master' of github.com:kubernetes/minikube into anders-qemu2
2022-05-03 14:01:09 -07:00
58eed153fa
Merge pull request #13991 from EdwinWalela/edwin-dev
...
Add --audit flag to minikube logs command
2022-04-22 16:46:10 -07:00
fd718348cd
remove setting event log path on delete
2022-04-22 11:34:14 -07:00
e77e17b9ae
Merge pull request #13979 from spowelljr/deleteJSON
...
Add JSON output to `minikube delete`
2022-04-21 14:06:47 -07:00
caf8e6402e
fix having flag before command cause problems
2022-04-20 15:12:20 -07:00
46849037b2
add --audit flag to minikube logs command
2022-04-20 20:23:07 +03:00
df9b2c8541
add JSON output to delete
2022-04-18 16:52:31 -07:00
2c776978d9
Merge pull request #13856 from t-inu/issue12809
...
Improve description for minikube cache command
2022-04-18 15:54:40 -07:00
18d20407c6
Improve description for minikube cache command
2022-04-14 10:31:54 +00:00
2b5a15fe19
Merge pull request #13957 from klaases/force1
...
Advise user of --force option when using root
2022-04-13 11:42:47 -07:00
a9cf4750b0
Merge pull request #13812 from tyabu12/fix/port-validation
...
Fix port validation error on specifying tcp/udp or range of ports.
2022-04-13 09:01:56 -07:00
d5a3fc48fd
Adjust message for clarity
2022-04-12 15:26:26 -07:00
6787bcf6b2
Advise user of --force option when using root
2022-04-12 15:25:17 -07:00
522c1a3274
feat: added configure option to registry-alieases addon
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2022-04-13 08:01:06 +10:00
ad5c964e6b
Merge pull request #13829 from AkihiroSuda/rootless-podman-take2
...
Support rootless Podman driver, take 2 (Usage: `minikube config set rootless true`)
2022-04-12 11:19:30 -07:00
d21342c69f
Make sure to look for KIC before using oci port
2022-04-05 20:02:08 +02:00
92ab555928
Support rootless Podman driver, take 2
...
Usage:
```
minikube config set rootless true
minikube start --driver=podman --container-runtime=(cri-o|containerd)`
```
Tested on Podman 4.0.2, Ubuntu 21.10.
Needs cgroup v2 (as in Rootless Docker): https://rootlesscontaine.rs/getting-started/common/cgroup2/
See also `site/content/en/docs/drivers/includes/podman_usage.inc`
Fix issue 8719
Fix issue 12460
Replace PR 12901
Changes from PR 12901: `rootless` is now a config property.
In the previous PR, `--rootless` was implemented as a flag for `minikube start`
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2022-04-05 18:49:40 +09:00
6a7f14ea01
Use the right port for docker in qemu driver
2022-04-04 20:18:51 +02:00
2e4ea3c259
replace MkdirTemp with t.TempDir in tests
2022-04-01 19:18:20 -07:00
1aa1f04e9b
remove old build tags
2022-03-30 16:43:29 -07:00
31d1fdae3b
Merge pull request #13730 from presztak/subnet_flag
...
Add 'subnet' flag for docker/podman driver
2022-03-30 16:02:54 -07:00
37e026b149
stop testing olm and warn users about the addon
2022-03-30 10:53:11 -07:00
9549bef504
don't write logs that contain environment variables
2022-03-29 11:09:11 -07:00
6e73112be6
change soft to silent
2022-03-28 16:47:33 -07:00
93bb522986
soft fail when user trying to generate log file if cluster not running
2022-03-28 16:44:16 -07:00
aa007da3fe
Merge pull request #13805 from klaases/autop1
...
Improve autopause error handling
2022-03-25 11:51:16 -07:00
afb3956fdb
Add comment to TestValidatePorts.
2022-03-24 09:34:04 +09:00
1832ed6ff5
Update validatePorts function comment for goDoc.
2022-03-23 13:21:33 +09:00
5a3877cfc5
Prefer out.Styled to out.Step, revert copyright
2022-03-21 11:49:26 -07:00
513a757ca7
Fix port validation error on specifying tcp/udp or range of ports.
2022-03-19 10:51:43 +09:00
deb5a574b6
bump golangci-lint to v1.45.0
2022-03-18 19:57:22 +00:00
f549634f59
Improve autopause error handling
2022-03-16 14:36:51 -07:00
76d97af2a0
add disable-metrics flag
2022-03-16 11:00:20 -07:00
701b4be842
Fix flow to support docker driver properly for mac, for issue #13746
2022-03-09 14:30:49 -05:00
cbdd447543
add 'subnet' flag
2022-02-27 16:56:05 +01:00
70a98e34ab
Merge pull request #13053 from tmcalves/validations_on_image_repository
...
Fixes validation on image repository URL when it contains port but no scheme
2022-02-18 13:42:04 -08:00
a0b30b6d56
fix SIGSEGV in kubectl when k8s not running
2022-02-18 16:24:58 +01:00
a9d3fe2906
Fixes validation on image repository URL when it contains port but not schema
...
Refactor the way validations are done to use regular expression
Explicitly use "auto" as the imageRepo instead of an empty string when URL received is invalid
2022-02-16 21:54:48 +00:00
d6120f131e
Merge pull request #13367 from ckannon/master
...
Adds 'minikube service --all' feature to allow forwarding all services in a namespace
2022-02-09 12:24:54 -08:00
c8d846d6c1
minikube #13075 adds --all feature for service
2022-02-09 10:12:01 -05:00
0d677cb71b
fix documentation typo for minikube image load command
2022-02-08 15:13:24 -08:00
8f41ad572a
Merge pull request #13547 from spowelljr/updateNotifyStructure
...
Update notify package to support `releases-v2.json`
2022-02-07 16:35:07 -08:00
5e54044127
Merge pull request #13354 from nishipy/issue-11627
...
Add exit message for too new Kubernetes version
2022-02-03 15:19:38 -08:00
423b816311
Merge pull request #13251 from afbjorklund/default-runtime
...
Make the default container runtime dynamic
2022-02-02 18:02:05 -08:00
d01c77d816
update notify package to support releases-v2.json
2022-02-02 16:39:57 -08:00
969b5cddf1
Merge pull request #13520 from minikube-bot/auto_bump_golint_version
...
bump golint version to v1.44.0
2022-02-02 15:57:24 -08:00
30b187f04d
Merge pull request #13514 from presztak/service_docker_hard_coded
...
Fix hard coded docker driver in minikube service command
2022-02-01 13:24:45 -08:00
c24818d9b7
lint
2022-02-01 13:21:53 -08:00
634b8030f9
Merge branch 'master' of github.com:kubernetes/minikube into anders-default-runtime
2022-02-01 12:59:09 -08:00
034f55696d
Merge pull request #13326 from gAmUssA/addons/kong
...
[Addon] Kong Ingress Controller
2022-01-31 17:15:54 -08:00
9da7049f8a
Currently, no warn or exit are there even if user specifies
...
any version newer than newestKubernetesVersion.
This fixes the flow as follows:
if not --force:
- Warn but do NOT exit for newer minor version and patch version
- Warn and Exit for newer major version
if --force: Warn but try anyways
2022-01-30 07:27:23 -05:00
dd431d36c2
remove hard coded docker driver
2022-01-30 00:08:23 +01:00
c5b1c56f57
Merge pull request #12835 from presztak/remove_kicbase_image_info
...
Print a message about preserving kicbase image when `minkube delete --purge --all` used
2022-01-27 21:23:27 -08:00
dc1b226562
Update cmd/minikube/cmd/start.go
...
Co-authored-by: Sharif Elgamal <selgamal@google.com>
2022-01-26 15:32:09 +09:00
fa5f67cc95
Merge pull request #13340 from spowelljr/addDisableOptimization
...
Add `--disable-optimizations` flag
2022-01-24 18:51:42 -08:00
398906ebd7
generate-docs
2022-01-24 17:09:11 -08:00
3eaf0f627c
Update cmd/minikube/cmd/start_flags.go
...
Co-authored-by: Medya Ghazizadeh <medyagh@users.noreply.github.com>
2022-01-24 17:07:57 -08:00
3a4b676199
list optimizations in flag
2022-01-24 17:00:26 -08:00
0f9564be88
remove hardcoded docker driver
2022-01-23 22:24:17 +01:00
7aafb2ddce
Add exit message for too new Kubernetes version
2022-01-15 11:18:34 -05:00
4cd3abfcde
add disable-optimizations flag
2022-01-12 13:50:38 -08:00
4a2c97f28a
ability to set a mirror for downloading kubectl, kubelet, & kubeadm
2022-01-12 17:43:33 +01:00
1d857e11de
add binary-mirror flag to start cmd
2022-01-12 17:43:33 +01:00
67f748fc9e
fixing broken addons_list_test
2022-01-11 18:29:09 -05:00
ee43bf8492
grammar
2022-01-06 13:19:32 -08:00
2ddfd60c72
Make warning for running amd64 binary on M1 more visible
2022-01-06 13:15:01 -08:00
c4800a6115
Make the default container runtime dynamic
...
Since the dockershim removal, there is no longer a constant
default container runtime provided by upstream. Only CRI.
2022-01-04 15:03:57 +01:00
b6e2ee2128
Merge pull request #12996 from presztak/listimages_formats
...
Add format flag to the `image ls` command
2021-12-23 12:31:59 -08:00
df2de68c13
Show the version of the cri-dockerd component
2021-12-22 22:25:50 +01:00
84a0e2023c
add format flag for 'image ls' command
2021-12-22 00:57:41 +01:00
a0d4d429e4
Merge pull request #13174 from sharifelgamal/addon-cleanup
...
cleanup addons documentation and image sources
2021-12-15 14:43:37 -08:00
5de765023a
Merge pull request #13124 from sharifelgamal/kicbase-arch
...
fix kicbase dockerfile to allow ppc64le and armv7 archs
2021-12-15 14:08:07 -08:00
aff01abcd1
Update cmd/minikube/cmd/config/addons_list_test.go
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2021-12-15 13:36:21 -08:00
cf73e08262
make the test better
2021-12-14 17:11:00 -08:00
066ee66ba8
fix unit test
2021-12-14 16:28:55 -08:00
b924ca6155
Merge pull request #13147 from Ashwin901/master
...
Improve UI Advice for failing to start for non-installed drivers
2021-12-14 13:52:30 -08:00
c3688b6230
address comments
2021-12-14 12:36:48 -08:00
54c615bd36
remove --mode flag from mount
2021-12-13 15:32:20 -08:00
2d12be02c4
detect arm better
2021-12-13 14:35:16 -08:00
50ed250fce
don't use crio on armv7 either
2021-12-13 13:31:04 -08:00
daa270ec0c
display installed and non-installed drivers in separate lists
2021-12-12 12:28:13 +05:30
5ddb53f57b
add all mount flags to start command
2021-12-10 11:43:50 -08:00
9d16d24909
Revert "Refactored to remove config.ExtraOptions"
2021-12-08 13:07:33 -08:00
ed380db035
Merge pull request #13125 from spowelljr/refactorExtraOptions
...
Refactored to remove config.ExtraOptions
2021-12-08 09:48:53 -08:00
3cd016b06f
added comment and append error to message
2021-12-07 16:56:35 -08:00
da7020aa9c
format error message EVEN BETTER
2021-12-07 16:27:50 -08:00
b9e9df130a
return better error
2021-12-07 16:10:04 -08:00
355f431c2d
refactored to remove config.ExtraOptions
2021-12-07 16:09:39 -08:00
6b7168cf4b
fix kicbase dockerfile to allow ppc64le and armv7 archs
2021-12-07 16:05:32 -08:00
f915d68855
Merge pull request #13110 from medyagh/k8sgomod
...
gomod: remove depending on k8s.io/kubernetes as a lib
2021-12-07 16:04:23 -08:00
c3ea9c298c
Merge pull request #12692 from arrikto/fix-apiserver-ips
...
Support changing apiserver-ips when restarting minikube
2021-12-07 15:33:24 -08:00
e900c5bb76
replacea all references to kuberentes/cmd to third_party
2021-12-07 14:20:07 -08:00
30afddc6c1
Merge pull request #13072 from klaases/kstop1
...
Stop K8s if running, when '--no-kubernetes' flag used
2021-12-06 12:49:20 -08:00
f1d63dfcff
Merge pull request #12990 from spowelljr/btrfsErrorMessage
...
Add advice if user using btrfs storage driver
2021-12-03 16:06:06 -08:00
47a280bdc7
Fix check for stopping k8s.
2021-12-03 14:15:00 -08:00
de3799696d
add support for uppercase
...
Signed-off-by: Sergio Galvan <sergalma@gmail.com>
2021-12-03 22:35:09 +01:00
9348d6a4f0
support newest for --kubernetes-version
2021-12-03 21:48:11 +01:00
f3186d07d8
Detect whether k8s needs to be stopped.
2021-12-03 12:35:34 -08:00
e468a42e15
Merge branch 'master' into kstop1
2021-12-02 14:43:33 -08:00
3074132aeb
Stop K8s if running, when --no-kubernetes.
2021-12-02 14:35:38 -08:00
c8fbd6e242
typo
2021-12-02 09:39:42 -08:00
3f8e3dc3ed
use oci cache to get storage driver
2021-12-01 16:15:01 -08:00
592e2b01ca
auto set LocalStorageCapacityIsolation for BTRFS
2021-11-30 14:34:57 -08:00
7b3860388c
Print a message about preserving kicbase image
...
Print additional info about preserving kicbase image and generates
image deletion command for user when running `minikube delete`.
Message is printed only when `--purge` option is used.
2021-11-25 23:36:59 +01:00
ee75b3c368
add support for port validation with ip
2021-11-23 10:09:14 -08:00
3686ba58f0
Merge pull request #11598 from daehyeok/copy_from
...
Support copy file from node to local host or between nodes.
2021-11-22 13:42:35 -08:00
119a0f07d7
Merge pull request #12942 from klaases/go5
...
Exit if --kubernetes-version and --no-kubernetes are specified.
2021-11-22 10:01:21 -08:00
22bbf5f9bb
Add config unset message.
2021-11-19 13:54:57 -08:00
2ab68fb50f
Merge pull request #12977 from medyagh/allflag_cache
...
fix flag name in cache add
2021-11-18 08:19:29 -08:00
355fe0e2bc
Merge pull request #12976 from spowelljr/outputTunnelHasStarted
...
Output tunnel has started message so users aren't confused if tunnel is running
2021-11-17 16:05:18 -08:00
43482ee901
Merge pull request #12952 from spowelljr/privOnlyWSL
...
Only check privileged ports for WSL
2021-11-17 16:03:52 -08:00
3dfe2a0af9
updated message
2021-11-17 15:43:19 -08:00
0059bc953f
Merge pull request #12958 from klaases/go6
...
ensure --memory flag is within syslimit
2021-11-17 18:37:39 -05:00
64ce5460cf
fix flag name in cache add
2021-11-17 15:31:55 -08:00
c470b8db18
output tunnel has started message so users aren't confused if tunnel is running
2021-11-17 15:22:39 -08:00
48424c5393
Merge pull request #11909 from vishjain/user/vishal/memory-leak/master
...
Cleanup on ticker allocations.
2021-11-17 13:23:54 -06:00
3c125f10e9
Merge pull request #12972 from mpuckett159/bug/fix-docker-env-typo
...
Fix typo in help text for minikube docker-env command
2021-11-17 13:51:52 -05:00
d831158c0c
Fix typo in help text for minikube docker-env
...
In the help text for the `minikube docker-env` command the suggestions for setting the docker command for Windows (cmd and powershell) don't work as output because if you don't pass the `--shell` flag, it adds a line at the beginning that will cause the cmd example to fail, and doesn't specify that you need to set the flag `--shell powershell` for it to work properly. I've updated the help text to provide a command that will work as expected for both shells.
2021-11-16 22:48:55 -08:00
227efdd03a
Exit if both no-kubernetes and kubernetes-version flags are used together.
2021-11-16 15:53:32 -08:00
38358b9b63
Return NoKubernetesVersion if noKubernetes is true.
2021-11-16 14:24:02 -08:00
f3f5ae3474
Only check kubernetesVersion flag if noKubernetes is false.
2021-11-16 14:17:29 -08:00
2a99b2f946
fix out of bound exceptions
2021-11-16 11:40:02 -05:00
e22b8c0709
ensure --memory flag is within syslimit
2021-11-15 13:35:12 -08:00
5594331882
fix: do not let users run --no-kubernetes on the none driver
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2021-11-16 07:06:37 +11:00
518fd1d6fa
update unit test
2021-11-15 12:16:57 -05:00
81aedea0bd
only check privileged ports for WSL
2021-11-15 11:49:59 -05:00
8bd28a6599
Merge pull request #12933 from klaases/go2
...
update suggestion messaging for --no-kubernetes
2021-11-12 12:21:14 -08:00
80b4e238cf
Merge pull request #12900 from AkihiroSuda/rootless-crio
...
Support CRI-O runtime with Rootless Docker driver (`--driver=docker --container-runtime=cri-o`)
2021-11-11 16:05:36 -08:00
532b383f46
Add "minikube image" message.
2021-11-11 14:53:31 -08:00
4238bc1319
update message by runtime
2021-11-11 14:49:18 -08:00
75e2466cf9
Merge pull request #12923 from sharifelgamal/sched-ctd
...
fix scheduled stop test for containerd on docker driver
2021-11-11 12:45:12 -08:00
klaases
Steven Powell
Steven Powell
anoop142
inifares23lab
Santhosh Nagaraj S
peizhouyu
zhouguowei
吴梓铭
Sharif Elgamal
Nikhil Sharma
lakshkeswani
Sharif Elgamal
Kian-Meng Ang
Jack Zhang
Nils Fahldieck
Harsh Vardhan
simonren-tes
Elias Koromilas
Predrag Rogic
ckannon
Medya Ghazizadeh
edwinwalela
Toshiaki Inukai
Pablo Caderno
Anders F Björklund
Akihiro Suda
Tomohito YABU
Piotr Resztak
Tiago Alves
Todd MacIntyre
Medya Gh
nishipy
nishipy
Viktor Gamov
Ashwin901
Sergio Galvan
klaases
Marcus Puckett