Commit Graph

219 Commits (3ffdaf3c1c6c674e439f3fc5ecebcc196da93d41)

Author SHA1 Message Date
Medya Ghazizadeh 7bb085ad24
Merge pull request #5003 from medyagh/kubeconfig
Refactor Kubeconfig
2019-08-13 14:57:49 -07:00
Thomas Strömberg 345ed1b85d
Merge pull request #5025 from blueelvis/4996-fix-download-progress-bars
Upgrade cheggaaa/pb from v1.0.27 to v3.0.1
2019-08-12 08:31:20 -07:00
Pranav Jituri 42f5b11fb3
Fixed as per review comments 2019-08-10 12:48:49 +05:30
Thomas Stromberg 7c865c27cf Merge DefaultMinikubeDirectory with GuestPersistentDir 2019-08-09 15:19:23 -07:00
Thomas Stromberg 2f1a11d8d3 Move reusable files (images, binaries, certs) to /data 2019-08-09 15:04:07 -07:00
Medya Gh 9ab4892806 move test data 2019-08-09 12:19:58 -07:00
Medya Gh df624349c3 created kubeconfig package 2019-08-09 12:18:33 -07:00
Sharif Elgamal 1f48364487
Fix prepareNone and add integration test for it (#5023)
* Fix prepareNone and add integration test for it

* add test file

* only compile none test on linux

* build tags are confusing

* build tags are quite confusing

* build tags are very confusing
2019-08-08 15:47:44 -07:00
Pranav Jituri 7fa4e054f3
Fixed the progress bars ^_^ 2019-08-09 04:02:29 +05:30
tstromberg 08d97cf025 Use a temp dest to atomically download the iso 2019-08-06 16:01:06 -07:00
Medya Ghazizadeh 551b164017
Merge pull request #4941 from josedonizetti/add-kubeconfig-tests
wip: Improve coverage: add kubeconfig tests
2019-08-06 10:38:04 -07:00
Thomas Stromberg 38410704ed Document 78 2019-08-05 16:32:54 -07:00
Thomas Stromberg 2540253bcb Indent progress bar & set width to 78 columns 2019-08-05 15:40:14 -07:00
tstromberg 23491b68b6 Add boilerplate 2019-08-05 12:47:11 -07:00
tstromberg 22e55c70b8 Switch ISO download impl from go-download to go-getter 2019-08-05 11:46:38 -07:00
josedonizetti e14c7d9b1f Fix TestSetCurrentContext to use tmpfile 2019-08-02 21:28:16 -03:00
tstromberg e717d46030 Decrease ReasonableStartTime from 10 minutes to 5 minutes 2019-08-02 14:42:57 -07:00
josedonizetti 760707a5fb Fix lint 2019-08-01 15:08:27 -03:00
josedonizetti 358750e2e4 Add UnsetCurrentContext tests 2019-08-01 14:32:26 -03:00
josedonizetti 8cc1242601 Add TestSetCurrentContext 2019-08-01 13:20:01 -03:00
Medya Gh 9b3f72024a list vms after clean up 2019-07-30 10:42:55 -07:00
Medya Gh d1a41e0015 Added default profile 2019-07-30 10:40:11 -07:00
josedonizetti 3ec9b1ed2a Bump k8s.io/kubernetes to 1.15.0 2019-07-24 19:51:40 -03:00
Sharif Elgamal 6552436311
Console output cleanup (#4825)
* Console output cleanup

* comment fix

* Fixing out.Out stutter

* Fix invalid template

* Change profile_list.go to new console functions

* more merge stuff
2019-07-19 17:00:51 -07:00
Thomas Stromberg 4076eb15d6 Remove unused imports 2019-07-19 16:40:34 -07:00
Thomas Stromberg a9309c3237 Remove unused ParseSHAFromURL function 2019-07-19 16:36:26 -07:00
tstromberg 22ae10c267 Remove unused getTestArgs struct 2019-07-18 18:17:19 -07:00
tstromberg 14c67d46a5 Remove TestParseSHAFromURL (not well isolated, takes 30 seconds) 2019-07-18 18:12:28 -07:00
Sharif Elgamal 93263bc2bc
Templatizing more calls to console 2019-07-17 18:06:06 -07:00
Thomas Strömberg 82d4c7dd2c
Merge pull request #4688 from kairen/better-comment
Add space after // comments
2019-07-11 11:53:15 -07:00
Kyle Bai c5f695e8a0 Better comment syntax 2019-07-05 11:17:10 +08:00
Kyle Bai 6505dfad62 Delete kubeconfig when a machine has been deleted 2019-07-04 14:47:41 +08:00
Pranav Jituri 6ba1725c08 Added Memory Size Checking 2019-06-26 00:22:41 +05:30
serhat çetinkaya 9d88171d18 Improve stop behavior to unset curren-tcontext only if needed 2019-06-25 10:55:28 -07:00
Medya Gh b332f04ac0 better var name 2019-06-15 23:17:14 -07:00
Medya Gh 5176806eb2 set context on profile 2019-06-15 22:18:23 -07:00
Medya Gh 05177194a5 increasing time out for Pod operations 2019-06-14 16:03:23 -07:00
Medya Gh 657469310c Use retryable http to avoid connection flakes 2019-06-13 22:58:14 -07:00
Sharif Elgamal f424969553
Initialisms, man. 2019-05-30 10:40:45 -07:00
Sharif Elgamal 34ccd2ad41
Change console style string to enum 2019-05-29 18:45:55 -07:00
Thomas Strömberg 9d09ff069b
Merge pull request #4229 from medyagh/no_proxy_for_self
Allow minikube to function with misconfigured NO_PROXY value
2019-05-20 11:22:12 -07:00
Jan Janik 21b9e95647 Whitelist for kubeadm extra args 2019-05-17 17:11:03 +12:00
Medya Gh 3ff806a595 Added unittest and rebase 2019-05-16 14:44:01 -07:00
Medya Gh e878f9badb Merge remote-tracking branch 'upstream/master' into no_proxy_for_self 2019-05-15 14:19:14 -07:00
Medya Gh b9149b1eb0 Better name 2019-05-15 11:44:31 -07:00
Medya Gh 6fe614efa7 Fix stutter between the package name and the function 2019-05-15 11:34:21 -07:00
Medya Gh 8120cdd505 No Proxy for Dashboard and moving logic to proxy package 2019-05-14 21:45:35 -07:00
tstromberg 313cf575fe Merge branch 'master' into gomods 2019-05-14 21:06:00 -07:00
Medya Gh 6a433d01bf Fixing K8S Client Config with TranportWrap 2019-05-14 20:16:44 -07:00
Thomas Stromberg 25579f5a58 Use consistent names for k8s API imports 2019-05-13 21:57:59 -07:00
tstromberg 9a9f9edf5f First pass at lint-ageddon 2019-05-13 18:31:55 -07:00
Himanshu Pandey c8af727416 Added tests to check current-context on start and stop of minikube 2019-04-30 15:32:40 -07:00
Himanshu Pandey df0a0ad77c Unset the current-context on minikube stop 2019-04-30 00:02:05 -07:00
Anders F Björklund a73dfc5f9e Merge branch 'master' into cyclo 2019-04-12 20:03:20 +02:00
Benn Linger d102550644 Fixed status checking with non-default apiserver-port. 2019-04-04 21:43:43 -04:00
Jan Janik e3cd27264d Escape systemd special chars in —docker-env 2019-03-29 16:56:51 +13:00
Anders F Björklund 4667c28164 Merge branch 'master' into cyclo 2019-03-26 07:16:28 +01:00
Thomas Strömberg 460ef571e2
Merge branch 'master' into lint 2019-03-21 11:32:47 -07:00
Thomas Stromberg 605088ff72 Keep Initializers as the first element, fix v1.14 test which still included Initializers 2019-03-20 17:23:07 -07:00
Thomas Stromberg 88091b2323 Fix DefaultLegacyAdmissionControllers comment 2019-03-20 16:45:39 -07:00
Anders F Björklund 03bdce47ee Decrease cyclomatic complexity for test
Mostly by using the "extract method" pattern.

Here was the report (from gocyclo), before:

17 tunnel TestTunnelManagerCleanup pkg/minikube/tunnel/tunnel_manager_test.go:174:1
44 tunnel TestTunnel pkg/minikube/tunnel/tunnel_test.go:35:1
34 kubeconfig configEquals pkg/util/kubeconfig/config_test.go:420:1
25 integration testMounting test/integration/mount_test.go:36:1
18 integration testTunnel test/integration/tunnel_test.go:37:1
2019-03-16 23:04:24 +01:00
Anders F Björklund 00c9846a19 Decrease cyclomatic complexity for code
Mostly by using the "extract method" pattern.

Here was the report (from gocyclo), before:

16 kubeadm (*KubeadmBootstrapper).UpdateCluster pkg/minikube/bootstrapper/kubeadm/kubeadm.go:374:1
16 cluster StartHost pkg/minikube/cluster/cluster.go:64:1
16 tunnel setupRoute pkg/minikube/tunnel/tunnel.go:135:1
16 provision configureAuth pkg/provision/buildroot.go:218:1
21 util setElement pkg/util/config.go:50:1
2019-03-16 22:18:14 +01:00
Anders F Björklund 5497b966be Rename stutter and move classes between packages
Removing the kubeconfig module is probably not a big deal,
since it was already hiding under the "util" directory...

But the layout of the Bootstrapper is slightly irritating,
as long as it is contained in a different "kubeadm" module.
2019-03-16 16:57:56 +01:00
Anders F Björklund edf46f003f Document all exported functions outside minikube 2019-03-16 16:57:37 +01:00
Thomas Stromberg 327fdd8d4b Update kubeadm config generation to be compatible with v1.14.0-beta.1 2019-03-06 13:32:33 -08:00
Anders F Björklund 46640cef68 Address all lint except undocumented and stutter
These two lint warnings still remain, after the cleanup:
"exported ... should have comment or be unexported"

"type name will be used as foo.FooBar by other packages,
 and that stutters; consider calling this Bar"
2019-03-02 22:03:55 +01:00
Thomas Stromberg a2865f183a Back to the original 10 minute timeout :( 2019-03-01 10:50:39 -08:00
Thomas Stromberg c40602b327 ReasonableStartTime = 8, for folks with CrashLooping DNS on none 2019-02-28 16:40:46 -08:00
Thomas Stromberg 3b2a81d409 Increase ReasonableStartTime from 5 to 9 minutes 2019-02-28 16:26:42 -08:00
Thomas Stromberg 6a18ad9bc5 Reduce wait times, and wait more consistently 2019-02-13 21:15:46 -08:00
Thomas Stromberg 6c48048538 Merge from hell #2: refactor start.go because it's terrible 2019-02-08 13:37:29 -08:00
Thomas Stromberg d1b0d0470a Initial console implementation 2019-02-06 22:00:30 -08:00
Thomas Strömberg 7b32547cf6
Merge pull request #3108 from sebcworks/sebcworks-customapiserverport
Allow to specify api server port through CLI fix #2781
2019-01-15 16:43:42 -08:00
Thomas Strömberg ae4221b3fb
Merge pull request #3475 from tstromberg/intlogs
tee party: Stream cmd output to tests when -v is enabled, and stream SSH output to logs
2018-12-20 17:21:34 -08:00
Thomas Stromberg fcaf89666f Decrease log noise by logging retry loops after the initial attempt 2018-12-20 10:27:47 -08:00
Thomas Stromberg 7f7587d96c Rename TeeWithPrefix to TeePrefix to match Go idioms 2018-12-20 09:54:09 -08:00
Thomas Stromberg 9b707fe234 Add TeeWithPrefix to ssh_runner as well 2018-12-19 17:03:55 -08:00
priyawadhwa 8f128a7d10 Enable gvisor addon in minikube (#3399)
This PR adds the code for enabling gvisor in minikube. It adds the pod
that will run when the addon is enabled, and the code for the image
which will run when this happens.

When gvisor is enabled, the pod will download runsc and the
gvisor-containerd-shim. It will replace the containerd config.toml and
restart containerd.

When gvisor is disabled, the pod will be deleted by the addon manager.
This will trigger a pre-stop hook which will revert the config.toml to
it's original state and restart containerd.
2018-12-07 15:27:22 -08:00
mikeweiwei 3deef5345d fix logging calls (#3315) 2018-11-13 13:53:50 -08:00
Bily Zhang b9a4f9459f Fix some typos (#3302)
Signed-off-by: mooncake <xcoder@tenxcloud.com>
2018-11-06 12:36:13 -05:00
xichengliudui 52f37d9623 Fix typo miniube-iso -> minikube-iso 2018-11-05 02:06:30 -05:00
Thomas Strömberg 2621bb3a27
Merge pull request #3187 from tstromberg/consistent_err_formatting
Globally replace %s format directives with %v for error strings
2018-10-19 16:44:46 -07:00
Thomas Strömberg b93c22b6ab
Merge pull request #3221 from tstromberg/iso_errors
Include ISO URL and reduce stutter in download error message
2018-10-19 16:18:53 -07:00
Thomas Stromberg 118e9cc016 Apply go 1.11 formatting using `gofmt -s -l -w` 2018-10-19 14:29:56 -07:00
Thomas Stromberg 72e596507a Merge branch 'master' into consistent_err_formatting 2018-10-19 14:08:35 -07:00
Thomas Stromberg 3e256a0463 Fix accidental switch from Println to Printf 2018-10-19 13:48:25 -07:00
Thomas Stromberg 7e54a16d60 Include ISO URL in download error, make output slightly easier to read. 2018-10-05 12:50:47 -07:00
Thomas Stromberg 7feb46edcb Removed unneccesary changes to download errors 2018-10-03 15:16:37 -07:00
Thomas Stromberg bc2dbe3b08 Improve readability of ISO download errors + include URL.
This is a separate issue I bumped into while developing the dashboard
PR.
2018-10-03 12:56:54 -07:00
Thomas Stromberg 3706b3b8ac Fix dangling format issues. 2018-09-28 16:48:37 -07:00
Thomas Stromberg 055c8002b1 Replace %s format directives with %v for errors.
Previously we were mixed between the two forms. This commit picks %v,
which is consistent with the Kubernetes code base. They both effectively
do the same thing in this case, though %v works with any object, and %s
only with string objects.
2018-09-28 16:05:27 -07:00
Jason Stangroome 9b21d3c7e4 Allow certificates to be optionally embedded in .kube/config
Opt-in with `minikube config set embed-certs true`. Similar to the
behaviour of `kubectl config set-credentials --embed-certs`.

Enables Minikube on Windows to produce a .kube/config file that
can be shared directly with kubectl inside the Windows Subsystem
for Linux (WSL) without needing to perform additional translation
of the certificate paths within the configuration file.
2018-09-03 15:34:50 -05:00
Sebastien Collin e551231ec5 Allow to specify api server port through CLI 2018-09-01 15:07:27 +02:00
Aaron Prindle a4606583e4 remove all localkube references from code, change /var/lib/localkube to /var/lib/minikube 2018-07-24 12:36:42 -07:00
Ivan Hamilton 4bdba1f20b Issue certificates with NotBefore set 1 day prior to avoid drift/timezone issues in VM 2018-05-23 13:18:26 -07:00
Arnaud MAZIN b25f82759f Create empty map if Nil 2018-04-29 18:24:25 -07:00
Arnaud MAZIN 3f9350da72 fmt 2018-04-29 18:24:25 -07:00
Arnaud MAZIN cc41522545 added map[string]string argument parsing for eviction-like arguments 2018-04-29 18:24:25 -07:00
AdamDang 3c50dee461
Update config.go 2018-04-23 20:10:55 +08:00
dlorenc 3cce3ca727 Make ResourceQuota last. 2018-03-06 20:50:22 -08:00