Thomas Strömberg
b4ce29d589
Merge pull request #5757 from priyawadhwa/wait_false
...
Set --wait=false to default but still wait for apiserver
2019-10-28 21:52:15 -07:00
Nanik T
994d093766
Add boolean to disable opening browser during test
...
The WaitAndMaybeOpenService(..) method allow user to open the service
url in a browser when found, this create issue during testing as it's
opening browser and consuming resources.
The fix is to introduce a boolean flag allowing the caller to specify
whether to just print out the url or open a browser window
2019-10-29 13:23:41 +11:00
Priya Wadhwa
bd5840aacf
improve comments
2019-10-28 18:02:45 -07:00
Priya Wadhwa
f3b1a09c36
Clean up bootstrapper interface to accept list of pods to wait for
...
when waiting for the cluster to start up.
2019-10-28 17:34:04 -07:00
Priya Wadhwa
5f12e9afa1
Update docs and add error message to generate-docs
2019-10-28 17:12:03 -07:00
Medya Gh
29a015b63f
remove more bin bash c
2019-10-28 14:10:22 -07:00
Thomas Strömberg
f5ad9014ae
Merge pull request #5758 from tstromberg/inverted-ssh
...
Do not check sshd for the none driver
2019-10-28 10:56:30 -07:00
Priya Wadhwa
f92b308f9a
Rebased on master
2019-10-28 10:46:35 -07:00
Priya Wadhwa
cf62ff62b2
Remove extra log
2019-10-28 10:46:14 -07:00
Priya Wadhwa
7900b63d2b
Wait for only apiserver by default
...
This PR changes --wait=false to be the default, but to still check for the apiserver in this case. If wait=true, we still wait for all pods to be up and running. This change should speed up `minikube start`, since we won't have to wait for other pods which can take a longer time to start up.
Ref #5681
2019-10-28 10:45:57 -07:00
tstromberg
b1fd21e118
Do not check sshd for the none driver
2019-10-28 10:35:20 -07:00
Medya Ghazizadeh
e2bbf7111e
Merge branch 'master' into NewCmdRunner
2019-10-27 00:18:00 -07:00
Anders F Björklund
d635b8dfc7
Add comments as requested by golint
2019-10-26 13:16:29 +02:00
Anders F Björklund
c3498c593b
Decrease cyclomatic complexity
...
Mostly by using the "extract method" pattern.
Here is the report (from gocyclo), before:
21 cmd runStart cmd/minikube/cmd/start.go:272:1
18 cmd validateNetwork cmd/minikube/cmd/start.go:982:1
16 cmd runDelete cmd/minikube/cmd/delete.go:90:1
16 cmd deleteProfile cmd/minikube/cmd/delete.go:177:1
2019-10-26 13:08:23 +02:00
Thomas Strömberg
991d84e9f5
Merge pull request #5732 from tstromberg/config-avail
...
Hide innocuous viper ConfigFileNotFoundError
2019-10-25 12:45:20 -07:00
tstromberg
e46502cfed
Add automatic selection message even when there is only one choice
2019-10-25 10:53:20 -07:00
tstromberg
416f132ebb
Pass --expected-default-driver to the test rather than minikube
...
Improve VBoxManage detection on Windows
Add missing install_test
2019-10-25 10:43:30 -07:00
tstromberg
a7a692d717
Hide viper ConfigFileNotFoundError
2019-10-25 10:37:33 -07:00
Medya Gh
ddabc9ef47
remove extra error word
2019-10-24 14:20:07 -07:00
Medya Gh
187dfe29f8
getting rid of some of bin bash -c
2019-10-24 14:13:51 -07:00
tstromberg
b0045275a9
Merge branch 'drv-select2' of github.com:tstromberg/minikube into drv-select2
2019-10-24 10:55:40 -07:00
Thomas Stromberg
8920a884c3
Minor improvements to the clarity of hypervisor errors
2019-10-24 07:45:40 -07:00
Thomas Stromberg
c925f65629
Warn about driver status, add more logging
2019-10-23 22:33:05 -07:00
tstromberg
bdd0f3831f
Merge branch 'drv-select2' of github.com:tstromberg/minikube into drv-select2
2019-10-23 22:15:27 -07:00
Thomas Stromberg
dcdac36e98
Add integration tests
2019-10-23 21:45:23 -07:00
tstromberg
5d4bf0848f
Merge branch 'master' into drv-select2
2019-10-23 14:09:03 -07:00
Thomas Strömberg
98b3aefcac
Merge pull request #5520 from theVDude/config-cleaup
...
Remove duplicate setting field in config
2019-10-23 11:44:53 -07:00
Thomas Stromberg
443ae74719
Make unit tests pass again
2019-10-23 09:34:32 -07:00
Thomas Stromberg
1fc11f56f1
Add logic for picking the default driver on a host
2019-10-22 20:38:30 -07:00
Thomas Strömberg
fbc1630fc5
Merge pull request #5611 from woodcockjosh/json-output-for-status
...
Add json output for status
2019-10-21 18:37:34 -07:00
Thomas Strömberg
64edf25cd5
Merge pull request #5658 from tstromberg/drv-reorg
...
Consolidate driver handling code in pkg/minikube/driver
2019-10-21 14:12:20 -07:00
Medya Gh
6faf9cdbe7
lint and code review
2019-10-21 13:01:06 -07:00
Medya Gh
342397ab46
convert more to exec.Command
2019-10-21 11:40:10 -07:00
Thomas Strömberg
026120ab71
Merge pull request #5655 from tstromberg/simpler-kubectl-check
...
Improve kubectl skew check logic
2019-10-21 11:38:29 -07:00
Medya Gh
6bd5d9b157
Merge remote-tracking branch 'upstream/master' into NewCmdRunner
2019-10-21 11:17:28 -07:00
tstromberg
7581cf3e0c
Address merge conflicts
2019-10-21 11:12:06 -07:00
Josh Woodcock
ca7d378aaa
Change default status output to not include the ip. Simplify json output
2019-10-21 12:50:00 -05:00
Josh Woodcock
6aaed92496
Add json output for status
2019-10-21 12:50:00 -05:00
Thomas Strömberg
cd9a6526d3
Merge pull request #5548 from blueelvis/5358-purge-flag-for-delete
...
Added flags to purge configuration with minikube delete
2019-10-21 10:26:36 -07:00
Thomas Strömberg
723e77ed62
Merge pull request #5601 from woodcockjosh/json-output-for-addons-list
...
Add JSON output for addons list
2019-10-21 10:25:24 -07:00
Thomas Strömberg
c8833827c1
Merge pull request #5624 from nanikjava/f-fix-4883
...
Add validation checking for minikube profile
2019-10-21 10:17:26 -07:00
Thomas Strömberg
523db2099c
Merge pull request #5640 from sharifelgamal/auto-download-off
...
add ability to override autoupdating drivers
2019-10-21 10:16:49 -07:00
Thomas Strömberg
fd5e1d30a1
Merge branch 'master' into simpler-kubectl-check
2019-10-21 10:09:36 -07:00
tstromberg
35f7c9f38a
Merge branch 'master' into drv-reorg
2019-10-21 09:50:08 -07:00
Thomas Strömberg
9f38ddff39
Merge pull request #5656 from tstromberg/driver-tests
...
Rewrite cmd/delete_test to run without side effects
2019-10-21 09:49:41 -07:00
Thomas Strömberg
667b8b9b5d
Merge pull request #5659 from priyawadhwa/skeleton
...
[performance] add Makefile rule and code skeleton for mkcmp
2019-10-21 09:45:49 -07:00
Thomas Strömberg
967ce4867d
Merge pull request #5663 from afbjorklund/lint-again
...
Pick some lint from the recent master commits
2019-10-21 09:44:14 -07:00
cueo
d411617f9c
Use opposite operator
2019-10-20 19:11:26 +05:30
Pranav Jituri
b3ccd9ae46
Refactored Delete and fixed linting issues
2019-10-20 13:13:35 +05:30
Pranav Jituri
88fd869a81
Merge branch 'master' into 5358-purge-flag-for-delete
...
# Conflicts:
# cmd/minikube/cmd/delete.go
# pkg/minikube/cluster/cluster.go
2019-10-20 12:14:44 +05:30
Pranav Jituri
2ba9cb4c1a
refactoring for delete
2019-10-20 02:19:18 +05:30
Anders F Björklund
96c39bf050
Pick some lint from the recent master commits
2019-10-19 09:37:20 +02:00
Priya Wadhwa
f2900c613e
fix linting error
2019-10-18 17:07:56 -07:00
Priya Wadhwa
91b744095d
Fix boilerplate
2019-10-18 17:06:06 -07:00
Priya Wadhwa
484a66e082
Add skeleton for mkcmp
...
This PR adds a skeleton for mkcmp, a binary to compare the performance
of two versions of minikube. It adds a Makefile rule out/mkcmp which
builds the binary.
2019-10-18 16:55:58 -07:00
Thomas Strömberg
56a23cab4a
Merge pull request #5654 from tstromberg/delete-anyways
...
Ensure that delete succeeds even if cluster is unavailable
2019-10-18 16:06:12 -07:00
tstromberg
13cba07ec8
Fix broken cluster_test
2019-10-18 15:48:26 -07:00
tstromberg
cedab9e0fb
Revert delete_test.go changes, moving to another PR
2019-10-18 15:22:01 -07:00
tstromberg
b9bd1ba8d6
Rewrite delete_test to run without side effects
2019-10-18 15:17:51 -07:00
tstromberg
7cb0cfdf79
Pass lint checks
2019-10-18 13:53:57 -07:00
tstromberg
15daa48ed7
Merge branch 'master' into drv-reorg
2019-10-18 13:01:10 -07:00
Thomas Stromberg
6d7d589a52
Consolidate driver-interaction code into pkg/minikube/driver
2019-10-18 13:00:07 -07:00
Thomas Strömberg
9db86d91fa
Merge pull request #5592 from tstromberg/sshcheck
...
Add networking validation to validateNetwork
2019-10-18 07:24:09 -07:00
Thomas Stromberg
489713b6a8
run goimports
2019-10-17 16:56:38 -07:00
Thomas Stromberg
b0109c094d
comparing uints are complicated
2019-10-17 16:56:03 -07:00
Thomas Stromberg
235f94c7da
Improve kubectl skew check logic
2019-10-17 16:29:15 -07:00
Thomas Stromberg
2180c1405b
Ensure that delete succeeds even if cluster is unavailable
2019-10-17 16:23:21 -07:00
Sharif Elgamal
dc94405a34
Merge branch 'master' of github.com:kubernetes/minikube into auto-download-off
2019-10-17 15:32:09 -07:00
Thomas Strömberg
a84b3a9c95
Merge pull request #5596 from nanikjava/f-fix-3329
...
Warn if incompatible kubectl version is in use
2019-10-17 15:23:13 -07:00
Thomas Strömberg
dd266c751f
Merge pull request #5554 from woodcockjosh/json-output-for-profile-lists
...
Add json output for profile list
2019-10-17 15:21:24 -07:00
Thomas Strömberg
ccc2042861
Merge branch 'master' into remove-heapster
2019-10-17 15:14:49 -07:00
Josh Woodcock
b132b04809
Add json output for addons list
2019-10-17 16:47:43 -05:00
Thomas Strömberg
6d63e43caf
Merge pull request #5555 from woodcockjosh/fix-addons-output-format-option
...
Fix addons list output format option
2019-10-17 14:46:02 -07:00
Nanik T
824c911c42
Add validation checking for minikube profile
...
Fixes : #4883
New function ProfileNameInReservedKeywords(..) has been added inside
pkg/minikube/config/profile.go
The new function perform validation to make sure the profile name is not
in the list of keywords.
Following are the keywords that are used:
start, stop, status, delete, config, open, profile, addons, cache, logs
The checking is case insensitive to cover combo of upper and lower case
2019-10-18 08:40:18 +11:00
Thomas Strömberg
f74ac2095c
Merge pull request #5565 from RickyRajinder/enable-addons-when-minikube-not-running
...
Allow addon enabling and disabling when minikube is not running
2019-10-17 14:38:36 -07:00
Thomas Strömberg
acec7e5971
Merge pull request #5626 from govargo/fix-update-context
...
fix "minikube update-context" command fail
2019-10-17 14:29:07 -07:00
Josh Woodcock
d758672c8b
Remove function exports for profile list output types
2019-10-17 16:15:15 -05:00
Josh Woodcock
4b2f962f0c
Add json output for profile list
2019-10-17 16:15:15 -05:00
Nanik T
789cc7a55a
Restructure code based on PR comments.
...
* When nil is returned from function just return back
* Restructure the output so that it will make more sense
for the user
2019-10-18 08:07:09 +11:00
Sharif Elgamal
a6d7989bfc
add ability to override autoupdating drivers
2019-10-16 14:51:13 -07:00
tstromberg
8ca74ef186
Use the value of --image-repository for connectivity check
2019-10-16 13:38:47 -07:00
tstromberg
22f2fa7730
Merge branch 'master' into sshcheck
2019-10-16 13:25:45 -07:00
Kenta Iso
d2557e688c
fix kubeconfig.UpdateIP() argument order
2019-10-15 22:41:59 +09:00
Medya Gh
749c34ae6c
adding a logging to make sure jenkins is running right thing
2019-10-12 10:30:54 -07:00
Marek Schwarz
d13f58fc3b
Merge branch 'master' into DELETE_ALL_PROFILES
2019-10-11 23:04:23 +02:00
Josh Woodcock
f39ecda4cb
Add tests for addons custom output format
2019-10-11 09:43:00 -05:00
Nanik T
9bf904141c
Warn if incompatible kubectl version is in use
...
Fixes : #3329
Modification is done inside start.go where additional checking on the
version returned via the kubectl CLI is checked.
Running 'kubectl version --output=json' will return both client
and server information.
2019-10-11 23:46:02 +11:00
RickyRajinder
96edacc0a9
Changed command runner
...
Fixed test
Print error message
Change minikube running check to after check if exists
Updates Set and adds test for disabling
Fix action for minikube not running
Fix import order
2019-10-11 00:09:28 -07:00
Sharif Elgamal
6c5e432b14
Merge pull request #4999 from bhanu011/master
...
Warn when a user tries to set a profile name that is unlikely to be valid
2019-10-10 12:46:22 -07:00
Marek Schwarz
ae731d4393
Merge branch 'master' into DELETE_ALL_PROFILES
2019-10-10 21:22:45 +02:00
Thomas Stromberg
268ac04f00
Don't try curl with localhost proxies
2019-10-10 12:17:56 -07:00
Thomas Stromberg
76471ffda5
Improve error messages, add container registry check
2019-10-10 12:14:27 -07:00
Thomas Stromberg
5e71eba5f7
Remove unused enableUpdateNotification variable
2019-10-10 11:30:08 -07:00
Thomas Stromberg
79efa5452d
More comprehensive network checks
2019-10-10 11:26:09 -07:00
Rob Bruce
958c886f8a
Remove duplicate setting field in config
2019-10-10 13:24:02 -04:00
Ruslan Gustomiasov
64f1e73a25
Addon heaspter is not in use
...
Fixes #5017 . As per discussion, needed a rebase and this PR is rebased
to latest master.
2019-10-10 21:38:14 +05:30
Kenta Iso
f111f09526
Modify shortlived variable name and improve --addons flag help message
2019-10-10 11:29:13 +09:00
Kenta Iso
76e5f7b4cd
remove repetitive addon list from command help and add --addons flag explanation to documents
2019-10-10 11:29:13 +09:00
Kenta Iso
1e11576c9a
Add addons flag to 'minikube start' in order to enable specified addons
2019-10-10 11:29:13 +09:00
tstromberg
fb0d042710
Attempt a better error message
2019-10-09 15:24:42 -07:00
tstromberg
bc74f960b0
Merge branch 'master' into sshcheck
2019-10-09 13:48:18 -07:00
tstromberg
cd592172f0
Validate TCP connectivity to the VM
2019-10-09 13:48:05 -07:00
Sharif Elgamal
e63ecbe3b1
switch pkgConfig to config
2019-10-09 11:45:00 -07:00
Sharif Elgamal
57e9592270
Merge branch 'master' into master
2019-10-09 11:35:46 -07:00
Sharif Elgamal
e15c72565c
revert unrelated changes
2019-10-09 10:17:47 -07:00
Sharif Elgamal
946afc584d
pointless import
2019-10-09 10:13:19 -07:00
Sharif Elgamal
dc0240ab75
remove unnecessary call
2019-10-09 10:01:12 -07:00
Sharif Elgamal
994606cdf4
Add libmachine debug logs back
2019-10-08 17:08:18 -07:00
Josh Woodcock
fdf5345616
Fix addons list output format option
2019-10-07 09:18:43 -05:00
Marek Schwarz
c4107aeece
Merge branch 'master' into DELETE_ALL_PROFILES
2019-10-06 14:22:05 +02:00
Pranav Jituri
cb5055ef19
Fixed linting error
2019-10-06 16:32:24 +05:30
Pranav Jituri
0945ed881b
Added flags to purge configuration
2019-10-06 16:17:30 +05:30
Medya Ghazizadeh
63497aa383
Merge pull request #5507 from woodcockjosh/add-dns-ingress-addon
...
Add ingress-dns addon
2019-10-05 19:49:59 -07:00
Marek Schwarz
1efdf11abb
Merge branch 'master' into DELETE_ALL_PROFILES
2019-10-03 12:02:59 +02:00
Josh Woodcock
22cfacee29
Add ingress-dns addon
2019-10-01 04:55:16 -05:00
Marek Schwarz
3396f5b8ab
Merge branch 'master' into DELETE_ALL_PROFILES
2019-09-28 14:46:36 +02:00
Zhongcheng Lao
630dba3af1
Merge remote-tracking branch 'origin/master' into crio-containerd-image-repo
2019-09-28 12:23:20 +08:00
Thomas Strömberg
90bf0f8ec5
Merge pull request #5439 from afbjorklund/current-context
...
Fix order of parameters to CurrentContext funcs
2019-09-27 16:32:23 -07:00
Marek Schwarz
4551a17178
Merge branch 'master' into DELETE_ALL_PROFILES
2019-09-27 18:28:07 +02:00
Y.Horie
291b60b4b7
move DefaultWait,DefaultInterval to service #5375
2019-09-27 07:59:46 +09:00
Y.Horie
ea60470a6c
Move ConfigFile var into localpath #5375
2019-09-27 07:59:46 +09:00
u5surf
32cae3b739
Add copyrights new file #5375
2019-09-27 07:59:46 +09:00
u5surf
8bae58695b
Move GithubMinikubeReleasesURL into notify #5375
2019-09-27 07:59:46 +09:00
Y.Horie
cf6e104f5c
Inline default flag values directly to where the flag is defined #5375
2019-09-27 07:59:46 +09:00
Y.Horie
d023ac779e
Rename cacheImageConfigKey from cache #5375
2019-09-27 07:59:46 +09:00
yugo horie
878c3ca2b6
WIP: Remove all single-package constants from constants package #5375
2019-09-27 07:59:46 +09:00
Medya Ghazizadeh
7d0de97935
Merge pull request #5468 from yuxiaobo96/minikube-update3
...
fix-up typo
2019-09-26 11:18:52 -07:00
Marek Schwarz
e8c997d573
Merge branch 'master' into DELETE_ALL_PROFILES
...
# Conflicts:
# cmd/minikube/cmd/delete.go
2019-09-26 19:27:33 +02:00
Thomas Strömberg
6d58c180da
Merge pull request #5422 from afbjorklund/reportcard-1.4
...
Improve reportcard
2019-09-26 09:59:50 -07:00
yuxiaobo
aefa95d137
fix-up typo
...
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2019-09-26 14:04:35 +08:00
Marek Schwarz
47ec8d3431
Merge branch 'master' into DELETE_ALL_PROFILES
2019-09-25 20:43:03 +02:00
Marek Schwarz
3ec82dd00d
Merge branch 'master' into DELETE_ALL_PROFILES
...
# Conflicts:
# cmd/minikube/cmd/delete.go
2019-09-25 20:42:33 +02:00
Zhongcheng Lao
e6986aa943
Do not pass all the kubernetes config to runtime
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-25 08:13:04 +08:00
Zhongcheng Lao
08161722b0
Adds PauseImage to get pause image names
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-25 08:12:32 +08:00
Zhongcheng Lao
0306a8bd6f
Fixes CRI-O runtime not working with image repository flags
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-24 23:31:36 +08:00
Thomas Strömberg
8e138a7eea
Merge pull request #5441 from hwdef/fix-typo
...
Fix a variety of spelling mistakes and typos
2019-09-24 06:42:36 -07:00
Thomas Strömberg
b75d4abc16
Merge pull request #5363 from woodcockjosh/add-helm-addon
...
Add helm-tiller addon
2019-09-24 06:37:29 -07:00
hwdef
bfc26bbdf0
fix spelling mistake
2019-09-24 11:18:53 +08:00
Josh Woodcock
dba30af5e6
Rename helm addon to helm-tiller
2019-09-23 13:15:38 -05:00
Anders F Björklund
18a7f4c6b5
Fix order of parameters to CurrentContext funcs
...
Apparently it is easy to get name and path swapped around.
2019-09-23 20:13:06 +02:00
Thomas Strömberg
213f93d6b6
Merge pull request #4980 from blueelvis/4459-delete-even-if-vm-doesnt-exist
...
Fix crash when deleting the cluster but it doesn't exist
2019-09-23 11:05:38 -07:00
Marek Schwarz
d52730a54f
Fixed test errors
2019-09-21 23:32:30 +02:00
Pranav Jituri
b14d83feaa
Fixed build error
...
Gofmt
2019-09-22 01:58:48 +05:30
Marek Schwarz
79e8250da4
Use localpath
2019-09-21 14:39:35 +02:00
Marek Schwarz
01dd044b6f
Merge branch 'master' into DELETE_ALL_PROFILES
...
# Conflicts:
# cmd/minikube/cmd/delete.go
# pkg/minikube/config/profile.go
2019-09-21 14:19:13 +02:00
Anders F Björklund
67c7a7a81c
Reduce cyclometric complexity by refactoring
...
19 cmd generateCfgFromFlags cmd/minikube/cmd/start.go:711:1
19 cmd runStart cmd/minikube/cmd/start.go:257:1
18 hyperkit (*Driver).Start pkg/drivers/hyperkit/driver.go:202:1
17 cmd runDelete cmd/minikube/cmd/delete.go:53:1
16 registry TestRegistry pkg/minikube/registry/registry_test.go:39:1
2019-09-21 09:24:39 +02:00
Thomas Strömberg
35f45d1930
Merge pull request #5356 from n0npax/improve-storageclass-test-coverage
...
Improve storageclass test coverage
2019-09-20 15:29:00 -07:00
Marcin Niemira
6008ee6c88
Merge branch 'master' of https://github.com/kubernetes/minikube into improve-storageclass-test-coverage
2019-09-20 22:19:42 +10:00
Marcin Niemira
c2b81476ed
update cmd due to interface change
2019-09-20 22:19:18 +10:00
serhatcetinkaya
f2d028c239
resolve circular import problem
2019-09-19 23:34:28 +03:00
serhatcetinkaya
f539ce991e
resolve conflicts in start.go by accepting current changes
2019-09-19 23:34:21 +03:00
serhatcetinkaya
20a439de02
replaced constants.GetMinipath() with localpath.MiniPath()
2019-09-19 23:28:20 +03:00
Thomas Strömberg
91f2a0ae7d
Merge pull request #5407 from tstromberg/delete-retry
...
Delete host before retrying creation
2019-09-19 10:21:37 -07:00
Thomas Strömberg
67be861579
Merge pull request #5401 from tstromberg/not-found3
...
Remove duplicate handling of driver conflict, handle driver not-found…
2019-09-19 09:53:49 -07:00
Thomas Strömberg
e19592282b
Merge pull request #5403 from tstromberg/dashboard-v1.16.0
...
Upgrade dashboard to 2.0.0b4
2019-09-19 09:53:43 -07:00
Marek Schwarz
71a6cb5434
Merge branch 'master' into DELETE_ALL_PROFILES
2019-09-19 17:14:31 +02:00
Thomas Stromberg
9c3b9eb076
Reword retry message
2019-09-19 07:00:07 -07:00
Thomas Stromberg
e68ef68fc4
Delete host before retrying creation
2019-09-19 06:56:19 -07:00
Thomas Stromberg
4c5bc881f7
Address start lint error
2019-09-18 17:39:57 -07:00
Thomas Stromberg
6bd89789c0
Upgrade dashboard to 2.0.0b4
2019-09-18 17:23:42 -07:00
Thomas Stromberg
eca5c996a4
Remove duplicate handling of driver conflict, handle driver not-found case
2019-09-18 15:29:27 -07:00
Thomas Stromberg
197039c23d
Fix tests
2019-09-18 13:46:10 -07:00
Thomas Stromberg
846dd306f3
Merge branch 'master' into interactive
2019-09-18 13:39:59 -07:00
Thomas Stromberg
c0874e2a7e
Add --interactive flag support
2019-09-18 13:18:15 -07:00
Thomas Stromberg
dd4005fe3a
Retry Start only 3 times: 5 is excessive
2019-09-18 06:54:25 -07:00
Thomas Strömberg
97ebe91c68
Merge pull request #5383 from tstromberg/root-err
...
Provide actionable feedback when running an incompatible driver with root
2019-09-18 06:09:21 -07:00
Josh Woodcock
d81e8e943b
Add helm addon
2019-09-18 06:55:54 -05:00
chentanjun
576fe6d615
fix-up typo
2019-09-18 14:52:10 +08:00
tstromberg
a2a48a22fb
Improve root error
2019-09-17 17:22:08 -07:00
tstromberg
ca2a2b1ad9
Merge
2019-09-17 17:10:48 -07:00
tstromberg
39253bb573
Provide actionable feedback for root error
2019-09-17 17:08:09 -07:00
Thomas Strömberg
978d05b11e
Merge pull request #5382 from tstromberg/too-much-logs
...
Redirect machine driver logs to glog, reduce log spam elsewhere
2019-09-17 10:47:11 -07:00
Thomas Stromberg
c9bf5a162a
Redirect machine driver logs to glog
2019-09-17 09:54:48 -07:00
Thomas Strömberg
f97b2c5462
Merge branch 'master' into driver-dl
2019-09-16 19:15:41 -07:00
Thomas Stromberg
c4a4f53b45
Download version appropriate driver, add sha256 checksum check
2019-09-16 15:38:58 -07:00
Thomas Stromberg
8fb4ed5a5a
Re-use last driver by default, clarify driver conflict message, move it to occur before driver download
2019-09-16 15:04:17 -07:00
josedonizetti
6da3f24416
Fix golint
2019-09-15 19:26:15 -03:00
josedonizetti
6b74e5fc2f
Fix typos
2019-09-15 19:23:10 -03:00
Pranav Jituri
bb2d0a05d9
Fix merge conflict
2019-09-15 19:27:38 +05:30
Jose Donizetti
fb43666d7d
Add installOrUpdate hyperkit support
2019-09-14 00:37:08 -03:00
Thomas Stromberg
b6d878c417
Move update notification out of PersistentPreRun, improve update UI
2019-09-13 09:53:04 -07:00
Thomas Stromberg
e3d23d89f1
kube-proxy/WaitCluster fix: don't bootstrap from a stale context
2019-09-12 09:43:34 -07:00
Thomas Stromberg
2362025efd
Merge branch 'master' into norunner2
2019-09-11 20:28:17 -07:00
Thomas Stromberg
f7b8525aeb
Add error if a non-default profile name is used with the none driver
2019-09-11 16:07:10 -07:00
Thomas Stromberg
7a5042793b
Merge branch 'master' into norunner2
2019-09-11 11:54:24 -07:00
Thomas Stromberg
79424baac9
start: extend core service timeout to decrease flakes
2019-09-11 09:56:23 -07:00
Thomas Stromberg
41a312c24a
dashboard: extend startup timeout to decrease flakes
2019-09-11 09:56:05 -07:00
Thomas Stromberg
46550dbf0d
config: improve usage error messages
2019-09-11 09:55:46 -07:00
josedonizetti
e5cc21cb02
Remove old test
2019-09-11 11:44:27 -03:00
josedonizetti
0cf4921c14
Add drivers.InstallOrUpdate acceptance tests
2019-09-11 11:34:29 -03:00
josedonizetti
30e75c3c39
Download kvm2 driver
2019-09-11 11:34:29 -03:00
Thomas Strömberg
f36c5d8ed1
Merge pull request #5289 from n0npax/skip-http-proxy-localhost-for-docker-env
...
Skip http proxy localhost for docker env
2019-09-10 22:16:25 -07:00
dpandhi-git
814c8e1c17
updated || for condition if dashboardURLMode && user.Uid as per comments #5292
2019-09-09 13:38:01 -07:00
Deepika Pandhi
73aefd070e
fix in dashboard.go to display dashborad url with root
2019-09-09 13:36:02 -07:00
Marcin Niemira
ee8d4b757c
fix unit tests
2019-09-08 16:25:55 +10:00
Marcin Niemira
e9f9df56ad
fix misspeling
2019-09-07 20:38:40 +10:00
Marcin Niemira
e9517ec69b
add tests
2019-09-07 20:26:57 +10:00
Marcin Niemira
0b986bd044
don't pass http_proxy to dockerEnv if it's poiting to localhost
2019-09-07 18:36:18 +10:00
Matt Morrissette
f1b3afe99c
Add "native-ssh" flag to "start" and "ssh" commands and config
2019-09-05 17:38:41 -07:00
Sharif Elgamal
8ff9309b41
Fix indent for linting
2019-09-05 12:18:34 -07:00
Sharif Elgamal
ba2f93106f
Merge pull request #5086 from MaxKam/checkCPUCount
...
Minimum CPUs check
2019-09-05 11:49:54 -07:00
Thomas Strömberg
3457782f0e
Merge pull request #4759 from serhatcetinkaya/master
...
Exit if --kubernetes-version is older than the oldest supported version
2019-09-05 11:45:45 -07:00
Marek Schwarz
5b1528bdc9
Merge branch 'master' into DELETE_ALL_PROFILES
2019-09-04 17:42:22 +02:00
Thomas Strömberg
2635734849
Merge pull request #5249 from tstromberg/mologs
...
More logs: exited containers, controller manager, double line count
2019-09-03 16:16:38 -07:00
tstromberg
c32cb098b0
More logs: exited containers, controller manager, double line count
2019-09-03 10:34:44 -07:00
Max K
4831b48b8f
Fixed formatting issue
2019-09-02 13:17:59 -07:00
Max K
68f8dca51a
Fixed counting of physical CPU cores
...
Gopsutil packae doesn't automatically return a count of CPU cores, have to use
the Counts function.
2019-09-02 13:04:27 -07:00
Max K
ac49c96c9b
Updated cpu check to handle none driver cpu check
2019-09-02 13:04:27 -07:00
Max K
5ec324e2d2
Added check to exit app and show error message if number of cpus
...
is less than the minimum required.
2019-09-02 13:04:27 -07:00
bpopovschi
8b17253d22
Moved warning to minikube start command and print it to stderr
2019-09-02 11:39:38 +03:00
serhatcetinkaya
23cc018bbf
start.go make err type usable for exit.withCodeT
2019-09-01 21:01:32 +03:00
serhatcetinkaya
14b1d84474
start.go rename exit.WithCode with exit.WithCodeT
2019-09-01 20:50:44 +03:00
serhatcetinkaya
0b829cc22d
fix warnings
2019-09-01 20:46:44 +03:00
serhatcetinkaya
2230a52aa0
start: check force flag while comparing specified version
2019-09-01 20:30:07 +03:00
serhatcetinkaya
578e32559b
Merge remote-tracking branch 'upstream/master'
2019-09-01 19:31:24 +03:00
Thomas Stromberg
2c533cf5f7
Update driver install URL, adjust upgrade text
2019-08-27 20:50:29 -07:00
Thomas Strömberg
2205bb85bf
Merge pull request #5212 from tstromberg/kconfig
...
Announce environmental overrides up front
2019-08-27 14:19:09 -07:00
Thomas Stromberg
de74ee1eb4
Announce environmental overrides up front
2019-08-27 09:42:16 -07:00
Marek Schwarz
24d4eda27d
Merge branch 'master' into DELETE_ALL_PROFILES
...
# Conflicts:
# cmd/minikube/cmd/delete.go
# translations/fr-FR.json
# translations/zh-CN.json
2019-08-27 17:04:01 +02:00
Sharif Elgamal
3ac576c9bf
Fix some help text grammar
2019-08-26 15:13:42 -07:00
Marek Schwarz
ea20ba3edb
Merge branch 'master' into DELETE_ALL_PROFILES
...
# Conflicts:
# pkg/minikube/constants/constants.go
2019-08-23 20:09:55 +02:00
Marek Schwarz
808477ae1e
Moved GetMachinePath to machine.go and renamed it to MachinePath
...
Added comments to public functions
2019-08-23 19:47:41 +02:00
Thomas Strömberg
b89a9f6261
Merge pull request #5155 from phillipahereza/downgrade_warning
...
Fix downgrade warning is unhelpful and confusing
2019-08-22 16:33:26 -07:00
Thomas Stromberg
c2c2d91453
Add assistance if the user has a root owned config
2019-08-22 14:24:59 -07:00
Thomas Stromberg
a43e311783
Exit startup if uid=0, add --force flag to override
2019-08-22 12:04:19 -07:00
phillipahereza
003ad46e4a
reworded error message
2019-08-22 08:33:22 +03:00
phillipahereza
fd8e93cbe8
Merge branch 'master' into downgrade_warning
2019-08-22 07:21:41 +03:00
Thomas Stromberg
1c7a281d47
Run gofmt -w -s
2019-08-21 11:35:59 -07:00
phillipahereza
689e3228ee
updated error message to provide more options and make more sense
2019-08-21 20:54:11 +03:00
phillipahereza
49e1267510
fix hardcoded version
2019-08-21 20:54:11 +03:00
phillipahereza
8521ac2204
fix local email
2019-08-21 20:54:11 +03:00
Phillip Ahereza
afe0f8faf3
update downgrade warning error and exit
2019-08-21 20:53:53 +03:00
Thomas Strömberg
410dd8a5e0
Merge pull request #4840 from blueelvis/4724-auto-generate-docs
...
Added command to generate the documentation
2019-08-21 10:26:48 -07:00
Thomas Strömberg
b9a88eb52b
Merge pull request #5116 from josedonizetti/refactor-read-config
...
Refactor config.ReadConfig to accept a file
2019-08-21 10:16:08 -07:00
Marek Schwarz
2c6f659725
Merge branch 'master' into DELETE_ALL_PROFILES
2019-08-21 18:49:37 +02:00
Marek Schwarz
b3741bd952
Readded init
2019-08-20 21:10:29 +02:00
Sharif Elgamal
404d0ff255
remove duplicate import
2019-08-20 12:00:30 -07:00
Medya Gh
f75b558ac2
rename kube pkg to kapi
2019-08-19 16:11:38 -07:00
Marek Schwarz
ba67c8516a
Merge branch 'master' into DELETE_ALL_PROFILES
...
# Conflicts:
# cmd/minikube/cmd/delete.go
# pkg/minikube/constants/constants.go
# test/integration/z_proxy_test.go
# translations/fr-FR.json
# translations/zh-CN.json
2019-08-19 21:26:14 +02:00
Marek Schwarz
4835945839
Bugfix
...
Refactor
2019-08-18 19:44:09 +02:00
Medya Gh
5464a7c9e2
adding a new flag wait-timeout and reduce default wait from 5 to 3
2019-08-18 01:14:02 -07:00
Medya Gh
5811610697
refactor util/kuberentes and ExtraOptions
2019-08-17 19:05:54 -07:00
josedonizetti
4738d1a80f
Refactor config.ReadConfig to accept a file
2019-08-17 12:08:38 -04:00
Thomas Strömberg
96fcb917f8
Merge pull request #5106 from tstromberg/just-delete
...
delete: Clean up machine directory if DeleteHost fails to
2019-08-16 16:46:53 -07:00
Thomas Stromberg
9a8275b83a
Make delete resilient against corrupt configs
2019-08-16 14:39:40 -07:00
Thomas Strömberg
4b5fc6a25a
Merge pull request #4844 from RA489/inseregis
...
[FEATURE] insecure-registry via minikube config set
2019-08-14 15:08:28 -07:00
Thomas Strömberg
e18d84c9f5
Merge pull request #4834 from RA489/conruntime
...
[FEATURE] allow to set container-runtime via config
2019-08-14 14:17:46 -07:00
Medya Ghazizadeh
14db2d7f1a
Merge pull request #5075 from medyagh/file_lock_write
...
Improve parallel run reliability by putting lock on files before writing
2019-08-14 12:37:47 -07:00
Medya Gh
f17f3408a8
convert all RetryAfter to retry.Expo
2019-08-13 23:48:30 -07:00
Medya Ghazizadeh
2be6484214
Merge pull request #4993 from ethan-daocloud/patch-1
...
start.go: logging message typo correction
2019-08-13 21:43:42 -07:00