Commit Graph

1339 Commits (39da4432c76c73c17eb89b292263a60d133bb08b)

Author SHA1 Message Date
tstromberg bc74f960b0 Merge branch 'master' into sshcheck 2019-10-09 13:48:18 -07:00
tstromberg cd592172f0 Validate TCP connectivity to the VM 2019-10-09 13:48:05 -07:00
Sharif Elgamal e63ecbe3b1
switch pkgConfig to config 2019-10-09 11:45:00 -07:00
Sharif Elgamal 57e9592270
Merge branch 'master' into master 2019-10-09 11:35:46 -07:00
Sharif Elgamal e15c72565c revert unrelated changes 2019-10-09 10:17:47 -07:00
Sharif Elgamal 946afc584d pointless import 2019-10-09 10:13:19 -07:00
Sharif Elgamal dc0240ab75 remove unnecessary call 2019-10-09 10:01:12 -07:00
Sharif Elgamal 994606cdf4 Add libmachine debug logs back 2019-10-08 17:08:18 -07:00
Josh Woodcock fdf5345616 Fix addons list output format option 2019-10-07 09:18:43 -05:00
Marek Schwarz c4107aeece Merge branch 'master' into DELETE_ALL_PROFILES 2019-10-06 14:22:05 +02:00
Pranav Jituri cb5055ef19
Fixed linting error 2019-10-06 16:32:24 +05:30
Pranav Jituri 0945ed881b
Added flags to purge configuration 2019-10-06 16:17:30 +05:30
Medya Ghazizadeh 63497aa383
Merge pull request #5507 from woodcockjosh/add-dns-ingress-addon
Add ingress-dns addon
2019-10-05 19:49:59 -07:00
Marek Schwarz 1efdf11abb Merge branch 'master' into DELETE_ALL_PROFILES 2019-10-03 12:02:59 +02:00
Josh Woodcock 22cfacee29 Add ingress-dns addon 2019-10-01 04:55:16 -05:00
Marek Schwarz 3396f5b8ab Merge branch 'master' into DELETE_ALL_PROFILES 2019-09-28 14:46:36 +02:00
Zhongcheng Lao 630dba3af1
Merge remote-tracking branch 'origin/master' into crio-containerd-image-repo 2019-09-28 12:23:20 +08:00
Thomas Strömberg 90bf0f8ec5
Merge pull request #5439 from afbjorklund/current-context
Fix order of parameters to CurrentContext funcs
2019-09-27 16:32:23 -07:00
Marek Schwarz 4551a17178 Merge branch 'master' into DELETE_ALL_PROFILES 2019-09-27 18:28:07 +02:00
Y.Horie 291b60b4b7 move DefaultWait,DefaultInterval to service #5375 2019-09-27 07:59:46 +09:00
Y.Horie ea60470a6c Move ConfigFile var into localpath #5375 2019-09-27 07:59:46 +09:00
u5surf 32cae3b739 Add copyrights new file #5375 2019-09-27 07:59:46 +09:00
u5surf 8bae58695b Move GithubMinikubeReleasesURL into notify #5375 2019-09-27 07:59:46 +09:00
Y.Horie cf6e104f5c Inline default flag values directly to where the flag is defined #5375 2019-09-27 07:59:46 +09:00
Y.Horie d023ac779e Rename cacheImageConfigKey from cache #5375 2019-09-27 07:59:46 +09:00
yugo horie 878c3ca2b6 WIP: Remove all single-package constants from constants package #5375 2019-09-27 07:59:46 +09:00
Medya Ghazizadeh 7d0de97935
Merge pull request #5468 from yuxiaobo96/minikube-update3
fix-up typo
2019-09-26 11:18:52 -07:00
Marek Schwarz e8c997d573 Merge branch 'master' into DELETE_ALL_PROFILES
# Conflicts:
#	cmd/minikube/cmd/delete.go
2019-09-26 19:27:33 +02:00
Thomas Strömberg 6d58c180da
Merge pull request #5422 from afbjorklund/reportcard-1.4
Improve reportcard
2019-09-26 09:59:50 -07:00
yuxiaobo aefa95d137 fix-up typo
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2019-09-26 14:04:35 +08:00
Marek Schwarz 47ec8d3431 Merge branch 'master' into DELETE_ALL_PROFILES 2019-09-25 20:43:03 +02:00
Marek Schwarz 3ec82dd00d Merge branch 'master' into DELETE_ALL_PROFILES
# Conflicts:
#	cmd/minikube/cmd/delete.go
2019-09-25 20:42:33 +02:00
Zhongcheng Lao e6986aa943
Do not pass all the kubernetes config to runtime
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-25 08:13:04 +08:00
Zhongcheng Lao 08161722b0
Adds PauseImage to get pause image names
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-25 08:12:32 +08:00
Zhongcheng Lao 0306a8bd6f
Fixes CRI-O runtime not working with image repository flags
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-24 23:31:36 +08:00
Thomas Strömberg 8e138a7eea
Merge pull request #5441 from hwdef/fix-typo
Fix a variety of spelling mistakes and typos
2019-09-24 06:42:36 -07:00
Thomas Strömberg b75d4abc16
Merge pull request #5363 from woodcockjosh/add-helm-addon
Add helm-tiller addon
2019-09-24 06:37:29 -07:00
hwdef bfc26bbdf0 fix spelling mistake 2019-09-24 11:18:53 +08:00
Josh Woodcock dba30af5e6 Rename helm addon to helm-tiller 2019-09-23 13:15:38 -05:00
Anders F Björklund 18a7f4c6b5 Fix order of parameters to CurrentContext funcs
Apparently it is easy to get name and path swapped around.
2019-09-23 20:13:06 +02:00
Thomas Strömberg 213f93d6b6
Merge pull request #4980 from blueelvis/4459-delete-even-if-vm-doesnt-exist
Fix crash when deleting the cluster but it doesn't exist
2019-09-23 11:05:38 -07:00
Marek Schwarz d52730a54f Fixed test errors 2019-09-21 23:32:30 +02:00
Pranav Jituri b14d83feaa
Fixed build error
Gofmt
2019-09-22 01:58:48 +05:30
Marek Schwarz 79e8250da4 Use localpath 2019-09-21 14:39:35 +02:00
Marek Schwarz 01dd044b6f Merge branch 'master' into DELETE_ALL_PROFILES
# Conflicts:
#	cmd/minikube/cmd/delete.go
#	pkg/minikube/config/profile.go
2019-09-21 14:19:13 +02:00
Anders F Björklund 67c7a7a81c Reduce cyclometric complexity by refactoring
19 cmd generateCfgFromFlags cmd/minikube/cmd/start.go:711:1
19 cmd runStart cmd/minikube/cmd/start.go:257:1
18 hyperkit (*Driver).Start pkg/drivers/hyperkit/driver.go:202:1
17 cmd runDelete cmd/minikube/cmd/delete.go:53:1
16 registry TestRegistry pkg/minikube/registry/registry_test.go:39:1
2019-09-21 09:24:39 +02:00
Thomas Strömberg 35f45d1930
Merge pull request #5356 from n0npax/improve-storageclass-test-coverage
Improve storageclass test coverage
2019-09-20 15:29:00 -07:00
Marcin Niemira 6008ee6c88
Merge branch 'master' of https://github.com/kubernetes/minikube into improve-storageclass-test-coverage 2019-09-20 22:19:42 +10:00
Marcin Niemira c2b81476ed
update cmd due to interface change 2019-09-20 22:19:18 +10:00
serhatcetinkaya f2d028c239 resolve circular import problem 2019-09-19 23:34:28 +03:00
serhatcetinkaya f539ce991e resolve conflicts in start.go by accepting current changes 2019-09-19 23:34:21 +03:00
serhatcetinkaya 20a439de02 replaced constants.GetMinipath() with localpath.MiniPath() 2019-09-19 23:28:20 +03:00
Thomas Strömberg 91f2a0ae7d
Merge pull request #5407 from tstromberg/delete-retry
Delete host before retrying creation
2019-09-19 10:21:37 -07:00
Thomas Strömberg 67be861579
Merge pull request #5401 from tstromberg/not-found3
Remove duplicate handling of driver conflict, handle driver not-found…
2019-09-19 09:53:49 -07:00
Thomas Strömberg e19592282b
Merge pull request #5403 from tstromberg/dashboard-v1.16.0
Upgrade dashboard to 2.0.0b4
2019-09-19 09:53:43 -07:00
Marek Schwarz 71a6cb5434 Merge branch 'master' into DELETE_ALL_PROFILES 2019-09-19 17:14:31 +02:00
Thomas Stromberg 9c3b9eb076 Reword retry message 2019-09-19 07:00:07 -07:00
Thomas Stromberg e68ef68fc4 Delete host before retrying creation 2019-09-19 06:56:19 -07:00
Thomas Stromberg 4c5bc881f7 Address start lint error 2019-09-18 17:39:57 -07:00
Thomas Stromberg 6bd89789c0 Upgrade dashboard to 2.0.0b4 2019-09-18 17:23:42 -07:00
Thomas Stromberg eca5c996a4 Remove duplicate handling of driver conflict, handle driver not-found case 2019-09-18 15:29:27 -07:00
Thomas Stromberg 197039c23d Fix tests 2019-09-18 13:46:10 -07:00
Thomas Stromberg 846dd306f3 Merge branch 'master' into interactive 2019-09-18 13:39:59 -07:00
Thomas Stromberg c0874e2a7e Add --interactive flag support 2019-09-18 13:18:15 -07:00
Thomas Stromberg dd4005fe3a Retry Start only 3 times: 5 is excessive 2019-09-18 06:54:25 -07:00
Thomas Strömberg 97ebe91c68
Merge pull request #5383 from tstromberg/root-err
Provide actionable feedback when running an incompatible driver with root
2019-09-18 06:09:21 -07:00
Josh Woodcock d81e8e943b Add helm addon 2019-09-18 06:55:54 -05:00
chentanjun 576fe6d615 fix-up typo 2019-09-18 14:52:10 +08:00
tstromberg a2a48a22fb Improve root error 2019-09-17 17:22:08 -07:00
tstromberg ca2a2b1ad9 Merge 2019-09-17 17:10:48 -07:00
tstromberg 39253bb573 Provide actionable feedback for root error 2019-09-17 17:08:09 -07:00
Thomas Strömberg 978d05b11e
Merge pull request #5382 from tstromberg/too-much-logs
Redirect machine driver logs to glog, reduce log spam elsewhere
2019-09-17 10:47:11 -07:00
Thomas Stromberg c9bf5a162a Redirect machine driver logs to glog 2019-09-17 09:54:48 -07:00
Thomas Strömberg f97b2c5462
Merge branch 'master' into driver-dl 2019-09-16 19:15:41 -07:00
Thomas Stromberg c4a4f53b45 Download version appropriate driver, add sha256 checksum check 2019-09-16 15:38:58 -07:00
Thomas Stromberg 8fb4ed5a5a Re-use last driver by default, clarify driver conflict message, move it to occur before driver download 2019-09-16 15:04:17 -07:00
josedonizetti 6da3f24416 Fix golint 2019-09-15 19:26:15 -03:00
josedonizetti 6b74e5fc2f Fix typos 2019-09-15 19:23:10 -03:00
Pranav Jituri bb2d0a05d9
Fix merge conflict 2019-09-15 19:27:38 +05:30
Jose Donizetti fb43666d7d Add installOrUpdate hyperkit support 2019-09-14 00:37:08 -03:00
Thomas Stromberg b6d878c417 Move update notification out of PersistentPreRun, improve update UI 2019-09-13 09:53:04 -07:00
Thomas Stromberg e3d23d89f1 kube-proxy/WaitCluster fix: don't bootstrap from a stale context 2019-09-12 09:43:34 -07:00
Thomas Stromberg 2362025efd Merge branch 'master' into norunner2 2019-09-11 20:28:17 -07:00
Thomas Stromberg f7b8525aeb Add error if a non-default profile name is used with the none driver 2019-09-11 16:07:10 -07:00
Thomas Stromberg 7a5042793b Merge branch 'master' into norunner2 2019-09-11 11:54:24 -07:00
Thomas Stromberg 79424baac9 start: extend core service timeout to decrease flakes 2019-09-11 09:56:23 -07:00
Thomas Stromberg 41a312c24a dashboard: extend startup timeout to decrease flakes 2019-09-11 09:56:05 -07:00
Thomas Stromberg 46550dbf0d config: improve usage error messages 2019-09-11 09:55:46 -07:00
josedonizetti e5cc21cb02 Remove old test 2019-09-11 11:44:27 -03:00
josedonizetti 0cf4921c14 Add drivers.InstallOrUpdate acceptance tests 2019-09-11 11:34:29 -03:00
josedonizetti 30e75c3c39 Download kvm2 driver 2019-09-11 11:34:29 -03:00
Thomas Strömberg f36c5d8ed1
Merge pull request #5289 from n0npax/skip-http-proxy-localhost-for-docker-env
Skip http proxy localhost for docker env
2019-09-10 22:16:25 -07:00
dpandhi-git 814c8e1c17 updated || for condition if dashboardURLMode && user.Uid as per comments #5292 2019-09-09 13:38:01 -07:00
Deepika Pandhi 73aefd070e fix in dashboard.go to display dashborad url with root 2019-09-09 13:36:02 -07:00
Marcin Niemira ee8d4b757c
fix unit tests 2019-09-08 16:25:55 +10:00
Marcin Niemira e9f9df56ad
fix misspeling 2019-09-07 20:38:40 +10:00
Marcin Niemira e9517ec69b
add tests 2019-09-07 20:26:57 +10:00
Marcin Niemira 0b986bd044
don't pass http_proxy to dockerEnv if it's poiting to localhost 2019-09-07 18:36:18 +10:00
Matt Morrissette f1b3afe99c
Add "native-ssh" flag to "start" and "ssh" commands and config 2019-09-05 17:38:41 -07:00
Sharif Elgamal 8ff9309b41
Fix indent for linting 2019-09-05 12:18:34 -07:00
Sharif Elgamal ba2f93106f
Merge pull request #5086 from MaxKam/checkCPUCount
Minimum CPUs check
2019-09-05 11:49:54 -07:00
Thomas Strömberg 3457782f0e
Merge pull request #4759 from serhatcetinkaya/master
Exit if --kubernetes-version is older than the oldest supported version
2019-09-05 11:45:45 -07:00
Marek Schwarz 5b1528bdc9 Merge branch 'master' into DELETE_ALL_PROFILES 2019-09-04 17:42:22 +02:00
Thomas Strömberg 2635734849
Merge pull request #5249 from tstromberg/mologs
More logs: exited containers, controller manager, double line count
2019-09-03 16:16:38 -07:00
tstromberg c32cb098b0 More logs: exited containers, controller manager, double line count 2019-09-03 10:34:44 -07:00
Max K 4831b48b8f Fixed formatting issue 2019-09-02 13:17:59 -07:00
Max K 68f8dca51a Fixed counting of physical CPU cores
Gopsutil packae doesn't automatically return a count of CPU cores, have to use
the Counts function.
2019-09-02 13:04:27 -07:00
Max K ac49c96c9b Updated cpu check to handle none driver cpu check 2019-09-02 13:04:27 -07:00
Max K 5ec324e2d2 Added check to exit app and show error message if number of cpus
is less than the minimum required.
2019-09-02 13:04:27 -07:00
bpopovschi 8b17253d22 Moved warning to minikube start command and print it to stderr 2019-09-02 11:39:38 +03:00
serhatcetinkaya 23cc018bbf start.go make err type usable for exit.withCodeT 2019-09-01 21:01:32 +03:00
serhatcetinkaya 14b1d84474 start.go rename exit.WithCode with exit.WithCodeT 2019-09-01 20:50:44 +03:00
serhatcetinkaya 0b829cc22d fix warnings 2019-09-01 20:46:44 +03:00
serhatcetinkaya 2230a52aa0 start: check force flag while comparing specified version 2019-09-01 20:30:07 +03:00
serhatcetinkaya 578e32559b Merge remote-tracking branch 'upstream/master' 2019-09-01 19:31:24 +03:00
Thomas Stromberg 2c533cf5f7 Update driver install URL, adjust upgrade text 2019-08-27 20:50:29 -07:00
Thomas Strömberg 2205bb85bf
Merge pull request #5212 from tstromberg/kconfig
Announce environmental overrides up front
2019-08-27 14:19:09 -07:00
Thomas Stromberg de74ee1eb4 Announce environmental overrides up front 2019-08-27 09:42:16 -07:00
Marek Schwarz 24d4eda27d Merge branch 'master' into DELETE_ALL_PROFILES
# Conflicts:
#	cmd/minikube/cmd/delete.go
#	translations/fr-FR.json
#	translations/zh-CN.json
2019-08-27 17:04:01 +02:00
Sharif Elgamal 3ac576c9bf
Fix some help text grammar 2019-08-26 15:13:42 -07:00
Marek Schwarz ea20ba3edb Merge branch 'master' into DELETE_ALL_PROFILES
# Conflicts:
#	pkg/minikube/constants/constants.go
2019-08-23 20:09:55 +02:00
Marek Schwarz 808477ae1e Moved GetMachinePath to machine.go and renamed it to MachinePath
Added comments to public functions
2019-08-23 19:47:41 +02:00
Thomas Strömberg b89a9f6261
Merge pull request #5155 from phillipahereza/downgrade_warning
Fix downgrade warning is unhelpful and confusing
2019-08-22 16:33:26 -07:00
Thomas Stromberg c2c2d91453 Add assistance if the user has a root owned config 2019-08-22 14:24:59 -07:00
Thomas Stromberg a43e311783 Exit startup if uid=0, add --force flag to override 2019-08-22 12:04:19 -07:00
phillipahereza 003ad46e4a reworded error message 2019-08-22 08:33:22 +03:00
phillipahereza fd8e93cbe8 Merge branch 'master' into downgrade_warning 2019-08-22 07:21:41 +03:00
Thomas Stromberg 1c7a281d47 Run gofmt -w -s 2019-08-21 11:35:59 -07:00
phillipahereza 689e3228ee updated error message to provide more options and make more sense 2019-08-21 20:54:11 +03:00
phillipahereza 49e1267510 fix hardcoded version 2019-08-21 20:54:11 +03:00
phillipahereza 8521ac2204 fix local email 2019-08-21 20:54:11 +03:00
Phillip Ahereza afe0f8faf3 update downgrade warning error and exit 2019-08-21 20:53:53 +03:00
Thomas Strömberg 410dd8a5e0
Merge pull request #4840 from blueelvis/4724-auto-generate-docs
Added command to generate the documentation
2019-08-21 10:26:48 -07:00
Thomas Strömberg b9a88eb52b
Merge pull request #5116 from josedonizetti/refactor-read-config
Refactor config.ReadConfig to accept a file
2019-08-21 10:16:08 -07:00
Marek Schwarz 2c6f659725 Merge branch 'master' into DELETE_ALL_PROFILES 2019-08-21 18:49:37 +02:00
Marek Schwarz b3741bd952 Readded init 2019-08-20 21:10:29 +02:00
Sharif Elgamal 404d0ff255 remove duplicate import 2019-08-20 12:00:30 -07:00
Medya Gh f75b558ac2 rename kube pkg to kapi 2019-08-19 16:11:38 -07:00
Marek Schwarz ba67c8516a Merge branch 'master' into DELETE_ALL_PROFILES
# Conflicts:
#	cmd/minikube/cmd/delete.go
#	pkg/minikube/constants/constants.go
#	test/integration/z_proxy_test.go
#	translations/fr-FR.json
#	translations/zh-CN.json
2019-08-19 21:26:14 +02:00
Marek Schwarz 4835945839 Bugfix
Refactor
2019-08-18 19:44:09 +02:00
Medya Gh 5464a7c9e2 adding a new flag wait-timeout and reduce default wait from 5 to 3 2019-08-18 01:14:02 -07:00
Medya Gh 5811610697 refactor util/kuberentes and ExtraOptions 2019-08-17 19:05:54 -07:00
josedonizetti 4738d1a80f Refactor config.ReadConfig to accept a file 2019-08-17 12:08:38 -04:00
Thomas Strömberg 96fcb917f8
Merge pull request #5106 from tstromberg/just-delete
delete: Clean up machine directory if DeleteHost fails to
2019-08-16 16:46:53 -07:00
Thomas Stromberg 9a8275b83a Make delete resilient against corrupt configs 2019-08-16 14:39:40 -07:00
Thomas Strömberg 4b5fc6a25a
Merge pull request #4844 from RA489/inseregis
[FEATURE] insecure-registry via minikube config set
2019-08-14 15:08:28 -07:00
Thomas Strömberg e18d84c9f5
Merge pull request #4834 from RA489/conruntime
[FEATURE] allow to set container-runtime via config
2019-08-14 14:17:46 -07:00
Medya Ghazizadeh 14db2d7f1a
Merge pull request #5075 from medyagh/file_lock_write
Improve parallel run reliability by putting lock on files before writing
2019-08-14 12:37:47 -07:00
Medya Gh f17f3408a8 convert all RetryAfter to retry.Expo 2019-08-13 23:48:30 -07:00
Medya Ghazizadeh 2be6484214
Merge pull request #4993 from ethan-daocloud/patch-1
start.go: logging message typo correction
2019-08-13 21:43:42 -07:00
Medya Gh 998d305af3 Adding lock to most ioutil.WriteFile 2019-08-13 21:12:34 -07:00
Medya Gh 5b7428c57f remove TODO comment 2019-08-13 17:50:28 -07:00
Medya Gh 9f0b4e61f8 lint 2019-08-13 15:55:52 -07:00
Medya Gh 010b29c178 lint and TODO comment 2019-08-13 15:51:12 -07:00
Medya Gh f712dd62f3 rename funcs, add new func DeleteProfile 2019-08-13 15:51:12 -07:00
Medya Gh 6a694ffa6f Add create profile, move funcs out of constants 2019-08-13 15:51:12 -07:00
Medya Ghazizadeh 7bb085ad24
Merge pull request #5003 from medyagh/kubeconfig
Refactor Kubeconfig
2019-08-13 14:57:49 -07:00
Thomas Stromberg f2acb4a33e Update code references to new documentation URL's 2019-08-12 14:51:41 -07:00
Sharif Elgamal 294f880106
Localization support for help text (#4814)
* Translating help text

* explicity set usage template so we can localize it

* cleaning up extract and translation files

* Add extraction for flags help text

* some comments for extract

* refactor to account for new behavior

* Make usage template translations more palatable.

* remove commented code

* fix go mod

* pin to proper version in go.mod

* translate command grouping headers
2019-08-12 11:16:20 -07:00
Medya Gh e696d33206 renamed funky name to Settings 2019-08-09 17:51:51 -07:00
Medya Gh a7986993e3 get rid of cmd/util package 2019-08-09 12:23:05 -07:00
Medya Gh d60664df78 refactor fix tests 2019-08-09 12:23:05 -07:00
Medya Gh d3e4e78caa remove redudnent arugment 2019-08-09 12:22:37 -07:00
Medya Gh c064d50881 more clearn func names and move var closer where used 2019-08-09 12:22:10 -07:00
Medya Gh 08e3e14263 add embeded-certs flag to config, decouple kubeconfig from viper 2019-08-09 12:21:48 -07:00
Medya Gh a15201b131 remove exit from kubeconfig update lib 2019-08-09 12:21:48 -07:00
Medya Gh 733ba21a36 decouple kubeconfig update from Host 2019-08-09 12:21:48 -07:00
Medya Gh 5621355004 ranem DeleteContext func 2019-08-09 12:19:58 -07:00
Medya Gh 5a9fb439ab rename funcs 2019-08-09 12:19:58 -07:00
Medya Gh a54b9629cd unexport and rename funcs 2019-08-09 12:19:58 -07:00
Medya Gh ffe573ec48 fixed stutter 2019-08-09 12:18:33 -07:00
Medya Gh df624349c3 created kubeconfig package 2019-08-09 12:18:33 -07:00
Thomas Strömberg 4a335cbd56
Merge pull request #5026 from tstromberg/drvmnt
Restore --disable-driver-mounts flag
2019-08-09 07:49:05 -07:00
Thomas Stromberg d18978450c Restore --disable-driver-mounts flag 2019-08-08 17:12:33 -07:00
Sharif Elgamal 1f48364487
Fix prepareNone and add integration test for it (#5023)
* Fix prepareNone and add integration test for it

* add test file

* only compile none test on linux

* build tags are confusing

* build tags are quite confusing

* build tags are very confusing
2019-08-08 15:47:44 -07:00
Marek Schwarz f0dd5a7e35 Added unit test for deletion of all profiles
Improved logging
2019-08-08 23:16:46 +02:00
bhanu011 17365e7e42 4883: removed exit with error 2019-08-09 01:41:42 +05:30
bhanu011 1a790dad18 4883: Fixed unused variable issue in test case 2019-08-09 01:17:56 +05:30
Marek Schwarz 6ed4262849 Resolved import cycle
Added unit test for machine.go
2019-08-08 21:41:58 +02:00
bhanu011 c93908dd0a 4883: Advice when user tries to set profile name 2019-08-09 00:58:08 +05:30
Marek Schwarz 50329ed870 Added machine.go to Load and Validate machines
Added empty machine_test.go
Added testdata for machine.go
2019-08-07 21:48:46 +02:00
Jituri, Pranav fb8a47f441
Fixed the template for dashboard output 2019-08-07 11:16:39 +05:30
bhanu011 333c293976 4883: Advice when user tries to set profile name 2019-08-07 02:46:09 +05:30
ethan 8a73b56e33
start.go: logging message typo correction
Signed-off-by: ethan <guangming.wang@daocloud.io>
2019-08-06 22:17:32 +08:00
Pranav Jituri c5e55a1004
Fixed linting and added some more info to build guide for testing 2019-08-05 02:04:55 +05:30
Pranav Jituri bf4f77a780
Fix crash when the cluster doesn't exist 2019-08-05 01:22:18 +05:30
Pranav Jituri e147341300
Generate Docs is now a hidden command 2019-08-04 20:11:59 +05:30
Medya Ghazizadeh 45e5265c35
Merge pull request #4944 from josedonizetti/refactor-extract-writeconfig
Refactor extract writeconfig
2019-08-04 00:41:25 -07:00
Thomas Stromberg ed6428b324 Turn gopsutil errors into warnings: Virtualization() not supported on Darwin 2019-08-03 10:04:23 -07:00
josedonizetti 2fbd028c07 Refactor improve variable names 2019-08-02 21:57:31 -03:00
josedonizetti 8b42e28d44 Refactor WriteConfig to accept a path 2019-08-02 21:45:01 -03:00
Thomas Strömberg ae9f406b38
Merge pull request #4607 from dfang/feature/registry_mirror_env
Automatically set flags for MINIKUBE_ prefixed env vars
2019-08-02 15:34:05 -07:00
Thomas Strömberg be61eb7bb1
Merge branch 'master' into cherry-3a96b 2019-08-02 15:04:10 -07:00
tstromberg 2dd3445176 Add container status and container runtime logs 2019-08-02 14:39:56 -07:00
tstromberg 45e9cfba8f Opt for shorter output strings 2019-08-02 11:38:37 -07:00
tstromberg 4b9402fc82 Add host distro to minikube start & guest distro to logs 2019-08-02 11:17:52 -07:00
josedonizetti 4a4ae87e9e refactor: Move WriteConfig to pkg/minikube/config 2019-08-01 14:37:30 -03:00
josedonizetti 483fe644eb Improve UnsetTest 2019-07-30 14:16:51 -03:00
josedonizetti 45a329fb6c Unset profile when it is deleted 2019-07-30 12:44:50 -03:00
fang duan a44b3393aa
FIX 2019-07-30 08:20:37 +08:00
Medya Ghazizadeh 165c1afd33 UI: improve minikube help output by grouping into categories (#4879)
* Improve minikube help output by grouping into categories

* consistant colon

* Add configuration category to grouped commands
2019-07-29 15:04:44 -07:00
Marek Schwarz a1d73a7a34 Added method to delete invalid profiles
Added unit tests for DeleteProfiles
deleteProfile for not part of api anymore
Added more validation for profiles
2019-07-29 23:19:13 +02:00
Medya Ghazizadeh 743aeaa859
Merge pull request #4887 from josedonizetti/fix-glog-parse-error
Fix glog parse error
2019-07-29 13:24:19 -07:00
Thomas Strömberg a05a26e039
Merge pull request #4758 from blueelvis/4661-force-poweroff-in-hyperv
hyperv: Run "sudo poweroff" before stopping VM
2019-07-29 10:16:23 -07:00
josedonizetti 08c86b4010 Add comment explaining pkg/initflag 2019-07-27 11:05:49 -03:00
josedonizetti 42a69a9a27 Add pkg/initflag 2019-07-27 10:40:21 -03:00
fang duan 389cb018da
Merge branch 'master' into feature/registry_mirror_env 2019-07-27 20:01:14 +08:00
Jose Donizetti fe00076341
Revert "Fix flag.Parse error logging" 2019-07-25 23:03:04 -03:00
Medya Ghazizadeh 288024fd53
Merge pull request #4867 from josedonizetti/fix-flag-parse-error-logging
Fix flag.Parse error logging
2019-07-25 14:41:58 -07:00
Jose Donizetti 4ea0250a43 Validate driver is supported on current OS (#4720)
* Validate None driver is supported on current OS

* Add Virtualbox tests to validateOSSupportVMDriver

* Add Hyperv driver OS validation

* Add Hyperkit driver OS validation

* Add Kvm2 driver OS validation

* Refactor driver validation to use IsValidDriver
2019-07-25 11:14:57 -07:00
josedonizetti d7f755d67a Fix flag.Parse error logging 2019-07-25 10:31:30 -03:00
Marek Schwarz 6f81089dfb Fixed review findings 2019-07-24 20:35:58 +02:00
Marek Schwarz d4d8cc43f0 Refactor error init 2019-07-24 17:28:57 +02:00
Marek Schwarz 96ef740782 Improved logging 2019-07-24 15:01:52 +02:00
Marek Schwarz 1ef11bfea8 Fix test 2019-07-23 17:53:14 +02:00
Marek Schwarz 6dcb45ad52 Refactor 2019-07-23 17:26:27 +02:00
Marek Schwarz 6d9ae13990 Fixed Test 2019-07-23 13:50:36 +02:00
fang duan 3261b7d019
Merge branch 'master' into feature/registry_mirror_env 2019-07-23 15:43:30 +08:00
RA489 81144395ba [FEATURE] allow to set container-runtime via config 2019-07-23 08:29:27 +05:30
RA489 043c45ddf4 [FEATURE] allow to set container-runtime via config 2019-07-23 07:30:31 +05:30
Marek Schwarz 45161fabc4 Keep deleting when profiles when the deletion of one profile fails
Added deletionError struct
Added function to handle deletion errors for logging
2019-07-23 00:58:02 +02:00
Jose Donizetti 6a5fbbac34 Warn if hyperkit version is old (#4691)
* Add warn if hyperkit driver version is old

* Add hyperkit upgrade documentation

* Improve kvm/hyperkit upgrade warn message

* Move validateDriverVersion to before downloading ISO

* Change executable to use constants
2019-07-22 15:35:42 -07:00
Jituri, Pranav d3974b53fc Fixed the linting error 2019-07-23 01:47:30 +05:30
Jituri, Pranav f97451e0f2 Added command to generate the documentation 2019-07-23 01:31:41 +05:30
fang duan 05ee40fc28
Minikube start respects MINIKUBE_ prefixed env now 2019-07-22 11:26:38 +08:00
Marek Schwarz e237a1314d Fixed merge error 2019-07-20 20:02:40 +02:00
Jituri, Pranav c96a3bf1db Add conditional to poweroff on Hyper-V using SSH 2019-07-20 23:05:45 +05:30
Marek Schwarz 48bd69c895 Integrated ListProfiles()
Removed GetAllProfiles()
Made LoadProfile public
2019-07-20 18:57:27 +02:00
Marek Schwarz 70f4cb99ce Merge branch 'master' into DELETE_ALL_PROFILES
# Conflicts:
#	cmd/minikube/cmd/delete.go
2019-07-20 18:18:30 +02:00
Sharif Elgamal 6552436311
Console output cleanup (#4825)
* Console output cleanup

* comment fix

* Fixing out.Out stutter

* Fix invalid template

* Change profile_list.go to new console functions

* more merge stuff
2019-07-19 17:00:51 -07:00
Thomas Strömberg 784717c007
Merge pull request #4813 from tstromberg/cluster_test
Make cluster_test and utils_test run in isolation
2019-07-19 16:48:26 -07:00
Medya Gh 5d5c193743 Fix profile list error handling 2019-07-19 16:24:23 -07:00
Medya Gh 605a549de4 Improve usage message when there is no profile found 2019-07-19 16:15:11 -07:00
Medya Gh 7ef6b80a16 Add usage message when no profile found and avoid showing empty table 2019-07-19 16:10:03 -07:00
Medya Ghazizadeh 9f42df6209
Merge pull request #4811 from medyagh/add_profile_list_cmd
Add a new command (profile list)
2019-07-19 15:43:50 -07:00
Medya Gh 51a19625bc Lint and add optional arg to other loaders 2019-07-19 10:45:56 -07:00
Medya Gh b17376cccf Refactor profile, detect invalid profiles 2019-07-18 18:23:26 -07:00
tstromberg a3d32758f8 Add mock.Logf functions to avoid panics 2019-07-18 18:12:48 -07:00
Medya Gh 0d16ab38b9 boilerplate format 2019-07-18 14:50:37 -07:00
Medya Gh a0e515a770 Added cobra command for profile list 2019-07-18 14:29:47 -07:00
Medya Gh 8730c02c93 Use Out instead OutT for ip 2019-07-18 13:01:05 -07:00
Medya Gh 453b8630f4 merge upstream 2019-07-18 11:50:55 -07:00
Thomas Strömberg b992c4542a
Merge pull request #4744 from tstromberg/faster-kubelet
Allow users to skip pod health checks with --wait=false
2019-07-18 11:00:21 -07:00
Medya Gh ed11f3ab0c merge upstream 2019-07-18 10:39:28 -07:00
Marek Schwarz 4c6af0281a Fixed goimports lint error 2019-07-18 13:21:53 +02:00
Marek Schwarz 42a58500f6 Fixed lint errors 2019-07-18 11:40:52 +02:00
Marek Schwarz 09d8143fa9 Merge branch 'master' into DELETE_ALL_PROFILES
# Conflicts:
#	cmd/minikube/cmd/delete.go
2019-07-18 11:18:19 +02:00
Marek Schwarz 9e73f6e4aa Refactor review findings
Removed IsProfileConfigValid
Added TODOs
2019-07-18 08:47:05 +02:00
Medya Ghazizadeh 5178c0b300
Merge branch 'master' into translation_outstyle 2019-07-17 18:12:45 -07:00
Sharif Elgamal 93263bc2bc
Templatizing more calls to console 2019-07-17 18:06:06 -07:00
Sharif Elgamal b4feb7e842
Merge branch 'master' of github.com:kubernetes/minikube into TEMPLATES 2019-07-17 17:46:08 -07:00
Medya Gh 97ba8854a6 more translation formatting 2019-07-17 17:37:39 -07:00
Thomas Stromberg 054fc946f1 Pass most tests 2019-07-17 17:13:12 -07:00
Thomas Stromberg cbd7d702ef Merge remote-tracking branch 'upstream/master' 2019-07-17 16:55:06 -07:00
Thomas Stromberg 3d7c657eaf Templated output migration 2019-07-17 16:54:56 -07:00
Medya Gh 4e4eccad30 Added more translation formatting 2019-07-17 16:54:29 -07:00
Medya Gh f57f6d724c linting 2019-07-17 16:28:49 -07:00
Sharif Elgamal 67f0e8e3f4 initial commit 2019-07-17 15:42:08 -07:00
Medya Gh f1d55de97c Added translation fomratting for disable,profile,start 2019-07-17 15:34:14 -07:00
Sharif Elgamal b40011b2e3
Add T versions of the console convenience functions (#4796)
* Add T versions of the console convenience functions

* more changes

* Make OutT and ErrT more convenient and add WithCodeT:

* add UsageT

* make extract

* translate messages in displayError
2019-07-17 15:19:49 -07:00
tstromberg 0b7bdad891 Merge conflicts 2019-07-17 09:22:05 -07:00
tstromberg 1b83a89df3 Settle merge conflicts 2019-07-17 09:00:54 -07:00
tstromberg 7a81b7cf68 Remove hardcoded driver list from help docs 2019-07-17 08:58:59 -07:00
Marek Schwarz 019ee1f018 Merge branch 'master' into DELETE_ALL_PROFILES 2019-07-17 08:52:37 +02:00
Medya Ghazizadeh d15eb12900
Merge pull request #4737 from medyagh/simplify_start
refactoring and simplifying start command
2019-07-16 15:34:22 -07:00
tstromberg d0ae6e9d3b Obsolete driver lint issues 2019-07-16 15:16:51 -07:00
tstromberg 9896386d03 Fix docker-machine-driver-kvm2 build 2019-07-16 14:42:56 -07:00
tstromberg 914713f388 Remove deprrecated drivers: kvm-old and xhyve 2019-07-16 13:40:00 -07:00
Marek Schwarz d0e749b3a0 Implemented deleteAllProfiles 2019-07-16 22:08:47 +02:00
Marek Schwarz f0e707c49d Merge remote-tracking branch 'marekschwarz/DELETE_ALL_PROFILES' into DELETE_ALL_PROFILES 2019-07-16 21:21:08 +02:00
Marek Schwarz 3c4b1b1656 Renamed minikubeConfig to mkConfig
Renamed hasConfigJson to hasConfigJSON
2019-07-16 21:20:59 +02:00
Marek Schwarz 925e803e85 Added deleteProfile function 2019-07-16 21:20:20 +02:00
Medya Gh 78789d8d80 spelling 2019-07-16 09:33:35 -07:00
Sharif Elgamal 941c7d5fb2
moving checks to their relevant stops so unit tests work 2019-07-15 13:38:12 -07:00
Marek Schwarz 72a9493dfb
Renamed delte-all flag to all 2019-07-15 12:30:39 +02:00
Marek Schwarz dd9afd1783 Ensure usage of --delete-all without -p flag
Added skeleton for deleteAllProfiles function
2019-07-14 22:02:33 +02:00
serhatcetinkaya deead301f2 start: compare specified kubernetes version with oldest supported version 2019-07-14 19:29:08 +03:00
Marek Schwarz 13f40f4bf2 Check if machineConfig and kubernetesConfig is not empty 2019-07-14 14:33:13 +02:00
Marek Schwarz f9e849066b Removed debug code
Added skeleton for IsProfileConfigValid
2019-07-14 00:14:12 +02:00
Marek Schwarz 6c4749b33c Bugfix: Imported wrong configname 2019-07-13 23:57:27 +02:00
Marek Schwarz 6f2390b8f6 Added function to check if profile-config is valid 2019-07-13 23:36:00 +02:00
Marek Schwarz 6887128f80 Merge remote-tracking branch 'main/master' into DELETE_ALL_PROFILES 2019-07-13 23:29:26 +02:00
Marek Schwarz 08b6edc781 Added function to get all profiles 2019-07-13 12:37:55 +02:00
Thomas Strömberg b50aa37407
Revert "Refactor status command" 2019-07-12 14:23:38 -07:00
tstromberg 44c8dd52a8 Add --wait flag to allow users to skip pod health checks 2019-07-12 14:18:43 -07:00
Marek Schwarz db6b0a50cd Added --delete-all flag 2019-07-12 18:00:11 +02:00
Medya Gh 3dce194cd9 Move options for better groupiong 2019-07-11 17:26:36 -07:00
Medya Gh 089bacc58f group init flags 2019-07-11 17:16:22 -07:00
Medya Gh 944d33e4e4 Fix config pointer 2019-07-11 16:41:07 -07:00
Medya Gh 641c9c4bbd remove extra logging 2019-07-11 13:09:40 -07:00
Kubernetes Prow Robot 65c6f9e5a3
Merge pull request #4686 from josedonizetti/refactor-status-cmd
Refactor status command
2019-07-11 11:54:10 -07:00
Thomas Strömberg 82d4c7dd2c
Merge pull request #4688 from kairen/better-comment
Add space after // comments
2019-07-11 11:53:15 -07:00
Thomas Strömberg b0b13e1a7c
Merge pull request #4545 from marcosdiez/dont_disable_container_engines_when_vmdriver_is_none
Don't disable other container engines when --vm_driver=none
2019-07-11 11:17:57 -07:00
Medya Gh 3e9077dd2a added comment 2019-07-10 23:42:23 -07:00
Medya Gh ff969e693b Simplifying start cmd 2019-07-10 23:14:15 -07:00
Sharif Elgamal c92e65ec28
Add templating for proper localization (#4677)
* Add templating for proper localization

* Fixing tests for new translation style

* checking errors is important

* fixing more console tests

* good function names make for happy developers

* add test for OutTemplateStyle

* short function names make for happy developers

* better formatting

* more better variable names
2019-07-10 10:17:28 -07:00
josedonizetti 120ce27845 Refacator status command 2019-07-09 15:58:01 -03:00
Medya Ghazizadeh 8e0596d2b1
Merge pull request #4692 from josedonizetti/add-kubectl-flag-examples
Add kubectl help examples
2019-07-09 11:02:48 -07:00
josedonizetti cf468bfe63 Add kubectl examples 2019-07-09 05:11:33 -03:00
Medya Ghazizadeh c8b0b41a6b
Merge pull request #4675 from superbrothers/fix-minikube-service
Fix `minikube service` to show error message if service has no node ports
2019-07-08 21:22:58 -07:00
Anders F Björklund dfbf8013ec Reduce complexity of the delete command 2019-07-06 10:14:58 +02:00
Kazuki Suda 6f96fbaa93 Print information of a service as a table 2019-07-05 15:32:19 +09:00
Medya Ghazizadeh 4e5f173a9c
Merge pull request #4687 from medyagh/move_command_runner
moving command runner to its own package
2019-07-04 23:30:21 -07:00
Medya Ghazizadeh cc9960200f
Merge pull request #4676 from josedonizetti/warn-if-kvm2-version-is-old
Add warn if kvm driver version is old
2019-07-04 22:22:13 -07:00
Kyle Bai c5f695e8a0 Better comment syntax 2019-07-05 11:17:10 +08:00
Medya Gh 99ac1a81e7 moving command runner to its own package 2019-07-04 16:31:07 -07:00
josedonizetti 9210b96ee8 Add upgrade documentation to kvm version warn 2019-07-04 17:25:56 -03:00
josedonizetti 5f84ae3cd2 Add extractVMDriverVersion documentation 2019-07-04 17:25:56 -03:00
josedonizetti d7a30e118f Fix start_test.go copyright 2019-07-04 17:25:56 -03:00
josedonizetti f61d62647a Add comment about kvm2 force upgrade 2019-07-04 17:25:56 -03:00
josedonizetti dabf272f33 Add warn if kvm driver version is old 2019-07-04 17:25:56 -03:00
Kyle Bai 6505dfad62 Delete kubeconfig when a machine has been deleted 2019-07-04 14:47:41 +08:00
Medya Ghazizadeh 68c546ff1d
Merge pull request #4645 from josedonizetti/fix-profile-flag-indentation
Fix profile flag documentation indentation
2019-07-02 19:06:13 -07:00
Medya Gh d269afef16 better format message 2019-07-01 18:27:00 -07:00
Medya Gh c8876b4675 Exit if none is run without sudo 2019-07-01 18:24:17 -07:00
josedonizetti 18d8ecf519 Simplify `-p` documentation 2019-07-01 18:46:38 -03:00
Medya Ghazizadeh 124b845b60
Merge pull request #4644 from josedonizetti/prefix-kvm-only-flags
Add kvm prefix to flags only used by kvm
2019-07-01 14:43:05 -07:00
Medya Ghazizadeh 2aac268ba6
Merge pull request #4593 from josedonizetti/add-hyperkit-version
Add version to hyperkit driver
2019-07-01 14:38:30 -07:00
Medya Ghazizadeh 449c8781e1
Merge pull request #4595 from blueelvis/memory-size-sanity-check
Added validation for start memory size
2019-06-30 15:17:28 -07:00
josedonizetti a7feb232a1 Fix profile flag documentation indentation 2019-06-29 12:38:32 -03:00
josedonizetti fe3620020a Add kvm prefix to flags only used by kvm 2019-06-29 12:25:36 -03:00
Jose Donizetti 4812761f05 Add gitCommitID to hyperkit version 2019-06-29 09:32:21 -03:00
josedonizetti 931a0a557b Add hyperkit version 2019-06-29 09:22:51 -03:00
Christophe VILA 8cd38956f2 Make virtualbox DNS settings configurable 2019-06-28 16:38:16 -07:00
Jose Donizetti 9dfe660c64 Add support to custom qemu uri on kvm2 driver 2019-06-28 14:12:58 -07:00
Jose Donizetti 8acf4824df Add commit id to docker-machine-driver-kvm2 version 2019-06-28 13:45:54 -07:00
Jituri, Pranav 0305c9d0fa Fixed repeating of messages 2019-06-28 15:30:46 +05:30
Medya Ghazizadeh 886d159a5b
Proxy: handle lower case proxy env vars 2019-06-26 10:33:50 -07:00
Himanshu Pandey 904bc49f71 Added validation for --registry-mirror flag 2019-06-26 10:19:03 -07:00
Francis 6bc977ad04 better service retry logic 2019-06-25 17:28:10 -07:00
Pranav Jituri 6ba1725c08 Added Memory Size Checking 2019-06-26 00:22:41 +05:30
Sharif Elgamal 37239ba83d
Merge pull request #4581 from sharifelgamal/translation-bindata
Add translation files into the minikube binary
2019-06-25 10:19:34 -07:00
Deepjyoti Mondal 8be917f0a5 Display commit id for minikube version 2019-06-25 10:12:55 -07:00
Marcos Diez d58e727512 Merge remote-tracking branch 'origin/master' into dont_disable_container_engines_when_vmdriver_is_none 2019-06-25 13:37:30 -03:00
Medya Gh e35f96d9e0 check error before defer close 2019-06-24 21:09:23 -07:00
Medya Gh 129e2fdb18 Improve readability, defer close api 2019-06-24 20:48:52 -07:00
Sharif Elgamal cab5d30900
outDir is clearer I suppose 2019-06-24 16:19:32 -07:00
Medya Gh 34fda98f4e Improve typecheck for driver options 2019-06-24 15:23:57 -07:00
Sharif Elgamal 8a4776b250
Fixing top level extract call for new translations directory location 2019-06-24 15:18:31 -07:00
Medya Gh c7bf1ce7cd type check for drivers 2019-06-24 14:39:21 -07:00
Medya Ghazizadeh e0c20a4202
Merge pull request #4558 from afbjorklund/reportcard-new
Fix the reportcard: gofmt, golint and gocyclo
2019-06-24 11:44:42 -07:00
Francis 467d8c975f Clean up profile folder after minikube delete 2019-06-24 09:48:25 -07:00
Marcos Diez 820f7984da go fmt 2019-06-24 11:54:20 -03:00
Marcos Diez f802c19eeb making code more readable 2019-06-24 09:31:35 -03:00
Marcos Diez ba20534107 we don't disable other container engines when vmdriver==none 2019-06-24 09:31:35 -03:00
Thomas Strömberg e851619553
Merge pull request #4568 from kubernetes/allow-naked-version
Allow --kubernetes-version to be specified without the leading v
2019-06-24 13:03:34 +08:00
Thomas Strömberg ce74af2d08
Merge pull request #4455 from djmgit/sudo_message
Provide warning message for unnecessary sudo
2019-06-24 12:58:41 +08:00
Thomas Stromberg a9ec145bcb Allow --kubernetes-version to be specified without the leading v 2019-06-24 10:29:09 +08:00
Thomas Stromberg 31354884a5 run goimports 2019-06-23 21:11:42 +08:00
Thomas Stromberg 742dee9e4c Turn console output message into less noisy info message 2019-06-23 21:03:42 +08:00